On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote:
> On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote:
> > From: Xiaoming Ni
> >
> > Move the firmware config sysctl table to fallback_table.c and use the
> > new register_sysctl_subdir() helper. Th
On Fri, May 29, 2020 at 11:13:21AM +0300, Jani Nikula wrote:
> On Fri, 29 May 2020, Luis Chamberlain wrote:
> > Often enough all we need to do is create a subdirectory so that
> > we can stuff sysctls underneath it. However, *if* that directory
> > was already created early
On Thu, Jun 04, 2020 at 09:48:43PM -0700, Bart Van Assche wrote:
> On 2020-06-01 10:05, Luis Chamberlain wrote:
> > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> > index a55cbfd060f5..5b0310f38e11 100644
> > --- a/kernel/trace/blktrace.c
> > ++
On Thu, Jul 11, 2019 at 04:07:27PM -0700, Brendan Higgins wrote:
> On Wed, Jul 3, 2019 at 3:25 PM Luis Chamberlain wrote:
> >
> > On Wed, Jul 03, 2019 at 08:57:58PM +0200, Greg Kroah-Hartman wrote:
> >
> > But again, this is a separate problem. The one I am addressing
On Thu, Aug 01, 2019 at 08:18:01AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Branden wrote:
> > Hi Greg,
> >
> > I am now back from leave to continue this patch. Comment below.
> >
> > On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote:
> > > On Thu, May
On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote:
> diff --git a/Kconfig b/Kconfig
> index 48a80beab6853..10428501edb78 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -30,3 +30,5 @@ source "crypto/Kconfig"
> source "lib/Kconfig"
>
> source "lib/Kconfig.debug"
> +
> +source
On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote:
> +/**
> + * module_test() - used to register a kunit_module with KUnit.
> + * @module: a statically allocated kunit_module.
> + *
> + * Registers @module with the test framework. See kunit_module for
> more
> + * information.
>
On Mon, Jun 17, 2019 at 01:26:12AM -0700, Brendan Higgins wrote:
> From: Iurii Zaikin
>
> KUnit tests for initialized data behavior of proc_dointvec that is
> explicitly checked in the code. Includes basic parsing tests including
> int min/max overflow.
First, thanks for this work! My review
On Tue, Jun 25, 2019 at 05:07:32PM -0700, Brendan Higgins wrote:
> On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote:
> >
> > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote:
> > > +/**
> > > + * module_test() - used to register a kunit_mod
On Thu, Aug 22, 2019 at 12:24:46PM -0700, Scott Branden wrote:
> @@ -923,16 +936,22 @@ EXPORT_SYMBOL_GPL(firmware_request_cache);
> */
> int
> request_firmware_into_buf(const struct firmware **firmware_p, const char
> *name,
> - struct device *device, void *buf, size_t
On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
> On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> > This implies you having to change the other callers, and while currently
> > our list of drivers is small,
>
> Yes, the list is small, very small.
>
&g
On Mon, Sep 30, 2019 at 02:05:22PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 27, 2019 at 11:55:13AM -0600, Tuowen Zhao wrote:
> > Write-combining BAR for intel-lpss-pci in MTRR causes system hangs
> > during boot.
> >
> > This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc
>
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote:
> +EXPORT_SYMBOL(devm_ioremap_uc);
EXPORT_SYMBOL_GPL() would be my preference.
Luis
On Mon, Oct 14, 2019 at 12:57:54PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 14, 2019 at 10:31:50AM +0000, Luis Chamberlain wrote:
> > On Mon, Oct 14, 2019 at 11:29:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Oct 14, 2019 at 09:22:16AM +, Luis Chamberlain wro
On Mon, Oct 14, 2019 at 03:02:03PM +0100, Alan Maguire wrote:
>
>
> On Mon, 14 Oct 2019, Luis Chamberlain wrote:
>
> > On Tue, Oct 08, 2019 at 03:55:43PM +0100, Alan Maguire wrote:
> > > The current kunit execution model is to provide base kunit function
On Mon, Oct 14, 2019 at 03:44:40PM +0100, Matthias Maennich wrote:
> Hi Luis!
>
> On Mon, Oct 14, 2019 at 08:52:35AM +0000, Luis Chamberlain wrote:
> > On Fri, Oct 11, 2019 at 09:26:05PM +0200, Heiner Kallweit wrote:
> > > On 10.10.2019 19:15
On Tue, Oct 15, 2019 at 10:44:34AM +0300, Andy Shevchenko wrote:
> On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> > On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > > -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # save the attached
On Wed, Oct 16, 2019 at 02:37:10PM +0100, Matthias Maennich wrote:
> On Wed, Oct 16, 2019 at 12:50:30PM +0000, Luis Chamberlain wrote:
> > On Mon, Oct 14, 2019 at 03:44:40PM +0100, Matthias Maennich wrote:
> > > Hi Luis!
> > >
> > > On Mon, Oct 14, 2019 at 08:5
On Thu, Oct 17, 2019 at 07:32:18PM +0100, Alan Maguire wrote:
> kunit needs a non-exported global kernel symbol
> (sysctl_hung_task_timeout_secs).
Sounds like a perfect use case for the new symbol namespaces [0]. We
wouldn't want random drivers importing this namespace, but for kunit it
would
On Thu, Oct 17, 2019 at 05:18:16PM -0700, Brendan Higgins wrote:
> From: Mike Salvatore
>
> In order to write the tests against the policy unpacking code, some
> static functions needed to be exposed for testing purposes. One of the
> goals of this patch is to establish a pattern for which
On Wed, Oct 09, 2019 at 09:03:34PM -0600, Tuowen Zhao wrote:
> Implement a resource managed strongly uncachable ioremap function.
>
> Tested-by: AceLan Kao
> Signed-off-by: Tuowen Zhao
> Acked-by: Mika Westerberg
> Acked-by: Andy Shevchenko
Acked-by: Luis Chamberlain
Luis
On Wed, Oct 09, 2019 at 09:03:35PM -0600, Tuowen Zhao wrote:
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch use devm_ioremap_uc to
On Tue, Aug 27, 2019 at 12:40:02PM +0200, Takashi Iwai wrote:
> On Mon, 26 Aug 2019 19:24:22 +0200,
> Scott Branden wrote:
> >
> > I will admit I am not familiar with every subtlety of PCI
> > accesses. Any comments to the Valkyrie driver in this patch series are
> > appreciated.
> > But not all
uct ctl_table {
> ...
>
> Besides the wide use of this proposed cose style, this change helps to
> find at a glance the struct definition when navigating the code.
>
> Signed-off-by: Alessio Balsini
> Cc: Luis Chamberlain
> Cc: Kees Cook
Acked-by: Luis Chamberlain
Luis
On Fri, Oct 04, 2019 at 04:17:33PM -0700, Dmitry Torokhov wrote:
> Hi Hans,
>
> On Fri, Oct 04, 2019 at 04:50:52PM +0200, Hans de Goede wrote:
> > In some cases the platform's main firmware (e.g. the UEFI fw) may contain
> > an embedded copy of device firmware which needs to be (re)loaded into
On Wed, Apr 29, 2020 at 11:49:37AM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 07:46:26AM +0000, Luis Chamberlain wrote:
> > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> > index 5c52976bd762..383045f67cb8 100644
> > --- a/kernel/trace/blktrace.c
&
On Wed, Apr 29, 2020 at 02:57:26PM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 12:21:52PM +0000, Luis Chamberlain wrote:
> > On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote:
> > > On Wed, Apr 29, 2020 at 12:02:30PM +, Luis Chamberlain wrote:
> >
On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote:
> On Fri, May 01, 2020 at 03:06:26PM +0000, Luis Chamberlain wrote:
> > > You have access to a block device here, please use dev_warn() instead
> > > here for that, that makes it obvious as to what
On Fri, May 1, 2020 at 9:40 AM Luis Chamberlain wrote:
>
> On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote:
> > On Fri, May 01, 2020 at 03:06:26PM +, Luis Chamberlain wrote:
> > > > You have access to a block device here, please use dev_war
On Wed, Apr 29, 2020 at 11:50:34AM +0200, Greg KH wrote:
> On Wed, Apr 29, 2020 at 07:46:27AM +0000, Luis Chamberlain wrote:
> > Be pedantic on removal as well and hold the mutex.
> > This should prevent uses of addition while we exit.
> >
> > Signed-off-by: Luis Chambe
On Fri, May 01, 2020 at 05:22:12PM -0700, Bart Van Assche wrote:
> Please fix the spelling errors. Otherwise this patch looks good to me.
Fixed, thanks for the review.
Luis
On Sun, May 03, 2020 at 03:32:45AM -0700, Matthew Wilcox wrote:
> On Fri, May 01, 2020 at 05:22:12PM -0700, Bart Van Assche wrote:
> > > expected behaviour before and it now fails as the device is still present
> >^
> >behavior?
>
> That's UK/US spelling. We do
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Reviewed-by: Greg Kroah-Hartman
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/Makefile | 1 +
block/blk-core.c| 9 +
block/blk-debugfs.c | 15 +++
block/blk.h | 7 +++
4
Stange
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Reported-by: syzbot+603294af2d01acfdd...@syzkaller.appspotmail.com
Fixes: 6ac93117ab00 ("blktrace: use existing disk debugfs directory")
Signed-off-by: Luis Chamberlain
---
block/blk-debugfs.c | 29
-blktrace-fixes
Luis Chamberlain (6):
block: revert back to synchronous request_queue removal
block: move main block debugfs initialization to its own file
blktrace: move blktrace debugfs creation to helper function
blktrace: fix debugfs use after free
blktrace: break out of blktrace
e
Cc: Omar Sandoval
Cc: Hannes Reinecke
Cc: Nicolai Stange
Cc: Greg Kroah-Hartman
Cc: Michal Hocko
Cc: yu kuai
Suggested-by: Nicolai Stange
Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression")
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 23
Be pedantic on removal as well and hold the mutex.
This should prevent uses of addition while we exit.
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index da693e6a834e..6dccba22c9b5
Move the work to create the debugfs directory used into a helper.
It will make further checks easier to read. This commit introduces
no functional changes.
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff
-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 5c52976bd762..383045f67cb8 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -4,6 +4,8 @@
*
*/
+#define
eue() call followed but a put_disk(). And if the
refcount was incremented, we'd still be able to keep the same error
path of blk_cleanup_queue() followed by put_disk().
Signed-off-by: Luis Chamberlain
---
block/genhd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bl
This adds error handling to the *add_disk*() callers and the functions
it depends on. This is initial work as drivers are not converted. That
is separate work.
Signed-off-by: Luis Chamberlain
---
block/blk-integrity.c | 13 ++-
block/blk-sysfs.c | 7 +-
block/blk.h | 5
Move the disk / partition invalidation into a helper. This will make
reading del_gendisk easier to read, in preparation for adding support
to add error handling later on register_disk() and to later share more
code with del_gendisk.
This change has no functional changes.
Signed-off-by: Luis
://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200428-blktrace-fixes
Luis Chamberlain (6):
block: refcount the request_queue early in __device_add_disk()
block: move disk announce work from register_disk() to a helper
block: move disk invalidation from del_gendisk
This moves quite a bit of code which does one thing into a helper.
We currently do not check for errors but we may decide that might
be desirable later.
This also makes the code easier to read.
Signed-off-by: Luis Chamberlain
---
block/genhd.c | 30 +++---
1 file
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers
, but since
del_gendisk() deals with this before queue de-registration we'll
take a hint that's the right order that this should be done, and
we shouldn't instead strictly unwind register_disk() exactly.
We'll instead keep whatever lessons have been learned from
del_gendisk().
Signed-off-by: Luis
On Wed, Apr 29, 2020 at 04:26:37AM -0700, Christoph Hellwig wrote:
> I can't say I'm a fan of all these long backtraces in commit logs..
>
> > +static struct dentry *blk_debugfs_dir_register(const char *name)
> > +{
> > + return debugfs_create_dir(name, blk_debugfs_root);
> > +}
>
> I don't
On Wed, Apr 29, 2020 at 04:50:51AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 11:45:42AM +0000, Luis Chamberlain wrote:
> > On Wed, Apr 29, 2020 at 04:26:37AM -0700, Christoph Hellwig wrote:
> > > I can't say I'm a fan of all these long backtra
On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote:
> > > Err, that function is static and has two callers.
> >
> > Yes but that is to make it easier to look for who is creating the
&g
On Wed, Oct 16, 2019 at 03:06:30PM -0600, Tuowen Zhao wrote:
> Signed-off-by: Tuowen Zhao
Acked-by: Luis Chamberlain
Luis
On Fri, Oct 18, 2019 at 10:31:39AM +0100, Matthias Maennich wrote:
> The introduction of the symbol namespace patches changed the way symbols are
> named in the ksymtab entries. That caused userland tools to fail (such as
> kmod's depmod). As depmod is used as part of the kernel build it was worth
On Wed, Oct 23, 2019 at 11:49:40AM +0100, Matthias Maennich wrote:
> On Fri, Oct 18, 2019 at 12:18:48PM +0000, Luis Chamberlain wrote:
> > On Wed, Oct 16, 2019 at 02:37:10PM +0100, Matthias Maennich wrote:
> > > On Wed, Oct 16, 2019 at 12:50:30PM +, Luis Chamberlain wrote:
&
On Fri, Oct 11, 2019 at 09:26:05PM +0200, Heiner Kallweit wrote:
> On 10.10.2019 19:15, Luis Chamberlain wrote:
> >
> >
> > On Thu, Oct 10, 2019, 6:50 PM Heiner Kallweit > <mailto:hkallwe...@gmail.com>> wrote:
> >
> > MODULE_SOFTDEP(&quo
On Tue, Oct 08, 2019 at 03:55:43PM +0100, Alan Maguire wrote:
> The current kunit execution model is to provide base kunit functionality
> and tests built-in to the kernel. The aim of this series is to allow
> building kunit itself and tests as modules. This in turn allows a
> simple form of
On Mon, Oct 14, 2019 at 12:01:44PM +0200, Jessica Yu wrote:
> +++ Heiner Kallweit [11/10/19 21:26 +0200]:
> > On 10.10.2019 19:15, Luis Chamberlain wrote:
> > >
> > >
> > > On Thu, Oct 10, 2019, 6:50 PM Heiner Kallweit > > <mailto:hkallwe...@gmail.co
On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote:
>
>
> On 23.06.20 16:23, Christian Borntraeger wrote:
> >
> >
> > On 23.06.20 16:11, Christian Borntraeger wrote:
> >> Jens Markwardt reported a regression in the linux-next runs. with "umh:
> >> fix
> >> processed error
On Tue, Jun 23, 2020 at 05:05:01PM +, Johannes Thumshirn wrote:
> On 22/06/2020 14:27, Luis Chamberlain wrote:
> [...]> If you run run_0004.sh from break-blktrace [0]. Even with all my
> patches
> > merged we still run into this. And so the bug lies within the block
> >
On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote:
> Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to
> avoid unneeded instrumentation.
>
> Signed-off-by: Alexander Popov
But why is skipping it safe?
Luis
On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote:
> Add 'verbose' plugin parameter for stackleak gcc plugin.
> It can be used for printing additional info about the kernel code
> instrumentation.
>
> For using it add the following to scripts/Makefile.gcc-plugins:
>
Martin, your eyeballs would be appreciated for a bit on this.
On Wed, Jun 24, 2020 at 12:05:46PM +, Luis Chamberlain wrote:
> On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote:
> >
> >
> > On 23.06.20 16:23, Christian Borntraeger wrote:
> > >
On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote:
>
>
> On 24.06.20 16:43, Christoph Hellwig wrote:
> > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote:
> >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC
> >> is used" breaks
On Wed, Jun 24, 2020 at 01:17:25PM +, Luis Chamberlain wrote:
> I found however an LTP bug indicating the need to test for
> s390 wait macros [0] in light of a recent bug in glibc for s390.
> I am asking for references to that issue given I cannot find
> any mention of this
On Thu, Jun 25, 2020 at 10:02:21PM +0200, Wolfram Sang wrote:
> The doubled 'however' is confusing. Simplify the comment a little and
> reformat the paragraph.
>
> Signed-off-by: Wolfram Sang
Acked-by: Luis Chamberlain
Luis
m/linux/kernel/git/palmer/linux.git -b
> generic-devmem .
Reviewed-by: Luis Chamberlain
Luis
On Thu, Jul 09, 2020 at 09:31:37PM -0700, Kees Cook wrote:
> On Thu, Jul 09, 2020 at 04:51:15PM -0700, Julius Hemanth Pitti wrote:
> > protected_* files have 600 permissions which prevents
> > non-superuser from reading them.
> >
> > Container like "AWS greengrass" refuse to launch unless
> >
Long ago Takashi had some points about this strategy breaking
compressed file use. Was that considered?
Luis
On Fri, Jul 24, 2020 at 02:36:39PM -0700, Kees Cook wrote:
> From: Scott Branden
>
> Add request_partial_firmware_into_buf() to allow for portions of a
> firmware file to be read into
nges here]
> - fix issues in firmware test suite
> - add firmware partial read patches
> - various bug fixes/cleanups
> v1:
> https://lore.kernel.org/lkml/20200717174309.1164575-1-keesc...@chromium.org/
For patches 1-10:
Reviewed-by: Luis Chamberlain
Luis
On Mon, May 18, 2020 at 08:21:08AM -0700, Kees Cook wrote:
> On Mon, May 18, 2020 at 08:37:42AM -0400, Mimi Zohar wrote:
> > Hi Christoph,
> >
> > On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote:
> > > On Fri, May 15, 2020 at 09:29:33PM +, Luis Cha
review on the
recent blktrace fixes [0].
[0]
https://lore.kernel.org/linux-block/20200415123434.gu11...@42.do-not-panic.com/
Reported-by: Christoph Hellwig
Cc: Jan Kara
Cc: Ming Lei
Cc: Bart Van Assche
Cc: Christoph Hellwig
Signed-off-by: Luis Chamberlain
---
This goes tested against
On Tue, Feb 5, 2019 at 2:07 PM Luis Chamberlain wrote:
> In lieu of no Luke Skywalker, if you will, for a large kconfig revamp
> on this, I'm inclined to believe *at least* having some kconfig_symb
> exposed for some modules is better than nothing. Christoph are you
> tot
On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote:
> On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote:
> > There is no real problem merging ioends that go beyond i_size into an
> > ioend that doesn't. We just need to move the append transaction to the
> > base
On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote:
>
> On Wed, Jun 26, 2019 at 03:21:08PM -0700, Luis Chamberlain wrote:
> > On Tue, Feb 5, 2019 at 2:07 PM Luis Chamberlain wrote:
> > > In lieu of no Luke Skywalker, if you will, for a large kconfig revamp
> &
On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote:
> On Tue, Jun 25, 2019 at 12:10:20PM +0200, Christoph Hellwig wrote:
> > On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote:
> > > I'm a little concerned this is going to limit what we can do
> > > with the XFS IO path because
On Tue, Jun 04, 2019 at 11:27:51PM +0800, Zhiqiang Liu wrote:
> > On Wed, May 15, 2019 at 10:53:55PM +0800, Zhiqiang Liu wrote:
> In proc_dointvec_jiffies func, the write value is only checked
> whether it is larger than INT_MAX. If the write value is less
> than zero, it can also
On Sat, Jun 29, 2019 at 10:42:57AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 28, 2019 at 11:40:22AM -0700, Luis Chamberlain wrote:
> > On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote:
> > >
> > > On Wed, Jun 26, 2019 at 03:21:08PM -0700, Luis Chamberlain w
On Wed, Jul 03, 2019 at 09:40:48AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 02, 2019 at 08:51:06PM +0000, Luis Chamberlain wrote:
> > On Sat, Jun 29, 2019 at 10:42:57AM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Jun 28, 2019 at 11:40:22AM -0700, Luis Chamberlain wro
On Wed, Jul 03, 2019 at 02:16:44PM +0200, Enrico Weigelt, metux IT consult
wrote:
> On 28.06.19 20:40, Luis Chamberlain wrote:
>
> Hi folks,
>
> > The solution puts forward a mechanism to add a kconfig_symb where
> > we are 100% certain we have a direct module --
On Wed, Jul 03, 2019 at 08:57:58PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 03, 2019 at 04:50:20PM +0000, Luis Chamberlain wrote:
> > On Wed, Jul 03, 2019 at 09:40:48AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jul 02, 2019 at 08:51:06PM +, Luis Chamberlain wro
On Wed, Jul 03, 2019 at 09:31:33PM +0200, Enrico Weigelt, metux IT consult
wrote:
> On 03.07.19 19:35, Luis Chamberlain wrote:
>
> Hi,
>
> >> Okay, but IIRC this will add more boilerplate those modules.
> >
> > Just one module attribute.
>
> Yes
Please re-state the main fix in the commit log, not just the subject.
Also, this does not explain why the current values are and the impact to
systems / users. This would help in determine and evaluating if this
deserves to be a stable fix.
On Fri, Jul 05, 2019 at 06:30:21PM +0200, Radoslaw
Please Cc Andrew Morton on future follow
ups.
On Sat, Jul 06, 2019 at 12:19:16AM +0200, Radoslaw Burny wrote:
> On Fri, Jul 5, 2019 at 10:02 PM Luis Chamberlain wrote:
> >
> >
> > Please re-state the main fix in the commit log, not just the subject.
>
> Sure, I'll
Sorry for the late review... Ah!
On Tue, Jun 11, 2019 at 02:26:25PM +0200, Takashi Iwai wrote:
> @@ -354,7 +454,12 @@ module_param_string(path, fw_path_para,
> sizeof(fw_path_para), 0644);
> MODULE_PARM_DESC(path, "customized firmware image search path with a higher
> priority than default
On Mon, May 04, 2020 at 12:08:55PM -0700, Kees Cook wrote:
> Just as a precaution, make sure that proc handlers don't accidentally
> grow "count" beyond the allocated kbuf size.
>
> Signed-off-by: Kees Cook
> ---
> This applies to hch's sysctl cleanup tree...
> ---
> fs/proc/proc_sysctl.c | 3
On Mon, May 04, 2020 at 01:32:07PM -0700, Kees Cook wrote:
> On Mon, May 04, 2020 at 07:59:37PM +0000, Luis Chamberlain wrote:
> > On Mon, May 04, 2020 at 12:08:55PM -0700, Kees Cook wrote:
> > > Just as a precaution, make sure that proc handlers don't accidentally
> &g
f_stats_handler'
> [-Werror,-Wunused-function]
> static int bpf_stats_handler(struct ctl_table *table, int write,
>
> Fix the check to match the reference.
>
> Fixes: d46edd671a14 ("bpf: Sharing bpf runtime stats with BPF_ENABLE_STATS")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Luis Chamberlain
Luis
On Tue, May 05, 2020 at 01:41:44PM -0700, Kees Cook wrote:
> On Tue, May 05, 2020 at 08:34:41AM +0200, Greg KH wrote:
> > On Mon, May 04, 2020 at 09:59:03PM +0000, Luis Chamberlain wrote:
> > > On Mon, May 04, 2020 at 01:32:07PM -0700, Kees Cook wrote:
> > > > On M
On Fri, May 15, 2020 at 12:17:52AM +0800, Xiaoming Ni wrote:
> On 2020/5/14 14:05, Xiaoming Ni wrote:
> > On 2020/5/13 20:50, Luis Chamberlain wrote:
> > > On Wed, May 13, 2020 at 12:04:02PM +0800, Xiaoming Ni wrote:
> > > > On 2020/5/13 6:03, Luis Chamberlain wrote:
fdput(). Refine
> the code path a bit for it to read more clearly.
> Reference: 22f96b3808c1 ("fs: add sync_file_range() helper")
>
> Signed-off-by: Shuah Khan
Reviewed-by: Luis Chamberlain
Luis
On Fri, May 15, 2020 at 09:03:54AM -0700, Kees Cook wrote:
> On Fri, May 15, 2020 at 04:56:34PM +0800, Xiaoming Ni wrote:
> > On 2020/5/15 16:04, Kees Cook wrote:
> > > On Fri, May 15, 2020 at 12:33:41PM +0800, Xiaoming Ni wrote:
> > > > Move hung_task sysctl interface to hung_task_sysctl.c.
> > >
nduced crashes by writes to sysctl interface
> /proc/sys/kernel/tainted causing false positive hits for such policies.
>
> Suggested-by: Qian Cai
> Signed-off-by: Rafael Aquini
Reviewed-by: Luis Chamberlain
Luis
On Thu, May 14, 2020 at 05:53:41PM +0300, Igor Russkikh wrote:
> >
> > So do you mean like the changes below?
> >
> > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > index f4eebaabb6d0..95cb7da2542e 100644
> > ---
On Wed, May 13, 2020 at 11:35:06AM -0700, Scott Branden wrote:
> On 2020-05-12 5:33 p.m., Luis Chamberlain wrote:
> > On Thu, May 07, 2020 at 05:27:34PM -0700, Scott Branden wrote:
> > flags? But its a single variable enum!
> fw_opt is an existing enum which doesn't reall
On Wed, May 13, 2020 at 12:23:59PM -0400, Mimi Zohar wrote:
> Hi Scott,
>
> On Thu, 2020-05-07 at 17:27 -0700, Scott Branden wrote:
> > Please consider this version series ready for upstream acceptance.
> >
> > This patch series adds partial read support in request_firmware_into_buf.
> > In
to annotate when this happens clearly.
Cc: "Michael S. Tsirkin"
Cc: Shannon Nelson
Cc: Jakub Kicinski
Cc: Heiner Kallweit
Signed-off-by: Luis Chamberlain
---
drivers/net/ethernet/8390/axnet_cs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/eth
to annotate when this happens clearly.
Cc: Ariel Elior
Cc: Sudarsana Kalluru
CC: gr-everest-linux...@marvell.com
Signed-off-by: Luis Chamberlain
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
to annotate when this happens clearly.
Cc: Douglas Miller
Signed-off-by: Luis Chamberlain
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c
b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 0273fb7a9d01
-next tag next-20200515. You can find
these changes on my tree:
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200515-taint-firmware-net
Luis Chamberlain (15):
taint: add module firmware crash taint support
ethernet/839: use new module_firmware_crashed()
bnx2x
to annotate when this happens clearly.
Cc: linux-wirel...@vger.kernel.org
Cc: Lennert Buytenhek
Cc: Kalle Valo
Cc: "Gustavo A. R. Silva"
Cc: Johannes Berg
Cc: Ganapathi Bhat
Signed-off-by: Luis Chamberlain
---
drivers/net/wireless/marvell/mwl8k.c | 1 +
1 file changed, 1 insertion(+)
to annotate when this happens clearly.
Cc: linux-wirel...@vger.kernel.org
Cc: ath...@lists.infradead.org
Cc: Kalle Valo
Signed-off-by: Luis Chamberlain
---
drivers/net/wireless/ath/ath6kl/hif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath6kl/hif.c
b/drivers/net
to annotate when this happens clearly.
Cc: Vishal Kulkarni
Signed-off-by: Luis Chamberlain
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index
101 - 200 of 575 matches
Mail list logo