[PATCH v2 12/15] ath10k: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3

[PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa

[PATCH v2 09/15] qed: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Ariel Elior Cc: gr-everest-linux...@marvell.com Reviewed-by: Igor Russkikh Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: > Can you also move kernel_read_* out of fs.h? That header gets pulled > in just about everywhere and doesn't really need function not related > to the general fs interface. Sure, where should I dump these? Luis

[PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wi...@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01

[PATCH v2 06/15] liquidio: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Reviewed-by: Derek Chickles Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio

[PATCH v2 04/15] bnxt: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

[PATCH v2 14/15] brcm80211: use new module_firmware_crashed()

ieter-Paul Giesberts Signed-off-by: Luis Chamberlain --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d6

[PATCH v2 05/15] bna: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: gr-linux-nic-...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net

[PATCH v2 01/15] taint: add module firmware crash taint support

in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- Documentation/admin-guide/tainted-kernels.rst | 6 ++ include/linux/kernel.h| 3 ++- include/linux/module.h| 13

Re: [PATCH v5 0/7] firmware: add partial read support in request_firmware_into_buf

On Fri, May 15, 2020 at 04:28:08PM -0700, Scott Branden wrote: > Hi Luis, > > On 2020-05-15 1:47 p.m., Luis Chamberlain wrote: > > On Wed, May 13, 2020 at 12:23:59PM -0400, Mimi Zohar wrote: > > > Hi Scott, > > > > > > On Thu, 2020-05-07 at 17:27

Re: [PATCH v4 4/5] blktrace: break out of blktrace setup on concurrent calls

On Mon, May 11, 2020 at 7:39 AM Luis Chamberlain wrote: > > On Sat, May 09, 2020 at 06:09:38PM -0700, Bart Van Assche wrote: > > How about using the block device name instead of the partition name in > > the error message since the concurrency context is the block device and >

[PATCH v5 0/7] block: fix blktrace debugfs use after free

sed on linux-next tag next-20200515, and can also be found on my git tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200515-blktrace-fixes Luis Chamberlain (7): block: add docs for gendisk / request_queue refcount helpers block: clarify context fo

[PATCH v5 1/7] block: add docs for gendisk / request_queue refcount helpers

This adds documentation for the gendisk / request_queue refcount helpers. Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Signed-off-by: Luis Chamberlain --- block/blk-core.c | 13 + block/genhd.c| 50 +++- 2 files

[PATCH v5 2/7] block: clarify context for gendisk / request_queue refcount increment helpers

, but will be addressed in the next patch. Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Signed-off-by: Luis Chamberlain --- block/blk-core.c | 2 ++ block/genhd.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/block/blk-core.c b/block/blk-core.c index e438c3b0815b

[PATCH v5 4/7] block: move main block debugfs initialization to its own file

Cc: Greg Kroah-Hartman Cc: Michal Hocko Cc: yu kuai Reviewed-by: Greg Kroah-Hartman Reviewed-by: Bart Van Assche Signed-off-by: Luis Chamberlain --- block/Makefile | 10 +++--- block/blk-core.c| 9 + block/blk-debugfs.c | 15 +++ block/blk.h | 8

[PATCH v5 5/7] blktrace: fix debugfs use after free

: 6ac93117ab00 ("blktrace: use existing disk debugfs directory") Signed-off-by: Luis Chamberlain --- block/blk-debugfs.c | 182 +++ block/blk-mq-debugfs.c | 5 - block/blk-sysfs.c| 3 + block/blk.h | 16 +++

[PATCH v5 3/7] block: revert back to synchronous request_queue removal

d-by: Nicolai Stange Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression") Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Signed-off-by: Luis Chamberlain --- block/blk-core.c | 8 block/blk-sysfs.c | 43 +

[PATCH v5 6/7] blktrace: break out of blktrace setup on concurrent calls

-off-by: Luis Chamberlain --- kernel/trace/blktrace.c | 13 + 1 file changed, 13 insertions(+) diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 6c10a1427de2..ac6650828d49 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -3,6 +3,9 @@ * Copyright

[PATCH v5 7/7] loop: be paranoid on exit and prevent new additions / removals

Be pedantic on removal as well and hold the mutex. This should prevent uses of addition while we exit. Reviewed-by: Ming Lei Signed-off-by: Luis Chamberlain --- drivers/block/loop.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index

[PATCH v4 0/5] block: fix blktrace debugfs use after free

: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200508-block-fixes Luis Chamberlain (5): block: revert back to synchronous request_queue removal block: move main block debugfs initialization to its own file blktrace: fix debugfs use after free blktrace

[PATCH v4 4/5] blktrace: break out of blktrace setup on concurrent calls

-off-by: Luis Chamberlain --- kernel/trace/blktrace.c | 9 + 1 file changed, 9 insertions(+) diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 6c10a1427de2..bd5ec2184d46 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -3,6 +3,9 @@ * Copyright (C

[PATCH v4 2/5] block: move main block debugfs initialization to its own file

Cc: Greg Kroah-Hartman Cc: Michal Hocko Cc: yu kuai Reviewed-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Bart Van Assche Signed-off-by: Luis Chamberlain --- block/Makefile | 1 + block/blk-core.c| 9 + block/blk-debugfs.c | 15 +++ block

[PATCH v4 3/5] blktrace: fix debugfs use after free

yzkaller.appspotmail.com Fixes: 6ac93117ab00 ("blktrace: use existing disk debugfs directory") Signed-off-by: Luis Chamberlain --- block/blk-debugfs.c | 187 +++ block/blk-mq-debugfs.c | 5 - block/blk-sysfs.c| 3

[PATCH v4 5/5] loop: be paranoid on exit and prevent new additions / removals

Be pedantic on removal as well and hold the mutex. This should prevent uses of addition while we exit. I cannot trigger an issue with this though, this is just a fix done through code inspection. Reviewed-by: Ming Lei Signed-off-by: Luis Chamberlain --- drivers/block/loop.c | 4 1 file

[PATCH v4 1/5] block: revert back to synchronous request_queue removal

e Cc: Omar Sandoval Cc: Hannes Reinecke Cc: Nicolai Stange Cc: Greg Kroah-Hartman Cc: Michal Hocko Cc: yu kuai Suggested-by: Nicolai Stange Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression") Reviewed-by: Christoph Hellwig Signed-off-by: Luis Chamberlain --

Re: [RFC v1 0/6] block: add error handling for *add_disk*()

On Tue, May 05, 2020 at 06:18:22PM -0700, Bart Van Assche wrote: > On 2020-04-29 00:48, Luis Chamberlain wrote: > > While working on some blktrace races I noticed that we don't do > > error handling on *add_disk*() and friends. This is my initial > > work on that. > >

Re: [PATCH v2] kernel: add panic_on_taint

On Fri, May 08, 2020 at 08:47:19AM -0400, Rafael Aquini wrote: > On Thu, May 07, 2020 at 10:25:58PM +0000, Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 06:06:06PM -0400, Rafael Aquini wrote: > > > On Thu, May 07, 2020 at 08:33:40PM +, Luis Chamberlain wrote

[PATCH 00/15] net: taint when the device driver firmware crashes

ound on my git tree as well: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200509-taint-firmware-net Luis Chamberlain (15): taint: add module firmware crash taint support ethernet/839: use new module_firmware_crashed() bnx2x: use new module_firmware_crashed()

[PATCH 13/15] ath6kl: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net

[PATCH 05/15] bna: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: gr-linux-nic-...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net

[PATCH 14/15] brcm80211: use new module_firmware_crashed()

ieter-Paul Giesberts Signed-off-by: Luis Chamberlain --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d6

[PATCH 09/15] qed: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Ariel Elior Cc: gr-everest-linux...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic

[PATCH 02/15] ethernet/839: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: "Michael S. Tsirkin" Cc: Shannon Nelson Cc: Jakub Kicinski Cc: Heiner Kallweit Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/eth

[PATCH 06/15] liquidio: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net

[PATCH 03/15] bnx2x: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Ariel Elior Cc: Sudarsana Kalluru CC: gr-everest-linux...@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

[PATCH 11/15] wimax/i2400m: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wi...@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01

[PATCH 07/15] cxgb4: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index

[PATCH 10/15] soc: qcom: ipa: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa

[PATCH 08/15] ehea: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01

[PATCH 15/15] mwl8k: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 04/15] bnxt: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

[PATCH 01/15] taint: add module firmware crash taint support

in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- include/linux/kernel.h| 3 ++- include/linux/module.h| 13 + include/trace/events/module.h | 3 ++- kernel/module.c | 5 +++-- kernel

[PATCH 12/15] ath10k: use new module_firmware_crashed()

to annotate when this happens clearly. Cc: linux-wirel...@vger.kernel.org Cc: ath...@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

sometimes requires a driver unload / reload and in the worst cases > > a reboot. > > > > Using a taint flag allows us to annotate when this happens clearly. > > > > Cc: Ariel Elior > > Cc: gr-everest-linux...@marvell.com > > Signed-off-by: Luis Cham

Re: [PATCH 01/15] taint: add module firmware crash taint support

On Sat, May 09, 2020 at 11:18:29AM -0400, Rafael Aquini wrote: > We are still missing the documentation bits for this > new flag, though. Ah yeah sorry about that. > How about having a blurb similar to: > > diff --git a/Documentation/admin-guide/tainted-kernels.rst >

Re: [PATCH v4 4/5] blktrace: break out of blktrace setup on concurrent calls

On Sat, May 09, 2020 at 06:09:38PM -0700, Bart Van Assche wrote: > On 2020-05-08 20:10, Luis Chamberlain wrote: > > @@ -493,6 +496,12 @@ static int do_blk_trace_setup(struct request_queue *q, > > char *name, dev_t dev, > > */ > > strreplace(buts->name,

Re: [PATCH v4 1/5] block: revert back to synchronous request_queue removal

On Sun, May 10, 2020 at 08:20:58AM +0200, Greg KH wrote: > On Sat, May 09, 2020 at 03:10:54AM +0000, Luis Chamberlain wrote: > > Commit dc9edc44de6c ("block: Fix a blk_exit_rl() regression") merged on > > v4.12 moved the work behind blk_release_queue() into a workqueue

Re: [PATCH v4 3/5] blktrace: fix debugfs use after free

On Sat, May 09, 2020 at 05:58:55PM -0700, Bart Van Assche wrote: > On 2020-05-08 20:10, Luis Chamberlain wrote: > > Screenshots of what the debugfs for block looks like after running > > blktrace on a system with sg0 which has a raid controllerand then sg1 > > as the media ch

Re: [PATCH v4 3/5] blktrace: fix debugfs use after free

On Sun, May 10, 2020 at 08:26:36AM +0200, Greg KH wrote: > On Sat, May 09, 2020 at 03:10:56AM +0000, Luis Chamberlain wrote: > > diff --git a/block/blk-debugfs.c b/block/blk-debugfs.c > > index 19091e1effc0..d40f12aecf8a 100644 > > --- a/block/blk-debugfs.c > >

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

On Sat, May 09, 2020 at 11:35:46AM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 04:35:37 +0000 Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > &g

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

On Sat, May 09, 2020 at 07:15:23PM -0700, Shannon Nelson wrote: > On 5/9/20 6:58 PM, Andrew Lunn wrote: > > On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: > > As for firmware, how much damage can the firmware do as it crashed? If > > it is a DMA master, it could of splattered

Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

On Wed, May 13, 2020 at 08:50:46AM +0200, Greg Kroah-Hartman wrote: > On Tue, May 12, 2020 at 11:31:28PM -0700, Scott Branden wrote: > > Hi Luis, > > > > On 2020-05-12 5:38 p.m., Luis Chamberlain wrote: > > > On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Brand

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Wed, May 13, 2020 at 12:04:02PM +0800, Xiaoming Ni wrote: > On 2020/5/13 6:03, Luis Chamberlain wrote: > > On Tue, May 12, 2020 at 12:40:55PM -0500, Eric W. Biederman wrote: > > > Luis Chamberlain writes: > > > > > > > On Tue, May 12, 2020 at 06

Re: [PATCH v2 2/2] fs: avoid fdput() after failed fdget() in kernel_read_file_from_fd()

On Wed, May 13, 2020 at 06:49:50AM +0100, Al Viro wrote: > On Tue, May 12, 2020 at 01:43:05PM -0600, Shuah Khan wrote: > > diff --git a/fs/exec.c b/fs/exec.c > > index 06b4c550af5d..ea24bdce939d 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -1021,8 +1021,8 @@ int

Re: [PATCH v3 5/5] lib/test_sysctl: support testing of sysctl. boot parameter

On Wed, May 13, 2020 at 10:58:16AM +0200, Vlastimil Babka wrote: > On 5/11/20 8:31 PM, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 01:05:22PM +0200, Vlastimil Babka wrote: > >> 8< > >> From a999e993a89e521b152bbd4b1466f69e62879c30 Mon Sep 17 00:00:00 2

Re: [PATCH v3 5/5] lib/test_sysctl: support testing of sysctl. boot parameter

On Wed, May 13, 2020 at 7:15 AM Luis Chamberlain wrote: > > On Wed, May 13, 2020 at 10:58:16AM +0200, Vlastimil Babka wrote: > > On 5/11/20 8:31 PM, Luis Chamberlain wrote: > > > On Mon, May 11, 2020 at 01:05:22PM +0200, Vlastimil Babka wrote: > >

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Wed, May 13, 2020 at 08:42:30AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > On Tue, May 12, 2020 at 12:40:55PM -0500, Eric W. Biederman wrote: > >> Luis Chamberlain writes: > >> > >> > On Tue, May 12, 2020 at 06:52:35AM -0

Re: [PATCH v2 2/2] fs: avoid fdput() after failed fdget() in kernel_read_file_from_fd()

On Wed, May 13, 2020 at 7:13 AM Luis Chamberlain wrote: > > On Wed, May 13, 2020 at 06:49:50AM +0100, Al Viro wrote: > > On Tue, May 12, 2020 at 01:43:05PM -0600, Shuah Khan wrote: > > > diff --git a/fs/exec.c b/fs/exec.c > > > index 06b4c550af5d..ea24bdce939

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Wed, May 13, 2020 at 09:44:40AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > On Wed, May 13, 2020 at 08:42:30AM -0500, Eric W. Biederman wrote: > >> Luis Chamberlain writes: > >> > >> > On Tue, May 12, 2020 at 12:40:55PM -0

[PATCH 1/3] fs: unexport kernel_read_file()

There are no modular uses of kernel_read_file(), so just unexport it. Suggested-by: Al Viro Signed-off-by: Luis Chamberlain --- fs/exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/exec.c b/fs/exec.c index 23dc2b45d590..9791b9eef9ce 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -988,7

[PATCH 3/3] fs: move kernel_read*() calls to its own symbol namespace

Signed-off-by: Luis Chamberlain --- drivers/base/firmware_loader/main.c | 1 + fs/exec.c | 6 +++--- kernel/kexec_file.c | 2 ++ kernel/module.c | 1 + security/integrity/digsig.c | 3 +++ security/integrity/ima/ima_fs.c

[PATCH 0/3] fs: reduce export usage of kerne_read*() calls

-kernel-read-sym Luis Chamberlain (3): fs: unexport kernel_read_file() security: add symbol namespace for reading file data fs: move kernel_read*() calls to its own symbol namespace drivers/base/firmware_loader/fallback.c | 1 + drivers/base/firmware_loader/main.c | 1 + fs/exec.c

[PATCH 2/3] security: add symbol namespace for reading file data

of operations happen as a whole. Signed-off-by: Luis Chamberlain --- drivers/base/firmware_loader/fallback.c | 1 + fs/exec.c | 2 ++ kernel/kexec.c | 2 ++ kernel/module.c | 2 ++ security/security.c

Re: [PATCH v4] kernel: add panic_on_taint

On Wed, May 13, 2020 at 11:00:26AM -0400, Rafael Aquini wrote: > Analogously to the introduction of panic_on_warn, this patch > introduces a kernel option named panic_on_taint in order to > provide a simple and generic way to stop execution and catch > a coredump when the kernel gets tainted by

Re: [PATCH 2/3] security: add symbol namespace for reading file data

On Wed, May 13, 2020 at 10:40:31AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > Certain symbols are not meant to be used by everybody, the security > > helpers for reading files directly is one such case. Use a symbol > > namespace for them. > &g

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

On Wed, May 13, 2020 at 05:20:14PM -0400, Mimi Zohar wrote: > On Wed, 2020-05-13 at 12:41 -0700, Scott Branden wrote: > > > > On 2020-05-13 12:39 p.m., Mimi Zohar wrote: > > > On Wed, 2020-05-13 at 12:18 -0700, Scott Branden wrote: > > >> On 2020-05-13 12:03 p.m., Mimi Zohar wrote: > > >>> On

Re: [PATCH linux-kselftest/test v1] apparmor: add AppArmor KUnit tests for policy unpack

On Sat, Oct 19, 2019 at 01:56:01PM +0100, Alan Maguire wrote: > On Fri, 18 Oct 2019, Luis Chamberlain wrote: > > > On Thu, Oct 17, 2019 at 05:18:16PM -0700, Brendan Higgins wrote: > > > From: Mike Salvatore > > > > > > In order to write the tests

Re: [PATCH v2] mm: expland documentation over __read_mostly

On Tue, May 8, 2018 at 12:19 PM Luis R. Rodriguez wrote: > > __read_mostly can easily be misused by folks, its not meant for > just read-only data. There are performance reasons for using it, but > we also don't provide any guidance about its use. Provide a bit more > guidance over it use. > >

[PATCH] mm: expland documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Acked-by: Christoph Lameter Signed-off-by: Luis Chamberlain --- I sent

Re: [PATCH] kernel: add panic_on_taint

On Wed, May 06, 2020 at 06:28:15PM -0400, Rafael Aquini wrote: > Analogously to the introduction of panic_on_warn, this patch > introduces a kernel option named panic_on_taint in order to > provide a simple and generic way to stop execution and catch > a coredump when the kernel gets tainted by

Re: [PATCH v3] kernel: add panic_on_taint

On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > +Trigger Kdump on add_taint() > + > + > +The kernel parameter, panic_on_taint, calls panic() from within add_taint(), > +whenever the value set in this bitmask matches with the bit flag being set > +by

Re: [PATCH v4 0/4] Fix some issues about kmod

On Mon, May 11, 2020 at 08:59:37PM +0800, Tiezhu Yang wrote: > Hi, > > Could you please apply the following three patches? > > [v4,1/4] selftests: kmod: Use variable NAME in kmod_test_0001() > https://lore.kernel.org/patchwork/patch/1227980/ > > [v4,2/4] kmod: Remove redundant "be an" in the

Re: [PATCH v3 5/5] lib/test_sysctl: support testing of sysctl. boot parameter

On Mon, May 11, 2020 at 01:05:22PM +0200, Vlastimil Babka wrote: > > On 4/27/20 8:39 PM, Luis Chamberlain wrote: > > On Mon, Apr 27, 2020 at 08:04:33PM +0200, Vlastimil Babka wrote: > > Nice, also we could just require > > > > diff --git a/tools/testing/selfte

Re: [PATCH v3] kernel: add panic_on_taint

On Mon, May 11, 2020 at 04:03:25PM -0400, Rafael Aquini wrote: > On Mon, May 11, 2020 at 06:24:55PM +0000, Luis Chamberlain wrote: > > On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > > > +Trigger Kdump on add_taint() > > > +===

Re: [PATCH] kernel: sysctl: ignore invalid taint bits introduced via kernel.tainted and taint the kernel with TAINT_USER on writes

On Mon, May 11, 2020 at 05:59:04PM -0400, Rafael Aquini wrote: > The sysctl knob allows any user with SYS_ADMIN capability to > taint the kernel with any arbitrary value, but this might > produce an invalid flags bitset being committed to tainted_mask. > > This patch introduces a simple way for

Re: [PATCH] kernel: sysctl: ignore invalid taint bits introduced via kernel.tainted and taint the kernel with TAINT_USER on writes

On Mon, May 11, 2020 at 07:59:14PM -0400, Rafael Aquini wrote: > On Mon, May 11, 2020 at 11:10:45PM +0000, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 05:59:04PM -0400, Rafael Aquini wrote: > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > > index 8a176d

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Mon, May 11, 2020 at 09:55:16AM +0800, Xiaoming Ni wrote: > On 2020/5/11 9:11, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the vfs tree got a conflict in: > > > >kernel/sysctl.c > > > > between commit: > > > >b6522fa409cf ("parisc: add sysctl file

Re: [PATCH] kernel: sysctl: ignore invalid taint bits introduced via kernel.tainted and taint the kernel with TAINT_USER on writes

On Mon, May 11, 2020 at 09:03:13PM -0400, Rafael Aquini wrote: > On Tue, May 12, 2020 at 12:17:03AM +0000, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 07:59:14PM -0400, Rafael Aquini wrote: > > > On Mon, May 11, 2020 at 11:10:45PM +, Luis Chamberlain wrote: > >

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Mon, May 11, 2020 at 10:22:04PM -0700, Kees Cook wrote: > On Tue, May 12, 2020 at 12:33:05AM +0000, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 09:55:16AM +0800, Xiaoming Ni wrote: > > > On 2020/5/11 9:11, Stephen Rothwell wrote: > > > > Hi all, > > &

Re: [PATCH] kernel: sysctl: ignore invalid taint bits introduced via kernel.tainted and taint the kernel with TAINT_USER on writes

On Tue, May 12, 2020 at 10:49:06AM -0400, Rafael Aquini wrote: > On Tue, May 12, 2020 at 05:04:05AM +0000, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 09:03:13PM -0400, Rafael Aquini wrote: > > > On Tue, May 12, 2020 at 12:17:03AM +, Luis Chamberlain wrote: > >

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Tue, May 12, 2020 at 06:52:35AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > On Mon, May 11, 2020 at 09:55:16AM +0800, Xiaoming Ni wrote: > >> On 2020/5/11 9:11, Stephen Rothwell wrote: > >> > Hi all, > >> > > >> >

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

On Tue, May 12, 2020 at 07:23:28PM +0300, Igor Russkikh wrote: > > >> So I think its not a good place to insert this call. > >> Its hard to find exact good place to insert it in qed. > > > > Is there a way to check if what happened was indeed a fw crash? > > Our driver has two firmwares

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

On Tue, May 12, 2020 at 12:40:55PM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > On Tue, May 12, 2020 at 06:52:35AM -0500, Eric W. Biederman wrote: > >> Luis Chamberlain writes: > >> > >> &

Re: [PATCH] kernel: sysctl: ignore out-of-range taint bits introduced via kernel.tainted

es a simple way for proc_taint() to ignore > any eventual invalid bit coming from the user input before > committing those bits to the kernel tainted_mask. > > Signed-off-by: Rafael Aquini Acked-by: Luis Chamberlain Luis

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

On Thu, May 07, 2020 at 05:27:33PM -0700, Scott Branden wrote: > diff --git a/fs/exec.c b/fs/exec.c > index 06b4c550af5d..cfab212fab9d 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -896,10 +896,14 @@ struct file *open_exec(const char *name) > } > EXPORT_SYMBOL(open_exec); > > -int

Re: [PATCH v5 2/7] firmware: add offset to request_firmware_into_buf

On Thu, May 07, 2020 at 05:27:34PM -0700, Scott Branden wrote: > Add offset to request_firmware_into_buf to allow for portions > of firmware file to be read into a buffer. Necessary where firmware > needs to be loaded in portions from file in memory constrained systems. > > Signed-off-by: Scott

Re: [PATCH v5 3/7] test_firmware: add partial read support for request_firmware_into_buf

On Thu, May 07, 2020 at 05:27:35PM -0700, Scott Branden wrote: > Add additional hooks to test_firmware to pass in support > for partial file read using request_firmware_into_buf. > buf_size: size of buffer to request firmware into > partial: indicates that a partial file request is being made >

Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: > +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) > + > +#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ > +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf_priv > +int

Re: [PATCH v2] kernel: sysctl: ignore out-of-range taint bits introduced via kernel.tainted

tainted_mask. > > Signed-off-by: Rafael Aquini Reviewed-by: Luis Chamberlain Luis

[PATCH v2] mm: expand documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over its use. Acked-by: Christoph Lameter Signed-off-by: Luis Chamberlain

Re: [PATCH v2] kernel: add panic_on_taint

On Thu, May 07, 2020 at 02:06:31PM -0400, Rafael Aquini wrote: > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 8a176d8727a3..b80ab660d727 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1217,6 +1217,13 @@ static struct ctl_table kern_table[] = { > .extra1

Re: [PATCH v2] kernel: add panic_on_taint

On Thu, May 07, 2020 at 02:06:31PM -0400, Rafael Aquini wrote: > Another, perhaps less frequent, use for this option would be > as a mean for assuring a security policy (in paranoid mode) > case where no single taint is allowed for the running system. If used for this purpose then we must add a

Re: [PATCH v2] kernel: add panic_on_taint

On Thu, May 07, 2020 at 02:47:05PM -0400, Rafael Aquini wrote: > On Thu, May 07, 2020 at 02:43:16PM -0400, Rafael Aquini wrote: > > On Thu, May 07, 2020 at 06:22:57PM +0000, Luis Chamberlain wrote: > > > On Thu, May 07, 2020 at 02:06:31PM -0400, Rafael Aquini wrote: > >

Re: [PATCH v2] kernel: add panic_on_taint

On Thu, May 07, 2020 at 06:06:06PM -0400, Rafael Aquini wrote: > On Thu, May 07, 2020 at 08:33:40PM +0000, Luis Chamberlain wrote: > > I *think* that a cmdline route to enable this would likely remove the > > need for the kernel config for this. But even with Vlastimil's work >

[RFC] taint: add module firmware crash taint support

or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain --- Below is the full diff stat of manual inspection throughout the kernel when this happens. My methodology is to just scrape for "crash" and then study the driver a bit to see if indeed it

Re: [RFC] taint: add module firmware crash taint support

On Fri, May 08, 2020 at 02:14:38AM +, Luis Chamberlain wrote: > Device driver firmware can crash, and sometimes, this can leave your > system in a state which makes the device or subsystem completely > useless. Detecting this by inspecting /proc/sys/kernel/tainted instead > of s

Re: [PATCH 1/2] fs: avoid fdput() after failed fdget() in ksys_sync_file_range()

On Fri, May 08, 2020 at 01:24:22AM +0100, Al Viro wrote: > On Fri, May 08, 2020 at 01:05:09AM +0100, Al Viro wrote: > > On Thu, May 07, 2020 at 05:57:09PM -0600, Shuah Khan wrote: > > > Fix ksys_sync_file_range() to avoid fdput() after a failed fdget(). > > > fdput() doesn't do fput() on this file

Re: [RFC] taint: add module firmware crash taint support

On Thu, May 07, 2020 at 10:47:08PM -0700, Kees Cook wrote: > On Fri, May 08, 2020 at 02:14:38AM +0000, Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > &g

Re: [RFC] taint: add module firmware crash taint support

On Fri, May 08, 2020 at 08:11:24AM +0200, Daniel Vetter wrote: > On Fri, May 08, 2020 at 02:14:38AM +0000, Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > &g

<    1   2   3   4   5   6   >