On Sat, May 16, 2020 at 03:24:01PM +0200, Johannes Berg wrote:
> On Fri, 2020-05-15 at 21:28 +0000, Luis Chamberlain wrote:>
> module_firmware_crashed
>
> You didn't CC me or the wireless list on the rest of the patches, so I'm
> replying to a random one, but ...
>
>
On Sat, May 16, 2020 at 03:50:55PM +0200, Johannes Berg wrote:
> On Sat, 2020-05-16 at 15:24 +0200, Johannes Berg wrote:
>
> > Instead of the kernel taint, IMHO you should provide an annotation in
> > sysfs (or somewhere else) for the *struct device* that had its firmware
> > crash. Or maybe, if
On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote:
>
>
> On 05/18/2020 09:51 AM, Luis Chamberlain wrote:
> > On Sat, May 16, 2020 at 03:24:01PM +0200, Johannes Berg wrote:
> > > On Fri, 2020-05-15 at 21:28 +, Luis Chamberlain wrote:>
> > > modu
On Mon, May 18, 2020 at 11:59:53AM +0800, Xiaoming Ni wrote:
> Kernel/sysctl.c contains more than 190 interface files, and there are a
> large number of config macro controls. When modifying the sysctl
> interface directly in kernel/sysctl.c, conflicts are very easy to occur.
> E.g:
On Mon, May 18, 2020 at 10:15:45AM -0700, Ben Greear wrote:
>
>
> On 05/18/2020 10:09 AM, Luis Chamberlain wrote:
> > On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote:
> > >
> > >
> > > On 05/18/2020 09:51 AM, Luis Chamberlain wrote:
> &
On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote:
> On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote:
> > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make
> > it const, in the same way as cap_last_cap.
> >
> > Signed-off-by: Stephen Kitt
>
>
On Mon, May 18, 2020 at 11:17:47AM -0700, Kees Cook wrote:
> On Mon, May 18, 2020 at 05:25:09PM +0000, Luis Chamberlain wrote:
> > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote:
> > > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote:
> > > &
On Mon, May 18, 2020 at 11:06:27AM -0700, Steve deRosier wrote:
> On Mon, May 18, 2020 at 10:19 AM Luis Chamberlain wrote:
> > From a support perspective it is a *crystal* clear sign that the device
> > and / or device driver may be in a very bad state, in a generic way.
> &g
On Mon, May 18, 2020 at 09:25:09PM +0200, Johannes Berg wrote:
> On Mon, 2020-05-18 at 19:09 +0000, Luis Chamberlain wrote:
>
> > > Unfortunately a "taint" is interpreted by many users as: "your kernel
> > > is really F#*D up, you better do something abou
On Mon, May 18, 2020 at 10:07:49PM +0200, Johannes Berg wrote:
> On Mon, 2020-05-18 at 19:59 +0000, Luis Chamberlain wrote:
>
> > > Err, no. Those two are most definitely related. Have you looked at (most
> > > or some or whatever) staging drivers recently?
On Mon, May 18, 2020 at 01:46:43PM -0700, Jakub Kicinski wrote:
> On Mon, 18 May 2020 22:41:48 +0200 Johannes Berg wrote:
> > On Mon, 2020-05-18 at 13:35 -0700, Jakub Kicinski wrote:
> > > It's intended to be a generic netlink channel for configuring devices.
> > >
> > > All the firmware-related
I like this, more below.
On Tue, Jun 09, 2020 at 08:06:02AM -0700, Christoph Hellwig wrote:
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 432fa60e7f8808..44239f603379d5 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -492,34 +493,23 @@ static
On Tue, Jun 09, 2020 at 07:08:17PM +0200, Christoph Hellwig wrote:
> Hi Al,
>
> two more fixes for the kernel pointers in the sysctl handlers.
Acked-by: Luis Chamberlain
Luis
On Tue, Jun 09, 2020 at 10:32:18AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 09, 2020 at 05:29:22PM +0000, Luis Chamberlain wrote:
> > Is scsi-generic is the only unwanted ugly child blktrace has to deal
> > with? For some reason I thought drivers/md/md.c was one but it
On Mon, May 11, 2020 at 12:28 PM Luis Chamberlain wrote:
>
> On Mon, May 11, 2020 at 08:59:37PM +0800, Tiezhu Yang wrote:
> > Hi,
> >
> > Could you please apply the following three patches?
> >
> > [v4,1/4] selftests: kmod: Use variable NAME in kmod_tes
On Wed, Jun 10, 2020 at 10:16:09AM +0200, Borislav Petkov wrote:
>
> Also, I'm working on removing that homegrown get_builtin_firmware() and
> use the one in the fw loader:
>
> https://lkml.kernel.org/r/20200408094526.gc24...@zn.tnic
I would like to still encourage this, even with this patch in
On Wed, Jun 10, 2020 at 03:46:50PM +0200, Borislav Petkov wrote:
> On Wed, Jun 10, 2020 at 01:12:09PM +0000, Luis Chamberlain wrote:
> > On Wed, Jun 10, 2020 at 10:16:09AM +0200, Borislav Petkov wrote:
> > >
> > > Also, I'm working on removing that homegrown get_built
On Tue, Jun 09, 2020 at 11:42:34PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 09, 2020 at 05:53:59PM +0000, Luis Chamberlain wrote:
> > > Feel free to add more comments, but please try to keep them short
> > > and crisp. At the some point long comments really distract fro
So, upon updating the commit log, and moving the empty directory check
into another patch, I realized we might be able to simplify this now even
further still. Patch below. The key of the issue was that the use after free
happens when a recursive removal happens, and then later a specific
dentry
On Wed, Jun 10, 2020 at 09:52:13PM +, Luis Chamberlain wrote:
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 7ff2ea5cd05e..5cea04c05e09 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -524,10 +524,16 @@ static int do_blk_tra
On Thu, Jul 02, 2020 at 01:26:53PM +0900, Tetsuo Handa wrote:
> On 2020/07/02 0:38, Luis Chamberlain wrote:
> > @@ -156,6 +156,18 @@ static void call_usermodehelper_exec_sync(struct
> > subprocess_info *sub_info)
> > */
> >
On Fri, Jul 03, 2020 at 09:52:01AM +0900, Tetsuo Handa wrote:
> On 2020/07/03 4:46, Luis Chamberlain wrote:
> > The alternative to making a compromise is using generic wrappers for
> > things which make sense and letting the callers use those.
>
> I suggest just intr
On Thu, Jul 02, 2020 at 01:32:21PM +1000, Herbert Xu wrote:
> On Tue, Jun 30, 2020 at 02:18:11PM +0530, Naresh Kamboju wrote:
> >
> > Since we are on this subject,
> > LTP af_alg02 test case fails on stable 4.9 and stable 4.4
> > This is not a regression because the test case has been failing
On Fri, Jun 26, 2020 at 02:22:11PM -0700, Brendan Higgins wrote:
> On Fri, Jun 26, 2020 at 2:20 PM Kees Cook wrote:
> >
> > On Fri, Jun 26, 2020 at 02:09:06PM -0700, Brendan Higgins wrote:
> > > Add a linker section where KUnit can put references to its test suites.
> > > This patch is the first
Brendan Higgins
> Reviewed-by: Stephen Boyd
Other than that:
Reviewed-by: Luis Chamberlain
Luis
On Sat, Jun 27, 2020 at 09:33:03AM -0700, Linus Torvalds wrote:
> The real problem with
> "set_fs()" has been that we've occasionally had bugs where we ended up
> running odd paths that we really didn't _intend_ to run with kernel
> pointers. The classic example is the SCSI "write as ioctl"
On Mon, Jun 29, 2020 at 02:55:05PM -0500, Eric W. Biederman wrote:
>
> I have tested thes changes by booting with the code compiled in and
> by killing "bpfilter_umh" and running iptables -vnL to restart
> the userspace driver.
>
> I have compiled tested each change with and without
On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote:
> Now that the last callser has been removed remove this code from exec.
>
> For anyone thinking of resurrecing do_execve_file please note that
> the code was buggy in several fundamental ways.
>
> - It did not ensure the file it
On Fri, Jul 03, 2020 at 11:43:28AM -0700, Kees Cook wrote:
> Make sure we don't regress the CAP_SYSLOG behavior of the module address
> visibility via /proc/modules nor /sys/module/*/sections/*.
>
> Cc: Luis Chamberlain
> Cc: Shuah Khan
> Cc: linux-kselft...@vger.kerne
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Acked-by: Luis Chamberlain
Shuah, can this go through your tree?
Luis
> ---
> tools/testing/selftests/kmod/kmod.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote:
> Hi,
>
> On 7/8/20 1:01 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 7/7/20 10:19 AM, Kees Cook wrote:
> > > Hi,
> > >
> > > In looking for closely at the additions that got made to the
> > > kernel_read_file() enums, I noticed that
On Wed, Jul 08, 2020 at 06:35:25AM +, Luis Chamberlain wrote:
> On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote:
> > Now that the last callser has been removed remove this code from exec.
> >
> > For anyone thinking of resurrecing do_execve_file please n
On Wed, Jul 08, 2020 at 01:58:47PM +0200, Hans de Goede wrote:
> Hi,
>
> On 7/8/20 1:55 PM, Luis Chamberlain wrote:
> > On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 7/8/20 1:01 PM, Hans de Goede wrote:
>
On Wed, Jul 08, 2020 at 08:08:09AM -0500, Eric W. Biederman wrote:
> Luis Chamberlain writes:
>
> > On Wed, Jul 08, 2020 at 06:35:25AM +, Luis Chamberlain wrote:
> >> On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote:
> >> > Now that the las
On Fri, Jun 26, 2020 at 02:54:10AM +, Luis Chamberlain wrote:
> On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote:
> >
> >
> > On 24.06.20 20:32, Christian Borntraeger wrote:
> > [...]>
> > > So the translations look correct
On Wed, Jul 01, 2020 at 07:04:15PM +0900, Tetsuo Handa wrote:
> I suspect commit 9e9b47d6bbe9df65 ("umh: fix processed error when
> UMH_WAIT_PROC is used").
> Maybe the change in kernel/umh.c and/or security/keys/request_key.c made by
> that commit is
> affecting call_usermodehelper_keys() == 0
On Wed, Jul 01, 2020 at 12:08:11PM +0200, Christian Borntraeger wrote:
> dmesg attached
> [ 14.438482] virbr0: port 1(virbr0-nic) entered blocking state
> [ 14.438485] virbr0: port 1(virbr0-nic) entered disabled state
> [ 14.438635] device virbr0-nic entered promiscuous mode
> [ 14.439654]
On Wed, Jul 01, 2020 at 10:24:29PM +0900, Tetsuo Handa wrote:
> On 2020/07/01 19:08, Christian Borntraeger wrote:
> >
> >
> > On 30.06.20 19:57, Luis Chamberlain wrote:
> >> On Fri, Jun 26, 2020 at 02:54:10AM +, Luis Chamberlain wrote:
> >>>
On Wed, Jul 01, 2020 at 11:08:57PM +0900, Tetsuo Handa wrote:
> On 2020/07/01 22:53, Luis Chamberlain wrote:
> >> Well, it is not br_stp_call_user() but br_stp_start() which is expecting
> >> to set sub_info->retval for both KWIFEXITED() case and KWIFSIGNALED() case.
> &
On Wed, Jul 01, 2020 at 05:48:48PM +0200, Christian Borntraeger wrote:
>
>
> On 01.07.20 17:38, Luis Chamberlain wrote:
> > On Wed, Jul 01, 2020 at 11:08:57PM +0900, Tetsuo Handa wrote:
> >> On 2020/07/01 22:53, Luis Chamberlain wrote:
> >>>> Well, it is
On Fri, Jul 03, 2020 at 08:44:47PM -0700, Randy Dunlap wrote:
> Drop the doubled word "for".
>
> Signed-off-by: Randy Dunlap
> Cc: Jonathan Corbet
> Cc: linux-...@vger.kernel.org
> Cc: Luis Chamberlain
> Cc: Greg Kroah-Hartman
For all the firmware pa
On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote:
>
>
> On 24.06.20 20:32, Christian Borntraeger wrote:
> [...]>
> > So the translations look correct. But your change is actually a sematic
> > change
> > if(ret) will only trigger if there is an error
> > if
On Fri, Jun 26, 2020 at 10:00:01AM +0100, Christoph Hellwig wrote:
> On Fri, Jun 26, 2020 at 07:22:34AM +0200, Christian Borntraeger wrote:
> >
> >
> > On 26.06.20 04:54, Luis Chamberlain wrote:
> > > On Wed, Jun 24, 2020 at 08:37:55PM +020
On Fri, Jun 26, 2020 at 11:40:08AM +, Luis Chamberlain wrote:
> Andrew, can you please revert these two for now:
>
> selftests: simplify kmod failure value
> umh: fix processed error when UMH_WAIT_PROC is used
>
> Later, we'll add Christoph's simplier kernel wait, a
On Fri, Jun 26, 2020 at 09:58:29AM +0200, Christoph Hellwig wrote:
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 28d6105e908e4c..fa86619cebc2be 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -297,6 +297,29 @@ static loff_t proc_reg_llseek(struct file *file, loff_t
>
On Fri, Jun 26, 2020 at 09:58:33AM +0200, Christoph Hellwig wrote:
> From: "Matthew Wilcox (Oracle)"
>
> This error path returned directly instead of calling sysctl_head_finish().
And if the commit log can say why this was bad. Found through code
inspection from what I recall right?
Luis
On Fri, Jun 26, 2020 at 09:58:35AM +0200, Christoph Hellwig wrote:
> diff --git a/fs/read_write.c b/fs/read_write.c
> index e765c95ff3440d..ae463bcadb6906 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -420,6 +420,18 @@ ssize_t iter_read(struct file *filp, char __user *buf,
> size_t
On Sat, Jun 20, 2020 at 10:11:46AM -0700, Bart Van Assche wrote:
> On 2020-06-19 13:47, Luis Chamberlain wrote:
> > Be pedantic on removal as well and hold the mutex.
> > This should prevent uses of addition while we exit.
> >
> > Reviewed-by: Ming Lei
> &g
On Sat, Jun 20, 2020 at 10:31:51AM -0700, Bart Van Assche wrote:
> On 2020-06-19 13:47, Luis Chamberlain wrote:
> > This goes tested with:
>
>got?
>
> > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> > index 7ff2ea5cd05e..e6e2d2
On Sat, Jun 20, 2020 at 11:07:43AM -0700, Bart Van Assche wrote:
> On 2020-06-19 13:47, Luis Chamberlain wrote:
> > We were only creating the request_queue debugfs_dir only
> > for make_request block drivers (multiqueue), but never for
> > request-based block drivers. We did
On Tue, Jun 23, 2020 at 12:04:06AM +0530, Naresh Kamboju wrote:
> LTP crypto regressions noticed on linux next 20200621.
>
> The common case for all tests is timeout after 15 minutes which
> means tests got hung and LTP timers killed those test runs after
> timeout.
> The root cause of the
On Fri, Jun 12, 2020 at 07:42:12PM -0700, Bart Van Assche wrote:
> On 2020-06-08 10:01, Luis Chamberlain wrote:
> > + /*
> > +* Blktrace needs a debugfs name even for queues that don't register
> > +* a gendisk, so it lazily registers the debugfs directory. But th
On Fri, Jun 12, 2020 at 06:53:40PM -0700, Bart Van Assche wrote:
> On 2020-06-08 10:01, Luis Chamberlain wrote:
> > + * Drivers exist which depend on the release of the request_queue to be
> > + * synchronous, it should not be deferred.
>
> This sounds mysterious.
On Wed, Jun 17, 2020 at 05:43:48PM -0700, Andrew Morton wrote:
> On Wed, 10 Jun 2020 15:49:18 + "Luis R. Rodriguez"
> wrote:
>
> > Tiezhu Yang had sent out a patch set with a slew of kmod selftest
> > fixes, and one patch which modified kmod to return 254 when a module
> > was not found.
This adds documentation for the gendisk / request_queue refcount
helpers.
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 13 +
block/genhd.c| 50 +++-
2 files
Be pedantic on removal as well and hold the mutex.
This should prevent uses of addition while we exit.
Reviewed-by: Ming Lei
Reviewed-by: Christoph Hellwig
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/block/loop.c b
t;James E.J. Bottomley"
Cc: yu kuai
Reported-by: syzbot+603294af2d01acfdd...@syzkaller.appspotmail.com
Fixes: 6ac93117ab00 ("blktrace: use existing disk debugfs directory")
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 18 --
1 file changed, 12 inse
of the blktrace context.
Signed-off-by: Luis Chamberlain
---
block/blk-core.c| 8 +-
block/blk-mq-debugfs.c | 5
block/blk-sysfs.c | 9 +++
block/blk.h | 2 --
include/linux/blkdev.h | 5 ++--
kernel/trace/blktrace.c | 58
, but will be addressed in the next patch.
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 2 ++
block/genhd.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/block/blk-core.c b/block/blk-core.c
index a0760aac110a
Ensure it is clear which lock is required on do_blk_trace_setup().
Suggested-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 7f60029bdaff..7ff2ea5cd05e
typically aren't checked for, and we have
maintainers doing sweep removals of these checks, but since we need this
check to ensure proper userspace blktrace functionality we make sure
to annotate the justification for the check.
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 12
d-by: Nicolai Stange
Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression")
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 8
block/blk-sysfs.c | 43 +
these, to let 0-day give me its blessings,
both for Linus' tree and linux-next. No issues have been found. I've
also taken time to run blktests prior and after this series and I have
found no regressions. In fact, I think I should just extend blktests
with the break-blktrace tests, I'll do that later.
Luis
Sorry it seems mutt ate my To:, so adding the folks I intended to
address on the To: field now :)
Luis
On Fri, Jun 19, 2020 at 08:46:26PM +, Luis Chamberlain wrote:
> On Wed, Jun 17, 2020 at 05:43:48PM -0700, Andrew Morton wrote:
> > On Wed, 10 Jun 2020 15:49:18 + "Lui
On Thu, Jun 18, 2020 at 04:46:27PM +0200, Christoph Hellwig wrote:
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -1626,6 +1626,22 @@ long kernel_wait4(pid_t upid, int __user *stat_addr,
> int options,
> return ret;
> }
>
> +int kernel_wait(pid_t pid, int *stat)
> +{
> + struct
On Sat, Jun 20, 2020 at 08:35:38AM +0200, Christoph Hellwig wrote:
> On Fri, Jun 19, 2020 at 09:17:00PM +0000, Luis Chamberlain wrote:
> > On Thu, Jun 18, 2020 at 04:46:27PM +0200, Christoph Hellwig wrote:
> > > --- a/kernel/exit.c
> > > +++ b/kernel/exit.c
> &
On Tue, May 19, 2020 at 06:42:31PM +0200, Jessica Yu wrote:
> +++ Luis Chamberlain [15/05/20 21:28 +]:
> > Device driver firmware can crash, and sometimes, this can leave your
> > system in a state which makes the device or subsystem completely
> > useless. Detecting thi
On Tue, May 19, 2020 at 02:15:30PM -0700, Jakub Kicinski wrote:
> Add infra for creating devlink instances for a device to report
Thanks for doing this series as a PoC, counter to the module_firmware_crash()
which I proposed to taint the kernel with a firmware crash flag to the kernel
and module.
On Fri, May 22, 2020 at 08:12:59AM +0300, Emmanuel Grumbach wrote:
> >
> > On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach
> > wrote:
> > > So I believe we already have this uevent, it is the devcoredump. All
> > > we need is to add the unique id.
> >
> > I think there are a few reasons that
On Tue, May 19, 2020 at 05:34:13PM -0500, Alex Elder wrote:
> On 5/15/20 4:28 PM, Luis Chamberlain wrote:
> > This makes use of the new module_firmware_crashed() to help
> > annotate when firmware for device drivers crash. When firmware
> > crashes devices can sometime
00608-blktrace-fixes
Luis Chamberlain (6):
block: add docs for gendisk / request_queue refcount helpers
block: clarify context for refcount increment helpers
block: revert back to synchronous request_queue removal
blktrace: annotate required lock on do_blk_trace_setup()
loop: be paranoid
, but will be addressed in the next patch.
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 2 ++
block/genhd.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/block/blk-core.c b/block/blk-core.c
index a0760aac110a
This adds documentation for the gendisk / request_queue refcount
helpers.
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 13 +
block/genhd.c| 50 +++-
2 files
Be pedantic on removal as well and hold the mutex.
This should prevent uses of addition while we exit.
Reviewed-by: Ming Lei
Reviewed-by: Christoph Hellwig
Signed-off-by: Luis Chamberlain
---
drivers/block/loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/block/loop.c b
Ensure it is clear which lock is required on do_blk_trace_setup().
Suggested-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
kernel/trace/blktrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 7f60029bdaff..7ff2ea5cd05e
d-by: Nicolai Stange
Fixes: dc9edc44de6c ("block: Fix a blk_exit_rl() regression")
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 8
block/blk-sysfs.c | 43 +
acfdd...@syzkaller.appspotmail.com
Fixes: 6ac93117ab00 ("blktrace: use existing disk debugfs directory")
Signed-off-by: Luis Chamberlain
---
block/blk-core.c | 4 ---
block/blk-mq-debugfs.c | 5
block/blk-sysfs.c| 40 +++
bloc
On Mon, Jun 22, 2020 at 07:16:15PM -0700, Bart Van Assche wrote:
> On 2020-06-22 05:27, Luis Chamberlain wrote:
> > Note: this will bring you sanity if you try to figure out *why* we still
> > get:
> >
> > [235530.144343] debugfs: Directory 'loop0' with parent '
Bart suggested we add docs for the degugfs_mutex, while at it I noticed
we don't have a nice way to add docs for members of the request_queue so
I figured I'd add one as I drive by.
Come bike shed with me.
Luis Chamberlain (2):
block: add initial kdoc over the request_queue
block: move
Now that we have a template, expand on the kdoc form for
the request_queue data structure with documentation from
the rest of the members, *only* for information we already
had.
This does not add any new documentation. This just shifts
documentation to kdoc form.
Signed-off-by: Luis Chamberlain
We start off with an initial description of the request_queue data
structure, followed by describing the purpose of the debugfs_mutex
debugfs_dir, and blk_trace.
Suggested-by: Bart Van Assche
Signed-off-by: Luis Chamberlain
---
include/linux/blkdev.h | 20
1 file changed
I've started to give some love towards XFS stable maintenance, the first
results of that work went in v4.19.21. I'd like to review what I use to
track the stable kernel baselines, oscheck [0], to avoid regressions,
and show how this can also easily be used to track any distribution
baselines as
On Wed, Feb 13, 2019 at 04:17:13PM -0800, Brendan Higgins wrote:
> On Wed, Feb 13, 2019 at 1:55 PM Kieran Bingham
> wrote:
> Oh, yep, you are right. Does that mean we should bother at all with a
> defconfig?
If one wanted a qemu enabled type of kernel and also for kuniut one
could imply run:
On Wed, Feb 13, 2019 at 07:17:59AM -0500, Mimi Zohar wrote:
> Require signed kernel modules on systems with secure boot mode enabled.
>
> Requiring appended kernel module signatures may be configured, enabled
> on the boot command line, or with this patch enabled in secure boot
> mode.
But only
On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote:
> diff --git a/kernel/module.c b/kernel/module.c
> index 2ad1b5239910..70a9709d19eb 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -275,16 +275,23 @@ static void module_assert_mutex_or_preempt(void)
>
> static bool
Small nit below.
On Wed, Jan 30, 2019 at 01:52:38PM -0500, Waiman Long wrote:
> diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
>
> +nr_negative shows the number of unused dentries that are also
> +negative dentries which do not mapped to actual files.
On Mon, Feb 04, 2019 at 05:05:10PM -0500, Mimi Zohar wrote:
> On Mon, 2019-02-04 at 12:38 -0800, Luis Chamberlain wrote:
> > On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote:
> > > diff --git a/kernel/module.c b/kernel/module.c
> > > index 2ad1b5
On Mon, Feb 04, 2019 at 05:28:00PM -0500, Waiman Long wrote:
> On 02/04/2019 05:23 PM, Luis Chamberlain wrote:
> > Small nit below.
> >
> > On Wed, Jan 30, 2019 at 01:52:38PM -0500, Waiman Long wrote:
> >> diff --git a/Documentation/sysctl/fs.txt
On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuank...@codeaurora.org wrote:
> Hi,
>
> Refined at below.
>
> From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001
This is all garbled, not sure why your patch looks all messed up.
Are you using git sendemail or something manual?
On Thu, Nov 29, 2018 at 8:31 PM Luis Chamberlain wrote:
>
> On Mon, Nov 26, 2018 at 09:12:16PM -0600, Dan Rue wrote:
> > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y is required for fw_fallback.sh.
> > Without it, fw_fallback.sh fails with 'usermode helper disabled so
> >
On Tue, Dec 25, 2018 at 12:14:57AM +0900, Masahiro Yamada wrote:
> The whole code of fallback_table.c is surrounded by #ifdef of
> CONFIG_FW_LOADER_USER_HELPER.
>
> Move the CONFIG_FW_LOADER_USER_HELPER switch to Makefile so that
> it is not compiled at all when this CONFIG is turned off.
>
> I
On Mon, Feb 04, 2019 at 08:41:50PM -0600, Dan Rue wrote:
> On Mon, Feb 04, 2019 at 05:39:57PM -0600, Luis Chamberlain wrote:
> > On Thu, Nov 29, 2018 at 8:31 PM Luis Chamberlain wrote:
> > >
> > > On Mon, Nov 26, 2018 at 09:1
On Tue, Feb 05, 2019 at 07:24:39AM -0500, Mimi Zohar wrote:
> On Mon, 2019-02-04 at 14:30 -0800, Luis Chamberlain wrote:
> > On Mon, Feb 04, 2019 at 05:05:10PM -0500, Mimi Zohar wrote:
> > > On Mon, 2019-02-04 at 12:38 -0800, Luis Chamberlain wrote:
>
> > > I don'
On Thu, Aug 25, 2016 at 2:19 PM Luis R. Rodriguez wrote:
>
> On Thu, Aug 25, 2016 at 09:43:13AM +0200, Christoph Hellwig wrote:
> > The idea seems useful, but I reallt don't like the 'reverse-engineering'
> > approach.
> >
> > If we want to this properly from the ground up we should just split
On Mon, Jan 28, 2019 at 10:05:45AM -0800, Andrew Morton wrote:
> On Mon, 28 Jan 2019 09:49:59 +0100 Vincent Whitchurch
> wrote:
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1242,6 +1242,20 @@ config SYSCTL_SYSCALL
> >
> > If unsure say N here.
> >
> > +config
Thanks for the patches, please include a...@linux-foundation.org in the
future, as we can merge the changes through Andrew as well.
Also please Cc yzai...@google.com, brendanhigg...@google.com in follow
ups for now. They are looking at the sysctl testing code as well.
Some feedback below:
On Thu, Dec 27, 2018 at 05:12:30AM -0600, Zev Weiss wrote:
> do_proc_do[u]intvec_minmax_conv() had included open-coded versions of
> do_proc_do[u]intvec_conv(), though the signed one omitted the check
> that the value is in [INT_MIN, INT_MAX]. Rather than increase the
> duplication further by
On Thu, Feb 07, 2019 at 06:34:23AM -0600, Zev Weiss wrote:
> Hello,
>
> After being left with an unusable system after a typo executing
> something like 'echo $((1<<24)) > /proc/sys/vm/max_map_count', I found
> that do_proc_dointvec_minmax_conv() was missing a check to ensure that
> the converted
On Wed, Dec 5, 2018 at 2:43 PM Dan Rue wrote:
>
> On Thu, Nov 29, 2018 at 06:37:32PM -0800, Luis Chamberlain wrote:
> > On Mon, Nov 26, 2018 at 09:12:15PM -0600, Dan Rue wrote:
> > > diff -Z is used to trim the trailing whitespace when comparing the
> > > loaded
On Mon, Nov 12, 2018 at 05:01:42PM +0100, Lucas Stach wrote:
> Device drivers with optional firmware may still want to use the
> asynchronous firmware loading interface. To avoid printing a
> warining into the kernel log when the optional firmware is
> absent, add a nowarn variant of this
301 - 400 of 575 matches
Mail list logo
