There is also a typo in Makefile which causes a modules.livepatch file
to be created in kernel sources even in case of building an external
module.
> diff --git a/Makefile b/Makefile
> index 2fdd8b40b7e0..459b9c9fe0a8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1185,6 +1185,7 @@ PHONY += prepar
Hi,
> > Do we have anything that blocks klp-convert-mini to be merged, or something
> > that
> > needs to be fixed?
>
> there is feedback from Petr and I agree with him that a selftest would be
> appropriate.
>
> Lukas, are you planning to send v2 with everything addressed?
Yes, I definitely
Summary
---
This is a significantly simplified version of the original klp-convert tool.
The klp-convert code has never got a proper review and also clean ups
were not easy. The last version was v7, see
https://lore.kernel.org/r/20230306140824.3858543-1-joe.lawre...@redhat.com
The main change
From: Josh Poimboeuf
Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
replacing hard-coded values in kernel/livepatch/core.c.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
Reviewed-by: Marcos Paulo de Souza
---
MAINTAINERS
From: Josh Poimboeuf
Call klp-convert for the livepatch modules after the final linking.
Also update the modpost tool so that it does not warn about unresolved
symbols matching the expected format which will be then resolved by
klp-convert.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas
tly support the compilation of the new tool,
update MAINTAINERS file and add a .gitignore file.
[jpoim...@redhat.com: initial version]
Signed-off-by: Josh Poimboeuf
[joe.lawre...@redhat.com: clean-up and fixes]
Signed-off-by: Joe Lawrence
[lhru...@suse.cz: klp-convert code, minimal approach]
Signed
function cmdline_proc_show to print the
string referenced by the symbol saved_command_line appended by the
string "livepatch=1".
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
---
samples/livepatch/Makefile | 1 +
samples/livepatch
Add a section to Documentation/livepatch/module-elf-format.rst
describing how klp-convert works for fixing relocations.
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
Reviewed-by: Marcos Paulo de Souza
---
Documentation/livepatch/module-elf-format.rst | 67 +++
1 file
The test proves that klp-convert works as intended and it is possible to
livepatch a function that use an external symbol.
Signed-off-by: Lukas Hruska
---
.../testing/selftests/livepatch/functions.sh | 16 +-
.../selftests/livepatch/test-extern.sh| 57
Summary
---
This is a significantly simplified version of the original klp-convert tool.
The klp-convert code has never got a proper review and also clean ups
were not easy. The last version was v7, see
https://lore.kernel.org/r/20230306140824.3858543-1-joe.lawre...@redhat.com
The main chan
From: Josh Poimboeuf
Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
replacing hard-coded values in kernel/livepatch/core.c.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
---
MAINTAINERS| 1 +
include/uapi/linux/livepatch.h | 15
tly support the compilation of the new tool,
update MAINTAINERS file and add a .gitignore file.
[jpoim...@redhat.com: initial version]
Signed-off-by: Josh Poimboeuf
[joe.lawre...@redhat.com: clean-up and fixes]
Signed-off-by: Joe Lawrence
[lhru...@suse.cz: klp-convert code, minimal appr
From: Josh Poimboeuf
Update the modpost program so that it does not warn about unresolved
symbols matching the expected format which will be then resolved by
klp-convert.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
---
.gitignore| 1 +
Makefile
function cmdline_proc_show to print the
string referenced by the symbol saved_command_line appended by the
string "livepatch=1".
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
---
samples/livepatch/Makefile| 1 +
.../livepatch/livepatch-annotated-sample
Add a section to Documentation/livepatch/module-elf-format.rst
describing how klp-convert works for fixing relocations.
Signed-off-by: Lukas Hruska
---
Documentation/livepatch/module-elf-format.rst | 67 +++
1 file changed, 67 insertions(+)
diff --git a/Documentation/livepatch
Hello Joe,
> > +#define KLP_RELOC_SYMBOL_POS(LP_OBJ_NAME, SYM_OBJ_NAME, SYM_NAME, SYM_POS)
> > \
> > + asm("\".klp.sym.rela." #LP_OBJ_NAME "." #SYM_OBJ_NAME "." #SYM_NAME ","
> > #SYM_POS "\"")
>
> ^^^
> I think I foun
From: Josh Poimboeuf
Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
replacing hard-coded values in kernel/livepatch/core.c.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
Reviewed-by: Marcos Paulo de Souza
---
MAINTAINERS
Summary
---
This is a significantly simplified version of the original klp-convert tool.
The klp-convert code has never got a proper review and also clean ups
were not easy. The last version was v7, see
https://lore.kernel.org/r/20230306140824.3858543-1-joe.lawre...@redhat.com
The main change
From: Josh Poimboeuf
Call klp-convert for the livepatch modules after the final linking.
Also update the modpost tool so that it does not warn about unresolved
symbols matching the expected format which will be then resolved by
klp-convert.
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas
tly support the compilation of the new tool,
update MAINTAINERS file and add a .gitignore file.
[jpoim...@redhat.com: initial version]
Signed-off-by: Josh Poimboeuf
[joe.lawre...@redhat.com: clean-up and fixes]
Signed-off-by: Joe Lawrence
[lhru...@suse.cz: klp-convert code, minimal approach]
Signed-off-b
function cmdline_proc_show to print the
string referenced by the symbol saved_command_line appended by the
string "livepatch=1".
Signed-off-by: Josh Poimboeuf
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
---
samples/livepatch/Makefile | 1 +
samples/livepatch
Add a section to Documentation/livepatch/module-elf-format.rst
describing how klp-convert works for fixing relocations.
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
Reviewed-by: Marcos Paulo de Souza
---
Documentation/livepatch/module-elf-format.rst | 67 +++
1 file
The test proves that klp-convert works as intended and it is possible to
livepatch a function that use an external symbol.
Signed-off-by: Lukas Hruska
Reviewed-by: Petr Mladek
Tested-by: Petr Mladek
---
tools/testing/selftests/livepatch/Makefile| 3 +-
.../testing/selftests/livepatch
This patch is only an example of how to generate #GP by IBT.
It serves only as an example for those wondering how the Linux behaves
in this case.
Don't merge this patch, because it causes a refcount underflow of the test
module, so it's not possible to unload it.
Signed-off-by: Lu
24 matches
Mail list logo