[PATCH 1/5] ALSA: emu10k1: remove reserved_page

2018-01-21 Thread Maciej S. Szmigiero
to remove the reserved_page allocation is a trivial change to the page allocation logic to ignore the first page entry and start its allocations from the second entry (index 1). Signed-off-by: Maciej S. Szmigiero --- include/sound/emu10k1.h | 1 - sound/pci/emu10k1/emu10k1_main.c | 11

[PATCH 2/5] ALSA: emu10k1: use dma_set_mask_and_coherent()

2018-01-21 Thread Maciej S. Szmigiero
We have been calling dma_set_mask() and then dma_set_coherent_mask() with the same value, but there is a dma_set_mask_and_coherent() function that does exactly that so let's use it instead. Signed-off-by: Maciej S. Szmigiero --- sound/pci/emu10k1/emu10k1_main.c | 3 +-- 1 file changed, 1

[PATCH 3/5] ALSA: emu10k1: add optional debug printouts with DMA addresses

2018-01-21 Thread Maciej S. Szmigiero
printouts are only enabled on an explicit request via the kernel dynamic debug mechanism. Signed-off-by: Maciej S. Szmigiero --- sound/pci/emu10k1/emu10k1_main.c | 8 sound/pci/emu10k1/memory.c | 11 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/sound/pci

[PATCH 4/5] ALSA: emu10k1: make sure synth DMA pages are allocated with DMA functions

2018-01-21 Thread Maciej S. Szmigiero
as the CPU physical address space which is not true for a system with a IOMMU. Since this made the synth part of the driver non-functional on such systems let's effectively revert that commit. Signed-off-by: Maciej S. Szmigiero --- sound/pci/emu10k1/mem

[PATCH 5/5] ALSA: emu10k1: add a IOMMU workaround

2018-01-21 Thread Maciej S. Szmigiero
to accesses up to 256 extra bytes. As a workaround let's widen these DMA allocations by an extra page if we detect that the device is behind a non-passthrough IOMMU (the DMA memory should be relatively plenty on IOMMU systems). Signed-off-by: Maciej S. Szmigiero --- include/sound/emu10k1.h

Re: [PATCH v3 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()

2018-01-15 Thread Maciej S. Szmigiero
On 15.01.2018 05:21, Nicolin Chen wrote: > The _fsl_ssi_set_dai_fmt() is a helper function being called from > fsl_ssi_set_dai_fmt() as an ASoC operation and fsl_ssi_hw_init() > mainly for AC97 format initialization. > > This patch cleans the _fsl_ssi_set_dai_fmt() in following ways: > * Removing

Re: [PATCH v3 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()

2018-01-15 Thread Maciej S. Szmigiero
On 15.01.2018 05:21, Nicolin Chen wrote: > This patch cleans up probe() function by moving all Device Tree > related code into a separate function. It allows the probe() to > be Device Tree independent. This will be very useful for future > integration of imx-ssi driver which has similar

Re: [PATCH v4 00/17] ASoC: fsl_ssi: Clean up - program flow level

2018-01-16 Thread Maciej S. Szmigiero
On 16.01.2018 00:16, Nicolin Chen wrote: > ==Change log== > v4 > * Reworked the series by taking suggestions from Maciej > + Added TXBIT0 bit back to play safe in PATCH-14 > + Made bool synchronous exclusive with AC97 mode in PATCH-16 > v3 > * Reworked the series by taking suggestions from

Re: [PATCH v4 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init()

2018-01-16 Thread Maciej S. Szmigiero
On 16.01.2018 00:16, Nicolin Chen wrote: > AC97 configures most of registers earlier to start a communication > with CODECs in order to successfully initialize CODEC. Currently, > _fsl_ssi_set_dai_fmt() and fsl_ssi_setup_ac97() are called to get > all SSI registers properly set. > > Since now the

Re: [PATCH v4 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()

2018-01-16 Thread Maciej S. Szmigiero
On 16.01.2018 00:16, Nicolin Chen wrote: > This patch cleans up probe() function by moving all Device Tree > related code into a separate function. It allows the probe() to > be Device Tree independent. This will be very useful for future > integration of imx-ssi driver which has similar

Re: [PATCH v4 00/17] ASoC: fsl_ssi: Clean up - program flow level

2018-01-16 Thread Maciej S. Szmigiero
On 17.01.2018 00:52, Nicolin Chen wrote: > On Wed, Jan 17, 2018 at 12:38:09AM +0100, Maciej S. Szmigiero wrote: > >>> Example of uncovered tests: AC97, PowerPC and FIQ. >> >> I've tested the whole series in the AC'97 mode on an i.MX6 UDOO board >> and everything

Re: [PATCH v5 00/17] ASoC: fsl_ssi: Clean up - program flow level

2018-01-17 Thread Maciej S. Szmigiero
ith foreground record (starting at different >time) via I2S Master and Slave mode > - Background record with foreground playback (starting at different >time) via I2S Master and Slave mode > * All tests above by hacking offline_config to true in imx51. > > Caleb has tested v1

[PATCH v2 3/5] ALSA: emu10k1: add optional debug printouts with DMA addresses

2018-01-27 Thread Maciej S. Szmigiero
printouts are only enabled on an explicit request via the kernel dynamic debug mechanism. Signed-off-by: Maciej S. Szmigiero --- Changes from v1: Fix a sparse warning by changing a variable type in __{get,set}_ptb_entry from u32 to __le32, don't open code EMUPAGESIZE. sound/pci/emu10k1

[PATCH v2 1/5] ALSA: emu10k1: remove reserved_page

2018-01-27 Thread Maciej S. Szmigiero
to remove the reserved_page allocation is a trivial change to the page allocation logic to ignore the first page entry and start its allocations from the second entry (index 1). Signed-off-by: Maciej S. Szmigiero --- Changes from v1: None in this patch. include/sound/emu10k1.h | 1 - sound/p

[PATCH v2 5/5] ALSA: emu10k1: add a IOMMU workaround

2018-01-27 Thread Maciej S. Szmigiero
it looks like the device tries to accesses up to 256 extra bytes. As a workaround let's widen these DMA allocations by an extra page if we detect that the device is behind a non-passthrough IOMMU (the DMA memory should be relatively plenty on IOMMU systems). Signed-off-by: Maciej S. Szmigiero

[PATCH v2 2/5] ALSA: emu10k1: use dma_set_mask_and_coherent()

2018-01-27 Thread Maciej S. Szmigiero
We have been calling dma_set_mask() and then dma_set_coherent_mask() with the same value, but there is a dma_set_mask_and_coherent() function that does exactly that so let's use it instead. Signed-off-by: Maciej S. Szmigiero --- Changes from v1: None in this patch. sound/pci/emu10k1

[PATCH v2 4/5] ALSA: emu10k1: make sure synth DMA pages are allocated with DMA functions

2018-01-27 Thread Maciej S. Szmigiero
as the CPU physical address space which is not true for a system with a IOMMU. Since this made the synth part of the driver non-functional on such systems let's effectively revert that commit. Signed-off-by: Maciej S. Szmigiero --- Changes from v1: None in this patch. sound/pci/emu10k1/mem

[PATCH] zswap: allow setting default status, compressor and allocator in Kconfig

2019-10-11 Thread Maciej S. Szmigiero
by adding an appropriate default switches to Kconfig. The default values for these options match what the code was using previously as its defaults. Signed-off-by: Maciej S. Szmigiero --- mm/Kconfig | 103 - mm/zswap.c | 26 -- 2 files ch

Re: [PATCH v2] hwmon: (drivetemp) Avoid SCT usage on Toshiba DT01ACA family drives

2020-07-14 Thread Maciej S. Szmigiero
On 14.07.2020 19:14, Guenter Roeck wrote: > On 7/14/20 7:11 AM, Maciej S. Szmigiero wrote: >> On 14.07.2020 16:02, Guenter Roeck wrote: >>> On 7/11/20 1:41 PM, Maciej S. Szmigiero wrote: >>>> It has been observed that Toshiba DT01ACA family drives have >>&g

[PATCH v3] hwmon: (drivetemp) Avoid SCT usage on Toshiba DT01ACA family drives

2020-07-18 Thread Maciej S. Szmigiero
;) Cc: sta...@vger.kernel.org Signed-off-by: Maciej S. Szmigiero --- Notes: This behavior was observed on two different DT01ACA3 drives. Usually, a series of queued WRITE FPDMA QUEUED commands just time out, but sometimes the whole drive freezes. Merely disconnecting and reconnecting SATA

Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config

2019-06-03 Thread Maciej S. Szmigiero
Hi Hans, On 03.06.2019 14:14, Hans Verkuil wrote: > Hi Maciej, > > Thank you for the patch, but I posted a fix for this earlier already: > > https://patchwork.linuxtv.org/patch/56441/ > > I'll drop this patch in favor of the one above. Apologies for not > CC-ing you on my patch, I should have

Re: [PATCH] zswap: allow setting default status, compressor and allocator in Kconfig

2019-10-18 Thread Maciej S. Szmigiero
On 18.10.2019 13:19, Dan Streetman wrote: > On Fri, Oct 11, 2019 at 7:40 PM Maciej S. Szmigiero > wrote: >> >> The compressed cache for swap pages (zswap) currently needs from 1 to 3 >> extra kernel command line parameters in order to make it work: it has to

Re: [PATCH v2] hwmon: (drivetemp) Avoid SCT usage on Toshiba DT01ACA family drives

2020-07-14 Thread Maciej S. Szmigiero
On 14.07.2020 16:02, Guenter Roeck wrote: > On 7/11/20 1:41 PM, Maciej S. Szmigiero wrote: >> It has been observed that Toshiba DT01ACA family drives have >> WRITE FPDMA QUEUED command timeouts and sometimes just freeze until >> power-cycled under heavy write loads w

[PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

2020-07-05 Thread Maciej S. Szmigiero
xample, XY movement multiplier). Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice") Cc: sta...@vger.kernel.org Signed-off-by: Maciej S. Szmigiero --- Sending again since the previous message bounced for most recipients. drivers/hid/hid-logitech-hi

Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

2020-07-06 Thread Maciej S. Szmigiero
On 06.07.2020 14:38, Filipe LaĆ­ns wrote: > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote: >> These messages appear each time the mouse wakes from sleep, in my >> case >> (Logitech M705), every minute or so. >> Let's downgrade them to the "

[PATCH] hwmon: (drivetemp) Avoid SCT usage on Toshiba DT01ACA family drives

2020-07-10 Thread Maciej S. Szmigiero
;) Cc: sta...@vger.kernel.org Signed-off-by: Maciej S. Szmigiero --- Sending again since the previous message bounced for most recipients. Notes: This behavior was observed on two different DT01ACA3 drives. Usually, a series of queued WRITE FPDMA QUEUED commands just time out, but sometimes

[PATCH v2] hwmon: (drivetemp) Avoid SCT usage on Toshiba DT01ACA family drives

2020-07-11 Thread Maciej S. Szmigiero
;) Cc: sta...@vger.kernel.org Signed-off-by: Maciej S. Szmigiero --- Notes: This behavior was observed on two different DT01ACA3 drives. Usually, a series of queued WRITE FPDMA QUEUED commands just time out, but sometimes the whole drive freezes. Merely disconnecting and reconnecting SATA

Re: [PATCH v12 0/8] [media] Add analog mode support for Medion MD95700

2020-06-03 Thread Maciej S. Szmigiero
On 03.06.2020 16:33, Lukas Straub wrote: > On Mon, 29 Apr 2019 18:16:51 +0200 > "Maciej S. Szmigiero" wrote: > >> This series adds support for analog part of Medion 95700 in the cxusb >> driver. >> (..) > Hi, > Any status on this? It has been mer

[PATCH 1/2] x86/microcode/AMD: Integrate verify_patch_size() into verify_patch()

2018-06-22 Thread Maciej S. Szmigiero
Integrating verify_patch_size() into verify_patch() will allows us to introduce in the next commit a check whether the indicated patch size makes sense for its indicated CPU family - for all CPU families known to the driver. Signed-off-by: Maciej S. Szmigiero --- This is part 1/2

[PATCH 2/2] x86/microcode/AMD: Check patch size for all known CPU families

2018-06-22 Thread Maciej S. Szmigiero
spot a patch that is longer than expected for its family we'll carefully skip over only the expected length to make sure we don't miss good patches in case the indicated patch size was something nonsensically huge. Signed-off-by: Maciej S. Szmigiero --- This is part 2/2 of a replacement

Re: [PATCH 2/2] x86/microcode/AMD: Check patch size for all known CPU families

2018-06-25 Thread Maciej S. Szmigiero
On 25.06.2018 20:37, Borislav Petkov wrote: (..) >> +break; >> case 0x14: >> max_size = F14H_MPB_MAX_SIZE; >> break; >> @@ -251,22 +239,41 @@ static bool verify_patch(u8 family, const u8 *buf, >> size_t buf_size, >> max_size =

Re: [PATCH v6 3/8] x86/microcode/AMD: Check microcode container data in the early loader

2018-06-14 Thread Maciej S. Szmigiero
On 05.06.2018 10:54, Borislav Petkov wrote: (..) >> @@ -258,25 +265,27 @@ static ssize_t parse_container(u8 *ucode, ssize_t >> size, struct cont_desc *desc) >> >> hdr = (u32 *)buf; >> >> -if (hdr[0] != UCODE_UCODE_TYPE) >> +if (!verify_patch_section(buf,

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-18 Thread Maciej S. Szmigiero
On 18.06.2018 18:44, Borislav Petkov wrote: > On Tue, Jun 12, 2018 at 11:08:31PM +0200, Maciej S. Szmigiero wrote: >> That was the solution before this patch series version (6) - there was >> a variable holding the CPU equivalence table size for the late loader, >> but you did

[PATCH v7 5/9] x86/microcode/AMD: Split status from data to skip in verify_and_add_patch()

2018-06-19 Thread Maciej S. Szmigiero
ainer data to skip to a separate output parameter. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 35 +++-- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/a

[PATCH v7 1/9] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length

2018-06-19 Thread Maciej S. Szmigiero
the leftover file length before passing this value to verify_patch_size(). Signed-off-by: Maciej S. Szmigiero Link: http://lkml.kernel.org/r/b4854b17-e3ba-54d6-488d-0e0bfffe4...@maciej.szmigiero.name [ Split comment. ] Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/microcode/amd.c | 15

[PATCH v7 9/9] x86/microcode/AMD: Check the equivalence table size when scanning it

2018-06-19 Thread Maciej S. Szmigiero
Currently, the code scanning the CPU equivalence table read from a microcode container file assumes that it actually contains a terminating zero entry. Let's check also the size of this table to make sure that we don't read past it in case it actually doesn't. Signed-off-by: Maciej S. Szmigiero

[PATCH v7 3/9] x86/microcode/AMD: Integrate verify_patch_size() into verify_patch()

2018-06-19 Thread Maciej S. Szmigiero
length to make sure we don't miss good patches in case the indicated patch size was something nonsensically huge. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 131 1 file changed, 57 insertions(+), 74 deletions(-) diff --git a/arch/x86

[PATCH v7 0/9] x86/microcode/AMD: Check microcode file sanity before loading it

2018-06-19 Thread Maciej S. Szmigiero
Currently, it is very easy to make the AMD microcode update driver crash or spin on a malformed microcode container file since it does very little consistency checking on data loaded from such file. This series introduces various checks, mostly on length-type fields, so all corrupted microcode

[PATCH v7 2/9] x86/microcode/AMD: Add microcode container data checking functions

2018-06-19 Thread Maciej S. Szmigiero
of a patch is not too large for a particular CPU family. By adding these checks as separate functions the actual microcode loading code won't get interspersed with a lot of checks and so will be more readable. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 180

[PATCH v7 7/9] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro

2018-06-19 Thread Maciej S. Szmigiero
. Signed-off-by: Maciej S. Szmigiero --- arch/x86/include/asm/microcode_amd.h | 1 + arch/x86/kernel/cpu/microcode/amd.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/x86/include/asm/microcode_amd.h b/arch/x86/include/asm/microcode_amd.h index 209492849566..8ea477fbc65f 100644

[PATCH v7 6/9] x86/microcode/AMD: Check microcode container data in the late loader

2018-06-19 Thread Maciej S. Szmigiero
Convert the late loader in the AMD microcode update driver to use newly introduced microcode container data checking functions as it was previously done for the early loader. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 67 + 1 file

[PATCH v7 4/9] x86/microcode/AMD: Check microcode container data in the early loader

2018-06-19 Thread Maciej S. Szmigiero
()-style functions to work. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c index 67147e784c0e

[PATCH v7 8/9] x86/microcode/AMD: Convert CPU equivalence table variable into a struct

2018-06-19 Thread Maciej S. Szmigiero
Convert pointer to CPU equivalence table global static variable into a struct descriptor in preparation for tracking also the size of this table. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 24 +--- 1 file changed, 13 insertions(+), 11

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-09-28 Thread Maciej S. Szmigiero
Hi, > Hi, > > I upgraded my kernel to 4.18.10 recently and have since been experiencing > network problems after resuming from a > suspend to RAM or disk. I previously had 4.18.6 and that was OK. > > The pattern of the problem is that when I first boot, the network is fine. > But, after

[PATCH] pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges

2018-09-08 Thread Maciej S. Szmigiero
esn't work correctly unless the CLKRUN protocol is disabled. Let's also make it clear in its description that the "disable_clkrun" module parameter only works on these two previously mentioned brands of CardBus bridges. Signed-off-by: Maciej S. Szmigiero --- drivers/pcmcia

Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data

2018-06-12 Thread Maciej S. Szmigiero
On 05.06.2018 10:55, Borislav Petkov wrote: > On Sun, May 20, 2018 at 12:07:22AM +0200, Maciej S. Szmigiero wrote: >> Currently, the code scanning a CPU equivalence table read from a microcode >> container file assumes that it actually contains a terminating zero entry,

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-10 Thread Maciej S. Szmigiero
On 11.10.2018 00:49, Chris Clayton wrote: >> Now, knowing the "right" value you can experiment with what rtl_init_rxcfg() >> writes (under the "default:" label for your NIC model). >> > > This might be more interesting. Through a combination of viewing the output > from pr_notice() and the

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-11 Thread Maciej S. Szmigiero
On 11.10.2018 10:24, Chris Clayton wrote: > On 11/10/2018 01:12, Maciej S. Szmigiero wrote: >> On 11.10.2018 00:49, Chris Clayton wrote: >>>> Now, knowing the "right" value you can experiment with what >>>> rtl_init_rxcfg() >>>>

[PATCH] r8169: set RX_MULTI_EN bit in RxConfig for 8168F-family chips

2018-10-11 Thread Maciej S. Szmigiero
suspended and resumed. Fixes: 05212ba8132b42 ("r8169: set RxConfig after tx/rx is enabled for RTL8169sb/8110sb devices") Reported-by: Chris Clayton Signed-off-by: Maciej S. Szmigiero --- drivers/net/ethernet/realtek/r8169.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: kernel 4.18.5 Realtek 8111G network adapter stops responding under high system load

2018-09-18 Thread Maciej S. Szmigiero
Hi, On 18.09.2018 12:23, David Arendt wrote: > Hi, > > Today I had the network adapter problems again. > So the patch doesn't seem to change anything regarding this problem. > This week my time is unfortunately very limited, but I will try to > find some time next weekend to look a bit more into

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Maciej S. Szmigiero
On 07.10.2018 21:36, Chris Clayton wrote: > Hi again, > > I didn't think there was anything in 4.19-rc7 to fix this regression, but > tried it anyway. I can confirm that the > regression is still present and my network still fails when, after a resume > from suspend (to ram or disk), I open my

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Maciej S. Szmigiero
On 09.10.2018 22:36, Heiner Kallweit wrote: > On 09.10.2018 16:40, Chris Clayton wrote: >> Thanks to Maciej and Heiner for their replies. >> >> On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >>> On 07.10.2018 21:36, Chris Clayton wrote: >>>> Hi again, &

Re: [PATCH][ASoC]Add ability to remove rate constraints from generic ASoC AC'97 CODEC driver

2015-04-04 Thread Maciej S. Szmigiero
W dniu 30.03.2015 06:19, Mark Brown pisze: > On Sun, Mar 29, 2015 at 06:00:33PM +0200, Maciej S. Szmigiero wrote: >> W dniu 22.03.2015 19:27, Mark Brown pisze: > >>> Please use subject lines matching the style for the subsystem. This is >>> helpful fo

Re: [PATCH][ASoC]Add ability to remove rate constraints from generic ASoC AC'97 CODEC driver

2015-04-07 Thread Maciej S. Szmigiero
W dniu 06.04.2015 18:41, Mark Brown pisze: > On Sun, Apr 05, 2015 at 12:16:40AM +0200, Maciej S. Szmigiero wrote: >> W dniu 30.03.2015 06:19, Mark Brown pisze: >>> On Sun, Mar 29, 2015 at 06:00:33PM +0200, Maciej S. Szmigiero wrote: > >>> Alternatively if

Re: [PATCH][ASoC]Add ability to remove rate constraints from generic ASoC AC'97 CODEC driver

2015-03-29 Thread Maciej S. Szmigiero
Thanks for looking into the patch. W dniu 22.03.2015 19:27, Mark Brown pisze: > On Wed, Mar 11, 2015 at 12:28:19AM +0100, Maciej S. Szmigiero wrote: >> Add ability to remove rate constraints from generic ASoC AC'97 CODEC >> driver via passed platform data, make it selec

[PATCH] ASoC: codecs-ac97: Remove rate constraints

2015-04-10 Thread Maciej S. Szmigiero
Remove rate constraints from generic ASoC AC'97 CODEC and make it selectable in config. Supported rates should be detected and constrained anyway by AC'97 generic code - was tested with VT1613 CODEC and iMX6 SSI controller. This way this driver can be used for platforms which don't need

[PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-23 Thread Maciej S. Szmigiero
snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, not of SNDRV_PCM_FORMAT_* (which are sequential integers), however some of ASoC CODEC drivers use these values instead. Found out by sparse on 0-day kernel tester. Signed-off-by: Maciej Szmigiero diff --git

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-26 Thread Maciej S. Szmigiero
Hello Takashi, W dniu 26.05.2015 07:29, Takashi Iwai pisze: > At Sat, 23 May 2015 18:32:29 +0200, > Maciej S. Szmigiero wrote: >> >> snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, >> not of SNDRV_PCM_FORMAT_* (which are sequential integers), >> howe

Re: [PATCH] serial: don't announce CIR serial ports

2015-08-04 Thread Maciej S. Szmigiero
Hi Peter, Thanks for looking into it. On 04.08.2015 03:46, Peter Hurley wrote: > Hi Maciej, > > On 08/02/2015 05:09 PM, Maciej S. Szmigiero wrote: >> CIR type serial ports aren't real serial ports. >> This is just a way to prevent legacy serial driver >> from probing

[PATCH] serial: don't register CIR serial ports

2015-08-05 Thread Maciej S. Szmigiero
CIR type serial ports aren't real serial ports. This is just a way to prevent legacy 8250 serial driver from probing and eventually binding some resources. Since in current state such ports aren't providing any real functionality and it is not possible to change their type via

Re: [PATCH] serial: don't announce CIR serial ports

2015-08-05 Thread Maciej S. Szmigiero
On 05.08.2015 04:03, Peter Hurley wrote: > On 08/04/2015 07:25 PM, Maciej S. Szmigiero wrote: >> Hi Peter, >> >> Thanks for looking into it. >> >> On 04.08.2015 03:46, Peter Hurley wrote: >>> Hi Maciej, >>> >>> On 08/02/2015 05:09 PM,

Re: [PATCH] serial: don't register CIR serial ports

2015-08-05 Thread Maciej S. Szmigiero
On 05.08.2015 16:51, Greg Kroah-Hartman wrote: > On Wed, Aug 05, 2015 at 02:33:33PM +0200, Maciej S. Szmigiero wrote: >> CIR type serial ports aren't real serial ports. >> >> This is just a way to prevent legacy 8250 serial >> driver from probing and eventuall

[PATCH 1/6][RESEND] ASoC: fsl_ssi: enable IPG clock during AC'97 reg access

2015-08-05 Thread Maciej S. Szmigiero
IPG clock have to be enabled during AC'97 CODEC register access in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- This is a resend without changes, to keep the whole series together. sound/soc/fsl/fsl_ssi.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-)

[PATCH 2/6][RESEND] ASoC: fsl_ssi: AC'97 DAI driver needs probe method too

2015-08-05 Thread Maciej S. Szmigiero
AC'97 DAI driver struct need the same probe method as I2S one to setup DMA params in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- This is a resend without changes, to keep the whole series together. sound/soc/fsl/fsl_ssi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH 3/6][RESEND] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-08-05 Thread Maciej S. Szmigiero
AC'97 bus can support asymmetric playback/capture rates so enable them in this case in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- This is a resend without changes, to keep the whole series together. sound/soc/fsl/fsl_ssi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)

[PATCH 4/6][RESEND] ASoC: fsl_ssi: add AC'97 ops setting check and cleanup

2015-08-05 Thread Maciej S. Szmigiero
Check whether setting AC'97 ops succeeded and clean them on removal so the fsl_ssi driver can be reloaded. Signed-off-by: Maciej Szmigiero --- This is a resend without changes, to keep the whole series together. sound/soc/fsl/fsl_ssi.c |9 - 1 files changed, 8 insertions(+), 1

[PATCH 5/6][RESEND] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-08-05 Thread Maciej S. Szmigiero
Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. Signed-off-by: Maciej Szmigiero --- This is a resend without changes, to keep the whole series together. sound/soc/fsl/fsl_ssi.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git

[PATCH 6/6 v2][RESEND] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-05 Thread Maciej S. Szmigiero
Adjust set DAI format function in fsl_ssi driver so it doesn't fail and clears RXDIR in AC'97 mode. Signed-off-by: Maciej Szmigiero --- Changes from v1: fix indentation to be consistent with rest of the driver. sound/soc/fsl/fsl_ssi.c |8 +--- 1 files changed, 5 insertions(+), 3

[PATCHv2] serial: don't register CIR serial ports

2015-08-05 Thread Maciej S. Szmigiero
CIR type serial ports aren't real serial ports. This is just a way to prevent legacy 8250 serial driver from probing and eventually binding some resources. Since in current state such ports aren't providing any real functionality and it is not possible to change their type via

[PATCH] drm: panel-simple: add URT UMSH-8596MD-xT panel support

2015-07-29 Thread Maciej S. Szmigiero
This patch adds support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels (both LVDS and parallel versions) to DRM panel-simple driver. Signed-off-by: Maciej Szmigiero --- .../devicetree/bindings/panel/urt,umsh-8596md.txt | 11 +

[PATCH 1/6] ASoC: fsl_ssi: enable IPG clock during AC'97 reg access

2015-07-30 Thread Maciej S. Szmigiero
IPG clock have to be enabled during AC'97 CODEC register access in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-07-30 Thread Maciej S. Szmigiero
AC'97 bus can support asymmetric playback/capture rates so enable them in this case in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 2/6] ASoC: fsl_ssi: AC'97 DAI driver needs probe method too

2015-07-30 Thread Maciej S. Szmigiero
AC'97 DAI driver struct need the same probe method as I2S one to setup DMA params in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 6/6] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-07-30 Thread Maciej S. Szmigiero
Adjust set DAI format function in fsl_ssi driver so it doesn't fail and clears RXDIR in AC'97 mode. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-07-30 Thread Maciej S. Szmigiero
Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 154bcf6..8e5ff5e 100644 ---

[PATCH 4/6] ASoC: fsl_ssi: add AC'97 ops setting check and cleanup

2015-07-30 Thread Maciej S. Szmigiero
Check whether setting AC'97 ops succeeded and clean them on removal so the fsl_ssi driver can be reloaded. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

Re: [PATCH 1/6] ASoC: fsl_ssi: enable IPG clock during AC'97 reg access

2015-07-30 Thread Maciej S. Szmigiero
Hi Fabio, On 30.07.2015 17:20, Fabio Estevam wrote: > Hi Maciej, > > On Thu, Jul 30, 2015 at 11:33 AM, Maciej S. Szmigiero > wrote: > >> static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, >> @@ -1151,6 +1160,14 @@ static unsigned short fsl_ssi_ac97_rea

Re: [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-07-31 Thread Maciej S. Szmigiero
On 31.07.2015 07:46, Markus Pargmann wrote: > On Thu, Jul 30, 2015 at 04:35:23PM +0200, Maciej S. Szmigiero wrote: >> Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. >> >> Signed-off-by: Maciej Szmigiero >> --- >> sound/soc/fsl/fsl_ssi.c | 21

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-07-31 Thread Maciej S. Szmigiero
Hi Markus, Thanks for looking into the changes. On 31.07.2015 07:53, Markus Pargmann wrote: > On Fri, Jul 31, 2015 at 07:27:19AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Thu, Jul 30, 2015 at 04:34:19PM +0200, Maciej S. Szmigiero wrote: >>> AC'97 bus can suppo

Re: [PATCH 6/6] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-07-31 Thread Maciej S. Szmigiero
On 31.07.2015 07:58, Markus Pargmann wrote: > On Thu, Jul 30, 2015 at 04:35:58PM +0200, Maciej S. Szmigiero wrote: >> Adjust set DAI format function in fsl_ssi driver so it >> doesn't fail and clears RXDIR in AC'97 mode. >> >> Signed-off-by: Maciej Szmigiero >>

[PATCH 1/3] emu10k1: remove unused AC'97 mixer controls on Audigy

2015-07-07 Thread Maciej S. Szmigiero
AC'97 Headphone output and EAPD control aren't used on Audigy so remove them from mixer. Also remove AC'97 3D control as the driver is already doing for Audigys with 1361T ADC. Signed-off-by: Maciej Szmigiero --- sound/pci/emu10k1/emumixer.c | 11 ++- 1 files changed, 6

[PATCH 2/3] emu10k1: enable TAD mic out on Audigy

2015-07-07 Thread Maciej S. Szmigiero
Enable TAD output on Audigy naming it "Phone Output", to be consistent with TAD input which is called "Phone". According to Creative doc ( http://support.creative.com/kb/ShowArticle.aspx?sid=3026 ) this should output just mic signal. Signed-off-by: Maciej Szmigiero ---

[PATCH 3/3] emu10k1: rename Audigy Analog Capture Boost control

2015-07-07 Thread Maciej S. Szmigiero
Audigy has "Analog Capture Boost" mixer control, however now this only controls mic level, not other analog sources. It applies also both to playback and capture, so rename it to something more descriptive. Signed-off-by: Maciej Szmigiero --- sound/pci/emu10k1/emumixer.c |2 +- 1 files

[PATCH] serial: don't announce CIR serial ports

2015-08-02 Thread Maciej S. Szmigiero
CIR type serial ports aren't real serial ports. This is just a way to prevent legacy serial driver from probing and eventually binding some resources so don't announce them like normal serial ports. Signed-off-by: Maciej Szmigiero --- drivers/tty/serial/serial_core.c |2 +- 1 files changed,

[PATCH] serial: 8250: don't bind to SMSC IrCC IR port

2015-08-02 Thread Maciej S. Szmigiero
SMSC IrCC SIR/FIR port should not be bound to by (legacy) serial driver so its own driver (smsc-ircc2) can bind to it. Signed-off-by: Maciej Szmigiero --- drivers/tty/serial/8250/8250_pnp.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCH] serial: 8250: bind to ALi Fast Infrared Controller (ALI5123)

2015-08-02 Thread Maciej S. Szmigiero
This way this device can be used with irtty-sir - at least on Toshiba Satellite A20-S103 it is not configured by default and needs PNP activation before it starts to respond on I/O ports. This device has actually its own driver (ali-ircc), but this driver seems to be non-functional for a very

[PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-02 Thread Maciej S. Szmigiero
Adjust set DAI format function in fsl_ssi driver so it doesn't fail and clears RXDIR in AC'97 mode. Changes from v1: fix indentation to be consistent with rest of the driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |8 +--- 1 files changed, 5 insertions(+), 3

Re: [PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-03 Thread Maciej S. Szmigiero
On 03.08.2015 18:21, Mark Brown wrote: > On Mon, Aug 03, 2015 at 12:44:11AM +0200, Maciej S. Szmigiero wrote: >> Adjust set DAI format function in fsl_ssi driver >> so it doesn't fail and clears RXDIR in AC'97 mode. >> >> Changes from v1: fix indentation to be consistent

Re: [PATCH] serial: don't announce CIR serial ports

2015-08-03 Thread Maciej S. Szmigiero
On 04.08.2015 01:40, Greg Kroah-Hartman wrote: > On Sun, Aug 02, 2015 at 11:09:57PM +0200, Maciej S. Szmigiero wrote: >> CIR type serial ports aren't real serial ports. >> This is just a way to prevent legacy serial driver >> from probing and eventually binding some resources

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-27 Thread Maciej S. Szmigiero
W dniu 26.05.2015 16:09, Takashi Iwai pisze: > At Tue, 26 May 2015 16:03:17 +0200, > Maciej S. Szmigiero wrote: >> >> Hello Takashi, >> >> W dniu 26.05.2015 07:29, Takashi Iwai pisze: >>> At Sat, 23 May 2015 18:32:29 +0200, >>> Maciej S. Szmig

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-13 Thread Maciej S. Szmigiero
Thanks for looking into the patch. W dniu 12.05.2015 19:58, Mark Brown pisze: > On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > >> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS >> select SND_SOC_88PM860X if MFD_88PM860X >> select S

[PATCH 1/2] ASoC: fsl-asoc-card: put ASRC OF node in case of unknown device

2015-08-31 Thread Maciej S. Szmigiero
In case of unknown DT compatible device the ASRC OF node possibly acquired earlier by of_parse_phandle() has to be put before returning from probe method. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl-asoc-card.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH 2/2] ASoC: fsl-asoc-card: add AC'97 support

2015-08-31 Thread Maciej S. Szmigiero
Add AC'97 support to fsl-asoc-card using generic ASoC AC'97 CODEC. The SSI controller will silently enable any TX AC'97 slots that have their bits set in SLOTREQ received from CODEC and then will redirect some of playback samples there. That's why it is important to make sure that any of CODEC

[PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel support

2015-09-01 Thread Maciej S. Szmigiero
This patch adds support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels (both LVDS and parallel versions) to DRM panel-simple driver. Signed-off-by: Maciej Szmigiero --- This is a resend without changes. diff --git

[PATCH] cfg80211: regulatory: restore proper user alpha2

2015-09-02 Thread Maciej S. Szmigiero
restore_regulatory_settings() should restore alpha2 as computed in restore_alpha2(), not raw user_alpha2 to behave as described in the comment just above that code. This fixes endless loop of calling CRDA for "00" and "97" countries after resume from suspend on my laptop. Looks like others had

[PATCH] net: fec: normalize return value of pm_runtime_get_sync() in MDIO write

2015-09-03 Thread Maciej S. Szmigiero
If fec MDIO write method succeeds its return value comes from call to pm_runtime_get_sync(). But pm_runtime_get_sync() can also return 1. In case of Micrel KSZ9031 PHY this value will then be returned along the call chain of phy_write() -> ksz9031_extended_write() -> ksz9031_center_flp_timing()

[PATCHv3] serial: don't register CIR serial ports

2015-08-15 Thread Maciej S. Szmigiero
CIR type serial ports aren't real serial ports. This is just a way to prevent legacy 8250 serial driver from probing and eventually binding some resources. Since in current state such ports aren't providing any real functionality and it is not possible to change their type via

Re: [PATCH] usb: ci_hdrc_imx: add optional hub clock

2015-06-24 Thread Maciej S. Szmigiero
Hi Peter, W dniu 23.06.2015 04:55, Peter Chen pisze: > On Mon, Jun 22, 2015 at 12:54:14AM +0800, Maciej S. Szmigiero wrote: >> This patch adds ability to define optional clock of connected >> USB hub to ChipIdea i.MX usb controller driver. >> >> This is needed

[PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Maciej S. Szmigiero
Currently the AC'97 mode in fsl_ssi driver isn't functional. This patch implements the following changes to make it work properly: * IPG clock have to be enabled during AC'97 CODEC register access, * AC'97 DAI driver struct need the same probe method as I2S one to setup DMA params, * AC'97 bus

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Maciej S. Szmigiero
Hello Fabio, W dniu 28.06.2015 01:06, Fabio Estevam pisze: > Hi Maciej, > > On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero > wrote: >> Currently the AC'97 mode in fsl_ssi driver isn't functional. > > Thanks for the fix. I look forward to test it on my udoo board.

<    3   4   5   6   7   8   9   10   >