Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Madhumthia Prabakaran
On Wed, Apr 03, 2019 at 07:21:45PM +0300, Dan Carpenter wrote: > On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > > data_bit = (data & BIT(i)) ? 1 : 0; > > I quite like the !! idiom also... > > data_bit = !!(data & BIT(i)); Thanks for reviewing it. >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-10 Thread Madhumthia Prabakaran
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > b/drivers/staging/rtl8723bs/include/drv_types.h > > index bafb2c30e7fb..b0623c936940 100644 >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-11 Thread Madhumthia Prabakaran
On Thu, Apr 11, 2019 at 11:13:28AM +0300, Dan Carpenter wrote: > On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote:

Re: [PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

2019-04-04 Thread Madhumthia Prabakaran
On Thu, Apr 04, 2019 at 12:09:00PM +0300, Dan Carpenter wrote: > You should probably update the subject line because now it's not just > about parentheses any more. > > [PATCH v2] Staging: rtlwifi: clean up crc16_ccitt() > > So the one thing per patch rule is a little bit about selling your >

Re: [PATCH] Staging: greybus: Fix spinlock_t definition without comment

2019-04-06 Thread Madhumthia Prabakaran
On Fri, Apr 05, 2019 at 11:53:04PM +0300, Dan Carpenter wrote: > On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran wrote: > > Fix spinlock_t definition without comment. > > > > Signed-off-by: Madhumitha Prabakaran > > --- > > drivers/staging/greybus/connection.h | 2 +- > > 1 file

Re: [greybus-dev] [PATCH] Staging: greybus: Fix spinlock_t definition without comment

2019-04-06 Thread Madhumthia Prabakaran
On Fri, Apr 05, 2019 at 05:50:10PM -0500, Alex Elder wrote: > On 4/5/19 3:53 PM, Dan Carpenter wrote: > > On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran > > wrote: > >> Fix spinlock_t definition without comment. > >> > >> Signed-off-by: Madhumitha Prabakaran > > Madhumitha, the