RE: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-30 Thread Manish Narani
Hi Greg, Thanks for the suggestion. I will fix it and send you in next version. :) Regards, Manish -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, September 29, 2016 2:24 PM To: Manish Narani <mnar...@xilinx.com> Cc: ba...@kernel.org;

RE: [LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-30 Thread Manish Narani
Hi Greg, Thanks for the suggestion. I will fix it and send you in next version. :) Regards, Manish -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, September 29, 2016 4:56 PM To: Manish Narani <mnar...@xilinx.com> Cc: ba...@kernel.org;

[LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-29 Thread Manish Narani
This patch adds support to configure data verification through module parameter. This parameter can be used to disable data verification in case if one wants to measure peak Bulk/Isoc-IN/OUT performance Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/gadget/fu

[LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

2016-09-29 Thread Manish Narani
This patch adds support to configure bulk maxburst through module parameter. This parameter can be used to modify bulk maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT performance. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/gadget/function/f_source

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2016-12-15 Thread Manish Narani
Thanks Greg. I have send another patch with changes as per your suggestions. Please review it and let me know if you have any concerns. - Manish -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, December 15, 2016 2:29 AM To: Manish Narani <m

[RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2016-12-14 Thread Manish Narani
This patch will add support for OTG host initialization. This will help OTG drivers to populate their host subsystem. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/host/xhci-plat.c | 35 +++ 1 files changed, 35 insertions(+), 0 del

[RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2016-12-14 Thread Manish Narani
This patch will add support for OTG host initialization. This will help OTG drivers to populate their host subsystem. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/host/xhci-plat.c | 39 +++ 1 file changed, 39 insertions(+) diff

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2017-01-01 Thread Manish Narani
Ping !! -Original Message- From: Manish Narani [mailto:manish.nar...@xilinx.com] Sent: Thursday, December 15, 2016 1:24 PM To: mathias.ny...@intel.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Anurag Kumar Vulisha <anura...@xilinx.

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2017-01-02 Thread Manish Narani
planning to add DWC3 OTG driver after this patch is added. Please let me know your valuable suggestions on this. Thanks, Manish -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Monday, January 02, 2017 2:53 PM To: Manish Narani <m

[RFC PATCH] arch: arm64: dts: add USB OTG interrupts support in ZynqMP device tree

2017-01-04 Thread Manish Narani
This patch adds OTG interrupt support in device tree. It will add an extra interrupt line number dedicated to OTG events. This will enable OTG interrupts to serve in DWC3 OTG driver. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +-

[RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2017-01-04 Thread Manish Narani
This patch will add support for OTG host initialization. This will help OTG drivers to populate their host subsystem. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/host/xhci-plat.c | 39 +++ 1 file changed, 39 insertions(+) diff

[RFC PATCH] usb: dwc3: host: add support for OTG in DWC3 host driver

2017-01-04 Thread Manish Narani
This patch adds support for OTG host mode initialization in DWC3 host driver. Before the host initialization sequence begins. The driver has to make sure the no OTG peripheral mode is enabled. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/dwc3/host.c | 14 +++

[RFC PATCH] usb: dwc3: gadget: add support for OTG in gadget framework

2017-01-04 Thread Manish Narani
This patch adds support for OTG in DWC3 gadget framework. This also adds support for HNP polling by host while in OTG mode. Modifications in couple of functions to make it in sync with OTG driver while keeping its original functionality intact. Signed-off-by: Manish Narani <mnar...@xilinx.

[RFC PATCH] usb: dwc3: core: add OTG support function calls and modifications

2017-01-04 Thread Manish Narani
This patch adds function call to initialize OTG driver. This patch also adds support for OTG device structure in DWC3 device. Modifications to event buffer related functions which are called from OTG driver upon requirement. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/us

[RFC PATCH] usb: dwc3: add support for OTG driver compilation

2017-01-04 Thread Manish Narani
This patch adds support for OTG driver compilation and object file creation Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/dwc3/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile index ffca340..2d269ad

[RFC PATCH] usb: dwc3: otg: Adding OTG driver for DWC3 controller

2017-01-04 Thread Manish Narani
This driver will add support for USB 2.0 OTG and USB 3.0 DRD in DWC3 framework. This OTG driver supports host/peripheral modes on run time. This driver will enable HNP and SRP support in High-Speed mode. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/dwc3/otg.c

RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

2017-01-04 Thread Manish Narani
Hi Felipe, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, January 04, 2017 7:01 PM > Hi, > > Manish Narani <manish.nar...@xilinx.com> writes: > > This patch adds support for OTG driver compilation and object file > > creation > >

RE: [RFC PATCH] usb: dwc3: host: add support for OTG in DWC3 host driver

2017-01-05 Thread Manish Narani
Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, January 04, 2017 7:03 PM > > Hi, > > Manish Narani <manish.nar...@xilinx.com> writes: > > This patch adds support for OTG host mode initialization in DWC3

[PATCH] usb: gadget: Correct usb EP argument for BOT status request

2017-03-20 Thread Manish Narani
This patch corrects the argument in usb_ep_free_request as it is mistakenly set to ep_out. It should be ep_in for status request. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/usb/gadget/function/f_tcm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[RFC PATCH 1/3] arm64: zynqmp: dt: Add support for setting SD tap delays

2018-06-07 Thread Manish Narani
This patch adds support for setting SD tap delays from Device Tree. Earlier, these tap values were made static via macros in the driver. So changing the tap values in the device tree makes the driver free from handling different tap values inside it. Signed-off-by: Manish Narani --- arch/arm64

[RFC PATCH 2/3] dt: bindings: Add SD tap value properties details

2018-06-07 Thread Manish Narani
This patch adds details of SD tap value properties in device tree. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b

[RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-07 Thread Manish Narani
This patch adds support for reading Tap Delay values from Device Tree and write them via eemi calls. The macros containing these tap delay values are removed from the driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 131 + 1 file

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-13 Thread Manish Narani
Ping for RFC > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Thursday, June 7, 2018 5:42 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; m...@kernel.org; stefan.krsmano...@aggios.com;

[RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-01-30 Thread Manish Narani
obtained SDHC tuned tap value. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 1 + drivers/mmc/host/sdhci-of-arasan.c | 219 - 2 files changed, 219 insertions(+), 1 deletion(-) diff

[RFC PATCH] soc: zynqmp: Add support for tap delay settings

2018-02-12 Thread Manish Narani
This patch add support for tep delays programming for zynqmp platform. This also adds dll reset support. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/soc/xilinx/Kconfig | 6 +- drivers/soc/xilinx/Makefile | 2 + drivers/soc/xilinx/

RE: [RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-02-20 Thread Manish Narani
Hi Adrian, > -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Friday, February 16, 2018 7:37 PM > To: Manish Narani <mnar...@xilinx.com>; michal.si...@xilinx.com; > ulf.hans...@linaro.org; linux-arm-ker...@lists.infr

RE: [RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-02-21 Thread Manish Narani
Hi Adrian, > -Original Message- > From: Manish Narani > Sent: Wednesday, February 21, 2018 11:39 AM > To: Adrian Hunter <adrian.hun...@intel.com>; michal.si...@xilinx.com; > ulf.hans...@linaro.org; linux-arm-ker...@lists.infradead.org; linux- > m...@vger.

RE: [RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-02-22 Thread Manish Narani
Hi Adrian, > -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Thursday, February 22, 2018 1:50 PM > To: Manish Narani <mnar...@xilinx.com>; michal.si...@xilinx.com; > ulf.hans...@linaro.org; linux-arm-ker...@lists.infr

RE: [RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-02-22 Thread Manish Narani
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Thursday, February 22, 2018 1:50 PM > To: Manish Narani <mnar...@xilinx.com>; michal.si...@xilinx.com; > ulf.hans...@linaro.org; linux-arm-ker...@lists.infradead.org; linux- > m..

RE: [RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-02-23 Thread Manish Narani
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Friday, February 23, 2018 1:04 PM > To: Manish Narani <mnar...@xilinx.com>; michal.si...@xilinx.com; > ulf.hans...@linaro.org; linux-arm-ker...@lists.infradead.org; linux- > m..

RE: [RFC PATCH 2/3] dt: bindings: Add SD tap value properties details

2018-06-21 Thread Manish Narani
Hi Mark, > -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Thursday, June 7, 2018 6:18 PM > To: Manish Narani > Cc: robh...@kernel.org; catalin.mari...@arm.com; will.dea...@arm.com; > m...@kernel.org; stefan.krsmano...@aggios.com

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-21 Thread Manish Narani
Hi Adrian, > -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Tuesday, June 19, 2018 5:08 PM > To: Manish Narani ; robh...@kernel.org; > catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org; > stefan.krsmano...@aggios.

RE: [PATCH v2 2/4] iio: adc: xilinx: limit pcap clock frequency value

2018-07-30 Thread Manish Narani
Hi Jonathan, > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Sunday, July 29, 2018 5:21 PM > To: Manish Narani > Cc: Sai Krishna Potthuri ; Michal Simek > ; pme...@pmeerw.net; l...@metafoo.de; > knaac...@gmx.de; Anirudha Sarangi ; Sr

[PATCH v3 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-02 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 64 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/drivers/edac

[PATCH v3 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-02 Thread Manish Narani
of DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is a feature of ZynqMP DDRC - The Binding Documentation in (2/4) is modified as per the review comments Changes in v3: - The commit message in (2/4) is modified (Synopsys EDAC Driver --> ZynqMP DDRC) Manish Narani

[PATCH v3 4/4] arm64: zynqmp: Add DDRC node

2018-08-02 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v3 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-02 Thread Manish Narani
of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 857 ++- 2 files changed, 841 insertions(+), 18 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH v3 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-02 Thread Manish Narani
This patch adds information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v2 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-02 Thread Manish Narani
This patch documents Synopsys EDAC driver which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v2 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-02 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 64 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/drivers/edac

[PATCH v2 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-02 Thread Manish Narani
of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 857 ++- 2 files changed, 841 insertions(+), 18 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH v2 4/4] arm64: zynqmp: Add DDRC node

2018-08-02 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v2 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-02 Thread Manish Narani
of DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is a feature of ZynqMP DDRC - The Binding Documentation in (2/4) is modified as per the review comments Manish Narani (4): edac: synps: Add platform specific structures for ddrc controller dt: bindings: Document ZynqMP DDRC

[PATCH v4 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-04 Thread Manish Narani
This patch adds information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v4 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-04 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. Also add support for ECC Error Injection in ZynqMP. The corrected and uncorrected error interrupts support is added. The Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish

[PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-04 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 83 ++-- 1 file changed, 65 insertions(+), 18 deletions(-) diff --git a/drivers/edac

[PATCH v4 4/4] arm64: zynqmp: Add DDRC node

2018-08-04 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-04 Thread Manish Narani
v4: - Updated the commit message in (1/4) - Renamed function pointer names removing 'synps_' in (1/4) - Shortened unnecessary long lines as per the review comment on (1/4) Manish Narani (4): edac: synps: Add platform specific structures for ddrc controller dt: bindings: Docum

RE: [PATCH v3 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-04 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, August 4, 2018 10:49 AM > Subject: Re: [PATCH v3 1/4] edac: synps: Add platform specific structures for > ddrc controller > > On Thu, Aug 02, 2018 at 06:21:19PM +0530

RE: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-06 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, August 4, 2018 10:03 PM > Subject: Re: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver > > On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote: >

RE: [PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-18 Thread Manish Narani
Ping. > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Saturday, August 4, 2018 2:56 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Michal Simek ; b...@alien8.de; > mche...@kernel.or

RE: [PATCH v4 4/4] arm64: zynqmp: Add DDRC node

2018-08-18 Thread Manish Narani
Ping. > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Saturday, August 4, 2018 2:56 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Michal Simek ; b...@alien8.de; > mche...@kernel.or

RE: [PATCH v4 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-22 Thread Manish Narani
Hi Boris, Thanks a lot for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, August 21, 2018 6:40 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Mic

RE: [PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-22 Thread Manish Narani
Hi Boris, Thank you so much for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, August 21, 2018 6:37 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-07-20 Thread Manish Narani
Hi Uffe, > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Tuesday, July 10, 2018 2:02 PM > To: Manish Narani > Cc: Rob Herring ; Mark Rutland > ; Catalin Marinas ; Will > Deacon ; Moritz Fischer ; > stefan.krsmano...@ag

[PATCH] checkpatch: Resolve improper warning for krealloc arg reuse

2018-07-18 Thread Manish Narani
); ... } $ ./scripts/checkpatch.pl -f file.c WARNING: Reusing the krealloc arg is almost always a bug + abc.def_var = krealloc(def_var, sizeof(*def_var), This patch resolves the above false warning. Signed-off-by: Manish Narani --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion

RE: [PATCH 3/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-23 Thread Manish Narani
Hi Jonathan, Thanks for your comments. > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Saturday, July 21, 2018 9:54 PM > To: Lars-Peter Clausen > Cc: Manish Narani ; knaac...@gmx.de; > pme...@pmeerw.net; Michal Simek ; linux- > i...@v

RE: [PATCH 4/4] iio: adc: xilinx: Use devm_ functions while requesting irq

2018-07-23 Thread Manish Narani
Hi Lars, > -Original Message- > From: Lars-Peter Clausen [mailto:l...@metafoo.de] > Sent: Thursday, July 19, 2018 10:08 PM > To: Manish Narani ; ji...@kernel.org; > knaac...@gmx.de; pme...@pmeerw.net; Michal Simek > ; linux-...@vger.kernel.org; linux-arm- > ker..

[PATCH 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-07-19 Thread Manish Narani
This patch documents Synopsys EDAC driver which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 25 ++ 1 file changed, 21 insertions(+), 4

[PATCH 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-07-19 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 70 1 file changed, 58 insertions(+), 12 deletions(-) diff --git a/drivers/edac

[PATCH 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-07-19 Thread Manish Narani
of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 848 ++- 2 files changed, 833 insertions(+), 17 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH 4/4] arm64: zynqmp: Add DDRC node

2018-07-19 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-07-19 Thread Manish Narani
This patch series enhances the current EDAC driver to support different platforms.This series adds support for ZynqMP DDRC controller in synopsys EDAC driver. This series also adds Device tree properties and relevant binding documentation. Manish Narani (4): edac: synps: Add platform specific

[PATCH v2 0/4] iio: adc: xilinx: XADC driver Enhancements and bug fixes

2018-07-23 Thread Manish Narani
interrupts. Manish Narani (4): iio: adc: xilinx: Check for return values in clk related functions iio: adc: xilinx: limit pcap clock frequency value iio: adc: xilinx: Remove platform_get_irq from xadc_remove function iio: adc: xilinx: Move request_irq before enabling interrupts drivers/iio

[PATCH v2 3/4] iio: adc: xilinx: Remove platform_get_irq from xadc_remove function

2018-07-23 Thread Manish Narani
off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 10 +- drivers/iio/adc/xilinx-xadc.h | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index 0dd306d..44a2519 100644 --- a/drivers/iio/

[PATCH v2 1/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-23 Thread Manish Narani
This patch adds check for return values from clock related functions. This was reported by static code analysis tool. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc

[PATCH v2 2/4] iio: adc: xilinx: limit pcap clock frequency value

2018-07-23 Thread Manish Narani
of XADC_CFG register to make timings better in the interface. So to avoid alteration of these bits every time, the pcap value should not cross the Fmax limit. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v2 4/4] iio: adc: xilinx: Move request_irq before enabling interrupts

2018-07-23 Thread Manish Narani
Enabling the Interrupts before registering the irq handler is a bad idea. This patch corrects the same for XADC driver. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc

[PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels'

2018-07-18 Thread Manish Narani
This patch fix the following checkpatch warning in xadc driver. - Reusing the krealloc arg is almost always a bug. Renamed the 'channels' variable as 'iio_xadc_channels' to fix the above warning. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 16 +--- 1 file

RE: [PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels'

2018-07-18 Thread Manish Narani
Hi Lars, > -Original Message- > From: Lars-Peter Clausen [mailto:l...@metafoo.de] > Sent: Wednesday, July 18, 2018 4:49 PM > To: Manish Narani ; ji...@kernel.org; > knaac...@gmx.de; pme...@pmeerw.net; Michal Simek > ; linux-...@vger.kernel.org; linux-arm- > ker..

[PATCH 3/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-18 Thread Manish Narani
This patch adds check for return values from clock related functions. This was reported by static code analysis tool. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc

[PATCH 4/4] iio: adc: xilinx: Use devm_ functions while requesting irq

2018-07-18 Thread Manish Narani
This patch adds support for using devm_ functions for requesting irq. This will let the core free irq itself whenever the error condition happens in probe or when xadc_remove is called. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 18 +++--- 1 file changed

[PATCH 2/4] iio: adc: xilinx: Remove dead code from xadc_zynq_setup

2018-07-18 Thread Manish Narani
This patch removes dead code from xadc_zynq_setup. The condition "if (tck_rate > XADC_ZYNQ_TCK_RATE_MAX)" cannot be true at any point of time. There is also an incompatible parameter used in the code. This patch fixes the same reported by coverity. Signed-off-by: Manish Narani ---

[PATCH 0/4] iio: adc: xilinx: XADC driver enhancements and bug fixes

2018-07-18 Thread Manish Narani
This patch series resolves code style problems as reported by code analysis tools. Manish Narani (4): iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels' iio: adc: xilinx: Remove dead code from xadc_zynq_setup iio: adc: xilinx: Check for return values in clk related

RE: [PATCH v5 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-09-06 Thread Manish Narani
Hi Boris, Thanks a lot for the review. Please see my comments inline. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, September 4, 2018 10:28 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ;

RE: [PATCH v5 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-09-06 Thread Manish Narani
Hi Rob, > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, September 4, 2018 7:46 PM > To: Manish Narani > Cc: mark.rutl...@arm.com; Michal Simek ; > b...@alien8.de; mche...@kernel.org; leoyang...@nxp.com; > amit.kuche...@linar

RE: [PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-06 Thread Manish Narani
Hi Jonathan, Thanks for the review! > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Sunday, September 2, 2018 11:45 PM > To: Manish Narani > Cc: knaac...@gmx.de; l...@metafoo.de; pme...@pmeerw.net; > robh...@kernel.org; mark.rutl...@arm

RE: [PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-06 Thread Manish Narani
Hi Rob, Thanks for the review. Please see my comments inline. > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, September 4, 2018 6:48 AM > To: Manish Narani > > On Thu, Aug 30, 2018 at 03:52:17PM +0530, Manish Narani wrote: > > Xilinx AMS have several ADC chan

RE: [PATCH 2/3] iio: adc: Add Xilinx AMS driver

2018-09-06 Thread Manish Narani
Hi Jonathan, Thanks a lot for the review. Please see my response inline. > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Monday, September 3, 2018 1:27 AM > To: Manish Narani > Cc: knaac...@gmx.de; l...@metafoo.de; pme...@pmeerw.net; >

RE: [PATCH v5 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-09-06 Thread Manish Narani
Hi Boris, Thanks for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, September 5, 2018 3:50 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; mche...@kernel.org; leoyang...@nxp

[PATCH v5 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-31 Thread Manish Narani
changes are also done for better readability. Signed-off-by: Manish Narani --- drivers/edac/Kconfig |2 +- drivers/edac/synopsys_edac.c | 1054 +- 2 files changed, 937 insertions(+), 119 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac

[PATCH v5 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-31 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5 deletions

[PATCH v5 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-31 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 78 +--- 1 file changed, 59 insertions(+), 19 deletions(-) diff --git a/drivers/edac

[PATCH v5 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-31 Thread Manish Narani
ary check for match data in probe() in (1/4) - Some Indentation changes for better readability in (1/4) and (3/4) - Removed repeated code in (3/4) - Used 'zynq' and 'zynqmp' instead of 'synps_enh_edac' in function names Manish Narani (4): edac: synps: Add platform speci

[PATCH v5 4/4] arm64: zynqmp: Add DDRC node

2018-08-31 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 3/3] arm64: zynqmp: DT: Add Xilinx AMS node

2018-08-30 Thread Manish Narani
The Xilinx AMS includes an ADC as well as on-chip sensors that can be used to sample external and monitor on-die operating conditions, such as temperature and supply voltage levels. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++ 1 file

[PATCH 2/3] iio: adc: Add Xilinx AMS driver

2018-08-30 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani --- drivers/iio/adc/Kconfig | 10 + drivers

[PATCH 0/3] Add Xilinx AMS Driver

2018-08-30 Thread Manish Narani
, PS, PL Sysmon Channels. Manish Narani (3): dt-bindings: iio: adc: Add Xilinx AMS binding documentation iio: adc: Add Xilinx AMS driver arm64: zynqmp: DT: Add Xilinx AMS node .../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 +++ arch/arm64/boot/dts/xilinx/zynqmp.dtsi |

[PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-08-30 Thread Manish Narani
Xilinx AMS have several ADC channels that can be used for measurement of different voltages and temperatures. Document the same in the bindings. Signed-off-by: Manish Narani --- .../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 + 1 file changed, 159 insertions

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-07-09 Thread Manish Narani
Ping > -Original Message- > From: Manish Narani > Sent: Thursday, June 21, 2018 6:25 PM > To: Adrian Hunter ; robh...@kernel.org; > catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org; > stefan.krsmano...@aggios.com; linux-arm-ker...@lists.infradead

[RFC PATCH] iio: adc: Add Xilinx AMS driver

2018-03-15 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani <mnar...@xilinx.com> --- drivers/iio/adc/K

RE: [RFC PATCH] sdhci: arasan: Add runtime PM support

2018-03-29 Thread Manish Narani
; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; shawn.lin@rock- > chips.com; Manish Narani <mnar...@xilinx.com> > Subject: Re: [RFC PATCH] sdhci: arasan: Add runtime PM support > > On 2018/3/29 13:48, naraniman...@gmail.com wrote: > > From: Manish Narani

RE: [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name

2018-10-08 Thread Manish Narani
4, 2018 at 09:05:20PM +0530, Manish Narani wrote: > > Rename the static functions to a shorter name. Since this is Synopsys > > EDAC driver, better to remove unnecessary 'synps_' prefix in function > > names. > > > > Signed-off-by: Manish Nar

[PATCH v9 3/6] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZynqMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v9 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-10-14 Thread Manish Narani
ion in (1/6). - From v8 the first 5 patches are removed in this series as they are applied on: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/?h=edac-for-4.20-synps - Updated Kconfig to check for ARCH_ZYNQMP instead of ARM64 Manish Narani

[PATCH v9 4/6] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 324

[PATCH v9 5/6] arm64: zynqmp: Add DDRC node

2018-10-14 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v9 6/6] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 420

[PATCH v9 2/6] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-10-14 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v9 1/6] edac: synopsys: Add error handling for NULL in probe()

2018-10-14 Thread Manish Narani
The function of_device_get_match_data() can return NULL in case of error. Add error handling for the same in probe(). Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c

  1   2   3   4   5   >