Re: [PATCH v2 06/12] KVM: MMU: introduce a static table to map guest access to spte access

2013-01-29 Thread Marcelo Tosatti
On Mon, Jan 28, 2013 at 10:07:15PM -0200, Marcelo Tosatti wrote: On Fri, Jan 25, 2013 at 10:46:31AM +0800, Xiao Guangrong wrote: On 01/25/2013 08:15 AM, Marcelo Tosatti wrote: On Wed, Jan 23, 2013 at 06:07:20PM +0800, Xiao Guangrong wrote: It makes set_spte more clean and reduces branch

Re: [PATCH v2 03/12] KVM: MMU: simplify mmu_set_spte

2013-01-29 Thread Marcelo Tosatti
On Tue, Jan 29, 2013 at 10:55:24AM +0800, Xiao Guangrong wrote: On 01/29/2013 08:21 AM, Marcelo Tosatti wrote: On Wed, Jan 23, 2013 at 06:05:29PM +0800, Xiao Guangrong wrote: In order to detecting spte remapping, we can simply check whether the spte has already been pointing to the pfn even

Re: [Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-27 Thread Marcelo Tosatti
On Sun, Feb 24, 2013 at 04:23:44PM -0500, Peter Hurley wrote: On Tue, 2013-02-19 at 10:26 +0200, Gleb Natapov wrote: On Mon, Feb 18, 2013 at 08:12:21PM -0500, Peter Hurley wrote: On Mon, 2013-02-18 at 19:59 -0300, Marcelo Tosatti wrote: On Wed, Feb 13, 2013 at 06:57:09AM -0500, Peter

Re: [PATCH v12 rebased 2/8] start vm after resetting it

2013-03-01 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 04:13:49PM +0800, Hu Tao wrote: On Thu, Feb 07, 2013 at 11:50:28PM -0200, Marcelo Tosatti wrote: On Wed, Jan 23, 2013 at 03:19:23PM +0800, Hu Tao wrote: From: Wen Congyang we...@cn.fujitsu.com The guest should run after resetting it, but it does not run if its

Re: [PATCH v12 rebased] kvm: notify host when the guest is panicked

2013-03-01 Thread Marcelo Tosatti
On Thu, Feb 28, 2013 at 04:54:25PM +0800, Hu Tao wrote: diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h index 06fdbd9..c15ef33 100644 --- a/arch/x86/include/uapi/asm/kvm_para.h +++ b/arch/x86/include/uapi/asm/kvm_para.h @@ -96,5 +96,7 @@

[GIT PULL] KVM fixes for 3.8-rc4

2013-01-24 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fixes Alexander Graf (1): KVM: PPC: Emulate dcbf arch/powerpc/kvm/emulate.c |2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line

Re: [PATCH v2 06/12] KVM: MMU: introduce a static table to map guest access to spte access

2013-01-24 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 06:07:20PM +0800, Xiao Guangrong wrote: It makes set_spte more clean and reduces branch prediction Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c | 37 ++--- 1 files changed, 26 insertions(+),

Re: [PATCH] kvm: Fix irqfd resampler list walk

2013-01-28 Thread Marcelo Tosatti
On Mon, Jan 28, 2013 at 08:25:00AM -0700, Alex Williamson wrote: On Mon, 2012-12-10 at 18:16 -0200, Marcelo Tosatti wrote: On Thu, Dec 06, 2012 at 02:44:59PM -0700, Alex Williamson wrote: Typo for the next pointer means we're walking random data here. Signed-off-by: Alex Williamson

Re: [PATCH v2 03/12] KVM: MMU: simplify mmu_set_spte

2013-01-28 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 06:05:29PM +0800, Xiao Guangrong wrote: In order to detecting spte remapping, we can simply check whether the spte has already been pointing to the pfn even if the spte is not the last spte, for middle spte is pointing to the kernel pfn which can not be mapped to

Re: [PATCH v2 06/12] KVM: MMU: introduce a static table to map guest access to spte access

2013-01-28 Thread Marcelo Tosatti
On Fri, Jan 25, 2013 at 10:46:31AM +0800, Xiao Guangrong wrote: On 01/25/2013 08:15 AM, Marcelo Tosatti wrote: On Wed, Jan 23, 2013 at 06:07:20PM +0800, Xiao Guangrong wrote: It makes set_spte more clean and reduces branch prediction Signed-off-by: Xiao Guangrong xiaoguangr

Re: [PATCH v6 1/3] KVM: x86: clean up reexecute_instruction

2013-01-21 Thread Marcelo Tosatti
On Sun, Jan 13, 2013 at 11:44:12PM +0800, Xiao Guangrong wrote: Little cleanup for reexecute_instruction, also use gpa_to_gfn in retry_instruction Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Applied series, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH 5/5] fix kvm's use of __pa() on percpu areas

2013-01-22 Thread Marcelo Tosatti
van Riel r...@redhat.com --- linux-2.6.git-dave/arch/x86/kernel/kvm.c |9 + linux-2.6.git-dave/arch/x86/kernel/kvmclock.c |4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Marcelo Tosatti mtosa...@redhat.com -- To unsubscribe from this list: send

Re: [PATCH v6 1/3] KVM: x86: clean up reexecute_instruction

2013-01-17 Thread Marcelo Tosatti
(+), 7 deletions(-) Reviewed-by: Marcelo Tosatti mtosa...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-18 Thread Marcelo Tosatti
On Wed, Feb 13, 2013 at 06:57:09AM -0500, Peter Hurley wrote: On Wed, 2013-02-13 at 12:51 +0200, Gleb Natapov wrote: On Tue, Feb 12, 2013 at 04:39:03PM -0800, H. Peter Anvin wrote: On 02/12/2013 04:26 PM, Peter Hurley wrote: With -next-20130204+ in ubuntu 12.10 VM (so the 80x25 VGA

Re: [PATCH 4/4] Add a timer to allow the separation of consigned from steal time.

2013-02-18 Thread Marcelo Tosatti
On Tue, Feb 05, 2013 at 03:49:41PM -0600, Michael Wolf wrote: Add a helper routine to scheduler/core.c to allow the kvm module to retrieve the cpu hardlimit settings. The values will be used to set up a timer that is used to separate the consigned from the steal time. 1) Can you please

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-02-18 Thread Marcelo Tosatti
On Mon, Feb 18, 2013 at 05:43:47PM +0100, Frederic Weisbecker wrote: 2013/2/5 Michael Wolf m...@linux.vnet.ibm.com: In the case of where you have a system that is running in a capped or overcommitted environment the user may see steal time being reported in accounting tools such as top or

[GIT PULL] KVM updates for the 3.9 merge window

2013-02-20 Thread Marcelo Tosatti
nested_vmx_exit_handled_msr Jesse Larrew (1): x86: kvm_para: fix typo in hypercall comments Marcelo Tosatti (3): KVM: VMX: fix incorrect cached cpl value with real/v8086 modes x86: pvclock kvm: align allocation size to page size Revert KVM: MMU: lazily drop large spte Mihai Caraman (2

Re: sched: Fix signedness bug in yield_to()

2013-02-21 Thread Marcelo Tosatti
On Thu, Feb 21, 2013 at 09:56:54AM +0100, Ingo Molnar wrote: * Shuah Khan shuahk...@gmail.com wrote: On Tue, Feb 19, 2013 at 7:27 PM, Linux Kernel Mailing List linux-kernel@vger.kernel.org wrote: Gitweb:

[PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Marcelo Tosatti
Hi, Here goes the 8xx PCMCIA driver, originally written by Magnus Damm, with several improvements and fixes. The driver was merged in v2.4 but never forward ported to v2.6. Please review, comments are welcome (including aesthetic enhancements). Russell: The driver is using

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Marcelo Tosatti
On Mon, Aug 29, 2005 at 11:39:02PM -0400, Jeff Garzik wrote: Marcelo Tosatti wrote: +static int voltage_set(int slot, int vcc, int vpp) +{ +u_int reg = 0; + +switch(vcc) { +case 0: break; +case 33: +reg |= BCSR1_PCVCTL4; +break; +case 50

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-30 Thread Marcelo Tosatti
Hi Paul, Jeff, On Tue, Aug 30, 2005 at 02:32:29PM +1000, Paul Mackerras wrote: Marcelo Tosatti writes: The memory map structure which contains device configuration/registers is _always_ directly mapped with pte's (the 8xx is a chip with builtin UART/network/etc functionality). I

Re: Telecom Clock driver for MPCBL0010 ATCA compute blade.

2005-08-30 Thread Marcelo Tosatti
Mark, Please fix identation accordingly to CodingStyle and repost, it looks quite ugly at the moment. On Tue, Aug 30, 2005 at 11:59:33AM -0700, Mark Gross wrote: The following is a driver I would like to see included in the base kernel. It allows OS controll of a device that synchronizes

Re: [PATCH] MPC8xx PCMCIA driver

2005-09-01 Thread Marcelo Tosatti
Thu, Sep 01, 2005 at 10:53:19AM +0200, Dominik Brodowski wrote: Hi, On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote: Russell: The driver is using pccard_nonstatic_ops for card window management, even though the driver its marked SS_STATIC_MAP (using mem-static_map

Re: [RFC 1/3] non-resident page tracking

2005-08-09 Thread Marcelo Tosatti
On Tue, Aug 09, 2005 at 09:15:26PM +0200, Peter Zijlstra wrote: On Tue, 2005-08-09 at 15:25 -0300, Marcelo Tosatti wrote: Hi Rik, Two hopefully useful comments: i) ARC and its variants requires additional information about page replacement (namely whether the page has been reclaimed

Re: [PATCH/RFT 4/5] CLOCK-Pro page replacement

2005-08-10 Thread Marcelo Tosatti
Hi Rik, First of all, this is very nice! The code is amazingly easy to read. Now the usual ranting: You change the rate of active list scanning, which I suppose won't change the current reclaiming behaviour much (at least not on the stress system to death tests which most folks use to test

Re: kernel 2.4.27-10: isofs driver ignore some parameters with mount

2005-08-15 Thread Marcelo Tosatti
Hi folks, On Fri, Aug 12, 2005 at 05:29:36PM +0900, Horms wrote: On Fri, Aug 12, 2005 at 10:44:17AM +0300, Alexander Pytlev wrote: Hello Debian, Kernel 2.4.27-10 With mount isofs filesystem, any mount parameters after iocharset=,map=,session= are ignored. Sample: mount -t

Re: [PATCH 2.4] (5/5) I2C updates for 2.4.32-pre3

2005-08-18 Thread Marcelo Tosatti
On Sun, Aug 14, 2005 at 05:17:16PM +0200, Jean Delvare wrote: Five log messages lack their trailing new line in i2c-core. Jean, All of these seem to be cleanups/cosmetic enhancements rather than real bugfixes, except the ML address update. As you know, we've been trying to reduce the scope of

Re: [PATCH] cpm_uart: Fix dpram allocation and non-console uarts

2005-08-21 Thread Marcelo Tosatti
Hi, On Wed, Aug 17, 2005 at 10:42:36PM -0700, Nish Aravamudan wrote: On 8/8/05, Kumar Gala [EMAIL PROTECTED] wrote: (A believe Marcelo would like to see this in 2.6.13, but I'll let him fight over that ;) * Makes dpram allocations work * Makes non-console UART work on both 8xx and

Re: Linux 2.4.32-pre2

2005-07-28 Thread Marcelo Tosatti
On Thu, Jul 28, 2005 at 07:02:30PM +1000, Grant Coady wrote: On Wed, 27 Jul 2005 05:05:12 -0300, Marcelo Tosatti [EMAIL PROTECTED] wrote: Here goes another -pre, after a long period. Breaks Toshiba laptop: hard lockup -- what is on screen is same as working dmesg up to point: host/uhci.c

Linux 2.4.32-pre3

2005-08-08 Thread Marcelo Tosatti
Marowsky-Bree: fix oops when starting md multipath 2.4 kernel Linus Torvalds: PATCH: Fix outstanding gzip/zlib security issues Marcelo Tosatti: Change VERSION to v2.4.32-pre3 Merge rsync://rsync.kernel.org/.../davem/net-2.4 Patrick McHardy: [NETFILTER]: Use correct byteorder in ICMP NAT

Re: [RFC 1/3] non-resident page tracking

2005-08-09 Thread Marcelo Tosatti
Hi Rik, Two hopefully useful comments: i) ARC and its variants requires additional information about page replacement (namely whether the page has been reclaimed from the L1 or L2 lists). How costly would it be to add this information to the hash table? ii) From my reading of the patch, the

[PATCH] introduce config option to disable DMA zone on i386

2006-12-28 Thread Marcelo Tosatti
Hi, The following patch adds a config option to get rid of the DMA zone on i386. Architectures with devices that have no addressing limitations (eg. PPC) already work this way. This is useful for custom kernel builds where the developer is certain that there are no address limitations. For

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-10 Thread Marcelo Tosatti
On Fri, Sep 07, 2012 at 05:56:39PM +0800, Xiao Guangrong wrote: On 09/06/2012 10:09 PM, Avi Kivity wrote: On 08/22/2012 03:47 PM, Xiao Guangrong wrote: On 08/22/2012 08:06 PM, Avi Kivity wrote: On 08/21/2012 06:03 AM, Xiao Guangrong wrote: Introduce write_readonly_mem in mmio-exit-info to

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-11 Thread Marcelo Tosatti
On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in faults to non-existant/read-only/.../new-tag memslot), must handle the faults properly or avoid the

Re: [PATCH v2 4/5] KVM: MMU: introduce page_fault_start and page_fault_end

2012-09-19 Thread Marcelo Tosatti
On Tue, Sep 18, 2012 at 04:15:32PM +0800, Xiao Guangrong wrote: On 09/15/2012 11:25 PM, Marcelo Tosatti wrote: On Fri, Sep 14, 2012 at 05:59:06PM +0800, Xiao Guangrong wrote: Wrap the common operations into these two functions Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com

Re: [PATCH v8 1/3] KVM: x86: export svm/vmx exit code and vector code to userspace

2012-09-20 Thread Marcelo Tosatti
On Mon, Sep 17, 2012 at 07:58:57AM -0700, Arnaldo Carvalho de Melo wrote: Em Mon, Sep 17, 2012 at 04:31:13PM +0800, Dong Hao escreveu: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Exporting KVM exit information to userspace to be consumed by perf. [ Dong Hao

Re: qemu-kvm loops after kernel udpate

2012-09-11 Thread Marcelo Tosatti
On Tue, Sep 11, 2012 at 08:11:36PM +0200, Jiri Slaby wrote: Hi, it looks like an update from next-20120824 to next-20120910 makes kvm defunct. When I try to run qemu, it loops forever without printing anything on the monitor. -no-kvm makes it indeed work. Cmdline I use: qemu-kvm -k

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Marcelo Tosatti
On Tue, Sep 11, 2012 at 11:39:01AM -0300, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in faults to non-existant/read-only/.../new

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Marcelo Tosatti
On Wed, Sep 12, 2012 at 06:34:33PM +0300, Avi Kivity wrote: On 09/11/2012 05:39 PM, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result

Re: [PATCH v2 1/5] KVM: MMU: release noslot pfn on the fail path properly

2012-09-15 Thread Marcelo Tosatti
On Fri, Sep 14, 2012 at 05:57:22PM +0800, Xiao Guangrong wrote: We can not directly call kvm_release_pfn_clean to release the pfn since we can meet noslot pfn which is used to cache mmio info into spte Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c

Re: [PATCH v2 5/5] KVM: MMU: introduce FNAME(prefetch_gpte)

2012-09-15 Thread Marcelo Tosatti
On Fri, Sep 14, 2012 at 06:13:11PM +0800, Xiao Guangrong wrote: On 09/14/2012 05:59 PM, Xiao Guangrong wrote: + return FNAME(prefetch_gpte)(vcpu, sp, spte, gptep[i], true); Sorry, this was wrong. Update this patch. [PATCH v2 5/5] KVM: MMU: introduce FNAME(prefetch_gpte) The

Re: [PATCH v2 4/5] KVM: MMU: introduce page_fault_start and page_fault_end

2012-09-15 Thread Marcelo Tosatti
On Fri, Sep 14, 2012 at 05:59:06PM +0800, Xiao Guangrong wrote: Wrap the common operations into these two functions Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Why? I think people are used to spin_lock(lock) sequence spin_unlock(lock) So its easy to verify whether access

Re: [PATCH] KVM: VMX: invalidate vpid for invlpg instruction

2012-08-31 Thread Marcelo Tosatti
On Fri, Aug 31, 2012 at 06:10:48PM +0200, Davidlohr Bueso wrote: For processors that support VPIDs we should invalidate the page table entry specified by the lineal address. For this purpose add support for individual address invalidations. Not necessary - a single context invalidation is

[GIT PULL] KVM fixes for 3.6-rc3

2012-08-31 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fixes Alan Cox (1): kvm: Fix nonsense handling of compat ioctl Michael S. Tsirkin (1): KVM: x86: fix KVM_GET_MSR for PV EOI arch/x86/kvm/x86.c |3 +++

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-13 Thread Marcelo Tosatti
On Sat, Aug 11, 2012 at 11:36:20AM +0800, Xiao Guangrong wrote: On 08/11/2012 02:14 AM, Marcelo Tosatti wrote: On Tue, Aug 07, 2012 at 05:47:15PM +0800, Xiao Guangrong wrote: Changelog: - introduce KVM_PFN_ERR_RO_FAULT instead of dummy page - introduce KVM_HVA_ERR_BAD and optimize error

Re: [PATCH v8] kvm: notify host when the guest is panicked

2012-08-13 Thread Marcelo Tosatti
On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is panicked. If

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 01:48:39PM -0600, Eric Blake wrote: On 08/13/2012 12:21 PM, Marcelo Tosatti wrote: On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose

Re: [PATCH 0/3] Documentation : hypercalls

2012-08-13 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 01:09:46PM +0530, Raghavendra K T wrote: This is the hypercall documentation patch series First patch covers KVM specific hypercall information. second patch is has typo fix for vmcall instruction comment in kvm_para.h Third patch includes a veryful documentation

Re: [PATCH] kvm: disable stealtime via reboot notifier to avoid mem corruption

2012-08-13 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 12:36:22PM +0200, Florian Westphal wrote: else, we get memory corruption on reboot; found when tracking down initramfs unpack error on initial reboot (with qemu-kvm -smp 2, no problem with single-core). problem with doing it via kvm_shutdown() is that this file

Re: [PATCH repost] kvm: drop parameter validation

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 05:30:53PM +0300, Gleb Natapov wrote: On Mon, Aug 13, 2012 at 01:43:58PM +0300, Michael S. Tsirkin wrote: We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called. Drop it. I would

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 10:47:48AM +0300, Gleb Natapov wrote: On Mon, Aug 13, 2012 at 05:24:52PM -0300, Marcelo Tosatti wrote: On Mon, Aug 13, 2012 at 01:48:39PM -0600, Eric Blake wrote: On 08/13/2012 12:21 PM, Marcelo Tosatti wrote: On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 10:58:07AM +0800, Xiao Guangrong wrote: On 08/14/2012 01:39 AM, Marcelo Tosatti wrote: On Sat, Aug 11, 2012 at 11:36:20AM +0800, Xiao Guangrong wrote: On 08/11/2012 02:14 AM, Marcelo Tosatti wrote: On Tue, Aug 07, 2012 at 05:47:15PM +0800, Xiao Guangrong wrote

Re: [PATCH] kvm: disable stealtime via reboot notifier to avoid mem corruption

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 11:15:06AM +0200, Florian Westphal wrote: Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Aug 10, 2012 at 12:36:22PM +0200, Florian Westphal wrote: --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -191,7 +191,6 @@ static void

Re: [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote: On Aug 14, 2012, at 1:42 PM, Jan Kiszka wrote: On 2012-08-14 10:56, Daniel P. Berrange wrote: On Mon, Aug 13, 2012 at 03:21:32PM -0300, Marcelo Tosatti wrote: On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 05:00:33PM +0300, Avi Kivity wrote: On 08/10/2012 09:14 PM, Marcelo Tosatti wrote: On Tue, Aug 07, 2012 at 05:47:15PM +0800, Xiao Guangrong wrote: Changelog: - introduce KVM_PFN_ERR_RO_FAULT instead of dummy page - introduce KVM_HVA_ERR_BAD and optimize error hva

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote: On Aug 14, 2012, at 1:42 PM, Jan Kiszka wrote: On 2012-08-14 10:56, Daniel P. Berrange wrote: On Mon, Aug

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked\

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 05:59:06PM -0500, Anthony Liguori wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 01:44:14PM +0300, Avi Kivity wrote: On 08/14/2012 06:51 PM, Marcelo Tosatti wrote: Userspace may want to modify the ROM (for example, when programming a flash device). It is also possible to map an hva range rw through one slot and ro through another. Right

Re: [PATCH V2] KVM: x86: disable stealtime on reboot to avoid mem corruption

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 04:00:40PM +0200, Florian Westphal wrote: else, host continues to update stealtime after reboot, which can corrupt e.g. initramfs area. found when tracking down initramfs unpack error on initial reboot (with qemu-kvm -smp 2, no problem with single-core).

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-16 Thread Marcelo Tosatti
On Thu, Aug 16, 2012 at 12:03:01PM +0300, Avi Kivity wrote: On 08/15/2012 08:53 PM, Marcelo Tosatti wrote: On Wed, Aug 15, 2012 at 01:44:14PM +0300, Avi Kivity wrote: On 08/14/2012 06:51 PM, Marcelo Tosatti wrote: Userspace may want to modify the ROM (for example, when programming

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-16 Thread Marcelo Tosatti
On Thu, Aug 16, 2012 at 01:49:11PM +0800, Xiao Guangrong wrote: On 08/14/2012 11:25 PM, Marcelo Tosatti wrote: On Tue, Aug 14, 2012 at 10:58:07AM +0800, Xiao Guangrong wrote: On 08/14/2012 01:39 AM, Marcelo Tosatti wrote: On Sat, Aug 11, 2012 at 11:36:20AM +0800, Xiao Guangrong wrote

Re: [PATCH v5 02/12] KVM: hide KVM_MEMSLOT_INVALID from userspace

2012-08-09 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:48:49PM +0800, Xiao Guangrong wrote: Quote Avi's comment: | KVM_MEMSLOT_INVALID is actually an internal symbol, not used by | userspace. Please move it to kvm_host.h. Also, move KVM_MEMSLOT_INVALID to the highest bit Signed-off-by: Xiao Guangrong

Re: [PATCH 0/3] Documentation : hypercalls

2012-08-09 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 01:09:46PM +0530, Raghavendra K T wrote: This is the hypercall documentation patch series First patch covers KVM specific hypercall information. second patch is has typo fix for vmcall instruction comment in kvm_para.h Third patch includes a veryful documentation

Re: [PATCH v5 03/12] KVM: introduce gfn_to_pfn_memslot_atomic

2012-08-09 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:49:36PM +0800, Xiao Guangrong wrote: It can instead of hva_to_pfn_atomic Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c |5 + include/linux/kvm_host.h |3 ++- virt/kvm/kvm_main.c | 14 --

Re: [PATCH v5 05/12] KVM: reorganize hva_to_pfn

2012-08-10 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:51:05PM +0800, Xiao Guangrong wrote: We do too many things in hva_to_pfn, this patch reorganize the code, let it be better readable Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- virt/kvm/kvm_main.c | 159

Re: [PATCH v5 00/12] KVM: introduce readonly memslot

2012-08-10 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:47:15PM +0800, Xiao Guangrong wrote: Changelog: - introduce KVM_PFN_ERR_RO_FAULT instead of dummy page - introduce KVM_HVA_ERR_BAD and optimize error hva indicators The test case can be found at:

Re: [PATCH v5 11/12] KVM: x86: introduce set_mmio_exit_info

2012-08-10 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:54:42PM +0800, Xiao Guangrong wrote: Introduce set_mmio_exit_info to cleanup the common code Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c | 33 + 1 files changed, 17 insertions(+), 16

[GIT PULL] KVM fixes for 3.6-rc3

2012-08-23 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fixes: Alan Cox (1): ppc: e500_tlb memset clears nothing Alexander Graf (1): KVM: PPC: Add cache flush on page map Avi Kivity (1): KVM: x86 emulator: use stack

Re: [PATCH] KVM: trace the events of mmu_notifier

2012-08-23 Thread Marcelo Tosatti
On Tue, Aug 21, 2012 at 05:51:35PM +0800, Xiao Guangrong wrote: mmu_notifier is the interface to broadcast the mm events to KVM, the tracepoints introduced in this patch can trace all these events, it is very helpful for us to notice and fix the bug caused by mm Signed-off-by: Xiao Guangrong

Re: [PATCH] KVM: trace the events of mmu_notifier

2012-08-23 Thread Marcelo Tosatti
On Thu, Aug 23, 2012 at 08:30:15PM +0800, Xiao Guangrong wrote: On 08/23/2012 05:24 PM, Marcelo Tosatti wrote: On Tue, Aug 21, 2012 at 05:51:35PM +0800, Xiao Guangrong wrote: mmu_notifier is the interface to broadcast the mm events to KVM, the tracepoints introduced in this patch can trace

Re: [GIT PULL] KVM fixes for 3.6-rc3

2012-08-24 Thread Marcelo Tosatti
On Thu, Aug 23, 2012 at 09:54:43PM -0700, Linus Torvalds wrote: On Thu, Aug 23, 2012 at 12:30 AM, Marcelo Tosatti mtosa...@redhat.com wrote: Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fixes: I'm not seeing what you claim

Re: [PATCHv2] kvm: Fix nonsense handling of compat ioctl

2012-08-27 Thread Marcelo Tosatti
On Wed, Aug 22, 2012 at 02:34:11PM +0100, Alan Cox wrote: From: Alan Cox a...@linux.intel.com KVM_SET_SIGNAL_MASK passed a NULL argument leaves the on stack signal sets uninitialized. It then passes them through to kvm_vcpu_ioctl_set_sigmask. We should be passing a NULL in this case not

Re: [PATCH for-3.6] kvm: fix KVM_GET_MSR for PV EOI

2012-08-27 Thread Marcelo Tosatti
On Sun, Aug 26, 2012 at 06:00:29PM +0300, Michael S. Tsirkin wrote: KVM_GET_MSR was missing support for PV EOI, which is needed for migration. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Please consider this bugfix patch for 3.6. Thanks! arch/x86/kvm/x86.c | 3 +++ 1 file

Re: [PATCH for-3.6] kvm: fix KVM_GET_MSR for PV EOI

2012-08-27 Thread Marcelo Tosatti
On Mon, Aug 27, 2012 at 05:47:42PM -0300, Marcelo Tosatti wrote: On Sun, Aug 26, 2012 at 06:00:29PM +0300, Michael S. Tsirkin wrote: KVM_GET_MSR was missing support for PV EOI, which is needed for migration. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Please consider

Re: [PATCH] Documentation/kvm : Add documentation on Hypercalls

2012-07-31 Thread Marcelo Tosatti
On Tue, Jul 24, 2012 at 02:23:59PM +0530, Raghavendra K T wrote: From: Raghavendra K T raghavendra...@linux.vnet.ibm.com Thanks Alex for KVM_HC_FEATURES inputs and Jan for VAPIC_POLL_IRQ, and Peter (HPA) for suggesting hypercall ABI addition. Signed-off-by: Raghavendra K T

Re: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set

2012-07-31 Thread Marcelo Tosatti
On Thu, Jul 26, 2012 at 02:22:48PM +0200, Markus Trippelsdorf wrote: Every time I start qemu-kvm on my system the following line is added to the syslog: vcpu0 unhandled rdmsr: 0xc0010001 AFAICS all calls to vcpu_unimpl only contain debugging info with little or no value for the end user.

Re: [PATCH] Documentation/kvm : Add documentation on Hypercalls

2012-08-01 Thread Marcelo Tosatti
On Wed, Aug 01, 2012 at 04:19:01PM +0530, Raghavendra K T wrote: On 08/01/2012 08:37 AM, Marcelo Tosatti wrote: On Tue, Jul 24, 2012 at 02:23:59PM +0530, Raghavendra K T wrote: From: Raghavendra K Traghavendra...@linux.vnet.ibm.com Thanks Alex for KVM_HC_FEATURES inputs and Jan

Re: [PATCH 3/9] KVM: define kvm_hwpoison_pfn statically

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:13:41PM +0800, Xiao Guangrong wrote: Then, get_hwpoison_pfn and is_hwpoison_pfn can be removed Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c |2 +- include/linux/kvm_host.h |4 ++-- virt/kvm/kvm_main.c |

Re: [PATCH 8/9] KVM: do not release the error pfn

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:18:58PM +0800, Xiao Guangrong wrote: After commit a2766325cf9f9, the error pfn is replaced by the error code, it need not be released anymore [ The patch is compiling tested for powerpc ] Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com ---

Re: [PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:14:25PM +0800, Xiao Guangrong wrote: Then, remove get_bad_pfn Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c |7 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff

Re: [PATCH 2/9] KVM: define kvm_fault_pfn statically

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:12:58PM +0800, Xiao Guangrong wrote: After that, the exported and un-inline function, get_fault_pfn, can be removed Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c |2 +- include/linux/kvm_host.h |3 ++-

Re: [PATCH 7/9] KVM: define kvm_bad_page statically

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:16:28PM +0800, Xiao Guangrong wrote: It is used to eliminate the overload of function call and cleanup the code Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- include/linux/kvm_host.h |9 +++-- virt/kvm/async_pf.c |2 +-

[GIT PULL] KVM fixes for 3.6-rc2

2012-08-03 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM _bug fixes_: - Fix DS/ES segment register corruption on x86_32. - Fix kvmclock wallclock migration offset. - Fix PIT interrupt ACK vs system reset logic bug. Avi Kivity (1):

Re: [PATCH v2 01/10] KVM: iommu: fix releasing unmapped page

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 03:36:52PM +0800, Xiao Guangrong wrote: There are two bugs: - the 'error page' is forgot to be released [ it is unneeded after commit a2766325cf9f9, for backport, we still do kvm_release_pfn_clean for the error pfn ] - guest pages are always released regardless

Re: [RFC][PATCH 3/5] add /dev/mem_notify device

2008-01-15 Thread Marcelo Tosatti
Hi Alan, On Tue, Jan 15, 2008 at 11:20:27AM +, Alan Cox wrote: On Tue, 15 Jan 2008 19:59:02 +0900 KOSAKI Motohiro [EMAIL PROTECTED] wrote: the core of this patch series. add /dev/mem_notify device for notification low memory to user process. As you only wake one process

Re: [RFC][PATCH 3/5] add /dev/mem_notify device

2008-01-15 Thread Marcelo Tosatti
On Wed, Jan 16, 2008 at 10:57:16AM +0900, KOSAKI Motohiro wrote: Hi Pavel err = poll(pollfds, 1, -1); // wake up at low memory ... /usage example Nice, this is really needed for openmoko, zaurus, etc But this changelog needs to go into Documentation/...

Re: [PATCH] kvm: handle last_boosted_vcpu = 0 case

2012-07-06 Thread Marcelo Tosatti
On Tue, Jun 19, 2012 at 04:51:04PM -0400, Rik van Riel wrote: On Wed, 20 Jun 2012 01:50:50 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: In ple handler code, last_boosted_vcpu (lbv) variable is serving as reference point to start when we enter. Also statistical

Re: [PATCH 5/9] KVM: MMU: fask check write-protect for direct mmu

2012-07-20 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 11:45:59AM +0800, Xiao Guangrong wrote: BTW, they are some bug fix patches on -master branch, but it is not existed on -next branch: commit: f411930442e01f9cf1bf4df41ff7e89476575c4d commit: 85b7059169e128c57a3a8a3e588fb89cb2031da1 It causes code conflict if we do the

Re: [PATCH 2/9] KVM: x86: simplify read_emulated

2012-07-20 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 10:17:36AM +0800, Xiao Guangrong wrote: On 07/20/2012 07:58 AM, Marcelo Tosatti wrote: - } + rc = ctxt-ops-read_emulated(ctxt, addr, mc-data + mc-end, size, +ctxt-exception); + if (rc != X86EMUL_CONTINUE) + return rc

Re: [PATCH 5/9] KVM: MMU: fask check write-protect for direct mmu

2012-07-20 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 10:34:28AM +0800, Xiao Guangrong wrote: On 07/20/2012 08:39 AM, Marcelo Tosatti wrote: On Tue, Jul 17, 2012 at 09:53:29PM +0800, Xiao Guangrong wrote: If it have no indirect shadow pages we need not protect any gfn, this is always true for direct mmu without nested

Re: [PATCH RFC V5 0/3] kvm: Improving directed yield in PLE handler

2012-07-20 Thread Marcelo Tosatti
+++ virt/kvm/Kconfig |3 +++ virt/kvm/kvm_main.c | 41 + 5 files changed, 85 insertions(+), 0 deletions(-) Reviewed-by: Marcelo Tosatti mtosa...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCHv2] kvm: fix race with level interrupts

2012-07-20 Thread Marcelo Tosatti
On Thu, Jul 19, 2012 at 01:45:20PM +0300, Michael S. Tsirkin wrote: When more than 1 source id is in use for the same GSI, we have the following race related to handling irq_states race: CPU 0 clears bit 0. CPU 0 read irq_state as 0. CPU 1 sets level to 1. CPU 1 calls kvm_ioapic_set_irq(1).

Re: [PATCH] kvm: drop parameter validation

2012-07-20 Thread Marcelo Tosatti
On Thu, Jul 19, 2012 at 02:13:13PM +0300, Michael S. Tsirkin wrote: We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called. Drop it. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Note: this is on top

Re: [PATCH 2/9] KVM: x86: simplify read_emulated

2012-07-20 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 09:15:44PM +0800, Xiao Guangrong wrote: On 07/20/2012 06:58 PM, Marcelo Tosatti wrote: On Fri, Jul 20, 2012 at 10:17:36AM +0800, Xiao Guangrong wrote: On 07/20/2012 07:58 AM, Marcelo Tosatti wrote: -} +rc = ctxt-ops-read_emulated(ctxt, addr, mc

Re: [PATCH] KVM: MMU: optimize for set_spte

2012-12-05 Thread Marcelo Tosatti
On Tue, Dec 04, 2012 at 07:17:11AM +0800, Xiao Guangrong wrote: There are two cases we need to adjust page size in set_spte: 1): the one is other vcpu creates new sp in the window between mapping_level() and acquiring mmu-lock. 2): the another case is the new sp is created by itself

Re: [RFC PATCH 4/6] kvm: Move private memory slots to start of memslots array

2012-12-05 Thread Marcelo Tosatti
On Mon, Dec 03, 2012 at 04:39:30PM -0700, Alex Williamson wrote: In order to make the memslots array grow on demand, move the private slots to the lower indexes of the array. The private slots are assumed likely to be in use, so if we didn't do this we'd end up allocating the full memslots

Re: [RFC PATCH 3/6] kvm: Merge id_to_index into memslots

2012-12-05 Thread Marcelo Tosatti
On Mon, Dec 03, 2012 at 04:39:24PM -0700, Alex Williamson wrote: This allows us to resize this structure and therefore the number of memslots as part of the RCU update. Why is this necessary? struct memslots is updated, message above conflicts with that. If there is a reason, id_to_index

Re: [RFC PATCH 5/6] kvm: Re-introduce memslots-nmemslots

2012-12-05 Thread Marcelo Tosatti
On Mon, Dec 03, 2012 at 04:39:36PM -0700, Alex Williamson wrote: struct kvm_memory_slot is currently 52 bytes (LP64), not counting the arch data. On x86 this means the memslot array to support a tiny 32+3 entries (user+private) is over 2k. We'd like to support more slots so that we can

Re: [RFC PATCH 0/6] kvm: Growable memory slot array

2012-12-05 Thread Marcelo Tosatti
On Mon, Dec 03, 2012 at 04:39:05PM -0700, Alex Williamson wrote: Memory slots are currently a fixed resource with a relatively small limit. When using PCI device assignment in a qemu guest it's fairly easy to exhaust the number of available slots. I posted patches exploring growing the

<    1   2   3   4   5   6   7   8   9   10   >