On Mon, Jan 07, 2008 at 12:29:51PM +0100, Jan Kara wrote:
On Sun 23-12-07 02:51:09, [EMAIL PROTECTED] wrote:
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL
On Mon, Jan 07, 2008 at 12:26:18PM +, Christoph Hellwig wrote:
On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote:
+static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb,
__u32 index)
+{
+ struct udf_part_map *map = UDF_SB(sb)-s_partmaps[index];
+
On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote:
On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote:
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
I'm not sure if this improves readability in general. If the code is
really a loop in nature, then we should code it using do {} while
On Mon, Jan 07, 2008 at 03:28:15PM -0800, Andrew Morton wrote:
On Mon, 7 Jan 2008 21:44:26 +0100
Marcin Slusarz [EMAIL PROTECTED] wrote:
There's some overly long lines here and some odd style, this should look
more like:
These long lines were split later in [PATCH 1/7] udf: fix coding
On Tue, Jan 08, 2008 at 11:17:32AM +0100, Jan Kara wrote:
On Mon 07-01-08 22:10:01, Marcin Slusarz wrote:
On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote:
On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote:
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
I'm not sure
.
Marcin Slusarz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
warnings, 1872 lines checked
all 164 warnings left are lines longer than 80 characters;
this file has too much indentation with really long expressions
to break all those lines now; will fix later
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL
- convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function
- convert kmalloc + memset to kcalloc
- check if kcalloc failed (partially)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
Acked-by: Christoph Hellwig
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/super.c |5 -
1 files
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function
convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/balloc.c |4 +---
fs/udf/super.c | 16 ++--
fs/udf/udf_sb.h |2 ++
3 files changed, 13 insertions(+), 9
fix sparse warnings:
fs/udf/super.c:1431:24: warning: symbol 'bh' shadows an earlier one
fs/udf/super.c:1347:21: originally declared here
fs/udf/super.c:472:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema
after: 1 errors, 38 warnings, 9468 lines checked
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/balloc.c| 231 +++---
fs/udf/crc.c |2 +-
fs/udf/directory.c | 83 ---
fs/udf/file.c | 18 +-
fs/udf/ialloc.c| 24 ++-
fs/udf/inode.c
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/inode.c | 15 ++-
fs/udf/misc.c| 35 ++-
fs/udf/namei.c |9 +
fs/udf/super.c | 16
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/balloc.c | 49 -
1 files changed, 20 insertions(+), 29 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/balloc.c | 118 +++---
1 files changed, 59 insertions(+), 59 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf
convert byte order of constant instead of variable,
which can be done at compile time (vs run time)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL PROTECTED]
---
fs/udf/directory.c |4 ++--
fs/udf/inode.c | 16
fs/udf/misc.c | 12
udf_debug should be enclosed with do { } while (0)
to be safely used in code like below:
if (something)
udf_debug();
else
anything;
(Otherwise compiler will not compile it with:
error: expected expression before 'else')
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/super.c | 59 ---
1 files changed, 30 insertions(+), 29 deletions(-)
diff --git a/fs/udf/super.c b/fs/udf
On Fri, Jan 11, 2008 at 12:24:49AM +0100, Jan Kara wrote:
On Thu 10-01-08 23:06:26, [EMAIL PROTECTED] wrote:
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
Just two minor comment...
---
fs/udf/balloc.c | 49
On Tue, Dec 18, 2007 at 03:36:42PM -0800, Andrew Morton wrote:
On Sun, 9 Dec 2007 22:23:42 +0100
Marcin __lusarz [EMAIL PROTECTED] wrote:
usb/storage/initializers.c: fix signedness difference
Signed-off-by: Marcin __lusarz [EMAIL PROTECTED]
---
drivers/usb/storage/initializers.c |
On Mon, Dec 17, 2007 at 10:30:01AM +0100, Takashi Iwai wrote:
At Sun, 16 Dec 2007 02:58:31 +0100,
Marcin Slusarz wrote:
On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote:
At Sat, 8 Dec 2007 21:50:45 +0100,
Marcin Ślusarz wrote:
sound/core.h: include sound/driver.h
' shadows an earlier one
fs/udf/super.c:1648:6: originally declared here
fs/udf/super.c:450:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
Thanks for the patch. The 'bh' change
:got unsigned int *noident
fs/udf/namei.c:1152:78: warning: incorrect type in argument 3 (different
signedness)
fs/udf/namei.c:1152:78:expected int *offset
fs/udf/namei.c:1152:78:got unsigned int *noident
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
I don't think
sparse generated:
fs/udf/dir.c:78:5: warning: symbol 'udf_readdir' was not declared. Should it be
static?
there are 2 different prototypes of udf_readdir - remove them and move
code around to make it still compile
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL
fix coding style, checkpatch warned about:
- braces {} are not necessary for single statement blocks
- line over 80 characters
- do not use assignment in if condition
- use tabs not spaces
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL
to uint32_t
gcc warned:
fs/udf/inode.c: In function 'udf_get_block':
fs/udf/inode.c:299: warning: 'phys' may be used uninitialized in this function
initialize it to 0 (if someday someone will break inode_getblk we will catch it
immediately)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben
make reading do_udf_readdir easier by adding new variable
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL PROTECTED]
---
fs/udf/dir.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/fs/udf/dir.c b
type in argument 3 (different
signedness)
fs/udf/namei.c:1152:78:expected int *offset
fs/udf/namei.c:1152:78:got unsigned int *noident
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
Acked-by: Jan Kara [EMAIL PROTECTED]
---
fs/udf/namei.c |2 +-
1 files changed, 1 insertions(+), 1
On Fri, Dec 21, 2007 at 04:21:17PM -0800, Andrew Morton wrote:
On Fri, 21 Dec 2007 16:55:03 +0100
Marcin Slusarz [EMAIL PROTECTED] wrote:
sparse generated:
fs/udf/dir.c:78:5: warning: symbol 'udf_readdir' was not declared. Should
it be static?
there are 2 different prototypes
going to do more cleanups later.
PS: This is the first time I use git-send-email - tell me if I do something
wrong.
Marcin Slusarz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
warnings, 1872 lines checked
all 164 warnings left are lines longer than 80 characters;
this file has too much indentation with really long expressions
to break all those lines
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf
rename UDF_SB function to udf_sb
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c | 12 ++--
fs/udf/ialloc.c |4 ++--
fs/udf/inode.c |6 +++---
fs/udf/super.c | 32
macro UDF_SB_PARTMAPS - function udf_sb_partmaps
macro UDF_SB_FREE - function udf_sb_free
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c | 24 ++--
fs/udf/super.c | 52
- change UDF_SB_VOLIDENT macro to udf_sb_volume_ident inline function
- rename s_volident field to s_volume_ident
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/file.c |2 +-
fs/udf/super.c
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/partition.c |6 +++---
fs/udf/super.c | 20 ++--
fs/udf/udf_sb.h| 10 +++---
3 files changed, 20 insertions(+), 16 deletions(-)
diff
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c | 10
fs/udf/super.c | 68 +++---
fs/udf/udf_sb.h |6 -
3 files changed, 44 insertions(+), 40
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/misc.c |8
fs/udf/super.c | 28 ++--
fs/udf/udf_sb.h |6 +-
3 files changed, 23 insertions(+), 19 deletions(-)
diff --git
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/super.c | 44 ++--
fs/udf/udf_sb.h |6 +-
2 files changed, 27 insertions(+), 23 deletions(-)
diff --git a/fs/udf/super.c
- change UDF_SB_LASTBLOCK macro to udf_sb_last_block inline function
- rename s_lastblock field to s_last_block
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/super.c| 20 ++--
fs/udf
- change UDF_SB_LVIDBH macro to udf_sb_lvid_bh inline function
- rename s_lvidbh field to s_lvid_bh
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c | 26 +-
fs/udf/ialloc.c
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c | 24
fs/udf/ialloc.c |2 +-
fs/udf/namei.c |4 ++--
fs/udf/super.c | 40
fs/udf
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/ialloc.c | 16
fs/udf/super.c | 34 +-
fs/udf/udf_sb.h | 10 --
3 files changed, 33 insertions(+), 27
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/udf_sb.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/udf/udf_sb.h b/fs/udf/udf_sb.h
index a9ff8fb..8683b71 100644
--- a/fs/udf/udf_sb.h
- change UDF_SB_RECORDTIME macro to udf_sb_record_time inline function
- rename s_recordtime field to s_record_time
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/inode.c| 14 +++---
fs/udf/super.c
- change UDF_SB_SERIALNUM macro to udf_sb_serial_number inline function
- rename s_serialnum field to s_serial_number
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/inode.c|2 +-
fs/udf/misc.c
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/balloc.c |2 +-
fs/udf/inode.c| 14 +++---
fs/udf/misc.c |2 +-
fs/udf/namei.c|2 +-
fs/udf/super.c| 10 +-
fs/udf
- change UDF_SB_VAT macro to udf_sb_vat_inode inline function
- rename s_vat field to s_vat_inode
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/partition.c|6 +++---
fs/udf/super.c| 24
- change UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps inline
function
- convert kmalloc + memset to kzalloc
- check if kzalloc failed (partially)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/super.c
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/super.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/ialloc.c |2 +-
fs/udf/udf_sb.h |8 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c
index 269f588..4d1684c
remove macros:
- UDF_SB_PARTTYPE
- UDF_SB_PARTROOT
- UDF_SB_PARTLEN
- UDF_SB_PARTVSN
- UDF_SB_PARTNUM
- UDF_SB_TYPESPAR
- UDF_SB_TYPEVIRT
- UDF_SB_PARTFUNC
- UDF_SB_PARTFLAGS
and replace all uses
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf/super.c |4 ++--
fs/udf/udf_sb.h | 37 -
2 files changed, 22 insertions(+), 19 deletions(-)
diff --git a/fs/udf/super.c b/fs/udf
: symbol 'i' shadows an earlier one
fs/udf/super.c:1701:6: originally declared here
fs/udf/super.c:1714:4: warning: symbol 'i' shadows an earlier one
fs/udf/super.c:1701:6: originally declared here
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL
fix warnings:
fs/udf/super.c:1370:24: warning: symbol 'bh' shadows an earlier one
fs/udf/super.c:1288:21: originally declared here
fs/udf/super.c:450:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL
to super.c
19 didn't change
22,23 was combined into one and functions moved from udf_sb.h to super.c
24 didn't change
Marcin Slusarz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
warnings, 1872 lines checked
all 164 warnings left are lines longer than 80 characters;
this file has too much indentation with really long expressions
to break all those lines now
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf
- convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function
- convert kmalloc + memset to kzalloc
- check if kzalloc failed (partially)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/super.c |7 ++-
1 files
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function
convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf
fix sparse warnings:
fs/udf/super.c:1431:24: warning: symbol 'bh' shadows an earlier one
fs/udf/super.c:1347:21: originally declared here
fs/udf/super.c:472:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema
there was a mismatch between externs in logo.c and code generated by pnmtologo
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Antonino Daplas [EMAIL PROTECTED]
CC: Andrew Morton [EMAIL PROTECTED]
CC: Sam Ravnborg [EMAIL PROTECTED]
---
drivers/video/logo/Makefile |8
drivers/video/logo/logo.c
On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote:
At Sat, 8 Dec 2007 21:50:45 +0100,
Marcin Ślusarz wrote:
sound/core.h: include sound/driver.h
include sound/driver.h in sound/core.h because core.h
uses SNDRV_CARDS (which is defined in sound/driver.h)
Signed-off-by:
sparse generated:
fs/udf/dir.c:78:5: warning: symbol 'udf_readdir' was not declared. Should it be
static?
there are 2 different prototypes of udf_readdir - remove them and move
code around to make it still compile
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED
make reading do_udf_readdir easier by adding new variable
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
---
fs/udf/dir.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/fs/udf/dir.c b/fs/udf/dir.c
index 174d2fc..c26e281
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/dir.c | 46 +++---
1 files changed, 27 insertions(+), 19 deletions(-)
diff --git a/fs/udf/dir.c b/fs/udf/dir.c
index c26e281..c5e38d6 100644
--- a/fs/udf/dir.c
+++ b/fs/udf/dir.c
@@ -65,24 +65,26
to uint32_t
gcc warned:
fs/udf/inode.c: In function 'udf_get_block':
fs/udf/inode.c:299: warning: 'phys' may be used uninitialized in this function
initialize it to 0 (if someday someone will break inode_getblk we will catch it
immediately)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben
type in argument 3 (different
signedness)
fs/udf/namei.c:1152:78:expected int *offset
fs/udf/namei.c:1152:78:got unsigned int *noident
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/namei.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/udf/namei.c
/super.c:450:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
---
fs/udf/super.c | 15 +++
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/udf/super.c b/fs/udf
: warning: incorrect type in argument 5
(different signedness)
drivers/usb/storage/initializers.c:89:26:expected unsigned int *act_len
drivers/usb/storage/initializers.c:89:26:got int *noident
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Greg Kroah-Hartman [EMAIL PROTECTED
fix warning:
drivers/usb/core/devio.c:1226:20: warning: incorrect type in assignment
(different address spaces)
drivers/usb/core/devio.c:1226:20:expected void *usercontext
drivers/usb/core/devio.c:1226:20:got void [noderef] asn:1*
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Greg
fix warning:
drivers/usb/host/ehci-hcd.c:832:8: warning: symbol 'status' shadows an earlier
one
drivers/usb/host/ehci-hcd.c:790:71: originally declared here
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Greg Kroah-Hartman [EMAIL PROTECTED]
---
drivers/usb/host/ehci-hcd.c |8
comverted - converted
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
include/asm-ia64/compat.h|2 +-
include/asm-mips/compat.h|2 +-
include/asm-parisc/compat.h |2 +-
include/asm-powerpc/compat.h |2 +-
include/asm-s390/compat.h|2 +-
include/asm-sparc64
On Tue, Dec 25, 2007 at 11:54:38AM +, Christoph Hellwig wrote:
Looks generally good, but it would be nice if you could avoid
introducing new overly long lines. Then again this really won't be
noticed in udf anyway and it looks like you plan to clean it up later
anyway.
Yes, that's what
convert byte order of constant instead of variable
it will be done at compile time (vs run time)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
drivers/net/qla3xxx.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
convert byte order of constant instead of variable
it will be done at compile time (vs run time)
ext3/4 bits are #if 0'ed, but someone might copy this code into other places
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/ext2/super.c |8 +++-
fs/ext3/super.c |2 +-
fs/ext4
convert byte order of constant instead of variable
it will be done at compile time (vs run time)
remove unused le32_and_cpu
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Mark Fasheh [EMAIL PROTECTED]
CC: Kurt Hackel [EMAIL PROTECTED]
---
fs/ocfs2/endian.h |5 -
fs/ocfs2/inode.c
+ memset to kcalloc
- check if kcalloc failed (partially)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/super.c | 25 +++--
fs/udf/udf_sb.h | 13 -
2
* alloc_slabmgmt: initialize all slab fields in 1 function
* slab-nodeid was initialized twice: in alloc_slabmgmt
and immediately after it in cache_grow
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Christoph Lameter [EMAIL PROTECTED]
CC: Pekka Enberg [EMAIL PROTECTED]
diff --git a/mm
Hi
Today I've got this (while i was upgrading my gentoo box):
WARNING: at kernel/lockdep.c:2658 check_flags()
Pid: 21680, comm: conftest Not tainted 2.6.24-rc6 #63
Call Trace:
[80253457] check_flags+0x1c7/0x1d0
[80257217] lock_acquire+0x57/0xc0
[8024d5c0]
-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/ext3/balloc.c |7 +
fs/ext3/ialloc.c | 12 +++--
fs/ext3/resize.c | 12 +++--
fs/ext3/super.c |2 +-
fs/ext3/xattr.c |6 +---
fs/ocfs2/cluster
On Sun, Dec 30, 2007 at 07:18:25PM +, Christoph Hellwig wrote:
On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote:
There are many places where these functions would be useful.
(just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]'
linux-src/)
What do you
On Mon, Dec 31, 2007 at 11:38:01AM -0800, Mark Fasheh wrote:
On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote:
There are many places where these functions would be useful.
(just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]'
linux-src/)
What do you think
:
* be16_add_cpu(__be16 *var, u16 val)
* be64_add_cpu(__be64 *var, u64 val)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Mark Fasheh [EMAIL PROTECTED]
---
fs/ocfs2/cluster/endian.h | 30
fs/ocfs2/cluster/nodemanager.c|1 -
fs/ocfs2/dlm/dlmast.c
-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/ext3/balloc.c |7 ++-
fs/ext3/ialloc.c | 12
fs/ext3/resize.c | 12
fs/ext3/super.c |2 +-
fs/ext3/xattr.c |6 ++
5 files changed, 13 insertions(+), 26 deletions(-)
diff --git a/fs/ext3/balloc.c b
remove beX_add functions and replace all uses with beX_add_cpu
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/xfs/quota/xfs_qm.c |6 ++--
fs/xfs/quota/xfs_trans_dquot.c |6 ++--
fs/xfs/xfs_alloc.c | 16 +++---
fs/xfs/xfs_alloc_btree.c | 16
[ble12346]*([ble12346]*_to_cpu.*[-+]' linux-src/
Patch for ext3 is an example how conversions will probably look like.
ps: this patchset depends on http://lkml.org/lkml/2007/12/25/35 (which is
in ocfs2 git tree, branches: trivial, ALL)
Marcin Slusarz
--
To unsubscribe from this list: send the line
it up almost completely.
(Only 3rd patch changed from second version)
Second version: http://lkml.org/lkml/2007/12/23/197
First version: http://lkml.org/lkml/2007/12/22/150
Marcin Slusarz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
warnings, 1872 lines checked
all 164 warnings left are lines longer than 80 characters;
this file has too much indentation with really long expressions
to break all those lines
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
---
fs/udf
- convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function
- convert kmalloc + memset to kcalloc
- check if kcalloc failed (partially)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
Acked-by: Christoph Hellwig
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf/super.c |7 ++-
1 files
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function
convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema [EMAIL PROTECTED]
CC: Jan Kara [EMAIL PROTECTED]
CC: Christoph Hellwig [EMAIL PROTECTED]
---
fs/udf
fix sparse warnings:
fs/udf/super.c:1431:24: warning: symbol 'bh' shadows an earlier one
fs/udf/super.c:1347:21: originally declared here
fs/udf/super.c:472:6: warning: symbol 'udf_write_super' was not declared.
Should it be static?
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
CC: Ben Fennema
Ehh, forgot to add patching order :(
Should be:
[PATCH 1/6] udf: fix coding style of super.c
[PATCH 2/6] udf: remove some ugly macros
[PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to
udf_sb_alloc_partition_maps function
[PATCH 4/6] udf: check if udf_load_logicalvol failed
[PATCH 5/6] udf:
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/balloc.c | 309 ---
1 files changed, 157 insertions(+), 152 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
index d1d4b8f..5ce7926 100644
--- a/fs/udf/balloc.c
+++ b/fs/udf
convert byte order of constant instead of variable,
which can be done at compile time (vs run time)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/directory.c |4 ++--
fs/udf/inode.c | 16
fs/udf/misc.c | 12 ++--
fs/udf/super.c | 16
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/balloc.c | 49 -
1 files changed, 20 insertions(+), 29 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
index 17b67dc..d1d4b8f 100644
--- a/fs/udf/balloc.c
+++ b/fs/udf
This is preparation for 7th patch.
[PATCH 7/7] udf: cache struct udf_inode_info
Patchset depends on udf patches in -mm and this:
http://lkml.org/lkml/2008/1/5/196
(Runtime tested: mount, open, read, seek, close, umount)
Marcin Slusarz
--
To unsubscribe from this list: send the line unsubscribe
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
fs/udf/inode.c | 15 ++-
fs/udf/misc.c| 24 +++-
fs/udf/namei.c |9 +
fs/udf/super.c | 16 ++--
fs/udf/udfdecl.h | 12
5 files changed, 20 insertions(+), 56
convert byte order of constant instead of variable
which can be done at compile time (vs run time)
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
---
drivers/net/qla3xxx.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
1 - 100 of 411 matches
Mail list logo
