Re: [PATCH] media: videobuf2-dma-contig: fix bad kfree in vb2_dma_contig_clear_max_seg_size

T_SYMBOL_GPL(vb2_dma_contig_set_max_seg_size); >*/ > void vb2_dma_contig_clear_max_seg_size(struct device *dev) > { > - kfree(dev->dma_parms); > - dev->dma_parms = NULL; > } > EXPORT_SYMBOL_GPL(vb2_dma_contig_clear_max_seg_size); We don't need to export empty function imho. It can be made an empty static inline in include/media/videobuf2-dma-contig.h. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning

> Signed-off-by: Tamseel Shams Indeed, it removes the warning on various Exynos{3,4,5} based boards. Tested-by: Marek Szyprowski > > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v2 2/2] memory: samsung: exynos5422-dmc: Add module param to control IRQ mode

lowing message and freeze on Odroid XU3 with multi_v7_defconfig: [    8.767708] exynos5-dmc 10c2.memory-controller: couldn't probe performance counters I will check this later why the EPROBE_DEFER error is not properly propagated and why it causes a freeze. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v2 2/2] memory: samsung: exynos5422-dmc: Add module param to control IRQ mode

Hi All, On 03.08.2020 17:30, Marek Szyprowski wrote: > On 10.07.2020 21:11, Lukasz Luba wrote: >> The driver can operate in two modes relaying on devfreq monitoring >> mechanism which periodically checks the device status or it can use >> interrupts when they are provided

Re: [PATCH 1/1] mfd: core: Fix memory leak of 'cell'

ig, the dts used for the test is arch/arm/boot/dts/exynos4412-trats2.dts > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

NK_FLAGS_RPM(FW_DEVLINK_FLAGS_ON | \ >DL_FLAG_PM_RUNTIME) > > -static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_PERMISSIVE; > +static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_ON; > static int __init fw_devlink_setup(char *arg) > { > if (!arg) Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

On 11.01.2021 12:12, Marek Szyprowski wrote: > On 18.12.2020 04:17, Saravana Kannan wrote: >> Cyclic dependencies in some firmware was one of the last remaining >> reasons fw_devlink=on couldn't be set by default. Now that cyclic >> dependencies don't block probin

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

On 11.01.2021 22:47, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 6:18 AM Marek Szyprowski > wrote: >> On 11.01.2021 12:12, Marek Szyprowski wrote: >>> On 18.12.2020 04:17, Saravana Kannan wrote: >>>> Cyclic dependencies in some firmware was one of the last

Re: [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler

y > be dropped by the input core. > > Note that there are more places in cyapa driver that call > input_device_enabled() without holding input->mutex, those are left > unfixed for now. > > Reported-by: Marek Szyprowski > Signed-off-by: Dmitry Torokhov > --- > > Ma

Re: [PATCH 1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5

rily working for this hardware. > > Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for > ARTIK5 module") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- Tested-by: Marek Szyprowski > 1 file chan

Re: [PATCH 6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family

s: odroidxu3: Enable wake alarm of S2MPS11 RTC") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- Tested-by: Marek Szyprowski > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5422-od

Re: [PATCH 3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato

rily working for this hardware. > > Fixes: faaf348ef468 ("ARM: dts: Add board dts file for exynos3250-rinato") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- Tested-by: Marek Szyprowski > 1 file changed, 1 insertion(+),

Re: [PATCH 5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa

: fix pinctrl for s2mps11-irq on > exynos5420-arndale-octa") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- Tested-by: Marek Szyprowski > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot

Re: [PATCH 3/3] driver core: platform: use bus_type functions

ck: (0xc3405e60 to 0xc3406000) [] (platform_shutdown) from [] (device_shutdown+0x18c/0x25c) [] (device_shutdown) from [] (kernel_restart+0xc/0x68) [] (kernel_restart) from [] (__do_sys_reboot+0x154/0x1f0) [] (__do_sys_reboot) from [] (ret_fast_syscall+0x0/0x58) Exception stack(0xc3405fa8 to 0xc3405ff0) ... ---[ end trace f39e94d5d6fd45bf ]--- > + > + > int platform_dma_configure(struct device *dev) > { > enum dev_dma_attr attr; > @@ -1375,6 +1370,9 @@ struct bus_type platform_bus_type = { > .dev_groups = platform_dev_groups, > .match = platform_match, > .uevent = platform_uevent, > + .probe = platform_probe, > + .remove = platform_remove, > + .shutdown = platform_shutdown, > .dma_configure = platform_dma_configure, > .pm = &platform_dev_pm_ops, > }; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

On 21.12.2020 08:55, Krzysztof Kozlowski wrote: > On Mon, Dec 21, 2020 at 08:36:02AM +0100, Marek Szyprowski wrote: >> On 18.12.2020 15:22, Krzysztof Kozlowski wrote: >>> On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: >>>> On 10.12.2020 22

Re: [PATCH v4 2/7] Input: use input_device_enabled()

ce 6687a21e6b7e94ac ]--- Let me know how I can help debugging this issue. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v4 2/7] Input: use input_device_enabled()

Hi Andrzej, On 07.12.2020 16:50, Andrzej Pietrasiewicz wrote: > Hi Marek, > > W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze: >> Hi Andrzej, >> >> On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: >>> Use the newly added helper in relevant input dri

[PATCH] extcon: max77693: Fix modalias string

ce") Signed-off-by: Marek Szyprowski --- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 4a410fd2ea9a..92af97e00828 100644 --- a/drivers/extcon/extcon-max77693.c

Re: [PATCH] regulator: core: avoid regulator_resolve_supply() race condition

put_device(&r->dev); > - return ret; > + goto out; > } > > ret = set_supply(rdev, r); > if (ret < 0) { > put_device(&r->dev); > - return ret; > + goto out; > } > > /* > @@ -1886,11 +1901,13 @@ static int regulator_resolve_supply(struct > regulator_dev *rdev) > if (ret < 0) { > _regulator_put(rdev->supply); > rdev->supply = NULL; > - return ret; > + goto out; > } > } > > - return 0; > +out: > + regulator_unlock(rdev); > + return ret; > } > > /* Internal regulator request function */ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

Hi Saravana, On 12.01.2021 21:51, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 11:11 PM Marek Szyprowski > wrote: >> On 11.01.2021 22:47, Saravana Kannan wrote: >>> On Mon, Jan 11, 2021 at 6:18 AM Marek Szyprowski >>> wrote: >>>> On 11.01.20

[PATCH] soc: samsung: pm_domains: Convert to regular platform driver

to convert Exynos power domain driver to regular platform driver. This is also required by the mentioned commit to enable probing any device which belongs to the Exynos power domains, as otherwise the core won't notice that the power domains are in fact available. Signed-off-by: Marek Szyprowski

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

Hi Saravana, On 13.01.2021 20:23, Saravana Kannan wrote: > On Tue, Jan 12, 2021 at 11:04 PM Marek Szyprowski > wrote: >> On 12.01.2021 21:51, Saravana Kannan wrote: >>> On Mon, Jan 11, 2021 at 11:11 PM Marek Szyprowski >>> wrote: >>>> On 11.01.2021

Re: [PATCH] soc: samsung: pm_domains: Convert to regular platform driver

Hi Saravana, On 13.01.2021 21:27, Saravana Kannan wrote: > On Wed, Jan 13, 2021 at 3:03 AM Marek Szyprowski > wrote: >> When Exynos power domain driver was introduced, the only way to ensure >> that power domains will be instantiated before the devices which belongs >> t

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

acing/instances/usb/events/dwc3/dwc3_complete_trb/enable >>> echo 1 > >>> /sys/kernel/debug/tracing/instances/usb/events/dwc3/dwc3_ctrl_req/enable >>> echo 1 > >>> /sys/kernel/debug/tracing/instances/usb/events/dwc3/dwc3_ep_dequeue/enable >>> echo

Re: [PATCH] PCI: dwc: Move forward the iATU detection process

7 @@ int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, u8 > func_no, int index, > void dw_pcie_disable_atu(struct dw_pcie *pci, int index, >enum dw_pcie_region_type type); > void dw_pcie_setup(struct dw_pcie *pci); > +void dw_pcie_iatu_detect(struct dw_pcie *pci); > > static inline void dw_pcie_writel_dbi(struct dw_pcie *pci, u32 reg, u32 val) > { Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

r(struct device_node *np, > if (ret < 0) > of_clk_del_provider(np); > > + fwnode_dev_initialized(&np->fwnode, true); > + > return ret; > } > EXPORT_SYMBOL_GPL(of_clk_add_hw_provider); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH net-next] net: stmmac: support FPE link partner hand-shaking procedure

be done after FPE handshake > + * is success. > + */ > + priv->plat->fpe_cfg->enable = fpe; > > ret = stmmac_est_configure(priv, priv->ioaddr, priv->plat->est, > priv->plat->clk_ptp_rate); > @@ -845,12 +853,29 @@ static int tc_setup_taprio(struct stmmac_priv *priv, > } > > netdev_info(priv->dev, "configured EST\n"); > + > + if (fpe) { > + stmmac_fpe_handshake(priv, true); > + netdev_info(priv->dev, "start FPE handshake\n"); > + } > + > return 0; > > disable: > priv->plat->est->enable = false; > stmmac_est_configure(priv, priv->ioaddr, priv->plat->est, >priv->plat->clk_ptp_rate); > + > + priv->plat->fpe_cfg->enable = false; > + stmmac_fpe_configure(priv, priv->ioaddr, > + priv->plat->tx_queues_to_use, > + priv->plat->rx_queues_to_use, > + false); > + netdev_info(priv->dev, "disabled FPE\n"); > + > + stmmac_fpe_handshake(priv, false); > + netdev_info(priv->dev, "stop FPE handshake\n"); > + > return ret; > } > > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 10abc80b601e..072f269b1618 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -144,6 +144,32 @@ struct stmmac_txq_cfg { > int tbs_en; > }; > > +/* FPE link state */ > +enum stmmac_fpe_state { > + FPE_STATE_OFF = 0, > + FPE_STATE_CAPABLE = 1, > + FPE_STATE_ENTERING_ON = 2, > + FPE_STATE_ON = 3, > +}; > + > +/* FPE link-partner hand-shaking mPacket type */ > +enum stmmac_mpacket_type { > + MPACKET_VERIFY = 0, > + MPACKET_RESPONSE = 1, > +}; > + > +enum stmmac_fpe_task_state_t { > + __FPE_REMOVING, > + __FPE_TASK_SCHED, > +}; > + > +struct stmmac_fpe_cfg { > + bool enable;/* FPE enable */ > + bool hs_enable; /* FPE handshake enable */ > + enum stmmac_fpe_state lp_fpe_state; /* Link Partner FPE state */ > + enum stmmac_fpe_state lo_fpe_state; /* Local station FPE state */ > +}; > + > struct plat_stmmacenet_data { > int bus_id; > int phy_addr; > @@ -155,6 +181,7 @@ struct plat_stmmacenet_data { > struct device_node *mdio_node; > struct stmmac_dma_cfg *dma_cfg; > struct stmmac_est *est; > + struct stmmac_fpe_cfg *fpe_cfg; > int clk_csr; > int has_gmac; > int enh_desc; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v3] amba: Remove deferred device addition

Rob Herring > Cc: Ulf Hansson > Cc: John Stultz > Cc: Saravana Kannan > Cc: Linus Walleij > Cc: Sudeep Holla > Cc: Nicolas Saenz Julienne > Cc: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: Russell King > Signed-off-by: Saravana Kannan > --- > > v

Re: [PATCH] PCI: dwc: Move forward the iATU detection process

On 26.03.2021 18:05, Marek Szyprowski wrote: > On 25.03.2021 21:19, Bjorn Helgaas wrote: >> On Thu, Mar 25, 2021 at 10:24:28AM +0100, Marek Szyprowski wrote: >>> On 25.01.2021 05:48, Zhiqiang Hou wrote: >>>> From: Hou Zhiqiang >>>> >>>> In

Re: [PATCH] clk: bcm: rpi: Don't register as OF provider if !dev->np

ble. > > Fixes: d4b4f1b6b97e ("clk: bcm: rpi: Add DT provider for the clocks") > Reported-by: Marek Szyprowski > Signed-off-by: Nicolas Saenz Julienne Tested-by: Marek Szyprowski > --- > drivers/clk/bcm/clk-raspberrypi.c | 10 ++ > 1 file changed, 6 insertions

Re: [PATCH net-next] net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg

it(). Additionally, checking of > priv->dma_cap.fpesel is added before calling stmmac_fpe_link_state_handle() > as only FPE supported SoC is allowed to call the function. > > Below is the kernel panic dump reported by Marek Szyprowski > : > > meson8b-dwmac ff3f.ethernet eth0: PHY [0.

Re: [PATCH] PCI: dwc: Move forward the iATU detection process

On 25.03.2021 21:19, Bjorn Helgaas wrote: > On Thu, Mar 25, 2021 at 10:24:28AM +0100, Marek Szyprowski wrote: >> On 25.01.2021 05:48, Zhiqiang Hou wrote: >>> From: Hou Zhiqiang >>> >>> In the dw_pcie_ep_init(), it depends on the detected iATU region >>&g

Re: [PATCH v6 14/24] iio: buffer: wrap all buffer attributes into iio_dev_attr

e_chan_devattr_list(&buffer->scan_el_dev_attr_list); > + iio_free_chan_devattr_list(&buffer->buffer_attr_list); > > return ret; > } > @@ -1443,7 +1467,7 @@ static void __iio_buffer_free_sysfs_and_mask(struct > iio_buffer *buffer) > bitmap_free(buffer->scan_mask); > kfree(buffer->buffer_group.name); > kfree(buffer->buffer_group.attrs); > - iio_free_chan_devattr_list(&buffer->scan_el_dev_attr_list); > + iio_free_chan_devattr_list(&buffer->buffer_attr_list); > } > > void iio_buffer_free_sysfs_and_mask(struct iio_dev *indio_dev) > diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h > index 3e555e58475b..41044320e581 100644 > --- a/include/linux/iio/buffer_impl.h > +++ b/include/linux/iio/buffer_impl.h > @@ -97,8 +97,8 @@ struct iio_buffer { > /* @scan_timestamp: Does the scan mode include a timestamp. */ > bool scan_timestamp; > > - /* @scan_el_dev_attr_list: List of scan element related attributes. */ > - struct list_head scan_el_dev_attr_list; > + /* @buffer_attr_list: List of buffer attributes. */ > + struct list_head buffer_attr_list; > > /* >* @buffer_group: Attributes of the new buffer group. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH 5/7] mfd: sec: Simplify getting of_device_id match data

#endif Does it make any sense to keep the #ifdef CONFIG_OF after this change? I would also skip (i2c->dev.of_node) check, because of_device_get_match_data() already does that (although indirectly). > return id->driver_data; > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH 5/7] mfd: sec: Simplify getting of_device_id match data

On 20.04.2021 09:03, Krzysztof Kozlowski wrote: > On 20/04/2021 07:25, Marek Szyprowski wrote: >> On 19.04.2021 10:17, Krzysztof Kozlowski wrote: >>> Use of_device_get_match_data() to make the code slightly smaller. >>> >>> Signed-off-by: Krzysztof Kozlowski &

Re: [PATCH] iommu: exynos: remove unneeded local variable initialization

On 08.04.2021 22:16, Krzysztof Kozlowski wrote: > The initialization of 'fault_addr' local variable is not needed as it is > shortly after overwritten. > > Addresses-Coverity: Unused value > Signed-off-by: Krzysztof Kozlowski Acked-by: Marek Szyprowski > --- >

Re: [PATCH] iio: buffer: use sysfs_attr_init() on allocated attrs

> https://lore.kernel.org/linux-iio/CA+U=DsrsvGgXEF30-vXuXS_k=-mjsjibweezwkb1hjvn1p9...@mail.gmail.com/T/#u > > Fixes: 15097c7a1adc ("iio: buffer: wrap all buffer attributes into > iio_dev_attr") > Reported-by: Marek Szyprowski > Signed-off-by: Alexandru Ardelean > --- &

Re: [PATCH 3/4] s5p-mfc: Use display delay and display enable std controls

On 09.11.2020 18:35, Stanimir Varbanov wrote: > Use the standard display_delay and display_delay_enable controls, > the legacy private MFC controls are kept for backward compatibility. > > Signed-off-by: Stanimir Varbanov Acked-by: Marek Szyprowski > --- > drivers/medi

Re: [PATCH net-next v2] r8153_ecm: avoid to be prior to r8152 driver

ECM mode for RTL8153") > Reported-by: Marek Szyprowski > Signed-off-by: Hayes Wang Yes, this looks like a proper fix. Tested-by: Marek Szyprowski > --- > v2: > Use a separate Kconfig entry for r8153_ecm with proper dependencies. > > drivers/net/usb/Kconfig | 9 ++

[PATCH] regulator: max14577: Add proper module aliases strings

Add proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings. Signed-off-by: Marek Szyprowski --- drivers/regulator/max14577-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] interconnect: fix memory trashing in of_count_icc_providers()

emory trashing when CONFIG_OF_DYNAMIC is enabled (for example arm/multi_v7_defconfig). Fixes: b1d681d8d324 ("interconnect: Add sync state support") Signed-off-by: Marek Szyprowski --- drivers/interconnect/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/interconnect/c

[PATCH 0/2] Fix USB2 PHY operation on Exynos542x

about the Exynos5420 variant. Best regards, Marek Szyprowski Patch summary: Marek Szyprowski (2): phy: samsung: add support for the Exynos5420 variant of the USB2 PHY ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible .../devicetree/bindings/phy/samsung-phy.txt | 1 + arch

[PATCH 1/2] phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY

-by: Marek Szyprowski --- .../devicetree/bindings/phy/samsung-phy.txt | 1 + drivers/phy/samsung/Kconfig | 7 ++- drivers/phy/samsung/phy-exynos5250-usb2.c | 48 +-- drivers/phy/samsung/phy-samsung-usb2.c| 6 +++ drivers/phy/samsung/phy-samsung

[PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible

USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the recently introduced dedicated compatible for Exynos5420. Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts

Re: [PATCH v4 4/5] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

Hi Vinod, On 20.11.2020 10:41, Vinod Koul wrote: > On 13-11-20, 18:01, Marek Szyprowski wrote: >> From: Jaehoon Chung >> >> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM: >> dts: exynos: Remove Exynos5440"). Rework this driver to sup

[PATCH v4 4/5 REBASED RESEND] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

Exynos5433 variant, rebased onto current kernel code, rewrote commit message] Signed-off-by: Marek Szyprowski Acked-by: Krzysztof Kozlowski Reviewed-by: Jingoo Han --- Resend reason: rebased onto current -next branch --- drivers/phy/samsung/phy-exynos-pcie.c | 301 ++--

Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible

Hi Krzysztof, On 20.11.2020 12:05, Krzysztof Kozlowski wrote: > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the >> recently introduced dedicated compatible for Exynos5420. >> &g

Re: [PATCH v2 2/3] spi: Use bus_type functions for probe, remove and shutdown

truct > spi_driver *sdrv) > { > sdrv->driver.owner = owner; > sdrv->driver.bus = &spi_bus_type; > - sdrv->driver.probe = spi_drv_probe; > - sdrv->driver.remove = spi_drv_remove; > - if (sdrv->shutdown) > - sdrv->driver.shutdown = spi_drv_shutdown; > return driver_register(&sdrv->driver); > } > EXPORT_SYMBOL_GPL(__spi_register_driver); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

[PATCH] spi: Fix potential NULL pointer dereference in spi_shutdown()

9a9f1021 (f9400c21) ---[ end trace 266c07205a2d632e ]--- Fixes: 9db34ee64ce4 ("spi: Use bus_type functions for probe, remove and shutdown)" Signed-off-by: Marek Szyprowski --- drivers/spi/spi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi.c b/d

Re: [PATCH] mm/memblock:use a more appropriate order calculation when free memblock pages

;) on top of linux next-20201204 fixed booting of my ARM32bit test systems. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v2 5/6] media: uvcvideo: Use dma_alloc_noncontiguos API

> -#endif > - if (!uvc_urb->buffer) { > + if (!uvc_alloc_urb_buffer(stream, uvc_urb, gfp_flags)) { > uvc_free_urb_buffers(stream); > break; > } > diff --git a/drivers/media/usb/uvc/uvcvideo.h > b/drivers/media/usb/uvc/uvcvideo.h > index a3dfacf069c4..3e6618a2ac82 100644 > --- a/drivers/media/usb/uvc/uvcvideo.h > +++ b/drivers/media/usb/uvc/uvcvideo.h > @@ -532,6 +532,8 @@ struct uvc_urb { > > char *buffer; > dma_addr_t dma; > + struct page **pages; > + struct sg_table sgt; > > unsigned int async_operations; > struct uvc_copy_op copy_operations[UVC_MAX_PACKETS]; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

lugins' failed make[1]: *** [scripts/gcc-plugins] Error 2 Makefile:1190: recipe for target 'scripts' failed make: *** [scripts] Error 2 Compilation works if I use the cross-gcc provided by gcc-7-arm-linux-gnueabi/gcc-arm-linux-gnueabi Ubuntu packages, which is: $ arm-linux-gnueabi-gcc --version arm-linux-gnueabi-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0 Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

On 18.12.2020 10:43, Masahiro Yamada wrote: > On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski > wrote: >> On 03.12.2020 13:57, Masahiro Yamada wrote: >>> Linus pointed out a third of the time in the Kconfig parse stage comes >>> from the single invocation of cc1pl

Re: [PATCH 7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2

rily working for this hardware. > > Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based > TM2 board") > Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- >

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

MIC drivers are used only on Devicetree boards. > > Additionally, the PMIC datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Signed-off-by: Krzysztof Kozlowski Tested-by: Mare

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

On 18.12.2020 16:03, Jon Hunter wrote: > On 18/12/2020 10:05, Marek Szyprowski wrote: >> On 18.12.2020 10:43, Masahiro Yamada wrote: >>> On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski >>> wrote: >>>> On 03.12.2020 13:57, Masahiro Yamada wrote: >>

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

Hi Krzysztof, On 18.12.2020 15:22, Krzysztof Kozlowski wrote: > On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: >> On 10.12.2020 22:29, Krzysztof Kozlowski wrote: >>> Interrupt line can be configured on different hardware in different way, >>> even

Re: linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c)

ed in the original commit - we should probably rework > the DWC driver dependencies on PCI_MSI_IRQ_DOMAIN to really fix it, for > the time being this should do. Thanks! I wasn't aware of that hidden dependency. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

[PATCH] phy: samsung: Fix build break in USB2 PHY driver for Exynos5420 SoCs

phy-exynos-usb2.ko] undefined! Fix this by removing PHY_EXYNOS5420_USB2 symbol and using PHY_EXYNOS5250_USB2 also for Exynos5420 SoCs. Reported-by: Markus Reichl Fixes: 81b534f7e9b2 ("phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY") Signed-off-by: Marek Szyprowsk

[PATCH v2] phy: samsung: Merge Kconfig for Exynos5420 and Exynos5250

phy-exynos-usb2.ko] undefined! Fix this by removing PHY_EXYNOS5420_USB2 symbol and using PHY_EXYNOS5250_USB2 also for Exynos5420 SoCs. Reported-by: Markus Reichl Fixes: 81b534f7e9b2 ("phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY") Signed-off-by: Marek Szyprowski

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

cblk0p6): mounted filesystem with ordered data mode. Opts: (null) VFS: Mounted root (ext4 filesystem) readonly on device 179:6. Trying to move old root to /initrd ... I suppose this issue can be also reproduced with qemu. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

Hi On 03.12.2020 16:46, Marek Szyprowski wrote: > On 25.11.2020 03:32, Matthew Wilcox wrote: >> On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: >>> On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: >>>> I find both of these functions

Re: [PATCH] regulator: core: avoid regulator_resolve_supply() race condition

Hi Mark, On 18.01.2021 21:49, Mark Brown wrote: > On Tue, Jan 12, 2021 at 10:34:19PM +0100, Marek Szyprowski wrote: >> == >> WARNING: possible circular locking dependency detected >> 5.11.0-rc1-8-geaa7995c52

Re: [TEST PATCH v1] driver: core: Make fw_devlink=on more forgiving

licitly not including you in the "To" because this patch won't > work for your issues. > > Cc: Marek Szyprowski > Cc: Geert Uytterhoeven > Cc: Marc Zyngier > Signed-off-by: Saravana Kannan > --- > drivers/base/base.h | 3 ++ > drivers/base/core.c

Re: [PATCH v3] amba: Remove deferred device addition

Hi Saravana, On 05.03.2021 19:02, Saravana Kannan wrote: > On Fri, Mar 5, 2021 at 3:45 AM Marek Szyprowski > wrote: >> On 04.03.2021 20:51, Saravana Kannan wrote: >>> The uevents generated for an amba device need PID and CID information >>> that's available o

Re: [PATCH] regulator: core: avoid regulator_resolve_supply() race condition

Hi Mark, On 21.01.2021 16:44, Mark Brown wrote: > On Thu, Jan 21, 2021 at 10:41:59AM +0100, Marek Szyprowski wrote: >> On 18.01.2021 21:49, Mark Brown wrote: >>> Does this help (completely untested): >> Sadly nope. I get same warning: > Try this instead: > > diff

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

, 2021 at 2:20 AM Geert Uytterhoeven >>>> wrote: >>>>> On Fri, Feb 5, 2021 at 11:06 AM Saravana Kannan >>>>> wrote: >>>>>> On Fri, Feb 5, 2021 at 12:06 AM Geert Uytterhoeven >>>>>> wrote: >>>>>>> On

Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving

h 6 through 8 update different frameworks to use the new API. This patchset fixes probing issue observed on various Exynos based boards even with commit c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") reverted. Thanks! Tested-by: Marek Szyprowski Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH RFC 1/2] dt: pci: designware-pcie.txt: convert it to yaml

t | 2 +- > MAINTAINERS | 2 +- > 19 files changed, 225 insertions(+), 108 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/pci/designware,pcie.yaml > delete mode 100644 Documentation/devicetree/bindings/pci/designware-pcie.txt > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [PATCH v12] ARM: uncompress: Validate start of physical memory against passed DTB

0 (CS3 space), > i.e. not at a multiple of 128 MiB. > > Suggested-by: Nicolas Pitre > Suggested-by: Ard Biesheuvel > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Ard Biesheuvel > Acked-by: Nicolas Pitre I've checked all of my arm 32bit test systems and they still boot fin

Re: [PATCH v5 06/11] drivers: of: initialize and assign reserved memory to newly created devices

Hello, On 2014-02-26 13:14, Grant Likely wrote: On Fri, 21 Feb 2014 13:25:22 +0100, Marek Szyprowski wrote: > Use recently introduced of_reserved_mem_device_init() function to > automatically assign respective reserved memory region to the newly created > platform and amba device. &

Re: [PATCH v5 01/11] of: document bindings for reserved-memory nodes

Hello, On 2014-02-26 12:51, Grant Likely wrote: On Fri, 21 Feb 2014 13:25:17 +0100, Marek Szyprowski wrote: > From: Grant Likely > > Reserved memory nodes allow for the reservation of static (fixed > address) regions, or dynamically allocated regions for a specific > purpose.

[PATCH v6 04/11] drivers: of: add support for custom reserved memory drivers

Add support for custom reserved memory drivers. Call their init() function for each reserved region and prepare for using operations provided by them with by the reserved_mem->ops array. Based on previous code provided by Josh Cartwright Signed-off-by: Marek Szyprowski --- drivers

[PATCH v6 05/11] drivers: of: add automated assignment of reserved regions to client devices

ed-off-by: Marek Szyprowski --- drivers/of/of_reserved_mem.c| 70 +++ include/linux/of_reserved_mem.h |7 2 files changed, 77 insertions(+) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index daaaf935911d..5c45016efd31

[PATCH v6 02/11] drivers: of: add initialization code for static reserved memory

t reserved memory layout directly from fdt. Based on previous code provided by Josh Cartwright Signed-off-by: Marek Szyprowski Acked-by: Grant Likely --- drivers/of/fdt.c | 131 include/linux/of_fdt.h |3 ++ 2 files changed, 134 insertion

[PATCH v6 10/11] arm64: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/arm64/Kconfig |1 + arch/arm64/mm/init.c |1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 27bbcfc7202a..6abf15407dca 100644 --- a/arch

[PATCH v6 09/11] arm: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/arm/Kconfig |1 + arch/arm/mm/init.c |2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e25419817791..d0262bea8020 100644 --- a/arch/arm

[PATCH v6 11/11] powerpc: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/powerpc/Kconfig |1 + arch/powerpc/kernel/prom.c |3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 957bf344c0f5..3b6617fed8fc

[PATCH v6 08/11] drivers: dma-contiguous: add initialization from device tree

Refactor internal dma_contiguous_init_reserved_mem() function, which creates CMA area from previously reserved memory region and add support for handling 'shared-dma-pool' reserved-memory device tree nodes. Based on previous code provided by Josh Cartwright Signed-off-by: Marek

[PATCH v6 01/11] of: document bindings for reserved-memory nodes

/20131030134702.19b57c40...@trevor.secretlab.ca adapted to support #memory-region-cells] Signed-off-by: Josh Cartwright [mszyprow: removed #memory-region-cells property] Signed-off-by: Marek Szyprowski --- .../bindings/reserved-memory/reserved-memory.txt | 136 1 file changed, 136

[PATCH v6 00/11] reserved-memory regions/CMA in devicetree, again

d by Josh Cartwright Summary: Grant Likely (1): of: document bindings for reserved-memory nodes Marek Szyprowski (10): drivers: of: add initialization code for static reserved memory drivers: of: add initialization code for dynamic reserved memory drivers: of: add support for custom

[PATCH v6 06/11] drivers: of: initialize and assign reserved memory to newly created devices

Use recently introduced of_reserved_mem_device_init() function to automatically assign respective reserved memory region to the newly created platform and amba device. Signed-off-by: Marek Szyprowski --- drivers/of/platform.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[PATCH v6 03/11] drivers: of: add initialization code for dynamic reserved memory

This patch adds support for dynamically allocated reserved memory regions declared in device tree. Such regions are defined by 'size', 'alignment' and 'alloc-ranges' properties. Based on previous code provided by Josh Cartwright Signed-off-by: Marek Szyp

[PATCH v6 07/11] drivers: dma-coherent: add initialization from device tree

Add support for handling 'shared-dma-pool' reserved-memory device tree nodes. Based on previous code provided by Josh Cartwright Signed-off-by: Marek Szyprowski --- drivers/base/dma-coherent.c | 40 1 file changed, 40 insertions(+) di

[PATCH v3] x86: dma-mapping: fix GFP_ATOMIC macro usage

: sta...@vger.kernel.org Signed-off-by: Marek Szyprowski --- Changelog: v3: - fixed spelling issues v2: - added more comments in the code to explain for _GFP_WAIT test v1: - initial version --- arch/x86/kernel/pci-dma.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

Re: [PATCHv2 2/2] arm: Get rid of meminfo

| 61 ++-- arch/arm/mm/mmu.c| 115 +- 32 files changed, 133 insertions(+), 284 deletions(-) (snipped) Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list:

Re: [PATCH v2 4/5] ARM: init: add support for reserved memory defined by device tree

On 2014-02-10 22:59, Grant Likely wrote: On Thu, 06 Feb 2014 14:26:13 +0100, Marek Szyprowski wrote: > Hello, > > On 2014-02-05 11:15, Grant Likely wrote: > > On Tue, 04 Feb 2014 13:09:32 +0100, Marek Szyprowski wrote: > > > Enable reserved memory initial

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

Hello, On 2014-02-05 12:05, Grant Likely wrote: On Tue, 04 Feb 2014 13:09:29 +0100, Marek Szyprowski wrote: > This patch adds device tree support for contiguous and reserved memory > regions defined in device tree. > > Large memory blocks can be reliably reserved only durin

Re: [PATCHv3 2/2] arm: Get rid of meminfo

-by: Catalin Marinas Acked-by: Santosh Shilimkar Tested-by: Leif Lindholm Signed-off-by: Laura Abbott Tested-by: Marek Szyprowski --- arch/arm/include/asm/mach/arch.h |4 +- arch/arm/include/asm/memblock.h |3 +- arch/arm/include/asm/setup.h | 23

Re: [BUG] Circular locking dependency - DRM/CMA/MM/hotplug/...

006 r7:c00464b4 r6:beeb6bb4 r5:e9b97300 r4: [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x48) r8:c000e8a4 r7:0036 r6:0006 r5:c00464b4 r4:beeb6bb4 Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v3 2/6] drivers: of: add initialization code for reserved memory

Hello, On 2014-02-18 17:56, Grant Likely wrote: On Tue, 18 Feb 2014 14:37:57 +0100, Marek Szyprowski wrote: > This patch adds device tree support for contiguous and reserved memory > regions defined in device tree. > > Large memory blocks can be reliably reserved only durin

Re: [PATCH v3 3/6] drivers: of: implement reserved-memory handling for dma

Hello, On 2014-02-18 17:58, Grant Likely wrote: On Tue, 18 Feb 2014 14:37:58 +0100, Marek Szyprowski wrote: > From: Josh Cartwright > > Add support for handling 'shared-dma-pool' reserved-memory nodes using > dma exclusive driver (dma_alloc_coherent()). > > Si

[PATCH v4 7/7] powerpc: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/powerpc/Kconfig |1 + arch/powerpc/kernel/prom.c |3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 957bf344c0f5..3b6617fed8fc

[PATCH v4 3/7] drivers: dma-contiguous: add initialization from device tree

Refactor internal dma_contiguous_init_reserved_mem() function, which creates CMA area from previously reserved memory region and add support for handling 'shared-dma-pool' reserved-memory device tree nodes. Based on previous code provided by Josh Cartwright Signed-off-by: Marek

[PATCH v4 6/7] arm64: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/arm64/Kconfig |1 + arch/arm64/mm/init.c |2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 27bbcfc7202a..6abf15407dca 100644 --- a/arch

[PATCH v4 2/7] drivers: dma-coherent: add initialization from device tree

Add support for handling 'shared-dma-pool' reserved-memory device tree nodes. Based on previous code provided by Josh Cartwright Signed-off-by: Marek Szyprowski --- drivers/base/dma-coherent.c | 41 + 1 file changed, 41 insertions(+) di

[PATCH v4 5/7] arm: add support for reserved memory defined by device tree

Enable reserved memory initialization from device tree. Signed-off-by: Marek Szyprowski --- arch/arm/Kconfig |1 + arch/arm/mm/init.c |3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e25419817791..d0262bea8020 100644 --- a/arch/arm

[PATCH v4 0/7] reserved-memory regions/CMA in devicetree, again

l' regions with 'reusable' property. v1: http://thread.gmane.org/gmane.linux.documentation/19579 - initial version prepared by Josh Cartwright Summary: Grant Likely (1): of: document bindings for reserved-memory nodes Marek Szyprowski (6): drivers: of: add initialization code for reserv

[PATCH v4 4/7] of: document bindings for reserved-memory nodes

/20131030134702.19b57c40...@trevor.secretlab.ca adapted to support #memory-region-cells] Signed-off-by: Josh Cartwright Signed-off-by: Marek Szyprowski --- .../bindings/reserved-memory/reserved-memory.txt | 138 1 file changed, 138 insertions(+) create mode 100644 Documentation

[PATCH v4 1/7] drivers: of: add initialization code for reserved memory

structures are unflattened, so we need to get reserved memory layout directly from fdt. Later, those reserved memory regions are assigned to devices on each device structure initialization. Signed-off-by: Marek Szyprowski [joshc: rework to implement new DT binding, provide mechanism for plugging in new

<    1   2   3   4   5   6   7   8   9   10   >