Re: [PATCH 1/2] mfd: add TI TPS80031 mfd core driver

2012-11-05 Thread Mark Brown
On Mon, Nov 05, 2012 at 03:14:17PM +0530, Laxman Dewangan wrote: Looks pretty good, a few smaller issues though. +static bool is_volatile_reg_id0(struct device *dev, unsigned int reg) +{ + return false; +} This is the default for all registers, you should not need to provide a function

Re: [PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-05 Thread Mark Brown
On Mon, Nov 05, 2012 at 03:14:18PM +0530, Laxman Dewangan wrote: + switch (ri-device_flags) { + case 0: Should we be using different versions of the ops depending on the device flags rather than having these switches? It seems like we can't change at runtime and it would make the code

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mark Brown
On Sat, Nov 03, 2012 at 10:13:10PM +0200, Mika Westerberg wrote: On Sat, Nov 03, 2012 at 01:42:02PM -0600, Bjorn Helgaas wrote: + case ACPI_RESOURCE_TYPE_IRQ: + info-gsi = res-data.irq.interrupts[0]; + info-triggering = res-data.irq.triggering; +

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mark Brown
On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote: + strlcpy(spi-modalias, acpi_device_hid(adev), sizeof(spi-modalias)); + if (info.gsi = 0) + spi-irq = acpi_register_gsi(adev-dev, info.gsi, + info.triggering,

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mark Brown
On Mon, Nov 05, 2012 at 12:56:02PM +0200, Mika Westerberg wrote: struct acpi_device { ... union acpi_resource_serial_bus *serial; ... }; It is also possible to have several serial bus connectors on a single device (although we've seen only one connector per device but it

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mark Brown
On Mon, Nov 05, 2012 at 01:03:22PM +0200, Mika Westerberg wrote: On Mon, Nov 05, 2012 at 11:54:55AM +0100, Mark Brown wrote: On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote: + strlcpy(spi-modalias, acpi_device_hid(adev), sizeof(spi-modalias)); + if (info.gsi = 0

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-06 Thread Mark Brown
On Mon, Nov 05, 2012 at 02:02:19PM +0200, Mika Westerberg wrote: On Mon, Nov 05, 2012 at 11:56:39AM +0100, Mark Brown wrote: I've got practical systems where there are multiple buses physically connected, though in practice almost always only one is actually used at runtime when it's I2C

Re: [PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-06 Thread Mark Brown
On Mon, Nov 05, 2012 at 05:30:02PM +0530, Laxman Dewangan wrote: On Monday 05 November 2012 04:12 PM, Mark Brown wrote: Should we be using different versions of the ops depending on the device flags rather than having these switches? It seems like we can't change at runtime and it would make

Re: [PATCH 1/2] ASoC: Ux500: Fixup use of clocks

2012-11-06 Thread Mark Brown
On Mon, Nov 05, 2012 at 03:27:08PM +0100, Ulf Hansson wrote: I can not find this patch on any next-tree yet. Same goes for: [PATCH 2/2] ASoC: Ux500: Control apb clock. Maybe I should be more patient, but thought it make sense to send a ping on this. :-) As I've had to tell you before pings

Re: [PATCH 5/7] mfd: max8925: support dt for regulator

2012-11-06 Thread Mark Brown
On Tue, Nov 06, 2012 at 03:44:52PM +0800, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/regulator/max8925-regulator.c | 35 - 1 files changed, 34 insertions(+), 1 deletions(-) There is no binding

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Mark Brown
On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Applied, thanks. signature.asc Description: Digital

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Mark Brown
On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Is this a resend of the patch I just applied, or is it

Re: [PATCH] regulator: core: avoid memory access after freeing it

2012-11-06 Thread Mark Brown
On Tue, Nov 06, 2012 at 11:12:56AM +, Charles Keepax wrote: Here would it not make sense to go slightly further and basically revert my original change. This feels sensible as it keeps it at only one location where the mutex is unlocked and removes the second exit point I added. This

Re: [PATCH v2 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Mark Brown
On Wed, Nov 07, 2012 at 04:41:50PM +0800, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com Applied, thanks - I'm assuming that the documentation for this binding is in the core MFD patch along with the bindings for the core? It's mandatory to have

Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Mark Brown
On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com Applied, thanks. +max8925 regulator device register is still handled by mfd_add_devices, not by +of_xxx, so, it is not necessary to add compatible name. Also,

Re: [PATCH -next] ASoC: cs42l52: fix the return value of cs42l52_set_fmt()

2012-11-07 Thread Mark Brown
On Wed, Nov 07, 2012 at 08:38:35PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix the return value of cs42l52_set_fmt() when clock inversion is not allowed and also remove the useless variable ret. Applied, but you need to work on your changelogs: What is

Re: [PATCH 1/2] regulator: gpio-regulator: Allow use of GPIO controlled regulators though DT

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 10:13:55AM +0100, Lee Jones wrote: On Wed, 17 Oct 2012, Mark Brown wrote: This should really be part of the patch adding the bindings... Would you like me to send the patch-set again? When I said I'd applied the patch that was what I meant. signature.asc

Re: [PATCH] spi: tegra: add spi driver for SLINK controller

2012-10-22 Thread Mark Brown
On Thu, Oct 18, 2012 at 04:17:13PM +0530, Laxman Dewangan wrote: + udelay(1); + wmb(); + } + tspi-dma_control_reg = val; + val |= SLINK_DMA_EN; + tegra_slink_writel(tspi, val, SLINK_DMA_CTL); + return 0; +} +static int

[PATCH] clk: Make the generic clock API available by default

2012-10-22 Thread Mark Brown
current architectures that HAVE_CLK but don't use the common clock framework have selects of HAVE_CUSTOM_CLK added. This allows drivers to use the generic API on platforms which have no need for the clock API at platform level. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked

Re: [PATCH] clk: Make the generic clock API available by default

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 02:05:57PM +0100, Russell King - ARM Linux wrote: On Mon, Oct 22, 2012 at 02:02:50PM +0100, Mark Brown wrote: @@ -327,6 +328,7 @@ config ARCH_AT91 select ARCH_REQUIRE_GPIOLIB select CLKDEV_LOOKUP select HAVE_CLK + select HAVE_CUSTOM_CLK

Re: [PATCH 1/2] ASoC: Ux500: Fixup use of clocks

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 02:32:04PM +0200, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org Make sure clocks are being prepared and unprepared as well as enabled and disabled. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 2/2] ASoC: Ux500: Control apb clock

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 02:32:05PM +0200, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org When switching to common clock driver for ux500 this clock needs to be handled as well. Before this clock was internally managed by the clock driver itself. Applied but why isn't this a

Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-22 Thread Mark Brown
On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable oldstatus is initialized but never used otherwise, so remove the unused variable. Applied, thanks. However for changes like this you should really consider in your

Re: [PATCH] clk: Make the generic clock API available by default

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 02:50:24PM +0100, Russell King - ARM Linux wrote: On Mon, Oct 22, 2012 at 02:27:11PM +0100, Mark Brown wrote: If we're worrying about that there's the larger point that the effect of this patch is to make HAVE_CLK meaningless as there will be no platform for which

Re: [PATCH] regulator: max77686: Make max77686_enable() static.

2012-10-22 Thread Mark Brown
On Mon, Oct 22, 2012 at 09:39:28AM +0530, Yadwinder Singh Brar wrote: This patch fixes a sparse warning. Since max77686_enable() is a callback,so it should be static. Applied, thanks. signature.asc Description: Digital signature

[GIT PULL] regmap for for v3.7

2012-10-22 Thread Mark Brown
The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/regmap-fix-mmio for you to fetch changes up to

Re: [PATCH] spi: tegra: add spi driver for SLINK controller

2012-10-23 Thread Mark Brown
On Mon, Oct 22, 2012 at 02:02:47PM -0600, Stephen Warren wrote: On 10/18/2012 04:47 AM, Laxman Dewangan wrote: + /* Read back register to make sure that register writes completed */ + if (reg != SLINK_TX_FIFO) + readl(tspi-base + SLINK_MAS_DATA); Is that really necessary on

Re: [PATCH] clk: Make the generic clock API available by default

2012-10-23 Thread Mark Brown
On Tue, Oct 23, 2012 at 10:10:09AM +0800, Kelvin Cheung wrote: Hi Mark, Don't top post! But the common clock infrastructure of Loongson1 has been implemented and enabled in previous patches. http://patchwork.linux-mips.org/patch/4268/ Please remove this arch from your patch. Done.

Re: [PATCH 2/2] Documentation: Describe Device Tree bindings for GPIO Regulator driver

2012-10-23 Thread Mark Brown
On Mon, Oct 15, 2012 at 02:17:00PM +0100, Lee Jones wrote: Here we specify all non-standard bindings which can be used when requesting the use of an GPIO controlled regulator from Device Tree. Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Lee Jones lee.jo...@linaro.org

Re: [PATCH] clk: Make the generic clock API available by default

2012-10-23 Thread Mark Brown
On Mon, Oct 22, 2012 at 09:56:54AM -0600, Stephen Warren wrote: Since v3.7-rc1, Tegra uses common clock, so I don't think the change above is right is it? No, updated. It really shouldn't take multiple kernel releases to get something like this done... signature.asc Description: Digital

[PATCH] clk: Make the generic clock API available by default

2012-10-23 Thread Mark Brown
current architectures that HAVE_CLK but don't use the common clock framework have selects of HAVE_CUSTOM_CLK added. This allows drivers to use the generic API on platforms which have no need for the clock API at platform level. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked

Re: [Patch v3 2/7] Regulator: DA9055 Regulator driver

2012-10-23 Thread Mark Brown
On Tue, Oct 23, 2012 at 03:32:25PM +0530, Ashish Jangam wrote: Does this patch looks good for you? Don't top post and don't send contentless pings. I've not yet read the patch and as previously explained nagging like this just means things take longer; you'd achieve more with basic stuff like

Re: [PATCH 2/2] mmc: sdhci: Defer probe if regulator_get fails

2012-10-23 Thread Mark Brown
On Tue, Oct 23, 2012 at 10:29:41AM -0600, Stephen Warren wrote: On 10/23/2012 01:57 AM, Lucas Stach wrote: Does this work with boards where we don't have any MMC supplies? Or are we just deferring the probe indefinitely there? For boards that power MMC unconditionally, are we supposed to

Re: [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support

2012-10-23 Thread Mark Brown
with the range checks in the default: case. Actually you could just use the GCC switch range feature: case PCIE_PM_STATUS_0_PORT_0_4..PCIE_PM_STATUS_7_0_EP4: Either of these would increase readability. but generally Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc

Re: [PATCH v3 6/6] Add a codec driver for SI476X MFD

2012-10-23 Thread Mark Brown
On Tue, Oct 23, 2012 at 11:44:32AM -0700, Andrey Smirnov wrote: This commit add a sound codec driver for Silicon Laboratories 476x series of AM/FM radio chips. I already merged a driver for this. If there are any changes you should send incremental updates rather than a full new driver.

Re: [PATCH 2/2] ASoC: ux500_msp_i2s: Fix devm_* and return code merge error

2012-10-24 Thread Mark Brown
On Wed, Oct 24, 2012 at 11:34:00AM +0200, Ulf Hansson wrote: Acked-by: Ulf Hansson ulf.hans...@linaro.org I assume this shall go into 3.7, right? Kind regards Ulf Hansson You may recall that only yesterday I reminded you not to top post... signature.asc Description: Digital signature

Re: [PATCH 190/193] sound/soc/fsl: remove CONFIG_EXPERIMENTAL

2012-10-24 Thread Mark Brown
On Tue, Oct 23, 2012 at 01:04:23PM -0700, Kees Cook wrote: This config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it. Applied, thanks. Please use subject lines matching the subsystem.

Re: [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support

2012-10-24 Thread Mark Brown
On Wed, Oct 24, 2012 at 02:31:18PM +0200, Davide Ciminaghi wrote: On Tue, Oct 23, 2012 at 06:18:38PM +0100, Mark Brown wrote: This and most of your other readable/writable things look like a framework feature waiting to be written - something data driven which takes a table of register

[GIT PULL] SPI updates for v3.7

2012-10-24 Thread Mark Brown
The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git tags/spi-linus for you to fetch changes up to

Re: [PATCH v2 2/4] gpio: add viperboard gpio driver

2012-10-24 Thread Mark Brown
I'm looping in Mark Brown to get some hints whether the following can be resolved easily or needs to be given up on... Some context would've been enormously useful for working out what the discussion is all about... this is *very* verbose and not at all clear. Setting the direction to output

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-10-24 Thread Mark Brown
On Tue, Oct 23, 2012 at 03:10:20PM -0700, Christopher Heiny wrote: On 10/11/2012 10:16 PM, Mark Brown wrote: On Thu, Oct 11, 2012 at 03:56:22AM +, Christopher Heiny wrote: Fix your mailer to word wrap within paragraphs. Sorry - I was on the road and had to use a web interface. It looked

[PATCH] mfd: wm5102: Update register patch for latest evaluation

2012-10-08 Thread Mark Brown
Latest evaluation of the device has provided some revisions to the configuration. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: sta...@vger.kernel.org --- Would it be OK to merge this via ASoC? It'd help with bisection. drivers/mfd/wm5102-tables.c | 519

[PATCH] mfd: da9055: Remove unprintable characters from headers

2012-10-08 Thread Mark Brown
There seem to be a number of unprintable characters at the head of some of the DA9055 include files which cause issues with some tools; remove them. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- include/linux/mfd/da9055/core.h |2 +- include/linux/mfd/da9055/pdata.h

Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

2012-10-08 Thread Mark Brown
On Tue, Oct 09, 2012 at 06:56:02AM +0800, Ming Lei wrote: Considered that zero-length firmware image doesn't make sense for drivers (callers), maybe it is a insane firmware image, so how about treating it as a failure? It seems better to punt that decision to callers - for example, the case I

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-09 Thread Mark Brown
or dynamically allocated and otherwise using a linear mapping. Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com but can you convert to regmap_irq? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/3] mfd: tps6586x: add irq io-resource for rtc sub driver

2012-10-09 Thread Mark Brown
On Mon, Oct 08, 2012 at 09:43:24PM +0530, Laxman Dewangan wrote: Add IRQ IORESOURCE for rtc sub driver of this device. The rtc driver can get the irq by calling platform_get_irq(). Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [PATCH 3/3] mfd: tps6586x: implement gpio_to_irq

2012-10-09 Thread Mark Brown
On Mon, Oct 08, 2012 at 09:43:25PM +0530, Laxman Dewangan wrote: The TPS6586x adds the interrupt of this device using linear mapping on irq domain. Hence, implement gpio_to_irq to get the irq number corresponding to TPS6586x GPIOs which is created dynamically. Reviewed-by: Mark Brown broo

Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? -- To unsubscribe

Re: [PATCH 2/5] regulator; tps65090: Register all regulators in single probe call

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:48PM +0530, Laxman Dewangan wrote: MFD drier registers the regulator driver once per device and hence it is require to register all regulators in single probe call. Following are details of changes done to achieve this: - Add max regulator and register all

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 11:18:24AM +0530, Laxman Dewangan wrote: On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote: but can you convert to regmap_irq? Yes, the motivation was this when I started this cleanups but found that there is 4 interrupt status and 5 interrupt mask register

Re: [PATCH 4/5] regulator: tps65090: Add voltage out level in platform data

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:50PM +0530, Laxman Dewangan wrote: TPS65090's DCDCs and FETs act as switch and so output voltage can be enable or disable only. The output voltage of this regulators depends on the input voltage. Add the voltage parameter to tell the output voltage value of

Re: [PATCH 5/5] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:51PM +0530, Laxman Dewangan wrote: The TPS65090's DCDC outut can also be enable/disable through the external digital input signal. Add support for enable/disable either through register access via I2C or through external control inputs. The external control inputs

Re: [PATCH v2 2/6] Add the main bulk of core driver for SI476x code

2012-10-09 Thread Mark Brown
On Fri, Oct 05, 2012 at 06:54:58PM -0700, Andrey Smirnov wrote: + err = regulator_enable(core-supplies.va); + if (err 0) + break; + + err = regulator_enable(core-supplies.vio2); +

Re: [PATCH v2 6/6] Add a codec driver for SI476X MFD

2012-10-09 Thread Mark Brown
On Fri, Oct 05, 2012 at 06:55:02PM -0700, Andrey Smirnov wrote: This commit add a sound codec driver for Silicon Laboratories 476x series of AM/FM radio chips. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 11:34:47AM +0530, Laxman Dewangan wrote: The bit definitions are also different in status and mask register and yes, this will be again problem as we do in isr thread data-status_buf[i] = ~data-mask_buf[i]; So given the constraint, generic will not work here. OK,

Re: [PATCH 5/5] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 11:51:19AM +0530, Laxman Dewangan wrote: On Tuesday 09 October 2012 11:58 AM, Mark Brown wrote: There's support for GPIO driven enable lines in the framework already, this driver should be able to use this happily, this sort of hardware is exactly the use case

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: Mostly OK, but there's a few issues including yet more reimplementation of framework features. +static int da9055_list_voltage(struct regulator_dev *rdev, + unsigned int selector) +{ + struct

Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 03:05:30PM +0800, Ming Lei wrote: On Tue, Oct 9, 2012 at 12:19 PM, Mark Brown It seems better to punt that decision to callers - for example, the case In fact, -ENOENT is returned to caller for non-direct loading situation, see_request_firmware_load(). I understand

Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 03:34:52PM +0800, Ming Lei wrote: Yes, I agree, and my question is only on what you mentioned: it didn't want to load an optional image maybe I misunderstood the above, never mind, :-) So one driver should suppose the firmware is there, and the

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 09:43:13AM +0200, Linus Walleij wrote: On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny che...@synaptics.com wrote: + * @cs_assert - For systems where the SPI subsystem does not control the CS/SSB + * line, or where such control is broken, you can provide a

Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:03:19PM +0530, Venu Byravarasu wrote: -Original Message- From: Laxman Dewangan Sent: Tuesday, October 09, 2012 3:19 PM Please, when replying to mails delete irrelevant text - only quote the bits of text you're replying to. This is very helpful to people

Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 08:02:18PM +0800, Ming Lei wrote: If loading via user space, timeout or not depends on userspace, at least udev won't timeout on non-existent firmware image. This may be a mdev or old udev thing... it's definitely prevelant. Also looks request_firmware_nowait() is

Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 10:55:17PM +0800, Ming Lei wrote: On Tue, Oct 9, 2012 at 8:36 PM, Mark Brown On Tue, Oct 09, 2012 at 08:02:18PM +0800, Ming Lei wrote: It doesn't really help as the ABI is such that you can only have one Could you let me know where the ABI is? It's defined

Re: [PATCH 4/5] regmap: add API to get irq_domain from regmap irq

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:58:35PM +0530, Laxman Dewangan wrote: Add API regmap_irq_get_irq_domain() for getting the irq domain from regmap irq. The irq domain created on result of regmap_add_irq_chip() from driver. This needs stubbing. Please also fix the formatting of your commit log,

Re: [PATCH 1/5] mfd: tps65910: use regmap irq framework for interrupt support

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:58:32PM +0530, Laxman Dewangan wrote: Implement irq support of tps65910 with regmap irq framework in place of implementing locally. This reduces the code size significantly and easy to maintain. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [PATCH 2/5] mfd: tps65910: move interrupt implementation code to mfd file

2012-10-09 Thread Mark Brown
. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/5] mfd: tps65910: Initialize mfd devices after all initialization done

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:58:34PM +0530, Laxman Dewangan wrote: Add sub devices of tps65910 after all initialization like interrupt, clock etc. is done. This will make sure that require data gets initialized properly before sub devices probe's get called. Reviewed-by: Mark Brown broo

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:30:16PM +0530, Ashish Jangam wrote: On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: + /* Set the GPIO I/P pin for controlling the regulator state. */ + ret

Re: [RFC] regulator: core: Support for continuous voltage range

2012-10-11 Thread Mark Brown
On Mon, Sep 24, 2012 at 06:56:53PM +0100, Pawel Moll wrote: Some regulators can set any voltage within the constraints range, not being limited to specified operating points. This patch makes it possible to describe such regulator and makes the regulator_is_supported_voltage() function

Re: [PATCH v3] regulator: Versatile Express regulator driver

2012-10-11 Thread Mark Brown
On Mon, Sep 24, 2012 at 06:56:54PM +0100, Pawel Moll wrote: Implementation of the regulator framework driver for the Versatile Express voltage control. Devices without voltage constraints (ie. regulator-[min|max]-microvolt properties in the DT node) are treated as fixed (or rather read-only)

Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Minor improvements

2012-10-11 Thread Mark Brown
On Wed, Oct 10, 2012 at 05:24:53PM +0530, Ashish Chavan wrote: This patch includes two minor improvements for da9055 codec driver (1) Adding support for DSP mode of AIF (2) Muting Mic PGAs during ALC calibration process Send one patch per change. I suspect the second change is a bug fix

Re: [PATCH V2 4/5] regmap: add API to get irq_domain from regmap irq

2012-10-11 Thread Mark Brown
On Wed, Oct 10, 2012 at 10:49:04PM +0530, Laxman Dewangan wrote: Add API regmap_irq_get_irq_domain() for getting the irq domain from regmap irq. The irq domain created on result of regmap_add_irq_chip() from driver. Applied, thanks. I'll push out a signed tag

Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Add support for DSP mode of AIF

2012-10-11 Thread Mark Brown
On Thu, Oct 11, 2012 at 01:44:39PM +0530, Ashish Chavan wrote: This patch adds AIF DSP mode support for da9055 codec driver. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Minor improvement in ALC calibration process

2012-10-11 Thread Mark Brown
On Thu, Oct 11, 2012 at 02:04:37PM +0530, Ashish Chavan wrote: This patch slightly improves ALC calibration process of da9055 codec driver by muting Mic PGAs during calibration. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-10-11 Thread Mark Brown
On Thu, Oct 11, 2012 at 03:56:22AM +, Christopher Heiny wrote: Fix your mailer to word wrap within paragraphs. If this feature is a deal-breaker, we can take it out. In the absence of a generic GPIO implementation for CS, though, I'd much rather leave it in. Once generic GPIO CS

Re: [PATCH] regmap : make lock/unlock functions customizable.

2012-10-12 Thread Mark Brown
On Mon, Oct 01, 2012 at 11:31:04PM +0200, cimina...@gnudd.com wrote: From: Davide Ciminaghi cimina...@gnudd.com It is sometimes convenient for a regmap user to override the standard regmap lock/unlock functions with custom functions. This looks good overall but... -static void

Re: [PATCH v2] regmap: silence GCC warning

2012-10-12 Thread Mark Brown
On Mon, Oct 08, 2012 at 10:06:30PM +0200, Paul Bolle wrote: Long story short: Jakub Jelinek pointed out that there is a type mismatch between 'num' in regmap_volatile_range() and 'val_count' in regmap_raw_read(). And indeed, converting 'num' to the type of 'val_count' (ie, size_t) makes this

Re: [PATCH v2 2/4] gpio: add viperboard gpio driver

2012-10-25 Thread Mark Brown
On Thu, Oct 25, 2012 at 12:02:36PM +0200, Lars Poeschel wrote: You can reread our conversation before Linus Walleij brought you in starting with my first patch submission here: https://lkml.org/lkml/2012/10/12/218 This has all the problems of this and your previous mail - here we've got

Re: [PATCH 1/2] mfd: arizona: Use correct array for ARRAY_SIZE in mfd_add_devices call

2012-10-25 Thread Mark Brown
. Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked

2012-10-25 Thread Mark Brown
error messages for all cases. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH v2 2/4] gpio: add viperboard gpio driver

2012-10-25 Thread Mark Brown
On Thu, Oct 25, 2012 at 06:02:42PM +0200, Lars Poeschel wrote: On Thursday 25 October 2012 at 16:00:13, Mark Brown wrote: Why would you want to implement this as a bus? If you're not actually rendering things down into a register and value on the bus then you should be hooking

Re: [PATCH] ASoC: wm5102: Correct micbias DAPM supplies

2012-10-25 Thread Mark Brown
On Thu, Oct 25, 2012 at 03:24:42PM +0100, Charles Keepax wrote: ARIZONA_MICB1_ENA_SHIFT was used for micbias 2 and 3. This change correctly uses the ARIZONA_MICBX_ENA_SHIFT for each corresponding DAPM supply. This should not have caused any problems as the micbias enables are in the same place

Re: [PATCH] regmap: Fix printing of size_t variable

2012-10-25 Thread Mark Brown
On Thu, Oct 25, 2012 at 02:07:18PM -0200, Fabio Estevam wrote: val_bytes is of 'size_t', so it should be printed as '%zu'. Fixes the following build warning on x86: drivers/base/regmap/regmap.c:872:4: warning: format '%d' expects argument of type 'int', but argument 5 has type 'size_t'

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-25 Thread Mark Brown
On Tue, Oct 23, 2012 at 11:44:28AM -0700, Andrey Smirnov wrote: + core-regmap = devm_regmap_init_si476x(core); + if (IS_ERR(core-regmap)) { This really makes little sense to me, why are you doing this? Does the device *really* layer a byte stream on top of I2C for sending messages

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-25 Thread Mark Brown
On Wed, Oct 24, 2012 at 09:58:19PM +0300, Felipe Balbi wrote: need a way to tell drivers/base hey, don't touch pinctrl at all because I know what I'm doing and that has to happen before probe() too, otherwise it's already too late and, according to what you suggest, drivers/base will already

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-26 Thread Mark Brown
On Fri, Oct 26, 2012 at 09:20:36AM +0300, Felipe Balbi wrote: On Thu, Oct 25, 2012 at 09:59:01PM +0100, Mark Brown wrote: I suspect that's not actually a big deal and that if we went down this route we'd have the driver take over control from the core code during probe() with the core

[PATCH] regmap: core: Report registers in hex when we can't cache

2012-10-26 Thread Mark Brown
This seems to be the most common way of reporting register numbers, it's certainly what we do for trace. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/base/regmap/regmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap

[PATCH] mfd: wm5102: Update maximum register

2012-10-26 Thread Mark Brown
The DSP memories are mapped into the register map, make them readable and writable by updating max_register appropriately. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/mfd/wm5102-tables.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] regmap: Fix printing of size_t variable

2012-10-27 Thread Mark Brown
On Thu, Oct 25, 2012 at 03:52:32PM -0700, Randy Dunlap wrote: Acked-by: Randy Dunlap rdun...@xenotime.net There's not much point in doing this after a patch has been applied... http://marc.info/?l=linux-kernelm=135041943424273w=2 So, the difference between Fabio's patch and your patch is

[GIT PULL] MXS SPI fixes for v3.7

2012-10-27 Thread Mark Brown
The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git tags/spi-mxs for you to fetch changes up to

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-27 Thread Mark Brown
On Thu, Oct 25, 2012 at 03:26:02PM -0700, Andrey Smirnov wrote: On 10/25/2012 12:45 PM, Mark Brown wrote: This really makes little sense to me, why are you doing this? Does the device *really* layer a byte stream on top of I2C for sending messages that look like marshalled register reads

Re: [PATCH v2 2/4] gpio: add viperboard gpio driver

2012-10-27 Thread Mark Brown
On Sat, Oct 27, 2012 at 06:14:16PM +0200, Linus Walleij wrote: I think you've done an honest effort (more than most would do for sure) to explore the ways of the regmap. If it doesn't fit, it doesn't fit and that's it. The bus stuff is needed by a bunch of other drivers - there's a similar

Re: [PATCH] gpiolib: Don't return -EPROBE_DEFER to sysfs, or for invalid gpios

2012-10-27 Thread Mark Brown
On Fri, Oct 26, 2012 at 09:26:33AM +0200, Linus Walleij wrote: On Thu, Oct 25, 2012 at 1:03 PM, Mathias Nyman gpios requested with invalid numbers, or gpios requested from userspace via sysfs should not try to be deferred on failure. Very good catch. I applied this to my fixes branch

Re: [PATCH 3.7-rc1] omap zoom2.c: Fix compile error by including correct header files

2012-10-27 Thread Mark Brown
On Wed, Oct 03, 2012 at 09:31:02AM -0700, Tony Lindgren wrote: Actually we can also drop #include mach/hardware.h too, it's now empty for mach-omap2. I've updated Tim's patch below for you guys to queue via the ASoC fixes. It's against the current linux next. Applied. Tim, you should send

Re: [Patch v3 2/7] Regulator: DA9055 Regulator driver

2012-10-27 Thread Mark Brown
On Thu, Oct 11, 2012 at 03:39:24PM +0530, Ashish Jangam wrote: This is the Regulator patch for the DA9055 PMIC and has got dependency on the DA9055 MFD core. Always submit patches with subject lines appropriate for the subsystem, this helps get your patch noticed. People do things like search

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-27 Thread Mark Brown
On Fri, Oct 26, 2012 at 02:57:50PM -0500, Rob Herring wrote: Like I said previously, I think we first need guidelines on what is and isn't acceptable use of C preprocessor in dts files. Didn't we already say that it was just the same rules as for things tht get included in .S files? Besides

Re: [Q] .readable_reg() not verified during read?

2012-10-28 Thread Mark Brown
On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: Looking at regmap.c it looks like the .readable_reg() callback is not consulted when performing a register read, e.g. in _regmap_raw_read(). Is this intentional? If yes - why? No real reason, though to be honest it's not

Re: [PATCH] Regulator: core: Unregister when gpio request fails.

2012-10-28 Thread Mark Brown
On Sun, Oct 28, 2012 at 04:01:11PM +0100, Andrew Lunn wrote: If the gpio_request_one() fails, or returns EPROBE_DEFER, the regulator must be device_unregister()ed. When this is not done, there are WARNING: from sysfs: WARNING: at fs/sysfs/file.c:343 sysfs_open_file+0x238/0x268() Applied,

Re: [Patch v3 2/7] Regulator: DA9055 Regulator driver

2012-10-29 Thread Mark Brown
On Mon, Oct 29, 2012 at 05:37:58PM +0530, Ashish Jangam wrote: On Sat, 2012-10-27 at 22:59 +0100, Mark Brown wrote: Always submit patches with subject lines appropriate for the subsystem, this helps get your patch noticed. People do things like search their mailboxes for subsystem

Re: [Q] .readable_reg() not verified during read?

2012-10-29 Thread Mark Brown
On Mon, Oct 29, 2012 at 08:40:55AM +0100, Guennadi Liakhovetski wrote: On Sun, 28 Oct 2012, Mark Brown wrote: No real reason, though to be honest it's not that important - the main reason for having the function is to make the debugfs stuff work nicely rather than anything else. But what

<    1   2   3   4   5   6   7   8   9   10   >