re to test it on *or* userland to issue the ioctls in
> question. So this series definitely needs a review and testing
> from hpsa maintainers before it might go anywhere.
Don: Please test and review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
27; and can be fixed
> by not set JOB when reset_devices on
Broadcom: Please review.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
> This code was using get_user_pages*(), in a "Case 1" scenario (Direct
> IO), using the categorization from [1]. That means that it's time to
> convert the get_user_pages*() + put_page() calls to pin_user_pages*()
> + unpin_user_pages() calls.
Kai: Please rev
Chris,
> I think you might be right. I also don't have much time to maintain it
> these days and the hardware I had is long dead.
In that case I'd appreciate a patch to remove it.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
urn/returns/
> object will be freed in bio_integrity_free() since 'bio->bi_opf' and
> 'bio->bi_integrity' was set previousy in bio_integrity_alloc().
s/was/were/
Otherwise OK.
And like Ming pointed out, you may want to add a comment about the
assertion that the fir
es
https://git.kernel.org/mkp/scsi/c/c7cee3e746a5
[3/4] scsi: ufs: Fix index of attributes query for WriteBooster feature
https://git.kernel.org/mkp/scsi/c/e31011ab3709
[4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend
https://git.kernel.org/mkp/scsi/c/51dd905bd2f6
k when processing unsolicited event
https://git.kernel.org/mkp/scsi/c/7217e6e694da
--
Martin K. Petersen Oracle Linux Engineering
; 'ibmvscsi_module_exit' was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: Make some functions static
https://git.kernel.org/mkp/scsi/c/1f93ad177d24
--
Martin K. Petersen Oracle Linux Engineering
; ufshcd_print_host_regs -> ufshcd_vops_dbg_register_dump ->
> ufs_qcom_dump_dbg_regs
>
> [...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ufs-qcom: Fix scheduling while atomic issue
https://git.kernel.org/mkp/scsi/c/3be60b564de4
--
Martin K. Petersen Oracle Linux Engineering
hanges
https://git.kernel.org/mkp/scsi/c/22617e216331
--
Martin K. Petersen Oracle Linux Engineering
;ll send a v3 if necessary, to correct that.
I'll fix it up when I apply.
--
Martin K. Petersen Oracle Linux Engineering
function
https://git.kernel.org/mkp/scsi/c/840e1b55bb75
--
Martin K. Petersen Oracle Linux Engineering
omplete_vX_hw()
https://git.kernel.org/mkp/scsi/c/1cdee0044261
--
Martin K. Petersen Oracle Linux Engineering
device() iteration with break or return,
> scsi_device_put() should be used to prevent stale scsi device references from
> being left behind.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: core: Fix incorrect usage of shost_for_each_device
https://git.kernel.org/mkp/scsi/c/4dea170f4fb2
by a target.
>
> This version ensures the initiator name is also printed on the same
> message in transport_lookup_tmr_lun for consistency.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: target: core: Add initiatorname to NON_EXISTENT_LUN error
https://git.kernel.org/mkp/scsi/c/5482d
that up. But I'll give Kai a chance to review before I apply.
--
Martin K. Petersen Oracle Linux Engineering
lush policy
https://git.kernel.org/mkp/scsi/c/f48b285ae658
--
Martin K. Petersen Oracle Linux Engineering
>
> While the other driver's entry looks like:
>
> [...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: hisi_sas: Display proc_name in sysfs
https://git.kernel.org/mkp/scsi/c/55ce24b3bfd7
--
Martin K. Petersen Oracle Linux Engineering
si: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
https://git.kernel.org/mkp/scsi/c/21d2b76831fd
--
Martin K. Petersen Oracle Linux Engineering
tch
4 got tagged as reviewed in patchwork.
--
Martin K. Petersen Oracle Linux Engineering
c: Remove redundant initialization to variable rc
https://git.kernel.org/mkp/scsi/c/6e27a86aed97
--
Martin K. Petersen Oracle Linux Engineering
cf
[7/8] scsi: ufs-mediatek: Enable WriteBooster capability
https://git.kernel.org/mkp/scsi/c/29060a629135
[8/8] scsi: ufs: Cleanup WriteBooster feature
https://git.kernel.org/mkp/scsi/c/79e3520f82cb
--
Martin K. Petersen Oracle Linux Engineering
ev & uctrl
https://git.kernel.org/mkp/scsi/c/f9491ed56e3a
--
Martin K. Petersen Oracle Linux Engineering
duced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> [...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ufs: Replace zero-length array with flexible-array
https://git.kernel.org/mkp/scsi/c/ec38c0adc0a1
--
Martin K. Petersen Oracle Linux Engineering
ad_iocmd_ioc_get_stats() static
https://git.kernel.org/mkp/scsi/c/102026483d2b
--
Martin K. Petersen Oracle Linux Engineering
duced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> [...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: libsas: Replace zero-length array with flexible-array
https://git.kernel.org/mkp/scsi/c/00b42b70ae52
--
Martin K. Petersen Oracle Linux Engineering
, thanks!
[1/1] scsi: aacraid: Use memdup_user() as a cleanup
https://git.kernel.org/mkp/scsi/c/8d925b1f00e6
--
Martin K. Petersen Oracle Linux Engineering
g/mkp/scsi/c/b59293b469b9
--
Martin K. Petersen Oracle Linux Engineering
validation logic in my commit hook script to ensure 12
digits going forward.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
msg
https://git.kernel.org/mkp/scsi/c/013f69a931e7
--
Martin K. Petersen Oracle Linux Engineering
ped
https://git.kernel.org/mkp/scsi/c/dbe6f49259da
--
Martin K. Petersen Oracle Linux Engineering
variable: "rval".
> Return "0" on line 1768
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Make qlafx00_process_aen() return void
https://git.kernel.org/mkp/scsi/c/88bfdf565cbe
--
Martin K. Petersen Oracle Linux Engineering
le
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Use true, false for need_mpi_reset
https://git.kernel.org/mkp/scsi/c/bda552a7741a
--
Martin K. Petersen Oracle Linux Engineering
pplied to 5.8/scsi-queue, thanks!
[1/1] scsi: qedi: Remove comparison of 0/1 to bool variable
https://git.kernel.org/mkp/scsi/c/9187745ceec6
--
Martin K. Petersen Oracle Linux Engineering
not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: aacraid: Make some symbols static
https://git.kernel.org/mkp/scsi/c/297083f6e53b
--
Martin K. Petersen Oracle Linux Engineering
rs/scsi/qla2xxx/qla_attr.c:1906:5-7: Unneeded variable: "rc".
> Return "0" on line 2180
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Make qla_set_ini_mode() return void
https://git.kernel.org/mkp/scsi/c/1b007f96f9e0
--
Martin K. Petersen Oracle Linux Engineering
t;use_32bit_dma
https://git.kernel.org/mkp/scsi/c/55d4ce458c77
--
Martin K. Petersen Oracle Linux Engineering
eset_inprogress
https://git.kernel.org/mkp/scsi/c/b91857a5ca13
--
Martin K. Petersen Oracle Linux Engineering
https://git.kernel.org/mkp/scsi/c/a3b923842626
--
Martin K. Petersen Oracle Linux Engineering
csi-queue, thanks!
[1/1] scsi: qla2xxx: make 1-bit bit-fields unsigned int
https://git.kernel.org/mkp/scsi/c/78b874b7cbf0
--
Martin K. Petersen Oracle Linux Engineering
;chan < 0'
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: dpt_i2o: Remove always false 'chan < 0' statement
https://git.kernel.org/mkp/scsi/c/6f41f08c88c5
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> Do you want me to resend, or can you fixup your tree?
I fixed it up.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/cxlflash/main.c:47:22: warning:
> variable ioarcb set but not used [-Wunused-but-set-variable]
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Hi Daniel,
> The initial lpfc_desc_set_adisc implementation dea3101e0a5c ("lpfc:
> add Emulex FC driver version 8.0.28") enabled ADISC if
Fixed up Hannes' email typo and applied to 5.4/scsi-fixes.
Also, please run checkpatch next time. Thanks!
--
Martin K. Peter
Daniel,
> The queue pointer might not be valid. The rest of the code checks the
> pointer before accessing it. lpfc_sli4_process_missed_mbox_completions
> is the only place where the check is missing.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
fix missing .cleanup_rq for SCSI hosts without request
batching
scsi: core: fix dh and multipathing for SCSI hosts without request
batching
drivers/scsi/scsi_lib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
Martin K. Petersen Oracle Linux Engineering
Thomas,
> Add the missing depends SCSI_SNI_53C710 to 53C700_LE_ON_BE to fix it.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Thomas,
> Drop out memory dev_printk() with wring device pointer argument.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Paul,
> I do not intend to actually remove rcu_swap_protected() until 5.6 for
> exactly this sort of thing. My plan is to take another pass through
> the tree after 5.5 comes out, and these will be caught at that time.
>
> Does that work for you?
Yep, that's great. T
Masahiro,
>> Fine with me. Is it going through your tree or should I pick it up?
>
> Could you please apply it to your tree?
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Allen,
> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
dev->inquiry_mutex));
Just a heads-up that we have added a couple of additional VPD pages so
my 5.5 tree will need additional calls to be updated to rcu_replace().
--
Martin K. Petersen Oracle Linux Engineering
Masahiro,
>> Add a header include guard just in case.
Fine with me. Is it going through your tree or should I pick it up?
--
Martin K. Petersen Oracle Linux Engineering
> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.
Himanshu: Please review!
--
Martin K. Petersen Oracle Linux Engineering
hread, I think we're
better off enhancing the existing process documents instead of
introducing more places for people to look.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fix sparse warning:
>
> drivers/scsi/bfa/bfad.c:1491:1: warning:
> symbol 'restart_bfa' was not declared. Should it be static?
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Vignesh,
> This series add DT bindings and driver for TI wrapper for Cadence UFS
> IP that is present on TI's J721e SoC
Will need some reviews from DT and ufs folks respectively before I can
queue this up.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
rmware documentation
> it is possible that multiple status continuations are emitted by the
> firmware.
Applied to 5.4/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Austin,
> Since 'commit fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")' was
> introduced, there is no call to csk_print_port()
> and csk_print_ip() is made.
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> There are some statements that are indented too deeply, remove the
> extraneous tabs and rejoin split lines.
Applied (additional hunk) to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> The goto statement is indented incorrectly, remove the extraneous tab.
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
plied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
-t'
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> There is a spelling mistake in literal string. Fix it.
Applied to 5.5/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
Navid,
> In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory
> needs to be released.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Don't populate the array dev_cmd_err on the stack but instead make it
> static const. Makes the object code smaller by 80 bytes.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Don't populate the array setup_attrs on the stack but instead make it
> static const. Makes the object code smaller by 180 bytes.
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Don't populate the array 'options' on the stack but instead make it
> static const. Makes the object code smaller by 143 bytes.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> The variable rc is being initialized with a value that is never read
> and is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> The pointer host is being initialized with a value that is never read
> and is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
unused-but-set-variable]
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> There is a statement that is indented one level too deeply, remove the
> tab, re-join broken line and remove some empty lines.
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
ase, feel free to take this
through the PCI tree.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
lloc' was not declared. Should it be
> static?
> drivers/scsi/hisi_sas/hisi_sas_main.c:3799:6:
> warning: symbol 'hisi_sas_debugfs_bist_init' was not declared. Should it be
> static?
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Long,
> storvsc doesn't use a dedicated hardware queue for a given CPU
> queue. When issuing I/O, it selects returning CPU (hardware queue)
> dynamically based on vmbus channel usage across all channels.
Applied to 5.4/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Austin,
> Since tmp_prio is declared as u8, the following statement is always false.
>tmp_prio < 0
>
> So remove 'always false' statement.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Denis,
> Replace the magic constant (6) with define PCI_STD_NUM_BARS
> representing the number of PCI BARs.
Applied to 5.4/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
only supports interleaved
> metadata so far given how awkward that is to deal with.
Yep. There's a reason we did DIX...
--
Martin K. Petersen Oracle Linux Engineering
is
not always easy to determine whether a bug fix series is for one tree or
the other.
--
Martin K. Petersen Oracle Linux Engineering
Dexuan,
> When we're in storvsc_suspend(), we're sure the SCSI layer has
> quiesced the scsi device by scsi_bus_suspend() -> ... ->
> scsi_device_quiesce(), so the low level SCSI adapter driver only needs
> to suspend/resume its own state.
Acked-by: Martin K. Peter
Hi Bart,
> On 9/11/19 5:40 PM, Martin K. Petersen wrote:
>> * Do not use custom To: and Cc: for individual patches. We want to see the
>> whole series, even patches that potentially need to go through a different
>> subsystem tree.
>
> Thanks for having written
ty bad at indicating the
intended target tree. I often ask for it in private mail but the
practice doesn't seem to stick. I spend a ton of time guessing whether a
patch is a fix for a new feature in the x+1 queue or a fix for the
current release. It is not always obvious.
--
Martin K. Petersen Oracle Linux Engineering
looks pretty good to me.
After the Plumbers session last year I wrote this for SCSI based on a
prior version by Christoph. It's gone a bit stale but I'll update it to
match your template.
--
Martin K. Petersen Oracle Linux Engineering
===
John,
> This patchset includes support for some more minor features, a bit of
> tidying, and a few patches to make the driver a bit more robust.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
ue size
> (currently 8).
>
> Scan existing LUNs when events are missed to check if they are still
> present. If not, remove them.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use kmemdup rather than duplicating its implementation
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bjorn,
> This series adds a new ufs vops to allow platform specific methods for
> resetting an attached UFS device, then implements this for the
> Qualcomm driver. This reset seems to be necessary for the majority of
> Dragonboard845c devices.
Applied to 5.4/scsi-queue, thanks!
Sakari,
> Convert the remaining %pf users to %ps to prepare for the removal of
> the old %pf conversion specifier support.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> There is a spelling mistake in a ql_log message. Fix it.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
ny serious io load triggers controller aborts)
Microchip folks: Please review!
--
Martin K. Petersen Oracle Linux Engineering
nt
> and can be removed.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Anil,
> Some UFS devices have issues if LCC is enabled. So we are setting
> PA_LOCAL_TX_LCC_Enable to 0 before link startup which will make sure
> that both host and device TX LCC are disabled once link startup is
> completed.
Applied to 5.4/scsi-queue. Thanks!
--
Martin
Colin,
> Variable error is being initialized with a value that is never read
> and error is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Hariprasad,
> As dma_pool_destroy and mempool_destroy functions has NULL check. We may
> not need NULL check before calling them.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
o trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please don't split Fixes tags over more than one line.
>
> Fixes tag
>
> Fixes: (a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump
>
> has these problem(s):
>
>
Colin,
> Variable ret is initialized to a value that is never read and it is
> re-assigned later and immediatetly returns. Clean up the code by
> removing rc and just returning 0.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
] device_resume+0x11b/0x220
>
> Voltage regulators are optional, so functions must check they exist
> before dereferencing.
>
> Note this issue is hidden if CONFIG_REGULATORS is not set, because the
> offending code is optimised away.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
601 - 700 of 1499 matches
Mail list logo
