[PATCH v3] input: tablet: add Pegasus Notetaker tablet driver

*really* fun to use as an input tablet though! So let's support this for everybody. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Any advice or objections? I'm sure this would be used if available like this. It was a quite popular device. I use it for quite some time and like it a l

Re: [patch V4 01/31] bitops: add parity functions

Am 2016-05-11 um 10:47 schrieb zengzhao...@163.com: > From: Zhaoxiu Zeng > > Add generic parity functions, adapted from > "https://graphics.stanford.edu/~seander/bithacks.html#ParityParallel;. > > The function parityN returns whether an odd or even number of bits are on

[PATCH] input: tablet: add Pegasus Notetaker tablet driver

*really* fun to use as an input tablet though! So let's support this for everybody. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/Kconfig | 15 ++ drivers/input/tablet/Makefile| 1 + drivers/input/tablet/pegasus_notetaker.c | 4

Re: [PATCH] iio: mma8452: add support for oversampling ratio

Am 2016-04-25 um 14:08 schrieb Martin Kepplinger: > This adds the following sysfs files according to the iio ABI: > > -rw-r--r--4096 in_accel_oversampling_ratio > -r--r--r--4096 in_accel_oversampling_ratio_available > > Internally, the device knows about 4 dif

[PATCH] rtc-pcf2123: use sign_extend32() for sign extension

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/rtc/rtc-pcf2123.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index f22e060..b4478cc 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/r

[PATCH v4] input: tablet: add Pegasus Notetaker tablet driver

*really* fun to use as an input tablet though! So let's support this for everybody. There's no way to disable the device. When the pen is out of range, we just don't get any URBs and don't do anything. Like all other mouses or input tablets, we don't use runtime PM. Signed-off-by: Martin Kepplinger

Re: [PATCH 2/4] input: tablet: pegasus_notetaker: Fix usb_autopm calls to be balanced

Am 2016-07-20 um 23:29 schrieb Dmitry Torokhov: > On Mon, Jul 18, 2016 at 04:29:07PM +0200, Martin Kepplinger wrote: >> Signed-off-by: Martin Kepplinger <mart...@posteo.de> >> --- >> drivers/input/tablet/pegasus_notetaker.c | 19 +++ >> 1

Re: [PATCH 1/4] input: tablet: pegasus_notetaker: Track usb control msg errors

Am 2016-07-20 um 23:06 schrieb Dmitry Torokhov: > Hi Martin, > > On Mon, Jul 18, 2016 at 04:29:06PM +0200, Martin Kepplinger wrote: >> Signed-off-by: Martin Kepplinger <mart...@posteo.de> >> --- >> drivers/input/tablet/pegasus_notetaker.c | 26

[PATCH 3/4] input: tablet: pegasus_notetaker: Cancel workqueue's work in suspend()

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/pegasus_notetaker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c index fdbc5e8..07436c6 100644 --- a/drivers/input/

[PATCH 2/4] input: tablet: pegasus_notetaker: Fix usb_autopm calls to be balanced

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/pegasus_notetaker.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c index 27cb352..f

[PATCH 4/4] input: tablet: pegasus_notetaker: Set device mode in reset_resume() if in use

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/pegasus_notetaker.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c index 07436c6..b172247

[PATCH 1/4] input: tablet: pegasus_notetaker: Track usb control msg errors

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/pegasus_notetaker.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c index 8

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > Hi Martin, > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: >> static int pegasus_reset_resume(struct usb_interface *intf) >> { >> +struct pegasus *pegasus = usb_get_intfdata(intf); >>

Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements

Am 2016-07-05 um 22:04 schrieb Jonathan Cameron: > On 04/07/16 13:23, Martin Kepplinger wrote: >> Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil: >>> Removed unwanted return statements from the function >>> mma8452_set_freefall_mode. >> >> You could've

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

Am 2016-07-08 um 23:08 schrieb Dmitry Torokhov: > On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: >> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: >>> Hi Martin, >>> >>> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: &

Re: [PATCH v1] drivers:iio:accel:mma8452: added cleanup provision in case of failure.

ffer_cleanup & iio_trigger_cleanup in this case. Thanks for your review, nice catch! Looks good to me. You just could have said "Don't leak allocated buffer on error during probe().", but oh well :) > > Signed-off-by: Bijosh Thykkoottathil <bijos...@hotmail.com>

Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements

Thykkoottathil <bijos...@hotmail.com> Reviewed-by: Martin Kepplinger <mart...@posteo.de> > --- > drivers/iio/accel/mma8452.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index e225d

[PATCH] Documentation: input: fix path to input code definitions

Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/input/input.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/input/input.txt b/Documentation/input/input.txt index 0acfddb..7ebce10 100644 --- a/Documentation/input/input.txt

[PATCH] input: pegasus_notetaker - directly include workqueue header

According to the kernel's guidelines, let's directly include the workqueue functions we use. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- I don't know if it's worth it, but I should have included this according to the guidelines :) drivers/input/tablet/pegasus_notetaker.c |

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-11-06 um 12:43 schrieb Martin Kepplinger: > Am 2016-11-06 um 12:21 schrieb Thorsten Leemhuis: >> On 01.11.2016 12:47, Jani Nikula wrote: >>> On Tue, 01 Nov 2016, Martin Kepplinger <mart...@posteo.de> wrote: >>>> I'll come up with a nouveau

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-11-06 um 12:21 schrieb Thorsten Leemhuis: > On 01.11.2016 12:47, Jani Nikula wrote: >> On Tue, 01 Nov 2016, Martin Kepplinger <mart...@posteo.de> wrote: >>> I'll come up with a nouveau system example and it was quite easy to bisect. >>> To quote th

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-11-07 um 09:24 schrieb Jani Nikula: > On Sun, 06 Nov 2016, Martin Kepplinger <mart...@posteo.de> wrote: >> I did not file a bug in bugzilla yet. I haven't given up that we can fix >> this here before the release. I've ignored it the last few days though. > > You

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-11-07 um 17:01 schrieb Martin Steigerwald: > Hello. > > Am Montag, 7. November 2016, 16:34:35 CET schrieb Martin Kepplinger: >> Am 2016-11-07 um 09:24 schrieb Jani Nikula: >>> On Sun, 06 Nov 2016, Martin Kepplinger <mart...@posteo.de> wrote: >>>&g

[PATCH] CREDITS: update credit information for Martin Kepplinger

Content and employer changed. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- CREDITS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CREDITS b/CREDITS index 513aaa3..8373676 100644 --- a/CREDITS +++ b/CREDITS @@ -1864,10 +1864,11 @@ S: The Netherland

[PATCH] iio: accel: mma8452: define unsigned return values where appropriate

smatch warned: sval_binop_signed: invalid divide LLONG_MIN/-1 and this fixes it. It's actually good to have, in order to avoid accidental checking for negative return values here. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/iio/accel/mma8452.c | 4 ++--

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-11-07 um 18:36 schrieb Jani Nikula: > On Mon, 07 Nov 2016, Martin Kepplinger <mart...@posteo.de> wrote: >> Am 2016-11-07 um 17:01 schrieb Martin Steigerwald: >>> Hello. >>> >>> Am Montag, 7. November 2016, 16:34:35 CET schrieb Martin Kep

Re: [BUG][REGRESSION] mangled display since -rc1

Am 2016-10-31 um 16:21 schrieb Joerg Roedel: > On Mon, Oct 31, 2016 at 11:40:06AM +0100, Martin Kepplinger wrote: >> In case the screenshot doesn't make it to you, here it is: >> https://postimg.org/image/5wl2wemt9/ > > Can you please send a boot-dmesg and 'lspci -v'? We ne

Re: [BUG][REGRESSION] mangled display since -rc1

Am 31. Oktober 2016 22:54:54 MEZ, schrieb Joerg Roedel <jroe...@suse.de>: >On Mon, Oct 31, 2016 at 09:44:51PM +0100, Martin Kepplinger wrote: >> This is one machine booting a bad kernel. I could provide another >> example later this week. > >You have an Intel system

Re: [BUG][REGRESSION] mangled display since -rc1

In case the screenshot doesn't make it to you, here it is: https://postimg.org/image/5wl2wemt9/ Am 31.10.2016 11:36 schrieb Martin Kepplinger: so guys, I can't believe that nobody hits this: Since -rc1 Nautilus' list of elements or Firefox' website window or just photos in eog (probably among

[BUG][REGRESSION] mangled display since -rc1

so guys, I can't believe that nobody hits this: Since -rc1 Nautilus' list of elements or Firefox' website window or just photos in eog (probably among many more things) is mangled. Please have a look at the screenshot of nautilus. This is the same on a i3 laptop with intel graphics and a i7

[BUG][REGRESSION] i915 gpu hangs under load

Hi I know something similar is here: https://bugs.freedesktop.org/show_bug.cgi?id=100110 too. But this is rc3 and my machine is totally *not usable*. Let me be annoying :) I hope I can help: Since rc1 I get gpu hangs and resets under load: This is almost certainly a kernel issue. 4.10 is

[PATCH] input: touchscreen: sur40: fix bad endianness handling in sur40_poll

sparse says: sur40.c:372:40: warning: restricted __le32 degrades to integer the header's data is __le32 so we need to convert it before comparing. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load

Am 2. April 2017 13:50:26 MESZ schrieb Thorsten Leemhuis <regressi...@leemhuis.info>: >Lo! On 22.03.2017 11:36, Jani Nikula wrote: >> On Wed, 22 Mar 2017, Martin Kepplinger <mart...@posteo.de> wrote: >>> I know something similar is here: >>> https://bugs

[PATCH] mailmap: add Martin Kepplinger's email

Set the partly deprecated companies' email addresses as alias for the personal one. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index de0fc5b..d2aeb14 100644 --- a/.mailmap

[PATCH] input: misc: yealink: define packet offset __be16 instead of u16

sparse says warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [usertype] offset got restricted __be16 [usertype] for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the first place shouldn't hurt. Signed-off-by: Martin

[PATCH] mfd: menelaus: remove obsolete local_irq_disable() and local_irq_enable()

Since commit e6229bec25be ("rtc: make rtc_update_irq callable with irqs enabled") rtc_update_irq() is callable with irqs enabled, see the rtc drivers. So update this accordingly. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> Cc: Henri Roosen <henri.r

Re: [PATCH 0/5] Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load

Am 07.04.2017 01:23 schrieb Andrea Arcangeli: I'm also getting kernel hangs every couple of days. For me it's still not fixed here in 4.11-rc5. It's hard to reproduce, the best reproducer is to build lineageos 14.1 on host while running LTP in a guest to stress the guest VM. Initially I thought

[PATCH v2] input: misc: yealink: define packet offset __be16 instead of u16

sparse says warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [usertype] offset got restricted __be16 [usertype] for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the first place shouldn't hurt. Signed-off-by: Martin

[PATCH 2/3] Documentation: devicetree: bindings: add bindings doc for ar1021 driver

Add a simple binding document highlighting the supported devices and I2C bus address. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- .../devicetree/bindings/input/touchscreen/ar1021.txt | 16 1 file changed, 16 insertions(+) create mode

[PATCH 1/3] input: touchscreen: ar1021_i2c: add support for AR1020

specific things in the future. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- drivers/input/touchscreen/Kconfig | 4 ++-- drivers/input/touchscreen/ar1021_i2c.c | 13 ++--- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 3/3] input: touchscreen: ar1021_i2c: coding style fixes

Use the common kernel coding style and corrently align parameters with open parenthesis. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- drivers/input/touchscreen/ar1021_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touch

Re: [PATCH 1/3] input: touchscreen: ar1021_i2c: add support for AR1020

On 2017-04-12 17:40, Dmitry Torokhov wrote: > Hi Martin, > > On Tue, Apr 11, 2017 at 12:27:57PM +0200, Martin Kepplinger wrote: >> ar1021_i2c simply also supports the ar1020 device we use. This is tested. >> They also share the same datasheet: >> >>http

[PATCH v2] input: touchscreen: ar1021_i2c: highlight support for AR1020

-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- revision history v2: leave compatible string untouched. only add description. v1: initial idea. drivers/input/touchscreen/Kconfig | 4 ++-- drivers/input/touchscreen/ar1021_i2c.c | 4 ++-- 2 files chan

Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger

1_i2c", ar1021); > if (error) { > dev_err(>dev, > makes sense, if users have to expect that this default can change. it works. Tested-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> martin

[PATCH v2] dt-bindings: input: add bindings document for ar1021_i2c driver

Add a simple binding document describing the supported devices and the I2C bus address. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- revision history v2: fixed subject line and binding; thanks Rob Herring v1: initial idea .../devicetree/bi

Re: [PATCH v2] Input: ar1021-i2c - fix too long name in driver's device table

r uses capitals, and > the manufacturer name is normally not included, except in very rare cases > of incompatible name collisions. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211 > Fixes: dd4cae8bf166 ("Input: Add Microchip AR1021 i2c touchscreen") > Signe

[PATCH 2/4] Documentation: input: fix path to input code defnitions

The UAPI header split failed to update the documentation in input-programming.txt; fix things accordingly. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/input/input-programming.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documen

[PATCH 4/4] Documentation: input: fix path to struct ff_effect's definition

The UAPI header split failed to update the documentation here; fix things accordingly. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/input/ff.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/input/ff.txt b/Documentation

[PATCH 1/4] Documentation: hid: fix path to input bus definitions

The UAPI header split failed to update the documentation here; fix things accordingly. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/hid/hidraw.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hid/hidraw.txt b/Documentati

[PATCH 3/4] Documentation: admin-guide: fix path to input key definitions

The UAPI header split failed to update the documentation here; fix things accordingly. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/admin-guide/sysrq.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/sysrq.

Re: [PATCH] mfd: menelaus: remove obsolete local_irq_disable() and local_irq_enable()

On 2017-04-12 22:15, Aaro Koskinen wrote: > On Mon, Apr 10, 2017 at 11:37:18AM +0200, Martin Kepplinger wrote: >> Since >> >> commit e6229bec25be ("rtc: make rtc_update_irq callable with irqs enabled") >> >> rtc_update_irq() is callable with irqs

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

.ev_src_ze = MMA8452_TRANSIENT_SRC_ZTRANSE, >- .ev_ths = MMA8452_TRANSIENT_THS, >- .ev_ths_mask = MMA8452_TRANSIENT_THS_MASK, >- .ev_count = MMA8452_TRANSIENT_COUNT, > }, > [mma8652] = { > .chip_id = MMA8652_DEVICE_ID, > .channels = mma8652_channels, > .num_channels = ARRAY_SIZE(mma8652_channels), > .mma_scales = { {0, 9577}, {0, 19154}, {0, 38307} }, >- .ev_cfg = MMA8452_FF_MT_CFG, >- .ev_cfg_ele = MMA8452_FF_MT_CFG_ELE, >- .ev_cfg_chan_shift = 3, >- .ev_src = MMA8452_FF_MT_SRC, >- .ev_src_xe = MMA8452_FF_MT_SRC_XHE, >- .ev_src_ye = MMA8452_FF_MT_SRC_YHE, >- .ev_src_ze = MMA8452_FF_MT_SRC_ZHE, >- .ev_ths = MMA8452_FF_MT_THS, >- .ev_ths_mask = MMA8452_FF_MT_THS_MASK, >- .ev_count = MMA8452_FF_MT_COUNT, > }, > [mma8653] = { > .chip_id = MMA8653_DEVICE_ID, > .channels = mma8653_channels, > .num_channels = ARRAY_SIZE(mma8653_channels), > .mma_scales = { {0, 38307}, {0, 76614}, {0, 153228} }, >- .ev_cfg = MMA8452_FF_MT_CFG, >- .ev_cfg_ele = MMA8452_FF_MT_CFG_ELE, >- .ev_cfg_chan_shift = 3, >- .ev_src = MMA8452_FF_MT_SRC, >- .ev_src_xe = MMA8452_FF_MT_SRC_XHE, >- .ev_src_ye = MMA8452_FF_MT_SRC_YHE, >- .ev_src_ze = MMA8452_FF_MT_SRC_ZHE, >- .ev_ths = MMA8452_FF_MT_THS, >- .ev_ths_mask = MMA8452_FF_MT_THS_MASK, >- .ev_count = MMA8452_FF_MT_COUNT, > }, > [fxls8471] = { > .chip_id = FXLS8471_DEVICE_ID, > .channels = mma8451_channels, > .num_channels = ARRAY_SIZE(mma8451_channels), > .mma_scales = { {0, 2394}, {0, 4788}, {0, 9577} }, >- .ev_cfg = MMA8452_TRANSIENT_CFG, >- .ev_cfg_ele = MMA8452_TRANSIENT_CFG_ELE, >- .ev_cfg_chan_shift = 1, >- .ev_src = MMA8452_TRANSIENT_SRC, >- .ev_src_xe = MMA8452_TRANSIENT_SRC_XTRANSE, >- .ev_src_ye = MMA8452_TRANSIENT_SRC_YTRANSE, >- .ev_src_ze = MMA8452_TRANSIENT_SRC_ZTRANSE, >- .ev_ths = MMA8452_TRANSIENT_THS, >- .ev_ths_mask = MMA8452_TRANSIENT_THS_MASK, >- .ev_count = MMA8452_TRANSIENT_COUNT, > }, > }; > -- Martin Kepplinger http://martinkepplinger.com sent from mobile

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

val |= BIT(idx_y + chip->ev_cfg_chan_shift); >>> - val |= BIT(idx_z + chip->ev_cfg_chan_shift); >>> + val |= BIT(idx_x + MMA8452_FF_MT_CHAN_SHIFT); >>> + val |= BIT(idx_y + MMA8452_FF_MT_CHAN_SHIFT); >>> + val |= BIT(idx_z + MMA8452_FF_MT_CHAN_SHIFT); >>> val &= ~MMA8452_FF_MT_CFG_OAE; >>> } else { >>> - val &= ~BIT(idx_x + chip->ev_cfg_chan_shift); >>> - val &= ~BIT(idx_y + chip->ev_cfg_chan_shift); >>> - val &= ~BIT(idx_z + chip->ev_cfg_chan_shift); >>> + val &= ~BIT(idx_x + MMA8452_FF_MT_CHAN_SHIFT); >>> + val &= ~BIT(idx_y + MMA8452_FF_MT_CHAN_SHIFT); >>> + val &= ~BIT(idx_z + MMA8452_FF_MT_CHAN_SHIFT); >>> val |= MMA8452_FF_MT_CFG_OAE; >>> } >>> >>> - return mma8452_change_config(data, chip->ev_cfg, val); >>> + return mma8452_change_config(data, MMA8452_FF_MT_CFG, val); >>> } >>> >>> static int mma8452_set_hp_filter_frequency(struct mma8452_data >*data, >>> @@ -740,6 +733,39 @@ static int mma8452_write_raw(struct iio_dev >*indio_dev, >>> return ret; >>> } >>> >>> +static int mma8452_get_event_regs(const struct iio_chan_spec *chan, >>> + enum iio_event_direction dir, >>> + struct mma8452_event_regs *ev_regs >>> + ) >>> +{ >>> + if (!chan) >>> + return -EINVAL; >>> + switch (chan->type) { >>> + case IIO_ACCEL: >>> + switch (dir) { >>> + case IIO_EV_DIR_FALLING: >>> + ev_regs->ev_cfg = MMA8452_FF_MT_CFG; >>> + ev_regs->ev_src = MMA8452_FF_MT_SRC; >>> + ev_regs->ev_ths = MMA8452_FF_MT_THS; >>> + ev_regs->ev_ths_mask = MMA8452_FF_MT_THS_MASK; >>> + ev_regs->ev_count = MMA8452_FF_MT_COUNT; >>> + break; >>> + case IIO_EV_DIR_RISING: >>> + ev_regs->ev_cfg = MMA8452_TRANSIENT_CFG; >>> + ev_regs->ev_src = MMA8452_TRANSIENT_SRC; >>> + ev_regs->ev_ths = MMA8452_TRANSIENT_THS; >> >> ev_ths_mask is not set here >> >>> + ev_regs->ev_count = MMA8452_TRANSIENT_COUNT; >>> + break; >>> + default: >>> + return -EINVAL; >>> + } >>> + break; >>> + default: >>> + return -EINVAL; >>> + } >>> + return 0; >> could replace 'breaks' with return 0 to save some lines and simplify >> control flow >> >>> +} >>> + >>> static int mma8452_read_thresh(struct iio_dev *indio_dev, >>>const struct iio_chan_spec *chan, >>>enum iio_event_type type, >>> @@ -749,21 +775,23 @@ static int mma8452_read_thresh(struct iio_dev >*indio_dev, >>> { >>> struct mma8452_data *data = iio_priv(indio_dev); >>> int ret, us, power_mode; >>> + struct mma8452_event_regs ev_regs; >>> >>> + ret = mma8452_get_event_regs(chan, dir, _regs); >>> + if (ret) >>> + return ret; >>> switch (info) { >>> case IIO_EV_INFO_VALUE: >>> - ret = i2c_smbus_read_byte_data(data->client, >>> - data->chip_info->ev_ths); >>> + ret = i2c_smbus_read_byte_data(data->client, ev_regs.ev_ths); >>> if (ret < 0) >>> return ret; >>> >>> - *val = ret & data->chip_info->ev_ths_mask; >>> + *val = ret & ev_regs.ev_ths_mask; >>> >>> return IIO_VAL_INT; >>> >>> case IIO_EV_INFO_PERIOD: >>> - ret = i2c_smbus_read_byte_data(data->client, >>> - data->chip_info->ev_count); >>> + ret = i2c_smbus_read_byte_data(data->client, ev_regs.ev_count); >>> if (ret < 0) >>> return ret; >>> >>> @@ -809,14 +837,18 @@ static int mma8452_write_thresh(struct iio_dev >*indio_dev, >>> { >>> struct mma8452_data *data = iio_priv(indio_dev); >>> int ret, reg, steps; >>> + struct mma8452_event_regs ev_regs; >>> + >>> + ret = mma8452_get_event_regs(chan, dir, _regs); >>> + if (ret) >>> + return ret; >>> >>> switch (info) { >>> case IIO_EV_INFO_VALUE: >>> - if (val < 0 || val > MMA8452_TRANSIENT_THS_MASK) >>> + if (val < 0 || val > ev_regs.ev_ths_mask) >>> return -EINVAL; >>> >>> - return mma8452_change_config(data, data->chip_info->ev_ths, >>> -val); >>> + return mma8452_change_config(data, ev_regs.ev_ths, val); >>> >>> case IIO_EV_INFO_PERIOD: >>> ret = mma8452_get_power_mode(data); >>> @@ -830,8 +862,7 @@ static int mma8452_write_thresh(struct iio_dev >*indio_dev, >>> if (steps < 0 || steps > 0xff) >>> return -EINVAL; >>> >>> - return mma8452_change_config(data, data->chip_info->ev_count, >>> -steps); >>> + return mma8452_change_config(data, ev_regs.ev_count, steps); >>> >>> case IIO_EV_INFO_HIGH_PASS_FILTER_3DB: >>> reg = i2c_smbus_read_byte_data(data->client, >>> @@ -861,23 +892,23 @@ static int mma8452_read_event_config(struct >iio_dev *indio_dev, >>> enum iio_event_direction dir) >>> { >>> struct mma8452_data *data = iio_priv(indio_dev); >>> - const struct mma_chip_info *chip = data->chip_info; >>> int ret; >>> >>> - switch (dir) { >>> - case IIO_EV_DIR_FALLING: >>> - return mma8452_freefall_mode_enabled(data); >>> - case IIO_EV_DIR_RISING: >>> - if (mma8452_freefall_mode_enabled(data)) >>> - return 0; >>> + switch (chan->type) { >>> + case IIO_ACCEL: >> this adds a check for chan-type == IIO_ACCESS, so strictly this would >be >> an unrelated change... >> >>> + switch (dir) { >>> + case IIO_EV_DIR_FALLING: >>> + return mma8452_freefall_mode_enabled(data); >>> + case IIO_EV_DIR_RISING: >>> + ret = i2c_smbus_read_byte_data(data->client, >MMA8452_TRANSIENT_CFG); >>> + if (ret < 0) >>> + return ret; >>> >>> - ret = i2c_smbus_read_byte_data(data->client, >>> - data->chip_info->ev_cfg); >>> - if (ret < 0) >>> - return ret; >>> + return !!(ret & >>> MMA8452_TRANSIENT_CFG_CHAN(chan->scan_index)); >>> >>> - return !!(ret & BIT(chan->scan_index + >>> - chip->ev_cfg_chan_shift)); >>> + default: >>> + return -EINVAL; >>> + } >>> default: >>> return -EINVAL; >>> } >>> @@ -890,39 +921,33 @@ static int mma8452_write_event_config(struct >iio_dev *indio_dev, >>> int state) >>> { >>> struct mma8452_data *data = iio_priv(indio_dev); >>> - const struct mma_chip_info *chip = data->chip_info; >>> int val, ret; >>> >>> ret = mma8452_set_runtime_pm_state(data->client, state); >>> if (ret) >>> retu -- Martin Kepplinger http://martinkepplinger.com sent from mobile

[PATCH 1/2] README: revise the top level readme texts

re...". Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- README | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/README b/README index b2ba4aaa3a71..b281213e7c6f 100644 --- a/README +++ b/README @@ -1,17 +1,27 @@ Linux kernel

[PATCH 2/2] Documentation: admin-guide: remove redundant first paragraph of README.rst

eader, and start with telling what Linux is. This won't come as a surprise to the reader. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Documentation/admin-guide/README.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/Documentation/admin-guide/README.rst b/Documenta

[PATCH] staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/staging/vboxvideo/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig index a52746

[PATCH v2] staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text. Most notably, "to builtin this module" becomes "to build this driver built-in to the kernel". Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Thanks Dan. I actually also had the feeling that even though it's

[PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text. Most notably, "to builtin this module" becomes "to build this driver built-in to the kernel". Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- revision history v3: Avoid a repetition of "t

[PATCH 1/2] input: touchscreen: ar1021_i2c: enable touch mode during open

The device could as well be in command mode, in which this driver cannot handle the device. When opening the device, let's make sure the device will be in the mode we expect it to be for this driver. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- drivers/input/touch

[PATCH 2/2] input: touchscreen: ar1021_i2c: replace magic number with definition

We now have a few of this device's definitions. Let's avoid magic numbers and use them. Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com> --- drivers/input/touchscreen/ar1021_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touch

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

On 2017-08-01 05:08, Harinath Nampally wrote: >> Thanks for doing that work. I have had it on my list for a long time >> and you seem to fix it. Although I'd happily review and possibly test >> it, unfortunately I can't do so before the week of August 21st. >> >> If this might go in quick, nothing

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

s on only this one issue of enabling freefall (FF_MT registers) for the devices that currently use transient registers. thanks If falling: switch to ff_mt in any case. (fixing freefall for the transient-devices) ok sure. Thanks, Hari On 08/21/2017 04:47 AM, Martin Kepplinger wrote: If r

[PATCH] media: dvb-frontends: drx39xyj: remove obsolete sign extend macros

DRX_S9TOS16 and DRX_S24TODRXFREQ are simply not used. Furthermore, sign_extend32() should be used for sign extension. (Also, the comment describing DRX_S24TODRXFREQ was wrong). So remove these macros. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/media/dvb-frontends/dr

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

On 2017-05-08 18:11, Rob Herring wrote: > On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote: >> The datasheet and application note does not mention an allowed range for >> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set >> lower values

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

On 2017-05-11 10:32, Martin Kepplinger wrote: > On 2017-05-08 18:11, Rob Herring wrote: >> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote: >>> The datasheet and application note does not mention an allowed range for >>> the M09_REGISTER_THRESHOLD para

[PATCH 2/2 v2] input: touchscreen: ar1021_i2c: use BIT to check for a bit

The MSB for the first byte of touch data transmission is always 1. Make it a little more obvious we're testing this bit by using BIT(7). Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- I'd still use the definition :) but otherwise I'd write the following. It really doesn't matter

[PATCH] README: Find more sane first words we have to say about Linux

ds at least. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- please ignore if too irrelevant, but I personally would put this in 4.11, if still possible, and rewrite the REAME for 4.12 to be even more friendly. thanks martin README | 7 --- 1 file c

[PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter

The recent change commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open") also removed the ABS_X input code to be set. This must have been done by mistake; so we bring back the X axis! Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Dmitry, this m

Re: [PATCH] README: Find more sane first words we have to say about Linux

Am 2017-05-01 um 17:24 schrieb Jonathan Corbet: > On Sun, 30 Apr 2017 22:11:35 +0200 > Martin Kepplinger <mart...@posteo.de> wrote: > >> Imagine you're completely new to Linux, just real quick, ok? What do you do? >> Wouldn't having a look at README be under first if

[PATCH] fs: namei: use __pure modifier as declared in headers

sparse complains about different modifiers here. The function definitions should simply use their declarations' modifiers. We also shrink the text width to our 80 characters maximum while we are at it. This makes it sparse- and checkpatch-clean. Signed-off-by: Martin Kepplinger <m

[PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

for thresholds, and set the lower limit to 0. The documentation is updated accordingly. Signed-off-by: Schoefegger Stefan <stefan.schoefeg...@ginzinger.com> Signed-off-by: Manfred Schlaegl <manfred.schla...@ginzinger.com> Signed-off-by: Martin Kepplinger <martin.kepplin...@ginzinger.com>

[PATCH] tools: firewire: nosy-dump: fix a resource leak in main()

If option_input and option_output is true two files are opened consecutively. In case the second fopen() fails, let's fclose() the first one before returning early. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- tools/firewire/nosy-dump.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] tools: objtool: fix memory leak in elf_create_rela_section()

Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- tools/objtool/elf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c

[PATCH] tools: perf: fix leaking rec_argv in error cases

Let's free the allocated rec_argv in case we return early, in order to avoid leaking memory. This adds free() at a few very similar places across the tree where it was missing. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- tools/perf/builtin-c2c.c | 1 + tools/perf/b

[PATCH] tools: hv: hv_kvp_daemon: fix usage of realloc()

realloc() returns NULL in case it fails. Since we don't save the pointer in question elsewhere, we leak memory by assigning NULL to the original memory in the heap. realloc() doesn't free memory in case of failure, so let's do it manually. Signed-off-by: Martin Kepplinger <mart...@posteo

[PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section()

Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- I should've allocated some brain resources before freeing some computer's. tools/objtool/elf.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

> > Signed-off-by: Harinath Nampally <harinath...@gmail.com> > --- Alright, I didn't test it but I kind of like it now. The one minor naming issue I had pointed out before is mentioned below. But if that's no issue for Jon: Reviewed-by: Martin Kepplinger <mart...@posteo.

Re: [PATCH] iio: adc: dln2-adc: initialize local struct before using it

-ci/linux/commits/Martin-Kepplinger/iio-adc-dln2-adc-initialize-local-struct-before-using-it/20170912-064250 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

are >> >> pretty much similar as they >> >> both raise interrupt flag when the acceleration magnitude rises >above >> >> the threshold. >> >> Only difference is transient event has its own event config >registers >> >> with High pass filter. >> >> If HPF bypassed using config register transient event acts like >motion >> >> detection event. >> > >> >> >> >> That was my understanding but please correct me if I am wrong. >> > >> > I agree with your understanding. It's a rising threshold, just >that the input >> > will only reflect high frequency changes in the signal. >> > >> >> >> >> > Only freefall mode needs one fix: remembering to which set of >registers to fall back when >> >> > disabling it. >> >> >> >> I don't quite understand what you mean by 'to fall back when >disabling >> >> it'. Please elaborate. I would >> >> appreciate if you could suggest your logic in the form of >pseudo-code. >> >> Thanks for your time >> >> >> > ... -- Martin Kepplinger http://martinkepplinger.com sent from mobile

[PATCH] iio: adc: dln2-adc: initialize local struct before using it

struct data is defined and declared locally. Initiliazation has to be done manually, so let's add that. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- This is more of a question actually! Did you have in mind that data is not initialized here? If so, please drop this

Re: [PATCH 0/3] Refactor event related code

Am 25.09.2017 12:16 schrieb harinath Nampally: First, this is at least v2 of this series. Second, it still seems to include a 4th unrelated patch. ok I was not sure whether to make it v2 as the change was to only cover letter and no code changes. But now I know, will send v3 of this series.

Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

On 2017-09-30 19:59, Jonathan Cameron wrote: > On Wed, 27 Sep 2017 08:52:54 +0200 > Martin Kepplinger <mart...@posteo.de> wrote: > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: >>> Improves code readability, no impact on functionality. >>> >>

Re: [PATCH v3 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> Acked-by: Martin Kepplinger <mart...@posteo.de>

Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Am 25.09.2017 12:40 schrieb Harinath Nampally: Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally Please make the headline shorter and put some of it in the git commit message. (And please just resend it "--in-reply-to" this

Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Am 25.09.2017 12:40 schrieb Harinath Nampally: Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- I'd prefer a shorter subject line here too, see patch 2/3.

Re: [PATCH 0/3] Refactor event related code

Am 25.09.2017 12:07 schrieb Harinath Nampally: Rename some struct names and function names to improve code readability. Harinath Nampally (3): iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. iio: accel: mma8452: Rename time step

Re: [PATCH 0/3] This patchset refactors event related functions

Am 25.09.2017 05:15 schrieb Harinath Nampally: Harinath Nampally (3): Following 2 patches are for refactor: iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events. iio: accel: mma8452: Rename read/write event value callbacks

Re: [PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

Am 25.09.2017 05:15 schrieb Harinath Nampally: This patch adds following changes to support tap feature: - defines pulse event related registers - enables and handles single pulse interrupt for fxls8471 - handles IIO_EV_DIR_EITHER in read/write callbacks because event direction for pulse is

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

Thanks. I may have missed something, but I'm concerned about only one thing: devices without transient event registers. See my comments below. Am 20.08.2017 18:06 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

Am 28.08.2017 02:23 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can be

[PATCH] samples: replace outdated permission statement with SPDX identifiers

This replaces license permission statements that include a wrong postal address of the FSF with only SPDX license identifiers; in the samples directory. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- I'll fold this in, in the thread here. I guess this change is what Greg had i

Re: [PATCH] samples: replace FSF address with web source in license notices

Am 15.11.2017 07:29 schrieb Greg KH: On Tue, Nov 14, 2017 at 10:50:37AM +0100, Martin Kepplinger wrote: A few years ago the FSF moved and "59 Temple Place" is wrong. Having this still in our source files feels old and unmaintained. Let's take the license statement serious and n

Re: [PATCH] media: coda: fix comparision of decoded frames' indexes

Am 22.11.2017 14:43 schrieb Philipp Zabel: Hi Martin, On Fri, 2017-11-17 at 15:30 +0100, Martin Kepplinger wrote: At this point the driver looks the currently decoded frame's index and compares is to VPU-specific state values. Directly before this if and else statements the indexes are read

[PATCH v2] input: pegasus_notetaker: add license information

This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I already see a lot of SPDX tags using /**/ comments, I'll use that too. I

[PATCH v3] input: pegasus_notetaker: add license information

This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- ok. thanks for the license-cleanup efforts. I think it's important. martin patch revisions --- v3: use // comments v

[PATCH] media: coda: fix comparision of decoded frames' indexes

int! During these index checks, the current values apply, so fix this by taking display_idx instead of ctx->display_idx. ctx->display_idx is updated later in the same function. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- Please review this thoroughly, but in case

Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers

On 2017-11-18 01:13, Jonathan Corbet wrote: > On Sat, 18 Nov 2017 00:43:46 +0100 > Martin Kepplinger <mart...@posteo.de> wrote: > >> But Greg, people are listening to you. Please don't give advice in >> directions that are not clearly correct for Linux. You know you

[PATCH] input: pegasus_notetaker: add license information

This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger <mart...@posteo.de> --- drivers/input/tablet/pegasus_notetaker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/

[PATCH v2] iio: mma8452: replace license description with SPDX specifier

This replaces the custom license information text with the appropriate SPDX identifier. While the information here stays the same, it is easier to read. Signed-off-by: Martin Kepplinger <mart...@posteo.de> Acked-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- Sorry I had forg

Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers

On 2017-11-18 11:17, Greg KH wrote: > On Fri, Nov 17, 2017 at 03:53:53PM -0700, Jonathan Corbet wrote: >> On Thu, 16 Nov 2017 12:41:10 +0100 >> Greg KH wrote: >> I'll fold this in, in the thread here. I guess this change is what Greg had in mind? Or would you

<    1   2   3   4   5   6   7   8   9   10   >