Re: [PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability

2017-11-05 Thread Martin Kepplinger
ally Makes sense to me. Acked-by: Martin Kepplinger Hey Harinath, I think it'd be great to have the "power_mode" iio ABI interface for mma8452 too, and I just found an old patch pf mine for this. If you say you could test it and check for correct API usage and ABI provisioning in sy

Re: [PATCH v4 1/2] iio: accel: mma8452: Rename a struct for code readibility

2017-11-05 Thread Martin Kepplinger
On 2017-11-05 19:00, Harinath Nampally wrote: > Rename time step look up struct to generic name > as the values in the look table are same for all > the other events like pulse, transient etc. > > Signed-off-by: Harinath Nampally Acked-by: Martin Kepplinger

[PATCH] iio: mma8452: add power_mode sysfs configuration

2017-11-05 Thread Martin Kepplinger
This adds the power_mode sysfs interface to the device as documented in sysfs-bus-iio. --- Note that I explicitely don't sign off on this. This is a starting point for anybody who can test it and check for correct API usage, and ABI correctness, as documented in

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

2017-11-10 Thread Martin Kepplinger
On 2017-11-09 04:12, Harinath Nampally wrote: > This patch adds following related changes: > - defines pulse event related registers > - enables and handles single pulse interrupt for fxls8471 > - handles IIO_EV_DIR_EITHER in read/write callbacks (because > event direction for pulse is either

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

2017-11-12 Thread Martin Kepplinger
On 2017-11-11 01:33, Jonathan Cameron wrote: > On Mon, 6 Nov 2017 08:19:58 +0100 > Martin Kepplinger wrote: > >> This adds the power_mode sysfs interface to the device as documented in >> sysfs-bus-iio. >> >> --- >> >> Note that I explicitely don

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

2017-11-13 Thread Martin Kepplinger
Am 14.11.2017 05:36 schrieb harinath Nampally: > This patch adds following related changes: > - defines pulse event related registers > - enables and handles single pulse interrupt for fxls8471 > - handles IIO_EV_DIR_EITHER in read/write callbacks (because > event direction for pulse is either

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

2017-11-13 Thread Martin Kepplinger
uld've looked more closely. oversampling is there and seems to work. No need to blow up this driver or let alone extend an ABI now. Let's drop this patch. thanks martin On Sun, Nov 12, 2017 at 7:28 AM, Martin Kepplinger wrote: On 2017-11-11 01:33, Jonathan Cam

[PATCH] kernel: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
A few years ago the FSF moved and "59 Temple Place" is wrong. Having this still in our source files feels old and unmaintained. As https://www.gnu.org/licenses/gpl-howto.html suggests, we replace the postal address with "<http://www.gnu.org/licenses/>". Signed

[PATCH] crypto: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>". Signed-off-by: Martin Kepplinger --- crypto/ablk_helper.c | 4 +--- crypto/camellia_generic.c | 3 +-- crypto/cast5_generic.c| 3 +-- crypto/cast6_generic.c| 3 +-- crypto/simd.c | 4 +--- crypto/twofish_common.c | 5 ++---

[PATCH] init: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>". Signed-off-by: Martin Kepplinger --- init/noinitramfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/init/noinitramfs.c b/init/noinitramfs.c index 267739d85179..3ee9e3dbfbc4 100644 --- a/init/noinitramfs.c +++ b/init/no

[PATCH] lib: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>" in the lib directory. Signed-off-by: Martin Kepplinger --- This is an attempt to sneak this in for the lib subdirectory in one go. If you would rather have the changes individually go to the relevant people, please just say so. thanks

[PATCH] mm: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>" in the mm directory. Signed-off-by: Martin Kepplinger --- mm/kmemleak-test.c | 3 +-- mm/kmemleak.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/kmemleak-test.c b/mm/kmemleak-test.c index dd3c23a801b1..9a13ad2c0cc

[PATCH] samples: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>" in the samples directory. Signed-off-by: Martin Kepplinger --- samples/auxdisplay/cfag12864b-example.c | 3 +-- samples/configfs/configfs_sample.c | 6 ++ samples/connector/cn_test.c | 3 +-- samples/connector/ucon.c

Re: [PATCH] mm: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
Am 14.11.2017 10:49 schrieb Michal Hocko: On Tue 14-11-17 10:44:38, Martin Kepplinger wrote: A few years ago the FSF moved and "59 Temple Place" is wrong. Having this still in our source files feels old and unmaintained. Let's take the license statement serious and not con

[PATCH] scripts: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>" in the scripts directory. Signed-off-by: Martin Kepplinger --- scripts/dtc/checks.c| 4 +--- scripts/dtc/data.c | 4 +--- scripts/dtc/dtc-lexer.l | 4 +--- scripts/dtc/dtc-lexer.lex.c_shipped | 4 +---

[PATCH] security: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
ith "<http://www.gnu.org/licenses/>" in the security directory. Signed-off-by: Martin Kepplinger --- security/selinux/include/netlabel.h | 3 +-- security/selinux/netlabel.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/security/selinux/include/netl

Re: [PATCH] mm: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
Am 14.11.2017 11:02 schrieb Michal Hocko: On Tue 14-11-17 10:55:35, Martin Kepplinger wrote: Am 14.11.2017 10:49 schrieb Michal Hocko: > On Tue 14-11-17 10:44:38, Martin Kepplinger wrote: > > A few years ago the FSF moved and "59 Temple Place" is wrong. Having > > thi

[PATCH] media: coda: Fix definition of CODA_STD_MJPG

2017-11-08 Thread Martin Kepplinger
in the future. Signed-off-by: Martin Kepplinger --- drivers/media/platform/coda/coda_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h index 38df5fd9a2fa..8d726faaf86e 100644 --- a/drivers/media

[PATCH] media: coda: remove definition of CODA_STD_MJPG

2017-11-08 Thread Martin Kepplinger
be needed for i.MX6. So avoid confusion and remove this definition. Signed-off-by: Martin Kepplinger --- drivers/media/platform/coda/coda_regs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h index 38df5fd9a2fa

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

2017-11-08 Thread Martin Kepplinger
Am 09.11.2017 04:19 schrieb harinath Nampally: Hi Martin, Thanks for publishing the patch. I will work on it, but unfortunately I can't promise anything before 11/27. perfectly fine, this patch has been lying around here for at least a year, so there's no rush.

[PATCH] media: coda: fix comparision of decoded frames' indexes

2017-11-17 Thread Martin Kepplinger
int! During these index checks, the current values apply, so fix this by taking display_idx instead of ctx->display_idx. ctx->display_idx is updated later in the same function. Signed-off-by: Martin Kepplinger --- Please review this thoroughly, but in case I am wrong here, this is at least ver

Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers

2017-11-17 Thread Martin Kepplinger
On 2017-11-17 23:53, Jonathan Corbet wrote: > On Thu, 16 Nov 2017 12:41:10 +0100 > Greg KH wrote: > >>> I'll fold this in, in the thread here. I guess this change is what Greg >>> had in mind? Or would you prefer having including SPDX and removing >>> permission statement seperately? >> >> I

Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers

2017-11-18 Thread Martin Kepplinger
On 2017-11-18 01:13, Jonathan Corbet wrote: > On Sat, 18 Nov 2017 00:43:46 +0100 > Martin Kepplinger wrote: > >> But Greg, people are listening to you. Please don't give advice in >> directions that are not clearly correct for Linux. You know you could >> have simpl

[PATCH] input: pegasus_notetaker: add license information

2017-11-18 Thread Martin Kepplinger
This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger --- drivers/input/tablet/pegasus_notetaker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c

[PATCH v2] iio: mma8452: replace license description with SPDX specifier

2017-11-18 Thread Martin Kepplinger
This replaces the custom license information text with the appropriate SPDX identifier. While the information here stays the same, it is easier to read. Signed-off-by: Martin Kepplinger Acked-by: Peter Meerwald-Stadler --- Sorry I had forgotten to add the mailing lists and got Peter's Ack

Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers

2017-11-18 Thread Martin Kepplinger
On 2017-11-18 11:17, Greg KH wrote: > On Fri, Nov 17, 2017 at 03:53:53PM -0700, Jonathan Corbet wrote: >> On Thu, 16 Nov 2017 12:41:10 +0100 >> Greg KH wrote: >> I'll fold this in, in the thread here. I guess this change is what Greg had in mind? Or would you prefer having including

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-21 Thread Martin Kepplinger
Thanks. I may have missed something, but I'm concerned about only one thing: devices without transient event registers. See my comments below. Am 20.08.2017 18:06 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

2017-08-28 Thread Martin Kepplinger
Am 28.08.2017 02:23 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can be

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-22 Thread Martin Kepplinger
s on only this one issue of enabling freefall (FF_MT registers) for the devices that currently use transient registers. thanks If falling: switch to ff_mt in any case. (fixing freefall for the transient-devices) ok sure. Thanks, Hari On 08/21/2017 04:47 AM, Martin Kepplinger wrote: If r

[PATCH] tools: firewire: nosy-dump: fix a resource leak in main()

2017-09-13 Thread Martin Kepplinger
If option_input and option_output is true two files are opened consecutively. In case the second fopen() fails, let's fclose() the first one before returning early. Signed-off-by: Martin Kepplinger --- tools/firewire/nosy-dump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools

[PATCH] tools: hv: hv_kvp_daemon: fix usage of realloc()

2017-09-13 Thread Martin Kepplinger
realloc() returns NULL in case it fails. Since we don't save the pointer in question elsewhere, we leak memory by assigning NULL to the original memory in the heap. realloc() doesn't free memory in case of failure, so let's do it manually. Signed-off-by: Martin Kepplinger --- tools/hv

[PATCH] tools: objtool: fix memory leak in elf_create_rela_section()

2017-09-13 Thread Martin Kepplinger
Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger --- tools/objtool/elf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6e9f980a7d26

[PATCH] tools: perf: fix leaking rec_argv in error cases

2017-09-13 Thread Martin Kepplinger
Let's free the allocated rec_argv in case we return early, in order to avoid leaking memory. This adds free() at a few very similar places across the tree where it was missing. Signed-off-by: Martin Kepplinger --- tools/perf/builtin-c2c.c | 1 + tools/perf/builtin-mem.c | 1

[PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section()

2017-09-14 Thread Martin Kepplinger
Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger --- I should've allocated some brain resources before freeing some computer's. tools/objtool/elf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/objtool

[PATCH] Documentation: devices.rst: minor plural grammar fix

2018-04-01 Thread Martin Kepplinger
It's authors who request something here, no authors who requests. Let's fix this. Signed-off-by: Martin Kepplinger --- Documentation/admin-guide/devices.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/devices.rst b/Documentation/admin-guide

[PATCH 1/2] Input: mk712: update documentation web link

2018-04-02 Thread Martin Kepplinger
At the mentioned address there's nothing found. By searching information on the controller chip still can be found, so update the link to the resulting page. Signed-off-by: Martin Kepplinger --- drivers/input/touchscreen/mk712.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] Documentation: devices.txt: remove the mk712 touchscreen device from the list

2018-04-02 Thread Martin Kepplinger
The input/touchscreen/mk712.c driver has been rewritten for the common input event system. in 2005. There shouldn't a special device node be created anymore. Signed-off-by: Martin Kepplinger --- Please review this by looking at the driver too. Thanks, martin

Re: [PATCH 1/2] input: touchscreen: ar1021_i2c: enable touch mode during open

2018-02-05 Thread Martin Kepplinger
 Martin Kepplinger | Entwicklung Software  GINZINGER ELECTRONIC SYSTEMS GMBH Tel.: +43 7723 5422 157 Mail: martin.kepplin...@ginzinger.com Web: www.ginzinger.com On 2018-02-05 11:07, Christian Gmeiner wrote: > Hi all. > > 2017-04-27 14:22 GMT+02:00 Martin Kepplinger > : &

[PATCH 1/2] README: revise the top level readme texts

2017-07-12 Thread Martin Kepplinger
re...". Signed-off-by: Martin Kepplinger --- README | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/README b/README index b2ba4aaa3a71..b281213e7c6f 100644 --- a/README +++ b/README @@ -1,17 +1,27 @@ Linux kernel

[PATCH 2/2] Documentation: admin-guide: remove redundant first paragraph of README.rst

2017-07-12 Thread Martin Kepplinger
eader, and start with telling what Linux is. This won't come as a surprise to the reader. Signed-off-by: Martin Kepplinger --- Documentation/admin-guide/README.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/Documentation/admin-guide/README.rst b/Documentation/admin-guide/README.rst

[PATCH] staging: vboxvideo: Kconfig: Fix typos in help text

2017-07-24 Thread Martin Kepplinger
This fixes typos in vboxvideo's help text. Signed-off-by: Martin Kepplinger --- drivers/staging/vboxvideo/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig index a52746f9a670..2b058d573cf1

[PATCH] Input: tsc200x-core - set INPUT_PROP_DIRECT

2017-11-07 Thread Martin Kepplinger
-by: Martin Kepplinger --- Still, as a paranoia measure, I'd not do a bulk-patchset adding this bit to every driver here. I'll add it to drivers I know of, by using them myself or people that report using tslib. Who knows what devices or usecases exist out there :) drivers/input/touchscreen

Re: [PATCH] media: coda: fix comparision of decoded frames' indexes

2017-11-23 Thread Martin Kepplinger
Am 22.11.2017 14:43 schrieb Philipp Zabel: Hi Martin, On Fri, 2017-11-17 at 15:30 +0100, Martin Kepplinger wrote: At this point the driver looks the currently decoded frame's index and compares is to VPU-specific state values. Directly before this if and else statements the indexes are read

[PATCH v2] input: pegasus_notetaker: add license information

2017-11-26 Thread Martin Kepplinger
This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger --- Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I already see a lot of SPDX tags using /**/ comments, I'll use that too. I think if it is hand-written

[PATCH v3] input: pegasus_notetaker: add license information

2017-11-27 Thread Martin Kepplinger
This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger --- ok. thanks for the license-cleanup efforts. I think it's important. martin patch revisions --- v3: use // comments v2: use /**/ comments

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-10 Thread Martin Kepplinger
gt; > Signed-off-by: Harinath Nampally > --- Alright, I didn't test it but I kind of like it now. The one minor naming issue I had pointed out before is mentioned below. But if that's no issue for Jon: Reviewed-by: Martin Kepplinger btw, Harianath: Would you point me to the imx6ul eva

[PATCH] iio: adc: dln2-adc: initialize local struct before using it

2017-09-10 Thread Martin Kepplinger
struct data is defined and declared locally. Initiliazation has to be done manually, so let's add that. Signed-off-by: Martin Kepplinger --- This is more of a question actually! Did you have in mind that data is not initialized here? If so, please drop this patch. This is just in case you

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

2017-09-10 Thread Martin Kepplinger
celeration magnitude rises >above >> >> the threshold. >> >> Only difference is transient event has its own event config >registers >> >> with High pass filter. >> >> If HPF bypassed using config register transient event acts like >motion >> >> detection event. >> > >> >> >> >> That was my understanding but please correct me if I am wrong. >> > >> > I agree with your understanding. It's a rising threshold, just >that the input >> > will only reflect high frequency changes in the signal. >> > >> >> >> >> > Only freefall mode needs one fix: remembering to which set of >registers to fall back when >> >> > disabling it. >> >> >> >> I don't quite understand what you mean by 'to fall back when >disabling >> >> it'. Please elaborate. I would >> >> appreciate if you could suggest your logic in the form of >pseudo-code. >> >> Thanks for your time >> >> >> > ... -- Martin Kepplinger http://martinkepplinger.com sent from mobile

Re: [PATCH] iio: adc: dln2-adc: initialize local struct before using it

2017-09-12 Thread Martin Kepplinger
-ci/linux/commits/Martin-Kepplinger/iio-adc-dln2-adc-initialize-local-struct-before-using-it/20170912-064250 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget

[PATCH] scsi: sd: print write through due to no caching mode page as warning

2021-01-22 Thread Martin Kepplinger
: write through Print these messages as warnings instead of errors. Signed-off-by: Martin Kepplinger --- drivers/scsi/sd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index e7c52d6df4dc..db0171c81c5b 100644 --- a/drivers/scsi/sd.c

[PATCH] scsi_logging: print cdb into new line after opcode

2021-01-22 Thread Martin Kepplinger
example error will then read: sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 01 c0 09 00 00 00 08 00 Signed-off-by: Martin Kepplinger --- drivers/scsi/scsi_logging.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c

[PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property

2021-01-07 Thread Martin Kepplinger
Add #interconnect-cells on main so that it will probe the interconnect provider. Signed-off-by: Martin Kepplinger Acked-by: Georgi Djakov --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64

[PATCH v4 1/5] arm64: dts: imx8mq: Add NOC node

2021-01-07 Thread Martin Kepplinger
on top. Signed-off-by: Leonard Crestez Signed-off-by: Martin Kepplinger Acked-by: Georgi Djakov --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 +++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale

[PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

2021-01-07 Thread Martin Kepplinger
Add optional interconnect properties for the dram path requests. Signed-off-by: Martin Kepplinger --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree

[PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

2021-01-07 Thread Martin Kepplinger
Add interconnect ports for lcdif to set bus capabilities. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index

[PATCH v4 0/5] imx8mq: updates for the interconnect fabric

2021-01-07 Thread Martin Kepplinger
puri.sm/T/#t thanks, martin Leonard Crestez (1): arm64: dts: imx8mq: Add NOC node Martin Kepplinger (4): arm64: dts: imx8mq: Add interconnect provider property dt-bindings: mxsfb: Add interconnect bindings for LCDIF path arm64: dts: imx8mq: Add interconnect for lcdif arm64: defconfig:

[PATCH v4 5/5] arm64: defconfig: Enable interconnect for imx8mq

2021-01-07 Thread Martin Kepplinger
Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely available. Signed-off-by: Martin Kepplinger Acked-by: Georgi Djakov --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

Re: [PATCH] Revert "clk: imx: fix composite peripheral flags"

2021-01-07 Thread Martin Kepplinger
On 04.01.21 13:05, Abel Vesa wrote: On 20-12-31 17:33:40, Fabio Estevam wrote: Hi Martin, On Thu, Dec 31, 2020 at 11:22 AM Martin Kepplinger wrote: This reverts commit 936c383673b9e3007432f17140ac62de53d87db9. It breaks clock reparenting via devfreq on the imx8mq used in the Librem 5 phone

Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

2021-01-15 Thread Martin Kepplinger
On 15.01.21 10:47, Shawn Guo wrote: On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: Add interconnect ports for lcdif to set bus capabilities. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH] scsi_logging: print cdb into new line after opcode

2021-01-24 Thread Martin Kepplinger
On 23.01.21 04:09, Martin K. Petersen wrote: Ewan, sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 00 Print the cdb into a new line in any case, not only when cmd_len is greater than 16. The above example error will then read: sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28

[PATCH v2 2/9] arm64: dts: imx8mq-librem5: Mark charger IRQ as High-Z

2021-01-18 Thread Martin Kepplinger
From: Guido Günther This is consistent with other IRQs and makes keeps currents low. Signed-off-by: Guido Günther Signed-off-by: Martin Kepplinger Reviewed-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 6/9] arm64: dts: imx8mq-librem5: enable the LCD panel

2021-01-18 Thread Martin Kepplinger
This enables the Librem5's ft8006p based LCD panel driven by the imx8mq's Northwest Logic DSI IP core and mxsfb display controller. Signed-off-by: Martin Kepplinger --- .../boot/dts/freescale/imx8mq-librem5.dtsi| 53 ++- 1 file changed, 51 insertions(+), 2 deletions(-) diff

[PATCH v2 5/9] arm64: dts: imx8mq-librem5: Add LCD_1V8 regulator

2021-01-18 Thread Martin Kepplinger
From: Guido Günther It's a supply for to touch and LCD. Signed-off-by: Guido Günther Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi

[PATCH v2 0/9] Config and devicetree updates for the Librem 5 phone

2021-01-18 Thread Martin Kepplinger
usb-c chip as supplier for the charger arm64: dts: imx8mq-librem5: Add LCD_1V8 regulator Martin Kepplinger (4): arm64: dts: imx8mq-librem5: enable the LCD panel arm64: dts: imx8mq-librem5: set regulators boot-on dt-bindings: arm: fsl: Add the librem 5 Evergreen revision arm64: dts: Add Librem5

[PATCH v2 9/9] arm64: dts: Add Librem5 Evergreen

2021-01-18 Thread Martin Kepplinger
Add librem5-r4 with specifics to that revision like the near-level, battery and charger properties. For schematics and more information, see https://developer.puri.sm/Librem5/Hardware_Reference/Evergreen.html Signed-off-by: Martin Kepplinger Reviewed-by: Krzysztof Kozlowski --- arch/arm64/boot

[PATCH v2 1/9] arm64: defconfig: Enable vibra-pwm

2021-01-18 Thread Martin Kepplinger
From: Guido Günther The haptic motor for the Librem 5 uses this. Signed-off-by: Guido Günther Signed-off-by: Martin Kepplinger Reviewed-by: Krzysztof Kozlowski --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64

[PATCH v2 8/9] dt-bindings: arm: fsl: Add the librem 5 Evergreen revision

2021-01-18 Thread Martin Kepplinger
Add an entry for the Librem 5 phone, Evergreen revision which is supported by "r4". Schematics and more information can be found at https://developer.puri.sm/Librem5/Hardware_Reference/Evergreen.html Signed-off-by: Martin Kepplinger Reviewed-by: Krzysztof Kozlowski Acked-by: R

[PATCH v2 7/9] arm64: dts: imx8mq-librem5: set regulators boot-on

2021-01-18 Thread Martin Kepplinger
Expect all those regulators to be turned on initially. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale

[PATCH v2 4/9] arm64: dts: imx8mq-librem5: Add usb-c chip as supplier for the charger

2021-01-18 Thread Martin Kepplinger
From: Guido Günther The tps65982 feeds the bq25895 charge controller on the Librem 5. Signed-off-by: Guido Günther Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq

[PATCH v2 3/9] arm64: dts: imx8mq-librem5: Don't mark buck3 as always on

2021-01-18 Thread Martin Kepplinger
From: Guido Günther With the pmic driver fixed we can now shut off the regulator in the gpc. Signed-off-by: Guido Günther Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-04 Thread Martin Kepplinger
On 30.07.20 17:10, Alan Stern wrote: > On Thu, Jul 30, 2020 at 10:52:14AM +0200, Martin Kepplinger wrote: >> Maybe I should just start a new discussion with a patch, but the below >> is what makes sense to me (when I understand you correctly) and seems to >> work. I basical

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-09 Thread Martin Kepplinger
On 08.08.20 17:05, Alan Stern wrote: > On Sat, Aug 08, 2020 at 08:59:09AM +0200, Martin Kepplinger wrote: >> On 07.08.20 16:30, Alan Stern wrote: >>> On Fri, Aug 07, 2020 at 11:51:21AM +0200, Martin Kepplinger wrote: >>>> it's really strange: below is the chang

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-10 Thread Martin Kepplinger
On 09.08.20 17:26, Alan Stern wrote: > On Sun, Aug 09, 2020 at 11:20:22AM +0200, Martin Kepplinger wrote: >> Hey Alan, I'm really glad for that, I suspected some of this but I have >> little experience in scsi/block layers, so that is super helpful. >> >> I'd appreci

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-11 Thread Martin Kepplinger
On 10.08.20 16:13, Alan Stern wrote: > On Mon, Aug 10, 2020 at 02:03:17PM +0200, Martin Kepplinger wrote: >> On 09.08.20 17:26, Alan Stern wrote: >>> This is a somewhat fragile approach. You don't know for certain that >>> scsi_noretry_cmd will be called. Also, scs

Re: [PATCH v5 1/3] arm64: dts: Add a device tree for the Librem 5 phone

2020-08-13 Thread Martin Kepplinger
On 31.07.20 10:27, Martin Kepplinger wrote: > From: "Angus Ainslie (Purism)" > > Add a devicetree description for the Librem 5 phone. 4 hardware revisions > have been available. Some revisions include changes that need different > software to be run. So far, r3 ("

Re: [PATCH v5 3/3] dt-bindings: arm: fsl: Add the librem 5 phone

2020-08-01 Thread Martin Kepplinger
On 31.07.20 21:35, Rob Herring wrote: > On Fri, 31 Jul 2020 10:27:25 +0200, Martin Kepplinger wrote: >> Add entries for the imx8mq based Librem 5 phone. The "Birch" and >> "Chestnut" hardware revisions are supported by r2. The "Dogwood" >> revis

[PATCH v3 4/6] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

2020-12-10 Thread Martin Kepplinger
Add optional interconnect properties for the dram path requests. Signed-off-by: Martin Kepplinger --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree

[PATCH v3 0/6] imx8mq: updates for the interconnect fabric

2020-12-10 Thread Martin Kepplinger
n Leonard Crestez (1): arm64: dts: imx8mq: Add NOC node Martin Kepplinger (5): arm64: dts: imx8mq: Add interconnect provider property arm64: dts: imx8mq: Add interconnect for lcdif dt-bindings: mxsfb: Add interconnect bindings for LCDIF path interconnect: imx8mq: Use icc_sync_state arm64:

[PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node

2020-12-10 Thread Martin Kepplinger
on top. Signed-off-by: Leonard Crestez Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index a841a023e8e0

[PATCH v3 2/6] arm64: dts: imx8mq: Add interconnect provider property

2020-12-10 Thread Martin Kepplinger
Add #interconnect-cells on main so that it will probe the interconnect provider. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale

[PATCH v3 5/6] interconnect: imx8mq: Use icc_sync_state

2020-12-10 Thread Martin Kepplinger
Add the icc_sync_state callback to notify the framework when consumers are probed and the bandwidth doesn't have to be kept at maximum anymore. Signed-off-by: Martin Kepplinger Suggested-by: Georgi Djakov --- drivers/interconnect/imx/imx8mq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif

2020-12-10 Thread Martin Kepplinger
Add interconnect ports for lcdif to set bus capabilities. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index

[PATCH v3 6/6] arm64: defconfig: Enable interconnect for imx8mq

2020-12-10 Thread Martin Kepplinger
Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely available. Signed-off-by: Martin Kepplinger --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index c8ca76751a34..f25748b0fa95

[PATCH v2 0/4] small Librem 5 phone dts updates

2020-12-22 Thread Martin Kepplinger
revision history v2: (thanks Krzysztof) add Fixes tags and improve commit messages v1: https://lore.kernel.org/linux-arm-kernel/20201218103131.22013-1-martin.kepplin...@puri.sm/ Martin Kepplinger (4): arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 arm64: dts: imx8mq

[PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

2020-12-22 Thread Martin Kepplinger
In order for the touchscreen interrupt line to work, describe it properly. Otherwise it can work if defaults are ok, but we cannot be sure. Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone") Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freesc

[PATCH v2 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage

2020-12-22 Thread Martin Kepplinger
This is a workaround for a hardware bug in the r3 revision that basically would stop the system due to traffic on the i2c1 bus. A cpu voltage change would trigger such traffic and that's what is avoided in order to work around it. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts

[PATCH v2 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT

2020-12-22 Thread Martin Kepplinger
According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi too. Fixes: e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks assignment to board DT") Signed-off-by: Martin Kepplinger ---

[PATCH v2 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8

2020-12-22 Thread Martin Kepplinger
buck7 is the supply here. Also, fix alphabetical ordering. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64

[PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8

2020-12-18 Thread Martin Kepplinger
buck7 is the supply here. Also, fix alphabetical ordering. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64

[PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage

2020-12-18 Thread Martin Kepplinger
This is a workaround for a hardware bug in the r3 revision that basically would stop the system due to traffic on the i2c1 bus. A cpu voltage change would trigger such traffic and that's what is avoided in order to work around it. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts

[PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

2020-12-18 Thread Martin Kepplinger
Add the pinctrl description for the interrupt. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5

[PATCH 0/4] small Librem 5 phone dts updates

2020-12-18 Thread Martin Kepplinger
Some minor updates for the current hardware descriptions: Martin Kepplinger (4): arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT arm64

[PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT

2020-12-18 Thread Martin Kepplinger
According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi too. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 1 file changed, 4 insertions(+)

[PATCH] Revert "clk: imx: fix composite peripheral flags"

2020-12-31 Thread Martin Kepplinger
from PM QoS (-16) Note that on the Librem 5 devkit that uses a different revision of the imx8mq SoC, the added flag does *not* break said clock reparenting so there might be subtle differences here. Signed-off-by: Martin Kepplinger --- drivers/clk/imx/clk-composite-8m.c | 1 - 1 file changed, 1

[PATCH 2/6] arm64: dts: imx8mq: Add interconnect provider property

2020-12-01 Thread Martin Kepplinger
Add #interconnect-cells on main so that it will probe the interconnect provider. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale

[PATCH 1/6] arm64: dts: imx8m: Add NOC nodes

2020-12-01 Thread Martin Kepplinger
-by: Leonard Crestez Tested-by: Martin Kepplinger (imx8mq) --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++ 3 files changed, 66

[PATCH 0/6] imx8mq: updates for the interconnect fabric

2020-12-01 Thread Martin Kepplinger
(1): arm64: dts: imx8m: Add NOC nodes Martin Kepplinger (5): arm64: dts: imx8mq: Add interconnect provider property arm64: dts: imx8mq: Add interconnect for lcdif interconnect: imx8mq: Use icc_sync_state arm64: defconfig: Enable interconnect for imx8mq arm64: defconfig: updates for 5.10

[PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif

2020-12-01 Thread Martin Kepplinger
Add interconnect ports for lcdif to set bus capabilities. Signed-off-by: Martin Kepplinger --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index

[PATCH 4/6] interconnect: imx8mq: Use icc_sync_state

2020-12-01 Thread Martin Kepplinger
Add the icc_sync_state callback to notify the framework when consumers are probed and the bandwidth doesn't have to be kept at maximum anymore. Signed-off-by: Martin Kepplinger Suggested-by: Georgi Djakov --- drivers/interconnect/imx/imx8mq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 5/6] arm64: defconfig: Enable interconnect for imx8mq

2020-12-01 Thread Martin Kepplinger
Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely available for testing. Signed-off-by: Martin Kepplinger --- arch/arm64/configs/defconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

<    1   2   3   4   5   6   7   8   9   10   >