[PATCH v2] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-11-28 Thread Masahiro Yamada
t_check to compiler_attributes.h from compiler_types.h Signed-off-by: Masahiro Yamada --- Changes in v2: - Move __must_check to compiler_attributes.h include/linux/compiler_attributes.h | 7 +++ include/linux/compiler_types.h | 6 -- lib/Kco

[GIT PULL] Kbuild fixes for v5.10-rc6

2020-11-28 Thread Masahiro Yamada
++--- Makefile | 4 +--- scripts/package/builddeb | 2 ++ 3 files changed, 5 insertions(+), 6 deletions(-) -- Best Regards Masahiro Yamada

[PATCH v2 1/7] kbuild: doc: update the description about kbuild Makefiles

2020-11-28 Thread Masahiro Yamada
This line was written in 2003. Now we have much more Makefiles. The number of Makefiles is not important. The point is we have a Makefile in (almost) every directory. Signed-off-by: Masahiro Yamada --- (no changes since v1) Documentation/kbuild/makefiles.rst | 2 +- 1 file changed, 1

[PATCH v2 2/7] kbuild: doc: replace arch/$(ARCH)/ with arch/$(SRCARCH)/

2020-11-28 Thread Masahiro Yamada
wing to pass in the former ARCH=i386 or ARCH=x86_64. Update the documents for preciseness, and add the explanation of SRCARCH. Signed-off-by: Masahiro Yamada Reviewed-by: Randy Dunlap --- Changes in v2: - Fix a typo Documentation/kbuild/makefiles.rst | 61 +- D

Re: [PATCH] kbuild: add extra-y to targets-for-modules

2020-11-25 Thread Masahiro Yamada
On Tue, Nov 24, 2020 at 12:05 AM WANG Chao wrote: > > On 11/23/20 at 02:23P, Masahiro Yamada wrote: > > On Tue, Nov 3, 2020 at 3:23 PM WANG Chao wrote: > > > > > > extra-y target doesn't build for 'make M=...' since commit 6212804f2d78 > > >

Re: [PATCH] Makefile.extrawarn: remove -Wnested-externs warning

2020-11-24 Thread Masahiro Yamada
-Wnested-externs > KBUILD_CFLAGS += -Wshadow > KBUILD_CFLAGS += $(call cc-option, -Wlogical-op) > KBUILD_CFLAGS += -Wmissing-field-initializers > -- > 2.27.0 > -- Best Regards Masahiro Yamada

Re: [PATCH v3] Kbuild: do not emit debug info for assembly with LLVM_IAS=1

2020-11-24 Thread Masahiro Yamada
+= -Wa,-gdwarf-2 > >> > +endif > >> > > >> > ifdef CONFIG_DEBUG_INFO_DWARF4 > >> > DEBUG_CFLAGS += -gdwarf-4 > >> > -- > >> > 2.29.2.222.g5d2a92d10f8-goog > >> > > >> > >> > >> -- > >> Thanks, > >> ~Nick Desaulniers > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "Clang Built Linux" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to clang-built-linux+unsubscr...@googlegroups.com. > >> To view this discussion on the web visit > >> https://groups.google.com/d/msgid/clang-built-linux/CAKwvOdnxAr7UdjUiuttj%3Dbz1_voK1qUvpOvSY35qOZ60%2BE8LBA%40mail.gmail.com. > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH 2/2] Makefile.extrawarn: limit -Wnested-externs to clang

2020-11-23 Thread Masahiro Yamada
flag is only present in clang for compatibility with > GCC: > > https://clang.llvm.org/docs/DiagnosticsReference.html#wnested-externs > > With that, my reviewed by still stands. > I agree. Arnd, will you send v2? Please include https://clang.llvm.org/docs/DiagnosticsReference.html#wnested-externs as a reference. Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] Makefile.extrawarn: move -Wcast-align to W=3

2020-11-23 Thread Masahiro Yamada
ign > > KBUILD_CFLAGS += -Wdisabled-optimization > > KBUILD_CFLAGS += -Wnested-externs > > KBUILD_CFLAGS += -Wshadow > > @@ -80,6 +79,7 @@ endif > > ifneq ($(findstring 3, $(KBUILD_EXTRA_WARN)),) > > > > KBUILD_CFLAGS += -Wbad-function-cast > > +KB

Re: [PATCH] kconfig: qconf: show Qt version in the About dialog

2020-11-22 Thread Masahiro Yamada
On Mon, Nov 2, 2020 at 12:40 PM Masahiro Yamada wrote: > > You can get the Qt version by running "pkg-config --modversion Qt5Core" > or something, but this might be useful to get the runtime Qt version > more easily. Go to the menu "Help" -> "About&

Re: [PATCH] kbuild: add extra-y to targets-for-modules

2020-11-22 Thread Masahiro Yamada
ix your Makefile. Hint: https://patchwork.kernel.org/project/linux-kbuild/patch/20201123045403.63402-6-masahi...@kernel.org/ Probably what you should use is 'targets'. -- Best Regards Masahiro Yamada

Re: [PATCH 3/7] kbuild: doc: fix 'List directories to visit when descending' section

2020-11-22 Thread Masahiro Yamada
On Mon, Nov 23, 2020 at 1:54 PM Masahiro Yamada wrote: > > Fix state information: I mean "Fix stale information" > > - Fix the section number in the reference from 6.4 to 7.4. > > - Remove init-y and net-y. They were removed by commit 23febe375d94 >(&q

[PATCH 2/7] kbuild: doc: replace arch/$(ARCH)/ with arch/$(SRCARCH)/

2020-11-22 Thread Masahiro Yamada
wing to pass in the former ARCH=i386 or ARCH=x86_64. Update the documents for preciseness, and add the explanation of SRCARCH. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 61 +- Documentation/kbuild/modules.rst | 2 +- 2 files cha

[PATCH 3/7] kbuild: doc: fix 'List directories to visit when descending' section

2020-11-22 Thread Masahiro Yamada
ectively. - Update the example because arch/sparc64/Makefile does not exit. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild

[PATCH 7/7] kbuild: doc: document subdir-y syntax

2020-11-22 Thread Masahiro Yamada
There is no explanation about subdir-y. Let's document it. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst index 159e470

[PATCH 5/7] kbuild: doc: split if_changed explanation to a separate section

2020-11-22 Thread Masahiro Yamada
m Rules" section. I slightly reworded the explanation, re-numbered to fill the section, and also fixed the broken indentation of the Note: part. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 94 +- 1 file changed, 52 insertions(+), 42

[PATCH 1/7] kbuild: doc: update the description about kbuild Makefiles

2020-11-22 Thread Masahiro Yamada
This line was written in 2003. Now we have much more Makefiles. The number of Makefiles is not important. The point is we have a Makefile in (almost) every directory. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 6/7] kbuild: doc: clarify the difference between extra-y and always-y

2020-11-22 Thread Masahiro Yamada
it to the section 3.7. always-y is not documented anywhere. I added. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=f94e5fd7e5d09a56a60670a9bb211a791654bba8 Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 110 +++

[PATCH 4/7] kbuild: doc: merge 'Special Rules' and 'Custom kbuild commands' sections

2020-11-22 Thread Masahiro Yamada
fin Makefile does not exist any more. - Replace the example for cmd_ with a simpler one. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 88 ++ 1 file changed, 40 insertions(+), 48 deletions(-) diff --git a/Documentation/kbuild/make

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-22 Thread Masahiro Yamada
On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > > > Our goal is to always enable __must_check where appreciate, so this > > CONFIG option is no longer needed. > > This would be great. It also

[PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-21 Thread Masahiro Yamada
ger needed. I see a lot of defconfig (arch/*/configs/*_defconfig) files having: # CONFIG_ENABLE_MUST_CHECK is not set I did not touch them for now since it would be a big churn. If arch maintainers want to clean them up, please go ahead. Signed-off-by: Masahiro Yamada --- inc

[PATCH 5/6] ARC: build: remove unneeded extra-y

2020-11-21 Thread Masahiro Yamada
Adding vmlinux.* to extra-y has no point because we expect they are built on demand while building uImage.* Add them to 'targets' is enough to include the corresponding .cmd file. Signed-off-by: Masahiro Yamada --- arch/arc/boot/Makefile | 7 +++ 1 file changed, 3 insert

[PATCH 2/6] ARC: build: add uImage.lzma to the top-level target

2020-11-21 Thread Masahiro Yamada
able to be set. Signed-off-by: Masahiro Yamada --- arch/arc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index acf99420e161..61a41123ad4c 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -102,7 +102,7 @@ libs-y

[PATCH 4/6] ARC: build: move symlink creation to arch/arc/Makefile to avoid race

2020-11-21 Thread Masahiro Yamada
since $(obj)/uImage is a symlink. The symlink should be created in a phony target rule. I used $(kecho) instead of echo to suppress the message 'Image arch/arc/boot/uImage is ready' when the -s option is given. Signed-off-by: Masahiro Yamada --- arch/arc/Makefile | 13

[PATCH 6/6] ARC: build: use $(READELF) instead of hard-coded readelf

2020-11-21 Thread Masahiro Yamada
The top Makefile defines READELF as the readelf in the cross-toolchains. Use it rather than the host readelf. Signed-off-by: Masahiro Yamada --- arch/arc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/boot/Makefile b/arch/arc/boot/Makefile index

[PATCH 1/6] ARC: build: remove non-existing bootpImage from KBUILD_IMAGE

2020-11-21 Thread Masahiro Yamada
eaningless KBUILD_IMAGE assignment so it will fallback to the default vmlinux. With this change, you can build the deb package. I removed the 'bootpImage' target as well. At best, it provides 'make bootpImage' as an alias of 'make vmlinux', but I do not see much sense in d

[PATCH 3/6] ARC: build: add boot_targets to PHONY

2020-11-21 Thread Masahiro Yamada
targets as PHONY to fix this. Signed-off-by: Masahiro Yamada --- arch/arc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 61a41123ad4c..cf9da9aea12a 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -104,6 +104,7 @@ boot

[PATCH 0/6] ARC: build: fix various issues in arc boot Makefile

2020-11-21 Thread Masahiro Yamada
Masahiro Yamada (6): ARC: build: remove non-existing bootpImage from KBUILD_IMAGE ARC: build: add uImage.lzma to the top-level target ARC: build: add boot_targets to PHONY ARC: build: move symlink creation to arch/arc/Makefile to avoid race ARC: build: remove unneeded extra-y ARC

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-20 Thread Masahiro Yamada
ixed "apllied" to "applied". Maybe, "that sources" should be "those sources". -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: use -fmacro-prefix-map for .S sources compilation

2020-11-02 Thread Masahiro Yamada
o .S files as well as .c files. > # ensure -fcf-protection is disabled when using retpoline as it is > # incompatible with -mindirect-branch=thunk-extern > -- > 2.19.0.dirty > -- Best Regards Masahiro Yamada

[PATCH] kconfig: qconf: show Qt version in the About dialog

2020-11-01 Thread Masahiro Yamada
You can get the Qt version by running "pkg-config --modversion Qt5Core" or something, but this might be useful to get the runtime Qt version more easily. Go to the menu "Help" -> "About", then you can see it. Signed-off-by: Masahiro Yamada --- scripts/kconf

Re: [PATCH] Kbuild: implement support for DWARF5

2020-11-01 Thread Masahiro Yamada
is script. -u Treat unset variables and parameters other than the special parameters "@" and "*" as an error when performing parameter expansion. If expansion is attempted on an unset variable or parameter, the shell prints an error message, and, if not interactive, exits with a non-zero status. > -- > 2.29.0.rc1.297.gfa9743e501-goog > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20201022012106.1875129-1-ndesaulniers%40google.com. -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] builddeb: Fix rootless build in setuid/setgid directory

2020-10-28 Thread Masahiro Yamada
-R go-w "$pdir" > # in case we are in a restrictive umask environment like 0077 > chmod -R a+rX "$pdir" > + # in case we build in a setuid/setgid directory > + chmod -R ug-s "$pdir" > > # Create the package > dpkg-gencontrol -p$pname -P"$pdir" > -- > 2.28.0 > -- Best Regards Masahiro Yamada

Re: [PATCH 2/2] builddeb: Consolidate consecutive chmod calls into one

2020-10-28 Thread Masahiro Yamada
"$pdir" > # Create the package > dpkg-gencontrol -p$pname -P"$pdir" > -- > 2.28.0 > -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: remove unused OBJSIZE

2020-10-26 Thread Masahiro Yamada
KE UTS_MACHINE HOSTCXX > > export KGZIP KBZIP2 KLZOP LZMA LZ4 XZ ZSTD > > export KBUILD_HOSTCXXFLAGS KBUILD_HOSTLDFLAGS KBUILD_HOSTLDLIBS > > LDFLAGS_MODULE > > -- > > 2.25.4 > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20201023181805.GA3852821%40ubuntu-m3-large-x86. -- Best Regards Masahiro Yamada

[PATCH 3/3] kconfig: qconf: convert to Qt5 new signal/slot connection syntax

2020-10-24 Thread Masahiro Yamada
ignal connection to invalid slots") fixed wrong slots. This change makes it possible to catch such mistakes easily. Signed-off-by: Masahiro Yamada --- scripts/kconfig/qconf.cc | 136 ++- 1 file changed, 78 insertions(+), 58 deletions(-) diff --git a/scrip

[PATCH 2/3] kconfig: qconf: use a variable to pass packages to pkg-config

2020-10-24 Thread Masahiro Yamada
The variable, PKG, is defined at the beginning of this script. Signed-off-by: Masahiro Yamada --- scripts/kconfig/qconf-cfg.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/qconf-cfg.sh b/scripts/kconfig/qconf-cfg.sh index d1eb2407c35d..fa564cd795b7 100755

[PATCH 1/3] kconfig: qconf: drop Qt4 support

2020-10-24 Thread Masahiro Yamada
It is possible to keep this compatible with both Qt4 and Qt5, but not worth the efforts any more; it would require us to test this on both of them, and prevent us from using new features in Qt5. Qt5 was released in 2012, and now widely available. Drop the Qt4 support. Signed-off-by: Masahiro

[GIT PULL 2/2] Kconfig updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
useless code from qconf - Allow to edit "int", "hex", "string" options in place, and remove the separate edit box from qconf -------- Masahiro Yamada (11): kconfig: qconf: reformat the intro message kc

[GIT PULL 2/2] Kconfig updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
useless code from qconf - Allow to edit "int", "hex", "string" options in place, and remove the separate edit box from qconf -------- Masahiro Yamada (11): kconfig: qconf: reformat the intro message kc

[GIT PULL 1/2] Kbuild updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
p for reproducible packages builddeb: Enable rootless builds builddeb: Add support for all required debian/rules targets Jacob Keller (1): scripts: remove namespace.pl Mark Wielaard (1): kbuild: Only add -fno-var-tracking-assignments for old GCC versions Masahiro Yamada (21):

Re: [PATCH] kbuild: Use uname for LINUX_COMPILE_HOST detection

2020-10-21 Thread Masahiro Yamada
istribution. > > ./scripts/mkcompile_h: line 38: hostname: command not found > > Use `uname -n` instead, which is more likely to be available (and > mandated by standards). > > Signed-off-by: Chris Down > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: lin

Re: [PATCH V2] Only add -fno-var-tracking-assignments workaround for old GCC versions.

2020-10-20 Thread Masahiro Yamada
-assignments) > +# Workaround for GCC versions < 5.0 > +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61801 > +ifdef CONFIG_CC_IS_GCC > +DEBUG_CFLAGS := $(call cc-ifversion, -lt, 0500, $(call cc-option, > -fno-var-tracking-assignments)) > +endif > > ifdef CONFIG_DEBUG_INFO > ifdef CONFIG_DEBUG_INFO_SPLIT > -- > 2.18.4 > -- Best Regards Masahiro Yamada

Re: [PATCH v6 07/25] treewide: remove DISABLE_LTO

2020-10-16 Thread Masahiro Yamada
r tree, just to > separate it from the list of dependencies for this series? > > -Kees > > -- > Kees Cook Yes, this is stale code because GCC LTO was not pulled. Applied to linux-kbuild. I added the following historical background. Note added by Masahiro Yamada: DISA

Re: [PATCH] Kbuild.include: remove leftover comment for filechk utility

2020-10-16 Thread Masahiro Yamada
nd no timestamp update > -# - stdin is piped in from the first prerequisite ($<) so one has > -# to specify a valid file as first prerequisite (often the kbuild file) > define filechk > $(Q)set -e; \ > mkdir -p $(dir $@); \ > -- > 2.23.0 > -- Best Regards Masahiro Yamada

[PATCH 1/2] kbuild: deb-pkg: do not build linux-headers package if CONFIG_MODULES=n

2020-10-13 Thread Masahiro Yamada
t doesn't really make sense to build the linux-headers package. Fixes: 269a535ca931 ("modpost: generate vmlinux.symvers and reuse it for the second modpost") Reported-by: Josh Triplett Signed-off-by: Masahiro Yamada --- scripts/package/builddeb | 6 -- scripts/package/mkdeb

[PATCH 2/2] kbuild: deb-pkg: clean up package name variables

2020-10-13 Thread Masahiro Yamada
Hard-code the names of linux-headers and debug packages in the control file. The kernel package is different for ARCH=um. Change the code for better readability. Signed-off-by: Masahiro Yamada --- scripts/package/mkdebian | 18 +- 1 file changed, 9 insertions(+), 9 deletions

Re: [PATCH] kbuild: doc: describe proper script invocation

2020-10-13 Thread Masahiro Yamada
On Tue, Oct 13, 2020 at 11:31 PM Masahiro Yamada wrote: > > On Thu, Oct 1, 2020 at 4:57 PM Lukas Bulwahn wrote: > > > > During an investigation to fix up the execute bits of scripts in the kernel > > repository, Andrew Morton and Kees Cook pointed out that the execute b

Re: [PATCH v2 1/2] kconfig: use interpreters to invoke scripts

2020-10-13 Thread Masahiro Yamada
uot;Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20201012170631.1241502-2-ujjwalkumar0501%40gmail.com. -- Best Regards Masahiro Yamada

Re: [PATCH v2 2/2] kbuild: use interpreters to invoke scripts

2020-10-13 Thread Masahiro Yamada
> is WRONG > > Yup, as it's in a Makefile and that's a Makefile construct. > > > and in the next line he suggested the required correction. > > That being: > > $($(CONFIG_SHELL)-> $(shell $(CONFIG_SHELL) > > Such stuff should generally not be needed as the to-be-used > shell can be set in Makefiles via a "SHELL = " assignment > (defaulting to /bin/sh - what else;-). > Flags for the shell can BTW set with ".SHELLFLAGS = ". You are talking about a different thing. Take the current code as an example: $(shell $(srctree)/arch/ia64/scripts/check-gas "$(CC)" "$(OBJDUMP)") Here are two shell invocations. [1] The command $(srctree)/arch/ia64/scripts/check-gas "$(CC)" "$(OBJDUMP)" is run in /bin/sh because the default value of SHELL is /bin/sh. [2] The script, arch/ia64/scripts/check-gas, is run in /bin/sh because the hash-bang (the first line of check-gas) specifies #!/bin/sh Bernd is talking about [1]. In contrast, this patch is addressing [2] because Andrew Morton suggested to run scripts without relying on the executable bit. (and, after this patch, we run scripts without relying on the hash-bang because we now specify the interpreter.) Of course, [1] and [2] can be different. I always want to use /bin/sh for [1], so please do not use bash-extension inside $(shell ...) You have more choices for [2]. If arch/ia64/scripts/check-gas had been written with bash-extension, the code would have been changed into: $(shell $(BASH) $(srctree)/arch/ia64/scripts/check-gas "$(CC)" "$(OBJDUMP)") I hope this will be clearer. > So please > -) learn basic "Makefile" + "make" before brainlessly patching >a Makefile. > -) actually testy your changes to make sure the patch didn't >broke anything > -) and - last but not least - check if there isn't a shell >already set (and which). > > MfG, > Bernd > -- > There is no cloud, just other people computers. > -- https://static.fsf.org/nosvn/stickers/thereisnocloud.svg -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: doc: describe proper script invocation

2020-10-13 Thread Masahiro Yamada
t; not point to any documentation, though. > > Masahiro Yamada explained the convention of setting execute bits to make it > easier for manual script invocation. > > Provide some basic documentation how the build shall invoke scripts, such > that the execute bits do not matter,

Re: [PATCH RFC 0/2] use interpreters to invoke scripts

2020-10-12 Thread Masahiro Yamada
series. It is difficult to predict which patch he would pick up, and which he would not. I can apply this series together with Lukas' base patch. I pointed out possible mistakes in 2/2. I can locally fix them up if you agree. BTW, Kees Cook suggested dropping the x bit from all scripts, but I did not agree with that part. In the doc change, Lukas mentioned "further clean-up patches", but I hope it does not mean dropping the x bits. -- Best Regards Masahiro Yamada

Re: [PATCH RFC 2/2] kbuild: use interpreters to invoke scripts

2020-10-12 Thread Masahiro Yamada
arse HEAD > $(perf-tar)/HEAD;\ > (cd $(srctree)/tools/perf; \ > -util/PERF-VERSION-GEN $(CURDIR)/$(perf-tar)/); \ > +$(CONFIG_SHELL) util/PERF-VERSION-GEN $(CURDIR)/$(perf-tar)/); \ > tar rf $(perf-tar).tar $(perf-tar)/HEAD $(perf-tar)/PERF-VERSION-FILE; \ > rm -r $(perf-tar); \ > $(if $(findstring tar-src,$@),, \ > -- > 2.26.2 > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/979bb7b0-2cae-3cd7-2fbd-7fcece9aafd1%40gmail.com. -- Best Regards Masahiro Yamada

Re: [PATCH] MAINTAINERS: step down as maintainer of UniPhier SoCs and Denali driver

2020-10-12 Thread Masahiro Yamada
On Mon, Aug 31, 2020 at 1:10 PM Masahiro Yamada wrote: > > I am leaving Socionext. Orphan the UniPhier platform and Denali NAND > driver until somebody takes the role. > > Signed-off-by: Masahiro Yamada > --- > > I hope this can be applied to the ARM-SOC tree

Re: [PATCH v2] kbuild: enforce -Werror=return-type

2020-10-11 Thread Masahiro Yamada
ror=return-type -Wno-format-security \ >-std=gnu89 > KBUILD_CPPFLAGS := -D__KERNEL__ > KBUILD_AFLAGS_KERNEL := -- Best Regards Masahiro Yamada

Re: [PATCH v1] kbuild: enforce -Werror=return-type

2020-10-11 Thread Masahiro Yamada
t around line 500. > # Require designated initializers for all marked structures > KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init) > -- Best Regards Masahiro Yamada

Re: [PATCH] scripts: remove namespace.pl

2020-10-09 Thread Masahiro Yamada
tool output as suspect or not very useful (see discussions at [1] and > [2] for further context). > > As described by Masahiro Yamada at [2], namespace.pl provides 3 types of > checks: listing multiply defined symbols, resolving external symbols, > and warnings about symbols with no r

Re: [PATCH] merge_config.sh: Add switch to specify ARCH variable

2020-10-09 Thread Masahiro Yamada
Fills in any missing symbols with # CONFIG_* is not set > -make KCONFIG_ALLCONFIG=$TMP_FILE $OUTPUT_ARG $ALLTARGET > +make ARCH=$ARCH KCONFIG_ALLCONFIG=$TMP_FILE $OUTPUT_ARG $ALLTARGET > > > # Check all specified config values took (might have missed-dependency > issues) > -- > 1.8.3.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 5/7] builddeb: Enable rootless builds

2020-10-09 Thread Masahiro Yamada
gt; +++ b/scripts/package/mkdebian > @@ -188,6 +188,7 @@ Source: $sourcename > Section: kernel > Priority: optional > Maintainer: $maintainer > +Rules-Requires-Root: no > Build-Depends: bc, rsync, kmod, cpio, bison, flex | flex:native > $extra_build_depends > Homepage: https://www.kernel.org/ > > -- > 2.28.0.297.g1956fa8f8d > -- Best Regards Masahiro Yamada

Re: [PATCH 4/7] builddeb: Add support for all required debian/rules targets

2020-10-09 Thread Masahiro Yamada
VERSION=${revision} -f \$(srctree)/Makefile > > -binary-arch: > +build: build-arch > + > +binary-indep: > +binary-arch: build-arch > \$(MAKE) KERNELRELEASE=${version} ARCH=${ARCH} \ > KBUILD_BUILD_VERSION=${revision} -f \$(srctree)/Makefile intdeb-pkg > > -- > 2.28.0.297.g1956fa8f8d > -- Best Regards Masahiro Yamada

Re: [PATCH 1/7] builddeb: Pass -n to gzip for reproducible packages

2020-10-09 Thread Masahiro Yamada
pname/changelog.Debian" > + gzip -n -9 "$pdir/usr/share/doc/$pname/changelog.Debian" > sh -c "cd '$pdir'; find . -type f ! -path './DEBIAN/*' -printf '%P\0' > \ > | xargs -r0 md5sum > DEBIAN/md5sums" > > -- > 2.28.0.297.g1956fa8f8d > -- Best Regards Masahiro Yamada

Re: [PATCH 0/7] builddeb: Improve Debian packaging

2020-09-28 Thread Masahiro Yamada
d > > scripts/package/builddeb | 11 ++-- > scripts/package/mkdebian | 59 +++- > 2 files changed, 48 insertions(+), 22 deletions(-) > > -- > 2.28.0.297.g1956fa8f8d > -- Best Regards Masahiro Yamada

Re: [PATCH 3/7] builddeb: Switch to a machine readable copyright file

2020-09-28 Thread Masahiro Yamada
General Public License > + version 2 can be found in '/usr/share/common-licenses/GPL-2'. > EOF > > # Generate a control file > -- > 2.28.0.297.g1956fa8f8d > -- Best Regards Masahiro Yamada

Re: [PATCH RFC] kbuild: doc: describe proper script invocation

2020-09-28 Thread Masahiro Yamada
#Makefile > + cmd_depmod = $(CONFIG_SHELL) $(srctree)/scripts/depmod.sh > $(DEPMOD) \ > +$(KERNELRELEASE) > > 4 Host Program support > == > -- > 2.17.1 > -- Best Regards Masahiro Yamada

[GIT PULL] Kbuild fixes for v5.9-rc7

2020-09-27 Thread Masahiro Yamada
builds - Fix the usage of --target mentioned in the LLVM document Florian Fainelli (1): Documentation/llvm: Fix clang target examples Masahiro Yamada (1): scripts/kallsyms: skip ppc compiler stub *.long_branch

Re: [PATCH] Documentation/llvm: Fix clang target examples

2020-09-25 Thread Masahiro Yamada
> > ``--target=``. For > > example: :: > > > > - clang --target aarch64-linux-gnu foo.c > > + clang --target=aarch64-linux-gnu foo.c > > > > LLVM Utilities > > -- > > -- > > 2.25.1 > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-24 Thread Masahiro Yamada
ts/setlocalversion | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) Applied to linux-kbuild. Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH] modpost: allow modpost to fail on warnings

2020-09-24 Thread Masahiro Yamada
e) { > if (license_is_gpl_compatible(license)) > mod->gpl_compatible = 1; > > > If yes, also wondering if we can still add the option to treat warnings > as errors as an opt-in behavior? I want to add a new option only when it is necessary to do so. I am not sure which warnings are real warnings. > Thanks! > -Pierre -- Best Regards Masahiro Yamada

Re: [PATCH 1/1] Makefile.build: Add an explicit error for missing ASN.1 compiler

2020-09-24 Thread Masahiro Yamada
asename $@).c $(basename $@).h > > +ifndef CONFIG_ASN1 > +$(objtree)/scripts/asn1_compiler: > + $(error CONFIG_ASN1 must be defined for the asn1_compiler) > +endif > + > $(obj)/%.asn1.c $(obj)/%.asn1.h: $(src)/%.asn1 > $(objtree)/scripts/asn1_compiler > $(call cmd,asn1_compiler) > > -- > 2.26.2 > -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Masahiro Yamada
el/vdso/Makefile | 2 +- > arch/s390/kernel/vdso64/Makefile | 2 +- > arch/sparc/vdso/Makefile | 2 +- > arch/x86/entry/vdso/Makefile | 2 +- > tools/testing/selftests/bpf/Makefile | 2 +- > 10 files changed, 11 insertions(+), 11 deletions(-) Applied to linux-kbuild. Thanks. -- Best Regards Masahiro Yamada

[PATCH] kbuild: split the build log of kallsyms

2020-09-24 Thread Masahiro Yamada
.tmp_vmlinux.kallsyms2.o LD vmlinux Signed-off-by: Masahiro Yamada --- scripts/link-vmlinux.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index e6e2d9e5ff48..d9bcf36a1583 100755 --- a/scripts/link

Re: [PATCH] scripts/kallsyms: skip ppc compiler stub *.long_branch.* / *.plt_branch.*

2020-09-24 Thread Masahiro Yamada
On Wed, Sep 23, 2020 at 5:43 AM Guenter Roeck wrote: > > On Wed, Sep 23, 2020 at 02:48:56AM +0900, Masahiro Yamada wrote: > > PowerPC allmodconfig often fails to build as follows: > > > > LD .tmp_vmlinux.kallsyms1 > > KSYM.tmp_

[PATCH] scripts/kallsyms: skip ppc compiler stub *.long_branch.* / *.plt_branch.*

2020-09-22 Thread Masahiro Yamada
s step required. scripts/kallsyms.c already ignores various compiler stubs. Let's do similar to make kallsysms for PowerPC always succeed in 2 steps. Reported-by: Guenter Roeck Signed-off-by: Masahiro Yamada --- scripts/kallsyms.c | 16 +++- 1 file changed, 15 insertions(+), 1 delet

[GIT PULL] Kbuild fixes for v5.9-rc6

2020-09-19 Thread Masahiro Yamada
help message Masahiro Yamada (3): kconfig: qconf: use delete[] instead of delete to free array (again) kconfig: qconf: fix incomplete type 'struct gstr' warning kconfig: qconf: revive help message in the

Re: [PATCH] modpost: allow modpost to fail on warnings

2020-09-18 Thread Masahiro Yamada
6 +2592,9 @@ int main(int argc, char **argv) > case 'w': > warn_unresolved = 1; > break; > + case 'F': > + fail_on_warnings = 1; > + break; > case 'E': > sec_mismatch_fatal = 1; > break; > @@ -2671,5 +2678,8 @@ int main(int argc, char **argv) > > free(buf.p); > > + if (fail_on_warnings && warnings_count) > + err |= 2; > + > return err; > } > -- > 2.25.1 > -- Best Regards Masahiro Yamada

Re: [PATCH] kconfig: qconf: revive help message in the info view

2020-09-17 Thread Masahiro Yamada
On Tue, Sep 15, 2020 at 12:00 AM Masahiro Yamada wrote: > > Since commit 68fd110b3e7e ("kconfig: qconf: remove redundant help in > the info view"), the help message is no longer displayed. > > I intended to drop duplicated "Symbol:", "Type:"

Re: [PATCH 2/2] kconfig: fix incomplete type 'struct gstr' warning

2020-09-17 Thread Masahiro Yamada
On Wed, Sep 9, 2020 at 11:09 PM Boris Kolpackov wrote: > > Masahiro Yamada writes: > > > Currently, get_relations_str() is declared before the struct gstr > > definition. > > Yes, I also ran into this while building the kconfig code with MSVC. > I just moved the

Re: [PATCH 1/2] kconfig: qconf: use delete[] instead of delete to free array (again)

2020-09-17 Thread Masahiro Yamada
On Fri, Sep 11, 2020 at 2:24 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Tue, Sep 8, 2020 at 3:17 PM Masahiro Yamada wrote: > > > > Commit c9b09a9249e6 ("kconfig: qconf: use delete[] instead of delete > > to free array") fixed two line

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Thu, Sep 17, 2020 at 4:31 AM Rasmus Villemoes wrote: > > On 16/09/2020 20.01, Masahiro Yamada wrote: > > On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes > > wrote: > >> > >> On 16/09/2020 16.28, Masahiro Yamada wrote: > >>> On Fri, Sep 1

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes wrote: > > On 16/09/2020 16.28, Masahiro Yamada wrote: > > On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes > > wrote: > >> > >> On 10/09/2020 21.05, Brian Norris wrote: > >>> On Thu, Sep 1

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes wrote: > > On 10/09/2020 21.05, Brian Norris wrote: > > On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada > > wrote: > >> On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes > >> wrote: > >>> So in

Re: [question] KBUILD_OUTPUT and modules install (with INSTALL_MOD_PATH)

2020-09-15 Thread Masahiro Yamada
On Tue, Sep 15, 2020 at 2:42 PM Frank Wunderlich wrote: > > Am 15. September 2020 04:56:55 MESZ schrieb Masahiro Yamada > : > >On Tue, Sep 15, 2020 at 2:57 AM Frank Wunderlich > > >> i try to use modules_install target after building kernel with > >KBUILD_O

Re: [question] KBUILD_OUTPUT and modules install (with INSTALL_MOD_PATH)

2020-09-14 Thread Masahiro Yamada
without success) > > 718 include/config/auto.conf: > 719 $(Q)test -e include/generated/autoconf.h -a -e $@ || ( \ > 720 echo >&2; \ > 721 echo >&2 " ERROR: Kernel configuration is invalid."; \ > 722 echo >&2 " include/generated/autoconf.h or $@ are missing.";\ > > any idea? > > regards Frank > -- Best Regards Masahiro Yamada

Re: xconfig is broken again on Qt5

2020-09-14 Thread Masahiro Yamada
think it should be converted from gtk+2 to gtk+3 and I know various bugs that need fixing (but I have not been able to find time to work on it...) > Best regards, > Maxim Levitsky > -- Best Regards Masahiro Yamada

[PATCH] kconfig: qconf: revive help message in the info view

2020-09-14 Thread Masahiro Yamada
"defined at" is contained in menu_get_ext_help(), so I made sure to not display it twice. Fixes: 68fd110b3e7e ("kconfig: qconf: remove redundant help in the info view") Reported-by: Maxim Levitsky Signed-off-by: Masahiro Yamada --- scripts/kconfig/qconf.cc | 11 --- 1 f

Re: [PATCH] kbuild: Run syncconfig with -s

2020-09-14 Thread Masahiro Yamada
.o files are deleted on error or interruption (and this should be automatically handled by GNU Make). .o.cmd is included only when the corresponding .o exists. This is explained in the case [2] of commit 392885ee82d35d515ba2af7b72c5e357c3002113 -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: Run syncconfig with -s

2020-09-14 Thread Masahiro Yamada
On Mon, Sep 14, 2020 at 9:37 PM Ingo Molnar wrote: > > > * Masahiro Yamada wrote: > > > On Thu, Aug 20, 2020 at 3:35 PM Ingo Molnar wrote: > > > > > > On every kernel build that runs --syncconfig, there's an output of the > > > following line

Re: [PATCH 1/4] kbuild: remove cc-option test of -fno-strict-overflow

2020-09-14 Thread Masahiro Yamada
Hi Will, On Sat, Sep 12, 2020 at 12:22 AM Will Deacon wrote: > > On Thu, Sep 10, 2020 at 10:51:17PM +0900, Masahiro Yamada wrote: > > The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. > > > > Here is the godbolt: > > https://godbolt.org/

Re: [PATCH] build: Fix documentation checking

2020-09-10 Thread Masahiro Yamada
or member 'len' not described in 'apparmor_socket_getpeersec_stream' security/apparmor/domain.c:136: warning: Function parameter or member 'state' not described in 'label_compound_match' security/apparmor/domain.c:136: warning: Excess function parameter 'start' description in 'label_compound_match' security/apparmor/domain.c:290: warning: Function parameter or member 'perms' not described in 'change_profile_perms' security/apparmor/domain.c:389: warning: Function parameter or member 'bprm' not described in 'find_attach' security/apparmor/domain.c:389: warning: Function parameter or member 'head' not described in 'find_attach' security/apparmor/domain.c:389: warning: Function parameter or member 'name' not described in 'find_attach' security/apparmor/domain.c:389: warning: Function parameter or member 'info' not described in 'find_attach' security/apparmor/domain.c:560: warning: Function parameter or member 'info' not described in 'x_to_label' security/apparmor/domain.c:1292: warning: Excess function parameter 'onexec' description in 'aa_change_profile' security/apparmor/apparmorfs.c:1500: warning: Cannot understand * on line 1500 - I thought it was a doc line security/apparmor/apparmorfs.c:1527: warning: Cannot understand * on line 1527 - I thought it was a doc line security/apparmor/apparmorfs.c:1884: warning: Cannot understand * on line 1884 - I thought it was a doc line security/apparmor/apparmorfs.c:2127: warning: Function parameter or member 'p' not described in '__next_profile' security/apparmor/apparmorfs.c:2127: warning: Excess function parameter 'profile' description in '__next_profile' AR security/apparmor/built-in.a > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index a467b9323442..571d75777b6f 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -104,7 +104,8 @@ else ifeq ($(KBUILD_CHECKSRC),2) > endif > > ifneq ($(KBUILD_EXTRA_WARN),) > - cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< > + quiet_cmd_checkdoc = CHKDOC $< > +cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< > endif > > # Compile C sources (.c) > -- > 2.28.0 > -- Best Regards Masahiro Yamada

[PATCH 2/2] kbuild: move CFLAGS_{KASAN,UBSAN,KCSAN} exports to relevant Makefiles

2020-09-10 Thread Masahiro Yamada
ble, which evaluates $(call cc-option, ...) multiple times before Kbuild starts descending to subdirectories. Signed-off-by: Masahiro Yamada --- Makefile | 1 - scripts/Makefile.kasan | 2 ++ scripts/Makefile.kcsan | 2 +- scripts/Makefile.ubsan | 3 +++ 4 files changed, 6 inser

[PATCH 4/4] kbuild: remove cc-option test of -Werror=date-time

2020-09-10 Thread Masahiro Yamada
The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. Here is the godbolt: https://godbolt.org/z/xvjcMa Signed-off-by: Masahiro Yamada --- Makefile | 2 +- arch/arm64/kernel/vdso32/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 3/4] kbuild: remove cc-option test of -fno-stack-check

2020-09-10 Thread Masahiro Yamada
The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. Here is the godbolt: https://godbolt.org/z/59cK6o Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1b6abecc5cab..5102c89d3167 100644

[PATCH 1/2] kbuild: remove redundant CONFIG_KASAN check from scripts/Makefile.kasan

2020-09-10 Thread Masahiro Yamada
Since commit e0fe0bbe57b8 ("kbuild: include scripts/Makefile.* only when relevant CONFIG is enabled"), this file is included only when CONFIG_KASAN=y. This ifdef is redundant. Signed-off-by: Masahiro Yamada --- scripts/Makefile.kasan | 2 -- 1 file changed, 2 deletions(-) di

[PATCH 2/4] kbuild: remove cc-option test of -fno-merge-all-constants

2020-09-10 Thread Masahiro Yamada
The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. Here is the godbolt: https://godbolt.org/z/8T4177 Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 059b36f2ea53..1b6abecc5cab 100644

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Masahiro Yamada
print it. > - if atag="$(git describe 2>/dev/null)"; then > + if atag="$(git describe --abbrev=15 2>/dev/null)"; > then > echo "$atag" | awk -F- '{printf("-%05d-%s", > $(NF-1),$(NF))}' > > # If we don't have a tag at all we print > -g{commitish}. > -- > 2.23.0 > -- Best Regards Masahiro Yamada

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-10 Thread Masahiro Yamada
c about LTO. GCC LTO was implemented in the final link stage (i.e. vmlinux) by using $(CC) as a linker driver. On the other hand, Clang LTO, in this series implementation, works in the pre-mospost stage (i.e. vmlinux.o). -- Best Regards Masahiro Yamada

Re: [PATCH 2/4] kbuild: remove cc-option test of -fno-merge-all-constants

2020-09-10 Thread Masahiro Yamada
On Fri, Sep 11, 2020 at 1:33 AM Nathan Chancellor wrote: > > On Thu, Sep 10, 2020 at 10:51:18PM +0900, Masahiro Yamada wrote: > > The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. > > > > Here is the godbolt: > > https://godbolt.org/z/8T4177 &

[PATCH 1/4] kbuild: remove cc-option test of -fno-strict-overflow

2020-09-10 Thread Masahiro Yamada
The minimal compiler versions, GCC 4.9 and Clang 10 support this flag. Here is the godbolt: https://godbolt.org/z/odq8h9 Signed-off-by: Masahiro Yamada --- Makefile | 2 +- arch/arm64/kernel/vdso32/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-09 Thread Masahiro Yamada
On Wed, Sep 9, 2020 at 8:46 AM Sami Tolvanen wrote: > > On Sun, Sep 06, 2020 at 09:24:38AM +0900, Masahiro Yamada wrote: > > On Fri, Sep 4, 2020 at 5:30 AM Sami Tolvanen > > wrote: > > > > > > This patch series adds support for building x86_64 and arm64

[PATCH 1/2] kconfig: qconf: use delete[] instead of delete to free array (again)

2020-09-08 Thread Masahiro Yamada
x27;new[]' here char *data = new char[count + 1]; ^ Fixes: c4f7398bee9c ("kconfig: qconf: make debug links work again") Fixes: c9b09a9249e6 ("kconfig: qconf: use delete[] instead of delete to free array") Signed-off-by: Masahiro Yamada --- scripts/kconfig/qconf.cc | 2

<    3   4   5   6   7   8   9   10   11   12   >