(2013/11/28 2:41), Oleg Nesterov wrote:
On 11/27, Masami Hiramatsu wrote:
(2013/11/27 2:43), Oleg Nesterov wrote:
This doesn't allow to read the data from other CPUs, but at least
the changes are simple and this_cpu_ is better than the reading
from the obviously wrong address.
Yeah
(2013/11/27 23:39), Namhyung Kim wrote:
Hi Masami,
2013-11-27 (수), 20:57 +0900, Masami Hiramatsu:
(2013/11/27 15:19), Namhyung Kim wrote:
-DEFINE_BASIC_PRINT_TYPE_FUNC(u8, %x, unsigned int)
-DEFINE_BASIC_PRINT_TYPE_FUNC(u16, %x, unsigned int)
-DEFINE_BASIC_PRINT_TYPE_FUNC(u32, %lx
(2013/11/27 22:32), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
+#ifdef CONFIG_KPROBES
+/*
+ * Blacklist ganerating macro. Specify functions which is not probed
+ * by using this macro.
+ */
+#define __NOKPROBE_SYMBOL(fname
(2013/11/27 22:30), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2013/11/22 11:35), Masami Hiramatsu wrote:
(2013/11/21 16:29), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2013/11/21 2:36), Frank Ch. Eigler wrote
for the pointer! :)
It needs not a CPP macro but an assembly macro.
OK, I'll try that.
Thanks again,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send
,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
variable?
Hmm, indeed current message is too less information, but your message looks
wired. I think just showing Failed to find requested symbol in %s is enough.
:)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E
,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Fix perf probe --list to initialize fname local var always before
use it. This may cause a SEGV if there is a probe which is in
the function body but not in any inline function.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Paul
Hi Arnaldo,
I've found a bug in my previous patch which was already picked
in the perf/urgent branch. The buggy commit id is
e08cfd4bda7683cdbe6971c26cf23e2afdb1e7a8
And this is not related to the previous series of perf probe
updates.
Thank you,
(2013/10/11 21:23), Masami Hiramatsu wrote
:)
Reviewed-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
---
kernel/trace/trace.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 5aa8f80..81d95bf 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace
that the CONFIG_STACKTRACE is forced on if it is required.
And if you have found such case, IMHO, we should turn on the CONFIG_STACKTRACE
in Kconfig.
(Also, if it is not related to this series, it should be reported as a separated
bugfix :) )
Thank you,
--
Masami HIRAMATSU
IT Management Research
;
+}
+EXPORT_SYMBOL_GPL(tracing_alloc_snapshot);
Out of curiously, why this symbol is exported to modules?
The functions which are called directly from trace_event macros
should be exported because those macros can be used in module code,
but I couldn't find this in such code, at a glance.
Thank you,
--
Masami
(2013/10/11 23:04), Tom Zanussi wrote:
On Fri, 2013-10-11 at 22:47 +0900, Masami Hiramatsu wrote:
(2013/10/11 9:48), Tom Zanussi wrote:
/**
+ * tracing_alloc_snapshot - allocate snapshot buffer.
+ *
+ * This only allocates the snapshot buffer if it isn't already
+ * allocated - it doesn't
on the production
system).
I think under such situation kgdb operator must have full control of the
system, and he can (and has to) avoid such kind of race.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu
need to
use such union...
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
(2013/11/11 2:28), Oleg Nesterov wrote:
On 11/11, Masami Hiramatsu wrote:
(2013/11/09 4:00), Oleg Nesterov wrote:
uprobe_task-vaddr is a bit strange. First of all it is not really
needed, we can move it into arch_uprobe_task. The generic code uses
it only to pass the additional argument
handlers could use it to communicate with call_fetch() methods.
OK, those are used in the different phase as a scratchpad.
Signed-off-by: Oleg Nesterov o...@redhat.com
Reviewed-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Thanks!
---
include/linux/uprobes.h | 21
(2013/11/11 14:39), Sandeepa Prabhu wrote:
On 9 November 2013 14:40, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
(2013/11/09 1:56), Will Deacon wrote:
Hi Sandeepa,
On Thu, Oct 17, 2013 at 12:17:47PM +0100, Sandeepa Prabhu wrote:
Add support for basic kernel probes(kprobes), jump
(2013/11/11 16:54), Masami Hiramatsu wrote:
In fact, how do you avoid a race with hardware breakpoints? E.g., somebody
places a hardware breakpoint on an instruction in the kernel for which
kprobes has patched in a brk. We take the hardware breakpoint, disable the
breakpoint and set up
(2013/11/11 20:16), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
Currently the blacklist is maintained by hand in kprobes.c
which is separated from the function definition and is hard
to catch up the kernel update.
To solve this issue, I've tried
(2013/11/11 19:58), Will Deacon wrote:
On Mon, Nov 11, 2013 at 10:51:52AM +, Masami Hiramatsu wrote:
(2013/11/11 16:54), Masami Hiramatsu wrote:
In fact, how do you avoid a race with hardware breakpoints? E.g.,
somebody
places a hardware breakpoint on an instruction in the kernel
, it seems that this also has some works around instruction
manipulation (and confusable filenames...)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from
(2013/11/12 17:44), Sandeepa Prabhu wrote:
On 12 November 2013 12:57, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
(2013/11/12 15:23), Sandeepa Prabhu wrote:
OK, I've ensured that the hw_breakpoint (from perf) can work
with kprobes (from ftrace) at the same address on x86.
So
, and if I found
such problem, I added it on the blacklist.
Currently I run the test only on x86, so perhaps, other arch does
not have well tested yet.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail
it
been tested recently with sample modules or perf/ptrace?
I've tested on x86 with the latest tip-tree kernel and it worked.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
, perhaps we can do some magic in post-build script as kallsyms does.
1) make an object file
2) extract symbols from the file
3) put the symbols into data section as a list of strings
4) analyze the list at boot (init) time by using kallsyms
how about this? :)
Thank you,
--
Masami HIRAMATSU
;
/* copy of the original instruction */
+#ifdef CONFIG_KPROBES
struct arch_specific_insn ainsn;
+#else
+ int ainsn;
+#endif
/*
* Indicates various status flags.
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama
on each feature who is responsible for
it (even it is a piece of code), and scripts/get_maintainers.pl gives you
who are.
Srikar, Oleg, I think it's a good time to merge such arch_specific mechanism
of uprobes and kprobes. Would you think we can do similar thing on x86 too?
Thank you,
--
Masami
of the function tracing callback.
I see, function_trace_op is just a pointer to an actual ftrace_ops. :)
And I have ensured this change doesn't affect ftrace-kprobes since
it doesn't use this parameter.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Reviewed-by: Masami Hiramatsu masami.hiramatsu
permission error). And we are not sure the
code is same as old one. (only compared with what we expected)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from
cause a deadlock, see the warning in
smp_call_function_many, kernel/smp.c:371.
The change is inspired by the code in arch/x86/kernel/ftrace.c.
Looks good for me :)
Reviewed-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Petr Mladek pmla...@suse.cz
---
arch/x86
() and set_all_modules_text_rw()
OK, I got the reason why we can do it.
But if so, we should change all existing caller of text_poke_bp() to
call it in this patch, or they must fail at this point.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd
(2013/11/14 21:46), Petr Mladek wrote:
Masami Hiramatsu píše v Čt 14. 11. 2013 v 20:36 +0900:
(2013/11/14 19:41), Petr Mladek wrote:
@@ -837,7 +882,7 @@ static void recover_iter(struct text_poke_bp_iter
*iterator,
}
/* Finally, put back the first byte from the old code
-tracer last night, that was amazing :)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
nested macro.
- Update Documentations/kprobes.txt about blacklist.
---
Masami Hiramatsu (22):
kprobes: Prohibit probing on .entry.text code
kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist
kprobes: Show blacklist entries via debugfs
kprobes: Support blacklist functions
the blacklist.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: Al Viro v...@zeniv.linux.org.uk
Cc: Seiji Aguchi seiji.agu...@hds.com
Cc
.
Changes from previous version:
- fix indent of the macro by using tabs.
- fix macro for expanding nested macro.
- update Documentations/kprobes.txt
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
---
kernel/kprobes.c | 67
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in trap.c.
This also applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by referring
the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobe annotation in hw_breakpoint.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andrew Morton
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in ftrace.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in kvm.c.
This also adds kvm_read_and_reset_pf_reason in
the blacklist because it can be called before
do_page_fault.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in x86
kprobes code.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu
Show blacklist entries (function names with the address
range) via /sys/kernel/debug/kprobes/blacklist.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
---
kernel/kprobes.c | 61
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in notifier.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
---
kernel/notifier.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/kernel
.
update_bitfield_fetch_param
free_bitfield_fetch_param
kprobe_register
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
---
kernel/trace/trace_kprobe.c |2 +-
kernel/trace
unregister_kprobe
__unregister_kprobe_bottom
unregister_kprobes
__unregister_kprobe_top
unregister_kretprobe
unregister_kretprobe
unregister_kretprobes
unregister_kretprobes
wait_for_kprobe_optimizer
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana
.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Borislav Petkov b...@suse.de
Cc: Fenghua Yu fenghua...@intel.com
Cc: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/kernel/cpu
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in fault.c.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in alternative.c.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Jiri Kosina
with CONFIG_DEBUG_NOTIFIERS=y.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Andrew Morton a...@linux-foundation.org
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Cc: Borislav Petkov b...@suse.de
Cc: Ingo Molnar mi...@kernel.org
---
kernel/extable.c |2 ++
1 file changed
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in
dumpstack.c.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andrew
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in sched/core.c.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ingo Molnar mi...@redhat.com
Cc: Peter Zijlstra pet...@infradead.org
---
kernel/sched/core.c |6 --
1 file
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation for nmi handlers.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Peter
events/kprobes/foo/enable
# echo -:foo kprobe_events
# head -n 20 trace
# echo 0 events/kprobes/enable
# echo kprobe_events
# echo trace
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h
Use NOKPROBE_SYMBOL() to protect handlers from kprobes
in sample modules.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Ananth N Mavinakayanahalli ana...@in.ibm.com
---
samples/kprobes/jprobe_example.c|1 +
samples/kprobes/kprobe_example.c|3 +++
samples/kprobes
To blacklist the functions in a module (e.g. user-defined
kprobe handler and the functions invoked from it), expand
blacklist support for modules.
With this change, users can use NOKPROBE_SYMBOL() macro in
their own modules.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc
(2013/11/14 23:15), Jon Medhurst (Tixy) wrote:
On Thu, 2013-11-14 at 11:02 +0900, Masami Hiramatsu wrote:
(2013/11/14 2:13), Jon Medhurst (Tixy) wrote:
On Tue, 2013-10-15 at 17:04 -0400, David Long wrote:
From: David A. Long dave.l...@linaro.org
Instead of depending on include/asm/kprobes.h
(2013/11/15 5:33), David Long wrote:
On 11/14/13 09:15, Jon Medhurst (Tixy) wrote:
On Thu, 2013-11-14 at 11:02 +0900, Masami Hiramatsu wrote:
(2013/11/14 2:13), Jon Medhurst (Tixy) wrote:
On Tue, 2013-10-15 at 17:04 -0400, David Long wrote:
From: David A. Long dave.l...@linaro.org
Instead
(2013/11/15 23:28), Frederic Weisbecker wrote:
On Fri, Nov 15, 2013 at 09:15:21AM -0500, Steven Rostedt wrote:
On Fri, 15 Nov 2013 13:28:33 +0100
Peter Zijlstra pet...@infradead.org wrote:
On Fri, Nov 15, 2013 at 10:16:18AM +0900, Masami Hiramatsu wrote:
Kprobes itself can detect nested call
.
- Add blacklist on modules support.
- Add debugfs interface for blacklist.
- Fix indent of the NOKPROBE_SYMBOL() by using tabs.
- Fix NOKPROBE_SYMBOL() for expanding nested macro.
- Update Documentations/kprobes.txt about blacklist.
---
Masami Hiramatsu (23):
kprobes: Prohibit probing
()
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
Cc: Rob Landley r...@landley.net
Cc: Rusty Russell ru...@rustcorp.com.au
---
Documentation/kprobes.txt |8
include/linux/module.h
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in alternative.c.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Jiri Kosina
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in kvm.c.
This also adds kvm_read_and_reset_pf_reason in
the blacklist because it can be called before
do_page_fault.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner
.
update_bitfield_fetch_param
free_bitfield_fetch_param
kprobe_register
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
---
kernel/trace/trace_kprobe.c |2 +-
kernel/trace
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in trap.c.
This also applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by referring
the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Borislav Petkov b...@suse.de
Cc: Fenghua Yu fenghua...@intel.com
Cc: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/kernel/cpu
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in
dumpstack.c.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andrew
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation in x86
kprobes code.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu
Use kprobe_blackpoint for blacklisting .entry.text and .kprobes.text
instead of arch_within_kprobe_blacklist. This also makes them visible
via (debugfs)/kprobes/blacklist.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi
events/kprobes/foo/enable
# echo -:foo kprobe_events
# head -n 20 trace
# echo 0 events/kprobes/enable
# echo kprobe_events
# echo trace
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation for nmi handlers.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Peter
with CONFIG_DEBUG_NOTIFIERS=y.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Andrew Morton a...@linux-foundation.org
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Cc: Borislav Petkov b...@suse.de
Cc: Ingo Molnar mi...@kernel.org
---
kernel/extable.c |2 ++
1 file changed
.
Changes from previous version:
- Rename in_nokprobes_functions to within_kprobe_blacklist
and it returns a bool value istead of an error.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
Cc
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobes annotation in fault.c.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
Use NOKPROBE_SYMBOL macro to protect functions from kprobes
instead of __kprobe annotation in hw_breakpoint.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andrew Morton
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in ftrace.
This applies __always_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Signed-off-by: Masami Hiramatsu masami.hiramatsu
the blacklist.
Changes from previous:
- Introduce arch_within_kprobe_blacklist() which checks
the address is within the .kprobes.text (generic,x86) or
.entry.text (x86), for fixing build issue on !x86.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t
it is good to fix all such bugs
in this series.
This is just the first step to do it. :)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send
(2013/12/02 23:52), David Ahern wrote:
On 12/1/13, 10:59 PM, Masami Hiramatsu wrote:
(2013/12/02 9:07), David Ahern wrote:
When requesting a function from a userspace library the error message to
the user is less than helpful. e.g.,
perf probe -x /lib64/libpthread-2.14.90.so
(2013/12/03 2:55), David Ahern wrote:
On 12/2/13, 7:49 AM, David Ahern wrote:
On 12/1/13, 11:15 PM, Masami Hiramatsu wrote:
(2013/12/02 9:07), David Ahern wrote:
Allow user to specify an address within an executable. This is useful, for
example, in probing local functions. If the function
argument to receive 'void *priv' and make it
set only for uprobes so that we can determine the arg is for kprobes
or uprobes easily.
Suggested-by: Oleg Nesterov o...@redhat.com
Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com
Cc: Oleg
-bit registers.
That is the main difference.
Old BPF was using jt/jf fields for jump-insn only.
New BPF combines them into generic 'off' field for jump and non-jump insns.
k==imm field has the same meaning.
Looks very interesting. :)
Thank you!
--
Masami HIRAMATSU
IT Management Research Dept
,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
,... I want to improve that
after first step is done.
Actually, that part is done by the perf-probe and ftrace dynamic events
(kernel/trace/trace_probe.c). I think this generic BPF is good for
re-implementing fetch methods. :)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux
(2013/12/04 0:58), David Ahern wrote:
On 12/3/13, 2:24 AM, Masami Hiramatsu wrote:
I don't want to make perf-probe just a wrapper of the ftrace dynamic
event interface, because it doesn't add any value for users.
Sure it does -- a consistent user experience in using a single command
(perf
(2013/12/04 0:15), David Ahern wrote:
On 12/2/13, 10:12 PM, Masami Hiramatsu wrote:
That needs to be explicitly stated in the error message -- only global
symbols may be given.
Ah, I see. In that case, I think the variable is not a correct word,
the symbol is better, because perf probe can
NOKPROBE_SYMBOL() macro just
saves the address of non-probe-able symbols.
---
Masami Hiramatsu (6):
kprobes: Prohibit probing on .entry.text code
kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist
[BUGFIX] kprobes/x86: Prohibit probing on debug_stack_*
[BUGFIX] x86: Prohibit
.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: Andi Kleen a...@linux.intel.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Sasha
Since the kprobes uses do_debug for single stepping,
functions called from do_debug before notify_die must
not be probed. This prohibits probing on
native_set_debugreg which is used in do_debug.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Jeremy Fitzhardinge jer
the address of given function instead of
defining a data structure in NOKPROBE_SYMBOL().
- Add _ASM_NOKPROBE macro support for x86.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
Cc: Rob
the blacklist.
Changes from previous:
- Introduce arch_within_kprobe_blacklist() which checks
the address is within the .kprobes.text (generic,x86) or
.entry.text (x86), for fixing build issue on !x86.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t
thunk/restore functions are also used for tracing irqoff etc.
and those are involved in kprobe's exception handling.
Prohibit probing on them to avoid kernel crash.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi
.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Borislav Petkov b...@suse.de
Cc: Fenghua Yu fenghua...@intel.com
Cc: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/kernel/cpu
(2013/12/04 11:54), Sandeepa Prabhu wrote:
On 4 December 2013 06:58, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
Hi,
Here is the version 4 of NOKPORBE_SYMBOL series.
In this version, I removed the cleanup patches and
add bugfixes I've found, since those bugs will be
critical
(2013/12/04 10:44), David Ahern wrote:
On 12/3/13, 6:22 PM, Masami Hiramatsu wrote:
I figured out what you meant by uprobe_events interface yesterday. If I
have to go to that interface for even 1 function I would do it for all
-- from a user perspective it is just simpler to have 1 command
(2013/12/04 17:45), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
Hi,
Here is the version 4 of NOKPORBE_SYMBOL series.
In this version, I removed the cleanup patches and
add bugfixes I've found, since those bugs will be
critical.
Rest of the cleanup
(2013/12/04 17:46), Sandeepa Prabhu wrote:
On 4 December 2013 13:09, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
(2013/12/04 11:54), Sandeepa Prabhu wrote:
On 4 December 2013 06:58, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
Hi,
Here is the version 4
(2013/12/04 10:11), Steven Rostedt wrote:
On Wed, 04 Dec 2013 09:48:44 +0900
Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2013/12/03 13:28), Alexei Starovoitov wrote:
Such filters can be written in C and allow safe read-only access to
any kernel data structure.
Like systemtap
301 - 400 of 10440 matches
Mail list logo
