From: Matt Fleming matt.flem...@intel.com
We're starting to need a channel through which we can funnel EFI
patches to make sure they get merged in a timely fashion. Matthew and
Peter seem happy enough for me to take that bullet.
Signed-off-by: Matt Fleming matt.flem...@intel.com
Cc: H. Peter
From: Matt Fleming matt.flem...@intel.com
This series upgrades real_mode_header-trampoline_pgd to a proper
kernel pagetable instead of just mapping the kernel text and module
space. It also inserts the physical mappings for anything we
ioremap(), so I/O regions are always accessible via
From: Matt Fleming matt.flem...@intel.com
There are various pieces of code in arch/x86 that require a page table
with an identity mapping. Make trampoline_pgd a proper kernel page
table, it currently only includes the kernel text and module space
mapping.
One new feature of trampoline_pgd
From: Matt Fleming matt.flem...@intel.com
Some firmware still needs a 1:1 (virt-phys) mapping even after we've
called SetVirtualAddressMap(). So install the mapping alongside our
existing kernel mapping whenever we make EFI calls in virtual mode.
This bug was discovered on ASUS machines where
with identity mapping. Now
kernel didn't zap the identity mapping page table, so tboot related
code can remove the remapping code before trapping back now.
Signed-off-by: Xiaoyan Zhang xiaoyan.zh...@intel.com
Acked-by: Gang Wei gang@intel.com
Signed-off-by: Matt Fleming matt.flem...@intel.com
On Wed, 2012-10-03 at 14:31 +0100, Jan Beulich wrote:
Matt Fleming m...@console-pimps.org 10/03/12 2:59 PM
+static int insert_identity_mapping(resource_size_t paddr, unsigned long
vaddr,
+unsigned long size)
+{
+unsigned long end = vaddr + size;
+unsigned long
On Thu, 2012-10-04 at 10:24 +0800, Lee, Chun-Yi wrote:
UEFI variable filesystem need a new mount point, so this patch add
efivars kobject to efi_kobj for create a /sys/firmware/efi/efivars
folder.
Cc: Matt Fleming matt.flem...@intel.com
Cc: Jeremy Kerr jeremy.k...@canonical.com
Cc: Matthew
On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote:
On 03.10.12 at 16:03, Matt Fleming matt.flem...@intel.com wrote:
On Wed, 2012-10-03 at 14:31 +0100, Jan Beulich wrote:
Matt Fleming m...@console-pimps.org 10/03/12 2:59 PM
@@ -163,6 +258,10 @@ static void __iomem
*__ioremap_caller
On Fri, 2012-10-05 at 07:39 +0100, Jan Beulich wrote:
On 04.10.12 at 23:08, H. Peter Anvin h...@zytor.com wrote:
On 10/03/2012 06:31 AM, Jan Beulich wrote:
Matt Fleming m...@console-pimps.org 10/03/12 2:59 PM
+static int insert_identity_mapping(resource_size_t paddr, unsigned long
From: Matt Fleming matt.flem...@intel.com
This series upgrades real_mode_header-trampoline_pgd to a proper
kernel pagetable instead of just mapping the kernel text and module
space. It also inserts the physical mappings for anything we
ioremap(), so I/O regions are always accessible via
From: Matt Fleming matt.flem...@intel.com
There are various pieces of code in arch/x86 that require a page table
with an identity mapping. Make trampoline_pgd a proper kernel page
table, it currently only includes the kernel text and module space
mapping.
One new feature of trampoline_pgd
From: Matt Fleming matt.flem...@intel.com
Some firmware still needs a 1:1 (virt-phys) mapping even after we've
called SetVirtualAddressMap(). So install the mapping alongside our
existing kernel mapping whenever we make EFI calls in virtual mode.
This bug was discovered on ASUS machines where
with identity mapping. Now
kernel didn't zap the identity mapping page table, so tboot related
code can remove the remapping code before trapping back now.
Signed-off-by: Xiaoyan Zhang xiaoyan.zh...@intel.com
Acked-by: Gang Wei gang@intel.com
Signed-off-by: Matt Fleming matt.flem...@intel.com
On Fri, 2012-10-05 at 13:54 +0800, Jeremy Kerr wrote:
From: Matthew Garrett m...@redhat.com
The existing EFI variables code only supports variables of up to 1024
bytes. This limitation existed in version 0.99 of the EFI specification,
but was removed before any full releases. Since variables
with the *same* MCE error on your first? That is interesting.
Does anyone have a clue how to diagnose this further? I still think it's
a buggy UEFI implementation, especially since it ships with a CSM. Is it
possible that these MCE errors are non-fatal on Win 7/8?
--
Matt Fleming, Intel Open
stemming from efivars modprobe panicking on a
32/64-bit setup, as well as some reboot issues on similar setups.
Signed-off-by: Olof Johansson o...@lixom.net
Cc: sta...@kernel.org # 3.4 and 3.5
Cc: Matt Fleming matt.flem...@intel.com
Cc: Matthew Garrett m...@redhat.com
---
arch/x86/kernel
From: Matt Fleming matt.flem...@intel.com
We've started getting reports of users seeing Machine Check Exceptions
when booting their Samsung laptops in UEFI mode,
https://bugzilla.kernel.org/show_bug.cgi?id=47121
This module seems to be the culprit as it's grovelling around in the
0xf
Justen jordan.l.jus...@intel.com
Cc: Matt Fleming matt.flem...@intel.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Signed-off-by: Cesar Eduardo Barros ces...@cesarb.net
---
arch/x86/boot/header.S | 3 ---
1 file changed, 3
On Sun, 2012-11-04 at 09:47 -0800, Jonathan Nieder wrote:
Matt Fleming wrote:
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -717,7 +717,7 @@ config XO15_EBOOK
config SAMSUNG_LAPTOP
tristate Samsung Laptop driver
- depends on X86
+ depends
have EFI runtime
services?. The whole thing is a bit of a mess and I'm planning on
cleaning it up this week.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Mon, 2012-11-05 at 11:37 +0100, Greg KH wrote:
On Sun, Nov 04, 2012 at 05:35:06PM +, Matt Fleming wrote:
From: Matt Fleming matt.flem...@intel.com
We've started getting reports of users seeing Machine Check Exceptions
when booting their Samsung laptops in UEFI mode
as I can understand it we should be reserving those areas on a
UEFI booted machine and just marking them as busy so that they are not
available to any drivers to go peering into.
Yes, that would be the best way to resolve this going forward.
--
Matt Fleming, Intel Open Source Technology Center
grovel in places you shouldn't. Indeed its possible EFI should reserve
those memory regions ?
The kernel would have to reserve the gaps in the memory mappings since
there is no mapping in the EFI memory map for 0xf. There is no
support for that currently AFAIK.
--
Matt Fleming, Intel Open
On Sun, 2012-11-04 at 17:44 +, Corentin Chary wrote:
On Sun, Nov 4, 2012 at 5:35 PM, Matt Fleming m...@console-pimps.org wrote:
From: Matt Fleming matt.flem...@intel.com
We've started getting reports of users seeing Machine Check Exceptions
when booting their Samsung laptops in UEFI
From: Matt Fleming matt.flem...@intel.com
Calling __pa() with an ioremap'd address is invalid. If we
encounter an efi_memory_desc_t without EFI_MEMORY_WB set in
-attribute we currently call set_memory_uc(), which in turn
calls __pa() on a potentially ioremap'd address. On
CONFIG_X86_32
On Sat, 2012-10-20 at 08:15 +0800, joeyli wrote:
Hi Matt,
Sorry for bother you!
I didn't see this Matthew's patchset merged in EFI git tree. Do you have
plan to merge it? Or those patches need wait different subsystem leaders
merge.
I don't think it makes sense for the secure boot patch
to Documentation/x86/boot.txt too. But
otherwise,
Acked-by: Matt Fleming matt.flem...@intel.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
to decode this MCE code? It is not covered
in Intel's manuals. Hard to reason without any knowledge.
mcelog should be able to parse your MCE codes.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Thu, 2012-10-04 at 11:01 +0100, Jan Beulich wrote:
On 04.10.12 at 11:18, Matt Fleming matt.flem...@intel.com wrote:
On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote:
Btw., once this set of yours is in - will I need to resubmit the
time handling patch that actually triggered
On Mon, 2012-09-17 at 11:29 +0100, Matt Fleming wrote:
From: Matt Fleming matt.flem...@intel.com
The efi_enabled variable has come to mean Do we have EFI runtime
services available?. However, lack of EFI runtime services does not
mean that we should switch to using the VGA console. Provided
From: Matt Fleming matt.flem...@intel.com
The hostprogs need access to the CONFIG_* symbols found in
include/generated/autoconf.h. commit abbf1590 (UAPI: Partition the
header include path sets and add uapi/ header directories) replaced
$(LINUXINCLUDE) with $(USERINCLUDE) which doesn't contain
On Wed, 2012-10-10 at 16:51 +0100, Matt Fleming wrote:
From: Matt Fleming matt.flem...@intel.com
The hostprogs need access to the CONFIG_* symbols found in
include/generated/autoconf.h. commit abbf1590 (UAPI: Partition the
header include path sets and add uapi/ header directories) replaced
On Thu, 2012-10-11 at 11:32 +0100, Andy Whitcroft wrote:
We have recently been looking to backport the efivarfs support as posted,
to 3.5.x. Inspired by some searching questions from Tetsuo Handa I have
been reviewing this code. The following a first pass at fixing up some
of the error
On Thu, 2012-10-11 at 21:19 +0800, Jeremy Kerr wrote:
Currently, efivarfs does not enforce exclusion over the get_variable and
set_variable operations. Section 7.1 of UEFI requires us to only allow a
single processor to enter {get,set}_variable services at once.
This change acquires the
From: Matt Fleming matt.flem...@intel.com
The hostprogs need access to the CONFIG_* symbols found in
include/generated/autoconf.h. commit abbf1590 (UAPI: Partition the
header include path sets and add uapi/ header directories) replaced
$(LINUXINCLUDE) with $(USERINCLUDE) which doesn't contain
On Fri, 2012-10-12 at 13:03 -0600, Khalid Aziz wrote:
This does not read right. If kzalloc() fails, var will be a NULL
pointer. This code will set err to -ENOMEM and jump to out: where since
err is non-zero, this code will call kfree(Var) but var is a NULL
pointer at this point. Now kfree()
...@lixom.net
Acked-by: Maarten Lankhorst maarten.lankho...@canonical.com
Cc: sta...@kernel.org # 3.4 - 3.6
Cc: Matthew Garrett m...@redhat.com
Applied, thanks!
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
, memmap.nr_map * memmap.desc_size);
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
repository location on kernel.org.
Matt Fleming (1):
MAINTAINERS: Add EFI git repository location
Olof Johansson (1):
x86: efi: Turn off efi_enabled after setup on mixed fw/kernel
MAINTAINERS | 1 +
arch
On Fri, 2012-10-26 at 10:22 +0200, Ingo Molnar wrote:
* Matt Fleming m...@console-pimps.org wrote:
Hi guys,
The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37:
Linux 3.7-rc1 (2012-10-14 14:41:04 -0700)
are available in the git repository
to efi sysfs folder
Matt Fleming (11):
efivarfs: Add documentation for the EFI variable filesystem
x86, mm: Include the entire kernel memory map in trampoline_pgd
x86, efi: 1:1 pagetable mapping for virtual EFI calls
efivarfs: Return an error if we fail to read a variable
On Tue, 2012-11-13 at 14:10 -0800, H. Peter Anvin wrote:
On 11/13/2012 02:00 PM, Matt Fleming wrote:
Hi guys,
The following changes since commit 5189c2a7c7769ee9d037d76c1a7b8550ccf3481c:
x86: efi: Turn off efi_enabled after setup on mixed fw/kernel (2012-10-25
19:09:40 +0100
From: Matt Fleming matt.flem...@intel.com
As things currently stand, traditional EFI boot loaders and the EFI
boot stub are carrying essentially the same initialisation code
required to setup an EFI machine for booting a kernel. There's really
no need to have this code in two places and the hope
On 16/04/13 10:56, joeyli wrote:
I think I just got the same situation on my side with Acer machine. I am
trying Matthew's new patchset hope can avoid this situation:
https://lkml.org/lkml/2013/4/15/473
Please do let us know whether the patches work for you.
--
To unsubscribe from this
On 15/04/13 21:09, Matthew Garrett wrote:
Identical to V5, except with the UCS2 helper functions included this time.
Thanks these looks good to me. I've applied all three patches to the
'urgent' branch.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send
On 16/04/13 15:31, Sergey Vlasov wrote:
The commit efi: Distinguish between remaining space and actually used
space added usage of ucs2_*() functions to arch/x86/platform/efi/efi.c,
but the only thing which selected UCS2_STRING was EFI_VARS, which is
technically optional and can be built as a
On 16/04/13 15:31, Sergey Vlasov wrote:
Fixes build with CONFIG_EFI_VARS=m which was broken after the commit
x86, efivars: firmware bug workarounds should be in platform code.
Signed-off-by: Sergey Vlasov v...@altlinux.ru
---
arch/x86/platform/efi/efi.c | 1 +
1 file changed, 1
From: Matt Fleming matt.flem...@intel.com
drivers/firmware/efivars.c has grown pretty large and is ~2K lines.
Inside efivars.c there's currently,
o code for handling EFI variables at the firmware-level
o sysfs code for exposing EFI variables
o a new EFI variable filesystem
o
From: Matt Fleming matt.flem...@intel.com
Some machines have an EFI variable interface that does not conform to
the UEFI specification, e.g. CONFIG_GOOGLE_SMI. Add the necessary code
so that it's only possible to use one implementation of EFI variable
operations at runtime. This allows us to keep
From: Matt Fleming matt.flem...@intel.com
There are currently two implementations of the utf16 string functions.
Somewhat confusingly, they've got different names.
Centralise the functions in efi.h.
Cc: Tom Gundersen t...@jklm.no
Reviewed-by: Mike Waychison mi...@google.com
Signed-off-by: Matt
From: Matt Fleming matt.flem...@intel.com
efivars.c has grown far too large and needs to be divided up. Create a
new directory and move the persistence storage code to efi-pstore.c now
that it uses the new efivar API. This helps us to greatly reduce the
size of efivars.c and paves the way
From: Matt Fleming matt.flem...@intel.com
Now that efivarfs uses the efivar API, move it out of efivars.c and
into fs/efivarfs where it belongs. This move will eventually allow us
to enable the efivarfs code without having to also enable
CONFIG_EFI_VARS built, and vice versa.
Furthermore, things
From: Matt Fleming matt.flem...@intel.com
drivers/firmware/efivars.c has grown pretty large and is ~2K lines.
Inside efivars.c there's currently,
o code for handling EFI variables at the firmware-level
o sysfs code for exposing EFI variables
o a new EFI variable filesystem
o
From: Matt Fleming matt.flem...@intel.com
Some machines have an EFI variable interface that does not conform to
the UEFI specification, e.g. CONFIG_GOOGLE_SMI. Add the necessary code
so that it's only possible to use one implementation of EFI variable
operations at runtime. This allows us to keep
From: Matt Fleming matt.flem...@intel.com
There are currently two implementations of the utf16 string functions.
Somewhat confusingly, they've got different names.
Centralise the functions in efi.h.
Reviewed-by: Tom Gundersen t...@jklm.no
Tested-by: Tom Gundersen t...@jklm.no
Reviewed-by: Mike
From: Matt Fleming matt.flem...@intel.com
efivars.c has grown far too large and needs to be divided up. Create a
new directory and move the persistence storage code to efi-pstore.c now
that it uses the new efivar API. This helps us to greatly reduce the
size of efivars.c and paves the way
From: Matt Fleming matt.flem...@intel.com
Now that efivarfs uses the efivar API, move it out of efivars.c and
into fs/efivarfs where it belongs. This move will eventually allow us
to enable the efivarfs code without having to also enable
CONFIG_EFI_VARS built, and vice versa.
Furthermore, things
On 04/17/2013 01:30 AM, Tom Gundersen wrote:
Hi Matt,
On Tue, Apr 16, 2013 at 11:41 PM, Matt Fleming m...@console-pimps.org wrote:
This patch series introduces the new efivar_entry API, and splits out the
major
parts of efivars.c into new files. In particular, having the efivarfs code
efi_bgrt_probe(void) { return false; }
#endif /* !CONFIG_ACPI_BGRT */
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On 17/04/13 15:29, Jiri Slaby wrote:
On 04/16/2013 12:11 PM, Matt Fleming wrote:
On 16/04/13 10:56, joeyli wrote:
I think I just got the same situation on my side with Acer machine. I am
trying Matthew's new patchset hope can avoid this situation:
https://lkml.org/lkml/2013/4/15/473
Please
that later.
Thanks!
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
work. We can address this
properly if we ever start seeing i386 machines with bgrt pointers that
reference highmem.
---
From 37ba0d4f43e0f8ec3e3342bc1331e36125495d3e Mon Sep 17 00:00:00 2001
From: Matt Fleming matt.flem...@intel.com
Date: Thu, 18 Apr 2013 09:57:55 +0100
Subject: [PATCH] x86, efi
efisubsystem from efivars (2013-04-17 13:27:06 +0100)
Matt Fleming (5):
efi: move utf16 string functions to efi.h
efivars: Keep a private global pointer to efivars
efivars: efivar_entry API
efivars: Move pstore
an error message if we have EFI Boot services regions we can't
access directly. The error message will at least be useful if we do
start seeing BGRT pointers in highmem.
Could you give it a spin on your MinnowBoard?
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list
of punting. But it sounds like
there aren't any.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
On 04/19/2013 01:18 AM, Darren Hart wrote:
On 04/18/2013 09:19 AM, Matt Fleming wrote:
Could you give it a spin on your MinnowBoard?
I've removed the patch I reference above and applied your patch to my
3.8.4 MinnowBoard dev tree. It panics with:
D'oh. OK, at this point I'm inclined
)
Matt Fleming (1):
x86, efivars: firmware bug workarounds should be in platform code
Matthew Garrett (3):
Move utf16 functions to kernel core and rename
efi: Pass boot services variable info to runtime code
efi: Distinguish between remaining space and actually used
From: Matt Fleming matt.flem...@intel.com
There are currently two implementations of the utf16 string functions.
Somewhat confusingly, they've got different names.
Centralise the functions in efi.h.
Cc: Tom Gundersen t...@jklm.no
Cc: Mike Waychison mi...@google.com
Signed-off-by: Matt Fleming
From: Matt Fleming matt.flem...@intel.com
Some machines have an EFI variable interface that does not conform to the UEFI
specification, e.g. CONFIG_GOOGLE_SMI. Add the necessary code and Kconfig glue
so that it's only possible to select one implementation of EFI variable
operations. This allows
From: Matt Fleming matt.flem...@intel.com
drivers/firmware/efivars.c has grown pretty large and is ~2K lines.
Inside efivars.c there's currently,
o code for handling EFI variables at the firmware-level
o sysfs code for exposing EFI variables
o a new EFI variable filesystem
o
From: Matt Fleming matt.flem...@intel.com
Now that efivarfs uses the efivar API, move it out of efivars.c and into
fs/efivarfs where it belongs. This move will eventually allow us to enable the
efivarfs code without having to also enable CONFIG_EFI_VARS built, and vice
versa.
Furthermore, things
From: Matt Fleming matt.flem...@intel.com
efivars.c has grown far too large and needs to be divided up. Create a new
directory and move the persistence storage code to efi-pstore.c now that it
uses the new efivar API. This helps us to greatly reduce the size of efivars.c
and paves the way
On 04/04/13 17:12, Richard Weinberger wrote:
Fair point. I'll add such a printk() to my patch and resend.
Also take a look at FW_BUG.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 03/04/13 11:28, Matt Fleming wrote:
I applied this by hand. Your patch appears to be whitespace damaged. Also, I
expanded the commit message and turned it into,
efi: fix typo in Makefile
commit 9dead5bbb825 (efi: Build EFI stub with EFI-appropriate options)
contains a typo which
()
arch/x86/platform/efi/efi.c | 19 ++-
drivers/firmware/efivars.c |8 +---
2 files changed, 11 insertions(+), 16 deletions(-)
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
deletion(-)
You need to make it clear that enabling this option may brick your
machine if your firmware is buggy.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On 09/04/13 17:25, H. Peter Anvin wrote:
On 04/04/2013 05:18 AM, Matt Fleming wrote:
From: Matt Fleming matt.flem...@intel.com
drivers/firmware/efivars.c has grown pretty large and is ~2K lines.
Hi Matt,
Are you expecting me or Matt G. to take this one?
I was going to send it to you
.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
?
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
add (size !ret) checking?
If the purpose of this patch is just adding new API, we don't need to modify
the logic.
That looks like a bug that slipped in. I'll fix it. Thanks!
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux
On 10/04/13 09:59, Richard Weinberger wrote:
Some EFI implementations return always a MaximumVariableSize of 0,
check against max_size only if it is non-zero.
My Intel DQ67SW desktop board has such an implementation.
Signed-off-by: Richard Weinberger rich...@nod.at
---
On 10/04/13 09:59, Richard Weinberger wrote:
Using this parameter one can disable the storage_size/2 check if
he is really sure that the UEFI does sane gc and fulfills the spec.
This parameter is useful if a devices uses more than 50% of the
storage by default.
The Intel DQSW67 desktop
On 12/04/13 11:16, Lingzhu Xiang wrote:
On 04/11/2013 01:46 AM, Matthew Garrett wrote:
ops.query_variable_store = efi_query_variable_store;
Can't apply here. ops.query_variable_info = efi.query_variable_info?
It's against the 'urgent' branch at,
9dead5bbb825 (efi: Build EFI stub with EFI-appropriate options)
contains a typo which means that the efi_stub_$(BITS).o code is still not
compiled with -fshort-wchar and -mno-red-zone.
Fix it with s/KBUILD_CLFAGS/KBUILD_CFLAGS/
--
Matt Fleming, Intel Open Source Technology Center
.
Introducing new features via the EFI boot stub is fine, and working
around firmware bugs so that we can use some feature is also cool, but
we can't start fixing regressions from other subsystems in the EFI boot
stub.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from
that this isn't the way to
go.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On 03/04/13 14:48, Matthew Garrett wrote:
On Wed, 2013-04-03 at 14:11 +0100, Matt Fleming wrote:
This looks like something that will differ between implementations, and the
fact that it's appearing in our code is a sure sign that this isn't the way
to
go.
Our choices right now are:
1
think your original patch
is better for backward compatible on variable name.
Please consider to merge your original patch!
OK, this is what I've got queued up (note I removed the warning).
---
From afa9ae7bf47145d661487f88f2ec67b062ca98bc Mon Sep 17 00:00:00 2001
From: Matt Fleming matt.flem
;
+ efi_status_t status;
+ u64 pa_data = boot_params.hdr.setup_data;
+ int found = 0;
Why not make found a boolean?
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
implementations
of GetNextVariableName() which resulted in machines hanging and
sysfs files being created with garbage names.
Matt Fleming (2):
efivars: explicitly calculate length of VariableName
efivars: Handle
On Mon, 2013-03-11 at 16:17 -0500, Seth Forshee wrote:
Here's a patch that does the command line option. I'm happy with either
one.
I like the idea, but isn't the logic backwards? I would have expected
s/EFI_VARS_PSTORE_DEFAULT_DISABLE/EFI_VARS_PSTORE/g and then 'default y'
in the Kconfig file
On Tue, 2013-03-12 at 16:14 -0500, Seth Forshee wrote:
From 91df4dd0d1e20f44ea16b3653cffecd507fdb500 Mon Sep 17 00:00:00 2001
From: Seth Forshee seth.fors...@canonical.com
Date: Wed, 6 Mar 2013 14:25:36 -0600
Subject: [PATCH] efivars: Add module parameter to allow disabling use as a
pstore
On Wed, 2013-03-13 at 10:25 -0700, H. Peter Anvin wrote:
I think there should be two compile-time options (one to compile in the
EFI pstore code at all, and one to set its default.)
OK, sorry Seth, looks like I'm the one that misunderstood. I've picked
up your first two patches and pushed them
On Wed, 2013-03-13 at 14:14 -0500, Seth Forshee wrote:
On Wed, Mar 13, 2013 at 06:33:37PM +, Matt Fleming wrote:
On Wed, 2013-03-13 at 10:25 -0700, H. Peter Anvin wrote:
I think there should be two compile-time options (one to compile in the
EFI pstore code at all, and one to set its
On Sat, 2013-03-02 at 19:40 -0500, Matthew Garrett wrote:
UEFI variables are typically stored in flash. For various reasons, avaiable
space is typically not reclaimed immediately upon the deletion of a
variable - instead, the system will garbage collect during initialisation
after a reboot.
On Wed, 2013-03-06 at 15:34 +0800, joeyli wrote:
Hi Matt,
於 六，2013-03-02 於 07:41 +0800，joeyli 提到：
於 五，2013-03-01 於 16:31 +，Matt Fleming 提到：
On Fri, 2013-03-01 at 15:17 +, Matt Fleming wrote:
On Fri, 2013-03-01 at 11:20 +0800, Lee, Chun-Yi wrote:
From: Michael Schroeder m
) - 1];
+ if (c)
+ len += sizeof(c);
+ } while (c);
+
+ return len;
+}
+
It looks like this function can be replaced with utf16_strsize.
Nearly. For this particular case we also need to count the terminating
NULL.
--
Matt Fleming, Intel Open Source
On Wed, 2013-03-06 at 12:58 +0100, Frederic Crozat wrote:
Le mercredi 06 mars 2013 à 11:19 +, Matt Fleming a écrit :
Also, which machine did you see this behaviour on?
HP z220 desktop, System BIOS K51 v 1.54
this issue is only the Secure Boot related variables, which make me
think
On Wed, 2013-03-06 at 14:30 +0100, Frederic Crozat wrote:
Le mercredi 06 mars 2013 à 12:36 +, Matt Fleming a écrit :
On Wed, 2013-03-06 at 12:58 +0100, Frederic Crozat wrote:
Le mercredi 06 mars 2013 à 11:19 +, Matt Fleming a écrit :
Also, which machine did you see
.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
1 - 100 of 4043 matches
Mail list logo
