Re: [rfc patch] sched/fair: Use instantaneous load for fork/exec balancing

On Mon, 04 Jul, at 07:43:14PM, Mike Galbraith wrote: > On Mon, 2016-07-04 at 16:04 +0100, Matt Fleming wrote: > > > But we can optimise the special case of dequeueing the last entity and > > reset ::runnable_load_avg early, which gives a performance improvement > > t

Re: [rfc patch] sched/fair: Use instantaneous load for fork/exec balancing

runnable_load_avg > se->avg.load_avg even if 'se' is the only task on the runqueue. FYI, below is my quick and dirty hack that restored hackbench performance for the few machines I checked. I didn't try schbench with it. --- >From 4e9856ea3dc56e356195ca035dab7302754ce59b Mon Sep 17

Re: [rfc patch] sched/fair: Use instantaneous load for fork/exec balancing

runnable_load_avg > se->avg.load_avg even if 'se' is the only task on the runqueue. FYI, below is my quick and dirty hack that restored hackbench performance for the few machines I checked. I didn't try schbench with it. --- >From 4e9856ea3dc56e356195ca035dab7302754ce59b Mon Sep 17

Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer

On Mon, 27 Jun, at 01:00:50PM, Ingo Molnar wrote: > > Note that while at it I renamed 'flags' to '__flags' because 'flags' is > a commonly used variable name and the 'efi_status_t __s' variable was > macro-prefixed already. > > Any objections? Nope, that's fine.

Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer

On Mon, 27 Jun, at 01:00:50PM, Ingo Molnar wrote: > > Note that while at it I renamed 'flags' to '__flags' because 'flags' is > a commonly used variable name and the 'efi_status_t __s' variable was > macro-prefixed already. > > Any objections? Nope, that's fine.

Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

On Mon, 27 Jun, at 12:49:20PM, Ingo Molnar wrote: > The other weirdness is the misalignment of the '0xe' portion here: > > #define LINUX_EFI_ARM_SCREEN_INFO_TABLE_GUID EFI_GUID(0xe03fc20a, 0x85dc, > 0x406e, 0xb9, 0xe, 0x4a, 0xb5, 0x02, 0x37, 0x1d, 0x95) > #define LINUX_EFI_LOADER_ENTRY_GUID

Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

On Mon, 27 Jun, at 12:49:20PM, Ingo Molnar wrote: > The other weirdness is the misalignment of the '0xe' portion here: > > #define LINUX_EFI_ARM_SCREEN_INFO_TABLE_GUID EFI_GUID(0xe03fc20a, 0x85dc, > 0x406e, 0xb9, 0xe, 0x4a, 0xb5, 0x02, 0x37, 0x1d, 0x95) > #define LINUX_EFI_LOADER_ENTRY_GUID

Re: [PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code

On Fri, 24 Jun, at 01:44:48PM, Ard Biesheuvel wrote: > > This assignment breaks the calculation of mapsize in > arm_enable_runtime_services(), so you should probably fold the > following hunk into this patch. > > diff --git a/drivers/firmware/efi/arm-runtime.c >

Re: [PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code

On Fri, 24 Jun, at 01:44:48PM, Ard Biesheuvel wrote: > > This assignment breaks the calculation of mapsize in > arm_enable_runtime_services(), so you should probably fold the > following hunk into this patch. > > diff --git a/drivers/firmware/efi/arm-runtime.c >

Re: [PATCH v5 6/8] efi: load SSTDs from EFI variables

(Sorry, didn't get chance to reply before you sent this version) On Fri, 01 Jul, at 11:19:10PM, Octavian Purdila wrote: > + > +static __init int efivar_ssdt_load(void) > +{ > + struct efivar_entry *entry; > + /* We need a temporary empty list to be able to set duplicates > + * to

Re: [PATCH v5 6/8] efi: load SSTDs from EFI variables

(Sorry, didn't get chance to reply before you sent this version) On Fri, 01 Jul, at 11:19:10PM, Octavian Purdila wrote: > + > +static __init int efivar_ssdt_load(void) > +{ > + struct efivar_entry *entry; > + /* We need a temporary empty list to be able to set duplicates > + * to

[PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer

t; <h...@zytor.com> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Roy Franz <roy.fr...@linaro.org> Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: x...@kernel.org Signed-off-by: Matt Fleming <m...@codebluepr

[PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer

Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Ard Biesheuvel Cc: Mark Rutland Cc: Roy Franz Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: x...@kernel.org Signed-off-by: Matt Fleming --- arch/arm/include/asm/efi.h | 4 +--

[PATCH 6/7] x86/efi: Update efi_thunk to use the the arch_efi_call_virt* macros

.@sgi.com> Suggested-by: Matt Fleming <m...@codeblueprint.co.uk> Cc: Russ Anderson <r...@sgi.com> Cc: Dimitri Sivanich <sivan...@sgi.com> Cc: Russell King <li...@armlinux.org.uk> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Will Deacon <will.dea...@arm.com> C

[PATCH 5/7] x86/uv: Update uv_bios_call to use efi_call_virt_pointer

t;will.dea...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Roy Franz <roy.fr...@linar

[PATCH 6/7] x86/efi: Update efi_thunk to use the the arch_efi_call_virt* macros

From: Alex Thorlton Currently, the efi_thunk macro has some semi-duplicated code in it that can be replaced with the arch_efi_call_virt_setup/teardown macros. This commit simply replaces the duplicated code with those macros. Signed-off-by: Alex Thorlton Suggested-by: Matt Fleming Cc: Russ

[PATCH 5/7] x86/uv: Update uv_bios_call to use efi_call_virt_pointer

.infradead.org Cc: linux-...@vger.kernel.org Cc: x...@kernel.org Signed-off-by: Matt Fleming --- arch/x86/platform/uv/bios_uv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c index 815fec6e05e2..66b2166ea4a1 100644 -

[PATCH 7/7] x86/efi: Remove unused efi_get_time function

d Biesheuvel <ard.biesheu...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@kernel.org> Cc: "H. Peter Anvin" <h...@zytor.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/platform/efi/efi.c | 15

[PATCH 7/7] x86/efi: Remove unused efi_get_time function

Molnar Cc: "H. Peter Anvin" Signed-off-by: Matt Fleming --- arch/x86/platform/efi/efi.c | 15 --- include/linux/efi.h | 1 - 2 files changed, 16 deletions(-) diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index f93545e7dc54..d898b334f

[PATCH 3/7] x86/efi: Remove unused variable efi

. Peter Anvin" <h...@zytor.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@kernel.org> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/boot/compressed/eboot.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/boot/compres

[PATCH 3/7] x86/efi: Remove unused variable efi

From: Colin Ian King Remove unused variable efi, it is never used. Fixes clang build warning: arch/x86/boot/compressed/eboot.c:803:2: warning: Value stored to 'efi' is never read Signed-off-by: Colin Ian King Cc: "H. Peter Anvin" Cc: Thomas Gleixner Cc: Ingo Molnar Signed-of

[PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

't get me anywhere towards making that work. Signed-off-by: Peter Jones <pjo...@redhat.com> Cc: Joe Perches <j...@perches.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- include/linux/efi.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff

[GIT PULL 0/7] EFI changes for v4.8

Folks, please pull the v4.8 EFI queue. Included are some cleanups and fixes for SGI/UV BIOS calls. The following changes since commit 5edb56491d4812c42175980759da53388e5d86f5: Linux 4.7-rc3 (2016-06-12 07:20:35 -0700) are available in the git repository at:

[PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

rds making that work. Signed-off-by: Peter Jones Cc: Joe Perches Signed-off-by: Matt Fleming --- include/linux/efi.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/linux/efi.h b/include/linux/efi.h index f196dd0b0f2f..03009695760d 100644 --- a/inclu

[GIT PULL 0/7] EFI changes for v4.8

Folks, please pull the v4.8 EFI queue. Included are some cleanups and fixes for SGI/UV BIOS calls. The following changes since commit 5edb56491d4812c42175980759da53388e5d86f5: Linux 4.7-rc3 (2016-06-12 07:20:35 -0700) are available in the git repository at:

[PATCH 1/7] efibc: Report more information in the error messages

inaro.org> Cc: Arnd Bergmann <a...@arndb.de> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- drivers/firmware/efi/efibc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c index 8dd0c7085e59..56

[PATCH 1/7] efibc: Report more information in the error messages

or message. Signed-off-by: Jeremy Compostella Reported-by: Robert Elliott Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Ard Biesheuvel Cc: Arnd Bergmann Signed-off-by: Matt Fleming --- drivers/firmware/efi/efibc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/fi

Re: [PATCH] x86: fix unused efi_get_time function

On Fri, 17 Jun, at 04:51:29PM, Arnd Bergmann wrote: > Nothing calls the efi_get_time function on x86, but it does suffer > from the 32-bit time_t overflow in 2038. > > To avoid that if anyone starts calling it, this changes the function > to use timespec64 and mktime64 instead. > >

Re: [PATCH] x86: fix unused efi_get_time function

On Fri, 17 Jun, at 04:51:29PM, Arnd Bergmann wrote: > Nothing calls the efi_get_time function on x86, but it does suffer > from the 32-bit time_t overflow in 2038. > > To avoid that if anyone starts calling it, this changes the function > to use timespec64 and mktime64 instead. > >

Re: [PATCH v4 6/8] efi: load SSTDs from EFI variables

On Fri, 17 Jun, at 02:52:14PM, Octavian Purdila wrote: > This patch allows SSDTs to be loaded from EFI variables. It works by > specifying the EFI variable name containing the SSDT to be loaded. All > variables with the same name (regardless of the vendor GUID) will be > loaded. > > Note that we

Re: [PATCH v4 6/8] efi: load SSTDs from EFI variables

On Fri, 17 Jun, at 02:52:14PM, Octavian Purdila wrote: > This patch allows SSDTs to be loaded from EFI variables. It works by > specifying the EFI variable name containing the SSDT to be loaded. All > variables with the same name (regardless of the vendor GUID) will be > loaded. > > Note that we

Re: [RFC PATCH 08/11] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE

On Thu, 16 Jun, at 09:49:32AM, Yuyang Du wrote: > SD_BALANCE_{FORK|EXEC|WAKE} flags are for select_task_rq() to select a > CPU to run a new task or a waking task. SD_WAKE_AFFINE is a flag to > try selecting the waker CPU to run the waking task. > > SD_BALANCE_WAKE is not a sched_domain flag, but

Re: [RFC PATCH 08/11] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE

On Thu, 16 Jun, at 09:49:32AM, Yuyang Du wrote: > SD_BALANCE_{FORK|EXEC|WAKE} flags are for select_task_rq() to select a > CPU to run a new task or a waking task. SD_WAKE_AFFINE is a flag to > try selecting the waker CPU to run the waking task. > > SD_BALANCE_WAKE is not a sched_domain flag, but

Re: [PATCHv2 0/3] x86/UV, x86/efi: Re-factor efi_call_virt for general use

On Wed, 15 Jun, at 02:04:12PM, Alex Thorlton wrote: > Hey guys, > > This patchset creates a general purpose version of the efi_call_virt > macro that does not assume that the function pointer being passed in is > inside of efi.systab->runtime. It also fixes up uv_bios_call to use the > new

Re: [PATCHv2 0/3] x86/UV, x86/efi: Re-factor efi_call_virt for general use

On Wed, 15 Jun, at 02:04:12PM, Alex Thorlton wrote: > Hey guys, > > This patchset creates a general purpose version of the efi_call_virt > macro that does not assume that the function pointer being passed in is > inside of efi.systab->runtime. It also fixes up uv_bios_call to use the > new

[PATCH 01/11] x86/efi: Test for EFI_MEMMAP functionality when iterating EFI memmap

m> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/kernel/setup.c | 13 ++--- drivers/firmware/efi/fake_mem.c | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/set

[PATCH 01/11] x86/efi: Test for EFI_MEMMAP functionality when iterating EFI memmap

, merge everything under one if() conditional, and remove the now superfluous check from efi_fake_memmap(). Cc: Taku Izumi Cc: Tony Luck Cc: Xishi Qiu Cc: Kamezawa Hiroyuki Cc: Ard Biesheuvel Signed-off-by: Matt Fleming --- arch/x86/kernel/setup.c | 13 ++--- drivers/firmware

[PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code

o...@redhat.com> Cc: Borislav Petkov <b...@alien8.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/include/asm/efi.h | 1 - arch/x86/platform/efi/efi.c | 66 +

[PATCH 00/11] efi: Permanent runtime EFI memmap support

This series adds support for keeping the EFI memory map around at runtime for x86 (ARM and arm64 already have this support). Additionally, drivers can now reserve EFI boot services regions such that they are not released back to the kernel during efi_free_boot_services(). With these two features

[PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code

-by: Matt Fleming --- arch/x86/include/asm/efi.h | 1 - arch/x86/platform/efi/efi.c | 66 +++-- arch/x86/platform/efi/quirks.c | 4 +-- drivers/firmware/efi/arm-init.c | 17 +-- drivers/firmware/efi/efi.c | 46

[PATCH 00/11] efi: Permanent runtime EFI memmap support

This series adds support for keeping the EFI memory map around at runtime for x86 (ARM and arm64 already have this support). Additionally, drivers can now reserve EFI boot services regions such that they are not released back to the kernel during efi_free_boot_services(). With these two features

[PATCH 07/11] efi: Add efi_memmap_install() for installing new EFI memory maps

lt;mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Cc: Taku Izumi <izumi.t...@jp.fujitsu.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- drivers/firmware/efi/fake_mem.c | 8 +--- drivers/firmware/efi/memmap.c | 25 + include

[PATCH 06/11] efi: Split out EFI memory map functions into new file

<ard.biesheu...@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Peter Jones <pjo...@redhat.com> Cc: Borislav Petkov <b...@alien8.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Cc: Taku Izumi <izumi.t...@jp.fuji

[PATCH 07/11] efi: Add efi_memmap_install() for installing new EFI memory maps

() abstracts the details of how the new memory map should be mapped and the existing one unmapped. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Cc: Taku Izumi Signed-off-by: Matt Fleming --- drivers/firmware/efi/fake_mem.c | 8

[PATCH 06/11] efi: Split out EFI memory map functions into new file

Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Cc: Taku Izumi Signed-off-by: Matt Fleming --- drivers/firmware/efi/Makefile | 2 +- drivers/firmware/efi/efi.c | 129 --- drivers/firmware/efi/fake_mem.c | 143

[PATCH 10/11] efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()

: Leif Lindholm <leif.lindh...@linaro.org> Cc: Peter Jones <pjo...@redhat.com> Cc: Borislav Petkov <b...@alien8.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk

[PATCH 08/11] efi: Allow drivers to reserve boot services forever

c: Borislav Petkov <b...@alien8.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/platform/efi/quirks.c | 121 + drivers/firmware/efi

[PATCH 11/11] x86/efi-bgrt: Use efi_mem_reserve() to avoid copying image data

<jwbo...@fedoraproject.org> Cc: Josh Triplett <j...@joshtriplett.org> Cc: Andy Lutomirski <l...@amacapital.net> Cc: Môshe van der Sterre <m...@moshe.nl> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/platform/efi/efi-bgrt.c | 13 ++--- 1 fil

[PATCH 10/11] efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()

Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Signed-off-by: Matt Fleming --- drivers/firmware/efi/esrt.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 75feb3f5829b..b93cd11f9bcc

[PATCH 08/11] efi: Allow drivers to reserve boot services forever

kernel to access the same boot services regions that the initial boot kernel had access to unless they are reserved by every kexec kernel in the chain. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Signed-off-by: Matt Fleming

[PATCH 11/11] x86/efi-bgrt: Use efi_mem_reserve() to avoid copying image data

reboot. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Cc: Josh Boyer Cc: Josh Triplett Cc: Andy Lutomirski Cc: Môshe van der Sterre Signed-off-by: Matt Fleming --- arch/x86/platform/efi/efi-bgrt.c | 13 ++--- 1 file

[PATCH 09/11] efi/runtime-map: Use efi.memmap directly instead of a copy

rm.com> Cc: Dave Young <dyo...@redhat.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/platform/efi/efi.c| 40 -- drivers/firmware/efi/runtime-map.c | 35 + include/linux/efi.h

[PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap

t;leif.lindh...@linaro.org> Cc: Peter Jones <pjo...@redhat.com> Cc: Borislav Petkov <b...@alien8.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Dave Young <dyo...@redhat.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- arch/x86/platform/efi/efi.c

[PATCH 09/11] efi/runtime-map: Use efi.memmap directly instead of a copy

services across kexec reboot so that the ESRT and BGRT drivers will now work. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Signed-off-by: Matt Fleming --- arch/x86/platform/efi/efi.c| 40

[PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap

Cc: Mark Rutland Cc: Dave Young Signed-off-by: Matt Fleming --- arch/x86/platform/efi/efi.c| 46 + arch/x86/platform/efi/quirks.c | 2 - drivers/firmware/efi/arm-runtime.c | 4 +- drivers/firmware/efi/efi.c | 135 ++--- include/li

[PATCH 05/11] efi/fake_mem: Refactor main two code chunks into functions

aku Izumi <izumi.t...@jp.fujitsu.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> --- drivers/firmware/efi/fake_mem.c | 229 +++- 1 file changed, 134 insertions(+), 95 deletions(-) diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware

[PATCH 02/11] x86/efi: Consolidate region mapping logic

() and refactor the test for which regions should be mapped into a should_map_region() function. Generously sprinkle comments to clarify the different cases. Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Borislav Petkov <b...@alien8.de> Signed-off-by: Matt Fleming <m...@codeblueprint.c

[PATCH 05/11] efi/fake_mem: Refactor main two code chunks into functions

functions later. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Peter Jones Cc: Borislav Petkov Cc: Mark Rutland Cc: Dave Young Cc: Taku Izumi Signed-off-by: Matt Fleming --- drivers/firmware/efi/fake_mem.c | 229 +++- 1 file changed, 134 insertions(+), 95

[PATCH 02/11] x86/efi: Consolidate region mapping logic

() and refactor the test for which regions should be mapped into a should_map_region() function. Generously sprinkle comments to clarify the different cases. Cc: Ard Biesheuvel Cc: Borislav Petkov Signed-off-by: Matt Fleming --- arch/x86/platform/efi/efi.c| 50

Re: [PATCH v3 03/13] x86/mm: Remove kernel_unmap_pages_in_pgd() and efi_cleanup_page_tables()

nup_page_tables(), and that, in turn, > was unused, so just delete both functions. This leaves a couple of > other helpers unused, so delete them, too. > > Cc: Matt Fleming <m...@codeblueprint.co.uk> > Cc: linux-...@vger.kernel.org > Signed-off-by: Andy Lutomirski <l...@kerne

Re: [PATCH v3 03/13] x86/mm: Remove kernel_unmap_pages_in_pgd() and efi_cleanup_page_tables()

nup_page_tables(), and that, in turn, > was unused, so just delete both functions. This leaves a couple of > other helpers unused, so delete them, too. > > Cc: Matt Fleming > Cc: linux-...@vger.kernel.org > Signed-off-by: Andy Lutomirski > --- > arch/x86/include/asm/efi.h

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 16 Jun, at 09:38:31AM, Tom Lendacky wrote: > > Ok, I think this was happening before the commit to build our own > EFI page table structures: > > commit 67a9108ed ("x86/efi: Build our own page table structures") > > Before this commit the boot services ended up mapped into the kernel >

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 16 Jun, at 09:38:31AM, Tom Lendacky wrote: > > Ok, I think this was happening before the commit to build our own > EFI page table structures: > > commit 67a9108ed ("x86/efi: Build our own page table structures") > > Before this commit the boot services ended up mapped into the kernel >

Re: [PATCH v5 4/5] sched/fair: Skip detach sched avgs for new task when changing task groups

On Thu, 09 Jun, at 07:15:53AM, Yuyang Du wrote: > Newly forked task has not been enqueued, so should not be removed from > cfs_rq in task_move_group_fair(). To do so, we identify newly forked > tasks by their sched_avg's last_update_time in detach_entity_load_avg(). > > Signed-off-by: Yuyang Du

Re: [PATCH v5 4/5] sched/fair: Skip detach sched avgs for new task when changing task groups

On Thu, 09 Jun, at 07:15:53AM, Yuyang Du wrote: > Newly forked task has not been enqueued, so should not be removed from > cfs_rq in task_move_group_fair(). To do so, we identify newly forked > tasks by their sched_avg's last_update_time in detach_entity_load_avg(). > > Signed-off-by: Yuyang Du

Re: [PATCH v5 1/5] sched/fair: Clean up attach_entity_load_avg()

hange. > > Signed-off-by: Yuyang Du <yuyang...@intel.com> > --- > kernel/sched/fair.c | 43 --- > 1 file changed, 20 insertions(+), 23 deletions(-) Looks OK to me and makes the code easier to understand. Chasing ->avg.last_update_ti

Re: [PATCH v5 1/5] sched/fair: Clean up attach_entity_load_avg()

hange. > > Signed-off-by: Yuyang Du > --- > kernel/sched/fair.c | 43 --- > 1 file changed, 20 insertions(+), 23 deletions(-) Looks OK to me and makes the code easier to understand. Chasing ->avg.last_update_time values is tricky at the best of times. Reviewed-by: Matt Fleming

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

On Sun, 12 Jun, at 02:37:26PM, Lukas Wunner wrote: > > Resetting the card solves the problem at the root and fixes both, > the spurious interrupts and the memory corruption. It also avoids the need to figure out exactly which Boot Services regions may have become corrupt. This would be

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

On Sun, 12 Jun, at 02:37:26PM, Lukas Wunner wrote: > > Resetting the card solves the problem at the root and fixes both, > the spurious interrupts and the memory corruption. It also avoids the need to figure out exactly which Boot Services regions may have become corrupt. This would be

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 09 Jun, at 01:33:30PM, Tom Lendacky wrote: > > I was trying to play it safe here, but as you say, the firmware should > be using our page tables so we can get rid of this call. The problem > will actually be if we transition to a 32-bit efi. The encryption bit > will be lost in cr3 and so

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 09 Jun, at 01:33:30PM, Tom Lendacky wrote: > > I was trying to play it safe here, but as you say, the firmware should > be using our page tables so we can get rid of this call. The problem > will actually be if we transition to a 32-bit efi. The encryption bit > will be lost in cr3 and so

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Mon, 13 Jun, at 01:03:22PM, Matt Fleming wrote: > > Would we need a new function? Couldn't we just have a new > FIXMAP_PAGE_* constant? e.g. would something like this work? > > --- > > enum memremap_owner { > KERNEL_DATA = 0, > BOOT_DATA, > }; >

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Mon, 13 Jun, at 01:03:22PM, Matt Fleming wrote: > > Would we need a new function? Couldn't we just have a new > FIXMAP_PAGE_* constant? e.g. would something like this work? > > --- > > enum memremap_owner { > KERNEL_DATA = 0, > BOOT_DATA, > }; >

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 09 Jun, at 11:16:40AM, Tom Lendacky wrote: > > So maybe something along the lines of an enum that would have entries > (initially) like KERNEL_DATA (equal to zero) and EFI_DATA. Others could > be added later as needed. Sure, that works for me, though maybe BOOT_DATA would be more

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Thu, 09 Jun, at 11:16:40AM, Tom Lendacky wrote: > > So maybe something along the lines of an enum that would have entries > (initially) like KERNEL_DATA (equal to zero) and EFI_DATA. Others could > be added later as needed. Sure, that works for me, though maybe BOOT_DATA would be more

Re: [PATCH] [efifb] Fix 16 color palette entry calculation

On Tue, 07 Jun, at 01:23:05PM, Peter Jones wrote: > > Looks right to me. > > Acked-By: Peter Jones Tomi, are you OK to take this one or would you like me to take it through the EFI tree?

Re: [PATCH] [efifb] Fix 16 color palette entry calculation

On Tue, 07 Jun, at 01:23:05PM, Peter Jones wrote: > > Looks right to me. > > Acked-By: Peter Jones Tomi, are you OK to take this one or would you like me to take it through the EFI tree?

Re: [PATCH] x86/efi: remove unused variable efi

On Mon, 06 Jun, at 03:32:11PM, Colin Ian King wrote: > From: Colin Ian King > > Remove unused variable efi, it is never used. Fixes clang build > warning: > > arch/x86/boot/compressed/eboot.c:803:2: warning: Value stored to > 'efi' is never read > > Signed-off-by:

Re: [PATCH] x86/efi: remove unused variable efi

On Mon, 06 Jun, at 03:32:11PM, Colin Ian King wrote: > From: Colin Ian King > > Remove unused variable efi, it is never used. Fixes clang build > warning: > > arch/x86/boot/compressed/eboot.c:803:2: warning: Value stored to > 'efi' is never read > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH] x86/efi: Auto enable EFI memmap on SGI UV systems

anything that kstringtobool > will determine to be false. > > Signed-off-by: Joseph Thelen <jthe...@sgi.com> > Cc: Alex Thorlton <athorl...@sgi.com> > Cc: Matt Fleming <m...@codeblueprint.co.uk> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar &l

Re: [PATCH] x86/efi: Auto enable EFI memmap on SGI UV systems

anything that kstringtobool > will determine to be false. > > Signed-off-by: Joseph Thelen > Cc: Alex Thorlton > Cc: Matt Fleming > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x...@kernel.org > Cc: linux-...@vger.kernel.org > --- &

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Tue, 26 Apr, at 05:57:40PM, Tom Lendacky wrote: > The EFI tables are not encrypted and need to be accessed as such. Be sure > to memmap them without the encryption attribute set. For EFI support that > lives outside of the arch/x86 tree, create a routine that uses the __weak > attribute so that

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

On Tue, 26 Apr, at 05:57:40PM, Tom Lendacky wrote: > The EFI tables are not encrypted and need to be accessed as such. Be sure > to memmap them without the encryption attribute set. For EFI support that > lives outside of the arch/x86 tree, create a routine that uses the __weak > attribute so that

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

(Sorry for the delay) On Thu, 26 May, at 08:45:58AM, Tom Lendacky wrote: > > The patch in question is patch 6/18 where PAGE_KERNEL is changed to > include the _PAGE_ENC attribute (the encryption mask). This now > makes FIXMAP_PAGE_NORMAL contain the encryption mask while > FIXMAP_PAGE_IO does

Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear

(Sorry for the delay) On Thu, 26 May, at 08:45:58AM, Tom Lendacky wrote: > > The patch in question is patch 6/18 where PAGE_KERNEL is changed to > include the _PAGE_ENC attribute (the encryption mask). This now > makes FIXMAP_PAGE_NORMAL contain the encryption mask while > FIXMAP_PAGE_IO does

Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg()

On Mon, 06 Jun, at 03:40:18PM, Vincent Guittot wrote: > > The load average stuff is only enable for SMP system but it's not used > for UP system. Duh, right. My bad.

Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg()

On Mon, 06 Jun, at 03:40:18PM, Vincent Guittot wrote: > > The load average stuff is only enable for SMP system but it's not used > for UP system. Duh, right. My bad.

Re: [PATCH v4 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups

On Mon, 06 Jun, at 08:20:39AM, Yuyang Du wrote: > Newly forked task has not been enqueued, so should not be removed from > cfs_rq in task_move_group_fair(). To do so, we need to pass the fork > information all the way from sched_move_task() to task_move_group_fair(). > > Signed-off-by: Yuyang Du

Re: [PATCH v4 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups

On Mon, 06 Jun, at 08:20:39AM, Yuyang Du wrote: > Newly forked task has not been enqueued, so should not be removed from > cfs_rq in task_move_group_fair(). To do so, we need to pass the fork > information all the way from sched_move_task() to task_move_group_fair(). > > Signed-off-by: Yuyang Du

Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg()

On Mon, 06 Jun, at 08:20:37AM, Yuyang Du wrote: > attach_entity_load_avg() is called (indirectly) from: > > - switched_to_fair(): switch between classes to fair > - task_move_group_fair(): move between task groups > - enqueue_entity_load_avg(): enqueue entity > > Only in switched_to_fair() is

Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg()

On Mon, 06 Jun, at 08:20:37AM, Yuyang Du wrote: > attach_entity_load_avg() is called (indirectly) from: > > - switched_to_fair(): switch between classes to fair > - task_move_group_fair(): move between task groups > - enqueue_entity_load_avg(): enqueue entity > > Only in switched_to_fair() is

Re: [GIT PULL 0/2] EFI urgent fixes

On Tue, 31 May, at 11:23:42AM, Matt Fleming wrote: > Folks, please pull the following urgent patches which fix a boot crash > when using the "noefi" parameter and the debug output on arm. > > The following changes since commit 1a695a905c18548062509178b98bc91e67510864: >

Re: [GIT PULL 0/2] EFI urgent fixes

On Tue, 31 May, at 11:23:42AM, Matt Fleming wrote: > Folks, please pull the following urgent patches which fix a boot crash > when using the "noefi" parameter and the debug output on arm. > > The following changes since commit 1a695a905c18548062509178b98bc91e67510864: >

Re: [PATCH 3/3] Update efi_thunk to use efi_call_virt_generic

On Wed, 18 May, at 02:11:41PM, Alex Thorlton wrote: > diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h > index f310f0b..6643f9b 100644 > --- a/arch/x86/include/asm/efi.h > +++ b/arch/x86/include/asm/efi.h > @@ -68,6 +68,52 @@ struct efi_scratch { > u64 phys_stack; >

Re: [PATCH 3/3] Update efi_thunk to use efi_call_virt_generic

On Wed, 18 May, at 02:11:41PM, Alex Thorlton wrote: > diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h > index f310f0b..6643f9b 100644 > --- a/arch/x86/include/asm/efi.h > +++ b/arch/x86/include/asm/efi.h > @@ -68,6 +68,52 @@ struct efi_scratch { > u64 phys_stack; >

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

gt; ("x86/efi: Fix 7-parameter efi_call()s"). > > Now that all of those issues are out of the way, we're able to make this > simple change to use the new efi_call_virt_generic in uv_bios_call which > gets our machines booting, running properly, and able to execute our &

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

gt; ("x86/efi: Fix 7-parameter efi_call()s"). > > Now that all of those issues are out of the way, we're able to make this > simple change to use the new efi_call_virt_generic in uv_bios_call which > gets our machines booting, running properly, and able to execute our >

Re: [PATCH 1/3] Convert efi_call_virt to efi_call_virt_generic

ew > efi_call_virt_generic macro - this was mainly to keep the code from > looking too cluttered by adding a bunch of extra references to > efi.systab->runtime everywhere. > > Note that I also broke up the code in the efi_call_virt_generic macro a > bit in the process of moving

Re: [PATCH 1/3] Convert efi_call_virt to efi_call_virt_generic

ew > efi_call_virt_generic macro - this was mainly to keep the code from > looking too cluttered by adding a bunch of extra references to > efi.systab->runtime everywhere. > > Note that I also broke up the code in the efi_call_virt_generic macro a > bit in the process of moving it. >

Re: [PATCH] x86: Add early quirk to reset Apple AirPort card

when a driver is loaded for the wireless > card, which may be never if the driver is not installed or blacklisted. [... Snip a very thorough changelog ...] This patch looks fine to me from an EFI perspective. Acked-by: Matt Fleming <m...@codeblueprint.co.uk>

<    3   4   5   6   7   8   9   10   11   12   >