Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Mar 9, 2016, at 8:37 AM, Vaibhav Jain wrote: >> +/* >> + * AFU driver ops allows an AFU driver to create their own events to pass to >> + * userspace through the file descriptor as a simpler alternative to >> overriding >> + * the read() and poll() calls that

Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Mar 7, 2016, at 7:48 PM, Ian Munsie wrote: > > From: Ian Munsie > > This adds an afu_driver_ops structure with event_pending and > deliver_event callbacks. An AFU driver such as cxlflash can fill these > out and associate it with a context to

Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

A couple of minor nits below... > On Mar 7, 2016, at 12:59 PM, Ian Munsie wrote: > > @@ -346,7 +350,7 @@ ssize_t afu_read(struct file *file, char __user *buf, > size_t count, > > for (;;) { > prepare_to_wait(>wq, , TASK_INTERRUPTIBLE); > -

Re: [PATCH v2 2/2] cxl: add set/get private data to context struct

> On Mar 7, 2016, at 12:59 PM, Ian Munsie wrote: > > From: Michael Neuling > > This provides AFU drivers a means to associate private data with a cxl > context. This is particularly intended for make the new callbacks for > driver specific events easier

Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Mar 9, 2016, at 8:37 AM, Vaibhav Jain wrote: >> +/* >> + * AFU driver ops allows an AFU driver to create their own events to pass to >> + * userspace through the file descriptor as a simpler alternative to >> overriding >> + * the read() and poll() calls that works with the generic cxl

Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

A couple of minor nits below... > On Mar 7, 2016, at 12:59 PM, Ian Munsie wrote: > > @@ -346,7 +350,7 @@ ssize_t afu_read(struct file *file, char __user *buf, > size_t count, > > for (;;) { > prepare_to_wait(>wq, , TASK_INTERRUPTIBLE); > - if

Re: [PATCH v2 2/2] cxl: add set/get private data to context struct

> On Mar 7, 2016, at 12:59 PM, Ian Munsie wrote: > > From: Michael Neuling > > This provides AFU drivers a means to associate private data with a cxl > context. This is particularly intended for make the new callbacks for > driver specific events easier for AFU drivers to use, as they can

Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Mar 7, 2016, at 7:48 PM, Ian Munsie wrote: > > From: Ian Munsie > > This adds an afu_driver_ops structure with event_pending and > deliver_event callbacks. An AFU driver such as cxlflash can fill these > out and associate it with a context to enable passing custom AFU > specific events to