Add pm8998 thermal zone based on the examples in the spmi-temp-alarm
bindings.
Note: devices with the pm8998 need to have a 'thermal-zones' node (which
may be empty) with a label 'thermal_zones'.
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/q
The node is empty for now. It is needed to allow other DT snippets
to add thermal zone entries.
Signed-off-by: Matthias Kaehlcke
---
Sorry if you received this twice, lists were missing in cc in the first attempt
...
arch/arm64/boot/dts/qcom/sdm845.dtsi | 4
1 file changed, 4 insertions
This adds the spmi-temp-alarm node to pm8998 based on the examples in the
bindings.
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi
b/arch/arm64/boot/dts/qcom/pm8998.dtsi
Hi,
I stumbled across this patch since I'm currently poking around with
early thermal bringup on a platform and this patch has been integrated
in our development tree.
I'm seeing some unexpected behaviors, which could entirely due to
wrong expectation from my side. I only have some basic working
policy adjustments.
- dev_to_devfreq()
- lookup a devfreq strict from a device pointer
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/devfreq.c | 47 +---
include/linux/devfreq.h | 66 +++
2 files changed, 102 insertions
Currently update_devfreq() is only visible to devfreq governors outside
of devfreq.c. Make it public to allow drivers that adjust devfreq policies
to cause a re-evaluation of the frequency after a policy change.
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/governor.h | 3 ---
include
Signed-off-by: Matthias Kaehlcke
---
.../devicetree/bindings/misc/throttler.txt| 41 +++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/misc/throttler.txt
diff --git a/Documentation/devicetree/bindings/misc/throttler.txt
b
The driver subscribes to throttling events from the Chrome OS
embedded controller and enables/disables system throttling based
on these events.
Signed-off-by: Matthias Kaehlcke
---
drivers/misc/throttler/Kconfig | 15 +++
drivers/misc/throttler/Makefile| 1 +
drivers
which is the min/max frequency
supported by the device at a given time (depending on the
enabled/disabled OPPs)
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/governor_performance.c| 2 +-
drivers/devfreq/governor_powersave.c | 2 +-
drivers/devfreq/governor_simpleondemand
fo.min/max_freq
df->governor => p->governor
df->governor_name => p->governor_name
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/devfreq.c | 136 --
drivers/devfreq/governor_passive.c| 4 +-
drivers/dev
done by another (possibly platform specific)
driver.
Signed-off-by: Matthias Kaehlcke
---
drivers/misc/Kconfig| 1 +
drivers/misc/Makefile | 1 +
drivers/misc/throttler/Kconfig | 13 ++
drivers/misc/throttler/Makefile | 1 +
drivers/misc/throttler/core.c | 373
nor->get_target_freq().
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/governor_simpleondemand.c | 5 -
drivers/devfreq/governor_userspace.c | 16
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/devfreq/governor_simpleondemand.c
b/drivers/d
lue of 0. This also prevents df->max_freq from
being set below the min OPP when df->min_freq is 0, and similar for
min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the
checks for this case can be removed.
Fixes: f1d981eaecf8 ("PM / devfreq: Use the avail
devices the series introduces the
concept of a devfreq policy and the DEVFREQ_ADJUST notifier (similar
to CPUFREQ_ADJUST). Further it includes some related devfreq bugfixes
and improvements that change some of the code that is also touched
by the policy changes.
Matthias Kaehlcke (11):
PM / devfreq
th the
OPP freqs and then the user limts min/max_freq with scaling_min/
max_freq.
Needless to say that this change is a NOP, intended to improve
readability.
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/devfreq.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --g
Commit "PM / devfreq: Fix handling of min/max_freq == 0" ensures that
df->max_freq is not 0, remove unnecessary checks.
Signed-off-by: Matthias Kaehlcke
---
drivers/devfreq/governor_performance.c| 5 +
drivers/devfreq/governor_simpleondemand.c | 7 +++
2 files changed,
On Mon, Jun 18, 2018 at 05:17:16PM -0500, Josh Poimboeuf wrote:
> On Fri, Jun 15, 2018 at 02:14:41PM -0700, Matthias Kaehlcke wrote:
> > Hi Josh,
> >
> > with your work on objtool and the upcoming implementation of
> > -fno-delete-null-pointer-checks (https://reviews
On Mon, Jun 18, 2018 at 04:03:25PM -0700, Brian Norris wrote:
> Hi Matthias,
>
> On Thu, Jun 14, 2018 at 12:47:10PM -0700, Matthias Kaehlcke wrote:
> > The purpose of the throttler is to provide support for non-thermal
> > throttling. Throttling is triggered by ext
On Mon, Jun 18, 2018 at 04:21:10PM -0700, Brian Norris wrote:
> Hi,
>
> On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote:
> > Instantiate the CrOS EC throttler if it is enabled in the kernel
> > configuration.
> >
> > Signed-off-by: Matthias Ka
>
> > On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote:
> > > Instantiate the CrOS EC throttler if it is enabled in the kernel
> > > configuration.
> > >
> > > Signed-off-by: Matthias Kaehlcke
> > > ---
>
eboot.o: warning: objtool:
> native_machine_emergency_restart() falls through to next function
> machine_power_off()
>
> Reported-by: Matthias Kaehlcke
> Signed-off-by: Josh Poimboeuf
Tested-by: Matthias Kaehlcke
Reviewed-by: Matthias Kaehlcke
Thanks!
On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote:
> On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote:
> > On 19/06/2018 19:23, Joe Perches wrote:
> > > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote:
> > > > On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini
> > > > wrote:
On Tue, Jun 19, 2018 at 07:13:41PM +0200, Paolo Bonzini wrote:
> On 19/06/2018 19:08, Nick Desaulniers wrote:
> >> This one really makes the code uglier though, so I'm not really inclined
> >> to applying the patch.
> > Note that of the three variables (w, u, x), only u is used later on.
> > What a
^~
(gcc also raises a warning (see https://godbolt.org/g/6JWfWk), however it
doesn't seem to be universally enabled)
Suggested-by: Nick Desaulniers
Signed-off-by: Matthias Kaehlcke
---
Changes in v2:
- negate the bitmask at initialization and rename variables to not_X
On Tue, Jun 19, 2018 at 12:11:27PM -0700, Joe Perches wrote:
> On Tue, 2018-06-19 at 11:36 -0700, Matthias Kaehlcke wrote:
> > On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote:
> > > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote:
> > > > On 19/06
On Tue, Jun 19, 2018 at 02:55:05PM -0700, Joe Perches wrote:
> On Tue, 2018-06-19 at 14:10 -0700, Matthias Kaehlcke wrote:
> > On Tue, Jun 19, 2018 at 12:11:27PM -0700, Joe Perches wrote:
> > > -Wconstant-conversion is only issued when a *constant value* is assigned
> >
On Tue, Jun 19, 2018 at 05:18:02PM -0700, Joe Perches wrote:
> On Tue, 2018-06-19 at 16:45 -0700, Matthias Kaehlcke wrote:
> > On Tue, Jun 19, 2018 at 02:55:05PM -0700, Joe Perches wrote:
> > > Well, you advocate to disable a possibly useful warning globally ...
> > > Y
On Wed, May 30, 2018 at 05:04:14PM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote:
> > On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote:
> >> Hi,
> >>
> >> On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote
gt;
> 2018-05-25 22:30 GMT+02:00 Matthias Kaehlcke :
> > The driver subscribes to throttling events from the Chrome OS
> > embedded controller and enables/disables system throttling based
> > on these events.
> >
> > Signed-off-by: Matthias Kaehlcke
> >
Hi Rob,
On Thu, May 31, 2018 at 11:31:59AM -0500, Rob Herring wrote:
> On Fri, May 25, 2018 at 01:30:42PM -0700, Matthias Kaehlcke wrote:
>
> Commit msg?
Will add some more info in the next revision.
> > Signed-off-by: Matthias Kaehlcke
> > ---
> > .../devicetree/
On Thu, May 31, 2018 at 03:04:18PM -0500, Rob Herring wrote:
> On Thu, May 31, 2018 at 1:34 PM, Matthias Kaehlcke wrote:
> > Hi Rob,
> >
> > On Thu, May 31, 2018 at 11:31:59AM -0500, Rob Herring wrote:
> >> On Fri, May 25, 2018 at 01:30:42PM -0700, Matthias Kaehlc
On Thu, Jun 28, 2018 at 05:33:02PM -0700, Matthias Kaehlcke wrote:
> Hi,
>
> I stumbled across this patch since I'm currently poking around with
> early thermal bringup on a platform and this patch has been integrated
> in our development tree.
>
> I'm seeing s
Hi,
On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote:
> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
> sensors.
>
> Signed-off-by: Amit Kucheria
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 16
> 1 file changed, 16 insertions(+)
>
> diff
policy adjustments.
- dev_to_devfreq()
- lookup a devfreq strict from a device pointer
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- Fixed typo in commit message: devfreg => devfreq
- added 'Reviewed-by: Brian Norris ' tag
done by another (possibly platform specific)
driver.
Signed-off-by: Matthias Kaehlcke
--
Changes in v5:
- read throttling OPPs using new device tree binding (throttler-opps = <...>)
- thr_get_throttling_freq(): removed warning
- thr_handle_cpufreq_event(): merged similar
Exporting the device class allows other parts of the kernel to enumerate
the devfreq devices and receive notification when a devfreq device is
added or removed.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by:
Instantiate the CrOS EC throttler if it is enabled in the kernel
configuration.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- added 'Reviewed-by: Brian Norris ' tag
Changes in v4:
- register throttler in cros_ec_dev.c instead of cros_ec.c
Cha
The Throttler is used for non-thermal throttling of system components
like CPUs or devfreq devices.
Signed-off-by: Matthias Kaehlcke
--
Changes in v5:
- patch added to the series (replacing "dt-bindings: PM / OPP: add
opp-throttlers property")
---
.../devicetree/bindings/misc/thr
The driver subscribes to throttling events from the Chrome OS
embedded controller and enables/disables system throttling based
on these events.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Enric Balletbo i Serra
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- adapt to
cpufreq_update_policy() allows the throttler
driver to be built without ugly #ifdef'ery when cpufreq is disabled.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by: Brian Norris ' tag
Changes in v3:
- patch added to series
---
Currently update_devfreq() is only visible to devfreq governors outside
of devfreq.c. Make it public to allow drivers that adjust devfreq policies
to cause a re-evaluation of the frequency after a policy change.
Signed-off-by: Matthias Kaehlcke
Acked-by: MyungJoo Ham
Reviewed-by: Brian Norris
th the
OPP freqs and then the user limts min/max_freq with scaling_min/
max_freq.
Needless to say that this change is a NOP, intended to improve
readability.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Chanwoo Choi
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- added '
let update_devfreq() take care of any adjustments.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by: Brian Norris ' tag
Changes in v3:
- none
Changes in v2:
- squashed "PM / devfreq: Remove redundant frequen
fo.min/max_freq
df->governor => p->governor
df->governor_name => p->governor_name
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Brian Norris
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by: Brian Norris ' tag
Changes in v3:
- non
devices the series introduces the
concept of a devfreq policy and the DEVFREQ_ADJUST notifier (similar
to CPUFREQ_ADJUST). Further it includes some related devfreq bugfixes
and improvements that change some of the code that is also touched
by the policy changes.
Matthias Kaehlcke (12):
PM / devfreq
lue of 0. This also prevents df->max_freq from
being set below the min OPP when df->min_freq is 0, and similar for
min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the
checks for this case can be removed.
Fixes: f1d981eaecf8 ("PM / devfreq: Use the avai
Hi Chanwoo,
On Wed, Jul 04, 2018 at 11:20:31AM +0900, Chanwoo Choi wrote:
> Hi Matthias,
>
> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
> > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding the
> > devfreq device") initializes df->min/
Hi,
On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
> > Move variables related with devfreq policy changes from struct devfreq
> > to the new struct devfreq_policy and add a policy field to struct
rch_topology.c
> ./drivers/video/fbdev/sa1100fb.c
> ./drivers/video/fbdev/pxafb.c
> ./drivers/cpufreq/ppc_cbe_cpufreq_pmi.c
> ./drivers/cpufreq/cpufreq.c
> ./drivers/cpufreq/cpufreq.c
> ./drivers/cpufreq/cpufreq.c
> ./drivers/cpufreq/cpufreq.c
Thanks for your investigation.
Hi,
On Wed, Jul 04, 2018 at 02:30:32PM +0900, Chanwoo Choi wrote:
> I didn't see any framework which exporting the class instance.
> It is very dangerous. Unknown device drivers is able to reset
> the 'devfreq_class' instance. I can't agree this approach.
While I agree that it is potential dange
a look, but did you saw why this patch was not merged [1]?
> Maybe that could answer some of your questions.
>
> Best regards,
> Enric
>
> [1] https://lkml.org/lkml/2018/2/27/910
I missed this, thanks for the pointer!
> On 03/07/18 19:13, Matthias Kaehlcke wrote:
>
n directly switch to operating speed
if it is defined.
Couldn't we do this instead:
/* Setup user speed if needed */
speed = qca_get_speed(hu, QCA_OPER_SPEED);
if (speed) {
ret = qca_set_speed(hu, QCA_OPER_SPEED);
if (ret)
return ret;
qca_baudrate = qca_get_baudrate_value(speed);
} else {
qca_set_speed(hu, QCA_INIT_SPEED);
}
?
Or is setting the init speed needed before the operating speed can be
set? Sorry if we discussed this earlier in this series, I know I had a
few doubts about the speed management but don't recall this one
specifically.
Other than that:
Reviewed-by: Matthias Kaehlcke
On Thu, Jul 05, 2018 at 10:25:15PM +0530, Balakrishna Godavarthi wrote:
> Add support to set voltage/current of various regulators
> to power up/down Bluetooth chip wcn3990.
>
> Signed-off-by: Balakrishna Godavarthi
> ---
> changes in v9:
> * moved flow control to vendor and set_baudarte func
= qca_read_soc_version(hdev, &soc_ver);
> + if (ret < 0 || soc_ver == 0) {
> + bt_dev_err(hdev, "QCA Failed to get version (%d)", ret);
> + return ret;
> + }
> + bt_dev_info(hdev, "QCA controller version 0x%08x", soc_ver);
As commented on [1] I'd suggest to move some of the logging and error
handling to qca_read_soc_version(), especially since this sequence is
duplicated later in this series.
Not really the scope of this patch though, so:
Reviewed-by: Matthias Kaehlcke
[1] https://patchwork.kernel.org/patch/10510029/
Hi,
On Mon, Jun 11, 2018 at 06:49:13PM -0700, Brian Norris wrote:
> Hi!
>
> A few comments, but I didn't get to finish a thorough review yet.
>
>
> On Thu, Jun 07, 2018 at 11:12:12AM -0700, Matthias Kaehlcke wrote:
> > The purpose of the throttler is to pr
Hi,
On Tue, Jun 12, 2018 at 10:10:51AM +0530, Rajendra Nayak wrote:
> The RPMh Power domain driver aggregates the corner votes from various
> consumers for the ARC resources and communicates it to RPMh.
>
> We also add data for all power domains on sdm845 SoC as part of the patch.
> The driver ca
On Tue, Jun 12, 2018 at 01:00:14PM -0700, Brian Norris wrote:
> Hi,
>
> On Tue, Jun 12, 2018 at 10:11:40AM -0700, Matthias Kaehlcke wrote:
> > On Mon, Jun 11, 2018 at 06:49:13PM -0700, Brian Norris wrote:
> > > On Thu, Jun 07, 2018 at 11:12:12AM -0700, Matthias Kaehlcke wr
On Tue, Jun 12, 2018 at 01:40:22PM -0700, Brian Norris wrote:
> Hi Rob,
>
> On Tue, Jun 12, 2018 at 01:10:11PM -0600, Rob Herring wrote:
> > On Thu, Jun 07, 2018 at 11:12:13AM -0700, Matthias Kaehlcke wrote:
> > > The cros_ec_throttler monitors events from the Chrome OS E
(sorry if you receive two variants of this mail, I sent one earlier
today but for some reason it didn't make it to the lists)
On Wed, Jun 13, 2018 at 05:06:24PM +0100, Craig Tatlor wrote:
> Add bindings for the Qualcomm Battery Monitoring system.
>
> Signed-off-by: Craig Tatlor
> ---
>
> * Chan
Instantiate the CrOS EC throttler if it is enabled in the kernel
configuration.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- patch added to series
drivers/mfd/cros_ec.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
done by another (possibly platform specific)
driver.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- Kconfig: don't select CPU_FREQ and PM_DEVFREQ
- added CONFIG_THROTTLER_DEBUG option
- changed 'level' sysfs attribute to debugfs
- introduced thr_ macros for logging
- added deb
The driver subscribes to throttling events from the Chrome OS
embedded controller and enables/disables system throttling based
on these events.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Enric Balletbo i Serra
---
Changes in v3:
- change module license to GPL v2 as in the SPDX identifier
Exporting the device class allows other parts of the kernel to enumerate
the devfreq devices and receive notification when a devfreq device is
added or removed.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- none
Changes in v2:
- patch added to series
drivers/devfreq/devfreq.c | 3
The optional opp-throttlers property is used to configure the throttlers
(see drivers/misc/throttler/*) that use a given OPP to throttle the
corresponding device(s).
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- none
Changes in v2:
- patch added to series
Documentation/devicetree
Currently update_devfreq() is only visible to devfreq governors outside
of devfreq.c. Make it public to allow drivers that adjust devfreq policies
to cause a re-evaluation of the frequency after a policy change.
Signed-off-by: Matthias Kaehlcke
Acked-by: MyungJoo Ham
---
Changes in v3:
- none
policy adjustments.
- dev_to_devfreq()
- lookup a devfreq strict from a device pointer
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- devfreq.h: fixed misspelling of struct devfreq_policy
Changes in v2:
- performance, powersave and simpleondemand governors don't need changes
wit
cpufreq_update_policy() allows the throttler
driver to be built without ugly #ifdef'ery when cpufreq is disabled.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- patch added to series
include/linux/cpufreq.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/cpufreq.h b/include/
let update_devfreq() take care of any adjustments.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- none
Changes in v2:
- squashed "PM / devfreq: Remove redundant frequency adjustment from governors"
and "PM / devfreq: governors: Return device frequency limits instead of user
fo.min/max_freq
df->governor => p->governor
df->governor_name => p->governor_name
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- none
Changes in v2:
- performance, powersave and simpleondemand governors don't need changes
with "PM / dev
th the
OPP freqs and then the user limts min/max_freq with scaling_min/
max_freq.
Needless to say that this change is a NOP, intended to improve
readability.
---
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Chanwoo Choi
Changes in v3:
- none
Changes in v2:
- added 'Reviewed-by: Chanwoo Cho
devices the series introduces the
concept of a devfreq policy and the DEVFREQ_ADJUST notifier (similar
to CPUFREQ_ADJUST). Further it includes some related devfreq bugfixes
and improvements that change some of the code that is also touched
by the policy changes.
Matthias Kaehlcke (12):
PM / devfreq
lue of 0. This also prevents df->max_freq from
being set below the min OPP when df->min_freq is 0, and similar for
min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the
checks for this case can be removed.
Fixes: f1d981eaecf8 ("PM / devfreq: Use the available
^~
(gcc also raises a warning (see https://godbolt.org/g/6JWfWk), however it
doesn't seem to be universally enabled)
Signed-off-by: Matthias Kaehlcke
---
arch/x86/kvm/mmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/mmu.c
On Fri, Jun 15, 2018 at 11:18:12AM -0700, Joe Perches wrote:
> On Fri, 2018-06-15 at 11:04 -0700, Nick Desaulniers wrote:
> > On Fri, Jun 15, 2018 at 10:47 AM Matthias Kaehlcke
> > wrote:
> > >
> > > update_permission_bitmask() negates u8 bitmask values and a
Hi Josh,
with your work on objtool and the upcoming implementation of
-fno-delete-null-pointer-checks (https://reviews.llvm.org/D47894,
https://reviews.llvm.org/D47895) in clang most objtool warnings
for clang builds will be fixed.
However even with -fno-delete-null-pointer-checks we currently st
On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote:
> Hi,
>
> On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote:
> > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding
> > the devfreq device") introduced the initializa
Hi,
On Thu, May 17, 2018 at 10:44:08AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 05월 17일 06:10, Matthias Kaehlcke wrote:
> > The performance, powersave, simpleondemand and userspace governors
> > determine a target frequency and then adjust it according to the
> &
On Thu, May 17, 2018 at 10:07:56AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 05월 17일 07:57, Matthias Kaehlcke wrote:
> > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding
> > the devfreq device") introduced the initialization of the user
> >
lue of 0. This also prevents df->max_freq from
being set below the min OPP when df->min_freq is 0, and similar for
min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the
checks for this case can be removed.
Fixes: f1d981eaecf8 ("PM / devfreq: Use the avail
On Wed, May 16, 2018 at 02:10:51PM -0700, Matthias Kaehlcke wrote:
> The performance, powersave, simpleondemand and userspace governors
> determine a target frequency and then adjust it according to the
> df->min/max_freq limits that might have been set by user space. This
>
provide the necessary interfaces.
> On 2018년 05월 16일 06:24, Matthias Kaehlcke wrote:
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index fe2af6aa88fc..a7294c056f65 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
&
On Fri, May 18, 2018 at 08:26:30AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 05월 18일 08:07, Matthias Kaehlcke wrote:
> > Hi,
> >
> > On Thu, May 17, 2018 at 11:01:34AM +0900, Chanwoo Choi wrote:
> >> Hi,
> >>
> >> Could you give some use
On Fri, May 18, 2018 at 08:15:55AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 05월 18일 00:47, Matthias Kaehlcke wrote:
> > Hi,
> >
> > On Thu, May 17, 2018 at 10:44:08AM +0900, Chanwoo Choi wrote:
> >> Hi,
> >>
> >> On 2018년 05월 17일
On Fri, May 18, 2018 at 08:27:55AM +0900, Chanwoo Choi wrote:
> Hi,
>
> Please resend the patch with related other patches.
> It is hard to check the dependency/sequence of your patches.
The three patches (excluding the RFC) I sent in the past days are
independent from each other and can be appli
v;
> +
> + ret = cpufreq_register_driver(&cpufreq_qcom_hw_driver);
> + if (ret)
> + dev_err(&pdev->dev, "CPUFreq HW driver failed to register\n");
> + else
> + dev_dbg(&pdev->dev, "QCOM CPUFreq HW driver initialized\n");
> +
> + return ret;
> +}
> +
> +static int qcom_cpufreq_hw_driver_remove(struct platform_device *pdev)
> +{
> + return cpufreq_unregister_driver(&cpufreq_qcom_hw_driver);
> +}
> +
> +static const struct of_device_id qcom_cpufreq_hw_match[] = {
> + { .compatible = "qcom,cpufreq-hw" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, qcom_cpufreq_hw_match);
> +
> +static struct platform_driver qcom_cpufreq_hw_driver = {
> + .probe = qcom_cpufreq_hw_driver_probe,
> + .remove = qcom_cpufreq_hw_driver_remove,
> + .driver = {
> + .name = "qcom-cpufreq-hw",
> + .of_match_table = qcom_cpufreq_hw_match,
> + },
> +};
> +
> +static int __init qcom_cpufreq_hw_init(void)
> +{
> + return platform_driver_register(&qcom_cpufreq_hw_driver);
> +}
> +subsys_initcall(qcom_cpufreq_hw_init);
> +
> +static void __exit qcom_cpufreq_hw_exit(void)
> +{
> + platform_driver_unregister(&qcom_cpufreq_hw_driver);
> +}
> +module_exit(qcom_cpufreq_hw_exit);
> +
> +MODULE_DESCRIPTION("QCOM CPUFREQ HW Driver");
> +MODULE_LICENSE("GPL v2");
FWIW:
Reviewed-by: Matthias Kaehlcke
are sent as if they were
actual data.
Handle wrap arounds of the TX buffer properly and ensure that words
written to the TX FIFO always contain valid data (unless the transfer
is completed).
Fixes: a1fee899e5bed ("tty: serial: qcom_geni_serial: Fix softlock")
Signed-off-by: Matthias K
On Wed, Dec 19, 2018 at 10:49:26AM -0800, Evan Green wrote:
> On Wed, Dec 19, 2018 at 10:17 AM Matthias Kaehlcke wrote:
> >
> > Before commit a1fee899e5bed ("tty: serial: qcom_geni_serial: Fix
> > softlock") the size of TX transfers was limited to the TX FIFO si
uirk is set and the property does not exist
> > or is invalid the controller is marked as unconfigured.
> >
> > Signed-off-by: Matthias Kaehlcke
> > Reviewed-by: Balakrishna Godavarthi
> > Tested-by: Balakrishna Godavarthi
> > ---
> > Changes in v2:
> &
Hi Niklas,
On Wed, Dec 12, 2018 at 11:07:17PM +0100, Niklas Cassel wrote:
> On Tue, Dec 04, 2018 at 02:42:29PM -0800, Matthias Kaehlcke wrote:
> > Get the ref clock of the PHY from the device tree instead of
> > hardcoding its name and rate.
> >
> > Signe
On Mon, Dec 10, 2018 at 07:51:19AM -0800, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2018-12-04 14:42:30)
> > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c
> > b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c
> > index 71fe60e5f01f1..032bf3e8614bd 100644
> >
:
- always use parent rate for 28nm and 28nm 8960 PHYs
Major changes in v3:
- keep supporting DTs without ref clock for the 28nm and the 28nm
8960 PHYs
- added patch to add ref clock to qcom-apq8064.dtsi
Major changes in v2:
- apply to all MSM DSI PHY drivers, not only 10nm
Matthias Kaehlcke (8
Get the ref clock of the PHY from the device tree instead of
hardcoding its name and rate.
Note: This change could break old out-of-tree DTS files that
use the 14nm PHY.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
---
Changes in v5:
- pass the ref clock name to _register
Get the ref clock of the PHY from the device tree instead of
hardcoding its name and rate.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Stephen Boyd
---
Changes in v5:
- added "Reviewed-by: Stephen Boyd " tag
Changes in v4:
- always use parent rate in dsi_pll_28nm_clk_set_rate()
-
Add 'bi_tcxo' as ref clock for the DSI PHYs, it was previously
hardcoded in the PLL 'driver' for the 10nm PHY.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
Reviewed-by: Stephen Boyd
---
based on "[v6] arm64: dts: qcom: sdm845: Add dpu to
Get the ref clock of the PHY from the device tree instead of
hardcoding its name and rate.
Note: This change could break old out-of-tree DTS files that
use the 10nm PHY
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
---
Changes in v5:
- pass the ref clock name to _register
Allow the PHY drivers to get the ref clock from the DT.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
Reviewed-by: Rob Herring
---
Changes in v5:
- added "Reviewed-by: Rob Herring " tag
Changes in v4:
- added "Reviewed-by" tags f
Add 'xo_board' as ref clock for the DSI PHYs, it was previously
hardcoded in the PLL 'driver' for the 28nm PHY.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
Reviewed-by: Stephen Boyd
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by: St
Add 'xo_board' as ref clock for the DSI PHY, it was previously
hardcoded in the PLL 'driver' for the 28nm 8960 PHY.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Stephen Boyd
---
Changes in v5:
- none
Changes in v4:
- added 'Reviewed-by: Stephen Boyd ' tag
Chang
Get the ref clock of the PHY from the device tree instead of
hardcoding its name and rate.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Stephen Boyd tag
---
Changes in v5:
- added missing return keyword in msm_dsi_pll_28nm_init()
- added "Reviewed-by: Stephen Boyd " tag
Cha
te");
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
> +
> + cpu_hw_rate = clk_get_rate(clk) / CLK_HW_DIV;
> + clk_put(clk);
> +
> + global_pdev = pdev;
> +
> + ret = cpufreq_register_driver(&cpufreq_qcom_hw_driver);
> + if (ret)
> +
401 - 500 of 1855 matches
Mail list logo
