> > >
> > > Thanks for the patch, a few comments below, some are feedback I
> > > received when I sent some patches to this subsystem.
> > >
> > > Missatge de Matti Vaittinen del
> > > dia dt., 19 de juny 2018 a les 12:57:
> > > > +}
Thanks for taking the time to check this =)
On Thu, Jul 05, 2018 at 10:18:13AM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Matti Vaittinen wrote:
>
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1787,6 +1787,19 @@ config MFD_STW481X
And thanks again Lee!
On Thu, Jul 05, 2018 at 10:24:44AM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Matti Vaittinen wrote:
>
> > Document devicetree bindings for ROHM BD71837 PMIC MFD.
> >
> > Signed-off-by: Matti Vaittinen
> > Reviewed-by: Rob Herring
> &
On Thu, Jul 05, 2018 at 11:49:19AM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Matti Vaittinen wrote:
> > On Thu, Jul 05, 2018 at 10:24:44AM +0100, Lee Jones wrote:
> > > On Thu, 05 Jul 2018, Matti Vaittinen wrote:
> > >
> > > > Document device
On Thu, Jul 05, 2018 at 12:17:05PM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Matti Vaittinen wrote:
>
> > Thanks for taking the time to check this =)
> >
> > On Thu, Jul 05, 2018 at 10:18:13AM +0100, Lee Jones wrote:
> > > On Thu, 05 Jul 2018, Matti Vait
patch series is based on for-mfd-next
---
Matti Vaittinen (2):
mfd: bd71837: mfd driver for ROHM BD71837 PMIC
mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 62
drivers/mfd/Kconfig| 13 +
driver
ROHM BD71837 PMIC MFD driver providing interrupts and support
for three subsystems:
- clk
- Regulators
- input/power-key
Signed-off-by: Matti Vaittinen
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile | 1 +
drivers/mfd/rohm-bd718x7.c | 198
Document devicetree bindings for ROHM BD71837 PMIC MFD.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 62 ++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
diff --git
On Fri, Jul 06, 2018 at 08:05:59AM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Dmitry Torokhov wrote:
>
> > On July 5, 2018 12:56:50 AM PDT, Matti Vaittinen
> > wrote:
> > >On Wed, Jul 04, 2018 at 06:57:39PM +0200, Enric Balletbo Serra wrote:
> > >>
On Fri, Jul 06, 2018 at 07:09:13AM +0100, Lee Jones wrote:
[snip]
'
> page trying to find your response was a little painful. TIA.
Acronyms can be confusing for non native english speakers like me.
Luckily we have the internet =)
https://www.acronymfinder.com/Slang/TIA.html
>From these options
Hello Stephen,
Thanks again for the review. I'll do new patch which fixes these issues.
On Tue, Jun 12, 2018 at 12:44:11AM -0700, Stephen Boyd wrote:
> Quoting Matti Vaittinen (2018-06-04 06:19:13)
> > +config COMMON_CLK_BD71837
> > + tristate "Clock driver
On Tue, Jun 12, 2018 at 11:23:54AM +0300, Matti Vaittinen wrote:
> Hello Stephen,
>
> Thanks again for the review. I'll do new patch which fixes these issues.
>
> On Tue, Jun 12, 2018 at 12:44:11AM -0700, Stephen Boyd wrote:
> > Quoting Matti Vait
On Thu, Jun 07, 2018 at 02:12:18PM +0300, Matti Vaittinen wrote:
> On Wed, Jun 06, 2018 at 10:16:37AM -0500, Rob Herring wrote:
> > On Wed, Jun 6, 2018 at 2:34 AM, Matti Vaittinen
> > wrote:
> > > On Tue, Jun 05, 2018 at 10:46:14AM -0500, Rob Herring wrote:
> > >
river for power button connected to BD71837
This patch series is based on for-mfd-next
---
Matti Vaittinen (4):
mfd: bd71837: mfd driver for ROHM BD71837 PMIC
mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC
clk: bd71837: Add driver for BD71837 PMIC clock
input/power: Add drive
ROHM BD71837 PMIC MFD driver providing interrupts and support
for two subsystems:
- clk
- Regulators
Signed-off-by: Matti Vaittinen
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile| 1 +
drivers/mfd/bd71837.c | 249 ++
include
Document devicetree bindings for ROHM BD71837 PMIC MFD.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 ++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
diff --git
Support BD71837 gateable 32768 Hz clock.
Signed-off-by: Matti Vaittinen
---
drivers/clk/Kconfig | 6 ++
drivers/clk/Makefile | 1 +
drivers/clk/clk-bd71837.c | 145 ++
3 files changed, 152 insertions(+)
create mode 100644 drivers/clk
ROHM BD71837 PMIC power button driver providing power-key press
information to user-space.
Signed-off-by: Matti Vaittinen
---
drivers/input/misc/Kconfig | 10 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/bd718xx-pwrkey.c | 90
On Mon, Dec 17, 2018 at 05:32:44PM +, Mark Brown wrote:
> On Fri, Dec 14, 2018 at 04:08:12PM +0200, Matti Vaittinen wrote:
>
> > This is draft for approach proposed by Mark here:
> > http://lkml.iu.edu/hypermail/linux/kernel/1812.1/07117.html
>
> > Pretty untest
On Mon, Dec 17, 2018 at 06:07:22PM +, Mark Brown wrote:
> On Mon, Dec 17, 2018 at 10:42:48AM +0200, Matti Vaittinen wrote:
> > On Thu, Dec 13, 2018 at 06:20:26PM +, Mark Brown wrote:
>
> > > I can't remember and can't find any record of any discussion of
should not have
defaults hard-coded but keep the HW/boot defaults untouched.
Signed-off-by: Matti Vaittinen
---
So let's try removing the hard-coded default setting from generic
regmap-irq code as discussed with Mark here:
https://lore.kernel.org/lkml/20181217180722.gg27...@sirena.org.uk/
Core
add support to the regmap-irq for chips
which support them =)
We do not support distinguishing situation where HW supports rising
and falling edge detection but not both. Separating this would require
inventing yet another flags for IRQ types.
Signed-off-by: Matti Vaittinen
---
Version 3 of this
On Tue, Dec 18, 2018 at 02:08:41PM +0100, Bartosz Golaszewski wrote:
> wt., 18 gru 2018 o 11:58 Matti Vaittinen
> napisał(a):
> >
> > The common code should not set IRQ type. Read HW defaults to the
> > cache at startup instead of forcing type to EDGE_BOTH. If
> >
is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Matti-Vaittinen/regmap-regmap-irq-gpio-max77620-add-level-irq-support/20181218-225844
> base: https://git.kernel.org/pub/scm/linux/ke
On Fri, Dec 07, 2018 at 01:14:18PM +, Mark Brown wrote:
> On Fri, Dec 07, 2018 at 09:58:29AM +0200, Matti Vaittinen wrote:
> > On Wed, Dec 05, 2018 at 05:27:01PM +, Mark Brown wrote:
>
> > d->domain = irq_domain_add_lin
have active interrupts we can reduce the latency by only reading
the main register and those sub registers which have active
interrupts. Support this with regmap-irq for simple cases where
main register does not require acking or masking.
Signed-off-by: Matti Vaittinen
---
This is dra
Hello Mark & All,
On Fri, Dec 14, 2018 at 05:26:19PM +, Mark Brown wrote:
> On Fri, Dec 14, 2018 at 03:58:19PM +0200, Matti Vaittinen wrote:
> > On Fri, Dec 07, 2018 at 01:14:18PM +, Mark Brown wrote:
>
> > I could send an example on how the driver util
On Mon, Dec 17, 2018 at 10:19:12AM +0200, Matti Vaittinen wrote:
> Hello Mark & All,
>
> On Fri, Dec 14, 2018 at 05:26:19PM +, Mark Brown wrote:
> > On Fri, Dec 14, 2018 at 03:58:19PM +0200, Matti Vaittinen wrote:
> > > On Fri, Dec 07, 2018 at 01:14:18PM +, Ma
Hello Mark,
On Thu, Dec 13, 2018 at 06:20:26PM +, Mark Brown wrote:
> On Tue, Dec 11, 2018 at 04:05:55PM +0200, Matti Vaittinen wrote:
>
> > One specific question hit me while doing this. Why does the regmap-irq
> > core do default trigger type configuration? I did
add support to the regmap-irq for chips
which support them =)
We do not support distinguishing situation where HW supports rising
and falling edge detection but not both. Separating this would require
inventing yet another flags for IRQ types.
Signed-off-by: Matti Vaittinen
---
I did both the
Hello Vladimir,
Thanks for the review.
On Mon, Dec 10, 2018 at 05:16:28PM +0200, Vladimir Zapolskiy wrote:
> On 12/10/2018 10:14 AM, Matti Vaittinen wrote:
> > Add level active IRQ support to regmap-irq irqchip. Change breaks
> > existing regmap-irq type setting. Convert the e
Hello Again All,
Sorry for multiple posts but I had second look at this and...
On Tue, Dec 11, 2018 at 08:38:25AM +0200, Matti Vaittinen wrote:
> Hello Vladimir,
>
> Thanks for the review.
>
> On Mon, Dec 10, 2018 at 05:16:28PM +0200, Vladimir Zapolskiy wrote:
> > On 12/10
for riding and falling edge values
if both edges are requested to be detected. This may not work on all
HWs.
Signed-off-by: Matti Vaittinen
---
One specific question hit me while doing this. Why does the regmap-irq
core do default trigger type configuration? I did leave this in the
patch - but to
ke sane
approach. Any good adviece on how to proceed?
Best Regards
Matti Vaittinen
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
On Mon, Dec 31, 2018 at 07:11:27PM +, Mark Brown wrote:
> On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote:
>
> > Last night - just when I was about to get some sleep - it stroke me. I
> > think the correct thing to do would be leaving the irq_set_type to NULL
On Thu, Jan 03, 2019 at 05:20:08PM +, Charles Keepax wrote:
> On Wed, Jan 02, 2019 at 09:42:51AM +0200, Matti Vaittinen wrote:
> > On Mon, Dec 31, 2018 at 07:11:27PM +, Mark Brown wrote:
> > > On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote:
> > >
Do not register type setting callback if HW does not support
setting the irq type. IRQ core can then handle cases where
type setting is not supported and no regmap-irq specific handling
is required.
Signed-off-by: Matti Vaittinen
---
drivers/base/regmap/regmap-irq.c | 4 +++-
1 file changed, 3
how this should be done - but I don't think I
have the energy and time to drive this change further... So Mark, please
just drop this patch and keep the original fix unless you want to drive
this further yourself =)
Br,
Matti Vaittinen
>
> Thanks,
> Charles
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
Hello Geert,
Sorry for waiting - I just opened my computer after the holidays.
On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote:
> Hi Matti,
>
> On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen
> wrote:
> > Add level active IRQ support to regmap-irq irqc
Hello All,
On Thu, Dec 27, 2018 at 09:35:31AM +0200, Matti Vaittinen wrote:
> On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote:
> > Hi Matti,
> >
> > On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen
> > wrote:
> > > Add level active IRQ s
77620: add level-irq support")
Signed-off-by: Matti Vaittinen
---
Geert reported that 1c2928e3e321 breaks da9063-rtc on the Renesas
Koelsch board:
https://lore.kernel.org/lkml/20181227075648.GB2461@localhost.localdomain/T/#m194616cc88d7b4c2a78f7ce07907608fdb64a092
Geert, do you know if anyon
On Thu, Dec 27, 2018 at 09:56:48AM +0200, Matti Vaittinen wrote:
> Hello All,
>
> On Thu, Dec 27, 2018 at 09:35:31AM +0200, Matti Vaittinen wrote:
> > On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote:
> > > Hi Matti,
> > >
> > > On Tu
},
> };
> @@ -1059,7 +1059,7 @@ static int bd718xx_probe(struct platform_device *pdev)
> struct regulator_dev *rdev;
> const struct bd718xx_regulator_data *r;
>
> - r = &(*pmic_regulators[mfd->chip_type].r_datas)[i];
> +
or is there some better way to handle this? Can you cherry pick or
re-apply the commit
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09
- even though the file was later renamed?
Br,
Matti Vaittinen
--
0-Day tests found compilation error on x86.
Driver won't compile on x86_64 as "of_match_ptr" is
not found. Add missing include
At some point this fix was lost. So re-apply it.
Signed-off-by: Matti Vaittinen
---
drivers/regulator/bd718x7-regulator.c | 1 +
1 file changed, 1 ins
clk-max77686 never clean clkdev lookup at remove. This can cause
oops if clk-max77686 is removed and inserted again. Fix leak by
using new devm clkdev lookup registration. Simplify also error
path by using new devm_of_clk_add_parent_hw_provider.
Signed-off-by: Matti Vaittinen
---
drivers/clk
'devm_of_clk_add_parent_hw_provider' for no OF config.
- patches 2-8 are unchanged.
This patch series is based on clk-next
---
Matti Vaittinen (8):
clk: clkdev/of_clk - add managed lookup and provider registrations
clk: clk-max77686: Clean clkdev lookup leak and use devm
clk: clk-s3c2410-dclk
have SEL bit kept zero. Currently the driver assumes all
regulators to be controlled by SW so it sets all SEL bits to 1.
Signed-off-by: Matti Vaittinen
---
drivers/regulator/bd718x7-regulator.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/regulator/bd718x7
> >> #include
> >> #include
> >
> > Not sure if this is relevant but if I am not mistaken this should already
> > be fixed by:
> > df43519eb706edfe951284a825642ce2e1d38d09
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?
struct regmap *regmap;
unsigned long int id;
int chip_irq;
struct regmap_irq_chip_data *irq_data;
struct bd71837_pmic *pmic;
struct bd71837_clk *clk;
};
Other than that - simplifications are always welcome.
Reviewed-by: Matti Vaittinen
On Thu, Oct 04, 2018 at 02:51:48PM +0800, Axel Lin wrote:
> All the fields in struct bd718xx_pmic are not really necessary.
> Remove struct bd718xx_pmic to simplify the code.
>
> Signed-off-by: Axel Lin
> Reviewed-by: Matti Vaittinen
> ---
> v3: Remove the references to str
Thanks for taking the time and reviewing this!
On Fri, Nov 02, 2018 at 09:15:17AM +0100, Krzysztof Kozlowski wrote:
> On Thu, 1 Nov 2018 at 08:19, Matti Vaittinen
> wrote:
> >
> > clk-max77686 never clean clkdev lookup at remove. This can cause
> > oops if clk-max77686
Hello all,
Sorry for html email. I'm not used to send mails using gmail app.
Trying to resend as plain text now...
On 7/17/18, Matti Vaittinen wrote:
> ma 9. heinäk. 2018 klo 9.33 Stephen Boyd kirjoitti:
>
>> Quoting Matti Vaittinen (2018-06-28 00:54:53)
>> > Add d
On Sat, 2021-02-13 at 14:18 +0100, Hans de Goede wrote:
> Hi,
>
> On 2/13/21 1:16 PM, Greg Kroah-Hartman wrote:
> > On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote:
> > > +/**
> > > + * devm_delayed_work_autocancel - Resource-managed work
> &
Hello Andy, All.
On Wed, 2021-04-07 at 16:21 +0300, Andy Shevchenko wrote:
> On Wed, Apr 7, 2021 at 1:04 PM Matti Vaittinen
> wrote:
> > Provide helper function for IC's implementing regulator
> > notifications
> > when an IRQ fires. The helper also works for IR
Hello Andy,
On Wed, 2021-04-07 at 16:21 +0300, Andy Shevchenko wrote:
> On Wed, Apr 7, 2021 at 1:04 PM Matti Vaittinen
> wrote:
> > Provide helper function for IC's implementing regulator
> > notifications
> > when an IRQ fires. The helper also works for IR
and 7 LDOs.
Patch 9:
Kconfig and Makefiles for regulators
This patch series is based on for-mfd-next
---
Matti Vaittinen (9):
mfd: bd71837: mfd driver for ROHM BD71837 PMIC
mfd: bd71837: build BD71837 PMIC MFD driver
mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC
regulato
Configuration options and Makefile for BD71837 PMIC MFD driver
Signed-off-by: Matti Vaittinen
---
drivers/mfd/Kconfig | 13 +
drivers/mfd/Makefile | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index b860eb5aa194..7aa05fc9ed8e
ROHM BD71837 PMIC MFD driver providing interrupts and support
for two subsystems:
- clk
- Regulators
Signed-off-by: Matti Vaittinen
---
drivers/mfd/bd71837.c | 238 +
include/linux/mfd/bd71837.h | 316
2 files
Document devicetree bindings for ROHM BD71837 PMIC MFD.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
diff --git
Document devicetree bindings for ROHM BD71837 PMIC regulators.
Signed-off-by: Matti Vaittinen
---
.../bindings/regulator/rohm,bd71837-regulator.txt | 124 +
1 file changed, 124 insertions(+)
create mode 100644
Documentation/devicetree/bindings/regulator/rohm,bd71837
Document devicetree bindings for ROHM BD71837 PMIC clock output.
Signed-off-by: Matti Vaittinen
---
.../bindings/clock/rohm,bd71837-clock.txt | 37 ++
1 file changed, 37 insertions(+)
create mode 100644
Documentation/devicetree/bindings/clock/rohm,bd71837
Support BD71837 gateable 32768 Hz clock.
Signed-off-by: Matti Vaittinen
---
drivers/clk/clk-bd71837.c | 155 ++
1 file changed, 155 insertions(+)
create mode 100644 drivers/clk/clk-bd71837.c
diff --git a/drivers/clk/clk-bd71837.c b/drivers/clk/clk
Support for controlling the 8 bucks and 7 LDOs the PMIC contains.
Signed-off-by: Matti Vaittinen
---
drivers/regulator/bd71837-regulator.c | 683 ++
1 file changed, 683 insertions(+)
create mode 100644 drivers/regulator/bd71837-regulator.c
diff --git a/drivers
Configuration options and Makefile for BD71837 clock driver
Signed-off-by: Matti Vaittinen
---
drivers/clk/Kconfig | 9 +
drivers/clk/Makefile | 1 +
2 files changed, 10 insertions(+)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 41492e980ef4..4b045699bb5e 100644
--- a
Configurations and Makefile for BD71837 regulator driver
Signed-off-by: Matti Vaittinen
---
drivers/regulator/Kconfig | 11 +++
drivers/regulator/Makefile | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 097f61784a7d
Hello,
On Tue, May 29, 2018 at 08:39:58AM +0100, Lee Jones wrote:
> On Mon, 28 May 2018, Matti Vaittinen wrote:
>
> > Patch series adding support for ROHM BD71837 PMIC.
> FYI, this patch-set is going to be difficult to manage since it was
> not sent 'threaded'.
>
2, 3 and 4:
device tree binding documents.
Patch 5:
clock subsystem and support for gated clock.
Patch 6:
regulator driver supporting 8 bucks and 7 LDOs.
This patch series is based on for-mfd-next
---
Matti Vaittinen (6):
mfd: bd71837: mfd driver for ROHM BD71837 PMIC
mf
ROHM BD71837 PMIC MFD driver providing interrupts and support
for two subsystems:
- clk
- Regulators
Signed-off-by: Matti Vaittinen
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile| 1 +
drivers/mfd/bd71837.c | 224 ++
include/linux
Document devicetree bindings for ROHM BD71837 PMIC MFD.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 52 ++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
diff --git
Document devicetree bindings for ROHM BD71837 PMIC regulators.
Signed-off-by: Matti Vaittinen
---
.../bindings/regulator/rohm,bd71837-regulator.txt | 126 +
1 file changed, 126 insertions(+)
create mode 100644
Documentation/devicetree/bindings/regulator/rohm,bd71837
Document devicetree bindings for ROHM BD71837 PMIC clock output.
Signed-off-by: Matti Vaittinen
---
.../bindings/clock/rohm,bd71837-clock.txt | 37 ++
1 file changed, 37 insertions(+)
create mode 100644
Documentation/devicetree/bindings/clock/rohm,bd71837
Support BD71837 gateable 32768 Hz clock.
Signed-off-by: Matti Vaittinen
---
drivers/clk/Kconfig | 9 +++
drivers/clk/Makefile | 1 +
drivers/clk/clk-bd71837.c | 154 ++
3 files changed, 164 insertions(+)
create mode 100644 drivers/clk
Support for controlling the 8 bucks and 7 LDOs the PMIC contains.
Signed-off-by: Matti Vaittinen
---
drivers/regulator/Kconfig | 11 +
drivers/regulator/Makefile| 1 +
drivers/regulator/bd71837-regulator.c | 677 ++
3 files changed, 689
Hello,
On Tue, May 29, 2018 at 12:47:40PM +0100, Mark Brown wrote:
> On Tue, May 29, 2018 at 01:02:15PM +0300, Matti Vaittinen wrote:
>
> > @@ -0,0 +1,677 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright (C) 2018 ROHM Semiconductors */
> > +/*
&g
On Fri, Jun 01, 2018 at 12:32:16PM -0500, Rob Herring wrote:
> On Fri, Jun 1, 2018 at 1:25 AM, Matti Vaittinen
> wrote:
> > On Thu, May 31, 2018 at 09:07:24AM -0500, Rob Herring wrote:
> >> On Thu, May 31, 2018 at 5:23 AM, Matti Vaittinen
> >> wrote:
> >&g
ROHM BD71837 PMIC MFD driver providing interrupts and support
for two subsystems:
- clk
- Regulators
Signed-off-by: Matti Vaittinen
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile| 1 +
drivers/mfd/bd71837.c | 223 ++
include/linux
MFD driver and definitions bringing interrupt support and
enabling clk and regulator subsystems.
Patches 2 and 3
This patch series is based on for-mfd-next
---
Matti Vaittinen (4):
mfd: bd71837: mfd driver for ROHM BD71837 PMIC
mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC
Support BD71837 gateable 32768 Hz clock.
Signed-off-by: Matti Vaittinen
---
drivers/clk/Kconfig | 7 +++
drivers/clk/Makefile | 1 +
drivers/clk/clk-bd71837.c | 146 ++
3 files changed, 154 insertions(+)
create mode 100644 drivers/clk
Document devicetree bindings for ROHM BD71837 PMIC clock output.
Signed-off-by: Matti Vaittinen
---
.../bindings/clock/rohm,bd71837-clock.txt | 38 ++
1 file changed, 38 insertions(+)
create mode 100644
Documentation/devicetree/bindings/clock/rohm,bd71837
Document devicetree bindings for ROHM BD71837 PMIC MFD.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 76 ++
1 file changed, 76 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
diff --git
On Mon, Jun 04, 2018 at 04:18:07PM +0300, Matti Vaittinen wrote:
> +static struct regmap_irq_chip bd71837_irq_chip = {
> + .name = "bd71837-irq",
> + .irqs = bd71837_irqs,
> + .num_irqs = ARRAY_SIZE(bd71837_irqs),
> + .num_regs = 1,
> + .irq_reg_stri
On Tue, Jun 05, 2018 at 09:49:32AM -0600, Rob Herring wrote:
> On Mon, Jun 04, 2018 at 04:18:53PM +0300, Matti Vaittinen wrote:
> > Document devicetree bindings for ROHM BD71837 PMIC clock output.
> >
> > Signed-off-by: Matti Vaittinen
> > ---
> > .../bind
On Tue, Jun 05, 2018 at 09:47:57AM -0600, Rob Herring wrote:
> On Mon, Jun 04, 2018 at 04:18:30PM +0300, Matti Vaittinen wrote:
> > Document devicetree bindings for ROHM BD71837 PMIC MFD.
> >
> > Signed-off-by: Matti Vaittinen
> > ---
> > .../devicetree/binding
On Tue, Jun 05, 2018 at 10:46:14AM -0500, Rob Herring wrote:
> On Mon, Jun 4, 2018 at 6:32 AM, Matti Vaittinen
> wrote:
> > On Fri, Jun 01, 2018 at 12:32:16PM -0500, Rob Herring wrote:
> >> On Fri, Jun 1, 2018 at 1:25 AM, Matti Vaittinen
> >> wrote:
> >&g
On Tue, Jun 05, 2018 at 04:58:43PM +0300, Andy Shevchenko wrote:
> On Tue, May 29, 2018 at 1:02 PM, Matti Vaittinen
> wrote:
> > Support for controlling the 8 bucks and 7 LDOs the PMIC contains.
>
Thanks for the comments Andy. The regulator part of patch set v4 was
already appl
On Wed, Jun 06, 2018 at 10:16:37AM -0500, Rob Herring wrote:
> On Wed, Jun 6, 2018 at 2:34 AM, Matti Vaittinen
> wrote:
> > On Tue, Jun 05, 2018 at 10:46:14AM -0500, Rob Herring wrote:
> >> On Mon, Jun 4, 2018 at 6:32 AM, Matti Vaittinen
> >> wrote:
> >&g
...@fi.rohmeurope.com/
and I thought it already had the Reviewed-by tag from you :)
On Fri, Feb 22, 2019 at 06:30:41PM -0600, Rob Herring wrote:
> On Tue, Jan 22, 2019 at 11:45:38AM +0200, Matti Vaittinen wrote:
> > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > drivers) and 4 GPIO
Hello Lee and Mark,
On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote:
> Patch series introducing support for ROHM BD70528 PMIC
>
> ROHM BD70528 is a programmable Power Management IC for battery
> powered 'ultra low power' systems like the pre-announced NXP
&
Hello Lee, Mark,
On Thu, Feb 28, 2019 at 08:10:55AM +, Lee Jones wrote:
> On Thu, 28 Feb 2019, Matti Vaittinen wrote:
>
> > Hello Lee and Mark,
> >
> > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote:
> > > Patch series introducing support f
Split the bd718x7.h to ROHM common and bd718x7 specific parts
so that we do not need to add same things in every new ROHM
PMIC header. Please note that this change requires changes also
in bd718x7 sub-device drivers for regulators and clk.
Signed-off-by: Matti Vaittinen
Acked-by: Mark Brown
bd718x7 clk driver
Patch 4:
document DT bindings for BD70528
Patch 5:
support BD70528 GPIO block
Patch 6:
support BD70528 RTC
Patch 7:
support BD70528 battery charger
Patch 8:
support BD70528 watchdog
This patch series is based on Linus' v5.1-rc2 tag.
---
clk
- RTC
- watchdog
Signed-off-by: Matti Vaittinen
---
Changelog v13:
- Moved WDT enable/disable code to WDT driver
- Created WDT enable/disable stubs for cases where WDT is not compiled
in
Changelog v12:
- No functional changes.
- Fixed styling issues pointed by Lee Jones
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as
bd718x7. Only difference (from clk perspective) is register address.
Add support for controlling BD70528 clk using bd718x7 driver.
Signed-off-by: Matti Vaittinen
Acked-by: Stephen Boyd
---
Changelog v13:
- No changes
Changelog v12
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be
controlled by GPIO framework.
IRQs are handled by regmap-irq and GPIO driver is not
aware of the irq usage.
Signed-off-by: Matti Vaittinen
Reviewed-by: Linus Walleij
---
Changelog v13:
- No changes
Changelog v12:
- No functional changes
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
drivers) and 4 GPIO pins which can be configured for I/O or
as interrupt sources withe configurable trigger levels.
Signed-off-by: Matti Vaittinen
Reviewed-by: Rob Herring
Acked-by: Linus Walleij
---
Changelog v13:
- No changes
also the alarm interrupt to
this 24 hours for the sake of consistency.
Signed-off-by: Matti Vaittinen
Acked-by: Alexandre Belloni
---
Changelog v13:
- No changes
Changelog v12:
- No functional changes
- Few styling fixes
drivers/rtc/Kconfig | 8 +
drivers/rtc/Makefile | 1
ROHM BD70528 PMIC includes battery charger block. Support charger
staus queries and doing few basic settings like input current limit
and charging current.
Signed-off-by: Matti Vaittinen
---
Changelog v13:
- no changes
Changelog v12:
- Styling fixes only
drivers/power/supply/Kconfig
Initial support for watchdog block included in ROHM BD70528
power management IC.
Configurations for low power states are still to be checked.
Signed-off-by: Matti Vaittinen
Acked-by: Guenter Roeck
---
Changelog v13
- Moved WDT enable/disable code from MFD to WDT as was (strongly) suggested
On Mon, Feb 04, 2019 at 06:38:43AM -0800, Guenter Roeck wrote:
> On 2/4/19 4:49 AM, Matti Vaittinen wrote:
> > Initial support for watchdog block included in ROHM BD70528
> > power management IC.
> >
> > Configurations for low power states are still to be checked.
&g
101 - 200 of 875 matches
Mail list logo
