[RFC PATCH v2 10/10] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-01-25 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen --- drivers/watchdog/Kconfig | 12 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/bd70528_wdt.c

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Matti Vaittinen
WDT functions > > should be exported from WDT - then please ignore the v12. I'll do v13 > > at the afternoon (my time, which is only a bit after noon your time I > > guess) which will export these functions from WDT. (Well, I had to try > > once more :D) > > Please ke

[PATCH v13 0/8] support ROHM BD70528 PMIC

2019-04-04 Thread Matti Vaittinen
support BD70528 GPIO block Patch 6: support BD70528 RTC Patch 7: support BD70528 battery charger Patch 8: support BD70528 watchdog This patch series is based on Linus' v5.1-rc2 tag. --- Matti Vaittinen (8): mfd: regulator: clk: split rohm-bd718x7.h mfd: bd705

[PATCH v13 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-04-04 Thread Matti Vaittinen
Split the bd718x7.h to ROHM common and bd718x7 specific parts so that we do not need to add same things in every new ROHM PMIC header. Please note that this change requires changes also in bd718x7 sub-device drivers for regulators and clk. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown

[PATCH v13 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Matti Vaittinen
clk - RTC - watchdog Signed-off-by: Matti Vaittinen --- Changelog v13: - Moved WDT enable/disable code to WDT driver - Created WDT enable/disable stubs for cases where WDT is not compiled in Changelog v12: - No functional changes. - Fixed styling issues pointed by Lee Jones

[PATCH v13 3/8] clk: bd718x7: Support ROHM BD70528 clk block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as bd718x7. Only difference (from clk perspective) is register address. Add support for controlling BD70528 clk using bd718x7 driver. Signed-off-by: Matti Vaittinen Acked-by: Stephen Boyd --- Changelog v13: - No changes Changelog v12

[PATCH v13 4/8] dt-bindings: mfd: Document first ROHM BD70528 bindings

2019-04-04 Thread Matti Vaittinen
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED drivers) and 4 GPIO pins which can be configured for I/O or as interrupt sources withe configurable trigger levels. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-by: Linus Walleij --- Changelog v13: - No changes

[PATCH v13 5/8] gpio: Initial support for ROHM bd70528 GPIO block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be controlled by GPIO framework. IRQs are handled by regmap-irq and GPIO driver is not aware of the irq usage. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Changelog v13: - No changes Changelog v12: - No functional changes

[PATCH v13 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-04-04 Thread Matti Vaittinen
also the alarm interrupt to this 24 hours for the sake of consistency. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Changelog v13: - No changes Changelog v12: - No functional changes - Few styling fixes drivers/rtc/Kconfig | 8 + drivers/rtc/Makefile | 1

[PATCH v13 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 PMIC includes battery charger block. Support charger staus queries and doing few basic settings like input current limit and charging current. Signed-off-by: Matti Vaittinen --- Changelog v13: - no changes Changelog v12: - Styling fixes only drivers/power/supply/Kconfig

[PATCH v13 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-04-04 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- Changelog v13 - Moved WDT enable/disable code from MFD to WDT as was (strongly) suggested

Re: [PATCH RESEND v13 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-05-02 Thread Matti Vaittinen
Hello Sebastian, Thanks for the review. This is highly appreciated as charger subsystem is new to me =) On Thu, May 02, 2019 at 12:25:35AM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Apr 25, 2019 at 02:16:51PM +0300, Matti Vaittinen wrote: > > ROHM BD70528 PMIC includes

[PATCH v14 0/8] support ROHM BD70528 PMIC

2019-05-02 Thread Matti Vaittinen
s for BD70528 Patch 5: support BD70528 GPIO block Patch 6: support BD70528 RTC Patch 7: support BD70528 battery charger Patch 8: support BD70528 watchdog This patch series is based on Linus' v5.1-rc2 tag. --- Matti Vaittinen (8): mfd: regulator: clk: split

[PATCH v14 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-05-02 Thread Matti Vaittinen
Split the bd718x7.h to ROHM common and bd718x7 specific parts so that we do not need to add same things in every new ROHM PMIC header. Please note that this change requires changes also in bd718x7 sub-device drivers for regulators and clk. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown

[PATCH v14 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-05-02 Thread Matti Vaittinen
clk - RTC - watchdog Signed-off-by: Matti Vaittinen --- Changelog v14: No changes drivers/mfd/Kconfig | 17 ++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm-bd70528.c | 316 include/linux/mfd/rohm-bd70528.h | 408

[PATCH v14 3/8] clk: bd718x7: Support ROHM BD70528 clk block

2019-05-02 Thread Matti Vaittinen
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as bd718x7. Only difference (from clk perspective) is register address. Add support for controlling BD70528 clk using bd718x7 driver. Signed-off-by: Matti Vaittinen Acked-by: Stephen Boyd --- Changelog v14: No changes drivers/clk

[PATCH v14 4/8] dt-bindings: mfd: Document first ROHM BD70528 bindings

2019-05-02 Thread Matti Vaittinen
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED drivers) and 4 GPIO pins which can be configured for I/O or as interrupt sources withe configurable trigger levels. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-by: Linus Walleij --- Changelog v14: No changes

[PATCH v14 5/8] gpio: Initial support for ROHM bd70528 GPIO block

2019-05-02 Thread Matti Vaittinen
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be controlled by GPIO framework. IRQs are handled by regmap-irq and GPIO driver is not aware of the irq usage. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Changelog v14: No changes drivers/gpio/Kconfig| 11

[PATCH v14 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-05-02 Thread Matti Vaittinen
also the alarm interrupt to this 24 hours for the sake of consistency. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- Changelog v14: No changes drivers/rtc/Kconfig | 8 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-bd70528.c | 500

[PATCH v14 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-05-02 Thread Matti Vaittinen
ROHM BD70528 PMIC includes battery charger block. Support charger staus queries and doing few basic settings like input current limit and charging current. Signed-off-by: Matti Vaittinen Acked-by: Sebastian Reichel --- Changelog v14: - constify and statictze few structs - use dev_get_regmap

[PATCH v14 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-05-02 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- Changelog v14: No changes drivers/watchdog/Kconfig | 12 ++ drivers/watchdog

[PATCH] rtc: bd70528: fix driver dependencies

2019-08-11 Thread Matti Vaittinen
og is not compiled at all the stub functions for watchdog control are used. compiling the RTC without watchdog is fine. Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC") Suggested-by: Arnd Bergmann Reported-by: kbuild test robot Signed-off-by: Matti Vaittinen ---

Re: [RFC PATCH] arm64: dts: fsl: wandboard: Add a device tree for the PICO-PI-IMX8M

2019-06-23 Thread Matti Vaittinen
mpatible = "ldo5"; > + regulator-min-microvolt = <180>; > + regulator-max-microvolt = <330>; > + regulator-boot-on; > + regulator-always-on; You may want to mark the BU

Re: [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state

2019-02-12 Thread Matti Vaittinen
Hello Mark, On Tue, Feb 12, 2019 at 04:08:31PM +, Mark Brown wrote: > On Tue, Feb 12, 2019 at 04:19:38PM +0200, Matti Vaittinen wrote: > > read ROHM BD71837 / BD71847 specific device tree bindings for > > controlling the PMIC shutdown/reset states and voltages for > > dif

Re: [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state

2019-02-13 Thread Matti Vaittinen
his as "rohm,regulator-crucial-for-boot". > > I just think I need to document that those flags are required > for critical regulators if SNVS is used as reset target even if there > should be no one touching those regulators. Anyways, this is still valid - I'll prepar

[PATCH v2 0/3] bd718x7: Support SNVS low power state

2019-02-13 Thread Matti Vaittinen
of regulator-always-on and regulator-boot-on --- Matti Vaittinen (3): devicetree: bindings: bd718x7: document HW state related ROHM specific properties regulator: add regulator_desc_list_voltage_linear_range regulator: bd718x7: Support SNVS low power state .../devicetree/bindings

[PATCH v2 1/3] devicetree: bindings: bd718x7: document HW state related ROHM specific properties

2019-02-13 Thread Matti Vaittinen
regulators which are critical for boot. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 15 +++ .../bindings/regulator/rohm,bd71837-regulator.txt | 30 ++ 2 files changed, 45 insertions(+) diff --git a/Documentation/devicetree

[PATCH v2 2/3] regulator: add regulator_desc_list_voltage_linear_range

2019-02-13 Thread Matti Vaittinen
Add regulator_desc_list_voltage_linear_range which can be used by drivers for getting the voltages before regulator is registered. This may be useful for drivers which need to fetch the voltage selectors at device-tree parsing callback. Signed-off-by: Matti Vaittinen --- drivers/regulator

[PATCH v2 3/3] regulator: bd718x7: Support SNVS low power state

2019-02-13 Thread Matti Vaittinen
regulators which are critical for boot. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd718x7-regulator.c | 201 +- 1 file changed, 176 insertions(+), 25 deletions(-) diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c

[PATCH v9 0/8] support ROHM BD70528 PMIC

2019-02-13 Thread Matti Vaittinen
support BD70528 battery charger Patch 8: support BD70528 watchdog This patch series is based on Mark's regulator/for-next branch --- Matti Vaittinen (8): mfd: regulator: clk: split rohm-bd718x7.h mfd: bd70528: Support ROHM bd70528 PMIC - core clk: bd718x7: Support ROHM BD70

[PATCH v9 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-02-13 Thread Matti Vaittinen
Split the bd718x7.h to ROHM common and bd718x7 specific parts so that we do not need to add same things in every new ROHM PMIC header. Please note that this change requires changes also in bd718x7 sub-device drivers for regulators and clk. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown

[PATCH v9 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-13 Thread Matti Vaittinen
clk - RTC - watchdog Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 17 ++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm-bd70528.c | 397 +++ include/linux/mfd/rohm-bd70528.h | 392

[PATCH v9 3/8] clk: bd718x7: Support ROHM BD70528 clk block

2019-02-13 Thread Matti Vaittinen
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as bd718x7. Only difference (from clk perspective) is register address. Add support for controlling BD70528 clk using bd718x7 driver. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 6 +++--- drivers/clk/clk-bd718x7.c

[PATCH v9 4/8] devicetree: bindings: Document first ROHM BD70528 bindings

2019-02-13 Thread Matti Vaittinen
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED drivers) and 4 GPIO pins which can be configured for I/O or as interrupt sources withe configurable trigger levels. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-by: Linus Walleij --- I maintained reviewed-by and

[PATCH v9 5/8] gpio: Initial support for ROHM bd70528 GPIO block

2019-02-13 Thread Matti Vaittinen
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be controlled by GPIO framework. IRQs are handled by regmap-irq and GPIO driver is not aware of the irq usage. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig| 11 +++ drivers/gpio/Makefile

[PATCH v9 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-02-13 Thread Matti Vaittinen
also the alarm interrupt to this 24 hours for the sake of consistency. Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni --- I maintained the ack from Alexandre as the only change is using function exported by MFD instead of the pointer provided by MFD. Please let me know if this is not Ok

[PATCH v9 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-02-13 Thread Matti Vaittinen
ROHM BD70528 PMIC includes battery charger block. Support charger staus queries and doing few basic settings like input current limit and charging current. Signed-off-by: Matti Vaittinen --- drivers/power/supply/Kconfig | 9 + drivers/power/supply/Makefile | 1 + drivers

[PATCH v9 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-02-13 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- I maintained the ack from Guenter as only change is to use function exported by MFD instead

Re: [PATCH v10 0/9] support ROHM BD70528 PMIC

2019-03-25 Thread Matti Vaittinen
Hello again Lee & all, On Thu, Feb 28, 2019 at 10:22:48AM +0200, Matti Vaittinen wrote: > On Thu, Feb 28, 2019 at 08:10:55AM +, Lee Jones wrote: > > On Thu, 28 Feb 2019, Matti Vaittinen wrote: > > > > > Hello Lee and Mark, > > > > > > O

Re: [PATCH v10 0/9] support ROHM BD70528 PMIC

2019-03-25 Thread Matti Vaittinen
On Mon, Mar 25, 2019 at 08:02:06AM +, Lee Jones wrote: > On Mon, 25 Mar 2019, Matti Vaittinen wrote: > > > Hello again Lee & all, > > > > On Thu, Feb 28, 2019 at 10:22:48AM +0200, Matti Vaittinen wrote: > > > On Thu, Feb 28, 2019 at 08:10:55AM +, Le

[PATCH v11 0/8] support ROHM BD70528 PMIC

2019-03-25 Thread Matti Vaittinen
0528 GPIO block Patch 6: support BD70528 RTC Patch 7: support BD70528 battery charger Patch 8: support BD70528 watchdog This patch series is based on Linus' v5.1-rc2 tag. --- Matti Vaittinen (8): mfd: regulator: clk: split rohm-bd718x7.h mfd: bd70528: Support

[PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-03-25 Thread Matti Vaittinen
clk - RTC - watchdog Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 17 ++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm-bd70528.c | 438 +++ include/linux/mfd/rohm-bd70528.h | 383 +++ 4

[PATCH v11 3/8] clk: bd718x7: Support ROHM BD70528 clk block

2019-03-25 Thread Matti Vaittinen
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as bd718x7. Only difference (from clk perspective) is register address. Add support for controlling BD70528 clk using bd718x7 driver. Signed-off-by: Matti Vaittinen Acked-by: Stephen Boyd --- drivers/clk/Kconfig | 6

[PATCH v11 4/8] dt-bindings: mfd: Document first ROHM BD70528 bindings

2019-03-25 Thread Matti Vaittinen
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED drivers) and 4 GPIO pins which can be configured for I/O or as interrupt sources withe configurable trigger levels. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-by: Linus Walleij --- .../bindings/mfd/rohm,bd70528

[PATCH v11 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-03-25 Thread Matti Vaittinen
Split the bd718x7.h to ROHM common and bd718x7 specific parts so that we do not need to add same things in every new ROHM PMIC header. Please note that this change requires changes also in bd718x7 sub-device drivers for regulators and clk. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown

[PATCH v11 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-03-25 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- drivers/watchdog/Kconfig | 12 +++ drivers/watchdog/Makefile | 1 + drivers

[PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-03-25 Thread Matti Vaittinen
also the alarm interrupt to this 24 hours for the sake of consistency. Signed-off-by: Matti Vaittinen --- drivers/rtc/Kconfig | 8 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-bd70528.c | 500 ++ 3 files changed, 509 insertions(+) create mode

[PATCH v11 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-03-25 Thread Matti Vaittinen
ROHM BD70528 PMIC includes battery charger block. Support charger staus queries and doing few basic settings like input current limit and charging current. Signed-off-by: Matti Vaittinen --- drivers/power/supply/Kconfig | 9 + drivers/power/supply/Makefile | 1 + drivers

[PATCH v11 5/8] gpio: Initial support for ROHM bd70528 GPIO block

2019-03-25 Thread Matti Vaittinen
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be controlled by GPIO framework. IRQs are handled by regmap-irq and GPIO driver is not aware of the irq usage. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig| 11 ++ drivers/gpio/Makefile | 1

Re: [PATCH v10 0/9] support ROHM BD70528 PMIC

2019-03-06 Thread Matti Vaittinen
On Thu, Feb 28, 2019 at 11:40:26AM +, Mark Brown wrote: > On Thu, Feb 28, 2019 at 09:04:50AM +0200, Matti Vaittinen wrote: > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > >> Patch series introducing support for ROHM BD70528 PMIC > > >

Re: [PATCH 2/8] regulator: Support ROHM BD71847 power management IC

2018-09-11 Thread Matti Vaittinen
Hello Lee, Thanks again for the review! I see you did bunch of them... I really admire your devotion. For me reviewing is hard work. I do appreciate it. So nice to see you're back in the business =) On Tue, Sep 11, 2018 at 02:48:08PM +0100, Lee Jones wrote: > On Wed, 29 Aug 2018, Matti V

Re: [PATCH 7/8] regulator: bd718XX use pickable ranges

2018-09-12 Thread Matti Vaittinen
Hello, On Tue, Sep 11, 2018 at 02:55:49PM +0100, Lee Jones wrote: > On Wed, 29 Aug 2018, Matti Vaittinen wrote: > > > Few regulators in BD71837 and BD71847 can output voltages from > > different voltage ranges. Register interface is arranged so that > > used range is s

Re: [PATCH 4/8] mfd: dt bindings: add BD71847 device-tree binding documentation

2018-09-12 Thread Matti Vaittinen
On Tue, Sep 11, 2018 at 02:49:47PM +0100, Lee Jones wrote: > On Wed, 29 Aug 2018, Matti Vaittinen wrote: > > > Add ROHM BD71847 Power Management IC MFD binding information to > > device-tree binding documents. > > > > Signed-off-by: Matti Vaittinen > > --- &

Re: [PATCH 1/8] regulator: bd71837: Disable voltage monitoring for LDO3/4

2018-09-12 Thread Matti Vaittinen
On Tue, Sep 11, 2018 at 01:40:29PM +0100, Lee Jones wrote: > On Wed, 29 Aug 2018, Matti Vaittinen wrote: > > > There is a HW quirk in BD71837. The shutdown sequence timings for > > bucks/LDOs which are enabled via register interface are changed. > > At PMIC poweroff the vo

Re: [PATCH 1/8] regulator: bd71837: Disable voltage monitoring for LDO3/4

2018-09-12 Thread Matti Vaittinen
On Wed, Sep 12, 2018 at 09:42:51AM +0100, Lee Jones wrote: > On Wed, 12 Sep 2018, Matti Vaittinen wrote: > > > On Tue, Sep 11, 2018 at 01:40:29PM +0100, Lee Jones wrote: > > > On Wed, 29 Aug 2018, Matti Vaittinen wrote: > > > > > > > There is a HW quirk

[PATCH v2 0/7] regulator/mfd/dt_bindings: bd718x7: Support ROHM bd71847

2018-09-12 Thread Matti Vaittinen
t using helpers from patch 5 Patch 8: Renaming bd71837 regulator driver to bd718x7 this patch series is based on linux-next tag next-20180912. Matti Vaittinen (7): regulator: Support ROHM BD71847 power management IC regulator: dt bindings: add BD71847 device-tree binding documentation m

[PATCH v2 1/7] regulator: Support ROHM BD71847 power management IC

2018-09-12 Thread Matti Vaittinen
BD71847 is reduced version of BD71837. DVS bucks 3 and 4 are removed as is LDO7. Voltage ranges of some regulators are expanded. Add initial support for BD71847 with BD71837 driver. Signed-off-by: Matti Vaittinen --- drivers/mfd/rohm-bd718x7.c| 68 +-- drivers/regulator/bd71837

[PATCH v2 2/7] regulator: dt bindings: add BD71847 device-tree binding documentation

2018-09-12 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC regulator binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- .../devicetree/bindings/regulator/rohm,bd71837-regulator.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH v2 3/7] mfd: dt bindings: add BD71847 device-tree binding documentation

2018-09-12 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC MFD binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-for-MFD-by: Lee Jones --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 17 + 1 file changed, 9 insertions

[PATCH v2 4/7] regulator: Support regulators where voltage ranges are selectable

2018-09-12 Thread Matti Vaittinen
For example ROHM BD71837 and ROHM BD71847 Power management ICs have regulators which provide multiple linear ranges. Ranges can be selected by individual non contagious bit in vsel register. Add regmap helper functions for selecting ranges. Signed-off-by: Matti Vaittinen --- drivers/regulator

[PATCH v2 5/7] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances

2018-09-12 Thread Matti Vaittinen
Rename parts of code that support both BD71837 and BD71847 to BD718XX. Signed-off-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- drivers/mfd/rohm-bd718x7.c| 98 +-- drivers/regulator/bd71837-regulator.c | 24 - include/linux/mfd/rohm

[PATCH v2 6/7] regulator: bd718XX use pickable ranges

2018-09-12 Thread Matti Vaittinen
bits (as usual). Support BD71837 and BD71847 selectible range voltages using new pickable ranges helpers. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 155 +++--- include/linux/mfd/rohm-bd718x7.h | 34 2 files changed, 145

[PATCH v2 7/7] regulator: bd718xx: rename bd71837 to 718xx

2018-09-12 Thread Matti Vaittinen
rename bd71837-regulator.c to bd718x7-regulator.c to reflect the fact that also BD71847 is now supported by the driver. Signed-off-by: Matti Vaittinen --- drivers/regulator/Kconfig | 2 +- drivers/regulator/Makefile | 2

Re: [PATCH v2 5/7] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances

2018-09-13 Thread Matti Vaittinen
patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Matti-Vaittinen/regulator-mfd-dt_bindings-bd718x7-Support-ROHM-bd71847/20180914-000129 > base: https://git.kernel.org/pub/scm/linux/kerne

[PATCH v3 0/7] regulator/mfd/dt_bindings: bd718x7: Support ROHM bd71847

2018-09-14 Thread Matti Vaittinen
ator helpers Patch 6: Simple renaming plenty of BD71837 occurrences to BD718XX Patch 7: BD71837/BD71847 Full voltage range support using helpers from patch 5 Patch 8: Renaming bd71837 regulator driver to bd718x7 this patch series is based on linux-next tag next-20180912.

[PATCH v3 1/7] regulator/mfd: Support ROHM BD71847 power management IC

2018-09-14 Thread Matti Vaittinen
BD71847 is reduced version of BD71837. DVS bucks 3 and 4 are removed as is LDO7. Voltage ranges of some regulators are expanded. Add initial support for BD71847 with BD71837 driver. Signed-off-by: Matti Vaittinen --- drivers/mfd/rohm-bd718x7.c| 70 +-- drivers/regulator/bd71837

[PATCH v3 2/7] regulator: dt bindings: add BD71847 device-tree binding documentation

2018-09-14 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC regulator binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- .../devicetree/bindings/regulator/rohm,bd71837-regulator.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH v3 3/7] mfd: dt bindings: add BD71847 device-tree binding documentation

2018-09-14 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC MFD binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-for-MFD-by: Lee Jones --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 17 + 1 file changed, 9 insertions

[PATCH v3 4/7] regulator: Support regulators where voltage ranges are selectable

2018-09-14 Thread Matti Vaittinen
For example ROHM BD71837 and ROHM BD71847 Power management ICs have regulators which provide multiple linear ranges. Ranges can be selected by individual non contagious bit in vsel register. Add regmap helper functions for selecting ranges. Signed-off-by: Matti Vaittinen --- drivers/regulator

[PATCH v3 5/7] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances

2018-09-14 Thread Matti Vaittinen
Rename parts of code that support both BD71837 and BD71847 to BD718XX. Signed-off-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- drivers/mfd/rohm-bd718x7.c| 98 +-- drivers/regulator/bd71837-regulator.c | 26 +- include/linux/mfd/rohm

[PATCH v3 7/7] regulator: bd718xx: rename bd71837 to 718xx

2018-09-14 Thread Matti Vaittinen
rename bd71837-regulator.c to bd718x7-regulator.c to reflect the fact that also BD71847 is now supported by the driver. Signed-off-by: Matti Vaittinen --- drivers/regulator/Kconfig | 2 +- drivers/regulator/Makefile | 2

[PATCH v3 6/7] regulator: bd718XX use pickable ranges

2018-09-14 Thread Matti Vaittinen
bits (as usual). Support BD71837 and BD71847 selectible range voltages using new pickable ranges helpers. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 153 +++--- include/linux/mfd/rohm-bd718x7.h | 32 +++ 2 files changed, 143

Does Rockchip RK808 driver unload work as intended?

2018-09-07 Thread Matti Vaittinen
014 - well, chances are the driver does work and I just don't get it =) So can someone please shed some light on this? Is this a bug or am I just plain wrong? Br, Matti Vaittinen

Re: linux-next: build warning after merge of the regulator tree

2018-10-01 Thread Matti Vaittinen
of_device_get_match_data(&i2c->dev); is it possible one of the earlier versions has accidentally been applied? Should I create patch on top of the last regulator tree or what is the simplest way fix this? Br, Matti Vaittinen

Re: linux-next: build warning after merge of the regulator tree

2018-10-01 Thread Matti Vaittinen
Hello Stephen, Mark & All, On Tue, Oct 02, 2018 at 04:25:51PM +1000, Stephen Rothwell wrote: > On Tue, 2 Oct 2018 09:16:44 +0300 Matti Vaittinen > wrote: > > > > On Tue, Oct 02, 2018 at 01:07:48PM +1000, Stephen Rothwell wrote: > > > After merging the regulator

[PATCH] regulator: bd718xx: fix build warning on x86_64

2018-10-02 Thread Matti Vaittinen
Casting address to unsigned int causes a warning on some 64 bit architectures. Fix the cast. Signed-off-by: Matti Vaittinen --- Patch created against Mark's origin/topic/bd718xx. Fixes build warning reported by Stephen from linux-next. See: https://lore.kernel.org/lkml/20181002064317.G

Re: [PATCH] regulator/mfd: fix pointer-to-int cast

2018-10-02 Thread Matti Vaittinen
ext so I also did a patch fixing this. I think Mark alrady applied that patch to his tree. (https://lore.kernel.org/lkml/20181002145901.899d41121...@debutante.sirena.org.uk/) Br, Matti Vaittinen

Re: [PATCH v3 7/7] regulator: bd718xx: rename bd71837 to 718xx

2018-09-18 Thread Matti Vaittinen
plied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Matti-Vaittinen/regulator-mfd-dt_bindings-bd718x7-Support-ROHM-bd71847/20180914-210454 > base: https://git.kernel.org/pub/scm/linux/kernel/git/

[PATCH] regulator: bd718x7: add missing linux/of.h inclusion

2018-09-19 Thread Matti Vaittinen
0-Day tests found compilation error on x86. Driver won't compile on x86_64 as "of_match_ptr" is not found. Add missing include Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/bd71837

Re: Does Rockchip RK808 driver unload work as intended?

2018-09-10 Thread Matti Vaittinen
Hello, On Fri, Sep 07, 2018 at 01:19:40PM +0300, Matti Vaittinen wrote: > While doing this I hit to Rockchip RK808 driver which seems to utilize > oarent device (MFD dev) for pretty much all devm releasing. I wonder if > this is safe? What happens if one tries to remove the RK808 c

[PATCH] regulator: Fix pickable ranges mapping

2020-06-12 Thread Matti Vaittinen
, ret); base-commit: 0b0c0bd818ef76a20f58c3cb1ac96a3056ccb681 -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "

[PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names

2020-10-05 Thread Matti Vaittinen
Add regulator- prefix to allowed regulator node names. Prefix is expected by the driver and the actual binding yaml description. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] regulator: bd9576: Fix print

2020-10-05 Thread Matti Vaittinen
The print in probe is done using pr_info. Correct print call would be dev_dbg because: - Severity should really be dbg - The dev pointer is given as first argument Fixes: b014e9fae7e7de4329a7092ade4256982c5ce974 Signed-off-by: Matti Vaittinen --- Sorry folks! This should have never slip in

[PATCH v3 4/4] MAINTAINERS: Add ROHM BD9576MUF and BD9573MUF drivers

2020-09-29 Thread Matti Vaittinen
Add maintainer entries for ROHM BD9576MUF and ROHM BD9573MUF drivers. MFD, regulator and watchdog drivers were introduced for these PMICs. Signed-off-by: Matti Vaittinen --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5cfab015bd6

[PATCH v3 0/4] Support ROHM BD9576MUF and BD9573MUF PMICs

2020-09-29 Thread Matti Vaittinen
. Changelog v2: - dropped already applied regulator part - dt_bindings: Fix case for regulator-names in the example - watchdod: unify probe error check and revise includes --- Matti Vaittinen (4): dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs mfd: Support ROHM BD9576MUF and

[PATCH v3 1/4] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs

2020-09-29 Thread Matti Vaittinen
Add bindings for ROHM BD9576MUF and BD9573MUF PMICs. These PMICs are primarily intended to be used to power the R-Car series processors. They provide 6 power outputs, safety features and a watchdog with two functional modes. Signed-off-by: Matti Vaittinen --- Changes from v2: - Replace

[PATCH v3 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

2020-09-29 Thread Matti Vaittinen
Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are mainly used to power the R-Car series processors. Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 11 +++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm-bd9576.c| 130

[PATCH v3 3/4] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF

2020-09-29 Thread Matti Vaittinen
configured to detect only delayed ping or in a window mode where also too fast pings are detected. Signed-off-by: Matti Vaittinen --- Changes from v2: - Replace bindings hw_margin_ms and rohm,hw-margin-min-ms with rohm,hw-timeout-ms drivers/watchdog/Kconfig | 13 ++ drivers/watchdog

[PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()

2020-05-09 Thread Matti Vaittinen
When linear_ranges is compiled as module we get warning about missing MODULE_LICENSE(). Fix it by adding MODULE_LICENSE("GPL") as is suggested by SPDX and EXPORTs. Signed-off-by: Matti Vaittinen --- I saw Mark applied the linear-ranges patch. So I sent this fix as incremental pat

[PATCH] regulator: bd718x7: remove voltage change restriction from BD71847 LDOs

2020-05-13 Thread Matti Vaittinen
oltage has stabilized. ROHM HW colleagues measured the safety limit of 1000uS for guaranteeing the voltage has stabilized. Let's use that for starters and add confiurable stabilization wait-time later if needed. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd718x7-re

[PATCH 0/4] Support regulator ON/OFF by PMIC state machine.

2020-09-03 Thread Matti Vaittinen
allowing other to be still controlled using the driver. The driver can also be used to set voltages levels for all regulators no matter if enable/disable state is controlled by SW or HW. --- Matti Vaittinen (4): regulator: bd718x7 initialize regulator config only once dt-bindings: regulator

[PATCH 2/4] dt-bindings: regulator: bd71837: add property for omitting ON/OFF control

2020-09-03 Thread Matti Vaittinen
state machine control. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71837-regulator.yaml| 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd71837-regulator.yaml b/Documentation/devicetree/bindings/regulator

[PATCH 3/4] dt-bindings: regulator: bd71847: add property for omitting ON/OFF control

2020-09-03 Thread Matti Vaittinen
state machine control. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71847-regulator.yaml| 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd71847-regulator.yaml b/Documentation/devicetree/bindings/regulator

[PATCH 1/4] regulator: bd718x7 initialize regulator config only once

2020-09-03 Thread Matti Vaittinen
The BD718x7 driver initialized common configs for all regulators. Simplify initialization by moving the initialization of common configs out of the loop. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd718x7-regulator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 4/4] regulator: bd718x7 fix regulator states at SUSPEND

2020-09-03 Thread Matti Vaittinen
state machine control. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd718x7-regulator.c | 417 +- 1 file changed, 268 insertions(+), 149 deletions(-) diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c index a72031595b9e.

[PATCH v4 0/4] Support ROHM BD9576MUF and BD9573MUF PMICs

2020-10-28 Thread Matti Vaittinen
um) from the DT binding doc Changelog v3: - use only one binding to specify watchdog time-out window. Changelog v2: - dropped already applied regulator part - dt_bindings: Fix case for regulator-names in the example - watchdod: unify probe error check and revise includes --- Mat

[PATCH v4 1/4] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs

2020-10-28 Thread Matti Vaittinen
Add bindings for ROHM BD9576MUF and BD9573MUF PMICs. These PMICs are primarily intended to be used to power the R-Car series processors. They provide 6 power outputs, safety features and a watchdog with two functional modes. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- Changes

[PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

2020-10-28 Thread Matti Vaittinen
Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are mainly used to power the R-Car series processors. Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 11 +++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm-bd9576.c| 130

[PATCH v4 4/4] MAINTAINERS: Add ROHM BD9576MUF and BD9573MUF drivers

2020-10-28 Thread Matti Vaittinen
Add maintainer entries for ROHM BD9576MUF and ROHM BD9573MUF drivers. MFD, regulator and watchdog drivers were introduced for these PMICs. Signed-off-by: Matti Vaittinen --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e73636b75f29

[PATCH v4 3/4] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF

2020-10-28 Thread Matti Vaittinen
configured to detect only delayed ping or in a window mode where also too fast pings are detected. Signed-off-by: Matti Vaittinen Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 13 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/bd9576_wdt.c | 290

<    3   4   5   6   7   8   9   >