Re: pci driver loads right after unload

2018-01-03 Thread Max Gurtovoy
Hi Greg/Bjorn, On 1/2/2018 9:27 PM, Greg Kroah-Hartman wrote: On Tue, Jan 02, 2018 at 01:00:03PM -0600, Bjorn Helgaas wrote: [+cc Greg, linux-kernel] Hi Max, Thanks for the report! On Tue, Jan 02, 2018 at 01:50:23AM +0200, Max Gurtovoy wrote: hi all, I encountered a strange phenomena using

Re: [PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

2017-08-03 Thread Max Gurtovoy
On 8/3/2017 12:28 PM, Johannes Thumshirn wrote: NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Looks good, Reviewed-by: Max Gurtovoy <m...@mellanox.com>

Re: [PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

2017-08-03 Thread Max Gurtovoy
On 8/3/2017 12:28 PM, Johannes Thumshirn wrote: NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it. Signed-off-by: Johannes Thumshirn --- Looks good, Reviewed-by: Max Gurtovoy

Re: [GIT pull] irq updates for 4.13

2017-07-06 Thread Max Gurtovoy
On 7/4/2017 11:48 PM, Max Gurtovoy wrote: On 7/4/2017 10:10 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Linus Torvalds wrote: On Tue, Jul 4, 2017 at 8:17 AM, Jens Axboe <ax...@kernel.dk> wrote: On 07/03/2017 06:00 PM, Linus Torvalds wrote: If they ever do come online, does th

Re: [GIT pull] irq updates for 4.13

2017-07-06 Thread Max Gurtovoy
On 7/4/2017 11:48 PM, Max Gurtovoy wrote: On 7/4/2017 10:10 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Linus Torvalds wrote: On Tue, Jul 4, 2017 at 8:17 AM, Jens Axboe wrote: On 07/03/2017 06:00 PM, Linus Torvalds wrote: If they ever do come online, does that get fixed? I don't

Re: [GIT pull] irq updates for 4.13

2017-07-04 Thread Max Gurtovoy
On 7/4/2017 10:10 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Linus Torvalds wrote: On Tue, Jul 4, 2017 at 8:17 AM, Jens Axboe wrote: On 07/03/2017 06:00 PM, Linus Torvalds wrote: If they ever do come online, does that get fixed? I don't know. Somebody should check.

Re: [GIT pull] irq updates for 4.13

2017-07-04 Thread Max Gurtovoy
On 7/4/2017 10:10 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Linus Torvalds wrote: On Tue, Jul 4, 2017 at 8:17 AM, Jens Axboe wrote: On 07/03/2017 06:00 PM, Linus Torvalds wrote: If they ever do come online, does that get fixed? I don't know. Somebody should check. Yes, the blk-mq

Re: block: spread MSI(-X) vectors to all possible CPUs

2017-07-03 Thread Max Gurtovoy
On 6/27/2017 9:24 PM, Jens Axboe wrote: On 06/26/2017 04:20 AM, Christoph Hellwig wrote: Hi all, this series contains the left-over block bits to spread the MSI-X vectors over all CPU. Thomas already rewrote and then merged the irq bits into the tip irq/core branch, and this is the

Re: block: spread MSI(-X) vectors to all possible CPUs

2017-07-03 Thread Max Gurtovoy
On 6/27/2017 9:24 PM, Jens Axboe wrote: On 06/26/2017 04:20 AM, Christoph Hellwig wrote: Hi all, this series contains the left-over block bits to spread the MSI-X vectors over all CPU. Thomas already rewrote and then merged the irq bits into the tip irq/core branch, and this is the

Re: [PATCH v5 5/9] nvmet: implement namespace identify descriptor list

2017-06-07 Thread Max Gurtovoy
on as well. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.com> --- Looks good, Reviewed-by: Max Gurtovoy <m...@mellanox.com>

Re: [PATCH v5 5/9] nvmet: implement namespace identify descriptor list

2017-06-07 Thread Max Gurtovoy
on as well. Signed-off-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke --- Looks good, Reviewed-by: Max Gurtovoy

Re: [PATCH] nvme-rdma: remove race conditions from IB signalling

2017-06-05 Thread Max Gurtovoy
On 6/5/2017 12:45 PM, Marta Rybczynska wrote: This patch improves the way the RDMA IB signalling is done by using atomic operations for the signalling variable. This avoids race conditions on sig_count. The signalling interval changes slightly and is now the largest power of two not larger

Re: [PATCH] nvme-rdma: remove race conditions from IB signalling

2017-06-05 Thread Max Gurtovoy
On 6/5/2017 12:45 PM, Marta Rybczynska wrote: This patch improves the way the RDMA IB signalling is done by using atomic operations for the signalling variable. This avoids race conditions on sig_count. The signalling interval changes slightly and is now the largest power of two not larger

Re: [PATCH v4 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE

2017-06-04 Thread Max Gurtovoy
Looks good, Reviewed-by: Max Gurtovoy <m...@mellanox.com>

Re: [PATCH v4 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE

2017-06-04 Thread Max Gurtovoy
Looks good, Reviewed-by: Max Gurtovoy

Re: [PATCH v4 4/8] nvmet: add uuid field to nvme_ns and populate via configfs

2017-06-04 Thread Max Gurtovoy
On 6/4/2017 1:36 PM, Johannes Thumshirn wrote: Add the UUID field from the NVMe Namespace Identification Descriptor to the nvmet_ns structure and allow it's population via configfs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Looks good, Reviewed-by: Max Gurto

Re: [PATCH v4 4/8] nvmet: add uuid field to nvme_ns and populate via configfs

2017-06-04 Thread Max Gurtovoy
On 6/4/2017 1:36 PM, Johannes Thumshirn wrote: Add the UUID field from the NVMe Namespace Identification Descriptor to the nvmet_ns structure and allow it's population via configfs. Signed-off-by: Johannes Thumshirn Looks good, Reviewed-by: Max Gurtovoy

Re: [PATCH v2 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-01 Thread Max Gurtovoy
On 6/1/2017 2:17 PM, Johannes Thumshirn wrote: Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) Looks good, Reviewed-by: Max Gurtovoy <m...@mellanox.com>

Re: [PATCH v2 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-01 Thread Max Gurtovoy
On 6/1/2017 2:17 PM, Johannes Thumshirn wrote: Signed-off-by: Johannes Thumshirn --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) Looks good, Reviewed-by: Max Gurtovoy

Re: [PATCH v1 4/7] nvme: get list of namespace descriptors

2017-05-31 Thread Max Gurtovoy
On 5/31/2017 4:32 PM, Johannes Thumshirn wrote: If a target identifies itself as NVMe 1.3 compliant, try to get the list of Namespace Identification Descriptors and populate the UUID, NGUID and EUI64 fileds in the NVMe namespace structure with these values. Signed-off-by: Johannes Thumshirn

Re: [PATCH v1 4/7] nvme: get list of namespace descriptors

2017-05-31 Thread Max Gurtovoy
On 5/31/2017 4:32 PM, Johannes Thumshirn wrote: If a target identifies itself as NVMe 1.3 compliant, try to get the list of Namespace Identification Descriptors and populate the UUID, NGUID and EUI64 fileds in the NVMe namespace structure with these values. Signed-off-by: Johannes Thumshirn

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

2017-04-19 Thread Max Gurtovoy
On 4/19/2017 12:38 PM, Johannes Thumshirn wrote: On Wed, Apr 19, 2017 at 12:33:09PM +0300, Max Gurtovoy wrote: Hi Logan, On 4/19/2017 2:32 AM, Logan Gunthorpe wrote: This is safer as it doesn't rely on the data being stored in a single page in an sgl. It also aids our effort to start

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

2017-04-19 Thread Max Gurtovoy
On 4/19/2017 12:38 PM, Johannes Thumshirn wrote: On Wed, Apr 19, 2017 at 12:33:09PM +0300, Max Gurtovoy wrote: Hi Logan, On 4/19/2017 2:32 AM, Logan Gunthorpe wrote: This is safer as it doesn't rely on the data being stored in a single page in an sgl. It also aids our effort to start

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

2017-04-19 Thread Max Gurtovoy
Hi Logan, On 4/19/2017 2:32 AM, Logan Gunthorpe wrote: This is safer as it doesn't rely on the data being stored in a single page in an sgl. It also aids our effort to start phasing out users of sg_page. See [1]. For this we kmalloc some memory, copy to it and free at the end. Note: we can't

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

2017-04-19 Thread Max Gurtovoy
Hi Logan, On 4/19/2017 2:32 AM, Logan Gunthorpe wrote: This is safer as it doesn't rely on the data being stored in a single page in an sgl. It also aids our effort to start phasing out users of sg_page. See [1]. For this we kmalloc some memory, copy to it and free at the end. Note: we can't

Re: [PATCH] IB/iser: fix spelling mistake: "unexepected" -> "unexpected"

2017-02-23 Thread Max Gurtovoy
Looks fine: Reviewed-by: Max Gurtovoy <m...@mellanox.com> On 2/23/2017 1:22 PM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> trivial fix to spelling mistake in iser_err error message Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- driv

Re: [PATCH] IB/iser: fix spelling mistake: "unexepected" -> "unexpected"

2017-02-23 Thread Max Gurtovoy
Looks fine: Reviewed-by: Max Gurtovoy On 2/23/2017 1:22 PM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in iser_err error message Signed-off-by: Colin Ian King --- drivers/infiniband/ulp/iser/iser_initiator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

<    1   2