[PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

ata1.00: exception Emask 0x0 SAct 0x3fff SErr 0x20 action 0x2 frozen [...] ata1: soft resetting port http://lkml.org/lkml/2007/3/16/184 Signed-off-by: Max Kellermann [EMAIL PROTECTED] drivers/ata/libata-core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/ata

Re: [PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

On 2007/04/18 08:26, Tejun Heo [EMAIL PROTECTED] wrote: Can you try it on another controller? Say, a ahci or sil24? Seems to work ok on a Via VT8251 controller (AHCI) on kernel 2.6.21-rc6-git4 without my NCQ disabling patch. By the way, on this machine, I had a lot of SATA timeouts during

Re: [PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

On 2007/04/18 09:56, Tejun Heo [EMAIL PROTECTED] wrote: It's more likely your chipset just has busted MSI support. Please post the result of 'lspci -tv' and 'lspci -nn'. See attachments. I found the nomsi workaround in a forum, and didn't bother to investigate the real cause yet. Max

Re: [BUG 2.6.21-rc3-git9] SATA NCQ failure with Samsum HD401LJ

On 2007/03/19 13:09, Jeff Garzik [EMAIL PROTECTED] wrote: I may have missed the answer to this before, but: does the problem go away if you disable preempt? On my system (same problem, original bug report), preemption is disabled. Max - To unsubscribe from this list: send the line unsubscribe

[PATCH] /proc Security Hooks

Linux VServer. Signed-off-by: Max Kellermann [EMAIL PROTECTED] --- fs/proc/base.c |9 + fs/proc/generic.c| 15 +++ include/linux/security.h | 46 ++ security/Kconfig |8 security

Re: [PATCH] /proc Security Hooks

On 2007/10/16 21:54, Arjan van de Ven [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007 21:38:50 +0200 Max Kellermann [EMAIL PROTECTED] wrote: This patch attempts to unify duplicated code found in modules like Linux VServer. can you please merge this patch only when you also merge the first

Re: Netfilter: TARPIT Target

On 2005/02/17 15:41, Fao, Sean [EMAIL PROTECTED] wrote: I wanted to use the TARPIT target provided by Netfilter, but I am unable to find the module in the kernel. Has it been removed or am I looking in the wrong place? It is not in the mainstream kernel yet. You can find it in netfilter

Re: forkbombing Linux distributions

On 2005/03/22 12:49, Jan Engelhardt [EMAIL PROTECTED] wrote: What if the few procs that he may spawn also grab so much memory so your machine disappears in swap-t(h)rashing? The number of processes is counted per user, but CPU time and memory consumption is counted per process. Going around

Re: forkbombing Linux distributions

On 2005/03/23 15:23, Natanael Copa [EMAIL PROTECTED] wrote: On Wed, 2005-03-23 at 14:53 +0100, Max Kellermann wrote: The number of processes is counted per user, but CPU time and memory consumption is counted per process. So limiting maximum number of processes will automatically limit CPU

Re: forkbombing Linux distributions

On 2005/03/23 15:44, Natanael Copa [EMAIL PROTECTED] wrote: Yes, but if RLIMIT_NPROC is per user and RLIMIT_CPU is per proc the theoretical CPU limit per user is RLIMIT_NPROC * RLIMIT_CPU. So if you half the RLIMIT_NPROC you will half the theoretical maximum CPU limit per user. Same

[PATCH] fscache: extended dying check before emitting EV_INVALIDATE

; if one of those two terminal events is already queued, don't bother to queue EV_INVALIDATE. Signed-off-by: Max Kellermann m...@cm4all.com --- fs/fscache/cookie.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index 8dcb114..ed80d7f

[PATCH] print unsigned integers in sunrpc stats

Hi, the sunrpc stats are collected in unsigned integers, but they are printed with '%d'. That can result in negative numbers in /proc/net/rpc when the highest bit of a counter is set. The following patch changes '%d' to '%u' where appropriate. Max --- linux-2.6.13/net/sunrpc/stats.c.orig

Re: 2.6.23.1: oops in diskstats_show()

On 2008/01/29 23:22, Rick Lindsley [EMAIL PROTECTED] wrote: Right before the crash, I was torturing cryptsetup to experiment with encryption - I created and deleted device mapper objects in a loop. Creating and deleting block devices ... yeah, this is probably key to the problem. Can

[PATCH 2/2] fs/namespace: use RCU list functions for mnt_hash

mount.mnt_hash is RCU-protected, and therefore we must use the RCU variants to manipulate the list. Signed-off-by: Max Kellermann m...@cm4all.com --- fs/namespace.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 2aa0a14

[PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

(RCU'd vfsmounts). All releases since 3.12-rc5 are affected. Signed-off-by: Max Kellermann m...@cm4all.com --- fs/mount.h |1 + fs/namespace.c | 12 +++- fs/pnode.c |8 +--- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/fs/mount.h b/fs/mount.h index

Re: [PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

On 2014/03/19 22:22, Max Kellermann m...@cm4all.com wrote: In the presence of user+mount namespaces, this bug can be exploited by any unprivileged user to stall the kernel (denial of service by soft lockup). Proof-of-concept exploit attached. /* * Exploit for linux commit

[PATCH] fs/namespace: don't clobber mnt_hash.next while umounting [v2]

(RCU'd vfsmounts). All releases since 3.12-rc5 are affected. Signed-off-by: Max Kellermann m...@cm4all.com --- fs/mount.h |1 + fs/namespace.c | 12 +++- fs/pnode.c |8 +--- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/fs/mount.h b/fs/mount.h index

Re: [PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

On 2014/03/19 22:22, Max Kellermann m...@cm4all.com wrote: + list_add(child-mnt_unmounted, mnt-mnt_hash); This is obviously a bug in my patch, sorry. Will resend a fixed patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] cgroup_pids: add fork limit

On 2015/11/10 16:12, Tejun Heo <t...@kernel.org> wrote: > On Tue, Nov 10, 2015 at 03:06:46PM +0100, Max Kellermann wrote: > > This patch introduces a new setting called "fork_remaining". When > > positive, each successful fork decrements the value, and once it >

Re: [PATCH] cgroup_pids: add fork limit

On 2015/11/10 16:25, Aleksa Sarai wrote: > > The goal of this limit is to have another safeguard against fork > > bombs. It gives processes a chance to set up their child processes / > > threads, but will be stopped once they attempt to waste resources by > > continuously

Re: [PATCH] cgroup_pids: add fork limit

On 2015/11/10 16:44, Tejun Heo <t...@kernel.org> wrote: > On Tue, Nov 10, 2015 at 04:37:46PM +0100, Max Kellermann wrote: > > There's "cpu" which changes priority > > The cpu controller can limit both in terms of relative weight and > absolute CPU cycle bandwidth

Re: [PATCH] cgroup_pids: add fork limit

On 2015/11/10 18:29, Tejun Heo wrote: > It's not a stateful resource. Of course the resource is controlled in > terms of bandwidth not absoulte amount consumed. I'm glad we now agree on the basic facts. > It's absurd to limit absoulte amount for CPU cycles. And yet there's an

[PATCH] cgroup_pids: add fork limit

e new "pids" controller, which implements a similar idea. Signed-off-by: Max Kellermann <m...@cm4all.com> --- Documentation/cgroups/pids.txt | 31 ++ kernel/cgroup_pids.c | 123 2 files changed, 153 insertions(+), 1 deletion(-)

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

(Shuah, I did not receive your second reply; I only found it in an email archive.) > Yes media_devnode_create() creates the interfaces links and these > links are deleted by media_devnode_remove(). > media_device_unregister() still needs to delete the interfaces > links. The reason for that is

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

On 2016/06/15 22:32, Shuah Khan wrote: > This change introduces memory leaks, since drivers are relying on > media_device_unregister() to free interfaces. This is what I thought, too, until I checked the code paths. Who adds entries to that list? Only

[PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

handle, dvb_media_device_free() gets called, which frees the dvb_device.intf_devnode again. This patch removes the unnecessary kfree() call, and documents who's responsible for really freeing it. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-device.c |4 +++-

[PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

this variable. So this patch really implements this behavior, and adds another mdev==NULL check to media_gobj_destroy() to protect against double removal. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-entity.c |6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

Don't free the object until the file handle has been closed. Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvb_ca_en50221.c | 24 +++-

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

On 2016/06/16 18:24, Shuah Khan <shua...@osg.samsung.com> wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The > > funct

Re: [PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

On 2016/06/16 18:06, Shuah Khan <shua...@osg.samsung.com> wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > Don't free the object until the file handle has been closed. Fixes > > use-after-free bug which occurs when I disconnect my DVB-S received > > while VDR

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

On 2016/06/17 14:53, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Wed, Jun 15, 2016 at 10:15:07PM +0200, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The &

[PATCH 1/2] media/dvb-core: fix inverted check

Breakage caused by commit f50d51661a Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvbdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index 560450a..c756d4b

[PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

All accesses to media_devnode_nums must be protected with media_devnode_lock. The error code path in media_devnode_register() did not do this, however. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-devnode.c |3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 3/6] drivers/media/media-devnode: clear private_data before put_device()

Callbacks invoked from put_device() may free the struct media_devnode pointer, so any cleanup needs to be done before put_device(). Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-devnode.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 4/6] drivers/media/media-device: move debug log before _devnode_unregister()

After media_devnode_unregister(), the struct media_device may be freed already, and dereferencing it may crash. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-device.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/media-de

[PATCH 2/6] drivers/media/dvb-core/en50221: postpone release until file is closed

Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvb_ca_en50221.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/6] drivers/media/dvb-core/en50221: move code to dvb_ca_private_free()

Prepare for postponing the call until all file handles have been closed. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvb_ca_en50221.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-core/dvb_ca_en5022

[PATCH 6/6] drivers/media/dvb-usb-dvb: postpone kfree(mdev)

Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/media/u

[PATCH 5/6] drivers/media/media-device: add "release" callback

Allow the client to free its data structures only after all files have been closed (fixing use-after-free bugs). Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-device.c |9 +++-- include/media/media-device.h |2 ++ 2 files changed, 9 insertions

Re: [PATCH] drivers/media/rc: postpone kfree(rc_dev)

On 2016/03/21 13:24, Mauro Carvalho Chehab wrote: > Please, always send us your Signed-off-by on your patches, as described at: > > https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Developer.27s_Certificate_of_Origin_1.1 Sorry, I forgot this, and

[PATCH] drivers/media/rc: postpone kfree(rc_dev)

CONFIG_DEBUG_KOBJECT_RELEASE found this bug. --- drivers/media/rc/rc-main.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 1042fa3..cb3e8db 100644 --- a/drivers/media/rc/rc-main.c +++

[PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

--- drivers/media/media-devnode.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index cea35bf..4d7e8dd 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media/media-devnode.c @@ -266,8 +266,11 @@ int __must_check

[PATCH] drivers/media/rc: postpone kfree(rc_dev)

CONFIG_DEBUG_KOBJECT_RELEASE found this bug. Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/rc/rc-main.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 1042fa3..cb3e8db

[PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/media-devnode.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index cea35bf..4d7e8dd 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media

[PATCH 2/2] media/dvb-core: forward media_create_pad_links() return value

Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvbdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index c756d4b..96de2fa 100644 --- a/drivers/media/dvb-core/dv

Re: [PATCH 05/12] [media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations

On 2016/08/10 01:01, kbuild test robot <l...@intel.com> wrote: > url: > https://github.com/0day-ci/linux/commits/Max-Kellermann/rc-main-clear-rc_map-name-in-ir_free_table/20160810-054811 > base: git://linuxtv.org/media_tree.git master > config: i386-randconfig-n0-201632 (a

[PATCH 12/12] drivers/media/media-device: fix double free bug in _unregister()

handle, dvb_media_device_free() gets called, which frees the dvb_device.intf_devnode again. This patch removes the unnecessary kfree() call, and documents who's responsible for really freeing it. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/media-device.c

[PATCH 07/12] [media] dvb_frontend: merge the two dvb_frontend_detach() versions

This code duplication is confusing and error prone. Let's merge them by moving the release/dvb_detach call into one function with one #ifdef. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_frontend.c | 42 +

[PATCH 03/12] [media] dvb-core/en50221: use dvb_remove_device()

() instead of dvb_unregister_device(), we can avoid that. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_ca_en50221.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/

[PATCH 02/12] [media] dvbdev: split dvb_unregister_device()

sanitizing a few callers. With my new design, dvb_unregister_device() appears misnamed, but to reduce patch noise, I'm not renaming it just yet. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvbdev.c | 19 ++- drivers/media/dv

[PATCH 06/12] [media] dvb_frontend: tuner_ops.release returns void

It is not clear what this return value means. All implemenations return 0, and the one caller ignores the value. Let's remove this useless return value completely. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_frontend.c |3 +-- d

[PATCH 11/12] [media] media-entity: clear media_gobj.mdev in _destroy()

this variable. So this patch really implements this behavior, and adds another mdev==NULL check to media_gobj_destroy() to protect against double removal. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/media-entity.c |6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 05/12] [media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations

Most release callback functions are identical: free the "tuner_priv" and clear it. Let's eliminate some bloat by providing this simple implementation in the dvb_frontend library. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_fronte

[PATCH 04/12] [media] dvb: make DVB frontend *_ops instances "const"

These are immutable. Making them "const" allows the compiler to move them to the "rodata" section. Note that cxd2841er_t_c_ops cannot be made "const", because cxd2841er_attach() modifies it. Ouch! Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --

[PATCH 08/12] [media] dvb_frontend: add "detach" callback

Prepare for making "release" asynchronous (via kref). Some operations may need to be run synchronously in dvb_frontend_detach(), and that's why we need a "detach" callback. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_frontend

[PATCH 01/12] [media] rc-main: clear rc_map.name in ir_free_table()

rc_unregister_device() will first call ir_free_table(), and later device_del(); however, the latter causes a call to rc_dev_uevent(), which prints rc_map.name, which at this point has already bee freed. This fixes a use-after-free bug found with KASAN. Signed-off-by: Max Kellermann <max.kell

[PATCH 09/12] [media] stb0899: move code to "detach" callback

Ensure that STB0899_POSTPROC_GPIO_POWER is set synchronously. Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-frontends/stb0899_drv.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stb0899_dr

[PATCH 10/12] [media] dvb_frontend: move kref to struct dvb_frontend

+0x43/0xe5 [] dvb_usb_device_exit+0x69/0x7d [] pctv452e_usb_disconnect+0x7b/0x80 Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_frontend.c | 46 ++--- drivers/media/dvb-core/dvb_frontend.h |1 + 2 files changed, 31 i

[PATCH 1/2] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

l (arg=, cmd=, fd=) at fs/ioctl.c:689 #15 SyS_ioctl (fd=6, cmd=2148298626, arg=140734533693696) at fs/ioctl.c:680 #16 0x8103feb2 in entry_SYSCALL_64 () at arch/x86/entry/entry_64.S:207 Signed-off-by: Max Kellermann <m...@duempel.org> --- drivers/media/dvb-core/dvb_ca_en50

[PATCH 2/2] dvb_frontend: eliminate blocking wait in dvb_unregister_frontend()

ect+0x52/0x260 #4: (>mutex){..}, at: [] device_release_driver+0x1b/0x30 This patch removes the blocking wait, and postpones the kfree() call until all file handles have been closed by using struct kref. Signed-off-by: Max Kellermann <m...@duempel.org> --- dri

[PATCH] [media] pctv452e: move buffer to heap, no mutex

unusable (crashes instantly when plugging in the device). Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/usb/dvb-usb/pctv452e.c | 133 ++ 1 file changed, 72 insertions(+), 61 deletions(-) diff --git a/drivers/media/usb/d

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

On 2017/12/07 21:38, "Madhani, Himanshu" wrote: > NACK > > These calls are asynchronous calls and free should be called by > completion. I don't understand the NACK, and your text doesn't explain it. It only describes a second bug that is orthogonal to mine.

[PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

s belongs to the object at 88278147a440 which belongs to the cache qla2xxx_srbs of size 344 The buggy address is located 336 bytes inside of 344-byte region [88278147a440, 88278147a598) Signed-off-by: Max Kellermann <m...@cm4all.com> --- drivers/scsi/qla2xxx/qla_init.c |3 ++-

[PATCH] [media] dvbdev: add a mutex protecting the "mdev" pointer

8 85 c0 74 06 49 8b 7d RIP [] dvb_frontend_release+0xcb/0x120 Signed-off-by: Max Kellermann <max.kellerm...@gmail.com> --- drivers/media/dvb-core/dvb_frontend.c | 7 +++ drivers/media/dvb-core/dvbdev.c | 4 drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 4

[PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

s belongs to the object at 88278147a440 which belongs to the cache qla2xxx_srbs of size 344 The buggy address is located 336 bytes inside of 344-byte region [88278147a440, 88278147a598) Signed-off-by: Max Kellermann <m...@cm4all.com> --- drivers/scsi/qla2xxx/qla_init.c |3 ++-

[PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

d to check for "version==4". - If CONFIG_FS_POSIX_ACL=y and CONFIG_NFS_V3_ACL=y, MS_POSIXACL is always set, as before. Signed-off-by: Max Kellermann <m...@cm4all.com> --- fs/nfs/super.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/nf

[PATCH 1/2] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n

). Signed-off-by: Max Kellermann <m...@cm4all.com> --- include/linux/fs.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/fs.h b/include/linux/fs.h index 440281f8564d..c3240c28e61b 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1883,7 +1883,12 @@

[PATCH] nfs/super: set MS_POSIXACL only if ACL support is enabled

ONFIG_FS_POSIX_ACL=y and CONFIG_NFS_V3_ACL=y, MS_POSIXACL is always set, as before. Signed-off-by: Max Kellermann <m...@cm4all.com> --- fs/nfs/super.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 216f67d628b3..ec4e1f

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

On 2018/01/15 20:58, "Madhani, Himanshu" wrote: > We have patch to prevent this double free in 4.16/scsi-queue > already. No, let me repeat: this is a different bug! Your bug is about the free call after waiting for completion synchronously in

Re: [PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

On 2018/01/15 18:41, Greg KH wrote: > Your subject line is a bit odd :( True, I already repaired & resent it. Sorry for the hiccup.

[PATCH] nfs/super: check NFS_CAP_ACLS instead of the NFS version

regression caused by commit 013cdf1088d723 which itself was not completely wrong, but failed to consider all the side effects by misdesigned VFS code. Signed-off-by: Max Kellermann <m...@cm4all.com> --- fs/nfs/super.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH] sound/soc/rockchip: add RT5640 codec option

-by: Max Kellermann --- sound/soc/rockchip/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 957046ac6c8c..ac2e27043107 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -42,6 +42,16

Re: Netfilter: TARPIT Target

On 2005/02/17 15:41, "Fao, Sean" <[EMAIL PROTECTED]> wrote: > I wanted to use the TARPIT target provided by Netfilter, but I am unable > to find the module in the kernel. Has it been removed or am I looking > in the wrong place? It is not in the mainstream kernel yet. You can find it in

Re: forkbombing Linux distributions

On 2005/03/22 12:49, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > What if the few procs that he may spawn also grab so much memory so > your machine disappears in swap-t(h)rashing? The number of processes is counted per user, but CPU time and memory consumption is counted per process. Going

Re: forkbombing Linux distributions

On 2005/03/23 15:23, Natanael Copa <[EMAIL PROTECTED]> wrote: > On Wed, 2005-03-23 at 14:53 +0100, Max Kellermann wrote: > > The number of processes is counted per user, but CPU time and memory > > consumption is counted per process. > > So limiting maximum number of p

Re: forkbombing Linux distributions

On 2005/03/23 15:44, Natanael Copa <[EMAIL PROTECTED]> wrote: > Yes, but if > RLIMIT_NPROC is per user and RLIMIT_CPU is per proc > > the theoretical CPU limit per user is RLIMIT_NPROC * RLIMIT_CPU. So if > you half the RLIMIT_NPROC you will half the theoretical maximum CPU > limit per user. >

[PATCH] print unsigned integers in sunrpc stats

Hi, the sunrpc stats are collected in unsigned integers, but they are printed with '%d'. That can result in negative numbers in /proc/net/rpc when the highest bit of a counter is set. The following patch changes '%d' to '%u' where appropriate. Max --- linux-2.6.13/net/sunrpc/stats.c.orig

Re: [BUG 2.6.21-rc3-git9] SATA NCQ failure with Samsum HD401LJ

On 2007/03/19 13:09, Jeff Garzik <[EMAIL PROTECTED]> wrote: > I may have missed the answer to this before, but: does the problem > go away if you disable preempt? On my system (same problem, original bug report), preemption is disabled. Max - To unsubscribe from this list: send the line

[PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

ata1.00: exception Emask 0x0 SAct 0x3fff SErr 0x20 action 0x2 frozen [...] ata1: soft resetting port http://lkml.org/lkml/2007/3/16/184 Signed-off-by: Max Kellermann <[EMAIL PROTECTED]> drivers/ata/libata-core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/d

Re: [PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

On 2007/04/18 08:26, Tejun Heo <[EMAIL PROTECTED]> wrote: > Can you try it on another controller? Say, a ahci or sil24? Seems to work ok on a Via VT8251 controller (AHCI) on kernel 2.6.21-rc6-git4 without my NCQ disabling patch. By the way, on this machine, I had a lot of SATA timeouts during

Re: [PATCH] libata: add Samsung HD401LJ to the NCQ blacklist

On 2007/04/18 09:56, Tejun Heo <[EMAIL PROTECTED]> wrote: > It's more likely your chipset just has busted MSI support. Please > post the result of 'lspci -tv' and 'lspci -nn'. See attachments. I found the "nomsi" workaround in a forum, and didn't bother to investigate the real cause yet. Max

[PATCH] /proc Security Hooks

in modules like Linux VServer. Signed-off-by: Max Kellermann <[EMAIL PROTECTED]> --- fs/proc/base.c |9 + fs/proc/generic.c| 15 +++ include/linux/security.h | 46 ++ security/Kconfig |8 ++

Re: [PATCH] /proc Security Hooks

On 2007/10/16 21:54, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > On Tue, 16 Oct 2007 21:38:50 +0200 > Max Kellermann <[EMAIL PROTECTED]> wrote: > > This patch attempts to unify duplicated code found in modules like > > Linux VServer. > > can you please merge

[PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

ueued. The solution is to check for EV_RETIRE and EV_RELEASE; if one of those two terminal events is already queued, don't bother to queue EV_INVALIDATE. Signed-off-by: Max Kellermann --- fs/fscache/cookie.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fscache/cookie.

[PATCH 2/2] fs/namespace: use RCU list functions for mnt_hash

mount.mnt_hash is RCU-protected, and therefore we must use the RCU variants to manipulate the list. Signed-off-by: Max Kellermann --- fs/namespace.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 2aa0a14..295a0c0 100644

[PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

il namespace_unlock() is called. This regression was caused by commit 48a066e7 ("RCU'd vfsmounts"). All releases since 3.12-rc5 are affected. Signed-off-by: Max Kellermann --- fs/mount.h |1 + fs/namespace.c | 12 +++- fs/pnode.c |8 +--- 3 files changed, 13 ins

Re: [PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

On 2014/03/19 22:22, Max Kellermann wrote: > In the presence of user+mount namespaces, this bug can be exploited by > any unprivileged user to stall the kernel (denial of service by soft > lockup). Proof-of-concept exploit attached. /* * Exploit for lin

[PATCH] fs/namespace: don't clobber mnt_hash.next while umounting [v2]

il namespace_unlock() is called. This regression was caused by commit 48a066e7 ("RCU'd vfsmounts"). All releases since 3.12-rc5 are affected. Signed-off-by: Max Kellermann --- fs/mount.h |1 + fs/namespace.c | 12 +++- fs/pnode.c |8 +--- 3 files changed, 13 ins

Re: [PATCH 1/2] fs/namespace: don't clobber mnt_hash.next while umounting

On 2014/03/19 22:22, Max Kellermann wrote: > + list_add(>mnt_unmounted, >mnt_hash); This is obviously a bug in my patch, sorry. Will resend a fixed patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[PATCH] [media] dvbdev: add a mutex protecting the "mdev" pointer

8 85 c0 74 06 49 8b 7d RIP [] dvb_frontend_release+0xcb/0x120 Signed-off-by: Max Kellermann --- drivers/media/dvb-core/dvb_frontend.c | 7 +++ drivers/media/dvb-core/dvbdev.c | 4 drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 4 include/media/dvbdev.h

[PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

s belongs to the object at 88278147a440 which belongs to the cache qla2xxx_srbs of size 344 The buggy address is located 336 bytes inside of 344-byte region [88278147a440, 88278147a598) Signed-off-by: Max Kellermann --- drivers/scsi/qla2xxx/qla_init.c |3 ++- 1 file changed, 2 in

[PATCH] nfs/super: set MS_POSIXACL only if ACL support is enabled

ONFIG_FS_POSIX_ACL=y and CONFIG_NFS_V3_ACL=y, MS_POSIXACL is always set, as before. Signed-off-by: Max Kellermann --- fs/nfs/super.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 216f67d628b3..ec4e1f2775e0 100644 --- a/fs/nfs/

[PATCH 1/2] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n

). Signed-off-by: Max Kellermann --- include/linux/fs.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/fs.h b/include/linux/fs.h index 440281f8564d..c3240c28e61b 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1883,7 +1883,12 @@ static inline bool sb_rdonly

[PATCH 2/2] dFrom: Max Kellermann

d to check for "version==4". - If CONFIG_FS_POSIX_ACL=y and CONFIG_NFS_V3_ACL=y, MS_POSIXACL is always set, as before. Signed-off-by: Max Kellermann --- fs/nfs/super.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/nfs/super.c b/

Re: [PATCH 2/2] dFrom: Max Kellermann

On 2018/01/15 18:41, Greg KH wrote: > Your subject line is a bit odd :( True, I already repaired & resent it. Sorry for the hiccup.

[PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

s belongs to the object at 88278147a440 which belongs to the cache qla2xxx_srbs of size 344 The buggy address is located 336 bytes inside of 344-byte region [88278147a440, 88278147a598) Signed-off-by: Max Kellermann --- drivers/scsi/qla2xxx/qla_init.c |3 ++- 1 file changed, 2 in

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

On 2017/12/07 21:38, "Madhani, Himanshu" wrote: > NACK > > These calls are asynchronous calls and free should be called by > completion. I don't understand the NACK, and your text doesn't explain it. It only describes a second bug that is orthogonal to mine.

Kernel 5.1.15 stuck in compaction

Hi, one of our web servers got repeatedly stuck in the memory compaction code; two PHP processes have been busy at 100% inside memory compaction after a page fault: 100.00% 0.00% php-cgi7.0 [kernel.vmlinux] [k] page_fault | ---page_fault

Re: Kernel 5.1.15 stuck in compaction

On 2019/07/08 12:35, Max Kellermann wrote: > one of our web servers got repeatedly stuck in the memory compaction > code; two PHP processes have been busy at 100% inside memory > compaction after a page fault: This trace maybe helpful as well; the first PHP process:

2.6.23.1: oops in diskstats_show()

Hi, my kernel 2.6.23.1 oopsed today in diskstats_show(), leaving the block_subsys_lock mutex locked. I have an Athlon 64 X2 (dual-core), architecture x86_64. I have not tried with 2.6.24 yet, but it looks like there was no relevant change in 2.6.24. Right before the crash, I was torturing

  1   2   >