[PATCH v3 1/4] HID: logitech: Add MX Mice over Bluetooth

2019-10-05 Thread Mazin Rezk
This patch adds support for several MX mice over Bluetooth. The device IDs have been copied from the libratbag device database and their features have been based on their DJ device counterparts. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 18 ++ 1 file

[PATCH v3 3/4] HID: logitech: Add feature 0x0001: FeatureSet

2019-10-05 Thread Mazin Rezk
and stores a map of them in features an hidpp_device struct. This function runs when an HID++ 2.0 device is probed. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 92 1 file changed, 92 insertions(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b

[PATCH v3 2/4] HID: logitech: Support HID++ devices without short reports

2019-10-05 Thread Mazin Rezk
with the other Bluetooth devices. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 37 ++-- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 85fd0c17cc2f

[PATCH v3 4/4] HID: logitech: Support WirelessDeviceStatus connect events

2019-10-05 Thread Mazin Rezk
-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 64ac94c581aa..4a6e41c2c9fc 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers

Re: [PATCH v3 1/4] HID: logitech: Add MX Mice over Bluetooth

2019-10-06 Thread Mazin Rezk
On Sunday, October 6, 2019 11:07 AM, Filipe Laíns wrote: > On Sun, 2019-10-06 at 01:04 +0000, Mazin Rezk wrote: > > > This patch adds support for several MX mice over Bluetooth. The device IDs > > have been copied from the libratbag device database and their features &

Re: [PATCH v3 3/4] HID: logitech: Add feature 0x0001: FeatureSet

2019-10-06 Thread Mazin Rezk
On Sunday, October 6, 2019 11:25 AM, Filipe Laíns wrote: > On Sun, 2019-10-06 at 01:04 +0000, Mazin Rezk wrote: > > This patch adds support for the 0x0001 (FeatureSet) feature. This feature > > is used to look up the feature ID of a feature index on a device and list >

[PATCH v4 1/4] HID: logitech: Add MX Mice over Bluetooth

2019-10-10 Thread Mazin Rezk
On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote: > This patch adds support for several MX mice over Bluetooth. The device IDs > have been copied from the libratbag device database and their features > have been based on their DJ device counterparts. No changes have

[PATCH v4 2/4] HID: logitech: Support HID++ devices without short reports

2019-10-10 Thread Mazin Rezk
On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote: > This patch allows the hid-logitech-hidpp module to support devices that do > not have support for Short HID++ reports. So far, it seems that Bluetooth > HID++ 2.0 devices are missing short reports. > This has been tested a

[PATCH v4 4/4] HID: logitech: Support WirelessDeviceStatus connect events

2019-10-10 Thread Mazin Rezk
On Saturday, October 5, 2019 9:05 PM, Mazin Rezk wrote: > This patch makes WirelessDeviceStatus (0x1d4b) events get detected as > connection events on devices with HIDPP_QUIRK_WIRELESS_DEVICE_STATUS. > > This quirk is currently an alias for HIDPP_QUIRK_CLASS_BLUETOOTH since > the

[PATCH v4 3/4] HID: logitech: Add feature 0x0001: FeatureSet

2019-10-10 Thread Mazin Rezk
On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote: > This patch adds support for the 0x0001 (FeatureSet) feature. This feature > is used to look up the feature ID of a feature index on a device and list > the total count of features on the device. > > I also added the hidpp

[PATCH v5 1/2] HID: logitech: Add MX Master over Bluetooth

2019-10-11 Thread Mazin Rezk
. Since all Bluetooth LE HID++ devices seem to act this way, HIDPP_QUIRK_CLASS_BLUETOOTH_LE aliases this quirk. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid

[PATCH v5 2/2] HID: logitech: Support WirelessDeviceStatus connect events

2019-10-11 Thread Mazin Rezk
, HIDPP_QUIRK_CLASS_BLUETOOTH_LE aliases this quirk. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 42 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 3692fb883602

Re: [PATCH v7 1/3] HID: logitech-hidpp: Support translations from short to long reports

2019-10-22 Thread Mazin Rezk
On Tuesday, October 22, 2019 6:15 AM, Benjamin Tissoires wrote: > Hi Mazin, > > On Sun, Oct 20, 2019 at 6:41 AM Mazin Rezk mn...@protonmail.com wrote: > > > This patch allows short reports to be translated into long reports. > > hidpp_validate_device now returns a u8

Re: [PATCH v5 1/2] HID: logitech: Add MX Master over Bluetooth

2019-10-13 Thread Mazin Rezk
please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Mazin-Rezk/HID-logitech-Add-M

[PATCH v6 1/2] HID: logitech: Add MX Master over Bluetooth

2019-10-14 Thread Mazin Rezk
. Since all Bluetooth LE HID++ devices seem to act this way, HIDPP_QUIRK_CLASS_BLUETOOTH_LE aliases this quirk. To allow for some space for future quirks, I changed the comment that defines the bits reserved for classes from 2...20 to 2..15. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech

[PATCH v6 2/2] HID: logitech: Support WirelessDeviceStatus connect events

2019-10-14 Thread Mazin Rezk
, HIDPP_QUIRK_CLASS_BLUETOOTH_LE aliases this quirk. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 42 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 997b1056850a

[PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-26 Thread Mazin Rezk
rm/amd/display: Don't replace the dc_state for fast updates") Reported-by: Duncan <1i5t5.dun...@cox.net> Signed-off-by: Mazin Rezk --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 ++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drive

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-26 Thread Mazin Rezk
On Monday, July 27, 2020 1:40 AM, Mazin Rezk wrote: > This patch fixes a race condition that causes a use-after-free during > amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits > are requested and the second one finishes before the first. Essentially, > this bug

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
On Monday, July 27, 2020 9:26 AM, Kazlauskas, Nicholas wrote: > On 2020-07-27 1:40 a.m., Mazin Rezk wrote: > > This patch fixes a race condition that causes a use-after-free during > > amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits > > are request

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: > On Mon, Jul 27, 2020 at 9:28 PM Christian König > wrote: > > > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > > On 2020-07-27 9:39 a.m., Christian König wrote: > > >> Am 27.07.20 um 07:40

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
On Monday, July 27, 2020 5:32 PM, Daniel Vetter wrote: > On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: > > > > On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: > > > > > On Mon, Jul 27, 2020 at 9:28 PM Christian König > > > wrote: >

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
On Monday, July 27, 2020 7:42 PM, Mazin Rezk wrote: > On Monday, July 27, 2020 5:32 PM, Daniel Vetter wrote: > > > On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: > > > > > > On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: > > > > >

[PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-23 Thread Mazin Rezk
by: Duncan <1i5t5.dun...@cox.net> Signed-off-by: Mazin Rezk --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 86ffa0c288

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-23 Thread Mazin Rezk
On Thursday, July 23, 2020 6:32 PM, Kees Cook wrote: > On Thu, Jul 23, 2020 at 09:10:15PM +0000, Mazin Rezk wrote: > > > When amdgpu_dm_atomic_commit_tail is running in the workqueue, > > drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is > >

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-23 Thread Mazin Rezk
which may help in further discovering the cause. On Thursday, July 23, 2020 6:16 PM, Kazlauskas, Nicholas wrote: > On 2020-07-23 5:10 p.m., Mazin Rezk wrote: > > > When amdgpu_dm_atomic_commit_tail is running in the workqueue, > > drm_atomic_state_put wil

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
On Thursday, July 23, 2020 6:57 PM, Mazin Rezk wrote: > It seems that I spoke too soon. I ran the system for another hour after > submitting the patch and the bug just occurred. :/ > > Sadly, that means the bug isn't really fixed and that I have to go > investigate further. > &

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
On Friday, July 24, 2020 5:19 PM, Paul Menzel wrote: > Dear Kees, > > Am 24.07.20 um 19:33 schrieb Kees Cook: > > > On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: > > > > > Am 24.07.20 um 00:32 schrieb Kees Cook: > > > > > > >

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
On Saturday, July 25, 2020 12:59 AM, Duncan <1i5t5.dun...@cox.net> wrote: > On Sat, 25 Jul 2020 03:03:52 +0000 > Mazin Rezk mn...@protonmail.com wrote: > > > > Am 24.07.20 um 19:33 schrieb Kees Cook: > > > > > > > There was a fix to disable the a

Re: [PATCH v6 1/2] HID: logitech: Add MX Master over Bluetooth

2019-10-18 Thread Mazin Rezk
On Friday, October 18, 2019 11:36 AM, Benjamin Tissoires wrote: > Hi Mazin, > > On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk mn...@protonmail.com wrote: > > > This patch adds support for the MX Master (b01e and b012) and also adds > > foundational code for other Bl

Re: [PATCH v6 2/2] HID: logitech: Support WirelessDeviceStatus connect events

2019-10-18 Thread Mazin Rezk
On Friday, October 18, 2019 11:38 AM, Benjamin Tissoires wrote: > On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk mn...@protonmail.com wrote: > > > This patch allows WirelessDeviceStatus (0x1d4b) events to be detected as > > connection events in the hid-logitech-hidpp m

[PATCH v7 0/3] Logitech HID++ Bluetooth LE support

2019-10-19 Thread Mazin Rezk
lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com [v2] https://www.spinics.net/lists/linux-input/msg63467.html [v1] https://www.spinics.net/lists/linux-input/msg63317.html Mazin Rezk (3): HID: logitech-hidpp: Support translation

[PATCH v7 1/3] HID: logitech-hidpp: Support translations from short to long reports

2019-10-19 Thread Mazin Rezk
and the device does not support it, it is instead sent as a long report. Thanks, Mazin Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid

[PATCH v7 2/3] HID: logitech-hidpp: Support MX Master (b012, b01e) over Bluetooth

2019-10-19 Thread Mazin Rezk
devices should also be added later Thanks, Mazin Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index ee604b17514f..19b315e4e91b 100644 --- a/drivers/hid/hid

[PATCH v7 3/3] HID: logitech-hidpp: Support WirelessDeviceStatus connect events

2019-10-19 Thread Mazin Rezk
-by: Mazin Rezk --- drivers/hid/hid-logitech-hidpp.c | 39 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 19b315e4e91b..c8b23568d0b1 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b

[PATCH] HID: logitech: Use HIDPP_RECEIVER_INDEX instead of 0xff

2020-07-04 Thread Mazin Rezk
Some parts of hid-logitech-dj explicitly referred to 0xff for the receiver index. This patch changes those references to the HIDPP_RECEIVER_INDEX definition. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-dj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git