Re: [PATCH v11 0/6] KASAN for powerpc64 radix

2021-03-29 Thread Michael Ellerman
Christophe Leroy writes: > Le 23/03/2021 à 02:21, Daniel Axtens a écrit : >> Hi Christophe, >> >>> In the discussion we had long time ago, >>> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20190806233827.16454-5-...@axtens.net/#2321067 >>> , I challenged you on why it was not possible t

Re: [PATCH V2 1/5] powerpc/perf: Expose processor pipeline stage cycles using PERF_SAMPLE_WEIGHT_STRUCT

2021-03-27 Thread Michael Ellerman
Arnaldo writes: > On March 25, 2021 11:38:01 AM GMT-03:00, Peter Zijlstra > wrote: >>On Thu, Mar 25, 2021 at 10:01:35AM -0300, Arnaldo Carvalho de Melo >>wrote:. >>> > > Also for CPU_FTR_ARCH_31, capture the two cycle counter >>information in >>> > > two 16 bit fields of perf_sample_weight struc

Re: [PATCH] docs: powerpc: Fix misspellings and grammar errors

2021-03-26 Thread Michael Ellerman
| 4 ++-- > Documentation/powerpc/transactional_memory.rst | 4 ++-- > 9 files changed, 11 insertions(+), 11 deletions(-) LGTM. Acked-by: Michael Ellerman cheers

Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-24 Thread Michael Ellerman
void __init hvc_vio_init_early(void) >> | ^~~~~~ >> >> Cc: Michael Ellerman >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: linuxppc-...@lists.ozlabs.org >> Signed-off-by: Lee Jones >> Acked-by: Michael Ellerman >> --- >> a

Re: [PATCH 0/4] Rust for Linux for ppc64le

2021-03-23 Thread Michael Ellerman
Miguel Ojeda writes: > Hi Michael, > > On Tue, Mar 23, 2021 at 4:27 AM Michael Ellerman wrote: >> >> Hi all, >> >> Here's a first attempt at getting the kernel Rust support building on >> powerpc. > > Thanks a *lot*! It is great to have

[PATCH 4/4] rust: Enable for ppc64le

2021-03-22 Thread Michael Ellerman
All the pieces are in place now for us to enable building rust support on ppc64le. Only works with clang for now. Signed-off-by: Michael Ellerman --- init/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Kconfig b/init/Kconfig index d73ac9de186d..ddc2fda1a22c

[PATCH 3/4] powerpc/rust: Add target.json for ppc64le

2021-03-22 Thread Michael Ellerman
obviously do have 8-bit & 16-bit integer types, but I'm not sure if there's any need to specify that. ppc64le only for now. We'll eventually need to come up with some way to change the target.json that's used based on more than just $(ARCH). Signed-off-by: Michael Eller

[PATCH 1/4] rust: Export symbols in initialized data section

2021-03-22 Thread Michael Ellerman
represents the "initialized data section" with "D", so also look for that when exporting symbols. Signed-off-by: Michael Ellerman --- rust/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/Makefile b/rust/Makefile index eb8f12ce1644..4cddae9d4a

[PATCH 2/4] rust: Add powerpc64 as a 64-bit target_arch in c_types.rs

2021-03-22 Thread Michael Ellerman
powerpc kernel code uses int-ll64.h. Signed-off-by: Michael Ellerman --- rust/kernel/c_types.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/c_types.rs b/rust/kernel/c_types.rs index 423ac1108ddb..988fd84b0d66 100644 --- a/rust/kernel/c_types.rs +++ b/rust

[PATCH 0/4] Rust for Linux for ppc64le

2021-03-22 Thread Michael Ellerman
has length: 1028 cheers Michael Ellerman (4): rust: Export symbols in initialized data section rust: Add powerpc64 as a 64-bit target_arch in c_types.rs powerpc/rust: Add target.json for ppc64le rust: Enable for ppc64le arch/powerpc/rust/target.json | 30 +++

Re: [PATCH] powerpc/asm: Fix a typo

2021-03-22 Thread Michael Ellerman
Randy Dunlap writes: > On 3/22/21 4:32 AM, Bhaskar Chowdhury wrote: >> >> s/poiner/pointer/ >> >> Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > However, it would be a GOOD THING to collect multiple similar > patches that are in e.g. arch/powerpc/ and send them as one patch >

Re: [PATCH v11 1/6] kasan: allow an architecture to disable inline instrumentation

2021-03-22 Thread Michael Ellerman
Daniel Axtens writes: > Balbir Singh writes: > >> On Sat, Mar 20, 2021 at 01:40:53AM +1100, Daniel Axtens wrote: >>> For annoying architectural reasons, it's very difficult to support inline >>> instrumentation on powerpc64. >> >> I think we can expand here and talk about how in hash mode, the vm

Re: linux-next: Tree for Mar 19

2021-03-21 Thread Michael Ellerman
Miguel Ojeda writes: > On Sat, Mar 20, 2021 at 7:49 AM Miguel Ojeda > wrote: >> >> Reproduced on s390. However, under defconfig, one also needs to revert >> kernel/livepatch/core.c to avoid triggering the assert, i.e.: > > Stephen: I will put this in rust-next so that others don't see > problems

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-4 tag

2021-03-20 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.12: The following changes since commit 0b736881c8f1a6cd912f7a9162b9e097b28c1c30: powerpc/traps: unrecoverable_exception() is not an interrupt handler (2021-03-12 11:02:12 +1100) are available

Re: [PATCH v2] rpadlpar: fix potential drc_name corruption in store functions

2021-03-17 Thread Michael Ellerman
On Mon, 15 Mar 2021 15:48:21 -0600, Tyrel Datwyler wrote: > Both add_slot_store() and remove_slot_store() try to fix up the drc_name > copied from the store buffer by placing a NULL terminator at nbyte + 1 > or in place of a '\n' if present. However, the static buffer that we > copy the drc_name da

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-17 Thread Michael Ellerman
Daniel Axtens writes: > "heying (H)" writes: > >> Thank you for your reply. >> >> 在 2021/3/17 11:04, Daniel Axtens 写道: >>> Hi He Ying, >>> >>> Thank you for this patch. >>> >>> I'm not sure what the precise rules for Fixes are, but I wonder if this >>> should have: >>> >>> Fixes: 9a32a7e78bd0 ("p

Re: [PATCH] powerpc/vdso32: Add missing _restgpr_31_x to fix build failure

2021-03-15 Thread Michael Ellerman
On Tue, 9 Mar 2021 06:19:30 + (UTC), Christophe Leroy wrote: > With some defconfig including CONFIG_CC_OPTIMIZE_FOR_SIZE, > (for instance mvme5100_defconfig and ps3_defconfig), gcc 5 > generates a call to _restgpr_31_x. > > Until recently it went unnoticed, but > commit 42ed6d56ade2 ("powerpc/

Re: [PATCH] powerpc: Force inlining of cpu_has_feature() to avoid build failure

2021-03-15 Thread Michael Ellerman
On Wed, 10 Mar 2021 12:10:34 + (UTC), Christophe Leroy wrote: > The code relies on constant folding of cpu_has_feature() based > on possible and always true values as defined per > CPU_FTRS_ALWAYS and CPU_FTRS_POSSIBLE. > > Build failure is encountered with for instance > book3e_all_defconfig

Re: [PATCH] rpadlpar: fix potential drc_name corruption in store functions

2021-03-14 Thread Michael Ellerman
Tyrel Datwyler writes: > On 3/13/21 1:17 AM, Michal Suchánek wrote: >> On Wed, Mar 10, 2021 at 04:30:21PM -0600, Tyrel Datwyler wrote: >>> Both add_slot_store() and remove_slot_store() try to fix up the drc_name >>> copied from the store buffer by placing a NULL terminator at nbyte + 1 >>> or in p

Re: [PATCH] powerpc: kernel: Trivial spelling fixes throughout the file head_fsl_booke.S

2021-03-14 Thread Michael Ellerman
Randy Dunlap writes: > On 3/14/21 3:04 PM, Bhaskar Chowdhury wrote: >> >> Trivial spelling fixes throughout the file. >> >> Signed-off-by: Bhaskar Chowdhury >> --- >> arch/powerpc/kernel/head_fsl_booke.S | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-3 tag

2021-03-14 Thread Michael Ellerman
f [en/dis]able_kernel_vsx() powerpc/traps: unrecoverable_exception() is not an interrupt handler Daniel Axtens (1): powerpc/64s/exception: Clean up a missed SRR specifier Michael Ellerman (1): powerpc/64s: Use symbolic macros for function entry encoding Naveen N. Rao (1): pow

Re: [PATCH v2 00/43] powerpc/32: Switch to interrupt entry/exit in C

2021-03-14 Thread Michael Ellerman
On Tue, 9 Mar 2021 12:09:25 + (UTC), Christophe Leroy wrote: > This series aims at porting interrupt entry/exit in C on PPC32, using > the work already merged for PPC64. > > First two patches are a fix and an optimisation of unrecoverable_exception() > function. > > Six following patches do

Re: [PATCH] powerpc/603: Fix protection of user pages mapped with PROT_NONE

2021-03-14 Thread Michael Ellerman
On Mon, 1 Feb 2021 06:29:50 + (UTC), Christophe Leroy wrote: > On book3s/32, page protection is defined by the PP bits in the PTE > which provide the following protection depending on the access > keys defined in the matching segment register: > - PP 00 means RW with key 0 and N/A with key 1. >

Re: [PATCH] powerpc: Force inlining of mmu_has_feature to fix build failure

2021-03-14 Thread Michael Ellerman
On Sat, 27 Feb 2021 16:30:48 + (UTC), Christophe Leroy wrote: > The test robot has managed to generate a random config leading > to following build failure: > > LD .tmp_vmlinux.kallsyms1 > powerpc64-linux-ld: arch/powerpc/mm/pgtable.o: in function > `ptep_set_access_flags': > pgtable.c

Re: [PATCH] powerpc/syscall: Force inlining of __prep_irq_for_enabled_exit()

2021-03-14 Thread Michael Ellerman
On Wed, 24 Feb 2021 06:34:22 + (UTC), Christophe Leroy wrote: > As reported by kernel test robot, a randconfig with high amount of > debuging options can lead to build failure for undefined reference > to replay_soft_interrupts() on ppc32. > > This is due to gcc not seeing that __prep_irq_for_

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-14 Thread Michael Ellerman
On Tue, 9 Mar 2021 08:39:39 + (UTC), Christophe Leroy wrote: > Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() > when CONFIG_VSX is not set, to avoid following build failure. > > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o > In file included from >

Re: [PATCH v2 25/43] powerpc/32: Replace ASM exception exit by C exception exit from ppc64

2021-03-11 Thread Michael Ellerman
Christophe Leroy writes: > Le 11/03/2021 à 14:46, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> This patch replaces the PPC32 ASM exception exit by C exception exit. >>> >>> Signed-off-by: Christophe Leroy >>> --

Re: [PATCH v2 25/43] powerpc/32: Replace ASM exception exit by C exception exit from ppc64

2021-03-11 Thread Michael Ellerman
Christophe Leroy writes: > This patch replaces the PPC32 ASM exception exit by C exception exit. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_32.S | 481 +--- > arch/powerpc/kernel/interrupt.c | 4 + > 2 files changed, 132 insertions(+), 35

Re: [PATCH 2/6] mm: Generalize SYS_SUPPORTS_HUGETLBFS (rename as ARCH_SUPPORTS_HUGETLBFS)

2021-03-09 Thread Michael Ellerman
lication and makes it cleaner. > > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Thomas Bogendoerfer > Cc: "James E.J. Bottomley" > Cc: Helge Deller > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Pau

Re: [PATCH v4] powerpc/uprobes: Validation for prefixed instruction

2021-03-09 Thread Michael Ellerman
Ravi Bangoria writes: > On 3/9/21 4:51 PM, Naveen N. Rao wrote: >> On 2021/03/09 08:54PM, Michael Ellerman wrote: >>> Ravi Bangoria writes: >>>> As per ISA 3.1, prefixed instruction should not cross 64-byte >>>> boundary. So don't allow Uprobe on

Re: [PATCH v2] powerpc/kexec_file: Restore FDT size estimation for kdump kernel

2021-03-09 Thread Michael Ellerman
| 26 -- >> 3 files changed, 10 insertions(+), 20 deletions(-) > > I ended up delaying the referenced series til 5.13, but have applied > it now. Can I get an ack from the powerpc maintainers on this one? > I'll fixup the commit log to make sense given the commit id's aren't > valid. Thanks for handling it. Acked-by: Michael Ellerman cheers

Re: [PATCH v4] powerpc/uprobes: Validation for prefixed instruction

2021-03-09 Thread Michael Ellerman
Ravi Bangoria writes: > As per ISA 3.1, prefixed instruction should not cross 64-byte > boundary. So don't allow Uprobe on such prefixed instruction. > > There are two ways probed instruction is changed in mapped pages. > First, when Uprobe is activated, it searches for all the relevant > pages an

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-2 tag

2021-03-07 Thread Michael Ellerman
(1): powerpc/pseries: Don't enforce MSI affinity with kdump Jordan Niethe (1): powerpc/sstep: Fix VSX instruction emulation Michael Ellerman (1): powerpc/4xx: Fix build errors from mfdcr() Uwe Kleine-König (1): vio: make remove callback return void arch/powerpc/inc

Re: [PATCH V3] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-05 Thread Michael Ellerman
Anshuman Khandual writes: > HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual > platform subscribing it. Instead just make it generic. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Andrew Morton > Cc: Christoph H

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-05 Thread Michael Ellerman
Will Deacon writes: > On Wed, Mar 03, 2021 at 06:57:09PM +0100, Christophe Leroy wrote: >> Le 03/03/2021 à 18:46, Will Deacon a écrit : >> > On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: >> > > Le 03/03/2021 à 18:28, Will Deacon a écrit : >> > > > On Tue, Mar 02, 2021 at 05:25:

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-05 Thread Michael Ellerman
Marco Elver writes: ... > > The choice is between: > > 1. ARCH_FUNC_PREFIX (as a matter of fact, the ARCH_FUNC_PREFIX patch > is already in -mm). Perhaps we could optimize it further, by checking > ARCH_FUNC_PREFIX in buf, and advancing buf like you propose, but I'm > not sure it's worth worrying

Re: [PATCH] powerpc/pseries: export LPAR security flavor in lparcfg

2021-03-05 Thread Michael Ellerman
Laurent Dufour writes: > Le 05/03/2021 à 07:23, Michael Ellerman a écrit : >> Laurent Dufour writes: >>> This is helpful to read the security flavor from inside the LPAR. >> >> We already have /sys/kernel/debug/powerpc/security_features. >> >> Is th

Re: [PATCH] powerpc/pseries: export LPAR security flavor in lparcfg

2021-03-04 Thread Michael Ellerman
Laurent Dufour writes: > This is helpful to read the security flavor from inside the LPAR. We already have /sys/kernel/debug/powerpc/security_features. Is that not sufficient? > Export it like this in /proc/powerpc/lparcfg: > > $ grep security_flavor /proc/powerpc/lparcfg > security_flavor=1 >

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Michael Ellerman
Marco Elver writes: > On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote: >> Le 04/03/2021 à 12:31, Marco Elver a écrit : >> > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy >> > wrote: >> > > Le 03/03/2021 à 11:56, Marco Elver a écrit : >> > > > >> > > > Somewhat tangentially, I also

Re: [PATCH v2] powerpc: Fix save_stack_trace_regs() to have running function as first entry

2021-03-04 Thread Michael Ellerman
Christophe Leroy writes: > It seems like other architectures, namely x86 and arm64 > at least, include the running function as top entry when saving > stack trace with save_stack_trace_regs(). Also riscv AFAICS. > Functionnalities like KFENCE expect it. > > Do the same on powerpc, it allows KFEN

Re: linux-next: build failure after merge of the powerpc-fixes tree

2021-03-02 Thread Michael Ellerman
Uwe Kleine-König writes: > Hello, > > On 3/2/21 3:09 AM, Michael Ellerman wrote: >> Stephen Rothwell writes: >>> Hi all, >>> >>> After merging the powerpc-fixes tree, today's linux-next build (powerpc >>> allyesconfig) failed like this: &

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-02 Thread Michael Ellerman
Christophe Leroy writes: > Le 02/03/2021 à 10:53, Marco Elver a écrit : >> On Tue, 2 Mar 2021 at 10:27, Christophe Leroy >> wrote: >>> Le 02/03/2021 à 10:21, Alexander Potapenko a écrit : > [ 14.998426] BUG: KFENCE: invalid read in > finish_task_switch.isra.0+0x54/0x23c > [ 14.99

Re: [PATCH] powerpc: iommu: fix build when neither PCI or IBMVIO is set

2021-03-02 Thread Michael Ellerman
Randy Dunlap writes: > When neither CONFIG_PCI nor CONFIG_IBMVIO is enabled: > > ../arch/powerpc/kernel/iommu.c:178:30: error: 'fail_iommu_bus_notifier' > defined but not used [-Werror=unused-variable] > 178 | static struct notifier_block fail_iommu_bus_notifier = { > > If only that struct is b

Re: linux-next: build failure after merge of the powerpc-fixes tree

2021-03-01 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > After merging the powerpc-fixes tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/ethernet/ibm/ibmvnic.c:5399:13: error: conflicting types for > 'ibmvnic_remove' > 5399 | static void ibmvnic_remove(struct vio_dev *dev

Re: [PATCH v2] vio: make remove callback return void

2021-02-25 Thread Michael Ellerman
Uwe Kleine-König writes: > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All users already unconditionally return

Re: [PATCH] crypto/nx: add missing call to of_node_put()

2021-02-25 Thread Michael Ellerman
Yang Li writes: > In one of the error paths of the for_each_child_of_node() loop, > add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function > "for_each_child_of_node" should have of_node_put() before return

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag

2021-02-22 Thread Michael Ellerman
Rob Herring writes: > On Mon, Feb 22, 2021 at 6:05 AM Michael Ellerman wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> Hi Linus, >> >> Please pull powerpc updates for 5.12. >> >> There will be a conflict with the d

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag

2021-02-22 Thread Michael Ellerman
"Oliver O'Halloran" writes: > On Tue, Feb 23, 2021 at 9:44 AM Linus Torvalds > wrote: >> >> On Mon, Feb 22, 2021 at 4:06 AM Michael Ellerman wrote: >> > >> > Please pull powerpc updates for 5.12. >> >> Pulled. However: >> >

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag

2021-02-22 Thread Michael Ellerman
ee() call in dlpar_store() powerpc/pseries: Delete an error message for a failed string duplication in dlpar_store() powerpc/82xx: Delete an unnecessary of_node_put() call in pq2ads_pci_init_irq() powerpc/82xx: Use common error handling code in pq2ads_pci_init_irq() powerp

Re: linux-next: manual merge of the devicetree tree with the powerpc tree

2021-02-18 Thread Michael Ellerman
Rob Herring writes: > On Thu, Feb 18, 2021 at 5:34 AM Stephen Rothwell > wrote: >> On Thu, 18 Feb 2021 21:44:37 +1100 Michael Ellerman >> wrote: >> > >> > I think it just needs this? >> > >> > diff --git a/arch/powerpc/kexec/elf_64.c

Re: {standard input}:577: Error: unsupported relocation against base

2021-02-18 Thread Michael Ellerman
Feng Tang writes: > Hi Michael, > > On Tue, Feb 16, 2021 at 08:36:02PM +1100, Michael Ellerman wrote: >> Feng Tang writes: >> > Hi Christophe and Michael, >> > >> > On Mon, Jan 18, 2021 at 10:24:08PM +0800, Christophe Leroy wrote: >> >>

Re: linux-next: manual merge of the devicetree tree with the powerpc tree

2021-02-18 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the devicetree tree got a conflict in: > > arch/powerpc/kexec/elf_64.c > > between commit: > > 2377c92e37fe ("powerpc/kexec_file: fix FDT size estimation for kdump > kernel") > > from the powerpc tree and commit: > > 130b2d5

Re: {standard input}:577: Error: unsupported relocation against base

2021-02-16 Thread Michael Ellerman
Segher Boessenkool writes: > Hi! > > On Tue, Feb 16, 2021 at 08:36:02PM +1100, Michael Ellerman wrote: >> Feng Tang writes: >> > {standard input}:577: Error: unsupported relocation against base >> > {standard input}:580: Error: unsupported relocation against

Re: {standard input}:577: Error: unsupported relocation against base

2021-02-16 Thread Michael Ellerman
Feng Tang writes: > Hi Christophe and Michael, > > On Mon, Jan 18, 2021 at 10:24:08PM +0800, Christophe Leroy wrote: >> >> Le 05/01/2021 ? 11:58, kernel test robot a 閏rit : >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> > master >> > head: e71ba9452f0b5b2e8d

Re: [PATCH] powerpc/xive: Assign boolean values to a bool variable

2021-02-11 Thread Michael Ellerman
On Sun, 7 Feb 2021 14:43:12 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./arch/powerpc/kvm/book3s_xive.c:1856:2-17: WARNING: Assignment of 0/1 > to bool variable. > > ./arch/powerpc/kvm/book3s_xive.c:1854:2-17: WARNING: Assignment of 0/1 > to bool variable. Applied t

Re: [PATCH v5 00/22] powerpc/32: Implement C syscall entry/exit

2021-02-11 Thread Michael Ellerman
On Mon, 8 Feb 2021 15:10:19 + (UTC), Christophe Leroy wrote: > This series implements C syscall entry/exit for PPC32. It reuses > the work already done for PPC64. > > This series is based on today's merge-test > (b6f72fc05389e3fc694bf5a5fa1bbd33f61879e0) > > In terms on performance we have t

Re: [PATCH v2 1/3] powerpc/uaccess: get rid of small constant size cases in raw_copy_{to,from}_user()

2021-02-11 Thread Michael Ellerman
On Tue, 9 Feb 2021 14:02:12 + (UTC), Christophe Leroy wrote: > Copied from commit 4b842e4e25b1 ("x86: get rid of small > constant size cases in raw_copy_{to,from}_user()") > > Very few call sites where that would be triggered remain, and none > of those is anywhere near hot enough to bother.

Re: [PATCH v6 0/2] powerpc/32: Implement C syscall entry/exit (complement)

2021-02-11 Thread Michael Ellerman
On Tue, 9 Feb 2021 19:29:26 + (UTC), Christophe Leroy wrote: > This series implements C syscall entry/exit for PPC32. It reuses > the work already done for PPC64. > > This series is based on today's next-test (f538b53fd47a) where main patchs > from v5 are merged in. > > The first patch is im

Re: [PATCH 1/3] spi: mpc52xx: Avoid using get_tbl()

2021-02-11 Thread Michael Ellerman
On Tue, 9 Feb 2021 10:26:21 + (UTC), Christophe Leroy wrote: > get_tbl() is confusing as it returns the content TBL register > on PPC32 but the concatenation of TBL and TBU on PPC64. > > Use mftb() instead. > > This will allow the removal of get_tbl() in a following patch. Applied to powerpc

Re: [PATCH] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-11 Thread Michael Ellerman
On Mon, 8 Feb 2021 07:17:40 + (UTC), Christophe Leroy wrote: > THREAD_ALIGN_SHIFT = THREAD_SHIFT + 1 = PAGE_SHIFT + 1 > Maximum PAGE_SHIFT is 18 for 256k pages so > THREAD_ALIGN_SHIFT is 19 at the maximum. > > No need to clobber cr1, it can be preserved when moving r1 > into CR when we check s

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-8 tag

2021-02-11 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull one final powerpc fix for 5.11: The following changes since commit 24321ac668e452a4942598533d267805f291fdc9: powerpc/64/signal: Fix regression in __kernel_sigtramp_rt64() semantics (2021-02-02 22:14:41 +1100) are availabl

Re: [PATCH] arch: powerpc: kernel: Fix the spelling mismach to mismatch in head.44x.S

2021-02-10 Thread Michael Ellerman
On Tue, 2 Feb 2021 15:07:46 +0530, Bhaskar Chowdhury wrote: > s/mismach/mismatch/ Applied to powerpc/next. [1/1] powerpc/44x: Fix a spelling mismach to mismatch in head_44x.S https://git.kernel.org/powerpc/c/ea7826583f5ed7abca97e6e56441caadcbbd957a cheers

Re: [PATCH] powerpc/8xx: Fix software emulation interrupt

2021-02-10 Thread Michael Ellerman
On Fri, 5 Feb 2021 08:56:13 + (UTC), Christophe Leroy wrote: > For unimplemented instructions or unimplemented SPRs, the 8xx triggers > a "Software Emulation Exception" (0x1000). That interrupt doesn't set > reason bits in SRR1 as the "Program Check Exception" does. > > Go through emulation_as

Re: [PATCH] powerpc/uaccess: Perform barrier_nospec() in KUAP allowance helpers

2021-02-10 Thread Michael Ellerman
On Sun, 7 Feb 2021 10:08:11 + (UTC), Christophe Leroy wrote: > barrier_nospec() in uaccess helpers is there to protect against > speculative accesses around access_ok(). > > When using user_access_begin() sequences together with > unsafe_get_user() like macros, barrier_nospec() is called for >

Re: [PATCH 1/3] powerpc/32s: Change mfsrin() into a static inline function

2021-02-10 Thread Michael Ellerman
On Sat, 6 Feb 2021 11:47:26 + (UTC), Christophe Leroy wrote: > mfsrin() is a macro. > > Change in into an inline function to avoid conflicts in KVM > and make it more evolutive. Applied to powerpc/next. [1/3] powerpc/32s: Change mfsrin() into a static inline function https://git.kernel

Re: [PATCH v16 11/12] powerpc: Use OF alloc and free for FDT

2021-02-07 Thread Michael Ellerman
Rob Herring writes: > On Thu, Feb 4, 2021 at 10:42 AM Lakshmi Ramasubramanian > wrote: ... >> diff --git a/arch/powerpc/kexec/elf_64.c b/arch/powerpc/kexec/elf_64.c >> index d0e459bb2f05..51d2d8eb6c1b 100644 >> --- a/arch/powerpc/kexec/elf_64.c >> +++ b/arch/powerpc/kexec/elf_64.c >> @@ -19,6 +19

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-7 tag

2021-02-06 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.11: The following changes since commit 4025c784c573cab7e3f84746cc82b8033923ec62: powerpc/64s: prevent recursive replay_soft_interrupts causing superfluous interrupt (2021-01-24 22:27:24 +1100)

Re: [PATCH v2 1/1] powerpc/kvm: Save Timebase Offset to fix sched_clock() while running guest code.

2021-02-05 Thread Michael Ellerman
Nicholas Piggin writes: > Excerpts from Leonardo Bras's message of February 5, 2021 4:06 pm: >> Before guest entry, TBU40 register is changed to reflect guest timebase. >> After exitting guest, the register is reverted to it's original value. >> >> If one tries to get the timestamp from host betw

Re: [PATCH 01/13] powerpc/powernv: remove get_cxl_module

2021-02-04 Thread Michael Ellerman
gt; Reviewed-by: Andrew Donnellan > --- > arch/powerpc/platforms/powernv/pci-cxl.c | 22 -- > 1 file changed, 22 deletions(-) Acked-by: Michael Ellerman cheers

Re: [PATCH 1/2] powerpc/vdso: fix unnecessary rebuilds of vgettimeofday.o

2021-02-03 Thread Michael Ellerman
On Thu, 24 Dec 2020 02:11:41 +0900, Masahiro Yamada wrote: > vgettimeofday.o is unnecessarily rebuilt. Adding it to 'targets' is not > enough to fix the issue. Kbuild is correctly rebuilding it because the > command line is changed. > > PowerPC builds each vdso directory twice; first in vdso_prepa

Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock

2021-02-03 Thread Michael Ellerman
On Thu, 24 Dec 2020 21:24:46 +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). Applied to powerpc/next. [1/1] ocxl: use DEFINE_MUTEX() for mutex lock https://git.kernel.org/powerpc/c/52f6b0a90bcf573ba

Re: [PATCH] powerpc/kvm: Force selection of CONFIG_PPC_FPU

2021-02-03 Thread Michael Ellerman
On Tue, 19 Jan 2021 06:36:52 + (UTC), Christophe Leroy wrote: > book3s/32 kvm is designed with the assumption that > an FPU is always present. > > Force selection of FPU support in the kernel when > build KVM. Applied to powerpc/next. [1/1] powerpc/kvm: Force selection of CONFIG_PPC_FPU

Re: [PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant

2021-02-03 Thread Michael Ellerman
On Mon, 28 Dec 2020 12:34:59 +0800, Po-Hsu Lin wrote: > The == operand is a bash extension, thus this will fail on Ubuntu with > > As the /bin/sh on Ubuntu is pointed to DASH. > > Use -eq to fix this posix compatibility issue. Applied to powerpc/next. [1/1] selftests/powerpc: Make the test chec

Re: [PATCH] powerpc/setup: Adjust six seq_printf() calls in show_cpuinfo()

2021-02-03 Thread Michael Ellerman
On Tue, 2 Jul 2019 14:56:46 +0200, Markus Elfring wrote: > A bit of information should be put into a sequence. > Thus improve the execution speed for this data output by better usage > of corresponding functions. > > This issue was detected by using the Coccinelle software. Applied to powerpc/nex

Re: [PATCH] powerpc: Fix build error in paravirt.h

2021-02-03 Thread Michael Ellerman
On Wed, 20 Jan 2021 14:28:38 +0100, Michal Suchanek wrote: > ./arch/powerpc/include/asm/paravirt.h:83:44: error: implicit declaration > of function 'smp_processor_id'; did you mean 'raw_smp_processor_id'? > > smp_processor_id is defined in linux/smp.h but it is not included. > > The build error h

Re: [PATCH 0/2] PowerPC-pSeries: Adjustments for dlpar_store()

2021-02-03 Thread Michael Ellerman
On Tue, 27 Aug 2019 14:40:42 +0200, Markus Elfring wrote: > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete an unnecessary kfree() call > Delete an error message for a failed string duplication > > [...] Applied to powerpc/n

Re: [PATCH 0/2] powerpc/82xx: Adjustments for pq2ads_pci_init_irq()

2021-02-03 Thread Michael Ellerman
On Tue, 27 Aug 2019 10:23:29 +0200, Markus Elfring wrote: > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete an unnecessary of_node_put() call > Use common error handling code > > [...] Applied to powerpc/next. [1/2] powerpc

Re: [PATCH] powerpc/xmon: Enable breakpoints on 8xx

2021-02-03 Thread Michael Ellerman
On Wed, 23 Dec 2020 09:38:48 + (UTC), Christophe Leroy wrote: > Since commit 4ad8622dc548 ("powerpc/8xx: Implement hw_breakpoint"), > 8xx has breakpoints so there is no reason to opt breakpoint logic > out of xmon for the 8xx. Applied to powerpc/next. [1/1] powerpc/xmon: Enable breakpoints on

Re: [PATCH v2] powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected

2021-02-03 Thread Michael Ellerman
On Fri, 18 Dec 2020 06:56:05 + (UTC), Christophe Leroy wrote: > It is now possible to only build book3s/32 kernel for > CPUs without hash table. > > Opt out hash related code when CONFIG_PPC_BOOK3S_604 is not selected. Applied to powerpc/next. [1/1] powerpc/32s: Only build hash code when CON

Re: [PATCH] powerpc/47x: Disable 256k page size

2021-02-03 Thread Michael Ellerman
On Tue, 19 Jan 2021 07:00:00 + (UTC), Christophe Leroy wrote: > PPC47x_TLBE_SIZE isn't defined for 256k pages, so > this size of page shall not be selected for 47x. Applied to powerpc/next. [1/1] powerpc/47x: Disable 256k page size https://git.kernel.org/powerpc/c/910a0cb6d259736a0c86e7

Re: [PATCH 1/2] powerpc/47x: Disable 256k page size

2021-02-03 Thread Michael Ellerman
On Wed, 20 Jan 2021 07:49:13 + (UTC), Christophe Leroy wrote: > PPC47x_TLBE_SIZE isn't defined for 256k pages, so > this size of page shall not be selected for 47x. Applied to powerpc/next. [1/2] powerpc/47x: Disable 256k page size https://git.kernel.org/powerpc/c/910a0cb6d259736a0c86e7

Re: [PATCH] powerpc/mm/book3s64/iommu: fix some RCU-list locks

2021-02-03 Thread Michael Ellerman
On Sun, 10 May 2020 01:15:59 -0400, Qian Cai wrote: > It is safe to traverse mm->context.iommu_group_mem_list with either > mem_list_mutex or the RCU read lock held. Silence a few RCU-list false > positive warnings and fix a few missing RCU read locks. > > arch/powerpc/mm/book3s64/iommu_api.c:330

Re: [PATCH] powerpc/powernv/pci: fix a RCU-list lock

2021-02-03 Thread Michael Ellerman
On Sun, 10 May 2020 01:13:47 -0400, Qian Cai wrote: > It is unsafe to traverse tbl->it_group_list without the RCU read lock. > > WARNING: suspicious RCU usage > 5.7.0-rc4-next-20200508 #1 Not tainted > - > arch/powerpc/platforms/powernv/pci-ioda-tce.c:355 RCU-list t

Re: [PATCH] powerpc: fix AKEBONO build failures

2021-01-31 Thread Michael Ellerman
Randy Dunlap writes: > On 1/21/21 5:14 PM, Michael Ellerman wrote: >> Randy Dunlap writes: >>> On 1/20/21 1:29 PM, Yury Norov wrote: >>>> Hi all, >>>> >>>> I found the power pc build broken on today's >>>> linux-next (64706

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-6 tag

2021-01-31 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull another powerpc fix for 5.11: The following changes since commit 08685be7761d69914f08c3d6211c543a385a5b9c: powerpc/64s: fix scv entry fallback flush vs interrupt (2021-01-20 15:58:19 +1100) are available in the git reposi

[PATCH v2] MAINTAINERS: Add pattern that matches powerpc perf to the perf entry.

2021-01-29 Thread Michael Ellerman
From: Michal Suchanek The powerpc perf code is under arch/powerpc/perf, add a matching pattern to the perf MAINTAINERS entry. Signed-off-by: Michal Suchanek [mpe: Rebase and add change log] Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20191113162754.6991-1-msucha...@suse.de

Re: [PATCH v11 13/13] powerpc/64s/radix: Enable huge vmalloc mappings

2021-01-27 Thread Michael Ellerman
Nicholas Piggin writes: > Cc: linuxppc-...@lists.ozlabs.org > Signed-off-by: Nicholas Piggin > --- Acked-by: Michael Ellerman cheers > .../admin-guide/kernel-parameters.txt | 2 ++ > arch/powerpc/Kconfig | 1 + > arch/power

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-5 tag

2021-01-24 Thread Michael Ellerman
selftest fixes. Thanks to Eirik Fuller, Libor Pechacek, Nicholas Piggin, Sandipan Das, Tulio Magno Quites Machado Filho. - -- Michael Ellerman (1): selftests/powerpc: Only test lwm/stmw on big endian Nicholas Piggin (1): powerpc

Re: [PATCH] powerpc: fix AKEBONO build failures

2021-01-21 Thread Michael Ellerman
gt; - AKEBONO [=y] && PPC_47x [=y] > > WARNING: unmet direct dependencies detected for MMC_SDHCI > Depends on [n]: MMC [=n] && HAS_DMA [=y] > Selected by [y]: > - AKEBONO [=y] && PPC_47x [=y] > > Signed-off-by: Randy Dunlap > Cc: Michael E

Re: [PATCH] powerpc/47x: Disable 256k page size

2021-01-19 Thread Michael Ellerman
Christophe Leroy writes: > PPC47x_TLBE_SIZE isn't defined for 256k pages, so > this size of page shall not be selected for 47x. > > Reported-by: kernel test robot > Fixes: e7f75ad01d59 ("powerpc/47x: Base ppc476 support") > Signed-off-by: Christophe Leroy > --- > arch/powerpc/Kconfig | 2 +- >

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-4 tag

2021-01-17 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.11: The following changes since commit 3ce47d95b7346dcafd9bed3556a8d072cb2b8571: powerpc: Handle .text.{hot,unlikely}.* in linker script (2021-01-06 21:59:04 +1100) are available in the git r

Re: [PATCH v2] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-15 Thread Michael Ellerman
On Mon, 4 Jan 2021 13:59:53 -0700, Nathan Chancellor wrote: > Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input > sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM > change [1]. > > After another LLVM change [2], these sections are seen in some PowerPC > builds, whe

Re: [PATCH v3] powerpc/vdso: fix clock_gettime_fallback for vdso32

2021-01-15 Thread Michael Ellerman
On Tue, 12 Jan 2021 11:55:15 + (UTC), Christophe Leroy wrote: > The second argument of __kernel_clock_gettime64 points to a struct > __kernel_timespec, with 64-bit time_t, so use the clock_gettime64 syscall > in the fallback function for the 32-bit vdso. Similarily, > clock_getres_fallback sho

Re: [PATCH v2] powerpc: fix alignment bug whithin the init sections

2021-01-15 Thread Michael Ellerman
On Sat, 2 Jan 2021 22:11:56 +0200, Ariel Marcovitch wrote: > This is a bug that causes early crashes in builds with a > .exit.text section smaller than a page and a .init.text section that > ends in the beginning of a physical page (this is kinda random, which > might explain why this wasn't really

Re: [PATCH] perf tools: Resolve symbols against debug file first

2021-01-14 Thread Michael Ellerman
Namhyung Kim writes: > On Wed, Jan 13, 2021 at 8:43 PM Jiri Slaby wrote: >> >> On 13. 01. 21, 11:46, Jiri Olsa wrote: >> > On Wed, Jan 13, 2021 at 09:01:28AM +0100, Jiri Slaby wrote: >> >> With LTO, there are symbols like these: >> >> /usr/lib/debug/usr/lib64/libantlr4-runtime.so.4.8-4.8-1.4.x86_

Re: [PATCH v2] powerpc/vdso: fix clock_gettime_fallback for vdso32

2021-01-11 Thread Michael Ellerman
Christophe Leroy writes: > From: Andreas Schwab > > The second argument of __kernel_clock_gettime64 points to a struct > __kernel_timespec, with 64-bit time_t, so use the clock_gettime64 syscall > in the fallback function for the 32-bit vdso. Similarily, > clock_getres_fallback should use the cl

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-3 tag

2021-01-10 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull a couple of powerpc fixes for 5.11: The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: Linux 5.11-rc2 (2021-01-03 15:55:30 -0800) are available in the git repository at: https://git.kernel.org/

[PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread Michael Ellerman
/freescale/fs_enet/mii-bitbang.o Add the missing MODULE_LICENSEs to fix the build. Both files include a copyright header indicating they are GPL v2. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + drivers/net/ethernet/freescale/fs_enet/mii-fec.c

Re: [PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread Michael Ellerman
Andrew Lunn writes: > On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: >> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() >> into error") the ppc32_allmodconfig build fails with: >> >> ERROR: modpost: missing MODULE_

[PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Michael Ellerman
/freescale/fs_enet/mii-bitbang.o Add the missing MODULE_LICENSEs to fix the build. Both files include a copyright header indicating they are GPL v2. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + drivers/net/ethernet/freescale/fs_enet/mii-fec.c

<    1   2   3   4   5   6   7   8   9   10   >