On 12/16/2015 07:16 PM, Jason Gunthorpe wrote:
> On Wed, Dec 16, 2015 at 11:26:39AM +0100, Michael Wang wrote:
[snip]
>>
>> I've rechecked the ib_init_ah_from_path() again, and found it
>> still set IB_AH_GRH when the GID cache missing, but
erencing in kmemleak scanning.
The 'irq_remap_table' allocated won't be freed after initialized,
doesn't make sense to let kmemleak scan it.
This patch mark the 'irq_remap_table' object as 'ignored' to
stop the 'false positives' report.
Signed-of
ncing 'irq_remap_table' in
kmemleak scan.
The 'irq_remap_table' won't be freed after initialized, doesn't
make sense to check it's leaking.
This patch mark the 'irq_remap_table' object as 'gray' to stop
the 'false positives' report
On 11/20/2015 12:33 PM, Michael Wang wrote:
> The kmemleak testing on 3.18.24 show:
>
> unreferenced object 0x880233ff9010 (size 16):
> comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s)
> hex dump (first 16 bytes):
> 0a 0a 00 00 20 00 0
Hi, Joerg
On 11/25/2015 04:14 PM, Michael Wang wrote:
> On 11/25/2015 04:08 PM, Joerg Roedel wrote:
[snip]
>>> This is caused by the 'irq_lookup_table' was allocated with
>>> __get_free_pages() which won't create kmemleak object, thus it's
&
, or will you pick this patch?
>
> My preference (from a kmemleak perspective) is to tell kmemleak about
> the irq_lookup_table. Untested:
I'm fine with both solution, will leave the decision to maintainer :-)
BTW, could you please send a formal patch with descriptions?
Regards,
M
On 12/02/2015 12:31 PM, Catalin Marinas wrote:
> On 2 December 2015 at 10:56, Michael Wang wrote:
[snip]
>
> I could copy your description but I don't currently have a way (nor
> time) to test the patch. If you plan to test it anyway, please feel
> free to include my dif
On 12/02/2015 12:51 PM, Joerg Roedel wrote:
> On Wed, Dec 02, 2015 at 12:38:03PM +0100, Michael Wang wrote:
>> Joerg, this is really a tiny fix, would you mind to merge it into some
>> of your cleanup patch and testing them together? we are not in hurry,
>> just want to mak
On 12/02/2015 01:53 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote:
>> It's not my work or your work... it's a defect in the module and maintainer
>> should take responsibility on fixing it, correct?
>
> Well, you said &q
On 12/02/2015 01:56 PM, Joerg Roedel wrote:
> On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote:
>> It's not my work or your work... it's a defect in the module and maintainer
>> should take responsibility on fixing it, correct?
>
> No, its a false posi
Hi, Borislav
On 12/02/2015 02:13 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 02:01:55PM +0100, Michael Wang wrote:
>> Yeah.. it's a little complicated since we have our own kernel tree and this
>> won't be a problem for us, but we really prefer to help fix it in
On 12/02/2015 02:40 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 02:18:44PM +0100, Michael Wang wrote:
[snip]
>
>> Yeah, but it would be better to solve it, otherwise whoever saw this
>> report will need to go into the amd-iommu, make sure it's not a real
>
On 12/02/2015 02:59 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 02:48:47PM +0100, Michael Wang wrote:
>> I'm not sure why amd-iommu use get_page not kmalloc to initialize the
>> pointer table, but if it's necessary then the conflict will be there,
>>
On 12/02/2015 03:13 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 03:09:18PM +0100, Michael Wang wrote:
>> This tool will help improve the kernel, AFAIK it's already made it's
>> best, if you got any idea on how to make it even better that would be
>> grea
gs, additional annotations or specific page
> alloc API. However, this has its own drawbacks in terms of code
> complexity (potentially outside mm/kmemleak.c) and overhead.
Thanks for the very nice explain :-) I used to thought overhead is
the only concern, missing the point regardi
at if the transport don't require GRH?
eg inside the same subnet?
The hop_limit is only suggest that the package allowed to be
routed, not have to, correct?
Regards,
Michael Wang
> + if (ret)
> + return ret;
> +
> av->timeout = path->packet_life_ti
Hi, Joery
On 11/20/2015 12:33 PM, Michael Wang wrote:
> The kmemleak testing on 3.18.24 show:
>
> unreferenced object 0x880233ff9010 (size 16):
> comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s)
> hex dump (first 16 bytes):
> 0a 0a 00 00 20 00 0
On 11/25/2015 04:08 PM, Joerg Roedel wrote:
> On Fri, Nov 20, 2015 at 12:33:50PM +0100, Michael Wang wrote:
>> The kmemleak testing on 3.18.24 show:
>>
>> unreferenced object 0x880233ff9010 (size 16):
>> comm "swapper/0", pid 1, jiffies 4294937440 (a
On 05/13/2015 05:59 PM, Jason Gunthorpe wrote:
> On Wed, May 13, 2015 at 03:24:32PM +0200, Michael Wang wrote:
>> This is the following patch for:
>> https://lkml.org/lkml/2015/5/5/417
>> which try to document the settled rdma_cap_XX().
>>
>> Highlights:
ated features.
> Management Datagrams (MAD) are a required part of the InfiniBand
> specification and are supported on all InfiniBand devices. A slightly
> extended version are also supported on OPA interfaces.
>
> I would drop all instances of "use the helper to verify...&
+Infiniband address handler format is special in ethernet fabric,
>> use
>>> +the helper to verify whether the port is using ethernet format or
>> not.
>>
>> This helper is true when the address of the specific connection is of
>> the Ethernet (RoCE)
e give some description related to connection
below in the long description.
>
[snip]
>> Shall we put this long description into USAGE? Here maybe list
>> all the helpers to give some quick overview with a brief
>> description, what's your opinion?
>
> Given how we
on creating address vector,
but I can understand the concept.
>
> This helper is true when the address family of this queue pair is of the
> Ethernet (RoCE) variety.
Sounds good, will be merged in next version :-)
Regards,
Michael Wang
>
>
--
To unsubscribe from this list:
, please don't
be hesitate to point out the issues, any suggestions to improve or
complete the description are very welcomed ;-)
Signed-off-by: Michael Wang
---
Documentation/infiniband/rdma_helpers.txt | 79 +++
1 file changed, 79 insertions(+)
create mode 1
e :-)
I'll put the highlights and changelog under '---' in next version, is it
looks like this?
Subject: [PATCH RFC v3] Documentation/infiniband: Add docs for rdma-helpers
This is the following patch for:
https://lkml.org/lkml/2015/5/5/417
which try to document the settled
IB
qib IB_CA IB IB IB
Signed-off-by: Michael Wang
---
drivers/infiniband/core/device.c | 1 +
drivers/infiniband/hw/amso1100/c2_provider.c | 7 +++
drivers/infiniband/hw/cxgb3/iwch_provider.c | 7 +++
drivers
Use raw management helpers to reform IB-core multicast.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/multicast.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/infiniband/core/multicast.c
b/drivers/infiniband/core/multicast.c
index fa17b55
Use raw management helpers to reform IB-ulp ipoib.
Signed-off-by: Michael Wang
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c
b/drivers/infiniband/ulp/ipoib/ipoib_main.c
Introduce helper rdma_cap_ib_cm() to help us check if the port of an
IB device support Infiniband Communication Manager.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cm.c | 6 +++---
drivers/infiniband/core/cma.c | 19 +--
drivers/infiniband/core/ucm.c | 2
Introduce helper rdma_cap_iw_cm() to help us check if the port of an
IB device support IWARP Communication Manager.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 14 +++---
include/rdma/ib_verbs.h | 15 +++
2 files changed, 22 insertions(+), 7
Introduce helper rdma_cap_ib_smi() to help us check if the port of an
IB device support Infiniband Subnet Management Interface.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c | 2 +-
drivers/infiniband/core/mad.c | 2 +-
include/rdma/ib_verbs.h | 15
Introduce helper rdma_cap_ib_mcast() to help us check if the port of an
IB device support Infiniband Multicast.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 6 +++---
drivers/infiniband/core/multicast.c | 6 +++---
include/rdma/ib_verbs.h | 15
Introduce helper rdma_cap_ib_sa() to help us check if the port of an
IB device support Infiniband Subnet Administration.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 4 ++--
drivers/infiniband/core/sa_query.c | 10 +-
drivers/infiniband/core/ucma.c | 2
Introduce helper rdma_cap_eth_ah() to help us check if the port of an
IB device support Ethernet Address Handler.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 2 +-
drivers/infiniband/core/sa_query.c | 2 +-
drivers/infiniband/core/verbs.c| 4 ++--
include/rdma
Introduce helper rdma_cap_read_multi_sge() to help us check if the port of an
IB device support RDMA Read Multiple Scatter-Gather Entries.
Signed-off-by: Michael Wang
---
include/rdma/ib_verbs.h | 16
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 ++--
2 files
Introduce helper rdma_cap_af_ib() to help us check if the port of an
IB device support Native Infiniband Address.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 2 +-
include/rdma/ib_verbs.h | 15 +++
2 files changed, 16 insertions(+), 1 deletion(-)
diff
Use raw management helpers to reform mcast related part in IB-core cma.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 56 ++-
1 file changed, 18 insertions(+), 38 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers
Reform cma_acquire_dev() with management helpers, introduce
cma_validate_port() to make the code more clean.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 68 +--
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/drivers
Introduce helper rdma_cap_ib_mad() to help us check if the port of an
IB device support Infiniband Management Datagrams.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/mad.c | 6 +++---
drivers/infiniband/core/user_mad.c | 6 +++---
include/rdma/ib_verbs.h| 15
Use raw management helpers to reform route related part in IB-core cma.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 31 ---
drivers/infiniband/core/ucma.c | 25 ++---
2 files changed, 14 insertions(+), 42 deletions(-)
diff
Use raw management helpers to reform IB-core mad/agent/user_mad.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c| 2 +-
drivers/infiniband/core/mad.c | 43 +++---
drivers/infiniband/core/user_mad.c | 26 ---
3 files
Use raw management helpers to reform rest part in IB-core cma.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 3fb3458
Use raw management helpers to reform IB-core sa_query.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/sa_query.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/infiniband/core/sa_query.c
b/drivers/infiniband/core/sa_query.c
Use raw management helpers to reform cm related part in IB-core cma/ucm.
Few checks focus on the device cm type rather than the port capability,
directly pass port 1 works currently, but can't support mixing cm type
device in future.
Signed-off-by: Michael Wang
---
drivers/infiniband
Use raw management helpers to reform IB-core verbs
Signed-off-by: Michael Wang
---
drivers/infiniband/core/verbs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index f93eb8d..7dd2f51 100644
--- a
Use raw management helpers to reform IB-ulp xprtrdma.
Signed-off-by: Michael Wang
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +--
net/sunrpc/xprtrdma/svc_rdma_transport.c | 45 +---
2 files changed, 20 insertions(+), 29 deletions(-)
diff --git a/net/sunrpc
Use raw management helpers to reform IB-core cm.
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cm.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index e28a494..add5e484 100644
Add raw helpers:
rdma_protocol_ib
rdma_protocol_iboe
rdma_protocol_iwarp
rdma_ib_or_iboe (transition, clean up later)
To help us detect which technology the port supported.
Signed-off-by: Michael Wang
---
include/rdma/ib_verbs.h | 22 ++
1
hive.com/linux-rdma@vger.kernel.org/msg23339.html
Doug:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
Jason:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.h
On 05/05/2015 04:16 PM, Or Gerlitz wrote:
> On 5/5/2015 3:50 PM, Michael Wang wrote:
>> Since v7:
>>* Thanks to Doug, Ira, Devesh for the testing:-)
>>* Thanks for the comments from or, Doug, Ira, Jason:-)
>> Please remind me if anything missed:-P
>&g
any
guidelines on how to write the header of inline func for kdoc?
>
> Just because I want to move this along versus waiting for another
> respin, I'm going to copy and paste these into those locations and clean
> up the changelog when I integrate this patch.
Got it, if there is any
attribution.
The definition is far more detailed and accurate, it's already good enough
according to my understanding, should benefit the developer a lot ;-)
Regards,
Michael Wang
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
ranch with it
> included up to my github repo sometime today.
Got it :-)
Regards,
Michael Wang
>
>> About the Bug, if it was not introduced in this series, maybe including the
>> fix in next series would be better?
>>
>> Regards,
>> Michael Wang
>>
>>&g
e work up an incremental patch to address the kdocs issue.
> I've picked up the v8 patchset, and there is no need to respin it, but I
> would like to have that kdoc patch before the 4.2 merge window opens.
Sure, now these helpers are settled down, it's time for document,
I'll
ption are very welcomed ;-)
Signed-off-by: Michael Wang
---
Documentation/infiniband/rdma_helpers.txt | 76 +++
1 file changed, 76 insertions(+)
create mode 100644 Documentation/infiniband/rdma_helpers.txt
diff --git a/Documentation/infiniband/rdma_helpers.t
asking to merge the #15~23, and want to reserve the changelog
meanwhile reply the cover of prev version (I'm still confused on that...),
I've replied but get no respond yet.
I can make a v9 to merge the #15~#23 if that could benefit the maintainability,
please let me know your opinio
Agree, it sounds more reasonable to include the fix in the series introduced
it :-P
>
>
> For the rest of the series.
>
> Reviewed-by: Ira Weiny
> Tested-by: Ira Weiny
> -- Limited to mlx4, qib, and OPA (with additional patches.)
Thanks for the review and testing :-)
On 05/01/2015 08:34 AM, ira.weiny wrote:
> On Tue, Apr 28, 2015 at 05:10:00PM +0200, Michael Wang wrote:
>> Since v6:
>> * Thanks to Ira, Devesh for the review and testing :-)
>> * Thanks for the comments from Sean, Tom, Jason, Doug, Devesh, Ira,
>> Liran :-) P
Hi, Doug
Thanks for the excellent comments :-)
On 03/26/2015 03:09 PM, Doug Ledford wrote:
> On Wed, 2015-03-25 at 16:09 +0100, Michael Wang wrote:
>> [snip]
>>
> [snip]
>
> So, I would suggest that we fix things up thusly:
>
> enum transport {
> TRANSPOR
On 03/26/2015 05:27 PM, Doug Ledford wrote:
> On Thu, 2015-03-26 at 17:04 +0100, Michael Wang wrote:
>> [snip]
>>
>> Few more questions here is:
>> 1. when to setup? (maybe inside ib_register_device() before doing
>> client->add() callback?)
> I don't
Hi, Jason
Thanks for the reply :-)
On 03/26/2015 10:13 PM, Jason Gunthorpe wrote:
> On Thu, Mar 26, 2015 at 05:58:20PM +0100, Michael Wang wrote:
>
>> The questions is just wondering how the transition method could be, but
>> if we have to do the changes for vendor, that sound
.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
Doug:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html
Jason:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.html
Michael Wang (11):
[PATCH 01/11] IB/Verbs: Use helpers to check tran
s_eth()
and use them to save some code for us.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c | 2 +-
drivers/infiniband/core/cm.c | 2 +-
drivers/infiniband/core/cma.c
Introduce helper tech_iboe() to help us check if the port of an IB
device is using RoCE/IBoE technology.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 6 ++
include/rdma/ib_verbs.h | 16
Introduce helper has_mad() to help us check if an IB device support
Management Datagrams.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/mad.c | 4 ++--
drivers/infiniband/core/user_mad.c | 2 +-
include/rdma
Introduce helper cap_smi() to help us check if the port of an
IB device support Subnet Management Interface.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c | 2 +-
drivers/infiniband/core/mad.c| 2
Introduce helper has_cm() to help us check if an IB device
support Communication Manager.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cm.c | 2 +-
drivers/infiniband/core/cma.c | 10 --
drivers
Introduce helper has_sa() and cap_sa() to help us check if an IB device
or it's port support Subnet Administrator.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/sa_query.c | 12 ++--
include/rdma/ib_ve
Introduce helper has_mcast() and cap_mcast() to help us check if an
IB device or it's port support Multicast.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 2 +-
drivers/infiniband/core/multic
Introduce helper has_ipoib() and cap_ipoib() to help us check if an
IB device or it's port support IP over Infiniband.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 +++---
include
Introduce helper has_iwarp() to help us check if an IB device
support IWARP protocol.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
include/rdma/ib_verbs.h | 13 +
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2
TODO:
We need to classify these check into the management helper.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 5 ++---
drivers/infiniband/hw/mlx4/mad.c | 4 ++--
drivers/infiniband/hw/mlx4/main.c
TODO:
We need to classify these check into the management helper.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c| 2 +-
drivers/infiniband/core/sa_query.c | 2 +-
drivers/infiniband/core
On 03/27/2015 04:55 PM, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2015 at 10:52:10AM +0100, Michael Wang wrote:
>> [snip]
> So, in principle, testing the device should almost make sense. The
> device is the container for things like PD's MR's and QP's and those
&g
On 03/27/2015 05:06 PM, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote:
>
>> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c
>> b/drivers/infiniband/ulp/ipoib/ipoib_main.c
>> index 3341754..fcd7558 100644
>> +++
On 03/27/2015 05:13 PM, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote:
>> Introduce helper has_iwarp() to help us check if an IB device
>> support IWARP protocol.
> Should probably be !has_rdma_read_sges()
>
> True if the device can
tatic type or
infer from transport type (I suppose this won't change dynamically).
Thus I also agreed check inside mcast_event_handler() is unnecessary,
maybe we can change that logical to WARN_ON(!cap_mcast()) ?
Regards,
Michael Wang
>
> So maybe these checks really are redundant?
>
&g
o the performance concern on query_port() need to be addressed,
may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer
[PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology
---
drivers/infiniband
s_eth()
and use them to save some code for us.
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c | 2 +-
drivers/infiniband/core/cm.c | 2 +-
drivers/infiniband/core/cma.c | 27 ---
drivers/infin
This patch will introduce rdma_tech_is_iboe() and use it to save some code.
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 6 ++
include/rdma/ib_verbs.h | 6 ++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers
This should be [PATCH 0/2], and my sincerely apologize on the duplicated
mail, the connection is really terrible...
Regards,
Michael Wang
On 03/25/2015 12:12 PM, Michael Wang wrote:
There are too many lengthy code to check the transport type of IB device,
or the link layer type of it's
need a big work to adapt current implementation to utilize
these flags elegantly.
Also the performance concern on query_port() need to be addressed, may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and
This patch will introduce rdma_tech_is_iboe() and use it to save some code.
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 6 ++
include/rdma/ib_verbs.h | 6 ++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers
s_eth()
and use them to save some code for us.
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/agent.c | 2 +-
drivers/infiniband/core/cm.c | 2 +-
drivers/infiniband/core/cma.c | 27 ---
drivers/infin
Hi, Borislav
Why not just initialized it as NULL, or mark it as uninitialized_var()?
Regards,
Michael Wang
On 11/23/2015 10:36 AM, Borislav Petkov wrote:
> Hey,
>
> so I keep getting those since recently:
>
> net/netfilter/nfnetlink_queue.c:519:19: warning: ‘nfnl_
On 11/23/2015 10:54 AM, Borislav Petkov wrote:
> Hi Michael,
>
> On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote:
>> Why not just initialized it as NULL, or mark it as uninitialized_var()?
>
> because I'd like us to save us the redundant NULL initializati
On 11/23/2015 11:32 AM, Borislav Petkov wrote:
> On Mon, Nov 23, 2015 at 11:20:18AM +0100, Michael Wang wrote:
>> Who want to do that would take responsibility to make an else branch at
>> that time, but reserve the branch at this moment sounds unnecessary, and
>> no
e'd like to ask are we still planning to have this fix
in upstream?
Regards,
Michael Wang
On 07/11/2016 04:10 PM, Lars Ellenberg wrote:
> For a long time, generic_make_request() converts recursion into
> iteration by queuing recursive arguments on current->bio_list.
>
> This
t' this can no longer happen.
Signed-off-by: Michael Wang
---
block/blk-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 43b7d06..91223b2 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2619,8 +2619,10 @@ bool blk_u
Hi, Neil
On 04/03/2017 11:25 PM, NeilBrown wrote:
> On Mon, Apr 03 2017, Michael Wang wrote:
>
>> blk_attempt_plug_merge() try to merge bio into request and chain them
>> by 'bi_next', while after the bio is done inside request, we forgot to
>> reset the 'b
On 04/04/2017 11:37 AM, NeilBrown wrote:
> On Tue, Apr 04 2017, Michael Wang wrote:
[snip]
>>>
>>> If sync_request_write() is using a bio that has already been used, it
>>> should call bio_reset() and fill in the details again.
>>> However I don't
On 04/04/2017 12:23 PM, Michael Wang wrote:
[snip]
>> add something like
>> if (wbio->bi_next)
>> printk("bi_next!= NULL i=%d read_disk=%d bi_end_io=%pf\n",
>> i, r1_bio->read_disk, wbio->bi_end_io);
>>
>> that might help narr
On 04/04/2017 02:24 PM, Michael Wang wrote:
> On 04/04/2017 12:23 PM, Michael Wang wrote:
> [snip]
>>> add something like
>>> if (wbio->bi_next)
>>> printk("bi_next!= NULL i=%d read_disk=%d bi_end_io=%pf\n",
>>> i, r1_bi
7;t reset the 'bi_next' after bio
is done inside request, we hit the BUG like that.
This patch simply reset the bi_next before we reuse it.
Signed-off-by: Michael Wang
---
drivers/md/raid1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/
gt; sync_request_write() to submit a write request to it.
Make sense, while still have concerns regarding the design:
* in this case since the read_disk already abandoned, is it fine to
keep r1_bio->read_disk recording the faulty device index?
* we assign the 'end_sync_write' to
Oops: 0003 [#1] SMP
[snip]
Call Trace:
[] ? sysfs_kf_read+0x80/0xb0
[] kernfs_fop_read+0xab/0x160
[] __vfs_read+0x28/0xd0
[] vfs_read+0x86/0x130
[] SyS_read+0x46/0xa0
[] entry_SYSCALL_64_fastpath+0x12/0x6a
Simply return 0 in case of error solved the problem.
Signed-off-by: Michael
We found the upstream fix, sorry for the noise...
Regards,
Michael Wang
On 04/11/2017 12:14 PM, Michael Wang wrote:
>
> sysfs_kf_read() expect the show() callback return the dumped
> length, while rdev_attr_show() can return the error which lead
> into overflow:
>
> BUG
there any plan on backport it in future?
Regards,
Michael Wang
Hi, Joel
On 07/29/2017 10:13 AM, Joel Fernandes wrote:
> +Michael Wang on his current email address (old one bounced). (my
> reply was to Mike Galbraith but I also meant to CC Michael Wang for
> the discussion). Thanks
Just back from vacation and saw this long long discussion...
I t
isk), disk->minors, NULL,
exact_match, exact_lock, disk);
to prevent the following NULL pointer dereference and hard lockup?
Regards,
Michael Wang
Sep 29 09:53:28 st401b-3 systemd[1]: Starting Update UTMP about System Runlevel
Changes...
Sep 29 09:53:28 st401b-3 ntpd[4970]: Listen and drop on 1 v6wi
701 - 800 of 812 matches
Mail list logo
