Re: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-25 Thread Michal Marek
Dne 23.11.2016 v 20:40 Alexey Brodkin napsal(a): >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index 19cce226d1a8..44ef35d33956 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -123,9 +123,9 @@ libs-y += arch/arc/lib/ $(LIBGCC) >> boot:=

Re: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-25 Thread Michal Marek
Dne 23.11.2016 v 20:40 Alexey Brodkin napsal(a): >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index 19cce226d1a8..44ef35d33956 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -123,9 +123,9 @@ libs-y += arch/arc/lib/ $(LIBGCC) >> boot:=

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
Dne 24.11.2016 v 11:03 Nicholas Piggin napsal(a): > On Thu, 24 Nov 2016 10:32:12 +0100 > Michal Marek <mma...@suse.com> wrote: > >> On 2016-11-24 08:53, Nicholas Piggin wrote: >>> On Thu, 24 Nov 2016 08:36:39 +0100 >>> Greg Kroah-Hartman <gre...@linuxfoun

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
Dne 24.11.2016 v 11:03 Nicholas Piggin napsal(a): > On Thu, 24 Nov 2016 10:32:12 +0100 > Michal Marek wrote: > >> On 2016-11-24 08:53, Nicholas Piggin wrote: >>> On Thu, 24 Nov 2016 08:36:39 +0100 >>> Greg Kroah-Hartman wrote: >>> >>>&

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
On 2016-11-24 08:53, Nicholas Piggin wrote: > On Thu, 24 Nov 2016 08:36:39 +0100 > Greg Kroah-Hartman wrote: > >> On Thu, Nov 24, 2016 at 06:20:26PM +1100, Nicholas Piggin wrote: >>> But still, modversions is pretty complicated for what it gives us. It sends >>>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
On 2016-11-24 08:53, Nicholas Piggin wrote: > On Thu, 24 Nov 2016 08:36:39 +0100 > Greg Kroah-Hartman wrote: > >> On Thu, Nov 24, 2016 at 06:20:26PM +1100, Nicholas Piggin wrote: >>> But still, modversions is pretty complicated for what it gives us. It sends >>> preprocessed C into a C parser

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
the offending commit that broke > modversions > for essentially _everyone_ who does more complex modular builds on x86 ended > up > upstream: > > commit 4efca4ed05cbdfd13ec3e8cb623fb77d6e4ab187 > Author: Nicholas Piggin <npig...@gmail.com> > AuthorDate: Tue Nov

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
sm-prototypes.h >> create mode 100644 include/asm-generic/asm-prototypes.h > > Michal, I'm quite unhappy about how the offending commit that broke > modversions > for essentially _everyone_ who does more complex modular builds on x86 ended > up > upstream: > > com

[PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
<catalin.mari...@arm.com> Cc: Will Deacon <will.dea...@arm.com> Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek <mma...@suse.com> --- arch/arm64/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/Makefile b/arch/ar

[PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm64/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 3635b8662724..80b6866bcacb 100644 --- a/arch/arm64/Makefile

[PATCH 5/6] unicore32: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
t;g...@mprc.pku.edu.cn> Signed-off-by: Michal Marek <mma...@suse.com> --- arch/unicore32/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/Makefile b/arch/unicore32/Makefile index b6f5c4c1eaf9..98a5ca43ae87 100644 --- a/arch/unicore32/Makefil

[PATCH 5/6] unicore32: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Signed-off-by: Michal Marek --- arch/unicore32/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/Makefile b/arch/unicore32/Makefile index b6f5c4c1eaf9..98a5ca43ae87 100644 --- a/arch/unicore32/Makefile +++ b/arch/unicore32/Makefile @@ -43,9 +43,9 @@ boot

[PATCH 2/6] arm: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
<li...@armlinux.org.uk> Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek <mma...@suse.com> --- arch/arm/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 6be9ee148b78..f3fa2cafca15 100644 --

[PATCH 4/6] sh: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
<ys...@users.sourceforge.jp> Cc: Rich Felker <dal...@libc.org> Cc: linux...@vger.kernel.org Signed-off-by: Michal Marek <mma...@suse.com> --- arch/sh/Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sh/Makefile b/arch/sh/Makefile

[PATCH 2/6] arm: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 6be9ee148b78..f3fa2cafca15 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile

[PATCH 4/6] sh: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Cc: Rich Felker Cc: linux...@vger.kernel.org Signed-off-by: Michal Marek --- arch/sh/Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sh/Makefile b/arch/sh/Makefile index 336f33a419d9..280bbff12102 100644 --- a/arch/sh/Makefile +++ b/arch/sh/Makefile

[PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
<vgu...@synopsys.com> Cc: linux-snps-...@lists.infradead.org Signed-off-by: Michal Marek <mma...@suse.com> --- arch/arc/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 19cce226d1a8..44ef35d33956 100644 --

[PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Cc: linux-snps-...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arc/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 19cce226d1a8..44ef35d33956 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -123,9

[PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-22 Thread Michal Marek
The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so the workaround is no longer needed. Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/package/builddeb | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/package/builddeb b/s

[PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-22 Thread Michal Marek
The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so the workaround is no longer needed. Signed-off-by: Michal Marek --- scripts/package/builddeb | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index

[GIT PULL] kbuild post v4.9-rc1 fixes

2016-11-18 Thread Michal Marek
Hi Linus, Here are some regression fixes for kbuild: - modversion support for exported asm symbols (Nick Piggin). The affected architectures need separate patches adding asm-prototypes.h. - fix rebuilds of lib-ksyms.o (Nick Piggin) - -fno-PIE builds (Sebastian Siewior and Borislav Petkov). This

[GIT PULL] kbuild post v4.9-rc1 fixes

2016-11-18 Thread Michal Marek
Hi Linus, Here are some regression fixes for kbuild: - modversion support for exported asm symbols (Nick Piggin). The affected architectures need separate patches adding asm-prototypes.h. - fix rebuilds of lib-ksyms.o (Nick Piggin) - -fno-PIE builds (Sebastian Siewior and Borislav Petkov). This

Re: [PATCH -v1.1] kbuild: Steal gcc's pie from the very beginning

2016-11-15 Thread Michal Marek
ince gcc v3.4 and our lowest supported gcc version is 3.2 right now. > > Signed-off-by: Borislav Petkov <b...@suse.de> > Cc: sta...@vger.kernel.org > Cc: Ben Hutchings <b...@decadent.org.uk> > Cc: Michal Marek <mma...@suse.com> > Cc: Sebastian Andrzej Siewior <bige...@linutronix.de> Thanks, applied to kbuild.git#rc-fixes. Michal

Re: [PATCH -v1.1] kbuild: Steal gcc's pie from the very beginning

2016-11-15 Thread Michal Marek
ported gcc version is 3.2 right now. > > Signed-off-by: Borislav Petkov > Cc: sta...@vger.kernel.org > Cc: Ben Hutchings > Cc: Michal Marek > Cc: Sebastian Andrzej Siewior Thanks, applied to kbuild.git#rc-fixes. Michal

Re: Kbuild: CC= handling broken for tools/

2016-11-11 Thread Michal Marek
On 2016-11-11 12:23, Jiri Slaby wrote: > Hi, > > I am trying a new gcc with new warnings enabled: > > make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o > EXTRA_CFLAGS='-Wimplicit-fallthrough=3' Note that EXTRA_CFLAGS is a makefile variable read by both kbuild and tools/build apparently. > > But

Re: Kbuild: CC= handling broken for tools/

2016-11-11 Thread Michal Marek
On 2016-11-11 12:23, Jiri Slaby wrote: > Hi, > > I am trying a new gcc with new warnings enabled: > > make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o > EXTRA_CFLAGS='-Wimplicit-fallthrough=3' Note that EXTRA_CFLAGS is a makefile variable read by both kbuild and tools/build apparently. > > But

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-09 Thread Michal Marek
Dne 9.11.2016 v 07:10 Ingo Molnar napsal(a): > > * Michal Marek <mma...@suse.com> wrote: > >> On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: >>> Debian started to build the gcc with -fPIE by default so the kernel >>&g

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-09 Thread Michal Marek
Dne 9.11.2016 v 07:10 Ingo Molnar napsal(a): > > * Michal Marek wrote: > >> On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: >>> Debian started to build the gcc with -fPIE by default so the kernel >>> build ends before it starts proper

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-08 Thread Michal Marek
On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: > Debian started to build the gcc with -fPIE by default so the kernel > build ends before it starts properly with: > |kernel/bounds.c:1:0: error: code model kernel does not support PIC mode > > Also add to KBUILD_AFLAGS

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-08 Thread Michal Marek
On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: > Debian started to build the gcc with -fPIE by default so the kernel > build ends before it starts properly with: > |kernel/bounds.c:1:0: error: code model kernel does not support PIC mode > > Also add to KBUILD_AFLAGS

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-04 Thread Michal Marek
On 2016-11-03 20:48, SF Markus Elfring wrote: >> You could define an xprintf() macro that checks if the return value >> is < 0 and simply calls perror() and exit(1) in such case. > > Does such a macro belong to any general header file from the Linux > software library? No. Michal

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-04 Thread Michal Marek
On 2016-11-03 20:48, SF Markus Elfring wrote: >> You could define an xprintf() macro that checks if the return value >> is < 0 and simply calls perror() and exit(1) in such case. > > Does such a macro belong to any general header file from the Linux > software library? No. Michal

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:46 SF Markus Elfring napsal(a): >> I like the code as is. > > Do you really prefer to ignore important return values in the discussed > function? You could define an xprintf() macro that checks if the return value is < 0 and simply calls perror() and exit(1) in such case.

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:46 SF Markus Elfring napsal(a): >> I like the code as is. > > Do you really prefer to ignore important return values in the discussed > function? You could define an xprintf() macro that checks if the return value is < 0 and simply calls perror() and exit(1) in such case.

Re: [PATCH] kbuild: add %/built-in.o target in top Makefile

2016-11-01 Thread Michal Marek
On 2016-10-24 14:45, Wei Yang wrote: > diff --git a/Makefile b/Makefile > index addb235..546998e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1627,6 +1627,8 @@ endif > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > %.symtypes: %.c prepare scripts FORCE > $(Q)$(MAKE)

Re: [PATCH] kbuild: add %/built-in.o target in top Makefile

2016-11-01 Thread Michal Marek
On 2016-10-24 14:45, Wei Yang wrote: > diff --git a/Makefile b/Makefile > index addb235..546998e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1627,6 +1627,8 @@ endif > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > %.symtypes: %.c prepare scripts FORCE > $(Q)$(MAKE)

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-11-01 Thread Michal Marek
On 2016-10-18 03:34, Nicholas Piggin wrote: > Hi Adam, > > Thanks, this is looking good. powerpc will be able to use the generic > header. > > On Tue, 18 Oct 2016 02:16:26 +0200 > Adam Borowski wrote: > >> On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote:

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-11-01 Thread Michal Marek
On 2016-10-18 03:34, Nicholas Piggin wrote: > Hi Adam, > > Thanks, this is looking good. powerpc will be able to use the generic > header. > > On Tue, 18 Oct 2016 02:16:26 +0200 > Adam Borowski wrote: > >> On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote: +#include

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Michal Marek
Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the 'extern' declarations out

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Michal Marek
Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the 'extern' declarations out

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-19 Thread Michal Marek
Dne 18.10.2016 v 03:34 Nicholas Piggin napsal(a): > We should probably just bring all these arch patches through the > kbuild tree. > > I'm sorry for the breakage: I didn't realize it broke the build with > some configs, otherwise I would have given Michal a heads up before > his pull request,

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-19 Thread Michal Marek
Dne 18.10.2016 v 03:34 Nicholas Piggin napsal(a): > We should probably just bring all these arch patches through the > kbuild tree. > > I'm sorry for the breakage: I didn't realize it broke the build with > some configs, otherwise I would have given Michal a heads up before > his pull request,

[GIT PULL] kbuild misc changes for 4.9-rc1

2016-10-14 Thread Michal Marek
Hi Linus, just a few patches on the kbuild.git#misc branch this time: - New Coccinelle patch by Nicholas Mc Guire - Existing patch fixes by Julia Lawall - Minor comment fix by Markus Elfring The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1

[GIT PULL] kbuild misc changes for 4.9-rc1

2016-10-14 Thread Michal Marek
Hi Linus, just a few patches on the kbuild.git#misc branch this time: - New Coccinelle patch by Nicholas Mc Guire - Existing patch fixes by Julia Lawall - Minor comment fix by Markus Elfring The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1

[GIT PULL] kbuild changes for v4.9-rc1

2016-10-14 Thread Michal Marek
to definitions sparc: move exports to definitions [sparc] unify 32bit and 64bit string.h sparc32: debride memcpy.S a bit ia64: move exports to definitions Alexey Dobriyan (1): fixdep: faster CONFIG_ search Michal Marek (2): kbuild: Regenerate genksyms lexer

[GIT PULL] kbuild changes for v4.9-rc1

2016-10-14 Thread Michal Marek
to definitions sparc: move exports to definitions [sparc] unify 32bit and 64bit string.h sparc32: debride memcpy.S a bit ia64: move exports to definitions Alexey Dobriyan (1): fixdep: faster CONFIG_ search Michal Marek (2): kbuild: Regenerate genksyms lexer

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 11.10.2016 v 15:10 Michal Marek napsal(a): > Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): >> Hi all, >> >> On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot <xiaolong...@intel.com> >> wrote: >>> >>> FYI, we noticed the following c

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 11.10.2016 v 15:10 Michal Marek napsal(a): > Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): >> Hi all, >> >> On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot >> wrote: >>> >>> FYI, we noticed the following commit: >>> >>

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): > Hi all, > > On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot > wrote: >> >> FYI, we noticed the following commit: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> commit

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): > Hi all, > > On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot > wrote: >> >> FYI, we noticed the following commit: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> commit

Re: [PATCH] Coccinelle: flag conditions with no effect

2016-10-11 Thread Michal Marek
On Sat, Oct 08, 2016 at 05:51:45PM +0200, Nicholas Mc Guire wrote: > Report code constructs where the if and else branch are functionally > identical. In cases where this is intended it really should be > documented - most reported cases probably are bugs. > > Signed-off-by: Nicholas Mc Guire

Re: [PATCH] Coccinelle: flag conditions with no effect

2016-10-11 Thread Michal Marek
On Sat, Oct 08, 2016 at 05:51:45PM +0200, Nicholas Mc Guire wrote: > Report code constructs where the if and else branch are functionally > identical. In cases where this is intended it really should be > documented - most reported cases probably are bugs. > > Signed-off-by: Nicholas Mc Guire

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

2016-10-11 Thread Michal Marek
On Fri, Oct 07, 2016 at 08:30:48PM +0200, Julia Lawall wrote: > > > On Fri, 7 Oct 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Fri, 7 Oct 2016 16:06:15 +0200 > > > > Use the current name (in a comment at the beginning of this script) for >

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

2016-10-11 Thread Michal Marek
On Fri, Oct 07, 2016 at 08:30:48PM +0200, Julia Lawall wrote: > > > On Fri, 7 Oct 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Fri, 7 Oct 2016 16:06:15 +0200 > > > > Use the current name (in a comment at the beginning of this script) for > > the file which was converted

Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case

2016-10-01 Thread Michal Marek
Dne 21.9.2016 v 17:48 Julia Lawall napsal(a): > Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so > only allow this flag in the original code. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc. Thanks, Michal

Re: [PATCH] Coccinelle: pm_runtime: ensure relevance of pm_runtime reports

2016-10-01 Thread Michal Marek
Dne 22.9.2016 v 10:28 Julia Lawall napsal(a): > pm_runtime.cocci starts with one rule that searches for a variety of > functions calls, followed by various rules that report errors. Previously, > the only connection between the first rule and the rest was to check that > the first rule had

Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case

2016-10-01 Thread Michal Marek
Dne 21.9.2016 v 17:48 Julia Lawall napsal(a): > Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so > only allow this flag in the original code. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc. Thanks, Michal

Re: [PATCH] Coccinelle: pm_runtime: ensure relevance of pm_runtime reports

2016-10-01 Thread Michal Marek
Dne 22.9.2016 v 10:28 Julia Lawall napsal(a): > pm_runtime.cocci starts with one rule that searches for a variety of > functions calls, followed by various rules that report errors. Previously, > the only connection between the first rule and the rest was to check that > the first rule had

Re: [PATCH 0/2] Moving runnable code from Documentation (last 2 patches)

2016-10-01 Thread Michal Marek
gt;>> >>> Shuah Khan (2): >>> samples: move blackfin gptimers-example from Documentation >>> Doc: update 00-INDEX files to reflect the runnable code move >>> >> >> Hi Jon and Michal, >> >> Do these patches look good to you? I

Re: [PATCH 0/2] Moving runnable code from Documentation (last 2 patches)

2016-10-01 Thread Michal Marek
an (2): >>> samples: move blackfin gptimers-example from Documentation >>> Doc: update 00-INDEX files to reflect the runnable code move >>> >> >> Hi Jon and Michal, >> >> Do these patches look good to you? I can get these into 4.9-rc1 >> with your Ack. > > Seems good to me. > > Acked-by: Jonathan Corbet Likewise, Acked-by: Michal Marek Michal

[PATCH] initramfs: Escape colons in depfile

2016-09-23 Thread Michal Marek
Special characters are problematic in depfiles, but we can fix colons easily. Reported-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/gen_initramfs_list.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

[PATCH] initramfs: Escape colons in depfile

2016-09-23 Thread Michal Marek
Special characters are problematic in depfiles, but we can fix colons easily. Reported-by: Florian Fainelli Signed-off-by: Michal Marek --- scripts/gen_initramfs_list.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/gen_initramfs_list.sh b/scripts

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-23 Thread Michal Marek
On 2016-09-19 22:00, Florian Fainelli wrote: > On 09/13/2016 12:24 AM, Michal Marek wrote: >> On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: >>> Hi, >>> >>> I have a root filesystem embedding filenames that look like these: >>> >&g

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-23 Thread Michal Marek
On 2016-09-19 22:00, Florian Fainelli wrote: > On 09/13/2016 12:24 AM, Michal Marek wrote: >> On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: >>> Hi, >>> >>> I have a root filesystem embedding filenames that look like these: >>> >&g

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek
On 2016-09-15 08:08, Stephen Rothwell wrote: > Hi all, > > After merging the dax-misc tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages': > (___ksymtab+clear_pages+0x0): undefined reference to

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek
On 2016-09-15 08:08, Stephen Rothwell wrote: > Hi all, > > After merging the dax-misc tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages': > (___ksymtab+clear_pages+0x0): undefined reference to

Re: Build failure in -next due to 'kbuild: allow archs to select link dead code/data elimination'

2016-09-22 Thread Michal Marek
On 2016-09-14 21:48, Guenter Roeck wrote: > On Wed, Sep 14, 2016 at 12:30:04PM +1000, Nicholas Piggin wrote: >> commit 0ae28be83b4d6cd03ef5b481487d042f2b91954e >> Author: Nicholas Piggin >> Date: Wed Sep 14 12:24:03 2016 +1000 >> >> kbuild: -ffunction-sections fix for

Re: Build failure in -next due to 'kbuild: allow archs to select link dead code/data elimination'

2016-09-22 Thread Michal Marek
On 2016-09-14 21:48, Guenter Roeck wrote: > On Wed, Sep 14, 2016 at 12:30:04PM +1000, Nicholas Piggin wrote: >> commit 0ae28be83b4d6cd03ef5b481487d042f2b91954e >> Author: Nicholas Piggin >> Date: Wed Sep 14 12:24:03 2016 +1000 >> >> kbuild: -ffunction-sections fix for archs with conflicting

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-13 Thread Michal Marek
On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: > Hi, > > I have a root filesystem embedding filenames that look like these: > > /lib/data/: > > these are essentially files that can be matched against an USB > vendor/product id in an easy way. > > Now, the fun part is that

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-13 Thread Michal Marek
On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: > Hi, > > I have a root filesystem embedding filenames that look like these: > > /lib/data/: > > these are essentially files that can be matched against an USB > vendor/product id in an easy way. > > Now, the fun part is that

Re: linux-next: manual merge of the kbuild tree with Linus' tree

2016-09-12 Thread Michal Marek
On 2016-09-12 04:53, Nicholas Piggin wrote: > Question, what is the best way to merge dependent patches? Considering > they will need a good amount of architecture testing, I think they will > have to go via arch trees. But it also does not make sense to merge these > kbuild changes upstream

Re: linux-next: manual merge of the kbuild tree with Linus' tree

2016-09-12 Thread Michal Marek
On 2016-09-12 04:53, Nicholas Piggin wrote: > Question, what is the best way to merge dependent patches? Considering > they will need a good amount of architecture testing, I think they will > have to go via arch trees. But it also does not make sense to merge these > kbuild changes upstream

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-07 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97:

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-07 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-05 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97:

[GIT PULL] make deb-pkg fix

2016-09-05 Thread Michal Marek
Hi Linus, Please pull this fix from make deb-pkg. The bug got introduced in v4.8-rc1. Thanks, Michal The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at:

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-05 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for

[GIT PULL] make deb-pkg fix

2016-09-05 Thread Michal Marek
Hi Linus, Please pull this fix from make deb-pkg. The bug got introduced in v4.8-rc1. Thanks, Michal The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at:

Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs

2016-08-26 Thread Michal Marek
On 2016-06-13 15:04, Arnd Bergmann wrote: > The genksyms helper in the kernel cannot parse a type definition > like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS > helper, causing the following EXPORT_SYMBOL() statement to be ignored > when computing the crcs, and triggering a

Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs

2016-08-26 Thread Michal Marek
On 2016-06-13 15:04, Arnd Bergmann wrote: > The genksyms helper in the kernel cannot parse a type definition > like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS > helper, causing the following EXPORT_SYMBOL() statement to be ignored > when computing the crcs, and triggering a

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-25 Thread Michal Marek
On 2016-08-25 09:43, Christoph Hellwig wrote: > The idea seems useful, but I reallt don't like the 'reverse-engineering' > approach. > > If we want to this properly from the ground up we should just split out > our CONFIG_ SYMBOLS into > > MODULE_* - builds exactly one module (tristate, or maybe

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-25 Thread Michal Marek
On 2016-08-25 09:43, Christoph Hellwig wrote: > The idea seems useful, but I reallt don't like the 'reverse-engineering' > approach. > > If we want to this properly from the ground up we should just split out > our CONFIG_ SYMBOLS into > > MODULE_* - builds exactly one module (tristate, or maybe

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-24 Thread Michal Marek
On 2016-08-23 23:32, Luis R. Rodriguez wrote: > On Fri, Aug 19, 2016 at 11:07:36AM +0200, Michal Marek wrote: >> On 2016-08-18 19:55, Luis R. Rodriguez wrote: >>> On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: >>> >>>> This patchset imple

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-24 Thread Michal Marek
On 2016-08-23 23:32, Luis R. Rodriguez wrote: > On Fri, Aug 19, 2016 at 11:07:36AM +0200, Michal Marek wrote: >> On 2016-08-18 19:55, Luis R. Rodriguez wrote: >>> On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: >>> >>>> This patchset imple

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-19 Thread Michal Marek
On 2016-08-18 19:55, Luis R. Rodriguez wrote: > On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: > >> This patchset implements dynamic pegging of kconfig symbol >> into driver modinfo section > > First a little bit of motivation here helps, so let me try to > help fill in some

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-19 Thread Michal Marek
On 2016-08-18 19:55, Luis R. Rodriguez wrote: > On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: > >> This patchset implements dynamic pegging of kconfig symbol >> into driver modinfo section > > First a little bit of motivation here helps, so let me try to > help fill in some

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-19 Thread Michal Marek
On 2016-08-19 07:09, Stephen Rothwell wrote: > Hi Nick, > > On Fri, 19 Aug 2016 13:38:54 +1000 Stephen Rothwell <s...@canb.auug.org.au> > wrote: >> >> On Thu, 18 Aug 2016 11:09:48 +1000 Nicholas Piggin <npig...@gmail.com> wrote: >>> >>> On

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-19 Thread Michal Marek
On 2016-08-19 07:09, Stephen Rothwell wrote: > Hi Nick, > > On Fri, 19 Aug 2016 13:38:54 +1000 Stephen Rothwell > wrote: >> >> On Thu, 18 Aug 2016 11:09:48 +1000 Nicholas Piggin wrote: >>> >>> On Wed, 17 Aug 2016 14:59:59 +0200 >>> Michal Mar

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-17 Thread Michal Marek
On 2016-08-17 03:44, Stephen Rothwell wrote: > Hi Michal, > > After merging the kbuild tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warnings: > > WARNING: 25 bad relocations > c0cf2570 R_PPC64_ADDR64__crc___arch_hweight16 [...] > Introduced by commit > >

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-17 Thread Michal Marek
On 2016-08-17 03:44, Stephen Rothwell wrote: > Hi Michal, > > After merging the kbuild tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warnings: > > WARNING: 25 bad relocations > c0cf2570 R_PPC64_ADDR64__crc___arch_hweight16 [...] > Introduced by commit > >

Re: [PATCH] kbuild: do not add srctree to sysroot relative includes

2016-08-16 Thread Michal Marek
On 2016-08-16 13:40, Lars Persson wrote: > We need to filter out also -I=/path to allow sysroot relative > include paths in the makefiles of external modules. > > Signed-off-by: Lars Persson > --- > scripts/Kbuild.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] kbuild: do not add srctree to sysroot relative includes

2016-08-16 Thread Michal Marek
On 2016-08-16 13:40, Lars Persson wrote: > We need to filter out also -I=/path to allow sysroot relative > include paths in the makefiles of external modules. > > Signed-off-by: Lars Persson > --- > scripts/Kbuild.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] builddeb: Skip gcc-plugins when not configured

2016-08-16 Thread Michal Marek
Dne 15.8.2016 v 19:36 Kees Cook napsal(a): > When attempting to build a Debian kernel package, the "scripts/gcc-plugins" > directory does not exist in the output tree unless CONFIG_GCC_PLUGINS=y. > To avoid errors when not defined, this wraps the failing "find" in a config > test. > >

Re: [PATCH] builddeb: Skip gcc-plugins when not configured

2016-08-16 Thread Michal Marek
Dne 15.8.2016 v 19:36 Kees Cook napsal(a): > When attempting to build a Debian kernel package, the "scripts/gcc-plugins" > directory does not exist in the output tree unless CONFIG_GCC_PLUGINS=y. > To avoid errors when not defined, this wraps the failing "find" in a config > test. > >

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-15 Thread Michal Marek
Dne 16.8.2016 v 07:48 Michal Marek napsal(a): > Dne 2.8.2016 v 16:01 Michal Marek napsal(a): >> On 2016-02-03 22:19, Al Viro wrote: >>> Shortlog: >>> Al Viro (13): >>> [kbuild] handle exports in lib-y objects reliably >>> EXPORT_SYMBOL()

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-15 Thread Michal Marek
Dne 16.8.2016 v 07:48 Michal Marek napsal(a): > Dne 2.8.2016 v 16:01 Michal Marek napsal(a): >> On 2016-02-03 22:19, Al Viro wrote: >>> Shortlog: >>> Al Viro (13): >>> [kbuild] handle exports in lib-y objects reliably >>> EXPORT_SYMBOL()

<    1   2   3   4   5   6   7   8   9   10   >