Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-15 Thread Michal Marek
Dne 2.8.2016 v 16:01 Michal Marek napsal(a): > On 2016-02-03 22:19, Al Viro wrote: >> Shortlog: >> Al Viro (13): >> [kbuild] handle exports in lib-y objects reliably >> EXPORT_SYMBOL() for asm >> x86: move exports to actual definitions >&

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-15 Thread Michal Marek
Dne 2.8.2016 v 16:01 Michal Marek napsal(a): > On 2016-02-03 22:19, Al Viro wrote: >> Shortlog: >> Al Viro (13): >> [kbuild] handle exports in lib-y objects reliably >> EXPORT_SYMBOL() for asm >> x86: move exports to actual definitions >&

Re: Building a subdirectory ignores parent subdir-ccflags

2016-08-15 Thread Michal Marek
Dne 15.8.2016 v 23:29 Joe Perches napsal(a): > On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote: >> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote: >>> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: Start to rationalize include paths in source code files. >> []

Re: Building a subdirectory ignores parent subdir-ccflags

2016-08-15 Thread Michal Marek
Dne 15.8.2016 v 23:29 Joe Perches napsal(a): > On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote: >> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote: >>> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: Start to rationalize include paths in source code files. >> []

Re: [PATCH] scripts: Translate profile2linkerlist.

2016-08-07 Thread Michal Marek
Dne 7.8.2016 v 20:33 Jorge Natz napsal(a): > -while (<>) { > - my $line = $_; > - > - $_ =~ /\W*[0-9]+\W*([a-zA-Z\_0-9]+)\W*[0-9]+/; > - > - print "*(.text.$1)\n" [...] > + LINE=$( echo $LINE | sed -e s"/[0-9.][0-9.]*//" -e s"/[0-9.][0-9.]*$//" > | xargs) > + case $LINE in

Re: [PATCH] scripts: Translate profile2linkerlist.

2016-08-07 Thread Michal Marek
Dne 7.8.2016 v 20:33 Jorge Natz napsal(a): > -while (<>) { > - my $line = $_; > - > - $_ =~ /\W*[0-9]+\W*([a-zA-Z\_0-9]+)\W*[0-9]+/; > - > - print "*(.text.$1)\n" [...] > + LINE=$( echo $LINE | sed -e s"/[0-9.][0-9.]*//" -e s"/[0-9.][0-9.]*$//" > | xargs) > + case $LINE in

Re: [GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Dne 2.8.2016 v 22:55 Kees Cook napsal(a): > On Tue, Aug 2, 2016 at 1:41 PM, Linus Torvalds > <torva...@linux-foundation.org> wrote: >> On Tue, Aug 2, 2016 at 3:00 PM, Michal Marek <mma...@suse.com> wrote: >>> >>> please merge these kbuild changes for v4.8-

Re: [GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Dne 2.8.2016 v 22:55 Kees Cook napsal(a): > On Tue, Aug 2, 2016 at 1:41 PM, Linus Torvalds > wrote: >> On Tue, Aug 2, 2016 at 3:00 PM, Michal Marek wrote: >>> >>> please merge these kbuild changes for v4.8-rc1: >> >> Merged. However, there were two sli

[GIT PULL] kbuild misc changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, these is the non-critical part of kbuild for v4.8-rc1: - coccicheck script improvements by Luis R. Rodriguez and Deepa Dinamani - new coccinelle patches by Yann Droneaud and Vaishali Thakkar - debian packaging fixes by Wilfried Klaebe, Henning Schild and Marcin Mielniczuk. Thanks,

[GIT PULL] kbuild misc changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, these is the non-critical part of kbuild for v4.8-rc1: - coccicheck script improvements by Luis R. Rodriguez and Deepa Dinamani - new coccinelle patches by Yann Droneaud and Vaishali Thakkar - debian packaging fixes by Wilfried Klaebe, Henning Schild and Marcin Mielniczuk. Thanks,

[GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, please merge these kbuild changes for v4.8-rc1: - GCC plugin support by Emese Revfy from grsecurity, with a fixup from Kees Cook. The plugins are meant to be used for static analysis of the kernel code. Two plugins are provided already. - Reduction of the gcc commandline by Arnd

[GIT PULL] kbuild changes for v4.8-rc1

2016-08-02 Thread Michal Marek
Hi Linus, please merge these kbuild changes for v4.8-rc1: - GCC plugin support by Emese Revfy from grsecurity, with a fixup from Kees Cook. The plugins are meant to be used for static analysis of the kernel code. Two plugins are provided already. - Reduction of the gcc commandline by Arnd

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-02 Thread Michal Marek
On 2016-02-03 22:19, Al Viro wrote: > If everyone (including kbuild folks) is OK with the arch-independent parts of > this series, I'd like to put the first two commits into never-rebased branch > so that individual architecture trees could pull that and apply the > corresponding arch-dependent

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-02 Thread Michal Marek
On 2016-02-03 22:19, Al Viro wrote: > If everyone (including kbuild folks) is OK with the arch-independent parts of > this series, I'd like to put the first two commits into never-rebased branch > so that individual architecture trees could pull that and apply the > corresponding arch-dependent

Re: [PATCH v2] Coccinelle: Script to replace allocate and memset with zalloc functions

2016-07-28 Thread Michal Marek
On 2016-07-28 10:29, Amitoj Kaur Chawla wrote: > This script finds instances of allocate and memset which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > Changes in v2: > -Modified commit message

Re: [PATCH v2] Coccinelle: Script to replace allocate and memset with zalloc functions

2016-07-28 Thread Michal Marek
On 2016-07-28 10:29, Amitoj Kaur Chawla wrote: > This script finds instances of allocate and memset which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > Changes in v2: > -Modified commit message and subject There is

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-27 Thread Michal Marek
On 2016-07-27 01:09, Kees Cook wrote: > On Tue, Jul 26, 2016 at 3:19 PM, Michal Marek <mma...@suse.cz> wrote: >> Dne 14.6.2016 v 18:39 Kees Cook napsal(a): >>> On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell <s...@canb.auug.org.au> >>> wrote: >>>

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-27 Thread Michal Marek
On 2016-07-27 01:09, Kees Cook wrote: > On Tue, Jul 26, 2016 at 3:19 PM, Michal Marek wrote: >> Dne 14.6.2016 v 18:39 Kees Cook napsal(a): >>> On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell >>> wrote: >>>> Hi Michal, >>>> >>

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Michal Marek
Dne 14.6.2016 v 18:39 Kees Cook napsal(a): > On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell <s...@canb.auug.org.au> > wrote: >> Hi Michal, >> >> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek <mma...@suse.cz> wrote: >>> >>> I won't

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Michal Marek
Dne 14.6.2016 v 18:39 Kees Cook napsal(a): > On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell > wrote: >> Hi Michal, >> >> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote: >>> >>> I won't :). Kees, are you going to keep the patch in your

Re: [PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 23:26 Kees Cook napsal(a): > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown flag. This has

Re: [PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 23:26 Kees Cook napsal(a): > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown flag. This has

Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under

Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under ifndef force) > >

Re: [RESEND][PATCH] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
On Tue, Jul 12, 2016 at 03:30:43PM -0700, Kees Cook wrote: > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown

Re: [RESEND][PATCH] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
On Tue, Jul 12, 2016 at 03:30:43PM -0700, Kees Cook wrote: > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown

Re: [PATCH] Coccinelle: Script to replace allocate and memcpy with zalloc functions

2016-07-26 Thread Michal Marek
Dne 23.7.2016 v 23:00 Amitoj Kaur Chawla napsal(a): > This script finds instances of allocate and memcpy which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > scripts/coccinelle/api/zalloc.cocci | 556

Re: [PATCH] Coccinelle: Script to replace allocate and memcpy with zalloc functions

2016-07-26 Thread Michal Marek
Dne 23.7.2016 v 23:00 Amitoj Kaur Chawla napsal(a): > This script finds instances of allocate and memcpy which can be > replaced with a direct call to zalloc equivalent of a function. > > Signed-off-by: Amitoj Kaur Chawla > --- > scripts/coccinelle/api/zalloc.cocci | 556 >

Re: [PATCHv2] builddeb: fix file permissions before packaging

2016-07-26 Thread Michal Marek
Dne 22.7.2016 v 14:46 Henning Schild napsal(a): > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting

Re: [PATCHv2] builddeb: fix file permissions before packaging

2016-07-26 Thread Michal Marek
Dne 22.7.2016 v 14:46 Henning Schild napsal(a): > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting

Re: [PATCH] builddeb: fix file permissions before packaging

2016-07-22 Thread Michal Marek
On 2016-07-07 16:50, Henning Schild wrote: > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting

Re: [PATCH] builddeb: fix file permissions before packaging

2016-07-22 Thread Michal Marek
On 2016-07-07 16:50, Henning Schild wrote: > Builddep is not very explicit about file permissions. Actually the file > permissions in the package are largely influenced by the umask of the > user cloning the git and building the package. If that umask does not > set go+r the resulting

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

2016-07-22 Thread Michal Marek
ze_t instead. >> >> Note: >> >> Another way to fix the problem is to change the type of >> kexec_purgatory_size to be 'int' as there's this check in code: >> (kexec_purgatory_size <= 0) >> >> Signed-off-by: Michael Tautschnig <tauts...@amazon.c

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

2016-07-22 Thread Michal Marek
ze_t instead. >> >> Note: >> >> Another way to fix the problem is to change the type of >> kexec_purgatory_size to be 'int' as there's this check in code: >> (kexec_purgatory_size <= 0) >> >> Signed-off-by: Michael Tautschnig >> Cc: Michal Marek >> Cc: Vivek Goyal [...] > Acked-by: Dave Young Applied to kbuild.git#kbuild. Michal

Re: [PATCH] kbuild: make samples depend on headers_install

2016-07-22 Thread Michal Marek
On 2016-07-04 16:39, Arnd Bergmann wrote: > Olof's build test setup keeps failing to compile arm64 kernels > because of a toolchain that uses outdated kernel headers: > > /work/build/batch/samples/seccomp/bpf-fancy.c:13:27: fatal error: > linux/seccomp.h: No such file or directory > > This is

Re: [PATCH] kbuild: make samples depend on headers_install

2016-07-22 Thread Michal Marek
On 2016-07-04 16:39, Arnd Bergmann wrote: > Olof's build test setup keeps failing to compile arm64 kernels > because of a toolchain that uses outdated kernel headers: > > /work/build/batch/samples/seccomp/bpf-fancy.c:13:27: fatal error: > linux/seccomp.h: No such file or directory > > This is

Re: [PATCH 2/2] kbuild: add shell cache

2016-07-22 Thread Michal Marek
On 2016-06-27 20:28, Rabin Vincent wrote: > Running make results in over 40 invocations of the compiler just during > processing of the Makefile, before any actual rules are run. > > To reduce this overhead, cache the results of $(shell) calls to the > compiler. How do you detect when the

Re: [PATCH 2/2] kbuild: add shell cache

2016-07-22 Thread Michal Marek
On 2016-06-27 20:28, Rabin Vincent wrote: > Running make results in over 40 invocations of the compiler just during > processing of the Makefile, before any actual rules are run. > > To reduce this overhead, cache the results of $(shell) calls to the > compiler. How do you detect when the

Re: [PATCH v4 0/9] coccicheck: modernize

2016-07-22 Thread Michal Marek
On 2016-07-13 23:45, Luis R. Rodriguez wrote: > On Wed, Jun 29, 2016 at 03:14:50PM -0700, Luis R. Rodriguez wrote: >> There were quite a bit of comments from the v3 series [0], since there >> was quite a bit of review needed for some other changes I've had discussions >> with Nicolas and Julia

Re: [PATCH v4 0/9] coccicheck: modernize

2016-07-22 Thread Michal Marek
On 2016-07-13 23:45, Luis R. Rodriguez wrote: > On Wed, Jun 29, 2016 at 03:14:50PM -0700, Luis R. Rodriguez wrote: >> There were quite a bit of comments from the v3 series [0], since there >> was quite a bit of review needed for some other changes I've had discussions >> with Nicolas and Julia

Re: [REPOST 2, PATCH] builddeb: really include objtool binary in headers package

2016-07-19 Thread Michal Marek
On Tue, Jun 28, 2016 at 12:21:33PM +, Wilfried Klaebe wrote: > [added linux-kbu...@vger.kernel.org to Cc:, added Fixes:] > > On May 4th, Bjørn Mork provided patch > 697bbc7b832048d3a679cd55caf2268a325efbe0 to include objtool binaries in > the headers package. However, that one only works if

Re: [REPOST 2, PATCH] builddeb: really include objtool binary in headers package

2016-07-19 Thread Michal Marek
On Tue, Jun 28, 2016 at 12:21:33PM +, Wilfried Klaebe wrote: > [added linux-kbu...@vger.kernel.org to Cc:, added Fixes:] > > On May 4th, Bjørn Mork provided patch > 697bbc7b832048d3a679cd55caf2268a325efbe0 to include objtool binaries in > the headers package. However, that one only works if

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-18 Thread Michal Marek
On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > When building with separate object directories and driver specific > Makefiles that add additional header include paths, Kbuild adjusts > the gcc flags so that we include both the directory in the source > tree and in the object

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-18 Thread Michal Marek
On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > When building with separate object directories and driver specific > Makefiles that add additional header include paths, Kbuild adjusts > the gcc flags so that we include both the directory in the source > tree and in the object

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-27 Thread Michal Marek
Dne 26.6.2016 v 12:43 Thorsten Leemhuis napsal(a): > On 09.06.2016 01:29, Zanoni, Paulo R wrote: >> Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu: >>> On Tue, Jun 07, 2016 at 02:10:28PM +, Zanoni, Paulo R wrote: >>> From b36fad65d61fffe4b662d4bfb1ed673c4

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-27 Thread Michal Marek
Dne 26.6.2016 v 12:43 Thorsten Leemhuis napsal(a): > On 09.06.2016 01:29, Zanoni, Paulo R wrote: >> Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu: >>> On Tue, Jun 07, 2016 at 02:10:28PM +, Zanoni, Paulo R wrote: >>> From b36fad65d61fffe4b662d4bfb1ed673c4

[GIT PULL] kbuild regression fix

2016-06-27 Thread Michal Marek
s for you to fetch changes up to b36fad65d61fffe4b662d4bfb1ed673c455a36a2: kbuild: Initialize exported variables (2016-06-07 23:39:03 +0200) -------- Michal Marek (1): kbuild: Initialize exported variables Makefile | 2 ++ 1 file

[GIT PULL] kbuild regression fix

2016-06-27 Thread Michal Marek
s for you to fetch changes up to b36fad65d61fffe4b662d4bfb1ed673c455a36a2: kbuild: Initialize exported variables (2016-06-07 23:39:03 +0200) -------- Michal Marek (1): kbuild: Initialize exported variables Makefile | 2 ++ 1 file

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-21 Thread Michal Marek
Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > >> On 2016-05-23 17:18, Julia Lawall wrote: >>> >>> >>> On Mon, 23 May 2016, Yann Droneaud wrote: >>> >>>> Since commit 3ef0e5ba4

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-21 Thread Michal Marek
Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > >> On 2016-05-23 17:18, Julia Lawall wrote: >>> >>> >>> On Mon, 23 May 2016, Yann Droneaud wrote: >>> >>>> Since commit 3ef0e5ba4

Re: [PATCH 5/5] vmlinux.lds.h: replace config_enabled() with IS_ENABLED()

2016-06-20 Thread Michal Marek
Dne 14.6.2016 v 07:58 Masahiro Yamada napsal(a): > The use of config_enabled() against config options is ambiguous. > > Now, IS_ENABLED() is implemented purely with macro expansion, so > let's replace config_enabled() with IS_ENABLED(). > > Signed-off-by: Masahiro Yamada

Re: [PATCH 5/5] vmlinux.lds.h: replace config_enabled() with IS_ENABLED()

2016-06-20 Thread Michal Marek
Dne 14.6.2016 v 07:58 Masahiro Yamada napsal(a): > The use of config_enabled() against config options is ambiguous. > > Now, IS_ENABLED() is implemented purely with macro expansion, so > let's replace config_enabled() with IS_ENABLED(). > > Signed-off-by: Masahiro Yamada I applied the whole

Re: [PATCH] coccicheck: Allow for overriding spatch flags

2016-06-20 Thread Michal Marek
On Sun, Jun 12, 2016 at 11:45:57PM +0200, Julia Lawall wrote: > > > On Sun, 12 Jun 2016, Nicolas Palix (LIG) wrote: > > > Le 12/06/16 à 21:04, Deepa Dinamani a écrit : > > > Documentation/coccinelle.txt suggests using the SPFLAGS > > > make variable to pass additional options to spatch. > > >

Re: [PATCH] coccicheck: Allow for overriding spatch flags

2016-06-20 Thread Michal Marek
On Sun, Jun 12, 2016 at 11:45:57PM +0200, Julia Lawall wrote: > > > On Sun, 12 Jun 2016, Nicolas Palix (LIG) wrote: > > > Le 12/06/16 à 21:04, Deepa Dinamani a écrit : > > > Documentation/coccinelle.txt suggests using the SPFLAGS > > > make variable to pass additional options to spatch. > > >

Re: [PATCH] kbuild: setlocalversion: print error to STDERR

2016-06-20 Thread Michal Marek
On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote: > I tried to use 'make O=...' from an unclean source tree. This triggered > the error path of setlocalversion. But by printing to STDOUT, it created > a broken localversion which then caused another (unrelated) error: > >

Re: [PATCH] kbuild: setlocalversion: print error to STDERR

2016-06-20 Thread Michal Marek
On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote: > I tried to use 'make O=...' from an unclean source tree. This triggered > the error path of setlocalversion. But by printing to STDOUT, it created > a broken localversion which then caused another (unrelated) error: > >

Re: [PATCH v3] Coccinelle: noderef: Add new rules and correct the old rule

2016-06-20 Thread Michal Marek
On 2016-05-24 10:39, Julia Lawall wrote: > Acked-by: Julia Lawall > > On Tue, 24 May 2016, Vaishali Thakkar wrote: > >> Add new rules to detect the cases where sizeof is used in >> function calls as a argument. >> >> Also, for the patch mode third rule should behave same

Re: [PATCH v3] Coccinelle: noderef: Add new rules and correct the old rule

2016-06-20 Thread Michal Marek
On 2016-05-24 10:39, Julia Lawall wrote: > Acked-by: Julia Lawall > > On Tue, 24 May 2016, Vaishali Thakkar wrote: > >> Add new rules to detect the cases where sizeof is used in >> function calls as a argument. >> >> Also, for the patch mode third rule should behave same as >> second rule with

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-20 Thread Michal Marek
On 2016-05-23 17:18, Julia Lawall wrote: > > > On Mon, 23 May 2016, Yann Droneaud wrote: > >> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), >> kfree() is no more the only function to be considered: >> kzfree() should be recognized too. >> >> In particular, kzfree() must not be called

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

2016-06-20 Thread Michal Marek
On 2016-05-23 17:18, Julia Lawall wrote: > > > On Mon, 23 May 2016, Yann Droneaud wrote: > >> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), >> kfree() is no more the only function to be considered: >> kzfree() should be recognized too. >> >> In particular, kzfree() must not be called

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: >>> +weight = (int(rel_specs['VERSION'])<< 32) + \ >>> + (i

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: >>> +weight = (int(rel_specs['VERSION'])<< 32) + \ >>> + (i

Re: [PATCH] kcov: reject open when kernel not instrumented

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 17:49 Mark Rutland napsal(a): > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > this option from CFLAGS_KCOV, and build the kernel without > instrumentation, even if CONFIG_KCOV was selected. However, we still > build the rest of the kcov infrastructure,

Re: [PATCH] kcov: reject open when kernel not instrumented

2016-06-15 Thread Michal Marek
Dne 15.6.2016 v 17:49 Mark Rutland napsal(a): > If the toolchain does not support -fsanitize-coverage=trace-pc, we blat > this option from CFLAGS_KCOV, and build the kernel without > instrumentation, even if CONFIG_KCOV was selected. However, we still > build the rest of the kcov infrastructure,

Re: kbuild: default n removals?

2016-06-15 Thread Michal Marek
On 2016-06-08 17:38, Joe Perches wrote: > (Adding Michal Marek and linux-kbuild) > > On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: >> On 08.06.2016 16:53, Guenter Roeck wrote: >>> On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: >>>>>&g

Re: kbuild: default n removals?

2016-06-15 Thread Michal Marek
On 2016-06-08 17:38, Joe Perches wrote: > (Adding Michal Marek and linux-kbuild) > > On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: >> On 08.06.2016 16:53, Guenter Roeck wrote: >>> On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: >>>>>&g

Re: [PATCH 3/4] coccicheck: enable use of the kernel's python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > Signed-off-by: Luis R. Rodriguez > --- > scripts/coccicheck | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index ba7301ab0a3d..a4d91d649ad9 100755 > --- a/scripts/coccicheck

Re: [PATCH 3/4] coccicheck: enable use of the kernel's python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > Signed-off-by: Luis R. Rodriguez > --- > scripts/coccicheck | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index ba7301ab0a3d..a4d91d649ad9 100755 > --- a/scripts/coccicheck > +++

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > +weight = (int(rel_specs['VERSION'])<< 32) + \ > + (int(rel_specs['PATCHLEVEL']) << 16) + \ > + (sublevel << 8 ) + \ > + (extra * 60) + (relmod * 2) This is going

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Michal Marek
On 2016-06-15 00:10, Luis R. Rodriguez wrote: > +weight = (int(rel_specs['VERSION'])<< 32) + \ > + (int(rel_specs['PATCHLEVEL']) << 16) + \ > + (sublevel << 8 ) + \ > + (extra * 60) + (relmod * 2) This is going

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-06-14 Thread Michal Marek
On 2016-06-14 06:32, Stephen Rothwell wrote: > Hi Kees, > > On Mon, 13 Jun 2016 16:57:15 -0700 Kees Cook wrote: >> >> On Mon, Jun 13, 2016 at 4:53 PM, Kees Cook wrote: >>> >>> Strange, I pulled these directly from linux-next. Michal had an >>>

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-06-14 Thread Michal Marek
On 2016-06-14 06:32, Stephen Rothwell wrote: > Hi Kees, > > On Mon, 13 Jun 2016 16:57:15 -0700 Kees Cook wrote: >> >> On Mon, Jun 13, 2016 at 4:53 PM, Kees Cook wrote: >>> >>> Strange, I pulled these directly from linux-next. Michal had an >>> auto-responder saying he was going to be

Re: linux-next: build warnings after merge of the kbuild tree

2016-06-09 Thread Michal Marek
Dne 9.6.2016 v 06:05 Stephen Rothwell napsal(a): > On Wed, 8 Jun 2016 19:56:38 -0700 Kees Cook wrote: >> Ah, yes, that should default to off. We'll get a fix landed ASAP. > > Note that this was an allmodconfig build. The default is 'n', but > allmodconfig will turn it on

Re: linux-next: build warnings after merge of the kbuild tree

2016-06-09 Thread Michal Marek
Dne 9.6.2016 v 06:05 Stephen Rothwell napsal(a): > On Wed, 8 Jun 2016 19:56:38 -0700 Kees Cook wrote: >> Ah, yes, that should default to off. We'll get a fix landed ASAP. > > Note that this was an allmodconfig build. The default is 'n', but > allmodconfig will turn it on (as will allyesconfig).

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-06-08 Thread Michal Marek
Dne 7.6.2016 v 23:58 Kees Cook napsal(a): > On Tue, Jun 7, 2016 at 2:59 PM, Emese Revfy wrote: >> On Tue, 7 Jun 2016 13:59:53 -0700 >> Kees Cook wrote: >> I applied the series to kbuild.git#kbuild now, sorry for the delay. >>> >>> Awesome!

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-06-08 Thread Michal Marek
Dne 7.6.2016 v 23:58 Kees Cook napsal(a): > On Tue, Jun 7, 2016 at 2:59 PM, Emese Revfy wrote: >> On Tue, 7 Jun 2016 13:59:53 -0700 >> Kees Cook wrote: >> I applied the series to kbuild.git#kbuild now, sorry for the delay. >>> >>> Awesome! Thank you very much. I'll prepare the latent

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
respect to the main Makefile_. It's possible that e.g. some arch Makefile has a skeleton in the cupboard. We will see. Michal >From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00 2001 From: Michal Marek <mma...@suse.com> Date: Tue, 7 Jun 2016 11:57:02 +0200 Subject: [PATCH] kbuil

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
respect to the main Makefile_. It's possible that e.g. some arch Makefile has a skeleton in the cupboard. We will see. Michal >From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00 2001 From: Michal Marek Date: Tue, 7 Jun 2016 11:57:02 +0200 Subject: [PATCH] kbuild: Initialize expor

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-06-07 Thread Michal Marek
Dne 25.5.2016 v 19:12 Kees Cook napsal(a): > On Wed, May 25, 2016 at 3:46 AM, Michal Marek <mma...@suse.com> wrote: >> On 2016-05-24 19:04, Kees Cook wrote: >>> On Mon, May 23, 2016 at 3:07 PM, Emese Revfy <re.em...@gmail.com> wrote: >>>> This patch s

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-06-07 Thread Michal Marek
Dne 25.5.2016 v 19:12 Kees Cook napsal(a): > On Wed, May 25, 2016 at 3:46 AM, Michal Marek wrote: >> On 2016-05-24 19:04, Kees Cook wrote: >>> On Mon, May 23, 2016 at 3:07 PM, Emese Revfy wrote: >>>> This patch set introduce the GCC plugin infrastructure w

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 12:03, Masahiro Yamada wrote: > 2016-06-07 18:58 GMT+09:00 Michal Marek <mma...@suse.cz>: >> On 2016-06-07 11:38, Michal Marek wrote: >>> On 2016-06-07 03:38, Zanoni, Paulo R wrote: >>>> Hi >>>> >>>> I recently

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 12:03, Masahiro Yamada wrote: > 2016-06-07 18:58 GMT+09:00 Michal Marek : >> On 2016-06-07 11:38, Michal Marek wrote: >>> On 2016-06-07 03:38, Zanoni, Paulo R wrote: >>>> Hi >>>> >>>> I recently noticed that alternating betwe

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 11:38, Michal Marek wrote: > On 2016-06-07 03:38, Zanoni, Paulo R wrote: >> Hi >> >> I recently noticed that alternating between "make" and "make targz-pkg" >> rebuilds the whole Kernel. This was not happening before. As a Kernel

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 11:38, Michal Marek wrote: > On 2016-06-07 03:38, Zanoni, Paulo R wrote: >> Hi >> >> I recently noticed that alternating between "make" and "make targz-pkg" >> rebuilds the whole Kernel. This was not happening before. As a Kernel

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 03:38, Zanoni, Paulo R wrote: > Hi > > I recently noticed that alternating between "make" and "make targz-pkg" > rebuilds the whole Kernel. This was not happening before. As a Kernel > developer, my build/install/test environment heavily relies on the fact > that "make targz-pkg"

Re: Regression in "kbuild: fix if_change and friends to consider argument order"

2016-06-07 Thread Michal Marek
On 2016-06-07 03:38, Zanoni, Paulo R wrote: > Hi > > I recently noticed that alternating between "make" and "make targz-pkg" > rebuilds the whole Kernel. This was not happening before. As a Kernel > developer, my build/install/test environment heavily relies on the fact > that "make targz-pkg"

[GIT PULL] kbuild misc changes for v4.7-rc1

2016-05-26 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - Coccinelle fixes, one semantic patch less in this round [Vaishali Thakkar, Wolfram Sang, Kees Cook] - rpm-pkg support for (open)SUSE's update-bootloader [Jiří Kosian] - rpm-pkg restored support for $RPMOPTS [Srinivas Pandruvada] - deb-pkg

[GIT PULL] kbuild misc changes for v4.7-rc1

2016-05-26 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - Coccinelle fixes, one semantic patch less in this round [Vaishali Thakkar, Wolfram Sang, Kees Cook] - rpm-pkg support for (open)SUSE's update-bootloader [Jiří Kosian] - rpm-pkg restored support for $RPMOPTS [Srinivas Pandruvada] - deb-pkg

[GIT PULL] kconfig updates for v4.7-rc1

2016-05-26 Thread Michal Marek
Hi Linus, Please pull these kconfig fixes for v4.7-rc1: - Fix for behavior of tristate choice items and fix for documentation of existing kconfig behavior [Dirk Gouders] - More helpful "unexpected data" kconfig warning [Paul Bolle] Thanks, Michal The following changes since commit

[GIT PULL] kconfig updates for v4.7-rc1

2016-05-26 Thread Michal Marek
Hi Linus, Please pull these kconfig fixes for v4.7-rc1: - Fix for behavior of tristate choice items and fix for documentation of existing kconfig behavior [Dirk Gouders] - More helpful "unexpected data" kconfig warning [Paul Bolle] Thanks, Michal The following changes since commit

[GIT PULL] kbuild updates for v4.7-rc1

2016-05-26 Thread Michal Marek
c_i_c to cmd_cpp_i_c kbuild: rename cmd_as_s_S to cmd_cpp_s_S kbuild: fix if_change and friends to consider argument order Maxim Zhukov (1): scripts: genksyms: fix resource leak Michal Marek (1): kbuild: Get rid of KBUILD_STR Nicolas Ferre (1): kbuild: fix call to adjust_auto

[GIT PULL] kbuild updates for v4.7-rc1

2016-05-26 Thread Michal Marek
c_i_c to cmd_cpp_i_c kbuild: rename cmd_as_s_S to cmd_cpp_s_S kbuild: fix if_change and friends to consider argument order Maxim Zhukov (1): scripts: genksyms: fix resource leak Michal Marek (1): kbuild: Get rid of KBUILD_STR Nicolas Ferre (1): kbuild: fix call to adjust_auto

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-05-25 Thread Michal Marek
On 2016-05-24 19:04, Kees Cook wrote: > On Mon, May 23, 2016 at 3:07 PM, Emese Revfy wrote: >> This patch set introduce the GCC plugin infrastructure with examples for >> testing >> and documentation. >> >> GCC plugins are loadable modules that provide extra features to the

Re: [PATCH v9 0/4] Introduce GCC plugin infrastructure

2016-05-25 Thread Michal Marek
On 2016-05-24 19:04, Kees Cook wrote: > On Mon, May 23, 2016 at 3:07 PM, Emese Revfy wrote: >> This patch set introduce the GCC plugin infrastructure with examples for >> testing >> and documentation. >> >> GCC plugins are loadable modules that provide extra features to the compiler. >> They are

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

2016-05-19 Thread Michal Marek
Dne 17.5.2016 v 16:33 Julia Lawall napsal(a): > > > On Tue, 17 May 2016, Nicolas Palix (LIG) wrote: > >> Le 16/05/16 14:55, Kees Cook a écrit : >>> By default, "seq" counts from 1, but processes were starting counting >>> from 0, so when interrupted, coccicheck would leave the 0th process >>>

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

2016-05-19 Thread Michal Marek
Dne 17.5.2016 v 16:33 Julia Lawall napsal(a): > > > On Tue, 17 May 2016, Nicolas Palix (LIG) wrote: > >> Le 16/05/16 14:55, Kees Cook a écrit : >>> By default, "seq" counts from 1, but processes were starting counting >>> from 0, so when interrupted, coccicheck would leave the 0th process >>>

Re: [PATCH v8 2/4] GCC plugin infrastructure

2016-05-17 Thread Michal Marek
Dne 13.5.2016 v 01:57 Emese Revfy napsal(a): > --- /dev/null > +++ b/scripts/Makefile.gcc-plugins > @@ -0,0 +1,21 @@ > +ifdef CONFIG_GCC_PLUGINS > + __PLUGINCC := $(call cc-ifversion, -ge, 0408, $(HOSTCXX), $(HOSTCC)) > + PLUGINCC := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-plugin.sh >

Re: [PATCH v8 2/4] GCC plugin infrastructure

2016-05-17 Thread Michal Marek
Dne 13.5.2016 v 01:57 Emese Revfy napsal(a): > --- /dev/null > +++ b/scripts/Makefile.gcc-plugins > @@ -0,0 +1,21 @@ > +ifdef CONFIG_GCC_PLUGINS > + __PLUGINCC := $(call cc-ifversion, -ge, 0408, $(HOSTCXX), $(HOSTCC)) > + PLUGINCC := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-plugin.sh >

Re: [PATCH] scripts/package/Makefile: rpmbuild add support of RPMOPTS

2016-05-16 Thread Michal Marek
On Sat, May 14, 2016 at 08:09:52PM -0700, Srinivas Pandruvada wrote: > After commit 21a59991ce0c ("scripts/package/Makefile: rpmbuild is needed > for rpm targets"), it is no longer possible to specify RPMOPTS. > For example, we can no longer able to control _topdir using the following > make

Re: [PATCH] scripts/package/Makefile: rpmbuild add support of RPMOPTS

2016-05-16 Thread Michal Marek
On Sat, May 14, 2016 at 08:09:52PM -0700, Srinivas Pandruvada wrote: > After commit 21a59991ce0c ("scripts/package/Makefile: rpmbuild is needed > for rpm targets"), it is no longer possible to specify RPMOPTS. > For example, we can no longer able to control _topdir using the following > make

<    1   2   3   4   5   6   7   8   9   10   >