Re: [PATCH] logfs: clarify MTD dependency

2015-11-27 Thread Michal Marek
On 2015-11-27 15:30, Arnd Bergmann wrote: > On Friday 27 November 2015 15:14:06 Michal Marek wrote: >> >> Hi Arnd, >> >> I hit this as well and was about to submit a slightly different fix. Can >> you try the logfs portion of the below patch? Proper changel

Re: [PATCH] logfs: clarify MTD dependency

2015-11-27 Thread Michal Marek
) evaluates to 1 if CONFIG_FOO=y or we are building a module and CONFIG_FOO=m. Michal >From 63e7ab41e3958e753277728acbe15faf35a5374e Mon Sep 17 00:00:00 2001 From: Michal Marek <mma...@suse.com> Date: Fri, 27 Nov 2015 15:08:29 +0100 Subject: [PATCH] kbuild: Use IS_REACHABLE to handle o

Re: [PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-11-25 Thread Michal Marek
Dne 28.10.2015 v 14:25 Michal Marek napsal(a): > From: Michal Marek > > This allows to write > > drm-$(CONFIG_AGP) += drm_agpsupport.o > > without having to handle CONFIG_AGP=y vs. CONFIG_AGP=m. Only support > this syntax for modules, since built-in code dependin

Re: [PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-11-25 Thread Michal Marek
Dne 28.10.2015 v 14:25 Michal Marek napsal(a): > From: Michal Marek <mma...@suse.com> > > This allows to write > > drm-$(CONFIG_AGP) += drm_agpsupport.o > > without having to handle CONFIG_AGP=y vs. CONFIG_AGP=m. Only support > this syntax for modules,

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-24 11:42, Arnd Bergmann wrote: > On Tuesday 24 November 2015 11:20:43 Michal Marek wrote: >>> diff --git a/Makefile b/Makefile >>> index 5e01a416c6e4..f8b921658f29 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -626,7 +626,11 @@ KBUIL

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-23 17:26, Arnd Bergmann wrote: > These are all false positives that either rob someone's time when trying > to figure out whether they are real, or they get people to send wrong > patches to shut up the warnings. [...] > diff --git a/Makefile b/Makefile > index

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-23 17:26, Arnd Bergmann wrote: > These are all false positives that either rob someone's time when trying > to figure out whether they are real, or they get people to send wrong > patches to shut up the warnings. [...] > diff --git a/Makefile b/Makefile > index

Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-24 Thread Michal Marek
On 2015-11-24 11:42, Arnd Bergmann wrote: > On Tuesday 24 November 2015 11:20:43 Michal Marek wrote: >>> diff --git a/Makefile b/Makefile >>> index 5e01a416c6e4..f8b921658f29 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -626,7 +626,11 @@ KBUIL

Re: [PATCH] staging: drop kbuild workaround dummy module from top dir

2015-11-18 Thread Michal Marek
quired anymore. Acked-by: Michal Marek In fact, I can't even reproduce the original bug with 2.6.27 + the initial staging series. I also do not remember any fix for such bug in the recent years. 4b024242e8a4 ("kbuild: Fix linking error built-in.o no such file or directory") is related

Re: [PATCH] staging: drop kbuild workaround dummy module from top dir

2015-11-18 Thread Michal Marek
quired anymore. Acked-by: Michal Marek <mma...@suse.com> In fact, I can't even reproduce the original bug with 2.6.27 + the initial staging series. I also do not remember any fix for such bug in the recent years. 4b024242e8a4 ("kbuild: Fix linking error built-in.o no such file or d

Re: linux-next: clean up the kbuild tree?

2015-11-16 Thread Michal Marek
Dne 15.11.2015 v 18:58 Andi Kleen napsal(a): > On Sun, Nov 15, 2015 at 11:27:05AM +1100, Stephen Rothwell wrote: >> Hi Michal, >> >> I notice that the kbuild tree (relative to Linus' tree) only contains >> lots of merges and these 2 commits from April 2014: > > Really should get in that patch

Re: linux-next: clean up the kbuild tree?

2015-11-16 Thread Michal Marek
Dne 15.11.2015 v 18:58 Andi Kleen napsal(a): > On Sun, Nov 15, 2015 at 11:27:05AM +1100, Stephen Rothwell wrote: >> Hi Michal, >> >> I notice that the kbuild tree (relative to Linus' tree) only contains >> lots of merges and these 2 commits from April 2014: > > Really should get in that patch

[GIT PULL] kbuild misc update for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - several coccinelle updates - make deb-pkg creates an armhf package if CONFIG_VFP=y - make tags understands some more powerpc macros Thanks, Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1

[GIT PULL] kconfig changes for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, please pull these kconfig changes for v4.4-rc1: - make xconfig ported to Qt5, dropping support for Qt3 - merge_config.sh supports a single-input-file mode and also respects $KCONFIG_CONFIG - Fix for incorrect display of >= and > in dependency expressions Thanks, Michal The following

[GIT PULL] kbuild patch for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, the kbuild branch for v4.4-rc1 only has one commit: A new make kselftest-clean target cleans tools/testing/selftests. Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository

[GIT PULL] kbuild misc update for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, this is the non-critical part of kbuild: - several coccinelle updates - make deb-pkg creates an armhf package if CONFIG_VFP=y - make tags understands some more powerpc macros Thanks, Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1

[GIT PULL] kbuild patch for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, the kbuild branch for v4.4-rc1 only has one commit: A new make kselftest-clean target cleans tools/testing/selftests. Michal The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository

[GIT PULL] kconfig changes for v4.4-rc1

2015-11-10 Thread Michal Marek
Hi Linus, please pull these kconfig changes for v4.4-rc1: - make xconfig ported to Qt5, dropping support for Qt3 - merge_config.sh supports a single-input-file mode and also respects $KCONFIG_CONFIG - Fix for incorrect display of >= and > in dependency expressions Thanks, Michal The following

Re: [PATCH 00/10] merge_config misc reworks and testcases

2015-11-06 Thread Michal Marek
On 2015-10-28 01:46, Olof Johansson wrote: > On Wed, Oct 28, 2015 at 9:42 AM, Olof Johansson wrote: >> Hi, >> >> Somewhat wide distribution list here, since I've added everyone who's >> touched the script, with the presumption that those have been the major >> users of it. Please make sure none

Re: [PATCH 00/10] merge_config misc reworks and testcases

2015-11-06 Thread Michal Marek
On 2015-10-28 01:46, Olof Johansson wrote: > On Wed, Oct 28, 2015 at 9:42 AM, Olof Johansson wrote: >> Hi, >> >> Somewhat wide distribution list here, since I've added everyone who's >> touched the script, with the presumption that those have been the major >> users of it. Please

[PATCH] nfcmrvl: Fix Kconfig dependency

2015-11-03 Thread Michal Marek
rvl_spi.ko] undefined! Signed-off-by: Michal Marek --- drivers/nfc/nfcmrvl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/nfcmrvl/Kconfig b/drivers/nfc/nfcmrvl/Kconfig index 444ca94..670af76 100644 --- a/drivers/nfc/nfcmrvl/Kconfig +++ b/drivers/nfc/

[PATCH] nfcmrvl: Fix Kconfig dependency

2015-11-03 Thread Michal Marek
rvl_spi.ko] undefined! Signed-off-by: Michal Marek <mma...@suse.com> --- drivers/nfc/nfcmrvl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/nfcmrvl/Kconfig b/drivers/nfc/nfcmrvl/Kconfig index 444ca94..670af76 100644 --- a/drivers/nfc/nfcmrvl/Kconf

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 20:23 Thiago Macieira napsal(a): > On Monday 02 November 2015 10:48:00 Randy Dunlap wrote: >> Hi, >> What does this patch apply to? >> I can't apply it cleanly to to 4.3 or linux-next of yesterday or today. > > Hmm... interesting, it doesn't apply on linux-next. The reason for

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 17:28 Alexey Brodkin napsal(a): > On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote: >> Alexey, did this solve the problem for you? > > Yep, thanks a lot. > "make xconfig" now works for me! Thanks for testing, I will apply it to kbuild.git#kconfig. Thanks, Michal -- To

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 17:01, Thiago Macieira wrote: > On Monday 02 November 2015 16:50:33 Michal Marek wrote: >> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: >>> On Monday 02 November 2015 11:36:43 Michal Marek wrote: >>>> On 2015-11-02 04:20, Thiago

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: > On Monday 02 November 2015 11:36:43 Michal Marek wrote: > > On 2015-11-02 04:20, Thiago Macieira wrote: > > > - qtver=`qmake -query QT_VERSION` || { \ > > > + qtver=`qmake -query QT_VERSION` || \ >

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
On 2015-11-02 04:11, Randy Dunlap wrote: > On 11/01/15 08:53, Stephen Rothwell wrote: >> Hi all, >> >> I start again a day early, and this is how you all repay me? ;-) >> >> Changes since 20151022: >> > > on x86_64: > > 'make xconfig' dies a quick death when I try to use it: > >

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 04:20, Thiago Macieira wrote: > - qtver=`qmake -query QT_VERSION` || { \ > + qtver=`qmake -query QT_VERSION` || \ > + qtver=`qmake-qt5 -query QT_VERSION` || \ > + qtver=`qmake-qt4 -query QT_VERSION` || { \ The qtlibdir= etc assignments below still use qmake directly,

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
On 2015-11-02 04:11, Randy Dunlap wrote: > On 11/01/15 08:53, Stephen Rothwell wrote: >> Hi all, >> >> I start again a day early, and this is how you all repay me? ;-) >> >> Changes since 20151022: >> > > on x86_64: > > 'make xconfig' dies a quick death when I try to use it: > >

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: > On Monday 02 November 2015 11:36:43 Michal Marek wrote: > > On 2015-11-02 04:20, Thiago Macieira wrote: > > > - qtver=`qmake -query QT_VERSION` || { \ > > > + qtver=`qmake -query QT_VERSION` || \ >

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 17:01, Thiago Macieira wrote: > On Monday 02 November 2015 16:50:33 Michal Marek wrote: >> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: >>> On Monday 02 November 2015 11:36:43 Michal Marek wrote: >>>> On 2015-11-02 04:20, Thiago

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 17:28 Alexey Brodkin napsal(a): > On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote: >> Alexey, did this solve the problem for you? > > Yep, thanks a lot. > "make xconfig" now works for me! Thanks for testing, I will apply it to kbuild.git#kconfig. Thanks, Michal -- To

Re: linux-next: Tree for Nov 1 (xconfig problem)

2015-11-02 Thread Michal Marek
Dne 2.11.2015 v 20:23 Thiago Macieira napsal(a): > On Monday 02 November 2015 10:48:00 Randy Dunlap wrote: >> Hi, >> What does this patch apply to? >> I can't apply it cleanly to to 4.3 or linux-next of yesterday or today. > > Hmm... interesting, it doesn't apply on linux-next. The reason for

Re: make xconfig no longer works in Fedora

2015-11-02 Thread Michal Marek
On 2015-11-02 04:20, Thiago Macieira wrote: > - qtver=`qmake -query QT_VERSION` || { \ > + qtver=`qmake -query QT_VERSION` || \ > + qtver=`qmake-qt5 -query QT_VERSION` || \ > + qtver=`qmake-qt4 -query QT_VERSION` || { \ The qtlibdir= etc assignments below still use qmake directly,

Re: [PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-10-29 Thread Michal Marek
Dne 29.10.2015 v 07:34 Peter Chen napsal(a): > On Wed, Oct 28, 2015 at 02:25:41PM +0100, Michal Marek wrote: >> From: Michal Marek >> >> This allows to write >> >> drm-$(CONFIG_AGP) += drm_agpsupport.o >> >> without having to handle CONFIG_AGP=y

Re: [PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-10-29 Thread Michal Marek
Dne 29.10.2015 v 07:34 Peter Chen napsal(a): > On Wed, Oct 28, 2015 at 02:25:41PM +0100, Michal Marek wrote: >> From: Michal Marek <mma...@suse.com> >> >> This allows to write >> >> drm-$(CONFIG_AGP) += drm_agpsupport.o >> >> without having to

[PATCH 3/3] Revert "drm: Hack around CONFIG_AGP=m build failures"

2015-10-28 Thread Michal Marek
From: Michal Marek Kbuild now supports -m variables. This reverts commit 8fa884dc355ffd0caa964a284a530bf747df5c77. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Michal Marek --- drivers/gpu/drm/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/Makefile b

[PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-10-28 Thread Michal Marek
From: Michal Marek This allows to write drm-$(CONFIG_AGP) += drm_agpsupport.o without having to handle CONFIG_AGP=y vs. CONFIG_AGP=m. Only support this syntax for modules, since built-in code depending on something modular cannot work and init/Makefile actually relies on the current

[PATCH 1/3] staging/ad7606: Actually build the interface modules

2015-10-28 Thread Michal Marek
From: Michal Marek The ad7606_par and ad7606_spi drivers are not built if CONFIG_AD7606=m, because kbuild does not currently support -m syntax. Even if we add kbuild support, ad7606 fails to link, because of duplicate module_init definitions. Make the two drivers separate modules, as the Kconfig

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

2015-10-28 Thread Michal Marek
Dne 28.10.2015 v 10:54 Johan Hovold napsal(a): > On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote: >> Should have acked this message... >> >> Acked-by: Julia Lawall >> >> On Wed, 30 Sep 2015, Johan Hovold wrote: >> >>> This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic

Re: [PATCH 4/4] Mark files generated by confdata.c

2015-10-28 Thread Michal Marek
Dne 28.10.2015 v 09:00 Nicholas Mc Guire napsal(a): > On Tue, Oct 27, 2015 at 10:16:11PM +0100, Michal Marek wrote: >> You cannot run the C source to regenerate the file, so how about >> "generated by kconfig"? >> > Yup that makes more sense - and it would still

[PATCH 2/3] kbuild: Allow to specify composite modules with modname-m

2015-10-28 Thread Michal Marek
From: Michal Marek <mma...@suse.com> This allows to write drm-$(CONFIG_AGP) += drm_agpsupport.o without having to handle CONFIG_AGP=y vs. CONFIG_AGP=m. Only support this syntax for modules, since built-in code depending on something modular cannot work and init/Makefile actually

[PATCH 3/3] Revert "drm: Hack around CONFIG_AGP=m build failures"

2015-10-28 Thread Michal Marek
From: Michal Marek <mma...@suse.com> Kbuild now supports -m variables. This reverts commit 8fa884dc355ffd0caa964a284a530bf747df5c77. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Michal Marek <mma...@suse.cz> --- drivers/gpu/drm/Makefile | 2 -- 1 file changed, 2 deletions(-)

[PATCH 1/3] staging/ad7606: Actually build the interface modules

2015-10-28 Thread Michal Marek
From: Michal Marek <mma...@suse.com> The ad7606_par and ad7606_spi drivers are not built if CONFIG_AD7606=m, because kbuild does not currently support -m syntax. Even if we add kbuild support, ad7606 fails to link, because of duplicate module_init definitions. Make the two drivers se

Re: [PATCH 4/4] Mark files generated by confdata.c

2015-10-28 Thread Michal Marek
Dne 28.10.2015 v 09:00 Nicholas Mc Guire napsal(a): > On Tue, Oct 27, 2015 at 10:16:11PM +0100, Michal Marek wrote: >> You cannot run the C source to regenerate the file, so how about >> "generated by kconfig"? >> > Yup that makes more sense - and it would still

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

2015-10-28 Thread Michal Marek
Dne 28.10.2015 v 10:54 Johan Hovold napsal(a): > On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote: >> Should have acked this message... >> >> Acked-by: Julia Lawall >> >> On Wed, 30 Sep 2015, Johan Hovold wrote: >> >>> This effectively reverts 932058a5d5f9

Re: [PATCH 4/4] Mark files generated by confdata.c

2015-10-27 Thread Michal Marek
Dne 27.10.2015 v 16:30 Nicholas Mc Guire napsal(a): > scripts/kconfig/confdata.c generates a number of files - indicate the > location of the generator in the file heading to ease reading the sources. > > Signed-off-by: Nicholas Mc Guire > --- > This is no actual code change - compile-testing

Re: [PATCH 4/4] Mark files generated by confdata.c

2015-10-27 Thread Michal Marek
Dne 27.10.2015 v 16:30 Nicholas Mc Guire napsal(a): > scripts/kconfig/confdata.c generates a number of files - indicate the > location of the generator in the file heading to ease reading the sources. > > Signed-off-by: Nicholas Mc Guire > --- > This is no actual code change -

Re: [PATCH v6] coccinelle: Improve checking for missing NULL terminators

2015-10-26 Thread Michal Marek
Dne 23.10.2015 v 21:35 Julia Lawall napsal(a): > Acked-by: Julia Lawall > > On Fri, 23 Oct 2015, Daniel Granat wrote: > >> * Extend checking on tables containing structures which are >> initialized without specifying member name. Added new tables >> for checking: i2c_device_id and

Re: [PATCH 2/2 v2] coccinelle: ifnullfree: handle various destroy functions

2015-10-26 Thread Michal Marek
Dne 26.10.2015 v 22:28 Julia Lawall napsal(a): > Extend ifnullfree to the various destroy functions that were recently > extended to tolerate NULL arguments. > > Signed-off-by: Julia Lawall Applied both to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line

Re: [PATCH] cocinelle: iterators: semantic patch to delete unneeded of_node_put

2015-10-26 Thread Michal Marek
Dne 22.10.2015 v 22:11 Julia Lawall napsal(a): > Device node iterators perform an of_node_put on each iteration, so putting > an of_node_put before a continue results in a double put. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list:

Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

2015-10-26 Thread Michal Marek
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a): >> Remove removal and re-addition of freeing functions. > > I find such a wording confusing for a commit message. It is also a bit confusing to use the same subject for two patches in a series. How about [PATCH 1/2] coccinelle: ifnullfree:

Re: [PATCH] scripts/coccinelle: fix typos

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 11:35 Julia Lawall napsal(a): > Fix a couple spelling mistakes. > > Signed-off-by: Julia Lawall Applied, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] scripts/package/Makefile: Restore the RPMOPTS variable

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 02:09 Jim Davis napsal(a): > Restore the RPMOPTS variable to the rpm-pkg and binrpm-pkg targets > that commit 21a59991ce0c ("scripts/package/Makefile: rpmbuild is > needed for rpm targets") removed. > > Reported-by: Alaa Hleihel > Signed-off-by: Jim Davis If this is a

Re: [PATCH v2] Coccinelle: fix incorrect -include option transformation

2015-10-26 Thread Michal Marek
Dne 22.9.2015 v 15:27 Julia Lawall napsal(a): > On Tue, 22 Sep 2015, Andrzej Hajda wrote: > >> kbuild/gcc uses -include option to include files and -I to provide paths for >> #include <> directive. In case of spatch latter option should be prefixed >> with That hash sign in the comment was not

Re: [PATCH] kbuild: llvmlinux: Fix -fno-delete-null-pointer-checks compiler-flag

2015-10-26 Thread Michal Marek
Dne 15.9.2015 v 05:03 Sedat Dilek napsal(a): > CLANG (here: v3.7) does not support '-fno-delete-null-pointer-checks' > as a compiler-flag. > > Fix the HOSTCFLAGS and KBUILD_CFLAGS settings accordingly. > Furthermore, move and correct the $HOSTCC check. > > Tested against Linux v4.3-rc1 and a

Re: [PATCH] coccinelle: tests: improve odd_ptr_err.cocci

2015-10-26 Thread Michal Marek
Dne 30.8.2015 v 22:18 Julia Lawall napsal(a): > The original version only considered the case where the then branch > contains only one call to PTR_ERR. Reimplement the whole thing to allow > multiple calls, with potentially different arguments. > > Signed-off-by: Julia Lawall Applied to

Re: [PATCH v2] coccinelle: misc: move constants to the right

2015-10-26 Thread Michal Marek
Dne 4.9.2015 v 21:27 Julia Lawall napsal(a): > Move constants to the right in binary operators. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] coccinelle: tests: improve odd_ptr_err.cocci

2015-10-26 Thread Michal Marek
Dne 30.8.2015 v 22:18 Julia Lawall napsal(a): > The original version only considered the case where the then branch > contains only one call to PTR_ERR. Reimplement the whole thing to allow > multiple calls, with potentially different arguments. > > Signed-off-by: Julia Lawall

Re: [PATCH] scripts/coccinelle: fix typos

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 11:35 Julia Lawall napsal(a): > Fix a couple spelling mistakes. > > Signed-off-by: Julia Lawall Applied, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] Coccinelle: fix incorrect -include option transformation

2015-10-26 Thread Michal Marek
Dne 22.9.2015 v 15:27 Julia Lawall napsal(a): > On Tue, 22 Sep 2015, Andrzej Hajda wrote: > >> kbuild/gcc uses -include option to include files and -I to provide paths for >> #include <> directive. In case of spatch latter option should be prefixed >> with That hash sign in the comment was not

Re: [PATCH] scripts/package/Makefile: Restore the RPMOPTS variable

2015-10-26 Thread Michal Marek
Dne 17.10.2015 v 02:09 Jim Davis napsal(a): > Restore the RPMOPTS variable to the rpm-pkg and binrpm-pkg targets > that commit 21a59991ce0c ("scripts/package/Makefile: rpmbuild is > needed for rpm targets") removed. > > Reported-by: Alaa Hleihel > Signed-off-by: Jim Davis

Re: [PATCH v6] coccinelle: Improve checking for missing NULL terminators

2015-10-26 Thread Michal Marek
Dne 23.10.2015 v 21:35 Julia Lawall napsal(a): > Acked-by: Julia Lawall > > On Fri, 23 Oct 2015, Daniel Granat wrote: > >> * Extend checking on tables containing structures which are >> initialized without specifying member name. Added new tables >> for checking:

Re: [PATCH] cocinelle: iterators: semantic patch to delete unneeded of_node_put

2015-10-26 Thread Michal Marek
Dne 22.10.2015 v 22:11 Julia Lawall napsal(a): > Device node iterators perform an of_node_put on each iteration, so putting > an of_node_put before a continue results in a double put. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To

Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

2015-10-26 Thread Michal Marek
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a): >> Remove removal and re-addition of freeing functions. > > I find such a wording confusing for a commit message. It is also a bit confusing to use the same subject for two patches in a series. How about [PATCH 1/2] coccinelle: ifnullfree:

Re: [PATCH v2] coccinelle: misc: move constants to the right

2015-10-26 Thread Michal Marek
Dne 4.9.2015 v 21:27 Julia Lawall napsal(a): > Move constants to the right in binary operators. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] kbuild: llvmlinux: Fix -fno-delete-null-pointer-checks compiler-flag

2015-10-26 Thread Michal Marek
Dne 15.9.2015 v 05:03 Sedat Dilek napsal(a): > CLANG (here: v3.7) does not support '-fno-delete-null-pointer-checks' > as a compiler-flag. > > Fix the HOSTCFLAGS and KBUILD_CFLAGS settings accordingly. > Furthermore, move and correct the $HOSTCC check. > > Tested against Linux v4.3-rc1 and a

Re: [PATCH 2/2 v2] coccinelle: ifnullfree: handle various destroy functions

2015-10-26 Thread Michal Marek
Dne 26.10.2015 v 22:28 Julia Lawall napsal(a): > Extend ifnullfree to the various destroy functions that were recently > extended to tolerate NULL arguments. > > Signed-off-by: Julia Lawall Applied both to kbuild.git#misc, thanks. Michal -- To unsubscribe from this list:

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 14:14, Prarit Bhargava wrote: > On 10/22/2015 08:06 AM, Michal Marek wrote: >> It used to require a closing parenthesis, so it would not match the >> multiline macro invocations at all. Now it matches them, but ctags >> correctly warns that the empty string is

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 13:31, Prarit Bhargava wrote: > > > On 10/21/2015 03:52 PM, Michal Marek wrote: >> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>> On 10/15/2015 04:16 PM, Michal Marek wrote: >>>> Otherwise make tags can't parse them: >>>> >

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 13:31, Prarit Bhargava wrote: > > > On 10/21/2015 03:52 PM, Michal Marek wrote: >> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>> On 10/15/2015 04:16 PM, Michal Marek wrote: >>>> Otherwise make tags can't parse them: >>>> >

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Michal Marek
On 2015-10-22 14:14, Prarit Bhargava wrote: > On 10/22/2015 08:06 AM, Michal Marek wrote: >> It used to require a closing parenthesis, so it would not match the >> multiline macro invocations at all. Now it matches them, but ctags >> correctly warns that the empty string is

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Michal Marek
Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): > On 10/15/2015 04:16 PM, Michal Marek wrote: >> Otherwise make tags can't parse them: >> >> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern >> "\1" >> ctags: Warning: driver

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Michal Marek
Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): > On 10/15/2015 04:16 PM, Michal Marek wrote: >> Otherwise make tags can't parse them: >> >> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern >> "\1" >> ctags: Warning: driver

Re: [PATCH] kconfig: Fix copy error

2015-10-20 Thread Michal Marek
Dne 19.10.2015 v 16:57 Jan Beulich napsal(a): On 19.10.15 at 16:51, wrote: >> Signed-off-by: Michal Sojka > > Oops - yes of course. Thanks. > > Reviewed-by: Jan Beulich Applied to kbuild.git#kconfig. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] kconfig: Fix copy error

2015-10-20 Thread Michal Marek
Dne 19.10.2015 v 16:57 Jan Beulich napsal(a): On 19.10.15 at 16:51, wrote: >> Signed-off-by: Michal Sojka > > Oops - yes of course. Thanks. > > Reviewed-by: Jan Beulich Applied to kbuild.git#kconfig. Michal -- To unsubscribe

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-19 14:05, Christoffer Dall wrote: > ok, I've taken the patch. Thank you! I will remove it from my series. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-18 22:34, Christoffer Dall wrote: > On Thu, Oct 15, 2015 at 10:16:28PM +0200, Michal Marek wrote: >> Besides being a coding style issue, it confuses make tags: >> >> ctags: Warning: include/kvm/arm_vgic.h:307: null expansion of name pattern >> "\1

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-19 14:05, Christoffer Dall wrote: > ok, I've taken the patch. Thank you! I will remove it from my series. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-19 Thread Michal Marek
On 2015-10-18 22:34, Christoffer Dall wrote: > On Thu, Oct 15, 2015 at 10:16:28PM +0200, Michal Marek wrote: >> Besides being a coding style issue, it confuses make tags: >> >> ctags: Warning: include/kvm/arm_vgic.h:307: null expansion of name pattern >> "\1

Re: [PATCH 39/39] Update the buildsystem for KConfig finding Qt

2015-10-16 Thread Michal Marek
On 2015-10-16 06:12, Stefan Lippers-Hollmann wrote: > Hi > > On 2015-09-22, Thiago Macieira wrote: >> The buildsystem will now only search for Qt 4 and Qt 5. Support for Qt 2 >> and 3 was dropped in the previous commits (Qt 3 was EOL'ed in 2010 or >> so...). >> >> For Qt 5, to be future-proof

Re: [PATCH 39/39] Update the buildsystem for KConfig finding Qt

2015-10-16 Thread Michal Marek
On 2015-10-16 06:12, Stefan Lippers-Hollmann wrote: > Hi > > On 2015-09-22, Thiago Macieira wrote: >> The buildsystem will now only search for Qt 4 and Qt 5. Support for Qt 2 >> and 3 was dropped in the previous commits (Qt 3 was EOL'ed in 2010 or >> so...). >> >> For Qt 5, to be future-proof

[PATCH 4/9] tags: Fix erroneous pattern match in a comment

2015-10-15 Thread Michal Marek
l a better solution is found. Signed-off-by: Michal Marek --- scripts/tags.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 5b7828756083..996301c3883d 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -204,7 +204,7 @@ exuberant()

[PATCH 3/9] aic7xxx: Avoid name collision with

2015-10-15 Thread Michal Marek
expansion of name pattern "\3" Cc: linux-s...@vger.kernel.org Signed-off-by: Michal Marek --- drivers/scsi/aic7xxx/aic79xx.h | 4 ++-- drivers/scsi/aic7xxx/aic79xx_osm.h | 5 - drivers/scsi/aic7xxx/aic7xxx.h | 2 +- drivers/scsi/aic7xxx/aic7xxx_osm.h | 5 - drivers/scsi/aic7x

[PATCH 7/9] tags: Drop the _PE rule

2015-10-15 Thread Michal Marek
We are not indexing the userspace tools, so the rules only match some false positives in the kernel code. Signed-off-by: Michal Marek --- scripts/tags.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 8a03c335d107..06246b64c0a1 100755 --- a/scripts

[PATCH 1/9] tags: Treat header files as C code

2015-10-15 Thread Michal Marek
macros in the code and the C and C++ parsers fail and recover at different points. Also, qconf.h is parsed as C, but that's a negligible regression. Signed-off-by: Michal Marek --- scripts/tags.sh | 64 - 1 file changed, 32 insertions(+), 32

[PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-15 Thread Michal Marek
okies.c:44: null expansion of name pattern "\1" Cc: linux-i...@vger.kernel.org Cc: xen-de...@lists.xenproject.org Cc: linux-a...@vger.kernel.org Cc: rds-de...@oss.oracle.com Cc: net...@vger.kernel.org Signed-off-by: Michal Marek --- arch/ia64/kernel/smp.c | 3 +-- drivers/acpi/processor_idl

[PATCH 5/9] tags: Process Kconfig files in a single pass

2015-10-15 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/tags.sh | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 996301c3883d..7d496f602c4b 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -219,10 +219,7 @@ exuberant

[PATCH 8/9] tags: Unify emacs and exuberant rules

2015-10-15 Thread Michal Marek
with these versions of the tools: Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert etags (GNU Emacs 24.5) Signed-off-by: Michal Marek --- scripts/tags.sh | 200 ++-- 1 file changed, 108 insertions(+), 92 deletions(-) mode change

[PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-15 Thread Michal Marek
of name pattern "\1" ctags: Warning: include/kvm/arm_vgic.h:317: null expansion of name pattern "\1" Cc: kvm...@lists.cs.columbia.edu Signed-off-by: Michal Marek --- include/kvm/arm_vgic.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include

[PATCH 0/9] scripts/tags.sh cleanup

2015-10-15 Thread Michal Marek
Do a cleanup of the tags.sh script, to make it easier to maintain. The main part is in patch 8/9, which unifies the rules for emacs etags and exuberant ctags . Some of the fixes uncovered coding style issues in random source files, which are also fixed by this series. Michal Marek (9): tags

[PATCH 6/9] tags: Do not try to index defconfigs

2015-10-15 Thread Michal Marek
The defconfig files are in predictable locations, so there is no need to index them. Plus, the script was only looking for files named 'defconfig', which only works on a few architectures nowadays. Signed-off-by: Michal Marek --- scripts/tags.sh | 12 1 file changed, 12 deletions

Re: [RFC, 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

2015-10-15 Thread Michal Marek
target, using merge_config, as our defconfig, so >>>>>> adapt the logic in scripts/kconfig/Makefile to allow that. >>>>>> >>>>>> To minimise the chance of breaking anything, we first check if >>>>>> KBUILD_DEFCONFIG is a file, and if so

Re: [PATCH] scripts/kconfig/Makefile: Fix KBUILD_DEFCONFIG check when building with O=

2015-10-15 Thread Michal Marek
Reported-by: Olof Johansson > Signed-off-by: Michael Ellerman Acked-by: Michal Marek I could have spotted it myself :-/. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH] scripts/kconfig/Makefile: Fix KBUILD_DEFCONFIG check when building with O=

2015-10-15 Thread Michal Marek
; Reported-by: Olof Johansson <o...@lixom.net> > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> Acked-by: Michal Marek <mma...@suse.com> I could have spotted it myself :-/. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [RFC, 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

2015-10-15 Thread Michal Marek
t;>>> We would like to use a target, using merge_config, as our defconfig, so >>>>>> adapt the logic in scripts/kconfig/Makefile to allow that. >>>>>> >>>>>> To minimise the chance of breaking anything, we first check if >>>>>

[PATCH 2/9] KVM: arm: Do not indent the arguments of DECLARE_BITMAP

2015-10-15 Thread Michal Marek
of name pattern "\1" ctags: Warning: include/kvm/arm_vgic.h:317: null expansion of name pattern "\1" Cc: kvm...@lists.cs.columbia.edu Signed-off-by: Michal Marek <mma...@suse.com> --- include/kvm/arm_vgic.h | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 5/9] tags: Process Kconfig files in a single pass

2015-10-15 Thread Michal Marek
Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/tags.sh | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 996301c3883d..7d496f602c4b 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -219,10 +219,7 @@ exu

[PATCH 8/9] tags: Unify emacs and exuberant rules

2015-10-15 Thread Michal Marek
with these versions of the tools: Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert etags (GNU Emacs 24.5) Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/tags.sh | 200 ++-- 1 file changed, 108 insertions(+), 92 del

[PATCH 7/9] tags: Drop the _PE rule

2015-10-15 Thread Michal Marek
We are not indexing the userspace tools, so the rules only match some false positives in the kernel code. Signed-off-by: Michal Marek <mma...@suse.com> --- scripts/tags.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 8a03c335d107..06246b

<    1   2   3   4   5   6   7   8   9   10   >