Re: [PATCH] tags: much faster, parallel make tags

2015-04-15 Thread Michal Marek
On 2015-04-15 15:24, Michal Marek wrote: On 2015-04-14 19:20, Alexey Dobriyan wrote: ctags is single-threaded program. Split list of files to be tagged into equal parts, 1 part for each CPU and then merge the results. Speedup on one 2-way box I have is ~143 s = ~99 s (-31%). On another 4-way

Re: [PATCH V2 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-15 Thread Michal Marek
On 2015-04-09 22:58, Fabian Frederick wrote: if()/BUG conversion to BUG_ON must be avoided when there's side effect in condition. The reason being BUG_ON won't execute the condition when CONFIG_BUG is not defined. Inspired-by: J. Bruce Fields bfie...@fieldses.org Suggested-by: Julia

Re: [PATCH] tags: much faster, parallel make tags

2015-04-15 Thread Michal Marek
On 2015-04-14 19:20, Alexey Dobriyan wrote: ctags is single-threaded program. Split list of files to be tagged into equal parts, 1 part for each CPU and then merge the results. Speedup on one 2-way box I have is ~143 s = ~99 s (-31%). On another 4-way box: ~120 s = ~65 s (-46%!).

Re: [PATCH] tags: much faster, parallel make tags

2015-04-15 Thread Michal Marek
On 2015-04-14 22:24, Guenter Roeck wrote: On Tue, Apr 14, 2015 at 01:05:09PM -0700, Randy Dunlap wrote: On 04/14/15 10:20, Alexey Dobriyan wrote: ctags is single-threaded program. Split list of files to be tagged into equal parts, 1 part for each CPU and then merge the results. Speedup on

Re: [PATCH] tags: much faster, parallel make tags

2015-04-15 Thread Michal Marek
On 2015-04-14 19:20, Alexey Dobriyan wrote: ctags is single-threaded program. Split list of files to be tagged into equal parts, 1 part for each CPU and then merge the results. Speedup on one 2-way box I have is ~143 s = ~99 s (-31%). On another 4-way box: ~120 s = ~65 s (-46%!). I want

[GIT PULL] kbuild changes for v4.1-rc1

2015-04-15 Thread Michal Marek
rather than $(obj)/Makefile kbuild: ia64: use $(src)/Makefile.gate rather than particular path Michal Marek (1): kbuild: Don't reset timestamps in include/generated if not needed Kbuild| 21 ++--- Makefile | 28

Re: [PATCH] kbuild: add documentation of KBUILD_BUILD_VERSION

2015-04-13 Thread Michal Marek
On 2015-04-12 06:08, Nicholas Mc Guire wrote: > On Sat, 11 Apr 2015, Michal Marek wrote: > >> Dne 11.4.2015 v 15:20 Nicholas Mc Guire napsal(a): >>> On Sat, 11 Apr 2015, Jonathan Corbet wrote: >>> >>>> On Sun, 5 Apr 2015 08

Re: [PATCH] kbuild: add documentation of KBUILD_BUILD_VERSION

2015-04-13 Thread Michal Marek
On 2015-04-12 06:08, Nicholas Mc Guire wrote: On Sat, 11 Apr 2015, Michal Marek wrote: Dne 11.4.2015 v 15:20 Nicholas Mc Guire napsal(a): On Sat, 11 Apr 2015, Jonathan Corbet wrote: On Sun, 5 Apr 2015 08:44:28 +0200 Nicholas Mc Guire hof...@osadl.org wrote: KBUILD_BUILD_VERSION

Re: [PATCH] kbuild: add documentation of KBUILD_BUILD_VERSION

2015-04-11 Thread Michal Marek
Dne 11.4.2015 v 15:20 Nicholas Mc Guire napsal(a): > On Sat, 11 Apr 2015, Jonathan Corbet wrote: > >> On Sun, 5 Apr 2015 08:44:28 +0200 >> Nicholas Mc Guire wrote: >> >>> KBUILD_BUILD_VERSION is currently not documented but it is >>> needed when rebuilding a kernel that should result in the

Re: [PATCH] Makefile: Fix detection of clang when cross-compiling

2015-04-11 Thread Michal Marek
On Thu, Apr 09, 2015 at 04:34:54PM +0200, Paul Cercueil wrote: > When the host's C compiler is clang, and when attempting to > cross-compile Linux e.g. to MIPS with mipsel-linux-gcc, the Makefile > would incorrectly detect the use of clang, which resulted in > clang-specific flags being passed to

Re: [PATCH] kbuild: add documentation of KBUILD_BUILD_VERSION

2015-04-11 Thread Michal Marek
Dne 11.4.2015 v 15:20 Nicholas Mc Guire napsal(a): On Sat, 11 Apr 2015, Jonathan Corbet wrote: On Sun, 5 Apr 2015 08:44:28 +0200 Nicholas Mc Guire hof...@osadl.org wrote: KBUILD_BUILD_VERSION is currently not documented but it is needed when rebuilding a kernel that should result in the

Re: [PATCH] Makefile: Fix detection of clang when cross-compiling

2015-04-11 Thread Michal Marek
On Thu, Apr 09, 2015 at 04:34:54PM +0200, Paul Cercueil wrote: When the host's C compiler is clang, and when attempting to cross-compile Linux e.g. to MIPS with mipsel-linux-gcc, the Makefile would incorrectly detect the use of clang, which resulted in clang-specific flags being passed to

Re: [PATCH 0/2] Kbuild: kallsyms: update suffix ignore logic

2015-04-07 Thread Michal Marek
Dne 7.4.2015 v 11:02 Ard Biesheuvel napsal(a): > On 30 March 2015 at 15:20, Ard Biesheuvel wrote: >> Two patches that update the kallsyms ignore logic. >> >> Patch #1 adds logic to introduce symbols whose names end in (or equal) >> "_veneer". This prevent kallsyms generation errors on large ARM

Re: [PATCH 0/2] Kbuild: kallsyms: update suffix ignore logic

2015-04-07 Thread Michal Marek
Dne 7.4.2015 v 11:02 Ard Biesheuvel napsal(a): On 30 March 2015 at 15:20, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Two patches that update the kallsyms ignore logic. Patch #1 adds logic to introduce symbols whose names end in (or equal) _veneer. This prevent kallsyms generation errors

Re: [PATCH 0/4] kbuild: refactor Makefile inclusion

2015-04-02 Thread Michal Marek
On 2015-03-27 12:43, Masahiro Yamada wrote: > Masahiro Yamada (4): > kbuild: use relative path to include Makefile > kbuild: use relative path more to include Makefile > kbuild: include $(src)/Makefile rather than $(obj)/Makefile > kbuild: ia64: use $(src)/Makefile.gate rather than

Re: [PATCH] kbuild: do not add $(bounds-file) and $(offsets-file) to targets

2015-04-02 Thread Michal Marek
On 2015-03-26 12:59, Masahiro Yamada wrote: > $(always) is added to targets by scripts/Makefile.build. > Moreover, filechk does not need .*.cmd files. > > Adding these two files to targets is redundant. > > Signed-off-by: Masahiro Yamada Applied to kbuild.git#kbuild, thanks. Michal -- To

Re: [PATCH 0/4] kbuild: refactor Makefile inclusion

2015-04-02 Thread Michal Marek
On 2015-03-27 12:43, Masahiro Yamada wrote: Masahiro Yamada (4): kbuild: use relative path to include Makefile kbuild: use relative path more to include Makefile kbuild: include $(src)/Makefile rather than $(obj)/Makefile kbuild: ia64: use $(src)/Makefile.gate rather than particular

Re: [PATCH] kbuild: do not add $(bounds-file) and $(offsets-file) to targets

2015-04-02 Thread Michal Marek
On 2015-03-26 12:59, Masahiro Yamada wrote: $(always) is added to targets by scripts/Makefile.build. Moreover, filechk does not need .*.cmd files. Adding these two files to targets is redundant. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com Applied to kbuild.git#kbuild,

Re: [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o

2015-03-30 Thread Michal Marek
On 2015-03-30 15:31, Ard Biesheuvel wrote: > On 30 March 2015 at 15:26, Russell King - ARM Linux > wrote: >> On Mon, Mar 30, 2015 at 02:38:35PM +0200, Michal Marek wrote: >>> Is this a limitation of a particular ARM ABI or a limitation of a state >>> of the ar

Re: [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o

2015-03-30 Thread Michal Marek
On 2015-03-30 13:49, Ard Biesheuvel wrote: > The recursive partial linking of vmlinux can result in a > drivers/built-in.o that is so huge that it interferes with > the ability of the linker to emit veneers in the final link > stage if the symbols are out of reach. This is caused by the > fact

Re: [RFC PATCH 1/2] Kbuild: kallsyms: ignore veneers emitted by the ARM linker

2015-03-30 Thread Michal Marek
On 2015-03-30 13:49, Ard Biesheuvel wrote: > When linking large kernels on ARM, the linker will insert veneers > (i.e., PLT like stubs) when function symbols are out of reach for > the ordinary relative branch/branch-and-link instructions. > > However, due to the fact that the kallsyms region

Re: [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o

2015-03-30 Thread Michal Marek
On 2015-03-30 13:49, Ard Biesheuvel wrote: The recursive partial linking of vmlinux can result in a drivers/built-in.o that is so huge that it interferes with the ability of the linker to emit veneers in the final link stage if the symbols are out of reach. This is caused by the fact that

Re: [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o

2015-03-30 Thread Michal Marek
On 2015-03-30 15:31, Ard Biesheuvel wrote: On 30 March 2015 at 15:26, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Mar 30, 2015 at 02:38:35PM +0200, Michal Marek wrote: Is this a limitation of a particular ARM ABI or a limitation of a state of the art ARM linker or something

Re: [RFC PATCH 1/2] Kbuild: kallsyms: ignore veneers emitted by the ARM linker

2015-03-30 Thread Michal Marek
On 2015-03-30 13:49, Ard Biesheuvel wrote: When linking large kernels on ARM, the linker will insert veneers (i.e., PLT like stubs) when function symbols are out of reach for the ordinary relative branch/branch-and-link instructions. However, due to the fact that the kallsyms region sits in

Re: [PATCH] irqf_oneshot.cocci: add check of devm_request_threaded_irq()

2015-03-25 Thread Michal Marek
On Sun, Mar 22, 2015 at 11:29:13AM +0100, Julia Lawall wrote: > Acked-by: Julia Lawall > > Good fix, thanks! Applied to kbuild.git#misc. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] irqf_oneshot.cocci: add check of devm_request_threaded_irq()

2015-03-25 Thread Michal Marek
On Sun, Mar 22, 2015 at 11:29:13AM +0100, Julia Lawall wrote: Acked-by: Julia Lawall julia.law...@lip6.fr Good fix, thanks! Applied to kbuild.git#misc. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 13/14] kdbus: add walk-through user space example

2015-03-24 Thread Michal Marek
Dne 24.3.2015 v 18:37 Jiri Slaby napsal(a): > On 03/24/2015, 06:15 PM, David Herrmann wrote: >> On Tue, Mar 24, 2015 at 5:46 PM, Jiri Slaby wrote: >>> Errr, no. Not only it causes build failures (even with KDBUS=n), it >>> definitely should not be built for everyone. >> >> It's only built if

Re: [PATCH 0/6] kbuild: mergeconfig: fix bugs, improve readability, and add generic entry point

2015-03-24 Thread Michal Marek
On 2015-03-13 22:29, Darren Hart wrote: > On 3/13/15, 1:27 AM, "Josh Triplett" wrote: > >> On Fri, Mar 13, 2015 at 03:21:37PM +0900, Masahiro Yamada wrote: >>> >>> This series is related to mergeconfig (scripts/kconfig/merge_config.sh): >>> >>> 1/6 and 2/6 fix bugs related to the parallel build.

Re: [PATCH] kbuild: remove warning about "make depend"

2015-03-24 Thread Michal Marek
On 2015-02-03 11:43, Masahiro Yamada wrote: > Enough time has passed since "make depend" was deprecated. > Nobody would be in trouble without this hint. > > Signed-off-by: Masahiro Yamada I won't be surprised if some build script suddenly breaks. But such script has it coming :). Applied to

Re: [PATCH] kbuild: remove warning about make depend

2015-03-24 Thread Michal Marek
On 2015-02-03 11:43, Masahiro Yamada wrote: Enough time has passed since make depend was deprecated. Nobody would be in trouble without this hint. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com I won't be surprised if some build script suddenly breaks. But such script has it coming

Re: [PATCH 0/6] kbuild: mergeconfig: fix bugs, improve readability, and add generic entry point

2015-03-24 Thread Michal Marek
On 2015-03-13 22:29, Darren Hart wrote: On 3/13/15, 1:27 AM, Josh Triplett j...@joshtriplett.org wrote: On Fri, Mar 13, 2015 at 03:21:37PM +0900, Masahiro Yamada wrote: This series is related to mergeconfig (scripts/kconfig/merge_config.sh): 1/6 and 2/6 fix bugs related to the parallel

Re: [PATCH 13/14] kdbus: add walk-through user space example

2015-03-24 Thread Michal Marek
Dne 24.3.2015 v 18:37 Jiri Slaby napsal(a): On 03/24/2015, 06:15 PM, David Herrmann wrote: On Tue, Mar 24, 2015 at 5:46 PM, Jiri Slaby jsl...@suse.cz wrote: Errr, no. Not only it causes build failures (even with KDBUS=n), it definitely should not be built for everyone. It's only built if

Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism

2015-03-17 Thread Michal Marek
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a): > On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: >> On 2014-12-29 17:34, Sylvain BERTRAND wrote: >>> Chocked while compiling linux with dash shell instead of bash shell. >>> See: >>> http://pub

Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism

2015-03-17 Thread Michal Marek
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a): On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: On 2014-12-29 17:34, Sylvain BERTRAND wrote: Chocked while compiling linux with dash shell instead of bash shell. See: http://pubs.opengroup.org/onlinepubs/95399/utilities

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-13 Thread Michal Marek
Dne 13.3.2015 v 05:59 Masahiro Yamada napsal(a): > 2015-03-11 19:01 GMT+09:00 Michal Marek : >> We already have it and it is called "filechk." Valdis, can you check if >> the below patch works equally well for you? > > This looks almost nice, but a few comment

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-13 Thread Michal Marek
Dne 13.3.2015 v 05:59 Masahiro Yamada napsal(a): 2015-03-11 19:01 GMT+09:00 Michal Marek mma...@suse.cz: We already have it and it is called filechk. Valdis, can you check if the below patch works equally well for you? This looks almost nice, but a few comments below. Thanks for the review

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-03-11 Thread Michal Marek
On 2015-03-10 23:44, Mikko Rapeli wrote: > On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote: >> On 2015-02-17 00:05, Mikko Rapeli wrote: >>> Exit with error if using undefined variables or if any sub command fails >>> with error return value. unidef n

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-11 Thread Michal Marek
On Sun, Mar 08, 2015 at 04:08:06PM -0700, Linus Torvalds wrote: > On Tue, Mar 3, 2015 at 5:07 PM, Valdis Kletnieks > wrote: > > > > Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps > > and forcing rebuilds even if the contents haven't changed. Add a bit of > > shell magic

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-11 Thread Michal Marek
On Sun, Mar 08, 2015 at 04:08:06PM -0700, Linus Torvalds wrote: On Tue, Mar 3, 2015 at 5:07 PM, Valdis Kletnieks valdis.kletni...@vt.edu wrote: Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps and forcing rebuilds even if the contents haven't changed. Add a bit of

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-03-11 Thread Michal Marek
On 2015-03-10 23:44, Mikko Rapeli wrote: On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote: On 2015-02-17 00:05, Mikko Rapeli wrote: Exit with error if using undefined variables or if any sub command fails with error return value. unidef needs special handling since but this can

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-25 Thread Michal Marek
On 2015-02-10 23:32, Paul Bolle wrote: > On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote: >> We need an update to the MAINTAINERS file if "Yann E. MORIN" >> isn't the active Kconfig maintainer anymore. > > Yes, we do. Michal, what update would you suggest? I'll revert the patch that

Re: [PATCH] kconfig: fix a misspelling in scripts/kconfig/merge_config.sh

2015-02-25 Thread Michal Marek
On 2014-12-03 07:55, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/merge_config.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to kbuild.git#kconfig, sorry for the delay. Michal -- To unsubscribe from this list: send the line

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:59, David Howells wrote: > + if (argc == 5) { > + dest_name = argv[4]; > + replace_orig = false; > + } else { > + ERR(asprintf(_name, "%s.~signed~", module_name) < 0, > + "asprintf"); > + replace_orig = true;

Re: [PATCH 0/5] MODSIGN: Use PKCS#7 for module signatures [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:58, David Howells wrote: > Note that the revised sign-file program no longer supports the "-s > " > option as I'm not sure what the best way to deal with this is. Do we generate > a PKCS#7 cert from the signature given, or do we get given a PKCS#7 cert? I > lean towards the

Re: Differences between builtins and modules

2015-02-25 Thread Michal Marek
On Tue, Feb 24, 2015 at 10:02:55PM -0300, Lucas De Marchi wrote: > On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek wrote: > > On 2015-02-23 15:30, Lucas De Marchi wrote: > >> My questions are: > >> 1) should we put *all* the "modules" in the builtin index? &

Re: [PATCH 0/5] MODSIGN: Use PKCS#7 for module signatures [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:58, David Howells wrote: Note that the revised sign-file program no longer supports the -s signature option as I'm not sure what the best way to deal with this is. Do we generate a PKCS#7 cert from the signature given, or do we get given a PKCS#7 cert? I lean towards the

Re: Differences between builtins and modules

2015-02-25 Thread Michal Marek
On Tue, Feb 24, 2015 at 10:02:55PM -0300, Lucas De Marchi wrote: On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek mma...@suse.cz wrote: On 2015-02-23 15:30, Lucas De Marchi wrote: My questions are: 1) should we put *all* the modules in the builtin index? You mean all *.o files that do

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

2015-02-25 Thread Michal Marek
On 2015-02-06 15:59, David Howells wrote: + if (argc == 5) { + dest_name = argv[4]; + replace_orig = false; + } else { + ERR(asprintf(dest_name, %s.~signed~, module_name) 0, + asprintf); + replace_orig = true; + }

Re: [PATCH] kconfig: fix a misspelling in scripts/kconfig/merge_config.sh

2015-02-25 Thread Michal Marek
On 2014-12-03 07:55, Masahiro Yamada wrote: Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/kconfig/merge_config.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to kbuild.git#kconfig, sorry for the delay. Michal -- To unsubscribe from this list: send

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-25 Thread Michal Marek
On 2015-02-10 23:32, Paul Bolle wrote: On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote: We need an update to the MAINTAINERS file if Yann E. MORIN yann.morin.1...@free.fr isn't the active Kconfig maintainer anymore. Yes, we do. Michal, what update would you suggest? I'll revert the

[PATCH 1/3] kconfig: Get rid of the P() macro in headers

2015-02-24 Thread Michal Marek
\(([^,]*), *([^,]*), *(.*)\);/\2 \1\3;/' Plus some manual adjustments. Signed-off-by: Michal Marek --- scripts/kconfig/lkc.h | 2 -- scripts/kconfig/lkc_proto.h | 88 ++--- 2 files changed, 43 insertions(+), 47 deletions(-) diff --git a/scripts/kconfig/lkc.h

[PATCH 3/3] kconfig: Remove unnecessary prototypes from headers

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/kconfig/confdata.c | 5 + scripts/kconfig/expr.c | 18 -- scripts/kconfig/expr.h | 5 - scripts/kconfig/lkc.h | 11 --- scripts/kconfig/lkc_proto.h | 3 --- scripts/kconfig/menu.c | 4 ++-- scripts

[PATCH 2/3] kconfig: Remove dead code

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek --- scripts/kconfig/expr.c | 4 scripts/kconfig/gconf.c | 24 scripts/kconfig/lkc.h | 1 - scripts/kconfig/util.c | 10 -- 4 files changed, 39 deletions(-) diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c index

[PATCH 2/3] kconfig: Remove dead code

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek mma...@suse.cz --- scripts/kconfig/expr.c | 4 scripts/kconfig/gconf.c | 24 scripts/kconfig/lkc.h | 1 - scripts/kconfig/util.c | 10 -- 4 files changed, 39 deletions(-) diff --git a/scripts/kconfig/expr.c b/scripts/kconfig

[PATCH 3/3] kconfig: Remove unnecessary prototypes from headers

2015-02-24 Thread Michal Marek
Signed-off-by: Michal Marek mma...@suse.cz --- scripts/kconfig/confdata.c | 5 + scripts/kconfig/expr.c | 18 -- scripts/kconfig/expr.h | 5 - scripts/kconfig/lkc.h | 11 --- scripts/kconfig/lkc_proto.h | 3 --- scripts/kconfig/menu.c | 4

[PATCH 1/3] kconfig: Get rid of the P() macro in headers

2015-02-24 Thread Michal Marek
\(([^,]*), *([^,]*), *(.*)\);/\2 \1\3;/' Plus some manual adjustments. Signed-off-by: Michal Marek mma...@suse.cz --- scripts/kconfig/lkc.h | 2 -- scripts/kconfig/lkc_proto.h | 88 ++--- 2 files changed, 43 insertions(+), 47 deletions(-) diff --git a/scripts

Re: Differences between builtins and modules

2015-02-23 Thread Michal Marek
On 2015-02-23 15:30, Lucas De Marchi wrote: > This could be particularly bad if in a kernel version an option was > tristate and in a new version it changed to boolean. I'm not sure if > this is common to happen in kernel. Any code that did "modprobe > " would start to fail. I think it's quite

Re: Differences between builtins and modules

2015-02-23 Thread Michal Marek
On 2015-02-23 15:30, Lucas De Marchi wrote: This could be particularly bad if in a kernel version an option was tristate and in a new version it changed to boolean. I'm not sure if this is common to happen in kernel. Any code that did modprobe module would start to fail. I think it's quite

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On Fri, Feb 20, 2015 at 02:52:14PM +0100, Michal Marek wrote: > On 2015-02-19 13:26, David Howells wrote: > > Michal Marek wrote: > > > >> +X509_CERTIFICATES-y := $(wildcard *.x509) > >> +ifneq ($(objtree),$(srctree)) > >> +X509_CERTIFICATES-y +=

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On 2015-02-19 13:26, David Howells wrote: > Michal Marek wrote: > >> +X509_CERTIFICATES-y := $(wildcard *.x509) >> +ifneq ($(objtree),$(srctree)) >> +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509) >> +endif >> +X509_CERTIFICATES-$(CO

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-20 Thread Michal Marek
On 2015-02-20 10:29, Arnd Bergmann wrote: > On Thursday 19 February 2015 16:06:18 Michal Marek wrote: >>> We have similar problems in other areas >>> of the kernel. In theory, we could enforce the VIDEO_TUNER driver to >>> be modular here by adding lots of depe

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-20 Thread Michal Marek
On 2015-02-20 10:29, Arnd Bergmann wrote: On Thursday 19 February 2015 16:06:18 Michal Marek wrote: We have similar problems in other areas of the kernel. In theory, we could enforce the VIDEO_TUNER driver to be modular here by adding lots of dependencies to it: config VIDEO_TUNER

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On 2015-02-19 13:26, David Howells wrote: Michal Marek mma...@suse.cz wrote: +X509_CERTIFICATES-y := $(wildcard *.x509) +ifneq ($(objtree),$(srctree)) +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509) +endif +X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += signing_key.x509

Re: [PATCH] X.509: Fix certificate gathering again

2015-02-20 Thread Michal Marek
On Fri, Feb 20, 2015 at 02:52:14PM +0100, Michal Marek wrote: On 2015-02-19 13:26, David Howells wrote: Michal Marek mma...@suse.cz wrote: +X509_CERTIFICATES-y := $(wildcard *.x509) +ifneq ($(objtree),$(srctree)) +X509_CERTIFICATES-y += $(wildcard $(srctree)/*.x509) +endif

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
Dne 19.2.2015 v 15:53 Arnd Bergmann napsal(a): > On Thursday 19 February 2015 13:11:07 Michal Marek wrote: >> On 2015-02-18 18:12, Arnd Bergmann wrote: >>> In the media drivers, the v4l2 core knows about all submodules >>> and calls into them from a common function. H

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
On 2015-02-18 18:12, Arnd Bergmann wrote: > In the media drivers, the v4l2 core knows about all submodules > and calls into them from a common function. However this cannot > work if the modules that get called are loadable and the > core is built-in. In that case we get > > drivers/built-in.o:

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
On 2015-02-18 18:12, Arnd Bergmann wrote: In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In

Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro

2015-02-19 Thread Michal Marek
Dne 19.2.2015 v 15:53 Arnd Bergmann napsal(a): On Thursday 19 February 2015 13:11:07 Michal Marek wrote: On 2015-02-18 18:12, Arnd Bergmann wrote: In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules

[GIT PULL] kconfig changes for v3.20-rc1

2015-02-18 Thread Michal Marek
Hi Linus, Yann E. Morin was supposed to take over kconfig maintainership, but this hasn't happened. So I'm sending a few kconfig patches that I collected for v3.20-rc1: - Fix for missing va_end in kconfig - merge_config.sh displays used if given too few arguments - s/boolean/bool/ in Kconfig

[GIT PULL] kbuild misc changes for v3.20-rc1

2015-02-18 Thread Michal Marek
of CONFIG_CC_OPTIMIZE_FOR_SIZE (2015-01-08 14:53:50 +0100) Masahiro Yamada (1): kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE Michal Marek (1): kbuild: Update documentation of clean-files and clean-dirs Sedat Dilek (2

[GIT PULL] kbuild changes for v3.20-rc1

2015-02-18 Thread Michal Marek
the argument for false condition kbuild,gcov: simplify kernel/gcov/Makefile more Michal Marek (1): kbuild: Drop support for clean-rule Documentation/kbuild/makefiles.txt | 9 +++--- Kbuild | 61 +- Makefile

Re: [RFC] kbuild: make it possible to specify the module output dir

2015-02-18 Thread Michal Marek
On 2015-02-09 11:58, Kiran Raparthy wrote: > From: Rom Lemarchand > > kbuild: make it possible to specify the module output dir > > Make modinst_dir user-defined on the command line. > > This allows to do things like: > make MODLIB=output/ modinst_dir=. modules_install > > to ensure all the

[GIT PULL] kbuild misc changes for v3.20-rc1

2015-02-18 Thread Michal Marek
of CONFIG_CC_OPTIMIZE_FOR_SIZE (2015-01-08 14:53:50 +0100) Masahiro Yamada (1): kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE Michal Marek (1): kbuild: Update documentation of clean-files and clean-dirs Sedat Dilek (2

[GIT PULL] kconfig changes for v3.20-rc1

2015-02-18 Thread Michal Marek
Hi Linus, Yann E. Morin was supposed to take over kconfig maintainership, but this hasn't happened. So I'm sending a few kconfig patches that I collected for v3.20-rc1: - Fix for missing va_end in kconfig - merge_config.sh displays used if given too few arguments - s/boolean/bool/ in Kconfig

[GIT PULL] kbuild changes for v3.20-rc1

2015-02-18 Thread Michal Marek
the argument for false condition kbuild,gcov: simplify kernel/gcov/Makefile more Michal Marek (1): kbuild: Drop support for clean-rule Documentation/kbuild/makefiles.txt | 9 +++--- Kbuild | 61 +- Makefile

Re: [RFC] kbuild: make it possible to specify the module output dir

2015-02-18 Thread Michal Marek
On 2015-02-09 11:58, Kiran Raparthy wrote: From: Rom Lemarchand rom...@android.com kbuild: make it possible to specify the module output dir Make modinst_dir user-defined on the command line. This allows to do things like: make MODLIB=output/ modinst_dir=. modules_install to ensure

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-02-17 Thread Michal Marek
On 2015-02-17 00:05, Mikko Rapeli wrote: > Exit with error if using undefined variables or if any sub command fails > with error return value. unidef needs special handling since but this can > be done without the trap. Enables exaniming intermediate files if some > commands failed. The

Re: [PATCH 03/45] headers_install.sh: enhance error handling

2015-02-17 Thread Michal Marek
On 2015-02-17 00:05, Mikko Rapeli wrote: Exit with error if using undefined variables or if any sub command fails with error return value. unidef needs special handling since but this can be done without the trap. Enables exaniming intermediate files if some commands failed. The intermediate

Re: [PATCH] kasan: fix build warnings

2015-02-04 Thread Michal Marek
On 2015-02-04 13:05, Andrey Ryabinin wrote: > Or maybe it would be be better always use -Werror in cc-option? Please don't do it. A couple of Makefiles call cc-option after we have added the user-supplied KCFLAGS to KBUILD_CFLAGS. Michal -- To unsubscribe from this list: send the line

Re: [PATCH] kasan: fix build warnings

2015-02-04 Thread Michal Marek
On 2015-02-04 13:05, Andrey Ryabinin wrote: Or maybe it would be be better always use -Werror in cc-option? Please don't do it. A couple of Makefiles call cc-option after we have added the user-supplied KCFLAGS to KBUILD_CFLAGS. Michal -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-02 Thread Michal Marek
Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a): > On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek wrote: >> On 2015-01-29 21:47, Paul Bolle wrote: >>> [Added Michal. Removed Yann.] >>> >>> On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: >>&

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-02-02 Thread Michal Marek
Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a): On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek mma...@suse.cz wrote: On 2015-01-29 21:47, Paul Bolle wrote: [Added Michal. Removed Yann.] On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: On Tue, Jan 27, 2015 at 12:00 PM, Luis R

Re: [PATCH v12 01/28] scripts/gdb: Add infrastructure

2015-01-30 Thread Michal Marek
the object directory. > > Due to gdb.parse_and_eval and string redirection for gdb.execute, we > depend on gdb >= 7.2. > > This feature is enabled via CONFIG_GDB_SCRIPTS. > > CC: Michal Marek > CC: linux-kbu...@vger.kernel.org > Signed-off-by: Jan Kiszka > --- &

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-01-30 Thread Michal Marek
On 2015-01-29 21:47, Paul Bolle wrote: > [Added Michal. Removed Yann.] > > On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: >> On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez wrote: >>> On Fri, Jan 23, 2015 at 03:19:25PM +, Stefano Stabellini wrote: On Fri, 23 Jan 2015,

Re: [PATCH v3 0/2] x86/arm64: add xenconfig

2015-01-30 Thread Michal Marek
On 2015-01-29 21:47, Paul Bolle wrote: [Added Michal. Removed Yann.] On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote: On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Fri, Jan 23, 2015 at 03:19:25PM +, Stefano Stabellini wrote: On Fri, 23 Jan

Re: [PATCH v12 01/28] scripts/gdb: Add infrastructure

2015-01-30 Thread Michal Marek
to gdb.parse_and_eval and string redirection for gdb.execute, we depend on gdb = 7.2. This feature is enabled via CONFIG_GDB_SCRIPTS. CC: Michal Marek mma...@suse.cz CC: linux-kbu...@vger.kernel.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile | 5

Re: [PATCH v11 01/28] scripts/gdb: Add infrastructure

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: > --- a/scripts/Makefile > +++ b/scripts/Makefile > @@ -36,6 +36,7 @@ subdir-$(CONFIG_MODVERSIONS) += genksyms > subdir-y += mod > subdir-$(CONFIG_SECURITY_SELINUX) += selinux > subdir-$(CONFIG_DTC) += dtc >

Re: [PATCH v11 23/28] scripts/gdb: Ignore byte-compiled python files

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: > --- a/Makefile > +++ b/Makefile > @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version > .old_version $(version_h) \ > Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \ > signing_key.priv

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-29 Thread Michal Marek
On 2015-01-28 22:32, Paul Bolle wrote: > On Wed, 2015-01-28 at 16:26 +0100, Michal Marek wrote: >> On 2015-01-28 10:54, Paul Bolle wrote: >>> Now that we've been told Yann has disappeared, would you consider taking >>> this patch into one of your trees? It would be nice

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-29 Thread Michal Marek
On 2015-01-28 22:32, Paul Bolle wrote: On Wed, 2015-01-28 at 16:26 +0100, Michal Marek wrote: On 2015-01-28 10:54, Paul Bolle wrote: Now that we've been told Yann has disappeared, would you consider taking this patch into one of your trees? It would be nice to have people actually use

Re: [PATCH v11 01/28] scripts/gdb: Add infrastructure

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: --- a/scripts/Makefile +++ b/scripts/Makefile @@ -36,6 +36,7 @@ subdir-$(CONFIG_MODVERSIONS) += genksyms subdir-y += mod subdir-$(CONFIG_SECURITY_SELINUX) += selinux subdir-$(CONFIG_DTC) += dtc

Re: [PATCH v11 23/28] scripts/gdb: Ignore byte-compiled python files

2015-01-29 Thread Michal Marek
On 2015-01-29 07:46, Jan Kiszka wrote: --- a/Makefile +++ b/Makefile @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \ Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \ signing_key.priv signing_key.x509

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-28 Thread Michal Marek
On 2015-01-28 10:54, Paul Bolle wrote: > Now that we've been told Yann has disappeared, would you consider taking > this patch into one of your trees? It would be nice to have people > actually use it for a while. > > Or should we first clean up (most of) the warnings it generates? There It

Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected

2015-01-28 Thread Michal Marek
On 2015-01-28 10:54, Paul Bolle wrote: Now that we've been told Yann has disappeared, would you consider taking this patch into one of your trees? It would be nice to have people actually use it for a while. Or should we first clean up (most of) the warnings it generates? There It seems

Re: [PATCH] kconfig: use va_end to match corresponding va_start

2015-01-27 Thread Michal Marek
On 2015-01-12 14:18, Colin King wrote: > From: Colin Ian King > > Although on some systems va_end is a no-op, it is good practice > to use va_end, especially since the manual states: > > "Each invocation of va_start() must be matched by a corresponding > invocation of va_end() in the same

Re: [PATCH] kconfig: use va_end to match corresponding va_start

2015-01-27 Thread Michal Marek
On 2015-01-12 14:18, Colin King wrote: From: Colin Ian King colin.k...@canonical.com Although on some systems va_end is a no-op, it is good practice to use va_end, especially since the manual states: Each invocation of va_start() must be matched by a corresponding invocation of va_end()

[PATCH] DocBook: Do not exceed argument list limit

2015-01-26 Thread Michal Marek
Use find + xargs to compress the generated manpages. Without this patch, the build can fail with gzip -f Documentation/DocBook/man/*.9 /bin/bash: /usr/bin/gzip: Argument list too long This happened with qemu user mode emulation on aarch64. Signed-off-by: Michal Marek --- Documentation

[PATCH] DocBook: Do not exceed argument list limit

2015-01-26 Thread Michal Marek
Use find + xargs to compress the generated manpages. Without this patch, the build can fail with gzip -f Documentation/DocBook/man/*.9 /bin/bash: /usr/bin/gzip: Argument list too long This happened with qemu user mode emulation on aarch64. Signed-off-by: Michal Marek mma...@suse.cz

Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed

2015-01-23 Thread Michal Marek
On 2015-01-23 11:15, Alexander Holler wrote: > Am 23.01.2015 um 10:39 schrieb Alexander Holler: >> Am 23.01.2015 um 10:24 schrieb Michal Marek: >> >>>> + @rm ./signing_key.priv >>>> + @rm ./signing_key.x509 >>> >>> Why do you need to d

Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed

2015-01-23 Thread Michal Marek
On 2015-01-23 02:20, Alexander Holler wrote: > I usually throw away (delete) the key used to sign modules after having > called make -jN (b)zImage modules && make -jN modules_install. Because I've > got bored to always have to type rm signing_key.* afterwards, I've build > this patch some time

<    4   5   6   7   8   9   10   11   12   13   >