[PATCH] docs: Kill spaces at EOL in tuntap.txt

2012-12-18 Thread Michal Privoznik
Whitespace at the end of line is not end of the world, but nor useful too. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Documentation/networking/tuntap.txt | 64 ++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Documentation

[PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Michal Privoznik
/class/net/eth0/speed cat: /sys/class/net/eth0/speed: Invalid argument Signed-off-by: Michal Privoznik mpriv...@redhat.com --- net/core/net-sysfs.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 1cac29e..ce4b298 100644

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread Michal Privoznik
On 06.06.2014 21:54, David Miller wrote: From: Jiri Pirko j...@resnulli.us Date: Fri, 6 Jun 2014 10:57:33 +0200 Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this workaround code and have it clean and require say 3.16 kernel at least. Then your

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:44, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From

[PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Michal Privoznik
/sys/class/net/eth0/speed 4294967295 After the change: # cat /sys/class/net/eth0/speed -1 Signed-off-by: Michal Privoznik mpriv...@redhat.com --- net/core/net-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 1cac29e

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Michal Privoznik
changes through several architectures) while in fact '-1' should be reported. Before the change: # cat /sys/class/net/eth0/speed 4294967295 After the change: # cat /sys/class/net/eth0/speed -1 Signed-off-by: Michal Privoznik mpriv...@redhat.com --- net/core/net-sysfs.c | 2 +- 1 file

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-03 Thread Michal Privoznik
On 02.06.2014 20:10, David Miller wrote: From: Veaceslav Falico vfal...@redhat.com Date: Mon, 2 Jun 2014 17:01:50 +0200 I wonder, though, if we should document it or just output Unknown instead of -1. All of this discussion means that we can't change the format string without potentially

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-03 Thread Michal Privoznik
On 03.06.2014 09:07, Michal Privoznik wrote: On 02.06.2014 20:10, David Miller wrote: From: Veaceslav Falico vfal...@redhat.com Date: Mon, 2 Jun 2014 17:01:50 +0200 I wonder, though, if we should document it or just output Unknown instead of -1. All of this discussion means that we can't

[PATCH] cpupower: Correctly detect if running as root

2014-12-24 Thread Michal Privoznik
change the cpu frequency governor. Signed-off-by: Michal Privoznik mpriv...@redhat.com Acked-by: Thomas Renninger tr...@suse.de --- tools/power/cpupower/utils/cpupower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power

[PATCH] cpupower: Correctly detect if running as root

2014-12-14 Thread Michal Privoznik
change the cpu frequency governor. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/power/cpupower/utils/cpupower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c index 7cdcf88

[PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Michal Privoznik
/sys/class/net/eth0/speed 4294967295 After the change: # cat /sys/class/net/eth0/speed -1 Signed-off-by: Michal Privoznik --- net/core/net-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 1cac29e..99afdea 100644

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Michal Privoznik
changes through several architectures) while in fact '-1' should be reported. Before the change: # cat /sys/class/net/eth0/speed 4294967295 After the change: # cat /sys/class/net/eth0/speed -1 Signed-off-by: Michal Privoznik --- net/core/net-sysfs.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-03 Thread Michal Privoznik
On 02.06.2014 20:10, David Miller wrote: From: Veaceslav Falico Date: Mon, 2 Jun 2014 17:01:50 +0200 I wonder, though, if we should document it or just output "Unknown" instead of -1. All of this discussion means that we can't change the format string without potentially breaking something

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-03 Thread Michal Privoznik
On 03.06.2014 09:07, Michal Privoznik wrote: On 02.06.2014 20:10, David Miller wrote: From: Veaceslav Falico Date: Mon, 2 Jun 2014 17:01:50 +0200 I wonder, though, if we should document it or just output "Unknown" instead of -1. All of this discussion means that we can't change

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread Michal Privoznik
On 06.06.2014 21:54, David Miller wrote: From: Jiri Pirko Date: Fri, 6 Jun 2014 10:57:33 +0200 Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the link is not

[PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Michal Privoznik
/class/net/eth0/speed cat: /sys/class/net/eth0/speed: Invalid argument Signed-off-by: Michal Privoznik --- net/core/net-sysfs.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 1cac29e..ce4b298 100644 --- a/net/core/net

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this workaround code and have it clean and require say 3.16 kernel at least. Then your application wouldn't

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:44, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun

Re: cgroup and FALLOC_FL_PUNCH_HOLE: WARNING: CPU: 13 PID: 2438 at mm/page_counter.c:57 page_counter_uncharge+0x4b/0x5

2020-10-21 Thread Michal Privoznik
On 10/21/20 5:35 AM, Mike Kravetz wrote: On 10/20/20 6:38 AM, David Hildenbrand wrote: I'm bisecting the warning right now. Looks like it was introduced in v5.7. I found the following bugs in the cgroup reservation accounting. The ones in region_del are pretty obvious as the number of pages

Re: [PATCH] hugetlb_cgroup: fix reservation accounting

2020-10-22 Thread Michal Privoznik
On 10/21/20 10:44 PM, Mike Kravetz wrote: Michal Privoznik was using "free page reporting" in QEMU/virtio-balloon with hugetlbfs and hit the warning below. QEMU with free page hinting uses fallocate(FALLOC_FL_PUNCH_HOLE) to discard pages that are reported as free by a VM. The

[PATCH] docs: Kill spaces at EOL in tuntap.txt

2012-12-18 Thread Michal Privoznik
Whitespace at the end of line is not end of the world, but nor useful too. Signed-off-by: Michal Privoznik --- Documentation/networking/tuntap.txt | 64 ++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Documentation/networking/tuntap.txt b

[PATCH] cpupower: Correctly detect if running as root

2014-12-14 Thread Michal Privoznik
change the cpu frequency governor. Signed-off-by: Michal Privoznik --- tools/power/cpupower/utils/cpupower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c index 7cdcf88..9ea9143 100644

[PATCH] cpupower: Correctly detect if running as root

2014-12-24 Thread Michal Privoznik
change the cpu frequency governor. Signed-off-by: Michal Privoznik Acked-by: Thomas Renninger --- tools/power/cpupower/utils/cpupower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c index