[PATCH] serial: of-serial: Remove device_type = "serial" registration

2015-04-13 Thread Michal Simek
Do not probe all serial drivers by of_serial.c which are using device_type = "serial"; property. Only drivers which have valid compatible strings listed in the driver should be probed. When PORT_UNKNOWN probe will fail anyway. Signed-off-by: Michal Simek CC: --- drivers/

Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration

2015-04-13 Thread Michal Simek
Hi Greg, On 04/13/2015 07:00 PM, Greg Kroah-Hartman wrote: > On Mon, Apr 13, 2015 at 04:35:27PM +0200, Michal Simek wrote: >> Do not probe all serial drivers by of_serial.c which are using >> device_type = "serial"; property. Only drivers which have valid >> c

Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration

2015-04-13 Thread Michal Simek
On 04/13/2015 05:50 PM, Peter Hurley wrote: > [ + Arnd ] > > Hi Michal, > > On 04/13/2015 10:35 AM, Michal Simek wrote: >> Do not probe all serial drivers by of_serial.c which are using >> device_type = "serial"; property. Only drivers which have valid >&

Re: [PATCHv1 0/2] Adding driver for Xilinx LogiCORE IP mailbox.

2015-05-26 Thread Michal Simek
On 05/26/2015 06:12 PM, Moritz Fischer wrote: > On Mon, May 25, 2015 at 6:56 AM, Jingoo Han wrote: >> On Monday, May 25, 2015 3:05 PM, Michal Simek wrote: >>> On 05/22/2015 08:03 PM, Moritz Fischer wrote: >>>> This patchset adds mailbox framework integrat

Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().

2015-05-27 Thread Michal Simek
buffer_count = 0; > num_writes++; > - dirty = 0; > + dirty = false; > } > > /* Write unwritten data to ICAP */ > Tested-by: Michal Simek Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCHv2 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.

2015-05-27 Thread Michal Simek
On 05/27/2015 08:35 PM, Moritz Fischer wrote: > Changes from v1: > - Added common clock framework support > > Changes from v0: > - Fixed example bindings > > Signed-off-by: Moritz Fischer > --- > .../bindings/mailbox/xilinx-mailbox.txt | 44 > 1 file changed, 44 ins

Re: [PATCHv2 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-05-27 Thread Michal Simek
On 05/27/2015 08:35 PM, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is single channel per core and allows for transmit and receive. > > Changes from v1: > - Added com

Re: [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-27 Thread Michal Simek
On 05/27/2015 10:52 PM, Sören Brinkmann wrote: > On Wed, 2015-05-27 at 03:00PM -0500, Nathan Sullivan wrote: >> Use the new zynq binding for macb ethernet, since it will disable half >> duplex gigabit like the Zynq TRM says to do. Also allow the compatible >> cadence gem binding that won't disable

Re: [PATCHv2 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-05-28 Thread Michal Simek
On 05/28/2015 07:35 PM, Moritz Fischer wrote: > On Wed, May 27, 2015 at 10:45 PM, Michal Simek > wrote: >> On 05/27/2015 08:35 PM, Moritz Fischer wrote: >>> The Xilinx LogiCORE IP mailbox is a FPGA core that allows for >>> interprocessor communication via AX

Re: [PATCHv3 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.

2015-05-28 Thread Michal Simek
only one channel). The equivalent "mbox-names" property value can be > +used to give a name to the communication channel to be used by the client > user. > + > +Example: > + mclient0: mclient0@400 { > + compatible = "client-1.0"; > +

Re: [PATCHv3 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-05-28 Thread Michal Simek
+ return -ENOMEM; > + > + /* get clk and enable */ > + mbox->clk = devm_clk_get(&pdev->dev, "mbox"); > + if (IS_ERR(mbox->clk)) { > + dev_err(&pdev->dev, "Couldn't get clk.\n"); > + re

Re: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode

2015-06-11 Thread Michal Simek
ded..0d274fe 100644 > --- a/arch/arm/include/debug/zynq.S > +++ b/arch/arm/include/debug/zynq.S > @@ -38,6 +38,7 @@ > .endm > > .macro senduart,rd,rx > +ARM_BE8( rev \rd, \rd ) > str \rd, [\rx, #UART_FIFO_OFFSET

Re: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode

2015-06-12 Thread Michal Simek
str \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA > + strb\rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA > .endm > > .macro waituart,rd,rx > ok - this works too. Tested-by: Michal Simek Thanks, Michal -- To unsubscribe from this list: send th

[PATCH] drivers/firmware/memmap.c: Fix kernel-doc format

2015-06-12 Thread Michal Simek
Fix kernel-doc format validation to be able to use kernel-doc script for checking it. Signed-off-by: Michal Simek --- drivers/firmware/memmap.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c

[GIT PULL] arch/microblaze changes for 4.2-rc1

2015-06-22 Thread Michal Simek
pci_dev declaration Michal Simek (2): microblaze: Add missing release version code microblaze: Label local function static arch/microblaze/include/asm/pci.h| 17 - arch/microblaze/kernel/cpu/cpuinfo.c | 2 ++ arch/microblaze/kernel/dma.c | 1 + arch

Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-06-23 Thread Michal Simek
On 06/23/2015 08:00 PM, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is single channel per core and allows for transmit and receive. > > Changes from v4: > - Have sepa

[PATCH 3/3] usb: berlin: Trivial coding style cleanup

2015-06-24 Thread Michal Simek
Remove unneeded space after tab. Signed-off-by: Michal Simek --- drivers/phy/phy-berlin-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c index 762f0fbdc119..0fe0d81c29ee 100644 --- a/drivers/phy/phy-berlin

[PATCH 1/3] phy: berlin: .owner field is setup by core

2015-06-24 Thread Michal Simek
There was big cleanup in past to remove this unneeded setting. Signed-off-by: Michal Simek --- Can be also tracked by coccinelle script. scripts/coccinelle/api/platform_no_drv_owner.cocci --- drivers/phy/phy-berlin-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/phy

[PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver

2015-06-24 Thread Michal Simek
c&p error from berlin sata phy driver. Signed-off-by: Michal Simek --- drivers/phy/phy-berlin-usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c index d7431f6ab975..762f0fbdc119 100644 --- a/drivers

Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-06-24 Thread Michal Simek
On 06/24/2015 10:36 PM, Paul Bolle wrote: > On Tue, 2015-06-23 at 11:00 -0700, Moritz Fischer wrote: >> +MODULE_ALIAS("platform:xilinx-mailbox"); > > So I think this MODULE_ALIAS() is only useful if, in short, there's a > corresponding platform_device created. Ie, a platform_device with a > name "

Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-06-25 Thread Michal Simek
On 06/25/2015 09:31 AM, Paul Bolle wrote: > On Thu, 2015-06-25 at 08:55 +0200, Michal Simek wrote: >> On 06/24/2015 10:36 PM, Paul Bolle wrote: >>> On Tue, 2015-06-23 at 11:00 -0700, Moritz Fischer wrote: >>>> +MODULE_ALIAS("platform:xilinx-mailbox"); >&g

[PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable

2015-06-25 Thread Michal Simek
ff0a.gpio: Unbalanced pm_runtime_enable! root@zynqmp:~# rmmod gpio_zynq root@zynqmp:~# lsmod Not tainted Signed-off-by: Michal Simek --- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 2e87c4b8da26

Re: [PATCH v2] gpio/xilinx: Use correct address when setting initial values.

2015-06-25 Thread Michal Simek
T, > chip->gpio_state[1]); > - xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET, > + xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET, > chip->gpio_dir[1]); > } Reviewed-by: Michal Simek

Re: [PATCH v2 1/2] devicetree:bindings: add devicetree bindings for ceva ahci

2015-06-04 Thread Michal Simek
instead of gen2. > + > +Examples: > + ahci@fd0c { > + compatible = "ceva,ahci-1v84"; > + reg = <0xfd0c 0x200>; > + interrupt-parent = <&gic>; > + interrupts = <0 133 4>; > +

Re: [PATCH v2 2/2] drivers: ata: add support for Ceva sata host controller

2015-06-04 Thread Michal Simek
&ahci_platform_sht); > +} > + > +static int __maybe_unused ceva_ahci_suspend(struct device *dev) > +{ > + return ahci_platform_suspend_host(dev); > +} > + > +static int __maybe_unused ceva_ahci_resume(struct device *dev) > +{ > + return ahci_platfo

[PATCH] net: ll_temac: Remove sparse warnings

2015-06-05 Thread Michal Simek
main.c:590:6: warning: symbol 'temac_adjust_link' was not declared. Should it be static? Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/ll_temac_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_m

[PATCH] microblaze: Label local function static

2015-06-05 Thread Michal Simek
Warnings found by sparse: arch/microblaze/kernel/dma.c:157:5: warning: symbol 'dma_direct_mmap_coherent' was not declared. Should it be static? arch/microblaze/kernel/kgdb.c:35:14: warning: symbol 'pvr' was not declared. Should it be static? Signed-off-by: Michal Simek -

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-08 Thread Michal Simek
hink that > either the comment at the top of this file or the ident used in the > MODULE_LICENSE() macro needs to change. This is not just the problem with this driver but with others too. Have you sent any patch to add GPL v2+ to license.h? Also sort of checking for this will be great. Julia

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-09 Thread Michal Simek
On 06/09/2015 08:10 AM, Julia Lawall wrote: > > > On Tue, 9 Jun 2015, Michal Simek wrote: > >> Hi Paul, >> >> On 05/22/2015 12:30 PM, Paul Bolle wrote: >>> Again, just a nit: a license mismatch. >>> >>> On Thu, 2015-05-21 at 22:37 +0530

Re: [PATCH v2] gpio: Added GPIO support to Zynq Ultrascale+ MPSoC

2015-06-04 Thread Michal Simek
urce(pdev, IORESOURCE_MEM, 0); > @@ -619,7 +684,7 @@ static int zynq_gpio_probe(struct platform_device *pdev) > > /* configure the gpio chip */ > chip = &gpio->chip; > - chip->label = "zynq_gpio"; > + chip->label = gpio->p_data->lab

Re: linux-next: manual merge of the arm-soc tree with Linus' tree

2015-06-01 Thread Michal Simek
vid applied v1 of the patch. I have applied v2 (pulled via arm-soc) which also keep backward compatible string. There should be two compatible strings. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel -

[PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().

2015-06-01 Thread Michal Simek
From: Shailendra Verma The variable dirty is bool type. Hence assign the variable with bool value true/false instead of 1/0. Signed-off-by: Shailendra Verma Tested-by: Michal Simek --- drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-09 Thread Michal Simek
On 06/09/2015 09:21 AM, Paul Bolle wrote: > On Tue, 2015-06-09 at 08:03 +0200, Michal Simek wrote: >> Have you sent any patch to add GPL v2+ to license.h? > > "GPL" already means GPL v2 or later (see include/linux/module.h). ok. I see. Thanks, Michal -- Michal Sim

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-09 Thread Michal Simek
On 06/09/2015 10:15 AM, Paul Bolle wrote: > On Tue, 2015-06-09 at 09:09 +0200, Michal Simek wrote: >> On 06/09/2015 08:10 AM, Julia Lawall wrote: >>> On Tue, 9 Jun 2015, Michal Simek wrote: >>>> Also sort of checking for this will be great. Julia? >>> >&g

Re: [PATCH v2] checkpatch: validate MODULE_LICENSE content

2015-06-09 Thread Michal Simek
m the patch. > > I'd be inclined to keep it - if someone has used "Proprietary" then > they meant to do so, and they don't want checkpatch to keep telling them > they made a typo. Any update on this patch? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-09 Thread Michal Simek
On 06/09/2015 01:59 PM, Paul Bolle wrote: > On Tue, 2015-06-09 at 12:41 +0200, Michal Simek wrote: >> On 06/09/2015 10:15 AM, Paul Bolle wrote: >>> Mistakes I've seen made since I started checking this stuff (a few >>> months ago): >>> - typos in the lice

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-06-09 Thread Michal Simek
On 06/09/2015 02:24 PM, Paul Bolle wrote: > On Tue, 2015-06-09 at 14:12 +0200, Michal Simek wrote >> ok. Will check all our drivers we have to get it synchronized but I >> expect that a lot of drivers have problems there. > > So do I. Cleaning that all up would add a lo

Re: [PATCH] devicetree: xilinx: zynqmp: add sata node

2015-06-10 Thread Michal Simek
"disabled"; > + reg = <0x0 0xfd0c 0x2000>; > + interrupt-parent = <&gic>; > + interrupts = <0 133 4>; > + clocks = <&sata_clk>; > + }; > + > sdhci0:

Re: [PATCH] gpio: zynq: add missing module_exit function

2015-06-18 Thread Michal Simek
{ > + platform_driver_unregister(&zynq_gpio_driver); > +} > +module_exit(zynq_gpio_exit); > + > MODULE_AUTHOR("Xilinx Inc."); > MODULE_DESCRIPTION("Zynq GPIO driver"); > MODULE_LICENSE("GPL"); > Looks reasonable to me. Tested-by:

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-23 Thread Michal Simek
>> If you take a look at >> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts >> which is Ultra96 board gpio-line-names are filled there for the whole PS >> part. Definitely take a look and let know if you find out any issue there. > > It looks good. I even managed to boot my Ultra96 board which >

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-23 Thread Michal Simek
On 23.5.2018 11:44, Linus Walleij wrote: > On Tue, May 15, 2018 at 3:26 PM, Michal Simek wrote: > >> Have you done any decision about this patch? > > Yeah I applied the patch. It's a bit of "choose the lesser evil" approach > but what can I do... Thanks, Michal

Re: [PATCH v5 3/4] drivers: firmware: xilinx: Add sysfs interface

2018-03-01 Thread Michal Simek
+ This file name has changed between v4 and v5. File from v4 was correct. That's why I am waiting for v6 to be send before this is applied. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microbla

[PATCH] serial: xuartps: Fix the early_console junk character issue

2018-04-04 Thread Michal Simek
kishore Manne Signed-off-by: Michal Simek --- drivers/tty/serial/xilinx_uartps.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 19d370779767..4176c3a0b4e8 100644 --- a

Re: [RFC PATCH 1/3] of: base: Introduce of_alias_check_id() to check alias IDs

2018-04-26 Thread Michal Simek
On 27.4.2018 04:39, Rob Herring wrote: > On Thu, Apr 26, 2018 at 9:08 AM, Michal Simek wrote: >> The function travers the lookup table to check if the request alias >> id is compatible with the device driver match structure. >> This function will be used by serial drivers

Re: [PATCH 3/3] can: xilinx: fix xcan_start_xmit()'s return type

2018-04-27 Thread Michal Simek
On 26.4.2018 23:13, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

Re: [PATCH 3/3] can: xilinx: fix xcan_start_xmit()'s return type

2018-04-27 Thread Michal Simek
On 27.4.2018 09:55, Marc Kleine-Budde wrote: > On 04/27/2018 09:49 AM, Michal Simek wrote: >> On 26.4.2018 23:13, Luc Van Oostenryck wrote: >>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', >>> which is a typedef for an enum type, but

Re: [RFC PATCH 1/3] of: base: Introduce of_alias_check_id() to check alias IDs

2018-04-27 Thread Michal Simek
On 27.4.2018 15:02, Rob Herring wrote: > On Fri, Apr 27, 2018 at 1:10 AM, Michal Simek wrote: >> On 27.4.2018 04:39, Rob Herring wrote: >>> On Thu, Apr 26, 2018 at 9:08 AM, Michal Simek >>> wrote: >>>> The function travers the lookup table to check if

[PATCH] dt-bindings: Add vendor prefix for Avnet, Inc.

2018-05-02 Thread Michal Simek
"Avnet, Inc. is one of the world's largest distributors of electronic components and embedded solutions." - Wikipedia.org Website: www.avnet.com Signed-off-by: Michal Simek --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-02 Thread Michal Simek
On 2.5.2018 12:10, Linus Walleij wrote: > On Thu, Apr 26, 2018 at 3:35 PM, Michal Simek wrote: > >>> The only use case which I can think about is userspace sysfs >>> and then I would really like to know why these userspace >>> users cannot use the character devi

[PATCH] arm64: zynqmp: Remove #address/#size-cells from gpio-keys

2018-05-02 Thread Michal Simek
dts reports incorrect usage of these properties in gpio-keys node. Warning (avoid_unnecessary_addr_size): /gpio-keys: unnecessary The patch is removing these useless properties. Signed-off-by: Michal Simek --- arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 -- arch/arm64/boot/dts

[PATCH] arm64: zynqmp: Add support for Avnet Ultra96 rev1 board

2018-05-02 Thread Michal Simek
Avnet Ultra96 rev1 board is commercialized Xilinx zcu100 revC/D internal board. The patch is reusing zcu100 revC files but changing model description and compatible strings which are used for example by libmraa. Signed-off-by: Michal Simek --- I choose this option because there are houndreds of

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-02 Thread Michal Simek
On 2.5.2018 15:01, Linus Walleij wrote: > On Wed, May 2, 2018 at 12:15 PM, Michal Simek wrote: >> On 2.5.2018 12:10, Linus Walleij wrote: >>> On Thu, Apr 26, 2018 at 3:35 PM, Michal Simek >>> wrote: > >>>> Yes, it is about legacy application which

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-02 Thread Michal Simek
On 2.5.2018 15:56, Linus Walleij wrote: > On Wed, May 2, 2018 at 3:41 PM, Michal Simek wrote: > >> If you don't want this patch I understand that and it will become just >> another soc vendor patch out of mainline. > > I don't really know what to do, so that

[RFC PATCH v2 4/6] serial: uartps: Move alias reading higher in probe()

2018-06-06 Thread Michal Simek
This cosmetic change is done only for having next patch much easier to read. Moving id setup higher in probe is not affecting any usage of this driver and it also simplify error path. Signed-off-by: Michal Simek --- Changes in v2: - new patch - it can be sent separately too drivers/tty/serial

[RFC PATCH v2 6/6] serial: uartps: Remove CDNS_UART_NR_PORTS macro

2018-06-06 Thread Michal Simek
yPS1 Signed-off-by: Michal Simek --- Changes in v2: - Register one uart_driver with unique minor at probe time This patch not done because id is not unique. This needs to be solved before this patch can be applied. In v1 I have created of_alias_check_id() for that. https://lkml.org/lkml/2018/4

[RFC PATCH v2 5/6] serial: uartps: Fill struct uart_driver in probe()

2018-06-06 Thread Michal Simek
This is preparation step for dynamic port allocation without CDNS_UART_NR_PORTS macro. Fill the structure only once at probe. Signed-off-by: Michal Simek --- Changes in v2: - new patch - it can be sent separately too drivers/tty/serial/xilinx_uartps.c | 22 ++ 1 file

[RFC PATCH v2 2/6] serial: uartps: Move register to probe based on run time detection

2018-06-06 Thread Michal Simek
Find out the highest serial alias and allocate that amount of structures/minor numbers to be able to handle all of them. Origin setting that there are two prealocated CDNS_UART_NR_PORTS is kept there. Signed-off-by: Michal Simek --- Changes in v2: - Remove nr field logic Discussed here: https

[RFC PATCH v2 3/6] serial: uartps: Do not use static struct uart_driver out of probe()

2018-06-06 Thread Michal Simek
cdns_uart_suspend()/resume() and remove() are using static reference to struct uart_driver. Assign this referece to private data structure as preparation step for dynamic struct uart_driver allocation. Signed-off-by: Michal Simek --- Changes in v2: - new patch - it can be sent separately too

[RFC PATCH v2 0/6] serial: uartps: Add run time support for more IPs than hardcoded 2

2018-06-06 Thread Michal Simek
be sent separately too - new patch - it can be sent separately too - new patch - it can be sent separately too - Register one uart_driver with unique minor at probe time Michal Simek (6): serial: uartps: Do not initialize field to zero again serial: uartps: Move register to probe based on

[RFC PATCH v2 1/6] serial: uartps: Do not initialize field to zero again

2018-06-06 Thread Michal Simek
Writing zero and NULLs to already initialized fields is not needed. Remove this additional writes. Signed-off-by: Michal Simek --- Changes in v2: - new patch - it can be sent separately too drivers/tty/serial/xilinx_uartps.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty

[PATCH] dt-bindings: Add bitmain vendor prefix

2018-06-06 Thread Michal Simek
Bitmain (https://www.bitmain.com) is a vendor of cryptocurrency hardware. Signed-off-by: Michal Simek --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree

[GIT PULL] arch/microblaze patches for 4.18-rc1

2018-06-07 Thread Michal Simek
1 - Fix simpleImage format generation - Remove earlyprintk support and replace it by earlycon -------- Michal Simek (1): microblaze: Fix simpleImage format generation Rob Herring (3): microblaze: remove unnecessary prom.h inclu

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-05-15 Thread Michal Simek
Hi Linus, On 2.5.2018 16:19, Michal Simek wrote: > On 2.5.2018 15:56, Linus Walleij wrote: >> On Wed, May 2, 2018 at 3:41 PM, Michal Simek wrote: >> >>> If you don't want this patch I understand that and it will become just >>> another soc vendor patch out

Re: [PATCH] can: xilinx: fix xcan_start_xmit()'s return type

2018-04-25 Thread Michal Simek
On 24.4.2018 15:16, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

[PATCH] earlycon: Remove hardcoded port->uartclk initialization in of_setup_earlycon

2018-04-25 Thread Michal Simek
There is no reason to initialize uartclk to BASE_BAUD * 16 for DT based systems. Signed-off-by: Michal Simek Tested-by: Matt Redfearn --- It looks like from history that portclk = BASE_BAUD * 16 was setup to get on calculation on x86 (divisor = 1) but it shouldn't be needed on DT based s

Re: [PATCH v1 0/2] microblaze/PCI: Remove unused code

2018-04-26 Thread Michal Simek
urce claim issues. Or it's fine if >> you pick them up. > > I applied these to pci/microblaze for v4.17. If you pick them up, > Michal, I'll drop them; just let me know. Not a problem with it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3

Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-04-26 Thread Michal Simek
Hi Linus, On 26.4.2018 15:08, Linus Walleij wrote: > On Wed, Apr 11, 2018 at 3:55 PM, Michal Simek wrote: > > Thanks for your patch! > >> In past Xilinx gpio-zynq driver was setting up gpio chip->base as 0 >> which was chagned to autodetection when driver was u

[RFC PATCH 2/3] serial: uartps: Move register to probe based on run time detection

2018-04-26 Thread Michal Simek
Find out the highest serial alias and allocate that amount of structures/minor numbers to be able to handle all of them. Origin setting that there are two prealocated CDNS_UART_NR_PORTS is kept there. Signed-off-by: Michal Simek --- Discussed here: https://patchwork.kernel.org/patch/9738445

[RFC PATCH 0/3] serial: uartps: Add run time support for more IPs than hardcoded 2

2018-04-26 Thread Michal Simek
uartps ff01.serial: Selected ID 1 allocation passed [0.177149] ff01.serial: ttyPS1 at MMIO 0xff01 (irq = 34, base_baud = 625) is a xuartps Thanks, Michal Michal Simek (3): of: base: Introduce of_alias_check_id() to check alias IDs serial: uartps: Move register to probe based on

[RFC PATCH 1/3] of: base: Introduce of_alias_check_id() to check alias IDs

2018-04-26 Thread Michal Simek
The function travers the lookup table to check if the request alias id is compatible with the device driver match structure. This function will be used by serial drivers to check if requested alias is allocated or free to use. Signed-off-by: Michal Simek --- drivers/of/base.c | 49

[RFC PATCH 3/3] serial: uartps: Change uart ports allocation

2018-04-26 Thread Michal Simek
;t need to be probed. of_alias_check_id() does that test. If alias pointing to different not compatible IP, it is free to use. Signed-off-by: Michal Simek --- drivers/tty/serial/xilinx_uartps.c | 96 ++ 1 file changed, 85 insertions(+), 11 deletions(-) diff --git a/d

Re: [PATCH] firmware: xilinx: fix debugfs write handler

2019-02-28 Thread Michal Simek
On 18. 02. 19 22:43, Jann Horn wrote: > - Userspace wants to write a string with `len` bytes, not counting the >terminating NULL, so we should allocate `len+1` bytes. It looks like the >current code relied on having a nullbyte directly behind `kern_buff`, >which happens to work reliabl

Re: [PATCH] clocksource: cadence_ttc: fix memory leak in ttc_setup_clockevent

2019-03-13 Thread Michal Simek
On 09. 03. 19 15:24, Daniel Lezcano wrote: > > Hi Yue, > > I appreciate the fix but usually we add a rollback for all the > operations done in the init function. > > Please, migrate the init function to the timer-of API, so the rollback > will be automatically handled. > > Example here: > > ht

[GIT PULL] arch/microblaze patches for 5.1-rc1

2019-03-14 Thread Michal Simek
initialization Greg Kroah-Hartman (1): microblaze: no need to check return value of debugfs_create functions arch/microblaze/kernel/setup.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) -- Michal Simek

Re: [PATCH v2 1/3] firmware: xilinx: Add zynqmp_pm_get_chipid() API

2019-02-05 Thread Michal Simek
Hi, On 03. 02. 19 9:50, Srinivas Kandagatla wrote: > Hi Kishore, > > I need ack for this patch from Michal Simek to take this via nvmem tree. not sure if my reaction went through. Just for a record. There is high chance that there is collision in firmware interface. It means if yo

Re: [PATCH v2 1/3] firmware: xilinx: Add zynqmp_pm_get_chipid() API

2019-02-05 Thread Michal Simek
On 05. 02. 19 11:33, Srinivas Kandagatla wrote: > > > On 05/02/2019 10:29, Michal Simek wrote: >> Hi, >> >> On 03. 02. 19 9:50, Srinivas Kandagatla wrote: >>> Hi Kishore, >>> >>> I need ack for this patch from Michal Simek to take this via

Re: [PATCH v3 0/3] Add nvmem driver support for ZynqMP

2019-02-05 Thread Michal Simek
On 06. 02. 19 12:07, Nava kishore Manne wrote: > Nava kishore Manne (3): > firmware: xilinx: Add zynqmp_pm_get_chipid() API > dt-bindings: nvmem: Add bindings for ZynqMP nvmem driver > nvmem: zynqmp: Added zynqmp nvmem firmware driver > > .../bindings/nvmem/xlnx,zynqmp-nvmem.txt | 47 +

Re: [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on

2019-01-25 Thread Michal Simek
On 24. 01. 19 9:28, Jan Kiszka wrote: > From: Jan Kiszka > > Somewhere along recent changes to power control of the wl1831, power-on > became very unreliable on the Ultra96, failing like this: > > wl1271_sdio: probe of mmc2:0001:1 failed with error -16 > wl1271_sdio: probe of mmc2:0001:2 failed

Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

2019-04-03 Thread Michal Simek
rce(&pdev->dev, res); > + a = devm_platform_ioremap_resource(pdev, index); > > Cc: Joel Stanley > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Florian Fainelli > Cc: Linus Walleij > Cc: Baruch Siach > Cc: Keguang Zhang > Cc: Vladimir Zapolskiy > Cc:

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Michal Simek
On 08. 04. 19 16:17, Alan Tull wrote: > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne wrote: >> >> Hi Alan, >> >> Thanks for look into it and providing the ACK. >> I got one minor comments from Moritz Fischer do you want me fix that issue >> now or I can fix it later as it’s a minor comment?

Re: [PATCH v4 1/3] firmware: xilinx: Add fpga API's

2019-04-08 Thread Michal Simek
On 08. 04. 19 19:14, Moritz Fischer wrote: > Hi Nava, > > On Tue, Apr 02, 2019 at 06:01:21PM +0530, Nava kishore Manne wrote: >> This Patch Adds fpga API's to support the Bitstream loading >> by using firmware interface. >> >> Signed-off-by: Nava kishore Manne >> --- >> Changes for v4: >>

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Michal Simek
On 08. 04. 19 22:27, Alan Tull wrote: > On Mon, Apr 8, 2019 at 11:51 AM Moritz Fischer wrote: >> >> Hi Michal, >> >> On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: >>> On 08. 04. 19 16:17, Alan Tull wrote: >>>> On Mon,

Re: [PATCH 10/23] watchdog: of_xilinx_wdt: Convert to use device managed functions and other improvements

2019-04-09 Thread Michal Simek
m_add_action_or_reset() for calls to clk_disable_unprepare > - Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatedly > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Michal Simek > Signed-off-b

Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-27 Thread Michal Simek
On 21. 02. 19 12:03, Michal Simek wrote: > On 21. 02. 19 11:24, Paul Kocialkowski wrote: >> Hi, >> >> On Wed, 2019-02-20 at 07:58 +0100, Michal Simek wrote: >>> Hi, >>> >>> On 19. 02. 19 18:25, Andrew Lunn wrote: >>>>> Thanks f

Re: [PATCH 4/4] microblaze: Remove support for gcc < 4

2021-02-11 Thread Michal Simek
old_value, value); > -#endif > break; > > case R_MICROBLAZE_64_PCREL: > -#if __GNUC__ < 4 > - old_value = (location[0] & 0x) << 16 | > - (location[1] & 0xFFFF); > -

Re: [PATCH v2] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)

2021-02-12 Thread Michal Simek
On 2/12/21 12:23 AM, Nobuhiro Iwamatsu wrote: > zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: > xilinx: > Remove eemi ops for fpga related APIs", but not in > IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE). > Any driver who want to communicate with PMC using EEMI APIs use the f

Re: [PATCH] drivers: firmware: xilinx: Fix dereferencing freed memory

2021-02-12 Thread Michal Simek
/* > * Xilinx Zynq MPSoC Firmware layer > * > - * Copyright (C) 2014-2020 Xilinx, Inc. > + * Copyright (C) 2014-2021 Xilinx, Inc. > * > * Michal Simek > * Davorin Mista > @@ -1280,12 +1280,13 @@ static int zynqmp_firmware_probe(struct > platform_device *pdev) &

[GIT PULL] arch/microblaze patches for 5.12-rc1

2021-02-23 Thread Michal Simek
oblaze: Fix built-in DTB alignment to be 8-byte aligned arch/microblaze/Kconfig | 1 - arch/microblaze/kernel/module.c | 26 -- arch/microblaze/kernel/vmlinux.lds.S | 2 +- 3 files changed, 1 insertion(+), 28 deletions(-) -- Michal Simek, Ing. (M.Eng), O

Re: [PATCH v5 0/4] USB: misc: Add onboard_usb_hub driver

2021-02-24 Thread Michal Simek
Hi Matthias, On 2/10/21 6:10 PM, Matthias Kaehlcke wrote: > This series adds the onboard_usb_hub_driver, the corresponding > device tree bindings and creation of onboard_usb_hub platform in > the xhci-plat driver during probe(). > > The main issue the driver addresses is that a USB hub needs to b

Re: [PATCH v2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb5744 hub

2021-02-24 Thread Michal Simek
Hi Rob, On 2/11/21 3:42 PM, Rob Herring wrote: > On Thu, Feb 11, 2021 at 3:35 AM Michal Simek wrote: >> >> Hi Rob, >> >> On 2/10/21 11:22 PM, Rob Herring wrote: >>> On Tue, Feb 09, 2021 at 11:48:09AM +0100, Michal Simek wrote: >>>> From: Piyu

Re: [PATCH] dt-bindings: arm: xilinx: Add missing Zturn boards

2021-02-10 Thread Michal Simek
po 1. 2. 2021 v 14:16 odesílatel Michal Simek napsal: > > Add missing DT compatible strings for Zturn boards. > > Signed-off-by: Michal Simek > --- > > Patches are based on > https://lore.kernel.org/linux-arm-kernel/20210120194033.26970-3-mich...@walle.cc/ > ---

[PATCH v2] dt-bindings: spi: zynq: Convert Zynq QSPI binding to yaml

2021-02-10 Thread Michal Simek
Convert spi-zynq-qspi.txt to yaml. Signed-off-by: Michal Simek --- Changes in v2: - s/additionalProperties: true/unevaluatedProperties: false/ .../devicetree/bindings/spi/spi-zynq-qspi.txt | 25 .../bindings/spi/xlnx,zynq-qspi.yaml | 59 +++ MAINTAINERS

Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-10 Thread Michal Simek
Hi Andrew, On 2/10/21 3:52 AM, Andrew Lunn wrote: > On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: >> +static int usb5744_i2c_probe(struct i2c_client *client, >> + const struct i2c_device_id *id) >> +{ >> +struct device *dev

Re: [PATCH v2] dt-bindings: spi: zynq: Convert Zynq QSPI binding to yaml

2021-02-11 Thread Michal Simek
st 10. 2. 2021 v 11:10 odesílatel Michal Simek napsal: > > Convert spi-zynq-qspi.txt to yaml. > > Signed-off-by: Michal Simek > --- > > Changes in v2: > - s/additionalProperties: true/unevaluatedProperties: false/ > > .../devicetree/bindings/spi/spi-zynq-qspi.txt

Re: [PATCH v2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb5744 hub

2021-02-11 Thread Michal Simek
Hi Rob, On 2/10/21 11:22 PM, Rob Herring wrote: > On Tue, Feb 09, 2021 at 11:48:09AM +0100, Michal Simek wrote: >> From: Piyush Mehta >> >> Added dt binding for usb5744 driver. >> >> Signed-off-by: Piyush Mehta >> Signed-off-by: Michal Simek >> ---

Re: [PATCH] ARM: zynq: Update Copyright date in DTS

2021-02-11 Thread Michal Simek
po 1. 2. 2021 v 15:28 odesílatel Michal Simek napsal: > > Update years in header to be up2date. > > Signed-off-by: Michal Simek > --- > > arch/arm/boot/dts/zynq-7000.dtsi | 2 +- > arch/arm/boot/dts/zynq-cc108.dts | 2 +- > arch/arm/boot/dts/zynq-zc702.d

Re: [PATCH] ARM: zynq: Update Copyright date in DTS

2021-02-11 Thread Michal Simek
On 2/11/21 12:27 PM, Arnd Bergmann wrote: > On Mon, Feb 1, 2021 at 3:28 PM Michal Simek wrote: >> >> Update years in header to be up2date. >> >> Signed-off-by: Michal Simek > > I saw this in your pull request, and I did not think this was how > copyri

Re: [PATCH v2] dt-bindings: spi: zynq: Convert Zynq QSPI binding to yaml

2021-02-11 Thread Michal Simek
On 2/11/21 1:39 PM, Mark Brown wrote: > On Thu, Feb 11, 2021 at 10:37:30AM +0100, Michal Simek wrote: >> st 10. 2. 2021 v 11:10 odesílatel Michal Simek >> napsal: > >>> +description: >>> + The Xilinx Zynq QSPI controller is used to access multi-bi

Re: [PATCH] ARM: dts: ebaz4205: add pinctrl entries for switches

2021-02-02 Thread Michal Simek
On 2/1/21 2:30 PM, Michael Walle wrote: > Add the pinctrl entries for the GPIOs which are connected to the > push buttons on this board. > > Signed-off-by: Michael Walle > --- > arch/arm/boot/dts/zynq-ebaz4205.dts | 23 +++ > 1 file changed, 23 insertions(+) > > diff --gi

Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers

2021-02-02 Thread Michal Simek
On 2/1/21 6:41 PM, Rob Herring wrote: > On Mon, Feb 1, 2021 at 8:27 AM Michal Simek wrote: >> >> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version >> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC >> commit >> &

<    4   5   6   7   8   9   10   11   12   13   >