Re: [linux-sunxi] Re: [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Michal Suchanek
long enabling/disabling the clock took so more data can be collected from other systems. Signed-off-by: Michal Suchanek hramr...@gmail.com This is a big patch for just changing a timeout, most of this is in extra verbosity which IMHO has little value, in the error path w know we will have

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Michal Suchanek
On 12 August 2015 at 15:19, Olliver Schinagl oliver+l...@schinagl.nl wrote: Hey, On 12-08-15 14:35, Hans de Goede wrote: Hi, On 12-08-15 14:23, Michal Suchanek wrote: When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable automatic hardware controlled clock gating on the mmc

Re: [PATCH v4 7/7] mtd: spi-nor: add read loop

2015-08-14 Thread Michal Suchanek
On 14 August 2015 at 12:02, Andrew Murray amur...@embedded-bits.co.uk wrote: On 14 August 2015 at 10:23, Michal Suchanek hramr...@gmail.com wrote: mtdblock and ubi do not handle the situation when read returns less data than requested. Loop in spi-nor until buffer is filled or an error

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Michal Suchanek
On 27 July 2015 at 19:43, Marek Vasut ma...@denx.de wrote: On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: On 24 July 2015 at 10:34, Marek Vasut ma...@denx.de wrote: On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Ok, so here is some summary. I have a NOR

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-24 Thread Michal Suchanek
On 24 July 2015 at 10:34, Marek Vasut ma...@denx.de wrote: On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Hi! [...] It's probably slower to set up DMA for 2-byte commands but it might work nonetheless. It is, the overhead will be considerable. It might help

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Michal Suchanek
On 24 July 2015 at 10:34, Marek Vasut ma...@denx.de wrote: On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Hi! [...] It's probably slower to set up DMA for 2-byte commands but it might work nonetheless. It is, the overhead will be considerable. It might help

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 06:49, Vinod Koul vinod.k...@intel.com wrote: On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: Or alternatively we could publish the limitations of the channel using capabilities so SPI knows I have a dmaengine channel and it can transfer max N length

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 09:58, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: On 22 July 2015 at 09:33, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: On 22 July 2015 at 06:49, Vinod Koul

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 09:33, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: On 22 July 2015 at 06:49, Vinod Koul vinod.k...@intel.com wrote: On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: Or alternatively we could publish

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 10:24, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: On 22 July 2015 at 09:58, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: On 22 July 2015 at 09:33, Marek Vasut ma

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-23 Thread Michal Suchanek
On 22 July 2015 at 11:01, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: On 22 July 2015 at 10:24, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: On 22 July 2015 at 09:58, Marek Vasut ma

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-23 Thread Michal Suchanek
On 23 July 2015 at 18:46, Michal Suchanek hramr...@gmail.com wrote: On 22 July 2015 at 11:01, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: On 22 July 2015 at 10:24, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:18:04

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Michal Suchanek
On 4 June 2015 at 19:15, Richard Cochran richardcoch...@gmail.com wrote: On Thu, Jun 04, 2015 at 10:31:45AM +0200, Michal Suchanek wrote: You might want to try to run the bus at 60MHz or 80MHz and then the values would probably again be different. The first two values are set in DT so

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-19 Thread Michal Suchanek
Hello, On 15 July 2015 at 17:59, Brian Norris computersforpe...@gmail.com wrote: Hi Michal, On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: The problem is, if you add a new DT binding, you'd have to support it forever, no matter how bad idea that binding turned out to be.

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-21 Thread Michal Suchanek
Hello, On 21 July 2015 at 06:29, Vinod Koul vinod.k...@intel.com wrote: On Sun, Jul 19, 2015 at 09:01:34PM +0200, Michal Suchanek wrote: Hello, On 15 July 2015 at 17:59, Brian Norris computersforpe...@gmail.com wrote: Hi Michal, On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-03 Thread Michal Suchanek
On 3 November 2015 at 11:06, Vignesh R wrote: > In addition to providing direct access to SPI bus, some spi controller > hardwares (like ti-qspi) provide special memory mapped port > to accesses SPI flash devices in order to increase read performance. > This means the controller

Re: [PATCH 1/5] spi: introduce mmap read support for spi flash devices

2015-09-16 Thread Michal Suchanek
On 16 September 2015 at 14:46, Jagan Teki wrote: > On 15 September 2015 at 00:05, Mark Brown wrote: >> On Fri, Sep 04, 2015 at 04:55:33PM +0530, Jagan Teki wrote: >>> On 4 September 2015 at 13:59, Vignesh R wrote: >> >>> > + *

Re: Non-ascii mantainers

2015-12-02 Thread Michal Suchanek
On 1 December 2015 at 21:13, Andreas Mohr wrote: > Hi, > >> I don't really care if the maintainers are encoded or whatever. >> However, neither get_maintainers nor git format-patch encodes them and >> the listserver rejects them when not encoded. > > "neither ... nor" - IMHO

Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

2015-12-04 Thread Michal Suchanek
On 4 December 2015 at 15:30, Martin Sperl <mar...@sperl.org> wrote: > >> On 02.12.2015, at 00:12, Mark Brown <broo...@kernel.org> wrote: >> >> On Tue, Dec 01, 2015 at 04:51:06PM -, Michal Suchanek wrote: >> >>> +static inline size_t &

Re: Non-ascii mantainers

2015-12-07 Thread Michal Suchanek
On 7 December 2015 at 10:18, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Michael, > > On Tue, Dec 1, 2015 at 6:27 PM, Michal Suchanek <hramr...@gmail.com> wrote: >> On 1 December 2015 at 18:20, Al Viro <v...@zeniv.linux.org.uk> wrote: >>> On Tue

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-05 Thread Michal Suchanek
On 5 December 2015 at 11:15, Geert Uytterhoeven wrote: > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris > wrote: >> There have been several discussions [1] about adding a device tree binding >> for >> associating flash devices with the partition

Re: [RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding

2015-12-05 Thread Michal Suchanek
On 5 December 2015 at 12:39, Jonas Gorski wrote: > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris > wrote: >> + >> +Examples: >> + >> +flash@0 { >> + partitions { >> + compatible = "google,fmap"; >> + }; >> +}; > > I wonder

Non-ascii mantainers

2015-12-01 Thread Michal Suchanek
Hello, there are non-ascii characters in output of scripts/get_maintainer.pl If output of said script is used as --to in git format-patch the patch is rejected by this list. I am not sure if weeding out non-ascii maintainers is even feasible. scripts/get_maintainer.pl uses the MAINTAINERS file

Re: Non-ascii mantainers

2015-12-01 Thread Michal Suchanek
On 1 December 2015 at 18:20, Al Viro <v...@zeniv.linux.org.uk> wrote: > On Tue, Dec 01, 2015 at 06:10:29PM +0100, Michal Suchanek wrote: >> Hello, >> >> there are non-ascii characters in output of scripts/get_maintainer.pl >> >> If output of said scr

Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

2015-12-02 Thread Michal Suchanek
On 2 December 2015 at 00:12, Mark Brown <broo...@kernel.org> wrote: > On Tue, Dec 01, 2015 at 04:51:06PM -0000, Michal Suchanek wrote: > >> +static inline size_t >> +spi_max_transfer_size(struct spi_device *spi) >> +{ >> + struct spi_master *master

Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

2015-12-02 Thread Michal Suchanek
On 1 December 2015 at 20:58, Mark Brown <broo...@kernel.org> wrote: > On Tue, Dec 01, 2015 at 04:51:06PM -0000, Michal Suchanek wrote: >> On some SPI controllers it is not feasible to transfer arbitrary amount >> of data at once. >> >> When the limit on transfer

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-11 Thread Michal Suchanek
On 11 December 2015 at 09:44, Geert Uytterhoeven wrote: > Hi Brian, > > On Thu, Dec 10, 2015 at 9:54 PM, Brian Norris > wrote: >> On Sat, Dec 05, 2015 at 11:15:54AM +0100, Geert Uytterhoeven wrote: >>> On Sat, Dec 5, 2015 at 6:19 AM, Brian

Re: [RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding

2015-12-11 Thread Michal Suchanek
Hello, On 10 December 2015 at 21:43, Brian Norris <computersforpe...@gmail.com> wrote: > On Mon, Dec 07, 2015 at 12:36:28PM +1100, David Gibson wrote: >> On Sat, Dec 05, 2015 at 10:33:30PM +0100, Michal Suchanek wrote: >> > On 5 December 2015 at 12:39, Jonas Gorski

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-11 Thread Michal Suchanek
On 11 December 2015 at 17:00, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Michal, > > On Fri, Dec 11, 2015 at 4:34 PM, Michal Suchanek <hramr...@gmail.com> wrote: >> On 11 December 2015 at 09:44, Geert Uytterhoeven <ge...@linux-m68k.org> >> wro

Re: [RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding

2015-12-14 Thread Michal Suchanek
36:28PM +1100, David Gibson wrote: >>> > On Sat, Dec 05, 2015 at 10:33:30PM +0100, Michal Suchanek wrote: >>> > > On 5 December 2015 at 12:39, Jonas Gorski <j...@openwrt.org> wrote: >>> > > > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris >

Re: [PATCH v6 06/10] mtd: spi-nor: simplify write loop

2015-12-15 Thread Michal Suchanek
On 15 December 2015 at 21:22, Han Xu <han...@freescale.com> wrote: > On Wed, Dec 02, 2015 at 10:38:20AM +0000, Michal Suchanek wrote: >> The spi-nor write loop assumes that what is passed to the hardware >> driver write() is what gets written. >> >> When write() w

Re: [PATCH v4 6/7] mtd: spi-nor: simplify write loop

2015-11-20 Thread Michal Suchanek
On 20 November 2015 at 00:18, Brian Norris <computersforpe...@gmail.com> wrote: > Hi Michal, > > Sorry this has sat so long... > > On Fri, Aug 14, 2015 at 09:23:08AM -, Michal Suchanek wrote: >> The spi-nor write loop assumes that what is passed to the hardware >

Re: [PATCH v4 7/7] mtd: spi-nor: add read loop

2015-11-20 Thread Michal Suchanek
Hello, On 5 November 2015 at 04:39, Hou Zhiqiang wrote: > Hi Michal, > > Does this have any updates? I will try to update this patchset when it's agreed how the limit on transfer size is handled. Writing less data than was requested is acceptable for spi-nor but might

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-05 Thread Michal Suchanek
On 2 June 2016 at 16:26, Mark Brown <broo...@kernel.org> wrote: > On Thu, Jun 02, 2016 at 02:14:26PM +0200, Michal Suchanek wrote: >> On 2 June 2016 at 06:42, Priit Laes <pl...@plaes.org> wrote: >> > On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: > >>

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

2016-06-09 Thread Michal Suchanek
Hello, On 9 June 2016 at 18:20, Noralf Trønnes <nor...@tronnes.org> wrote: > > Den 09.06.2016 17:08, skrev Michal Suchanek: >> >> txbuflen can be set to arbitrary value by user and it is also set >> automagically to the maximum transfer size of the SPI m

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-14 Thread Michal Suchanek
Hello, On 14 June 2016 at 07:45, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Tue, Jun 14, 2016 at 3:28 PM, Michal Suchanek <hramr...@gmail.com> wrote: >> On 14 June 2016 at 06:47, Julian Calaby <julian.cal...@gmail.com> wrote: >>&g

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-13 Thread Michal Suchanek
On 14 June 2016 at 06:47, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Tue, Jun 14, 2016 at 2:34 PM, Michal Suchanek <hramr...@gmail.com> wrote: >> Hello, >> >> On 14 June 2016 at 01:43, Julian Calaby <julian.cal...@gmail.com>

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-13 Thread Michal Suchanek
Hello, On 14 June 2016 at 01:43, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Tue, Jun 14, 2016 at 3:46 AM, Michal Suchanek <hramr...@gmail.com> wrote: >> The drivers are very similar and share multiple flaws which needed >> separate fixes f

Re: [linux-sunxi] [PATCH v3 11/13] dt: spi: sun4i: merge sun4i and sun6i binding doc

2016-06-13 Thread Michal Suchanek
On 14 June 2016 at 01:45, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Tue, Jun 14, 2016 at 3:46 AM, Michal Suchanek <hramr...@gmail.com> wrote: >> Signed-off-by: Michal Suchanek <hramr...@gmail.com> >> --- >> .../device

Re: [linux-sunxi] [PATCH v3 07/13] spi: sunxi: rename constants to match between sun4i and sun6i

2016-06-13 Thread Michal Suchanek
Hello, On 14 June 2016 at 01:31, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Tue, Jun 14, 2016 at 3:46 AM, Michal Suchanek <hramr...@gmail.com> wrote: >> SUNXI_CTL_ -> SUNXI_TFR_CTL_ >> SUNXI_TFR_CTL_LMTF -> SUNXI_TFR_CTL_F

Re: [PATCH v3 00/13] sunxi spi fixes

2016-06-13 Thread Michal Suchanek
Hello, On 13 June 2016 at 21:57, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Mon, Jun 13, 2016 at 05:46:48PM -0000, Michal Suchanek wrote: >> Hello, >> >> This is update of the sunxi spi patches that should give full-featured SPI >> driver. >

Re: [PATCH 3/5] spi: sunxi: expose maximum transfer size limit

2016-05-30 Thread Michal Suchanek
Hello, On 30 May 2016 at 10:37, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, May 26, 2016 at 07:25:24PM -0000, Michal Suchanek wrote: >> The sun4i spi hardware can trasfer at most 63 bytes of data without DMA >> support so report the limi

Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Michal Suchanek
Hello, On 30 May 2016 at 17:03, Mark Brown <broo...@kernel.org> wrote: > On Mon, May 30, 2016 at 02:11:51PM +0200, Geert Uytterhoeven wrote: >> On Mon, May 30, 2016 at 1:26 PM, Mark Brown <broo...@kernel.org> wrote: >> > On Thu, May 26, 2016 at 07:25:25P

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-02 Thread Michal Suchanek
On 2 June 2016 at 06:42, Priit Laes <pl...@plaes.org> wrote: > On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: >> Hi, >> >> On Mon, May 30, 2016 at 04:50:16PM +0100, Mark Brown wrote: >> > >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal

[PATCH] usb: select NOP_USB_XCEIV by drivers that require it

2016-05-26 Thread Michal Suchanek
nse that there is no actual piece of hardware you can point at and say you did not include driver for this so it won't work. So just change all depends on it to select. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/usb/chipidea/Kconfig | 3 ++- drivers/usb/musb/Kconfig

Re: [PATCH v7 00/10] Add error checking to spi-nor read and write

2016-05-26 Thread Michal Suchanek
Hello, On 18 May 2016 at 03:24, Brian Norris <computersforpe...@gmail.com> wrote: > On Mon, May 16, 2016 at 09:47:20PM +0200, Michal Suchanek wrote: >> Hello, >> >> On 6 May 2016 at 02:31, Brian Norris <computersforpe...@gmail.com> wrote: >> > Hi, &

[PATCH] fbtft: limit transfer length by spi device limit

2016-05-26 Thread Michal Suchanek
Some SPI controllers can transfer only small piece of data at a time. Since SPI core gained a function to get the maximum transfer length use it. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- Tested on sunxi spi with DMA enabled and disabled. Makes a visible speed diff

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-26 Thread Michal Suchanek
On 27 May 2016 at 04:05, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Michal, > > On Fri, May 27, 2016 at 5:25 AM, Michal Suchanek <hramr...@gmail.com> wrote: >> The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over >> 1MHz SPI bus take

Re: [PATCH] usb: select NOP_USB_XCEIV by drivers that require it

2016-05-26 Thread Michal Suchanek
On 27 May 2016 at 05:41, Peter Chen <hzpeterc...@gmail.com> wrote: > On Thu, May 26, 2016 at 07:25:23PM -0000, Michal Suchanek wrote: >> Hello, >> >> I was updating my config by make oldconfig for a while and noticed that my >> USB >> OTG controller is not

Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-31 Thread Michal Suchanek
On 30 May 2016 at 17:50, Mark Brown <broo...@kernel.org> wrote: > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: >> On 30 May 2016 at 17:03, Mark Brown <broo...@kernel.org> wrote: > >> > I really don't think it's worth caring too much about cases

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-31 Thread Michal Suchanek
Hello On 30 May 2016 at 13:23, Mark Brown <broo...@kernel.org> wrote: > On Fri, May 27, 2016 at 03:10:11PM +1000, Julian Calaby wrote: >> On Fri, May 27, 2016 at 3:05 PM, Michal Suchanek <hramr...@gmail.com> wrote: > >> >> Also, should the changes for the dri

Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-31 Thread Michal Suchanek
On 31 May 2016 at 15:27, Mark Brown <broo...@kernel.org> wrote: > On Tue, May 31, 2016 at 12:44:54PM +0200, Michal Suchanek wrote: >> On 30 May 2016 at 17:50, Mark Brown <broo...@kernel.org> wrote: >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote

Re: [PATCH v3 00/13] sunxi spi fixes

2016-06-17 Thread Michal Suchanek
Hello, On 13 June 2016 at 21:57, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Mon, Jun 13, 2016 at 05:46:48PM -0000, Michal Suchanek wrote: >> Hello, >> >> This is update of the sunxi spi patches that should give full-featured SPI >> driver. >

[PATCH 0/3] Another stab at making spidev usable with devicetree

2016-06-24 Thread Michal Suchanek
Hello, This small patchset makes it possible to bind spidev manually to any SPI slave without much hassle. Thanks Michal Michal Suchanek (3): spi: spidev: fix the check for spidev in dt spi: of: allow instantiating slaves without a driver drivers core: allow id match override when

[PATCH 1/3] spi: spidev: fix the check for spidev in dt

2016-06-24 Thread Michal Suchanek
with ! CONFIG_OF since the id table which the code checks is not compiled then. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/spi/spidev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index e3c19f3..8045baf

[PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-24 Thread Michal Suchanek
SPI slave devices are not created when looking up driver for the slave fails. Create a device anyway so it can be manually bound to a driver. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/spi/spi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

[PATCH 3/3] drivers core: allow id match override when manually binding driver

2016-06-24 Thread Michal Suchanek
-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/base/Kconfig.debug | 14 + drivers/base/bus.c | 72 +- lib/Kconfig.debug | 2 ++ 3 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 driver

Re: [PATCH 7/9] mtd: m25p80: add support of dual and quad spi protocols to all commands

2016-06-23 Thread Michal Suchanek
Hello, this patch is kind of awesome. I have a few practical concerns however. On 20 June 2016 at 18:50, Cyrille Pitchen wrote: > Before this patch, m25p80_read() supported few SPI protocols: > - regular SPI 1-1-1 > - SPI Dual Output 1-1-2 > - SPI Quad Output 1-1-4 >

Re: [PATCH 7/9] mtd: m25p80: add support of dual and quad spi protocols to all commands

2016-06-23 Thread Michal Suchanek
On 24 June 2016 at 00:14, Marek Vasut <ma...@denx.de> wrote: > On 06/23/2016 11:58 PM, Michal Suchanek wrote: >> On 23 June 2016 at 22:46, Marek Vasut <ma...@denx.de> wrote: >>> On 06/23/2016 10:35 PM, Michal Suchanek wrote: >>>> Hello, >>

Re: [PATCH 7/9] mtd: m25p80: add support of dual and quad spi protocols to all commands

2016-06-23 Thread Michal Suchanek
On 23 June 2016 at 22:46, Marek Vasut <ma...@denx.de> wrote: > On 06/23/2016 10:35 PM, Michal Suchanek wrote: >> Hello, > > Hi, > >> this patch is kind of awesome. >> >> I have a few practical concerns however. >> >> On 20 June 2016 at 18

Re: [PATCH 7/9] mtd: m25p80: add support of dual and quad spi protocols to all commands

2016-06-23 Thread Michal Suchanek
On 24 June 2016 at 00:50, Marek Vasut <ma...@denx.de> wrote: > On 06/24/2016 12:43 AM, Michal Suchanek wrote: >> On 24 June 2016 at 00:14, Marek Vasut <ma...@denx.de> wrote: >>> On 06/23/2016 11:58 PM, Michal Suchanek wrote: >>>> On 23 June 2016 a

[PATCH v2 3/3] drivers core: allow id match override when manually binding driver

2016-06-27 Thread Michal Suchanek
les or any other needless complication. Note that any slave driver that requires configuration will fail to probe anyway if the configuration is not provided in the devicetree node. A driver like spidev that requires no configuration can bind to any slave. Signed-off-by: Michal Suchanek <

[PATCH v2 2/3] spi: of: allow instantiating slaves without a driver

2016-06-27 Thread Michal Suchanek
and the slave driver can try to set arbitrary transfer speed. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/spi/spi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0239b45..9b3b512 100644 --- a/drivers/spi

Re: [PATCH v2 3/3] drivers core: allow id match override when manually binding driver

2016-06-27 Thread Michal Suchanek
On 27 June 2016 at 21:09, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Mon, Jun 27, 2016 at 09:02:32PM +0200, Michal Suchanek wrote: >> The spi bus has no autodetection whatsoever. The 'detection' of the >> device that's suposed to be on the other side comp

[PATCH v2 1/3] spi: spidev: fix the check for spidev in dt

2016-06-27 Thread Michal Suchanek
some other random compatible which is not "spidev". Also the spidev id match table is not compiled when !CONFIG_OF So add a match table that has just "spidev" entry in it so it can reliably detect what this message is supposed to warn about. Signed-off-by: Michal Suchanek &

[PATCH v2 0/3] Updated spidev usability patchset

2016-06-27 Thread Michal Suchanek
This hopefully addresses pretty much all the comments on the previous version. Thanks Michal Michal Suchanek (3): spi: spidev: fix the check for spidev in dt spi: of: allow instantiating slaves without a driver drivers core: allow id match override when manually binding driver drivers

Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-26 Thread Michal Suchanek
On 26 June 2016 at 14:45, Mark Brown <broo...@kernel.org> wrote: > On Sun, Jun 26, 2016 at 02:39:20PM +0200, Michal Suchanek wrote: >> On 26 June 2016 at 13:58, Mark Brown <broo...@kernel.org> wrote: > >> > No, there's a lot more to having overlays to board-

Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-26 Thread Michal Suchanek
On 26 June 2016 at 13:21, Mark Brown <broo...@kernel.org> wrote: > On Sun, Jun 26, 2016 at 04:23:41AM +0200, Michal Suchanek wrote: >> On 26 June 2016 at 03:15, Mark Brown <broo...@kernel.org> wrote: > >> > I can't relate this hunk to the changelog and th

Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-26 Thread Michal Suchanek
On 26 June 2016 at 13:58, Mark Brown <broo...@kernel.org> wrote: > On Sun, Jun 26, 2016 at 01:35:46PM +0200, Michal Suchanek wrote: >> On 26 June 2016 at 13:21, Mark Brown <broo...@kernel.org> wrote: > >> > You can just add the entire slave node in the overlay, i

Re: [PATCH 1/3] spi: spidev: fix the check for spidev in dt

2016-06-25 Thread Michal Suchanek
On 26 June 2016 at 03:09, Mark Brown <broo...@kernel.org> wrote: > On Fri, Jun 24, 2016 at 04:20:32PM +0200, Michal Suchanek wrote: > >> The check is supposed to warn about spidev specified directly in >> devicetree as compatible. This just does not work. I have a devicetr

Re: [PATCH 1/3] spi: spidev: fix the check for spidev in dt

2016-06-25 Thread Michal Suchanek
On 26 June 2016 at 03:13, Mark Brown <broo...@kernel.org> wrote: > On Thu, Jun 23, 2016 at 05:41:19PM -0000, Michal Suchanek wrote: > >> The check is supposed to warn about spidev specified directly in >> devicetree as compatible. This just does not work. I have a devicetr

Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-25 Thread Michal Suchanek
On 26 June 2016 at 03:15, Mark Brown <broo...@kernel.org> wrote: > On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote: >> SPI slave devices are not created when looking up driver for the slave >> fails. Create a device anyway so it can be manually bound to a dri

Re: [PATCH 3/3] drivers core: allow id match override when manually binding driver

2016-06-26 Thread Michal Suchanek
Hello, On 26 June 2016 at 06:14, Dan Williams <dan.j.willi...@intel.com> wrote: > On Thu, Jun 23, 2016 at 10:41 AM, Michal Suchanek <hramr...@gmail.com> wrote: >> This allows binding spidev on any slave device by hand using sysfs >> without adding superfluous compat

Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver

2016-06-26 Thread Michal Suchanek
On 26 June 2016 at 14:57, Mark Brown <broo...@kernel.org> wrote: > On Sun, Jun 26, 2016 at 02:53:31PM +0200, Michal Suchanek wrote: >> On 26 June 2016 at 14:45, Mark Brown <broo...@kernel.org> wrote: > >> > No, there's other things like figuring out which con

Re: [PATCH 3/3] drivers core: allow id match override when manually binding driver

2016-06-26 Thread Michal Suchanek
On 26 June 2016 at 20:28, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote: >> This allows binding spidev on any slave device by hand using sysfs >> without adding superfluous compatibles or any other nee

[PATCH 2/2] of: fdt: mark unflattened tree as detached

2016-06-26 Thread Michal Suchanek
The tree returned from of_fdt_unflatten_tree cannot be attached to the live tree because it is not marked as detached so mark it as such. The dt resolver checks the flag and refuses to process the tree otherwise. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/of/fdt.

[PATCH 1/2] of: overlay: add resolver error prints

2016-06-26 Thread Michal Suchanek
Applying overlay fails silently in case of an error. Add error prints. Most notably the lack of symbols in the live tree is not reported. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/of/resolver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/of/reso

[PATCH 0/2] devicetree overlay small fixes

2016-06-26 Thread Michal Suchanek
Hello, while testing overlay loading I found some issues with applying the overlay. I sent these like a year ago already. One was since fixed but two still apply. Thanks Michal Michal Suchanek (2): of: overlay: add resolver error prints of: fdt: mark unflattened tree as detached drivers

Exynos Snow board display regression

2016-01-29 Thread Michal Suchanek
Hello, after commit a9fa852886fd5a7ccec3b7e9eff75f85072f009c display no longer works on the Snow board. The built-in panel is no longer probed. The commit *supposedly* provides for backwards compatibility and at first glance only new options for probing the panel are added. However, reverting

Re: Exynos Snow board display regression

2016-01-29 Thread Michal Suchanek
On 29 January 2016 at 18:18, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Hello Michal, > > On 01/29/2016 02:07 PM, Michal Suchanek wrote: >> >> Hello, >> >> after commit a9fa852886fd5a7ccec3b7e9eff75f85072f009c >> >> display no

Re: [PATCH 1/2] spi: sun4i: add DMA support

2016-02-26 Thread Michal Suchanek
t; sun4i SPI controller. Said transfers will be performed via DMA. >> >> Signed-off-by: Emilio López <emi...@elopez.com.ar> >> Tested-by: Michal Suchanek <hramr...@gmail.com> >> Tested-by: Priit Laes <pl...@plaes.org> >> --- > > You *must* sig

Re: [PATCH 1/2] spi: sun4i: add DMA support

2016-03-10 Thread Michal Suchanek
Hello, On 6 March 2016 at 22:42, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Feb 26, 2016 at 01:51:51PM +0100, Michal Suchanek wrote: >> Besides this non-technical objection there were multiple technical >> objections. >> >> IIRC one wa

Re: [PATCH 1/2] spi: sun4i: add DMA support

2016-03-19 Thread Michal Suchanek
On 17 March 2016 at 12:43, Mark Brown <broo...@kernel.org> wrote: > On Thu, Mar 17, 2016 at 11:58:05AM +0100, Michal Suchanek wrote: >> On 17 March 2016 at 08:27, Maxime Ripard > >> > You're mixing two things up: the fact that we can't do more than the >> &g

Re: [PATCH 1/2] spi: sun4i: add DMA support

2016-03-19 Thread Michal Suchanek
On 17 March 2016 at 08:27, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, Mar 10, 2016 at 10:01:04AM +0100, Michal Suchanek wrote: >> Hello, >> >> On 6 March 2016 at 22:42, Maxime Ripard >> <maxime.rip...@free-electrons.com> wrote: >&g

Re: sunxi spi clock problem

2016-05-22 Thread Michal Suchanek
, Chen-Yu Tsai <w...@csie.org> wrote: > Hi, > > On Sun, May 22, 2016 at 10:18 PM, Michal Suchanek <hramr...@gmail.com> wrote: >> Hello, >> >> I tried running a spidev test program on linux 4.6 and I uncovered a >> problem with the sunxi clk framework. &

sunxi spi clock problem

2016-05-22 Thread Michal Suchanek
Hello, I tried running a spidev test program on linux 4.6 and I uncovered a problem with the sunxi clk framework. Basically the system would lock up after running the test program. Digging deeper I found that it locks up with commit [47284e3e0f3c427c93f8583549b6c938e8a18015] spi: sun4i: allow

Re: sunxi spi clock problem

2016-05-22 Thread Michal Suchanek
On 22 May 2016 at 18:41, Michal Suchanek <hramr...@gmail.com> wrote: > Hello, > > The debugfs output shows that spi2 is reparented under pll5 and the > pll5 frequency remains unchanged. > > The request to get a 2GHz clock for spi is fulfilled on best-effort > basis by g

Re: [PATCH v7 00/10] Add error checking to spi-nor read and write

2016-05-16 Thread Michal Suchanek
Hello, On 6 May 2016 at 02:31, Brian Norris wrote: > Hi, > > I'm picking up Michal's patch set, since he dropped it on the floor, and it's > useful for others. My additions: > > * rebased on latest > * added fixes for drivers that have been merged in the meantime >

Re: [linux-sunxi] Re: [PATCH 4/9] spi: sun4i: add DMA support

2016-05-16 Thread Michal Suchanek
On 20 August 2015 at 16:56, Maxime Ripard wrote: >> + /* Enable Dedicated DMA requests */ >> + reg = sun4i_spi_read(sspi, SUN4I_CTL_REG); >> + reg |= SUN4I_CTL_DMAMC_DEDICATED; >> + sun4i_spi_write(sspi,

Re: [RESEND][PATCH] mtd: devices: m25p80: add support for mmap read request

2016-05-18 Thread Michal Suchanek
Hello, On 29 March 2016 at 07:46, Vignesh R wrote: > Certain SPI controllers may provide accelerated hardware interface to > read from m25p80 type flash devices in order to provide better read > performance. SPI core supports such devices with spi_flash_read() API. > Call

Re: [RESEND][PATCH] mtd: devices: m25p80: add support for mmap read request

2016-05-18 Thread Michal Suchanek
On 18 May 2016 at 11:39, Vignesh R <vigne...@ti.com> wrote: > Hi, > > On 05/18/2016 02:53 PM, Michal Suchanek wrote: >> Hello, > [...] >>> >>> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >>> index c9c3b7fa3051..7730e63

Re: [PATCH v3 00/13] sunxi spi fixes

2016-07-25 Thread Michal Suchanek
Hello, On 25 July 2016 at 09:32, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Jun 17, 2016 at 12:34:44PM +0200, Michal Suchanek wrote: >> Hello, >> >> On 13 June 2016 at 21:57, Maxime Ripard >> <maxime.rip...@free-electrons.com> wrote:

Re: [PATCH v3 00/13] sunxi spi fixes

2016-07-30 Thread Michal Suchanek
On 29 July 2016 at 22:22, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Mon, Jul 25, 2016 at 10:03:14AM +0200, Michal Suchanek wrote: >> Hello, >> >> On 25 July 2016 at 09:32, Maxime Ripard >> <maxime.rip...@free-electrons.com> wrote: >&g

Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver

2016-07-30 Thread Michal Suchanek
On 19 July 2016 at 12:52, Mark Brown <broo...@kernel.org> wrote: > On Tue, Jul 19, 2016 at 10:31:54AM +0200, Michal Suchanek wrote: >> On 19 July 2016 at 01:02, Mark Brown <broo...@kernel.org> wrote: >> > On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wr

[PATCH] of: fdt: mark unflattened tree as detached

2016-07-18 Thread Michal Suchanek
The tree returned from of_fdt_unflatten_tree cannot be attached to the live tree because it is not marked as detached so mark it as such. The dt resolver checks the flag and refuses to process the tree otherwise. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- - rebase on top of

[PATCH v3 3/3] spi: core: allow creating devices without spi-max-frequency

2016-07-18 Thread Michal Suchanek
Since the previous patch allows creating SPI slaves without specifying what device the CS connects to make spi-max-frequency also optional. The spi-max-frequency is device-specific and the driver can set it anyway. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/spi/spi

[PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves.

2016-07-18 Thread Michal Suchanek
provide interface backwards compatible with existing spidev tools. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- Documentation/spi/spidev | 40 ++--- drivers/spi/Kconfig | 2 +- drivers/spi/spi.c| 19 ++- drivers/spi/spidev.c

[PATCH v3 0/3] Spidev usability patchset update

2016-07-18 Thread Michal Suchanek
is not bound to start with or from which it is unbound is accessible with spidev. Constructive comments on improving this patchset are welcome. Thanks Michal Michal Suchanek (3): spi: spidev: create spidev device for all spi slaves. spi: of: allow instantiating slaves without a driver spi

[PATCH v3 2/3] spi: of: allow instantiating slaves without a driver

2016-07-18 Thread Michal Suchanek
SPI slave devices are not created when looking up driver for the slave fails. Create a device anyway so it can be used with spidev. Signed-off-by: Michal Suchanek <hramr...@gmail.com> --- drivers/spi/spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spi/s

Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver

2016-07-19 Thread Michal Suchanek
Hello, On 19 July 2016 at 01:02, Mark Brown <broo...@kernel.org> wrote: > On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wrote: >> SPI slave devices are not created when looking up driver for the slave >> fails. Create a device anyway so it can be used with

<    1   2   3   4   5   6   7   8   >