[PATCH v2] Bugfix for handling of shadow doorbell buffer.

. Fixes: f9f38e33389c (“nvme: improve performance for virtual NVMe devices”) Signed-off-by: Michal Wnukowski changes since v1: - Additional note about NVMe controller behavior. - Removal of volatile keyword has been reverted. --- drivers/nvme/host/pci.c | 8 1 file changed, 8 insertions

[PATCH] Bugfix for handling of shadow doorbell buffer.

-off-by: Michal Wnukowski --- drivers/nvme/host/pci.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 17a0190bd88f..091c2441b6fa 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -292,7 +292,7

Re: [PATCH] Bugfix for handling of shadow doorbell buffer.

On 08/14/2018 04:16 PM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 03:17:35PM -0700, Michal Wnukowski wrote: >> >> With memory barrier in place, the volatile keyword around *dbbuf_ei is >> redundant. > > No. The memory barrier enforces _orderi

Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

Thanks for applying and improving the comments. All still makes sense. I will forward this patch to sta...@vger.kernel.org once it get merged into Linus’ tree. On 08/17/2018 12:07 AM, Christoph Hellwig wrote: > I've applied this with some major updates to the subject, changelog > and the comment

Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

Thanks for applying and improving the comments. All still makes sense. I will forward this patch to sta...@vger.kernel.org once it get merged into Linus’ tree. On 08/17/2018 12:07 AM, Christoph Hellwig wrote: > I've applied this with some major updates to the subject, changelog > and the comment

[PATCH] Bugfix for handling of shadow doorbell buffer.

-off-by: Michal Wnukowski --- drivers/nvme/host/pci.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 17a0190bd88f..091c2441b6fa 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -292,7 +292,7

Re: [PATCH] Bugfix for handling of shadow doorbell buffer.

On 08/14/2018 04:16 PM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 03:17:35PM -0700, Michal Wnukowski wrote: >> >> With memory barrier in place, the volatile keyword around *dbbuf_ei is >> redundant. > > No. The memory barrier enforces _orderi

[PATCH v2] Bugfix for handling of shadow doorbell buffer.

. Fixes: f9f38e33389c (“nvme: improve performance for virtual NVMe devices”) Signed-off-by: Michal Wnukowski changes since v1: - Additional note about NVMe controller behavior. - Removal of volatile keyword has been reverted. --- drivers/nvme/host/pci.c | 8 1 file changed, 8 insertions