Re: [PATCH v4 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-28 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 11:03:26AM +0100, Rafael J. Wysocki wrote: > On Thursday, November 22, 2012 10:43:28 AM Linus Walleij wrote: > > On Wed, Nov 21, 2012 at 10:31 PM, Rafael J. Wysocki wrote: > > > > > This patchset has been around for quite a while and went through a few > > > iterations, so

[PATCH 3/7] i2c-designware-pci: use managed functions pcim_* and devm_*

2013-03-21 Thread Mika Westerberg
From: Andy Shevchenko This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-pcidrv.c | 68

[PATCH 7/7] i2c-designware: switch to use runtime PM autosuspend

2013-03-21 Thread Mika Westerberg
Using autosuspend helps to reduce the resume latency in situations where another I2C message is going to be started soon. For example with HID over I2C touch panels we get several messages in a short period of time while the touch panel is in use. Signed-off-by: Mika Westerberg --- drivers/i2c

[PATCH 2/7] i2c-designware-pci: use dev_err() instead of printk()

2013-03-21 Thread Mika Westerberg
From: Andy Shevchenko With dev_err() we can get the device instance printed as well and is pretty much standard to use dev_* macros in drivers anyway. In addition correct indentation of probe() arguments. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- drivers/i2c/busses

[PATCH 4/7] i2c-designware: use dynamic adapter numbering on Lynxpoint

2013-03-21 Thread Mika Westerberg
numbering on Intel Lynxpoint. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-platdrv.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index c19c4ce..a22a852 100644 --- a

[PATCH 5/7] i2c-designware: enable/disable the controller properly

2013-03-21 Thread Mika Westerberg
function returns. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c index 94fd818

[PATCH 6/7] i2c-designware: use usleep_range() in the busy-loop

2013-03-21 Thread Mika Westerberg
This is not an atomic context so there is no need to use mdelay() but instead use usleep_range(). Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b

[PATCH 1/7] i2c-designware: move to managed functions (devm_*)

2013-03-21 Thread Mika Westerberg
From: Andy Shevchenko This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller and tidier. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-platdrv.c | 73

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-04 Thread Mika Westerberg
On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: > On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: > > > Mark, thank you for applying patches 1-4/10. Is there anything you want me > > to do for the rest of the patches in order to get those merged?

Re: [PATCH v3 05/10] spi/pxa2xx: break out the private DMA API usage into a separate file

2013-02-04 Thread Mika Westerberg
On Mon, Feb 04, 2013 at 08:43:42PM +0100, Linus Walleij wrote: > On Tue, Jan 22, 2013 at 11:26 AM, Mika Westerberg > wrote: > > > The PXA SPI driver uses PXA platform specific private DMA implementation > > which does not work on non-PXA platforms. In order to use thi

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-07 Thread Mika Westerberg
Hi Mark/Grant, On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: > On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: > > > Mark, thank you for applying patches 1-4/10. Is there anything you want me > > to do for the rest of the patches in order t

[PATCH] Documentation / acpi: refer to correct file for acpi_platform_device_ids[] table

2013-02-08 Thread Mika Westerberg
When the ACPI platform device code was converted to the new ACPI scan handler facility, the the acpi_platform_device_ids[] was moved to drivers/acpi/acpi_platform.c. Update the documentation accordingly. Signed-off-by: Mika Westerberg --- Documentation/acpi/enumeration.txt |4 ++-- 1 file

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-08 Thread Mika Westerberg
On Fri, Feb 08, 2013 at 10:37:15PM +0100, Linus Walleij wrote: > On Mon, Feb 4, 2013 at 10:52 AM, Mika Westerberg > wrote: > > On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: > >> On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: > >> >

Re: [PATCH] Documentation / acpi: refer to correct file for acpi_platform_device_ids[] table

2013-02-08 Thread Mika Westerberg
On Sat, Feb 09, 2013 at 12:14:27AM +0100, Rafael J. Wysocki wrote: > On Friday, February 08, 2013 04:07:01 PM Mika Westerberg wrote: > > When the ACPI platform device code was converted to the new ACPI scan > > handler facility, the the acpi_platform_device_ids[] was moved to &

Re: [PATCH 0/7] hid driver transport cleanup

2013-02-11 Thread Mika Westerberg
out that there is a dependency to usbhid in many of the drivers, especially in sensor-hub which caused the system crash while the driver tried to transmit over USB even though it was behind I2C. Your series fixes that nicely :) You can add, Reviewed-by: Mika Westerberg for the whole seri

[PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-11 Thread Mika Westerberg
We now have two transport mediums: USB and I2C, where sensor hubs can exists. So instead of constraining the driver to only these two we let it to match any HID bus as long as the group is HID_GROUP_SENSOR_HUB. Signed-off-by: Mika Westerberg --- drivers/hid/hid-sensor-hub.c |3 ++- 1 file

[PATCH 1/3] HID: extend autodetect to handle I2C sensors as well

2013-02-11 Thread Mika Westerberg
Since the advent of HID over I2C protocol, it is possible to have sensor hubs behind I2C bus as well. We can autodetect this in a same way than USB sensor hubs. Signed-off-by: Mika Westerberg --- drivers/hid/hid-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Mika Westerberg
This table is not used anywhere in the driver so kill it. Signed-off-by: Mika Westerberg --- drivers/hid/hid-sensor-hub.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index c06e933..2643bce9 100644 --- a/drivers/hid/hid

Re: [PATCH 0/7] hid driver transport cleanup

2013-02-11 Thread Mika Westerberg
On Mon, Feb 11, 2013 at 12:19:13PM +0100, Benjamin Tissoires wrote: > On Mon, Feb 11, 2013 at 11:13 AM, Mika Westerberg > wrote: > > On Fri, Feb 08, 2013 at 03:37:29PM +0100, Benjamin Tissoires wrote: > >> so, here is the hid drivers cleanup. The aim is to remove as m

Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-12 Thread Mika Westerberg
On Mon, Feb 11, 2013 at 03:54:05PM +, Pandruvada, Srinivas wrote: > So finally we can use HID sensor hub over I2C. > Did you try with any I2C sensor hub? Yes, we have I2C HID sensor hub here and I tested with it. However, I'm not that familiar how it should be used except that I can see the se

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: > On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: > > Next time, please direct these mails to my Linaro id :) > > > > On Mon, Jan 28, 2013 at 4:34 PM, Andy Shevchenko > > wrote: > > > On some hardware configurations we have

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 09:34:35AM -0800, Vinod Koul wrote: > On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote: > > On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: > > > On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: > > > >

[PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Mika Westerberg
the ACPI GPIO number to the corresponding Linux GPIO number and returns that. Signed-off-by: Mika Westerberg --- Documentation/acpi/enumeration.txt | 32 ++- drivers/gpio/gpiolib-acpi.c| 77 include/linux/acpi_gpio.h | 17

Re: GPS driver for Linux - kernel or user-space driver?

2013-04-04 Thread Mika Westerberg
(Adding Lv, he has been working on this). On Wed, Apr 03, 2013 at 06:44:51PM -0700, Marcel Holtmann wrote: > Hi Greg, > > I've been approached by a developer at Sony who wants to publish an > open source driver for a Sony GPS receiver module. > >>> > >>> What does the device look like?

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: > Hi Mika, > > On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg > wrote: > > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > > a helper function analogous to Device Tree ver

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: > On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg > wrote: > > On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: > >> Hi Mika, > >> > >> On Wed, Apr 3, 2013 a

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 12:01:23PM +0200, Benjamin Tissoires wrote: > > One option is to provide acpi_get_gpio_all() that returns all GPIOs and > > their corresponding types. That should allow clients like i2c-hid to find > > the right GPIO (I'm hoping that there will be only one GpioInt associated

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-01-28 Thread Mika Westerberg
uitable resources here: 13176bbf183c8 (ACPI: add support for CSRT table). > > Signed-off-by: Mika Westerberg > > Signed-off-by: Andy Shevchenko > > --- > > drivers/dma/dw_dmac.c | 13 + > > drivers/dma/dw_dmac_regs.h |1 + > > 2 fi

Re: [PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices

2013-01-28 Thread Mika Westerberg
nce bit easier. Feel free to add: Reviewed-by: Mika Westerberg Tested-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices

2013-01-29 Thread Mika Westerberg
On Mon, Jan 28, 2013 at 02:01:14PM +0100, Rafael J. Wysocki wrote: > +/* Flags for acpi_create_platform_device */ > +#define ACPI_PLATFORM_CLKBIT(0) > + > +/* > + * The following ACPI IDs are known to be suitable for representing as > + * platform devices. > + */ > +static const struct acpi_dev

Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()

2013-01-31 Thread Mika Westerberg
. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()

2013-01-31 Thread Mika Westerberg
On Wed, Jan 30, 2013 at 11:04:03PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make acpi_bus_get_parent() more straightforward and remove an > unnecessary local variable ret from it. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg -- T

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-01 Thread Mika Westerberg
On Fri, Feb 01, 2013 at 02:32:03PM +0800, zergmk2 wrote: > I've verified your patch and spi bus worked properly on PXA910 platform. > I used a debug tool to send data on spi bus, and I connected spi out pin > and spi in pin. > So when I read data from spi bus, it should be what I sent from spi bus.

Re: [PATCH 0/4] i2c-designware: add Intel Lynxpoint support

2013-01-24 Thread Mika Westerberg
On Thu, Jan 24, 2013 at 08:28:46AM +0100, Wolfram Sang wrote: > I can't tell much about ACPI usage, but rest looks good to me. Applied > to next. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-02-27 Thread Mika Westerberg
when the GPIO is available and not vice versa. Fix this by making the function return boolean as expected by the callers. Signed-off-by: Mika Westerberg --- drivers/gpio/gpio-ich.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio

[PATCH] HID: make sensor autodetection independent of underlying bus

2013-02-19 Thread Mika Westerberg
Instead of limiting HID sensors to USB and I2C busses we can just make everything that has usage page of HID_UP_SENSOR to be included in HID_GROUP_SENSOR_HUB group. This allows the sensor-hub to work over bluetooth (and other transports) as well. Reported-by: Alexander Holler Signed-off-by: Mika

Re: [PATCH -next] spi: fix return value check in ce4100_spi_probe()

2013-02-22 Thread Mika Westerberg
t; Signed-off-by: Wei Yongjun Nice catch! Acked-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH 1/6] Introduce acpi_match_device_id().

2012-10-01 Thread Mika Westerberg
On Mon, Oct 01, 2012 at 01:56:17PM +, Zhang, Rui wrote: > > > > -Original Message- > > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > > Sent: Monday, October 01, 2012 2:38 PM > > To: Zhang, Rui > > Cc: LKML; linux-pm; linux-

Re: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration driver

2012-10-01 Thread Mika Westerberg
On Mon, Oct 01, 2012 at 02:19:49PM +, Zhang, Rui wrote: > > > > -Original Message- > > From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c- > > ow...@vger.kernel.org] On Behalf Of Mika Westerberg > > Sent: Monday, October 01, 2012 2:55 PM > > T

Re: [RFC PATCH 0/6] ACPI: ACPI 5.0 device enumeration proposal

2012-10-01 Thread Mika Westerberg
On Mon, Oct 01, 2012 at 02:30:00PM +, Zhang, Rui wrote: > > > > -Original Message- > > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > > Sent: Monday, October 01, 2012 2:45 PM > > To: Zhang, Rui > > Cc: LKML; linux-pm; linux-

Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types

2012-10-31 Thread Mika Westerberg
On Wed, Oct 31, 2012 at 10:06:00PM +0100, Rafael J. Wysocki wrote: > On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: > > > By "tested" I mean "run with some new devices that use the ACPI > > > enumeration > > > provided here, on x86". Sorry for being too vague. > > > > Do you or Mik

[PATCH 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-03 Thread Mika Westerberg
code in Rafael's branch assigns the ACPI handle to the master device. I2C slave devices can be enumerated by calling acpi_i2c_register_devices() in the adapter driver. Thanks, Mika Mathias Nyman (1): gpio / ACPI: add ACPI support Mika Westerberg (2): spi / ACPI: add ACPI enumeration

[PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
order to get its slave devices enumerated, created and bound to the corresponding ACPI handle. Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki --- drivers/acpi/Kconfig |6 ++ drivers/acpi/Makefile|1 + drivers/acpi/acpi_i2c.c | 234

[PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-03 Thread Mika Westerberg
d-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki --- drivers/gpio/Kconfig|4 +++ drivers/gpio/Makefile |1 + drivers/gpio/gpiolib-acpi.c | 60 +++ include/linux/acpi_gpio.h | 19 ++ 4 files changed, 84 inser

[PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
for further configuration. Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki --- drivers/spi/spi.c | 231 - 1 file changed, 230 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 84c2861..de22a6e

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
On Sat, Nov 03, 2012 at 01:42:02PM -0600, Bjorn Helgaas wrote: > On Sat, Nov 3, 2012 at 1:46 AM, Mika Westerberg > wrote: > > ACPI 5 introduced SPISerialBus resource that allows us to enumerate and > > configure the SPI slave devices behind the SPI controller. This patch adds &g

Re: [PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-04 Thread Mika Westerberg
On Sat, Nov 03, 2012 at 10:52:46PM +0100, Jean Delvare wrote: > On Sat, 3 Nov 2012 09:46:33 +0200, Mika Westerberg wrote: > > ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate > > and configure the I2C slave devices behind the I2C controller. This patch

Re: [PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-04 Thread Mika Westerberg
On Sun, Nov 04, 2012 at 09:50:31AM +0100, Jean Delvare wrote: > On Sun, 4 Nov 2012 09:23:17 +0200, Mika Westerberg wrote: > > On Sat, Nov 03, 2012 at 10:52:46PM +0100, Jean Delvare wrote: > > > On Sat, 3 Nov 2012 09:46:33 +0200, Mika Westerberg wrote: > > > > --- /

Re: [PATCH 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-05 Thread Mika Westerberg
On Sun, Nov 04, 2012 at 07:29:10PM +0100, Linus Walleij wrote: > On Sat, Nov 3, 2012 at 8:46 AM, Mika Westerberg > wrote: > > > With ACPI 5 we can now describe how devices are connected to their bus > > using new resources: SPISerialBus and I2CSerialBus. Also it is now pos

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:31:19AM +0100, Rafael J. Wysocki wrote: > The general idea is to move the _CRS parsing routine from acpi_platform.c > to scan.c and make it attach resource objects to struct acpi_device. > > I'm thinking about adding a list head to struct acpi_device pointing to a > list

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:54:55AM +0100, Mark Brown wrote: > On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote: > > > + strlcpy(spi->modalias, acpi_device_hid(adev), sizeof(spi->modalias)); > > + if (info.gsi >= 0) > > + spi-&g

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:56:39AM +0100, Mark Brown wrote: > On Mon, Nov 05, 2012 at 12:56:02PM +0200, Mika Westerberg wrote: > > > > struct acpi_device { > > > ... > > > union acpi_resource_serial_bus *serial; > > > ... > > > }; &g

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 01:59:23PM +0100, Rafael J. Wysocki wrote: > On Monday, November 05, 2012 01:23:50 PM Jean Delvare wrote: > > On Mon, 5 Nov 2012 14:02:19 +0200, Mika Westerberg wrote: > > > On Mon, Nov 05, 2012 at 11:56:39AM +0100, Mark Brown wrote: > > > > I&

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 02:20:52PM +0100, Linus Walleij wrote: > > > > It looks like some PMICs for example have two I2C control interfaces, like > > TI's TWL6030 if I'm not mistaken. If both are put behind the same I2C > > controller with different address, you have the situation like above. > >

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 03:19:58PM +0100, Rafael J. Wysocki wrote: > > In the ACPI namespace we have device nodes and serial interfaces below them. > In the above case we see that a single device node supports two different > interfaces and in that case we probably should create two different > st

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 04:19:20PM +0100, Jean Delvare wrote: > On Mon, 5 Nov 2012 16:53:15 +0200, Mika Westerberg wrote: > > On Mon, Nov 05, 2012 at 03:19:58PM +0100, Rafael J. Wysocki wrote: > > > > > > In the ACPI namespace we have device nodes and serial interfaces

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 10:43:17AM -0700, Bjorn Helgaas wrote: > > It should already be unique in case of ACPI. We use ACPI _HID and _UID to > > achieve that. > > Using only _HID and _UID to guarantee uniqueness means you're relying > on a property of the BIOS, so you're vulnerable to BIOS bugs. >

[PATCH 2/2] ACPI, ia64: export acpi_[un]register_gsi()

2012-10-29 Thread Mika Westerberg
These functions might be called from modules as well so make sure they are exported. Signed-off-by: Mika Westerberg --- arch/ia64/kernel/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c index 44057885..bd86e39 100644 --- a/arch/ia64

[PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()

2012-10-29 Thread Mika Westerberg
From: Andy Shevchenko These functions might be called from modules as well so make sure they are exported. In addition we implement empty version of acpi_unregister_gsi() and remove the one from pci_irq.c. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- Although there are no

Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()

2012-10-29 Thread Mika Westerberg
On Mon, Oct 29, 2012 at 12:12:10PM +0100, Ingo Molnar wrote: > > * Mika Westerberg wrote: > > > From: Andy Shevchenko > > > > These functions might be called from modules as well so make sure they are > > exported. In addition we implement empty version

[PATCH v4] i2c: enable runtime PM for I2C adapter devices enumerated from ACPI

2013-10-01 Thread Mika Westerberg
addition to that we attach the I2C client devices to the ACPI power domain and make sure that they are powered on when the driver ->probe() is called. Non-ACPI devices are not affected by this change. This patch is based on the work by Aaron Lu and Lv Zheng. Signed-off-by: Mika Westerb

[PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-01 Thread Mika Westerberg
-off-by: Mika Westerberg --- drivers/gpio/gpio-lynxpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c index 2d9ca60..41b5913 100644 --- a/drivers/gpio/gpio-lynxpoint.c +++ b/drivers/gpio/gpio-lynxpoint.c

[PATCH 3/5] gpiolib / ACPI: add ACPI support for gpiod_get_index()

2013-10-01 Thread Mika Westerberg
gpiod_get_index() and gpiod_get() are now the new preferred way to request GPIOs. Add support for finding the corresponding GPIO descriptor from ACPI namespace. Signed-off-by: Mika Westerberg --- drivers/gpio/gpiolib.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpio

[PATCH 4/5] gpiolib / ACPI: allow passing GPIOF_ACTIVE_LOW for GpioInt resources

2013-10-01 Thread Mika Westerberg
The ACPI GpioInt resources contain polarity field that is used to specify whether the interrupt is active high or low. Since gpiolib supports GPIOF_ACTIVE_LOW we can pass this information in the flags field in acpi_find_gpio(), analogous to the DeviceTree version. Signed-off-by: Mika Westerberg

[PATCH 0/5] gpiolib: convert ACPI GPIO helpers to gpiod_ interfaces

2013-10-01 Thread Mika Westerberg
acpi_gpiochip_request_interrupts(). Patches [2-5/5] do the actual conversion. The series is based on the latest patches from Alexandre Courbot and I've tested them on Intel Haswell based machine. Please review. Mika Westerberg (5): gpiolib / ACPI: move acpi_gpiochip_free_interrupts next to the request function gp

[PATCH 1/5] gpiolib / ACPI: move acpi_gpiochip_free_interrupts next to the request function

2013-10-01 Thread Mika Westerberg
It makes more sense to have these functions close to each other. No functional changes. Signed-off-by: Mika Westerberg --- drivers/gpio/gpiolib-acpi.c | 76 ++--- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/gpio/gpiolib-acpi.c

[PATCH 5/5] gpiolib / ACPI: document the GPIO descriptor based interface

2013-10-01 Thread Mika Westerberg
In addition to the existing ACPI specific GPIO interface, document the new descriptor based GPIO interface in Documentation/acpi/enumeration.txt, so it is clear that this new interface is preferred over the ACPI specific version. Signed-off-by: Mika Westerberg --- Documentation/acpi

[PATCH 2/5] gpiolib / ACPI: convert to gpiod interfaces

2013-10-01 Thread Mika Westerberg
descriptors to integers. Signed-off-by: Mika Westerberg --- drivers/gpio/gpiolib-acpi.c | 51 + include/linux/acpi_gpio.h | 38 ++--- 2 files changed, 54 insertions(+), 35 deletions(-) diff --git a/drivers/gpio/gpiolib

Re: [PATCH v4] i2c: enable runtime PM for I2C adapter devices enumerated from ACPI

2013-10-05 Thread Mika Westerberg
On Tue, Oct 01, 2013 at 04:09:42PM +0300, Mika Westerberg wrote: > The ACPI specification requires the parent device to be powered on before > any of its children. It can be only powered off when all the children are > already off. > > Currently whenever there is no I2C traffic go

[PATCH 2/2] i2c-designware: configure *CNT values from ACPI

2013-07-08 Thread Mika Westerberg
and otherwise use the default method based solely on the input clock speed. Signed-off-by: Mika Westerberg --- This applies on top of following patch which is not yet in i2c tree: http://permalink.gmane.org/gmane.linux.drivers.i2c/15754 drivers/i2c/busses/i2c-designware-platdrv.c | 25

[PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-08 Thread Mika Westerberg
. that are very platform specific and have an effect on the clock signal. With this patch we let the platform code to specify more accurate, optimal *CNT values if they are known beforehand. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-core.c | 46

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-09 Thread Mika Westerberg
On Mon, Jul 08, 2013 at 03:42:17PM +0200, Christian Ruppert wrote: > On Mon, Jul 08, 2013 at 02:45:26PM +0300, Mika Westerberg wrote: > > The DesignWare I2C controller has high count (HCNT) and low count (LCNT) > > registers for each of the I2C speed modes (standard and fast). Thes

Re: [RFC][PATCH 4/8] ACPI / hotplug / PCI: Hotplug context objects for bridges and functions

2013-07-09 Thread Mika Westerberg
On Tue, Jul 09, 2013 at 02:18:12AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > When either a new hotplug brigde or a new hotplug function is added ^^ typo > by the ACPI-based PCI hotplug (acpiphp) code, attach a contex

Re: [RFC][PATCH 5/8] ACPI / hotplug / PCI: Unified notify handler for hotplug events

2013-07-09 Thread Mika Westerberg
On Tue, Jul 09, 2013 at 02:19:04AM +0200, Rafael J. Wysocki wrote: > Index: linux-pm/drivers/pci/hotplug/acpiphp.h > === > --- linux-pm.orig/drivers/pci/hotplug/acpiphp.h > +++ linux-pm/drivers/pci/hotplug/acpiphp.h > @@ -137,6 +137,7

Re: [RFC][PATCH 6/8] ACPI / hotplug / PCI: Drop acpiphp_handle_to_bridge()

2013-07-09 Thread Mika Westerberg
On Tue, Jul 09, 2013 at 02:20:31AM +0200, Rafael J. Wysocki wrote: > @@ -953,37 +937,49 @@ static void acpiphp_sanitize_bus(struct > * ACPI event handlers > */ > > -static acpi_status > -check_sub_bridges(acpi_handle handle, u32 lvl, void *context, void **rv) > +static acpi_status check_sub_b

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-10 Thread Mika Westerberg
On Tue, Jul 09, 2013 at 06:19:28PM +0200, Christian Ruppert wrote: > What I meant is the following: The clock cycle time Tc is composed of > the four components > > Tc = Th + Tf + Tl + Tr > > where > Th: Time during which the signal is high > Tf: Falling edge transition time > Tl: Time du

Re: [PATCH 2/2] i2c-designware: configure *CNT values from ACPI

2013-07-10 Thread Mika Westerberg
On Mon, Jul 08, 2013 at 02:45:27PM +0300, Mika Westerberg wrote: > Some Intel LPSS I2C devices make the *CNT values available from ACPI > namespace in similar way than the SDA hold value. These values allow > platform/BIOS to specify the most accurate *CNT values for the device > d

Re: [PATCH] i2c-designware: configure SDA hold time from ACPI

2013-07-10 Thread Mika Westerberg
On Wed, Jul 03, 2013 at 12:52:40PM +0300, Mika Westerberg wrote: > Some Intel LPSS I2C devices make the SDA hold time parameter available via > SSCN (standard mode) and FMCN (fast mode) ACPI methods. If we find that > such method exist, we evaluate it and pass the returned SDA hold value

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-11 Thread Mika Westerberg
On Wed, Jul 10, 2013 at 06:56:35PM +0200, Christian Ruppert wrote: > On Wed, Jul 10, 2013 at 01:52:15PM +0300, Mika Westerberg wrote: > > On Tue, Jul 09, 2013 at 06:19:28PM +0200, Christian Ruppert wrote: > > > What I meant is the following: The clock cycle time Tc is composed

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-11 Thread Mika Westerberg
On Thu, Jul 11, 2013 at 10:36:00AM +0300, Mika Westerberg wrote: > On Wed, Jul 10, 2013 at 06:56:35PM +0200, Christian Ruppert wrote: > > On Wed, Jul 10, 2013 at 01:52:15PM +0300, Mika Westerberg wrote: > > > On Tue, Jul 09, 2013 at 06:19:28PM +0200, Christian Ruppert wrote: &g

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-07-12 Thread Mika Westerberg
On Fri, Jul 12, 2013 at 04:56:49PM +0900, Shinya Kuribayashi wrote: > On 7/11/13 7:13 PM, Mika Westerberg wrote: > >On Thu, Jul 11, 2013 at 10:36:00AM +0300, Mika Westerberg wrote: > >>On Wed, Jul 10, 2013 at 06:56:35PM +0200, Christian Ruppert wrote: > >>>On Wed, Ju

Re: [RFC][PATCH 11/30] ACPI / hotplug / PCI: Register all devices under the given bridge

2013-07-12 Thread Mika Westerberg
On Fri, Jul 12, 2013 at 01:50:29AM +0200, Rafael J. Wysocki wrote: > @@ -1210,6 +1125,35 @@ void acpiphp_enumerate_slots(struct pci_ >*/ > get_device(&bus->dev); > > + if (!pci_is_root_bus(bridge->pci_bus)) { > + struct acpiphp_context *context; > + > + /

Re: [RFC][PATCH 11/30] ACPI / hotplug / PCI: Register all devices under the given bridge

2013-07-12 Thread Mika Westerberg
On Fri, Jul 12, 2013 at 02:54:20PM +0300, Mika Westerberg wrote: > On Fri, Jul 12, 2013 at 01:50:29AM +0200, Rafael J. Wysocki wrote: > > @@ -1210,6 +1125,35 @@ void acpiphp_enumerate_slots(struct pci_ > > */ > > get_device(&bus->dev); > > > >

Re: [RFC][PATCH 23/30] ACPI / hotplug / PCI: Do not exectute _PS0 and _PS3 directly

2013-07-12 Thread Mika Westerberg
On Fri, Jul 12, 2013 at 02:01:30AM +0200, Rafael J. Wysocki wrote: > Index: linux-pm/drivers/pci/hotplug/acpiphp.h > === > --- linux-pm.orig/drivers/pci/hotplug/acpiphp.h > +++ linux-pm/drivers/pci/hotplug/acpiphp.h > @@ -160,7 +160,6

Re: [RFC][PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds

2013-07-12 Thread Mika Westerberg
ed to be applied. With the above mentioned patch applied + fix for patch [23/30], I tested this series on Acer Aspire S5 and Intel DZ77RE-75K desktop and Thunderbolt works just fine :-) You can add Tested-by: Mika Westerberg to the series. Nice cleanup! -- To unsubscribe from this list: send the

[PATCH] PCI / hotplug / ACPI: Get rid of check_sub_bridges()

2013-07-13 Thread Mika Westerberg
also simplifies the ACPIPHP code a bit. Signed-off-by: Mika Westerberg --- This applies on top of v3.10 with Rafael's ACPIPHP + Thunderbolt series applied: http://www.spinics.net/lists/linux-acpi/msg44480.html drivers/pci/hotplug/acpiphp_glue.c | 25 - 1 fi

Re: [PATCH] PCI / hotplug / ACPI: Get rid of check_sub_bridges()

2013-07-14 Thread Mika Westerberg
On Sat, Jul 13, 2013 at 11:47:26PM +0200, Rafael J. Wysocki wrote: > On Saturday, July 13, 2013 08:09:59 PM Mika Westerberg wrote: > > Now that acpiphp_check_bridge() always enumerates devices behind the > > bridge, there is no need to do that for each sub-bridge anymore like it is

Re: [PATCH] x86: add pin control support to Intel low power subsystem

2013-09-13 Thread Mika Westerberg
trol their gpio resources, but more pincontrol functions > such as pin muxing and grouping are possible to add later. > > Signed-off-by: Mathias Nyman Makes sense, and since there seems to be no way to enable pinctrl by just selecting it from 'make XXXconfig', Reviewed-by:

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-14 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 02:10:43PM -0700, Kevin Hilman wrote: > > > > // This makes sure that the controller itself is powered on > > // (adapter device follows its parent which is the controller). The > > // controller is attached to the ACPI power domain so it is > > // brought to

Re: [PATCH 2/2] gpio / ACPI: add support for GPIO operation regions

2013-09-14 Thread Mika Westerberg
On Sat, Sep 14, 2013 at 12:10:37AM +, Zheng, Lv wrote: > Is it possible to install the handler for ACPI_ROOT_OBJECT? > Can it be achieved by implementing a setup callback? Yes that can be done. However, that would mean that we always install the operation region handler even if there is no sui

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-15 Thread Mika Westerberg
On Sun, Sep 15, 2013 at 01:47:44PM +0100, Mark Brown wrote: > On Sun, Sep 15, 2013 at 09:41:39AM +0300, Mika Westerberg wrote: > > > There's also a less intrusive way of fixing the problem we see with ACPI > > enabled I2C devices: > > > 1. In I2C core i2c_de

Re: [PATCH 2/2] gpio / ACPI: add support for GPIO operation regions

2013-09-16 Thread Mika Westerberg
On Mon, Sep 16, 2013 at 01:21:53AM +, Zheng, Lv wrote: > > A pseudo device may be created to access the GPIO operation region fields > > provided by one GPIO device. > > The pseudo device may have other functions to access other GPIO operation > > region fields provided by other GPIO devices,

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-16 Thread Mika Westerberg
On Sun, Sep 15, 2013 at 03:48:12PM +0200, Sylwester Nawrocki wrote: > On 09/13/2013 05:40 PM, Mika Westerberg wrote: > [...] > >>>The call to pm_runtime_get_noresume() should make sure that the device is > >>>in active state (at least in state where it can access the

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-16 Thread Mika Westerberg
On Mon, Sep 16, 2013 at 11:12:49AM +0100, Mark Brown wrote: > That's definitely an ACPI specific (probably x86 specific ACPI?) > requirement not a generic one, on some systems it would increase power > consumption since the controller will need to sit on while the device is > functioning autonomous

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-16 Thread Mika Westerberg
On Mon, Sep 16, 2013 at 03:46:16PM +0100, Graeme Gregory wrote: > On Mon, Sep 16, 2013 at 05:38:12PM +0300, Mika Westerberg wrote: > > On Mon, Sep 16, 2013 at 11:12:49AM +0100, Mark Brown wrote: > > > That's definitely an ACPI specific (probably x86 specific ACPI?) > >

Re: [PATCH 2/2] gpio / ACPI: add support for GPIO operation regions

2013-09-17 Thread Mika Westerberg
On Mon, Sep 16, 2013 at 11:35:56PM +, Zheng, Lv wrote: > > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > > Sent: Monday, September 16, 2013 4:11 PM > > > > On Mon, Sep 16, 2013 at 01:21:53AM +, Zheng, Lv wrote: > > > > A pseudo devi

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-17 Thread Mika Westerberg
On Mon, Sep 16, 2013 at 09:07:07PM +0200, Rafael J. Wysocki wrote: > On Monday, September 16, 2013 11:47:08 AM Mika Westerberg wrote: > > On Sun, Sep 15, 2013 at 03:48:12PM +0200, Sylwester Nawrocki wrote: > > > On 09/13/2013 05:40 PM, Mika Westerberg wrote: > > >

[PATCH] spi/pxa2xx: check status register as well to determine if the device is off

2013-09-04 Thread Mika Westerberg
register for ~0 and returning IRQ_NONE in that case. Signed-off-by: Mika Westerberg --- drivers/spi/spi-pxa2xx.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index e0fd6f6..2cbab8a 100644 --- a/drivers/spi/spi

[PATCH RESEND 1/2] i2c: prepare runtime PM support for I2C client devices

2013-09-09 Thread Mika Westerberg
I2C controller device. The adapter device is handled along with the I2C controller device (it uses pm_runtime_no_callbacks()). Signed-off-by: Aaron Lu Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki --- drivers/i2c/i2c-core.c | 48 +++-

[PATCH RESEND 2/2] i2c: attach/detach I2C client device to the ACPI power domain

2013-09-09 Thread Mika Westerberg
that's the case, attach it to the ACPI power domain. In addition we make sure that the device is fully powered when its ->probe() function gets called. For non-ACPI devices this patch is a no-op. Signed-off-by: Lv Zheng Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki --- dri

  1   2   3   4   5   6   7   8   9   10   >