Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Mika Westerberg
On Thu, Jan 18, 2018 at 12:20:32PM +0200, Mika Westerberg wrote: > On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > > Unfortunately we couldn't get approval yet, since it's a prototype > > machine. > > In that case, I think the system itself and its A

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Mika Westerberg
On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > Unfortunately we couldn't get approval yet, since it's a prototype > machine. In that case, I think the system itself and its ACPI tables should be fixed if possible. Windows relies on that table as well so unless there is something t

Re: [PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs without a mmio resource

2018-01-15 Thread Mika Westerberg
Signed-off-by: Hans de Goede Seems like a good way to fix it IMHO, Acked-by: Mika Westerberg

Re: Regression due to "PCI: Do not allocate more buses than available in parent"

2018-01-12 Thread Mika Westerberg
Hi, On Fri, Jan 12, 2018 at 04:07:44PM +0100, Sebastian Reichel wrote: > Hi, > > I have an ARM/DT based system [0], that no longer finds its ethernet cards > behind a PCIe switch. I bisected the problem and ended up on > a20c7f36bd3d. I tried providing some space using the suggested > "pci=hpbus

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-10 Thread Mika Westerberg
On Wed, Jan 10, 2018 at 04:13:51PM +0100, Takashi Iwai wrote: > Hi, > > on the recent kernels, i2c-i801 skips the creation of iTCO wdt when > ACPI WDAT is present. It's fine when ACPI really creates the watchdog > device. But, we've got a report showing that the watchdog is missing > on some mac

[PATCH] mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Apollo Lake

2018-01-04 Thread Mika Westerberg
Just to be on the safe side, don't touch the bit. If write access to the flash chip is needed, the BIOS needs to enable it explicitly. Signed-off-by: Mika Westerberg --- drivers/mfd/lpc_ich.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_

Re: pinctrl-amd: What hardware does it apply to?

2017-12-21 Thread Mika Westerberg
On Fri, Dec 22, 2017 at 10:37:32AM +1000, Andrew Cooks wrote: > > > On 21/12/17 22:12, Mika Westerberg wrote: > > On Thu, Dec 21, 2017 at 11:11:18AM +0100, Linus Walleij wrote: > >>> In contrast, the pinctrl-amd driver only mentions the newer KERNCZ > >>>

Re: pinctrl-amd: What hardware does it apply to?

2017-12-21 Thread Mika Westerberg
27;t understand anything of what you just wrote. > I am basically ignorant when it comes to ACPI details. > > So let's CC the GPIO ACPI maintainer, Mika Westerberg. If the hardware is not the same that is already supported by the pinctrl-amd, then you definitely should allocate a new s

Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2

2017-12-16 Thread Mika Westerberg
On Tue, Dec 05, 2017 at 09:52:50AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 10:49:13AM +0200, Mika Westerberg wrote: > > On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > > > Hi Greg, > > > > > > Here are two Thunderbolt fixe

Re: [PATCH V3] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-15 Thread Mika Westerberg
M / runtime: Fix handling of suppliers with disabled > runtime PM". > > Signed-off-by: Adrian Hunter Acked-by: Mika Westerberg

Re: [PATCH v2] gpio: fix "gpio-line-names" property retrieval

2017-12-15 Thread Mika Westerberg
andle(chip->of_node) or dev_fwnode(chip->parent) > to that function. > > Fixes: 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names() to use device > property accessors") > Cc: sta...@vger.kernel.org > Signed-off-by: Christophe Leroy Acked-by: Mika Westerberg

Re: [PATCH] gpio: fix "gpio-line-names" property retrieval

2017-12-15 Thread Mika Westerberg
On Fri, Dec 15, 2017 at 09:09:15AM +0100, Christophe Leroy wrote: > Following commit 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names() > to use device property accessors"), "gpio-line-names" DT property is > not retrieved anymore when chip->parent is not set by the driver. Thanks for taking car

Re: [PATCH 2/2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

2017-12-05 Thread Mika Westerberg
On Tue, Dec 05, 2017 at 11:27:38AM +, Jonathan Cameron wrote: > Why does it not make sense to just create them all from the ACPI/I2C core? How do you know in ACPI/I2C core what is the right thing to do? Is it a single device, like EEPROM with multiple addresses, or is it multiple completely se

Re: [PATCH v5] PCI: hotplug: Drop checking of PCI_BRIDGE_CONTROL in *_unconfigure_device()

2017-12-05 Thread Mika Westerberg
On Thu, Nov 09, 2017 at 02:15:08PM +0300, Mika Westerberg wrote: > During PCIe surprise hot-unplug the device is not accessible anymore and > register reads return 0x. When that happens > pciehp_unconfigure_device() > may inadvertently think the device below the bridge may

Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2

2017-12-05 Thread Mika Westerberg
On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > Hi Greg, > > Here are two Thunderbolt fixes and one related MAINTAINERS update for the > next -rc: > > - Use shorter path for force_power attribute in thunderbolt.rst > - Ring interrupts were not masked pro

Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized

2017-12-04 Thread Mika Westerberg
el: Allow custom GPIO base for pad groups") > Signed-off-by: Colin Ian King Acked-by: Mika Westerberg

Re: [PATCH 2/2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

2017-12-04 Thread Mika Westerberg
On Mon, Dec 04, 2017 at 11:29:31AM +0100, Hans de Goede wrote: > i2c_new_secondary_device() is for a different purpose, this is for when > a single i2c device listens on multiple addresses and the driver wants > separate i2c_client-s to use to talk to each address. > > In this case there are 2 sep

Re: [PATCH 2/2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

2017-12-04 Thread Mika Westerberg
On Sat, Dec 02, 2017 at 12:19:27PM +, Jonathan Cameron wrote: > On Wed, 29 Nov 2017 22:31:12 + > Jeremy Cline wrote: > > > Some BOSC0200 acpi_device-s describe two accelerometers in a single ACPI > > device. Check for a companion device and handle a second i2c_client > > if it is present.

[PATCH 1/3] thunderbolt: Make pathname to force_power shorter

2017-12-01 Thread Mika Westerberg
From: Andy Shevchenko WMI is the bus inside kernel, so, we may access the GUID via /sys/bus/wmi instead of doing this through /sys/devices path. Signed-off-by: Andy Shevchenko Acked-by: Mario Limonciello Signed-off-by: Mika Westerberg --- Documentation/admin-guide/thunderbolt.rst | 2 +- 1

[PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts

2017-12-01 Thread Mika Westerberg
rings") Signed-off-by: Mika Westerberg Acked-by: Yehezkel Bernat --- drivers/thunderbolt/nhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 419a7a90bce0..f45bcbc63738 100644 --- a/drivers/thunderbolt/nhi.c +++

[PATCH 2/3] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry

2017-12-01 Thread Mika Westerberg
Make sure Thunderbolt maintainers get to see patches that touch documentation of the Thunderbolt driver as well. Signed-off-by: Mika Westerberg --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..478e4d342c2a 100644 --- a/MAINTAINERS

[PATCH 0/3] thunderbolt fixes for v4.15-rc2

2017-12-01 Thread Mika Westerberg
! Andy Shevchenko (1): thunderbolt: Make pathname to force_power shorter Mika Westerberg (2): MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry thunderbolt: Mask ring interrupt properly when polling starts Documentation/admin-guide/thunderbolt.rst | 2 +- MAINTAINERS

Re: [PATCH 1/2] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry

2017-12-01 Thread Mika Westerberg
On Mon, Nov 27, 2017 at 02:48:57PM +0300, Mika Westerberg wrote: > Make sure Thunderbolt maintainers get to see patches that touch > documentation of the Thunderbolt driver as well. > > Signed-off-by: Mika Westerberg Applied.

[PATCH v2] pinctrl: intel: Initialize GPIO properly when used through irqchip

2017-11-29 Thread Mika Westerberg
pport") Reported-by: Daniel Drake Reported-and-tested-by: Chris Chiu Signed-off-by: Mika Westerberg Cc: sta...@vger.kernel.org --- Changes from v1: * Renamed __intel_gpio_init_gpio() to intel_gpio_set_gpio_mode() * Added Fixes: and Cc sta...@vger.kernel.org * Added Tested-by from Chris Chiu

Re: [PATCH] pinctrl: intel: Initialize GPIO properly when used through irqchip

2017-11-29 Thread Mika Westerberg
On Wed, Nov 29, 2017 at 01:39:00PM +0100, Linus Walleij wrote: > On Mon, Nov 20, 2017 at 4:19 PM, Mika Westerberg > wrote: > > > When a GPIO is requested using gpiod_get_* APIs the intel pinctrl driver > > switches the pin to GPIO mode and makes sure interrupts are r

Re: [PATCH 0/3] pinctrl: Align Cannon Lake GPIO number space with Windows

2017-11-29 Thread Mika Westerberg
On Wed, Nov 29, 2017 at 01:49:01PM +0100, Linus Walleij wrote: > On Mon, Nov 27, 2017 at 2:54 PM, Mika Westerberg > wrote: > > > It turns out that the Cannon Lake GPIO driver in Windows uses different > > GPIO numbering scheme than what Linux uses. Instead of hardware numb

Re: [PATCH v2] ACPI / PMIC: constify platform_device_id

2017-11-29 Thread Mika Westerberg
f-by: Arvind Yadav Acked-by: Mika Westerberg

Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

2017-11-28 Thread Mika Westerberg
Let's limit the DMI quirks that try to preserve virtual IRQ > numbers on Strago boards to those that still carry BIOSes 1.0. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953 > Signed-off-by: Dmitry Torokhov Acked-by: Mika Westerberg Assuming there is no versio

Re: [PATCH 1/2] ACPI / PMIC: constify platform_device_id

2017-11-28 Thread Mika Westerberg
f-by: Arvind Yadav Acked-by: Mika Westerberg

Re: [PATCH 2/2] ACPI / PMIC: Constify platform_device_id

2017-11-28 Thread Mika Westerberg
f-by: Arvind Yadav You may want to change the title to mention the PMIC driver in question like: "ACPI / PMIC / bxtwc: ..." or so. The patch itself is fine, Acked-by: Mika Westerberg

[PATCH 3/3] pinctrl: cannonlake: Align GPIO number space with Windows

2017-11-27 Thread Mika Westerberg
mbering to follow the Windows GPIO driver numbering taking advantage of the gpio_base field introduced in the previous patch. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cannonlake.c | 65 -- 1 file changed, 34 insertions(+), 31 deletions(-) di

[PATCH 2/3] pinctrl: intel: Allow custom GPIO base for pad groups

2017-11-27 Thread Mika Westerberg
a new field (gpio_base) to the pad group structure and update the core Intel pinctrl driver to handle this accordingly. Passing 0 as gpio_base will use direct mapping so the existing drivers do not need to be modified. Passing -1 excludes the whole pad group from having GPIO mapping. Signed-off-by:

[PATCH 0/3] pinctrl: Align Cannon Lake GPIO number space with Windows

2017-11-27 Thread Mika Westerberg
he Windows GPIO driver numbering scheme. Mika Westerberg (3): gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation pinctrl: intel: Allow custom GPIO base for pad groups pinctrl: cannonlake: Align GPIO number space with Windows drivers/gpio/gpiolib-acpi.c

[PATCH 1/3] gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation

2017-11-27 Thread Mika Westerberg
s exactly same than the hardware pin 81 (SDMMC3_CD_B). As an added bonus this simplifies both the ACPI GPIO core code and the Cherryview pinctrl driver. Signed-off-by: Mika Westerberg --- drivers/gpio/gpiolib-acpi.c| 75 +- drivers/pinctrl/intel/pinctrl-

[PATCH 1/2] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry

2017-11-27 Thread Mika Westerberg
Make sure Thunderbolt maintainers get to see patches that touch documentation of the Thunderbolt driver as well. Signed-off-by: Mika Westerberg --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..478e4d342c2a 100644 --- a/MAINTAINERS

[PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts

2017-11-27 Thread Mika Westerberg
rings") Signed-off-by: Mika Westerberg --- drivers/thunderbolt/nhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 419a7a90bce0..f45bcbc63738 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c

Re: [PATCH v4] iio : Add cm3218 smbus ara and acpi support

2017-11-27 Thread Mika Westerberg
On Sat, Nov 25, 2017 at 02:00:34PM +, Jonathan Cameron wrote: > > There does not seem to be any way in ACPI to tell which "connection" is > > used to describe ARA so that part currently is something each driver > > needs to handle as they know the device the best. I don't think we have > > any

[PATCH] net: thunderbolt: Stop using zero to mean no valid DMA mapping

2017-11-24 Thread Mika Westerberg
ially allocated and unmap them when the interface is brought down. In between we just DMA sync the buffers for the CPU or device as needed. Signed-off-by: Mika Westerberg --- drivers/net/thunderbolt.c | 57 --- 1 file changed, 24 insertions(+), 33 del

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-23 Thread Mika Westerberg
On Thu, Nov 23, 2017 at 08:24:05PM +0800, Chris Chiu wrote: > Thanks for your confirmation. I've pushed this back to ASUS. They told me > there's a new official BIOS released, of course they don't know > whether if it helps > or not. I then upgraded it and the problem is gone. So it's truly a > BIO

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-21 Thread Mika Westerberg
On Tue, Nov 21, 2017 at 07:54:26PM +0800, Chris Chiu wrote: > Yup, I checked the value of the corresponded pin. It shows following before > suspend > pin 18 (GPIO_18) GPIO 0x40800102 0x00024075 > > Then after resume > pin 18 (GPIO_18) GPIO 0x40800102 0x00024075 [ACPI] OK, so ownership is changed

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-21 Thread Mika Westerberg
On Fri, Nov 17, 2017 at 04:11:31PM +0800, Chris Chiu wrote: > On Fri, Nov 17, 2017 at 2:49 PM, Mika Westerberg > wrote: > > On Thu, Nov 16, 2017 at 09:27:51PM +0800, Chris Chiu wrote: > >> On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg > >> wrote: > >&g

[PATCH] pinctrl: intel: Initialize GPIO properly when used through irqchip

2017-11-20 Thread Mika Westerberg
like interrupts suddenly stop firing completely and the touchpad stops responding to user input. Fix this by properly initializing the pin to GPIO mode also when it is used directly through irqchip. Reported-by: Daniel Drake Reported-by: Chris Chiu Signed-off-by: Mika Westerberg --- Chris

Re: [PATCH v4] iio : Add cm3218 smbus ara and acpi support

2017-11-20 Thread Mika Westerberg
+Jarkko On Sun, Nov 19, 2017 at 04:35:51PM +, Jonathan Cameron wrote: > On Thu, 2 Nov 2017 16:04:07 +0100 > Wolfram Sang wrote: > > > On Thu, Nov 02, 2017 at 02:35:50PM +, Jonathan Cameron wrote: > > > On Fri, 27 Oct 2017 18:27:02 +0200 > > > Marc CAPDEVILLE wrote: > > > > > > > On a

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-20 Thread Mika Westerberg
On Mon, Nov 20, 2017 at 01:18:51PM +0800, Chris Chiu wrote: > On Fri, Nov 17, 2017 at 9:52 PM, Mika Westerberg > wrote: > > On Fri, Nov 17, 2017 at 03:35:18PM +0200, Mika Westerberg wrote: > >> > pin 18 (GPIO_18) GPIO 0x40900100 0x00024075 > > > > Hmm, >

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Mika Westerberg
On Fri, Nov 17, 2017 at 03:35:18PM +0200, Mika Westerberg wrote: > > pin 18 (GPIO_18) GPIO 0x40900100 0x00024075 Hmm, If I decode 0x40900100 correctly PADCFG0_GPIROUTIOXAPIC (BIT 20) flag is set for the pin. This means the interrupt is routed to IO-APIC instead. Now, we do clear that flag

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Mika Westerberg
On Fri, Nov 17, 2017 at 09:21:48PM +0800, Chris Chiu wrote: > On Fri, Nov 17, 2017 at 7:00 PM, Mika Westerberg > wrote: > > On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote: > >> Hi Mika, > >> Here's the full dmesg log you need. The touchpad sto

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Mika Westerberg
On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote: > Hi Mika, > Here's the full dmesg log you need. The touchpad stop reporting at > the last of the log. > https://gist.github.com/mschiu77/a0b8d24a586a228c55eca30c87c71d41 Thanks! I did not spot anything suspicious in the i2c-hid init

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Mika Westerberg
On Fri, Nov 17, 2017 at 04:27:39PM +0800, Chris Chiu wrote: > On Thu, Nov 16, 2017 at 9:07 PM, Mika Westerberg > wrote: > > On Thu, Nov 16, 2017 at 12:01:24PM +, Daniel Drake wrote: > >> On Thu, Nov 16, 2017 at 11:52 AM, Mika Westerberg > >> wrote: > >&g

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-16 Thread Mika Westerberg
On Thu, Nov 16, 2017 at 09:27:51PM +0800, Chris Chiu wrote: > On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg > wrote: > > On Wed, Nov 15, 2017 at 06:19:56PM +0800, Chris Chiu wrote: > >> Hi Mika, > >> I've confirmed with Asus and they said it's the la

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-16 Thread Mika Westerberg
On Wed, Nov 15, 2017 at 04:08:32PM +0800, Chris Chiu wrote: > Yes, that’s the most weird part. Sounds pretty much like a BIOS issue. Do you know if there is a newer BIOS and have you tried that already?

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-16 Thread Mika Westerberg
On Thu, Nov 16, 2017 at 12:01:24PM +, Daniel Drake wrote: > On Thu, Nov 16, 2017 at 11:52 AM, Mika Westerberg > wrote: > > Please first check the signal with some analyzator if it works as > > expected and let's then figure out what needs to be fixed and where ;-) &

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-16 Thread Mika Westerberg
On Wed, Nov 15, 2017 at 06:19:56PM +0800, Chris Chiu wrote: > Hi Mika, > I've confirmed with Asus and they said it's the latest BIOS for > shipment and verified OK on Windows. So their BIOS team will not do > anything for this. I'll ask around if our Windows people know anything about this. My

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-16 Thread Mika Westerberg
On Thu, Nov 16, 2017 at 11:38:33AM +, Daniel Drake wrote: > Hi, > > We have 2 new laptop samples which use ACPI GpioInt for the I2C-HID > touchpad interrupt (via intel-gpio) and both models face different > issues related to this interrupt, which is level-triggered active low > (as defined by

[PATCH v5] PCI: hotplug: Drop checking of PCI_BRIDGE_CONTROL in *_unconfigure_device()

2017-11-09 Thread Mika Westerberg
think it makes sense to drop the whole PCI_BRIDGE_CONTROL check from pciehp_unconfigure_device(). While there do the same for shpchp_configure_device() based on the same reasoning and the fact that the same bug might trigger in standard PCI hotplug as well. Signed-off-by: Mika Westerberg --- The

Re: [PATCH v4] PCI: pciehp: Drop checking of PCI_BRIDGE_CONTROL in pciehp_unconfigure_device()

2017-11-07 Thread Mika Westerberg
On Mon, Nov 06, 2017 at 05:14:09PM -0600, Bjorn Helgaas wrote: > As you mention, shpchp_unconfigure_device() contains the same code; is > there any reason not to remove it from there as well? I don't see why we cannot remove that as well. But I have to admit that I don't know much about convention

Re: [PATCH 2/2] ACPI / PMIC: make intel_pmic_opregion_data structures const

2017-11-07 Thread Mika Westerberg
On Fri, Nov 03, 2017 at 04:03:48PM +0100, Bhumika Goyal wrote: > Make these structures as const as they are only passed to the function > intel_pmic_install_opregion_handler having the argument as const. > > Signed-off-by: Bhumika Goyal Acked-by: Mika Westerberg

Re: [PATCH 1/2] ACPI / PMIC: Make some pointers, structure field and function argument as const

2017-11-07 Thread Mika Westerberg
On Fri, Nov 03, 2017 at 04:03:47PM +0100, Bhumika Goyal wrote: > Make some pointers of type intel_pmic_opregion_data as const as they > do not modify the fields of the structure they point too. > After this change, make the data field of intel_pmic_opregion > structure const as this data field is u

[PATCH] MAINTAINERS: Add git tree for Thunderbolt development

2017-11-06 Thread Mika Westerberg
I will be gathering Thunderbolt related patches to this git tree with help of other Thunderbolt maintainers. Signed-off-by: Mika Westerberg --- Hi Andreas and Greg, If you are fine, I can pick up Thunderbolt related patches to this tree and then forward them to Greg via pull requests or patch

Re: [PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

2017-11-06 Thread Mika Westerberg
and connection > manager") > Signed-off-by: Gustavo A. R. Silva Good catch! Acked-by: Mika Westerberg Greg, can you pick this to your char-misc tree? Thanks. > --- > drivers/thunderbolt/tb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thunderb

Re: Excessive logging in thunderbolt driver

2017-11-01 Thread Mika Westerberg
On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote: > The thunderbolt driver needs to stop logging. > All these debug messages and the laptop is on battery with no devices > connected. > (I did use a USB key, but that is not a thunderbolt device). > > IMHO a production driver shoul

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-31 Thread Mika Westerberg
On Mon, Oct 30, 2017 at 03:28:46PM -0700, sathyanarayanan kuppuswamy wrote: > Hi, > > > On 10/30/2017 03:58 AM, Cyrille Pitchen wrote: > > Applied to the spi-nor/next branch of l2-mtd > > > > Just for info, this patch didn't apply directly, it misses a line in the > > list of > > PCI IDS: > >

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-30 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > This patch adds Intel Lewisburg PCH SPI serial flash controller super > SKU PCI ID. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Mika Westerberg

Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller

2017-10-29 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 12:18:28PM -0700, Kuppuswamy, Sathyanarayanan wrote: > Mika, Shall I re-base this patch to add super SKU ID? Yes, please.

Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller

2017-10-29 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: > On 10/29/2017 10:57 AM, sathyanarayanan.kuppusw...@linux.intel.com wrote: > > From: Kuppuswamy Sathyanarayanan > > > > > > This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. > > > > Signed-off-by: Kuppuswam

[PATCH v4] PCI: pciehp: Drop checking of PCI_BRIDGE_CONTROL in pciehp_unconfigure_device()

2017-10-25 Thread Mika Westerberg
is what this patch does. Signed-off-by: Mika Westerberg --- The previous version of the patch can be found here: https://patchwork.kernel.org/patch/10024145/ Changes from the previous version: * Drop the whole PCI_BRIDGE_CONTROL check * Update patch subject to reflect that drivers/pci

[PATCH] thunderbolt: Drop sequence number check from tb_xdomain_match()

2017-10-25 Thread Mika Westerberg
k to macOS again, fix this so that we drop the whole sequence number check. This effectively works exactly the same than it worked before the aforementioned commit. This also follows the logic the original P2P networking code used. Signed-off-by: Mika Westerberg --- This applies on top of net-next.

[PATCH v3] PCI: pciehp: Check for valid PCI_BRIDGE_CONTROL in pciehp_unconfigure_device()

2017-10-24 Thread Mika Westerberg
read bctl value against 0x (device is not present anymore) before determining whether the device is a display or not. Signed-off-by: Mika Westerberg --- Hi Bjorn, This is an updated version of the patch 8/8 in my "PCI: Improvements for native PCIe hotplug" patch series and applies

Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency

2017-10-24 Thread Mika Westerberg
superfluous hence remove it. > > Suggested-by: Arnd Bergmann > Signed-off-by: Bin Meng Acked-by: Mika Westerberg

Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-24 Thread Mika Westerberg
On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote: > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Enforce dependency on PCI > > drivers/mtd/spi-nor/Kconfig | 3 ++- > 1

[PATCH 2/2] pinctrl: intel: Add Intel Cedar Fork PCH pin controller support

2017-10-23 Thread Mika Westerberg
Intel Cedar Fork PCH is the successor of Intel Denverton PCH but it is based on the newer GPIO/pinctrl hardware block. Add a new pinctrl/GPIO driver to support it. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/Kconfig | 8 + drivers/pinctrl/intel/Makefile

[PATCH 1/2] pinctrl: intel: Make offset to interrupt status register configurable

2017-10-23 Thread Mika Westerberg
Some GPIO blocks have the interrupt status (GPI_IS) offset different than it normally is, so make it configurable. If no offset is specified we use the default. While there remove two unused constants from the core driver. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-23 Thread Mika Westerberg
On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote: > > Also, the 'depends on EXPERT' statement looks misplaced, > > enabling EXPERT should only be there to allow you to turn > > extra things *off*, not to hide device drivers. > > > > I will leave this to Mika to comment the "EXPERT" usage.

Re: [PATCH v2 8/8] PCI: pciehp: Check that the device is really present before touching it

2017-10-23 Thread Mika Westerberg
On Fri, Oct 20, 2017 at 04:15:02PM -0500, Bjorn Helgaas wrote: > > + > > + /* Check if the device is really there anymore */ > > + present = presence ? pci_device_is_present(dev) : false; > > + > > + if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE && present) { > >

Re: [PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-13 Thread Mika Westerberg
igned-off-by: Joakim Tjernlund > > --- > > drivers/mfd/lpc_ich.c | 1 + > > 1 file changed, 1 insertion(+) > > Looks perfectly reasonable to me. Would be good to receive a nod from > one of the Intel or Extreme Engineering guys though. Acked-by: Mika Westerberg

[PATCH v2 0/8] PCI: Improvements for native PCIe hotplug

2017-10-13 Thread Mika Westerberg
* Add another separate loop to count number of hotplug and normal bridges * Reword comment about two scans * Generalize patches 4 and 5 so that they could work also on conventional PCI by dropping tests for PCIe. Mika Westerberg (8): PCI: Move pci_hp_add_bridge() to drivers/pci/prob

[PATCH v2 1/8] PCI: Move pci_hp_add_bridge() to drivers/pci/probe.c

2017-10-13 Thread Mika Westerberg
There is not much point of having a file with a single function in it. Instead we can just move pci_hp_add_bridge() to drivers/pci/probe.c and make it available always when PCI core is enabled. Signed-off-by: Mika Westerberg --- drivers/pci/Makefile | 3 --- drivers/pci/hotplug-pci.c | 29

[PATCH v2 4/8] PCI: Distribute available buses to hotplug capable bridges

2017-10-13 Thread Mika Westerberg
later on. While there update kernel docs of the affected functions. Signed-off-by: Mika Westerberg --- drivers/pci/probe.c | 156 ++-- 1 file changed, 138 insertions(+), 18 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index

[PATCH v2 2/8] PCI: Open-code the two pass loop when scanning bridges

2017-10-13 Thread Mika Westerberg
ned-off-by: Mika Westerberg --- drivers/pci/probe.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 7302cef51d3f..107052f1dad9 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2398,7 +239

[PATCH v2 5/8] PCI: Distribute available resources to hotplug capable bridges

2017-10-13 Thread Mika Westerberg
ports are too small. Here we follow what we already did for bus number and assign all available extra resources to hotplug capable bridges. This makes it possible to extend the hierarchy later. Signed-off-by: Mika Westerberg --- drivers/pci/setup-bus.c | 177

[PATCH v2 8/8] PCI: pciehp: Check that the device is really present before touching it

2017-10-13 Thread Mika Westerberg
calling pci_device_is_present() for it before we touch it any further. Signed-off-by: Mika Westerberg --- drivers/pci/hotplug/pciehp_pci.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c index

[PATCH v2 7/8] PCI: pciehp: Do not clear Presence Detect Changed during initialization

2017-10-13 Thread Mika Westerberg
untouched during initialization. Then once the event is unmasked we get an interrupt and handle the hotplug event properly. Signed-off-by: Mika Westerberg --- drivers/pci/hotplug/pciehp_hpc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pci/hotplug

[PATCH v2 3/8] PCI: Do not allocate more buses than available in parent

2017-10-13 Thread Mika Westerberg
max=40 pci_bus :08: busn_res: [bus 08-ff] end is updated to 40 Instead of allowing this we limit the subordinate number to be less than or equal the maximum subordinate number allocated for the parent bus (if it has any). Signed-off-by: Mika Westerberg --- drivers/pci/probe.c | 7 ++- 1

[PATCH v2 6/8] PCI: pciehp: Fix race condition handling surprise link down

2017-10-13 Thread Mika Westerberg
instead to avoid scaring users. This is based on the original work by Ashok Raj. Link: https://patchwork.kernel.org/patch/9469023 Suggested-by: Bjorn Helgaas Signed-off-by: Mika Westerberg --- drivers/pci/hotplug/pciehp_ctrl.c | 7 --- drivers/pci/hotplug/pciehp_hpc.c | 2 +- drivers/pci

Re: [PATCH] thunderbolt: Fix some right shifting to zero bugs

2017-10-13 Thread Mika Westerberg
On Fri, Oct 13, 2017 at 02:29:59PM +0300, Dan Carpenter wrote: > The problematic code looks like this: > > res_seq = res_hdr->xd_hdr.length_sn & TB_XDOMAIN_SN_MASK; > res_seq >>= TB_XDOMAIN_SN_SHIFT; > > TB_XDOMAIN_SN_SHIFT is 27, and right shifting a u8 27 bits is always > going to r

Re: [PATCH 3/7] PCI: Distribute available buses to hotplug capable PCIe downstream ports

2017-10-13 Thread Mika Westerberg
On Thu, Oct 12, 2017 at 01:32:23PM -0500, Bjorn Helgaas wrote: > On Thu, Oct 12, 2017 at 03:47:03PM +0300, Mika Westerberg wrote: > > On Wed, Oct 11, 2017 at 06:32:43PM -0500, Bjorn Helgaas wrote: > > > On Tue, Sep 26, 2017 at 05:17:16PM +0300, Mika Westerberg wrote: > > &

Re: [PATCH] PM / QoS: Drop PM_QOS_FLAG_REMOTE_WAKEUP

2017-10-13 Thread Mika Westerberg
end if they can > generate wakeup signals, so drop it. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg

Re: [PATCH 3/7] PCI: Distribute available buses to hotplug capable PCIe downstream ports

2017-10-12 Thread Mika Westerberg
On Wed, Oct 11, 2017 at 06:32:43PM -0500, Bjorn Helgaas wrote: > On Tue, Sep 26, 2017 at 05:17:16PM +0300, Mika Westerberg wrote: > > System BIOS sometimes allocates extra bus space for hotplug capable PCIe > > root/downstream ports. This space is needed if the device plugged to th

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-10 Thread Mika Westerberg
On Mon, Oct 09, 2017 at 04:18:10PM -0700, Darren Hart wrote: > I'm not sure how we would deal with it in the trees. Best to note this during > the merge window - whichever goes in second. Test merge will identify the > merge > conflict, and we can include a note to Linus on the preference. That

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-09 Thread Mika Westerberg
On Mon, Oct 09, 2017 at 06:56:33PM +0100, Mark Brown wrote: > +Networking over Thunderbolt cable > +- > +Thunderbolt technology allows software communication across two hosts > +connected by a Thunderbolt cable. > + > +It is possible to tunnel any kind of traff

[PATCH] thunderbolt: Initialize Thunderbolt bus earlier

2017-10-09 Thread Mika Westerberg
safe side also add a check for properly initialized xdomain_property_dir to tb_register_property_dir(). Reported-by: kernel test robot Signed-off-by: Mika Westerberg --- Hi David, This fixes a crash introduced in the Thunderbolt networking patches, so I'm wondering could you take this to

Re: [PATCH 0/7] PCI: Improvements for native PCIe hotplug

2017-10-09 Thread Mika Westerberg
On Tue, Sep 26, 2017 at 05:17:13PM +0300, Mika Westerberg wrote: > Hi, > > Currently when plugging PCIe device using native PCIe hotplug Linux PCI > core tries to allocate bus space and resources so that the newly enumerated > topology barely fits there. Now, if the PCIe topolog

Re: [PATCH] pinctrl: cherryview: fix issues caused by dynamic gpio irqs mapping

2017-10-06 Thread Mika Westerberg
On Wed, Oct 04, 2017 at 09:42:49AM +0300, Mika Westerberg wrote: > On Tue, Oct 03, 2017 at 12:00:49PM -0500, Grygorii Strashko wrote: > > New GPIO IRQs are allocated and mapped dynamically by default when > > GPIO IRQ infrastructure is used by cherryview-pinctrl driver. > >

Re: [PATCH] pinctrl: cherryview: fix issues caused by dynamic gpio irqs mapping

2017-10-04 Thread Mika Westerberg
On Wed, Oct 04, 2017 at 12:07:34PM -0400, Chris Gorman wrote: > Tested-by: Chris Gorman I guess you sent this because of the "Tested-by", right? It is enough if you reply to the original thread (the one posted by Grygorii yesterday) and say something like: Works for me, Tested-by: ... Then

Re: [PATCH] pinctrl: cherryview: fix issues caused by dynamic gpio irqs mapping

2017-10-03 Thread Mika Westerberg
ml/2017/9/28/153 > Cc: Andy Shevchenko > Cc: Chris Gorman > Cc: Mika Westerberg > Cc: Heikki Krogerus > Signed-off-by: Grygorii Strashko > Reported-by: Chris Gorman > Reported-by: Mika Westerberg Looks reasonable to me. Thanks for taking care of this! Chris, can you try if this fixes the issue and provide your Tested-by?

Re: [PATCH] pinctrl: cherryview: fix issues caused by dynamic gpio irqs mapping

2017-10-03 Thread Mika Westerberg
On Tue, Oct 03, 2017 at 08:54:30PM +0300, Andy Shevchenko wrote: > I'm not sure about this approach. It might be some other broken BIOS > discovered with some other driver (like pinctrl-baytrail.c as an > hypothetical example). Let's deal that separately if it ever happens. > Alternative is to de

[PATCH v3 12/19] thunderbolt: Use spinlock in ring serialization

2017-10-02 Thread Mika Westerberg
This makes it possible to enqueue frames also from atomic context which is needed for example, when networking packets are sent over a Thunderbolt cable. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- drivers

[PATCH v3 02/19] thunderbolt: Remove __packed from ICM message structures

2017-10-02 Thread Mika Westerberg
These messages are all 32-byte aligned and they should be packed without the __packed attribute just fine. It also allows compiler to generate better code on some architectures. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- drivers/thunderbolt

[PATCH v3 00/19] Thunderbolt networking

2017-10-02 Thread Mika Westerberg
have the networking service enabled by default). For Linux to Linux connection one host needs to load the networking driver first (so that the other side can locate the networking service and load the corresponding driver). Amir Levy (1): net: Add support for networking over Thunderbolt cable Mika

[PATCH v3 08/19] thunderbolt: Configure interrupt throttling for all interrupts

2017-10-02 Thread Mika Westerberg
This will keep the interrupt delivery rate reasonable. The value used here (128 us) is a recommendation from the hardware people. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat

[PATCH v3 09/19] thunderbolt: Add support for frame mode

2017-10-02 Thread Mika Westerberg
used for this purpose. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/ctl.c | 3 +- drivers/thunderbolt/nhi.c | 76

<    4   5   6   7   8   9   10   11   12   13   >