Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mike Turquette
Quoting Thierry Reding (2014-07-30 02:34:57) > On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: > > On 07/29/2014 02:19 PM, Mike Turquette wrote: > > >Quoting Mikko Perttunen (2014-07-29 01:47:35) > > >>On 22/07/14 19:57, Stephen Warren wrote: > &

[GIT PULL] clk: fixes for 3.16, part 2

2014-07-31 Thread Mike Turquette
The following changes since commit 64aa90f26c06e1cb2aacfb98a7d0eccfbd6c1a91: Linux 3.16-rc7 (2014-07-27 12:41:55 -0700) are available in the git repository at: git://git.linaro.org/people/mike.turquette/linux.git tags/clk-fixes-for-linus for you to fetch changes up to

[GIT PULL] clk: fixes for 3.16, part 2

2014-07-31 Thread Mike Turquette
The following changes since commit 64aa90f26c06e1cb2aacfb98a7d0eccfbd6c1a91: Linux 3.16-rc7 (2014-07-27 12:41:55 -0700) are available in the git repository at: git://git.linaro.org/people/mike.turquette/linux.git tags/clk-fixes-for-linus for you to fetch changes up to

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mike Turquette
Quoting Thierry Reding (2014-07-30 02:34:57) On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: On 07/29/2014 02:19 PM, Mike Turquette wrote: Quoting Mikko Perttunen (2014-07-29 01:47:35) On 22/07/14 19:57, Stephen Warren wrote: On 07/11/2014 08:18 AM, Mikko Perttunen wrote

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Mike Turquette
Quoting Tomasz Figa (2014-07-31 15:17:29) Humberto, [dropping few addresses from Cc as this topic is rather irrelevant for them and adding Mike and Sylwester] On 31.07.2014 23:19, Humberto Naves wrote: Hi, On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote:

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-31 Thread Mike Turquette
Quoting Stephen Warren (2014-07-31 12:53:54) On 07/31/2014 01:06 PM, Mike Turquette wrote: Quoting Thierry Reding (2014-07-30 02:34:57) On Tue, Jul 29, 2014 at 04:14:44PM -0600, Stephen Warren wrote: On 07/29/2014 02:19 PM, Mike Turquette wrote: Quoting Mikko Perttunen (2014-07-29 01:47

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-30 Thread Mike Turquette
Quoting Tero Kristo (2014-07-30 05:27:07) > On 07/30/2014 08:53 AM, Peter Ujfalusi wrote: > > On 07/29/2014 07:12 PM, Mike Turquette wrote: > >>> Oh yea, seems this got lost into the myriad of branches I have. I can push > >>> this on top of my

Re: linux-next: manual merge of the clk tree with the driver-core tree

2014-07-30 Thread Mike Turquette
Quoting Stephen Rothwell (2014-07-30 01:57:08) > Hi Mike, > > Today's linux-next merge of the clk tree got a conflict in > drivers/base/platform.c between commit 3d713e0e382e ("driver core: > platform: add device binding path 'driver_override'") from the > driver-core tree and commit 86be408bfbd8

Re: linux-next: manual merge of the clk tree with the driver-core tree

2014-07-30 Thread Mike Turquette
Quoting Stephen Rothwell (2014-07-30 01:57:08) Hi Mike, Today's linux-next merge of the clk tree got a conflict in drivers/base/platform.c between commit 3d713e0e382e (driver core: platform: add device binding path 'driver_override') from the driver-core tree and commit 86be408bfbd8 (clk:

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-30 Thread Mike Turquette
Quoting Tero Kristo (2014-07-30 05:27:07) On 07/30/2014 08:53 AM, Peter Ujfalusi wrote: On 07/29/2014 07:12 PM, Mike Turquette wrote: Oh yea, seems this got lost into the myriad of branches I have. I can push this on top of my for-v3.17/ti-clk-drv if you like. That is the easiest thing

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-29 Thread Mike Turquette
Quoting Mikko Perttunen (2014-07-29 01:47:35) > On 22/07/14 19:57, Stephen Warren wrote: > > On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > >> +static int emc_debug_rate_set(void *data, u64 rate) > >> +{ > >> +struct tegra_emc *tegra = data; > >> + > >> +return

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-29 Thread Mike Turquette
On Tue, Jul 29, 2014 at 1:23 AM, Tero Kristo wrote: > On 07/29/2014 09:27 AM, Mike Turquette wrote: >> >> Quoting Peter Ujfalusi (2014-07-14 03:10:28) >>> >>> On 05/06/2014 04:39 PM, Peter Ujfalusi wrote: >>>>>> >>>>>

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-07-29 Thread Mike Turquette
Quoting Tushar Behera (2014-07-10 23:18:54) > On 06/13/2014 02:39 AM, Mike Turquette wrote: > > Quoting Tushar Behera (2014-06-12 00:29:23) > >> On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette > >> wrote: > >>> Quoting Tushar Behera (2014-06-10 22:32:17

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-29 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-07-14 03:10:28) > On 05/06/2014 04:39 PM, Peter Ujfalusi wrote: > >>> Tero: can I have your ack for this patch or do you have further concerns? > >> > >> Yea looks good to me, except for the fact that there is some work on > >> getting > >> default rate/parent support

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-29 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-07-14 03:10:28) On 05/06/2014 04:39 PM, Peter Ujfalusi wrote: Tero: can I have your ack for this patch or do you have further concerns? Yea looks good to me, except for the fact that there is some work on getting default rate/parent support through DT. I

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-07-29 Thread Mike Turquette
Quoting Tushar Behera (2014-07-10 23:18:54) On 06/13/2014 02:39 AM, Mike Turquette wrote: Quoting Tushar Behera (2014-06-12 00:29:23) On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Tushar Behera (2014-06-10 22:32:17) When the output clock of AUDSS

Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration

2014-07-29 Thread Mike Turquette
On Tue, Jul 29, 2014 at 1:23 AM, Tero Kristo t-kri...@ti.com wrote: On 07/29/2014 09:27 AM, Mike Turquette wrote: Quoting Peter Ujfalusi (2014-07-14 03:10:28) On 05/06/2014 04:39 PM, Peter Ujfalusi wrote: Tero: can I have your ack for this patch or do you have further concerns? Yea

Re: [PATCH 8/8] clk: tegra: Add EMC clock driver

2014-07-29 Thread Mike Turquette
Quoting Mikko Perttunen (2014-07-29 01:47:35) On 22/07/14 19:57, Stephen Warren wrote: On 07/11/2014 08:18 AM, Mikko Perttunen wrote: +static int emc_debug_rate_set(void *data, u64 rate) +{ +struct tegra_emc *tegra = data; + +return clk_set_rate(tegra-hw.clk, rate); +} +

Re: [PATCH v3 00/15] Add Flexgen Clock support

2014-07-28 Thread Mike Turquette
Quoting Gabriel FERNANDEZ (2014-07-15 08:20:16) > Changes in v3: > - Change commit message > - Remove uncessary (void *) cast > - add a block diagram for flexgen clock binding documentation > > Changes in v2: > - use static const for clkgen_pll_data and stm_fs tables (from >Peter Griffin

Re: [PATCH v3 06/15] drivers: clk: st: STiH407: Support for Flexgen Clocks

2014-07-28 Thread Mike Turquette
Quoting Gabriel FERNANDEZ (2014-07-15 08:20:22) > +static const char ** __init flexgen_get_parents(struct device_node *np, > + int *num_parents) > +{ > + const char **parents; > + int nparents, i; > + > + nparents =

Re: [GIT PULL] qcom clock changes for 3.17

2014-07-28 Thread Mike Turquette
Quoting Stephen Boyd (2014-07-28 10:57:02) > On 07/28, Kumar Gala wrote: > > > > On Jul 21, 2014, at 4:26 PM, Stephen Boyd wrote: > > > > > Hi Mike, > > > > > > The following changes since commit > > > a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: > > > > > > Linux 3.16-rc2 (2014-06-21 19:02:54

Re: [GIT PULL] qcom clock changes for 3.17

2014-07-28 Thread Mike Turquette
Quoting Stephen Boyd (2014-07-28 10:57:02) On 07/28, Kumar Gala wrote: On Jul 21, 2014, at 4:26 PM, Stephen Boyd sb...@codeaurora.org wrote: Hi Mike, The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: Linux 3.16-rc2 (2014-06-21 19:02:54

Re: [PATCH v3 06/15] drivers: clk: st: STiH407: Support for Flexgen Clocks

2014-07-28 Thread Mike Turquette
Quoting Gabriel FERNANDEZ (2014-07-15 08:20:22) +static const char ** __init flexgen_get_parents(struct device_node *np, + int *num_parents) +{ + const char **parents; + int nparents, i; + + nparents =

Re: [PATCH v3 00/15] Add Flexgen Clock support

2014-07-28 Thread Mike Turquette
Quoting Gabriel FERNANDEZ (2014-07-15 08:20:16) Changes in v3: - Change commit message - Remove uncessary (void *) cast - add a block diagram for flexgen clock binding documentation Changes in v2: - use static const for clkgen_pll_data and stm_fs tables (from Peter Griffin review)

Re: [PATCH v8 00/13] Add Maxim 77802 PMIC support

2014-07-25 Thread Mike Turquette
13] clk: max77686: Convert to the generic max clock driver > [PATCH v8 07/13] clk: max77686: Improve Maxim 77686 PMIC clocks binding > [PATCH v8 08/13] clk: Add driver for Maxim 77802 PMIC clocks > [PATCH v8 09/13] clk: max77802: Add DT binding documentation For patches 4-9: Acked-by

Re: [PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-07-25 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-07-03 10:25:53) > On 18/06/14 17:29, Sylwester Nawrocki wrote: > > This patch adds helper functions to configure clock parents and rates > > as specified through 'assigned-clock-parents', 'assigned-clock-rates' > > DT properties for a clock provider or clock

Re: [PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-07-25 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-07-03 10:25:53) On 18/06/14 17:29, Sylwester Nawrocki wrote: This patch adds helper functions to configure clock parents and rates as specified through 'assigned-clock-parents', 'assigned-clock-rates' DT properties for a clock provider or clock consumer

Re: [PATCH v8 00/13] Add Maxim 77802 PMIC support

2014-07-25 Thread Mike Turquette
77686 PMIC clocks binding [PATCH v8 08/13] clk: Add driver for Maxim 77802 PMIC clocks [PATCH v8 09/13] clk: max77802: Add DT binding documentation For patches 4-9: Acked-by: Mike Turquette mturque...@linaro.org Regards, Mike [PATCH v8 10/13] rtc: max77686: Allow the max77686 rtc to wakeup

Re: [PATCH v2 1/2] clk: samsung: exynos4: Enable ARMCLK down feature

2014-07-23 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-07-18 07:36:32) > Enable ARMCLK down feature on all Exynos4 SoCs. The frequency of > ARMCLK will be reduced upon entering idle mode (WFI or WFE). > > The feature behaves like very fast cpufreq ondemand governor. In idle > mode this reduces energy consumption on

Re: [PATCH v2 1/2] clk: samsung: exynos4: Enable ARMCLK down feature

2014-07-23 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-07-18 07:36:32) Enable ARMCLK down feature on all Exynos4 SoCs. The frequency of ARMCLK will be reduced upon entering idle mode (WFI or WFE). The feature behaves like very fast cpufreq ondemand governor. In idle mode this reduces energy consumption on full

[GIT PULL] clk: fixes for 3.16

2014-07-13 Thread Mike Turquette
the clock tree description Himangi Saraogi (1): clk: sunxi: fix devm_ioremap_resource error detection code Julia Lawall (1): clk: ti: dra7: return error code in failure case Krzysztof Kozlowski (1): clk: s2mps11: Fix double free corruption during driver unbind Mike Turquette (2):

Re: [patch 0/2] clk: spear3xx: Make it actually work

2014-07-13 Thread Mike Turquette
Quoting Thomas Gleixner (2014-06-19 14:52:23) > This code is broken since commit 5df33a62c (SPEAr: Switch to common > clock framework). Sigh... > > The first patch fixes that issue and the second one makes the uarts1/2 > usable. Applied to clk-fixes. Regards, Mike > > Quality stuff that. >

Re: [patch 0/2] clk: spear3xx: Make it actually work

2014-07-13 Thread Mike Turquette
Quoting Thomas Gleixner (2014-06-19 14:52:23) This code is broken since commit 5df33a62c (SPEAr: Switch to common clock framework). Sigh... The first patch fixes that issue and the second one makes the uarts1/2 usable. Applied to clk-fixes. Regards, Mike Quality stuff that. Thanks,

[GIT PULL] clk: fixes for 3.16

2014-07-13 Thread Mike Turquette
description Himangi Saraogi (1): clk: sunxi: fix devm_ioremap_resource error detection code Julia Lawall (1): clk: ti: dra7: return error code in failure case Krzysztof Kozlowski (1): clk: s2mps11: Fix double free corruption during driver unbind Mike Turquette (2): Merge branch

Re: [PATCH 00/13] Tegra124 CL-DVFS / DFLL clocksource, plus cpufreq

2014-07-11 Thread Mike Turquette
Quoting Tuomas Tynkkynen (2014-07-10 14:42:36) > This series implements the DFLL/CL-DVFS clock source for the fast CPU > cluster on Tegra124, and a cpufreq driver that uses the DFLL for > clocking the CPU. Most of this is based on Paul Walmsley's public patch > set from December 2013, which is

Re: [PATCH 00/13] Tegra124 CL-DVFS / DFLL clocksource, plus cpufreq

2014-07-11 Thread Mike Turquette
Quoting Tuomas Tynkkynen (2014-07-10 14:42:36) This series implements the DFLL/CL-DVFS clock source for the fast CPU cluster on Tegra124, and a cpufreq driver that uses the DFLL for clocking the CPU. Most of this is based on Paul Walmsley's public patch set from December 2013, which is

Re: [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2

2014-07-03 Thread Mike Turquette
Quoting Viresh Kumar (2014-07-02 19:44:04) > On 3 July 2014 06:54, Stephen Boyd wrote: > > I gave it a spin. It works so you can have my > > > > Tested-by: Stephen Boyd > > Thanks, all suggested improvements are made and pushed again with > your Tested-by.. > > > I'm still concerned about the

Re: [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2

2014-07-03 Thread Mike Turquette
Quoting Viresh Kumar (2014-07-02 19:44:04) On 3 July 2014 06:54, Stephen Boyd sb...@codeaurora.org wrote: I gave it a spin. It works so you can have my Tested-by: Stephen Boyd sb...@codeaurora.org Thanks, all suggested improvements are made and pushed again with your Tested-by.. I'm

RE: [PATCH v2 0/4] Add support for Exynos clock output configuration

2014-07-02 Thread Mike Turquette
Quoting Kukjin Kim (2014-06-25 03:36:51) > Tomasz Figa wrote: > > > Hi Tomasz, > > > On all Exynos SoCs there is a dedicated CLKOUT pin that allows many of > > internal SoC clocks to be output from the SoC. The hardware structure > > Yeah, because the CLKOUT pin is used for measure of the clock

Re: [PATCH v3] clk: define and export clk_debugs_add_file

2014-07-02 Thread Mike Turquette
Quoting Peter De Schrijver (2014-06-26 08:00:53) > Define and export a new function clk_debugs_add_file which adds a file > to a existing clock's debugfs directory. This can be used by clock > providers to add debugfs entries which are not related to a specific clock > type. Examples include the

Re: [PATCH v4 0/6] clk: sunxi: fixes, cleanups and A23 basic clocks

2014-07-02 Thread Mike Turquette
Quoting Chen-Yu Tsai (2014-06-26 08:55:38) > Hi everyone, > > This is v4 of the sun8i clock series, which adds basic clock > support for the A23 SoC. It is based on my initial sun8i bring > up series [1]. This series was split up from the original A23 > series [2]. Yet to come are more clocks,

Re: [PATCH v2] clk: s2mps11: Fix clk_ops

2014-07-02 Thread Mike Turquette
Quoting Karol Wrona (2014-07-01 10:13:59) > s2mps11 clocks had registered callbacks for prepare ,unprepare and is_enabled. > During disabling unused clocks the lack of is_prepared caused that unused > s2mps11 clocks were not unprepared and stayed active. > > Regmap_read is cached so it can be

Re: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set

2014-07-02 Thread Mike Turquette
Quoting Boris BREZILLON (2014-07-02 01:18:11) > On Tue, 1 Jul 2014 16:12:12 +0200 > Alexandre Belloni wrote: > > > When the main crystal frequency is not set, the main clock is > > approximated using the MAINF value in the CKGR_MCFR register. Warn > > the user in that case. > > > >

Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-07-02 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-07-02 03:17:54) > Hello Mike, > > On 07/01/2014 07:29 PM, Mike Turquette wrote: > > Quoting Javier Martinez Canillas (2014-06-26 11:15:36) > >> Like most clock drivers, the Maxim 77686 PMIC clock binding > >> follows the

Re: [PATCH] clk: sunxi: fix devm_ioremap_resource error detection code

2014-07-02 Thread Mike Turquette
Quoting Emilio López (2014-06-28 14:38:26) > Hi, > > El 28/06/14 14:58, Boris BREZILLON escribió: > > Hello, > > > > On 28/06/2014 19:23, Himangi Saraogi wrote: > >> devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. > >> > >> A simplified version of the semantic match that

Re: [PATCH] clk: sunxi: fix devm_ioremap_resource error detection code

2014-07-02 Thread Mike Turquette
Quoting Emilio López (2014-06-28 14:38:26) Hi, El 28/06/14 14:58, Boris BREZILLON escribió: Hello, On 28/06/2014 19:23, Himangi Saraogi wrote: devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. A simplified version of the semantic match that finds this problem is

Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-07-02 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-07-02 03:17:54) Hello Mike, On 07/01/2014 07:29 PM, Mike Turquette wrote: Quoting Javier Martinez Canillas (2014-06-26 11:15:36) Like most clock drivers, the Maxim 77686 PMIC clock binding follows the convention that the #clock-cells property

Re: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set

2014-07-02 Thread Mike Turquette
Quoting Boris BREZILLON (2014-07-02 01:18:11) On Tue, 1 Jul 2014 16:12:12 +0200 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: When the main crystal frequency is not set, the main clock is approximated using the MAINF value in the CKGR_MCFR register. Warn the user in that

Re: [PATCH v2] clk: s2mps11: Fix clk_ops

2014-07-02 Thread Mike Turquette
Quoting Karol Wrona (2014-07-01 10:13:59) s2mps11 clocks had registered callbacks for prepare ,unprepare and is_enabled. During disabling unused clocks the lack of is_prepared caused that unused s2mps11 clocks were not unprepared and stayed active. Regmap_read is cached so it can be called

Re: [PATCH v4 0/6] clk: sunxi: fixes, cleanups and A23 basic clocks

2014-07-02 Thread Mike Turquette
Quoting Chen-Yu Tsai (2014-06-26 08:55:38) Hi everyone, This is v4 of the sun8i clock series, which adds basic clock support for the A23 SoC. It is based on my initial sun8i bring up series [1]. This series was split up from the original A23 series [2]. Yet to come are more clocks, reset

Re: [PATCH v3] clk: define and export clk_debugs_add_file

2014-07-02 Thread Mike Turquette
Quoting Peter De Schrijver (2014-06-26 08:00:53) Define and export a new function clk_debugs_add_file which adds a file to a existing clock's debugfs directory. This can be used by clock providers to add debugfs entries which are not related to a specific clock type. Examples include the

RE: [PATCH v2 0/4] Add support for Exynos clock output configuration

2014-07-02 Thread Mike Turquette
Quoting Kukjin Kim (2014-06-25 03:36:51) Tomasz Figa wrote: Hi Tomasz, On all Exynos SoCs there is a dedicated CLKOUT pin that allows many of internal SoC clocks to be output from the SoC. The hardware structure Yeah, because the CLKOUT pin is used for measure of the clock for debug

Re: [PATCH 2/2] MIPS: Alchemy: common clock framework integration

2014-07-01 Thread Mike Turquette
Quoting Manuel Lauss (2014-06-29 09:57:35) > Expose chip-internal configurable clocks to the common clk framework, > and fix a few drivers to take advantage of it. Thanks for the patch series! Both patches cover a lot of ground, but I'll focus on #2. It would be best to split the driver changes

Re: [PATCH v2] clk: s2mps11: Fix double free corruption during driver unbind

2014-07-01 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-06-27 05:21:10) > After unbinding the driver memory was corrupted by double free of > clk_lookup structure. This lead to OOPS when re-binding the driver > again. > > The driver allocated memory for 'clk_lookup' with devm_kzalloc. During > driver removal this

Re: [RESEND 0/2] clk: Support for Palmas clk32kg and clk32kgaudio clocks

2014-07-01 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-06-26 23:01:09) > Hi Mike, > > This is a resend of the v2 version of the palmas clock driver which seamingly > missed the 3.16 merge window. I have added Nishanth's Reviewed-by tag to the > patches. Thanks for the resend. Applied to clk-next. Regards, Mike > >

Re: [RESEND 2/2] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks

2014-07-01 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-06-29 22:56:55) > Hi Javier, > > On 06/27/2014 09:23 PM, Javier Martinez Canillas wrote: > > Hello Peter, > > > > On Fri, Jun 27, 2014 at 8:01 AM, Peter Ujfalusi > > wrote: > >> Palmas class of devices can provide 32K clock(s) to be used by other > >> devices > >>

Re: [PATCH] clk: Add tracepoints for hardware operations

2014-07-01 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-30 18:07:49) > On 06/30/14 17:52, Steven Rostedt wrote: > > On Mon, 30 Jun 2014 16:56:39 -0700 > > Stephen Boyd wrote: > > > >> @@ -483,10 +486,12 @@ static void clk_unprepare_unused_subtree(struct clk > >> *clk) > >> return; > >> > >> if

Re: [PATCH v2 1/1] clk: Fix build warnings

2014-07-01 Thread Mike Turquette
Quoting Sachin Kamat (2014-06-30 23:26:34) > ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined. > Thus, make their compilation conditional to fix the below warnings introduced > by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"): > drivers/clk/clk.c:40:27: warning:

Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0

2014-07-01 Thread Mike Turquette
Quoting Viresh Kumar (2014-07-01 04:14:04) > On 1 July 2014 00:03, Rob Herring wrote: > >> What about comparing "clocks" property in cpu DT nodes? > > > > What if a different clock is selected for some reason. > > I don't know why that will happen for CPUs sharing clock line. > > > I think a

Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-07-01 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-06-26 11:15:35) > This patch adds a dt-binding include for Maxim 77686 > PMIC clock IDs that can be to be shared between the > clk-max77686 clock driver and DeviceTree source files. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof

Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-07-01 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-06-26 11:15:36) > Like most clock drivers, the Maxim 77686 PMIC clock binding > follows the convention that the "#clock-cells" property is > used to specify the number of cells in a clock provider. > > But the binding document is not clear enough that it

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-07-01 Thread Mike Turquette
Quoting Yadwinder Singh Brar (2014-06-29 21:01:36) > Hi Javier, > > On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas > wrote: > > Maxim Integrated Power Management ICs are very similar with > > regard to their clock outputs. Most of the clock drivers for > > these chips are duplicating

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-07-01 Thread Mike Turquette
Quoting Yadwinder Singh Brar (2014-06-29 21:01:36) Hi Javier, On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these

Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-07-01 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-06-26 11:15:36) Like most clock drivers, the Maxim 77686 PMIC clock binding follows the convention that the #clock-cells property is used to specify the number of cells in a clock provider. But the binding document is not clear enough that it shall be

Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-07-01 Thread Mike Turquette
Quoting Javier Martinez Canillas (2014-06-26 11:15:35) This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk

Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0

2014-07-01 Thread Mike Turquette
Quoting Viresh Kumar (2014-07-01 04:14:04) On 1 July 2014 00:03, Rob Herring rob.herr...@linaro.org wrote: What about comparing clocks property in cpu DT nodes? What if a different clock is selected for some reason. I don't know why that will happen for CPUs sharing clock line. I

Re: [PATCH v2 1/1] clk: Fix build warnings

2014-07-01 Thread Mike Turquette
Quoting Sachin Kamat (2014-06-30 23:26:34) ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined. Thus, make their compilation conditional to fix the below warnings introduced by commit 27b8d5f723 (clk: flatten clk tree in debugfs): drivers/clk/clk.c:40:27: warning:

Re: [PATCH] clk: Add tracepoints for hardware operations

2014-07-01 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-30 18:07:49) On 06/30/14 17:52, Steven Rostedt wrote: On Mon, 30 Jun 2014 16:56:39 -0700 Stephen Boyd sb...@codeaurora.org wrote: @@ -483,10 +486,12 @@ static void clk_unprepare_unused_subtree(struct clk *clk) return; if

Re: [RESEND 2/2] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks

2014-07-01 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-06-29 22:56:55) Hi Javier, On 06/27/2014 09:23 PM, Javier Martinez Canillas wrote: Hello Peter, On Fri, Jun 27, 2014 at 8:01 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Palmas class of devices can provide 32K clock(s) to be used by other devices

Re: [RESEND 0/2] clk: Support for Palmas clk32kg and clk32kgaudio clocks

2014-07-01 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-06-26 23:01:09) Hi Mike, This is a resend of the v2 version of the palmas clock driver which seamingly missed the 3.16 merge window. I have added Nishanth's Reviewed-by tag to the patches. Thanks for the resend. Applied to clk-next. Regards, Mike Changes

Re: [PATCH v2] clk: s2mps11: Fix double free corruption during driver unbind

2014-07-01 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-06-27 05:21:10) After unbinding the driver memory was corrupted by double free of clk_lookup structure. This lead to OOPS when re-binding the driver again. The driver allocated memory for 'clk_lookup' with devm_kzalloc. During driver removal this memory was

Re: [PATCH 2/2] MIPS: Alchemy: common clock framework integration

2014-07-01 Thread Mike Turquette
Quoting Manuel Lauss (2014-06-29 09:57:35) Expose chip-internal configurable clocks to the common clk framework, and fix a few drivers to take advantage of it. Thanks for the patch series! Both patches cover a lot of ground, but I'll focus on #2. It would be best to split the driver changes out

Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0

2014-06-26 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-26 17:06:00) > Finally, checking for equivalent pointers from clk_get() will work now, Please don't do that. Even though it works for the current implementation, comparing those pointers from a driver violates how clkdev is supposed to work. The pointer returned by

Re: [PATCH] clk: define and export __clk_get_debug for providers

2014-06-26 Thread Mike Turquette
On Thu, Jun 26, 2014 at 12:37 AM, Tomeu Vizoso wrote: > On 25 June 2014 20:23, Mike Turquette wrote: >> >> Peter, >> >> Just FYI, I'm trying to reverse the trend of prepending double >> underscores for functions that are used by clock providers. That stuff >

Re: [PATCH RESEND] clk: flatten clk tree in debugfs

2014-06-26 Thread Mike Turquette
Quoting Peter De Schrijver (2014-06-26 09:39:06) > On Fri, Jun 13, 2014 at 10:02:39AM +0200, Peter De Schrijver wrote: > > On Fri, May 30, 2014 at 05:03:57PM +0200, Peter De Schrijver wrote: > > > This patch flattens the clk tree in CCF debugfs. Instead of representing > > > the > > > clocks and

Re: [PATCH RESEND] clk: flatten clk tree in debugfs

2014-06-26 Thread Mike Turquette
Quoting Peter De Schrijver (2014-06-26 09:39:06) On Fri, Jun 13, 2014 at 10:02:39AM +0200, Peter De Schrijver wrote: On Fri, May 30, 2014 at 05:03:57PM +0200, Peter De Schrijver wrote: This patch flattens the clk tree in CCF debugfs. Instead of representing the clocks and their

Re: [PATCH] clk: define and export __clk_get_debug for providers

2014-06-26 Thread Mike Turquette
On Thu, Jun 26, 2014 at 12:37 AM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 25 June 2014 20:23, Mike Turquette mturque...@linaro.org wrote: Peter, Just FYI, I'm trying to reverse the trend of prepending double underscores for functions that are used by clock providers. That stuff

Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0

2014-06-26 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-26 17:06:00) Finally, checking for equivalent pointers from clk_get() will work now, Please don't do that. Even though it works for the current implementation, comparing those pointers from a driver violates how clkdev is supposed to work. The pointer returned by

Re: [PATCH] clk: define and export __clk_get_debug for providers

2014-06-25 Thread Mike Turquette
Quoting Arnd Bergmann (2014-06-25 11:07:37) > On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote: > > Define and export a new function __clk_get_debug which returns the debugfs > > directory entry pointer. This can be used by clock providers to add debugfs > > entries which are not

Re: [PATCH] clk: define and export __clk_get_debug for providers

2014-06-25 Thread Mike Turquette
Quoting Arnd Bergmann (2014-06-25 11:07:37) On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote: Define and export a new function __clk_get_debug which returns the debugfs directory entry pointer. This can be used by clock providers to add debugfs entries which are not related to a

Re: [PATCH] clkdev: Don't print errors on probe defer

2014-06-17 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-13 16:36:31) > This error message can spam the logs if you have lots of probe > deferals due to missing clocks. Just silence the error in this > case because the driver should try again later. > > Signed-off-by: Stephen Boyd Looks OK to me. Russell? Regards, Mike

Re: [PATCH] clkdev: Don't print errors on probe defer

2014-06-17 Thread Mike Turquette
Quoting Stephen Boyd (2014-06-13 16:36:31) This error message can spam the logs if you have lots of probe deferals due to missing clocks. Just silence the error in this case because the driver should try again later. Signed-off-by: Stephen Boyd sb...@codeaurora.org Looks OK to me. Russell?

[GIT PULL] clk: changes for 3.16, part 2

2014-06-15 Thread Mike Turquette
: sunxi: Rework clock protection code clk: sun6i: Protect CPU clock clk: sun6i: Protect SDRAM gating bit Mike Turquette (2): Merge branch 'for-v3.16/ti-clk-drv' of github.com:t-kristo/linux-pm into clk-next Merge tag 'sunxi-clk-for-3.16-2' of https://github.com/mripard/linux

[GIT PULL] clk: changes for 3.16, part 2

2014-06-15 Thread Mike Turquette
: sunxi: Rework clock protection code clk: sun6i: Protect CPU clock clk: sun6i: Protect SDRAM gating bit Mike Turquette (2): Merge branch 'for-v3.16/ti-clk-drv' of github.com:t-kristo/linux-pm into clk-next Merge tag 'sunxi-clk-for-3.16-2' of https://github.com/mripard/linux

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Mike Turquette
Quoting Tushar Behera (2014-06-10 22:32:17) > When the output clock of AUDSS mux is disabled, we are getting kernel > oops while doing a clk_get() on other clocks provided by AUDSS. Though > user manual doesn't specify this dependency, we came across this issue > while disabling the parent of

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Mike Turquette
Quoting Tushar Behera (2014-06-10 22:32:17) When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while disabling the parent of AUDSS

Re: [GIT PULL] MMC updates for 3.16-rc1

2014-06-10 Thread Mike Turquette
Quoting Linus Torvalds (2014-06-10 14:50:59) > On Tue, Jun 10, 2014 at 12:51 PM, Chris Ball wrote: > > > > These patches have been tested in > > linux-next, and there are three minor conflicts which I've resolved on > > my mmc-updates-for-3.16-rc1-merged branch. > > Your merged branch is

Re: [GIT PULL] MMC updates for 3.16-rc1

2014-06-10 Thread Mike Turquette
Quoting Linus Torvalds (2014-06-10 14:50:59) On Tue, Jun 10, 2014 at 12:51 PM, Chris Ball ch...@printf.net wrote: These patches have been tested in linux-next, and there are three minor conflicts which I've resolved on my mmc-updates-for-3.16-rc1-merged branch. Your merged branch is

Re: [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description

2014-06-06 Thread Mike Turquette
Quoting Tomasz Figa (2014-06-05 15:26:31) > On 05.06.2014 22:35, Doug Anderson wrote: > > The "aclk66_peric" clock is a gate clock with a whole bunch of gates > > underneath it. This big gate isn't very useful to include in our > > clock tree. If any of the children need to be turned on then the

[GIT PULL] clk: changes for 3.16

2014-06-06 Thread Mike Turquette
clocks Maxime COQUELIN (3): clk: divider: Add round to closest divider clk: divider: Optimize clk_divider_bestdiv loop clk: divider: Fix table round up function Michal Simek (1): clk: si570: Fix email address specifiction Mike Turquette (10): Merge branch 'clk-fixes

[GIT PULL] clk: changes for 3.16

2014-06-06 Thread Mike Turquette
clocks Maxime COQUELIN (3): clk: divider: Add round to closest divider clk: divider: Optimize clk_divider_bestdiv loop clk: divider: Fix table round up function Michal Simek (1): clk: si570: Fix email address specifiction Mike Turquette (10): Merge branch 'clk-fixes

Re: [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description

2014-06-06 Thread Mike Turquette
Quoting Tomasz Figa (2014-06-05 15:26:31) On 05.06.2014 22:35, Doug Anderson wrote: The aclk66_peric clock is a gate clock with a whole bunch of gates underneath it. This big gate isn't very useful to include in our clock tree. If any of the children need to be turned on then the big

Re: [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description

2014-06-05 Thread Mike Turquette
Quoting Doug Anderson (2014-06-05 13:35:14) > The "aclk66_peric" clock is a gate clock with a whole bunch of gates > underneath it. This big gate isn't very useful to include in our > clock tree. If any of the children need to be turned on then the big > gate will need to be on anyway. ...and

Re: [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description

2014-06-05 Thread Mike Turquette
Quoting Doug Anderson (2014-06-05 13:35:14) The aclk66_peric clock is a gate clock with a whole bunch of gates underneath it. This big gate isn't very useful to include in our clock tree. If any of the children need to be turned on then the big gate will need to be on anyway. ...and there

Re: [PATCH] rtc: hym8563: add optional clock-output-names property

2014-06-02 Thread Mike Turquette
deal breaker. Reviewed-by: Mike Turquette Regards, Mike > --- > Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt | 3 +++ > drivers/rtc/rtc-hym8563.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindi

Re: [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests

2014-06-02 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 20:46:46) > On 05/30/2014 06:28 PM, Mike Turquette wrote: > > Quoting Alex Elder (2014-05-30 13:53:02) > >> Use a counter rather than a Boolean to track whether write access to > >> a CCU has been enabled or not. This will allow more than

Re: [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests

2014-06-02 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 20:46:46) On 05/30/2014 06:28 PM, Mike Turquette wrote: Quoting Alex Elder (2014-05-30 13:53:02) Use a counter rather than a Boolean to track whether write access to a CCU has been enabled or not. This will allow more than one of these requests to be nested

Re: [PATCH] rtc: hym8563: add optional clock-output-names property

2014-06-02 Thread Mike Turquette
breaker. Reviewed-by: Mike Turquette mturque...@linaro.org Regards, Mike --- Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt | 3 +++ drivers/rtc/rtc-hym8563.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc

Re: [PATCH] clk: versatile: free icst on error return

2014-05-30 Thread Mike Turquette
Quoting Colin King (2014-04-12 10:59:14) > From: Colin Ian King > > commit a183da63 introduced a new error return path that does > not kfree icst if the kmemdup of desc->params fails. > > Signed-off-by: Colin Ian King Applied to clk-next. Thanks, Mike > --- >

Re: [PATCH v4 3/7] clk: kona: don't init clocks at startup time

2014-05-30 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 13:53:04) > +static int kona_clk_prepare(struct clk_hw *hw) > { > + struct kona_clk *bcm_clk = to_kona_clk(hw); > + struct ccu_data *ccu = bcm_clk->ccu; > + unsigned long flags; > + int ret = 0; > + > + flags = ccu_lock(ccu); > +

<    1   2   3   4   5   6   7   8   9   10   >