Re: [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests

2014-05-30 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 13:53:02) > Use a counter rather than a Boolean to track whether write access to > a CCU has been enabled or not. This will allow more than one of > these requests to be nested. > > Note that __ccu_write_enable() and __ccu_write_disable() calls all > come in pairs,

Re: [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests

2014-05-30 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 13:53:02) Use a counter rather than a Boolean to track whether write access to a CCU has been enabled or not. This will allow more than one of these requests to be nested. Note that __ccu_write_enable() and __ccu_write_disable() calls all come in pairs, and

Re: [PATCH v4 3/7] clk: kona: don't init clocks at startup time

2014-05-30 Thread Mike Turquette
Quoting Alex Elder (2014-05-30 13:53:04) +static int kona_clk_prepare(struct clk_hw *hw) { + struct kona_clk *bcm_clk = to_kona_clk(hw); + struct ccu_data *ccu = bcm_clk-ccu; + unsigned long flags; + int ret = 0; + + flags = ccu_lock(ccu); +

Re: [PATCH] clk: versatile: free icst on error return

2014-05-30 Thread Mike Turquette
Quoting Colin King (2014-04-12 10:59:14) From: Colin Ian King colin.k...@canonical.com commit a183da63 introduced a new error return path that does not kfree icst if the kmemdup of desc-params fails. Signed-off-by: Colin Ian King colin.k...@canonical.com Applied to clk-next. Thanks, Mike

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-29 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-29 16:22:45) > On 05/26/2014 08:07 AM, Thierry Reding wrote: > > On Wed, May 14, 2014 at 12:35:18PM -0700, Mike Turquette wrote: > >> Quoting Thierry Reding (2014-05-14 07:27:40) > > [...] > >>> As for shared clocks I'm only aware

Re: [PATCH] clk: exynos5420: Keep aclk66_peric enabled during boot

2014-05-29 Thread Mike Turquette
Quoting Doug Anderson (2014-05-29 14:21:36) > Right now if you've got earlyprintk enabled on exynos5420-peach-pit > then you'll get a hang on boot. Here's why: > > 1. The i2c-s3c2410 driver will probe at subsys_initcall. It will >enable its clock and disable it. This is the clock "i2c2". >

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 09:53:50) > On 05/29/2014 11:35 AM, Mike Turquette wrote: > > Quoting Alex Elder (2014-05-29 06:26:15) > >> On 05/23/2014 07:53 PM, Mike Turquette wrote: > >>> The above seems like a lot effort to go to. Why not skip all of

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 06:26:15) > On 05/23/2014 07:53 PM, Mike Turquette wrote: > > The above seems like a lot effort to go to. Why not skip all of this and > > just implement the prerequisite logic in the .enable & .disable > > callbacks? E.g. your kona clk .e

[GIT PULL] clk: fixes for 3.15, part 2

2014-05-29 Thread Mike Turquette
. Maxime COQUELIN (1): clk: divider: Fix table round up function Mike Turquette (1): Merge tag 'clk-tegra-fixes-3.15' of git://nv-tegra.nvidia.com/user/pdeschrijver/linux into clk-fixes Thierry Reding (3): clk: tegra: Fix PLLE programming clk: tegra: Introduce divider

[GIT PULL] clk: fixes for 3.15, part 2

2014-05-29 Thread Mike Turquette
. Maxime COQUELIN (1): clk: divider: Fix table round up function Mike Turquette (1): Merge tag 'clk-tegra-fixes-3.15' of git://nv-tegra.nvidia.com/user/pdeschrijver/linux into clk-fixes Thierry Reding (3): clk: tegra: Fix PLLE programming clk: tegra: Introduce divider

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 06:26:15) On 05/23/2014 07:53 PM, Mike Turquette wrote: The above seems like a lot effort to go to. Why not skip all of this and just implement the prerequisite logic in the .enable .disable callbacks? E.g. your kona clk .enable callback would look like: I

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 09:53:50) On 05/29/2014 11:35 AM, Mike Turquette wrote: Quoting Alex Elder (2014-05-29 06:26:15) On 05/23/2014 07:53 PM, Mike Turquette wrote: The above seems like a lot effort to go to. Why not skip all of this and just implement the prerequisite logic

Re: [PATCH] clk: exynos5420: Keep aclk66_peric enabled during boot

2014-05-29 Thread Mike Turquette
Quoting Doug Anderson (2014-05-29 14:21:36) Right now if you've got earlyprintk enabled on exynos5420-peach-pit then you'll get a hang on boot. Here's why: 1. The i2c-s3c2410 driver will probe at subsys_initcall. It will enable its clock and disable it. This is the clock i2c2. 2. The

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-29 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-29 16:22:45) On 05/26/2014 08:07 AM, Thierry Reding wrote: On Wed, May 14, 2014 at 12:35:18PM -0700, Mike Turquette wrote: Quoting Thierry Reding (2014-05-14 07:27:40) [...] As for shared clocks I'm only aware of one use-case, namely EMC scaling. Using

Re: [PATCH v2 00/10] Marvell Berlin full clock support

2014-05-28 Thread Mike Turquette
vers/clk/berlin/berlin2-pll.c > create mode 100644 drivers/clk/berlin/berlin2-pll.h > create mode 100644 drivers/clk/berlin/bg2.c > create mode 100644 drivers/clk/berlin/bg2q.c > create mode 100644 drivers/clk/berlin/common.h > create mode 100644 include/dt-bindings/clock/ber

Re: [PATCH] CLK: TI: DRA7: return error code in failure case

2014-05-28 Thread Mike Turquette
Quoting Tero Kristo (2014-05-19 05:23:10) > On 05/19/2014 02:25 PM, Julia Lawall wrote: > > From: Julia Lawall > > > > Add a returned error code in the MAX_APLL_WAIT_TRIES case. Remove the > > updating of the return variable r to 0 if MAX_APLL_WAIT_TRIES is not yet > > reached, because r is

Re: [RFC PATCH] clk: flatten clk tree in debugfs

2014-05-28 Thread Mike Turquette
Quoting Saravana Kannan (2014-05-28 10:47:46) > On 05/26/2014 04:14 AM, Peter De Schrijver wrote: > > On Sat, May 24, 2014 at 12:24:32AM +0200, Saravana Kannan wrote: > >> On 05/23/2014 03:59 AM, Peter De Schrijver wrote: > >>> This patch flattens the clk tree in CCF debugfs. Instead of

RE: [PATCH v11 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-28 Thread Mike Turquette
Quoting Kukjin Kim (2014-05-27 21:49:49) > Mike Turquette wrote: > > > > Quoting Tarek Dakhran (2014-05-25 20:23:32) > > > The EXYNOS5410 clocks are statically listed and registered > > > using the Samsung specific common clock helper functions. > &g

Re: [PATCH] CLK: TI: DRA7: return error code in failure case

2014-05-28 Thread Mike Turquette
Quoting Tero Kristo (2014-05-19 05:23:10) On 05/19/2014 02:25 PM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Add a returned error code in the MAX_APLL_WAIT_TRIES case. Remove the updating of the return variable r to 0 if MAX_APLL_WAIT_TRIES is not yet reached, because

Re: [PATCH v2 00/10] Marvell Berlin full clock support

2014-05-28 Thread Mike Turquette
...@infradead.org Cc: Mike Turquette mturque...@linaro.org Cc: Alexandre Belloni alexandre.bell...@free-electrons.com Cc: Jisheng Zhang jszh...@marvell.com Cc: devicet...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org -- 1.9.1

RE: [PATCH v11 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-28 Thread Mike Turquette
Quoting Kukjin Kim (2014-05-27 21:49:49) Mike Turquette wrote: Quoting Tarek Dakhran (2014-05-25 20:23:32) The EXYNOS5410 clocks are statically listed and registered using the Samsung specific common clock helper functions. Signed-off-by: Tarek Dakhran t.dakh...@samsung.com

Re: [RFC PATCH] clk: flatten clk tree in debugfs

2014-05-28 Thread Mike Turquette
Quoting Saravana Kannan (2014-05-28 10:47:46) On 05/26/2014 04:14 AM, Peter De Schrijver wrote: On Sat, May 24, 2014 at 12:24:32AM +0200, Saravana Kannan wrote: On 05/23/2014 03:59 AM, Peter De Schrijver wrote: This patch flattens the clk tree in CCF debugfs. Instead of representing the

Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-27 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-07 09:24:10) > Commit c686078 ("clk: divider: Add round to closest divider") introduced > a helper function to check whether given divisor is the best one instead > of direct check. However due to int type used instead of unsigned long > for passing calculated rates to

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-27 Thread Mike Turquette
Quoting Rafael J. Wysocki (2014-05-26 04:22:32) > On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > > On 23 May 2014 21:44, Sören Brinkmann wrote: > > > Viresh: Could you imagine something similar for cpufreq? You suggested > > > migrating to Hz resolution. I guess that would ideally mean

Re: [PATCH 03/17] phy: ti-pipe3: add external clock support for PCIe PHY

2014-05-27 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-15 05:33:13) > On 05/15/2014 07:18 AM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Thursday 15 May 2014 05:42 PM, Nishanth Menon wrote: > >> On Thu, May 15, 2014 at 6:59 AM, Kishon Vijay Abraham I > >> wrote: > >>> Hi Nishant, > >>> > >>> On Thursday 15 May

Re: [PATCH] MAINTAINERS: add AT91 Clock Support entry

2014-05-27 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-27 04:39:28) > Signed-off-by: Boris BREZILLON Applied to clk-next. Regards, Mike > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1066264..40c5580 100644 > --- a/MAINTAINERS > +++

Re: [PATCH v2] clk: bcm/kona: implement determine_rate()

2014-05-27 Thread Mike Turquette
Quoting Alex Elder (2014-05-27 09:56:56) > Implement the clk->determine_rate method for Broadcom Kona peripheral > clocks. This allows a peripheral clock to be re-parented in order to > satisfy a rate change request. This takes the place of the previous > kona_peri_clk_round_rate()

Re: [PATCH v11 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-27 Thread Mike Turquette
Quoting Tarek Dakhran (2014-05-25 20:23:32) > The EXYNOS5410 clocks are statically listed and registered > using the Samsung specific common clock helper functions. > > Signed-off-by: Tarek Dakhran > Signed-off-by: Vyacheslav Tyrtov > --- > .../devicetree/bindings/clock/exynos5410-clock.txt |

Re: [PATCH v11 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-27 Thread Mike Turquette
Quoting Tarek Dakhran (2014-05-25 20:23:32) The EXYNOS5410 clocks are statically listed and registered using the Samsung specific common clock helper functions. Signed-off-by: Tarek Dakhran t.dakh...@samsung.com Signed-off-by: Vyacheslav Tyrtov v.tyr...@samsung.com ---

Re: [PATCH v2] clk: bcm/kona: implement determine_rate()

2014-05-27 Thread Mike Turquette
Quoting Alex Elder (2014-05-27 09:56:56) Implement the clk-determine_rate method for Broadcom Kona peripheral clocks. This allows a peripheral clock to be re-parented in order to satisfy a rate change request. This takes the place of the previous kona_peri_clk_round_rate() functionality,

Re: [PATCH] MAINTAINERS: add AT91 Clock Support entry

2014-05-27 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-27 04:39:28) Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Applied to clk-next. Regards, Mike --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1066264..40c5580 100644 ---

Re: [PATCH 03/17] phy: ti-pipe3: add external clock support for PCIe PHY

2014-05-27 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-15 05:33:13) On 05/15/2014 07:18 AM, Kishon Vijay Abraham I wrote: Hi, On Thursday 15 May 2014 05:42 PM, Nishanth Menon wrote: On Thu, May 15, 2014 at 6:59 AM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Nishant, On Thursday 15 May 2014 05:16

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-27 Thread Mike Turquette
Quoting Rafael J. Wysocki (2014-05-26 04:22:32) On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: On 23 May 2014 21:44, Sören Brinkmann soren.brinkm...@xilinx.com wrote: Viresh: Could you imagine something similar for cpufreq? You suggested migrating to Hz resolution. I guess that

Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-27 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-07 09:24:10) Commit c686078 (clk: divider: Add round to closest divider) introduced a helper function to check whether given divisor is the best one instead of direct check. However due to int type used instead of unsigned long for passing calculated rates to this

Re: [PATCH] clk: bcm/kona: implement determine_rate()

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-23 16:24:31) > On 05/23/2014 06:18 PM, Mike Turquette wrote: > > Quoting Alex Elder (2014-05-20 06:24:57) > >> Implement the clk->determine_rate method for Broadcom Kona peripheral > >> clocks. This allows a peripheral clock to be re-par

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 05:52:39) > @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) > clk = clk_register(NULL, _clk->hw); > if (IS_ERR(clk)) { > pr_err("%s: error registering clock %s (%ld)\n", __func__, > -

Re: [PATCH v2 1/5] clk: bcm281xx: add an initialized flag

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 05:52:38) > Add a flag that tracks whether a clock has already been initialized. > This will be used by the next patch to avoid initializing a clock > more than once when it's listed as a prerequisite. > > Signed-off-by: Alex Elder > --- >

Re: [PATCH] clk: bcm/kona: implement determine_rate()

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 06:24:57) > Implement the clk->determine_rate method for Broadcom Kona peripheral > clocks. This allows a peripheral clock to be re-parented in order to > satisfy a rate change request. This takes the place of the previous > kona_peri_clk_round_rate()

Re: [PATCH] clk: qcom: Fix blsp2_ahb_clk register offset

2014-05-23 Thread Mike Turquette
Quoting Georgi Djakov (2014-05-20 09:50:54) > The address of the blsp2_ahb_clk register is incorrect. Fix it. > > Signed-off-by: Georgi Djakov Applied to clk-next. Regards, Mike > --- > drivers/clk/qcom/gcc-msm8974.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v4 0/3] clk: s2mps11: Fixes and add support for S2MPS14 clocks

2014-05-23 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-05-21 04:22:58) > Hi, > > > This is actually a resend of previous patches, rebased on latest > 3.15-rc5. There are no changes, beside rebasing. > > The first two fixes were posted previously as separate patches and they > didn't get review [1]. I am attaching

Re: [PATCH] clk: st: Fix memory leak

2014-05-23 Thread Mike Turquette
Quoting Valentin Ilie (2014-04-22 06:15:54) > When it fails to allocate div, gate should be free'd before return > > Signed-off-by: Valentin Ilie Taken into clk-fixes. Regards, Mike > --- > drivers/clk/st/clkgen-pll.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] clk: divider: Fix table round up function

2014-05-23 Thread Mike Turquette
_MAX. > > Reported-by: Fabio Estevam > Reported-by: Shawn Guo > Tested-by: Fabio Estevam > Cc: Mike Turquette > Signed-off-by: Maxime Coquelin Pulled into clk-fixes for -rc7. Regards, Mike > --- > drivers/clk/clk-divider.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH 0/3] ARM: OMAP5+: Support Duty Cycle Correction(DCC)

2014-05-23 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-16 03:45:57) > Hi, > > This patch series has been carried over in vendor kernel for quiet > few years now. > > Unfortunately, it was very recently re-discovered and upstream kernel > is noticed to be broken for OMAP5 1.5GHz - at least we are operating > DPLL at

Re: [Patch v7 2/7] clock: keystone-pllctrl: add bindings for keystone pll controller

2014-05-23 Thread Mike Turquette
ions, gating, and synchronization. > > Reviewed-by: Arnd Bergmann > Signed-off-by: Ivan Khoronzhuk Acked-by: Mike Turquette Regards, Mike > --- > .../bindings/clock/ti-keystone-pllctrl.txt | 20 > > 1 file changed, 20 insertions(+) >

Re: [PATCH v10 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-23 Thread Mike Turquette
Quoting Tarek Dakhran (2014-05-23 03:35:42) > The EXYNOS5410 clocks are statically listed and registered > using the Samsung specific common clock helper functions. > > Signed-off-by: Tarek Dakhran > Signed-off-by: Vyacheslav Tyrtov Quick glance over it. Looks good to me. Regards, Mike > ---

Re: [PATCH v10 2/3] clk: exynos5410: register clocks using common clock framework

2014-05-23 Thread Mike Turquette
Quoting Tarek Dakhran (2014-05-23 03:35:42) The EXYNOS5410 clocks are statically listed and registered using the Samsung specific common clock helper functions. Signed-off-by: Tarek Dakhran t.dakh...@samsung.com Signed-off-by: Vyacheslav Tyrtov v.tyr...@samsung.com Quick glance over it.

Re: [Patch v7 2/7] clock: keystone-pllctrl: add bindings for keystone pll controller

2014-05-23 Thread Mike Turquette
, and synchronization. Reviewed-by: Arnd Bergmann a...@arndb.de Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@ti.com Acked-by: Mike Turquette mturque...@linaro.org Regards, Mike --- .../bindings/clock/ti-keystone-pllctrl.txt | 20 1 file changed, 20 insertions

Re: [PATCH 0/3] ARM: OMAP5+: Support Duty Cycle Correction(DCC)

2014-05-23 Thread Mike Turquette
Quoting Nishanth Menon (2014-05-16 03:45:57) Hi, This patch series has been carried over in vendor kernel for quiet few years now. Unfortunately, it was very recently re-discovered and upstream kernel is noticed to be broken for OMAP5 1.5GHz - at least we are operating DPLL at frequency

Re: [PATCH] clk: divider: Fix table round up function

2014-05-23 Thread Mike Turquette
...@gmail.com Reported-by: Shawn Guo shawn@freescale.com Tested-by: Fabio Estevam feste...@gmail.com Cc: Mike Turquette mike.turque...@linaro.org Signed-off-by: Maxime Coquelin maxime.coque...@st.com Pulled into clk-fixes for -rc7. Regards, Mike --- drivers/clk/clk-divider.c | 2 +- 1 file

Re: [PATCH] clk: st: Fix memory leak

2014-05-23 Thread Mike Turquette
Quoting Valentin Ilie (2014-04-22 06:15:54) When it fails to allocate div, gate should be free'd before return Signed-off-by: Valentin Ilie valentin.i...@gmail.com Taken into clk-fixes. Regards, Mike --- drivers/clk/st/clkgen-pll.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH v4 0/3] clk: s2mps11: Fixes and add support for S2MPS14 clocks

2014-05-23 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-05-21 04:22:58) Hi, This is actually a resend of previous patches, rebased on latest 3.15-rc5. There are no changes, beside rebasing. The first two fixes were posted previously as separate patches and they didn't get review [1]. I am attaching them

Re: [PATCH] clk: qcom: Fix blsp2_ahb_clk register offset

2014-05-23 Thread Mike Turquette
Quoting Georgi Djakov (2014-05-20 09:50:54) The address of the blsp2_ahb_clk register is incorrect. Fix it. Signed-off-by: Georgi Djakov gdja...@mm-sol.com Applied to clk-next. Regards, Mike --- drivers/clk/qcom/gcc-msm8974.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] clk: bcm/kona: implement determine_rate()

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 06:24:57) Implement the clk-determine_rate method for Broadcom Kona peripheral clocks. This allows a peripheral clock to be re-parented in order to satisfy a rate change request. This takes the place of the previous kona_peri_clk_round_rate() functionality,

Re: [PATCH v2 1/5] clk: bcm281xx: add an initialized flag

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 05:52:38) Add a flag that tracks whether a clock has already been initialized. This will be used by the next patch to avoid initializing a clock more than once when it's listed as a prerequisite. Signed-off-by: Alex Elder el...@linaro.org ---

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 05:52:39) @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) clk = clk_register(NULL, bcm_clk-hw); if (IS_ERR(clk)) { pr_err(%s: error registering clock %s (%ld)\n, __func__, -

Re: [PATCH] clk: bcm/kona: implement determine_rate()

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-23 16:24:31) On 05/23/2014 06:18 PM, Mike Turquette wrote: Quoting Alex Elder (2014-05-20 06:24:57) Implement the clk-determine_rate method for Broadcom Kona peripheral clocks. This allows a peripheral clock to be re-parented in order to satisfy a rate change

Re: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-05-22 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-05-19 10:22:51) > diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt > b/Documentation/devicetree/bindings/clock/clock-bindings.txt > index 700e7aa..bee649b 100644 > --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt > +++

Re: [PATCH RFC v5 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-05-22 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-04-11 05:25:49) > >> +==Assigned clock parents and rates== > >> + > >> +Some platforms require static initial configuration of parts of the clocks > >> +controller. Such a configuration can be specified in a clock consumer node > >> +through clock-parents and

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Mike Turquette
Quoting Sören Brinkmann (2014-05-22 13:32:09) > On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > > Hello Sören, > > > > On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > > > On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: &g

Re: [PATCH] clk: impd1: add pclk clocks

2014-05-22 Thread Mike Turquette
Quoting Linus Walleij (2014-04-15 01:29:45) > The IM-PD1 PrimeCells all have pclk assignments though this clock > cannot be controlled, and we need to provide this as a dummy > clock for the PL061 GPIO driver to probe, so let's assign it to > all the cells on the board. > >

Re: [PATCH] clk: impd1: add pclk clocks

2014-05-22 Thread Mike Turquette
Quoting Linus Walleij (2014-04-15 01:29:45) The IM-PD1 PrimeCells all have pclk assignments though this clock cannot be controlled, and we need to provide this as a dummy clock for the PL061 GPIO driver to probe, so let's assign it to all the cells on the board. Cc: Mike Turquette mturque

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Mike Turquette
Quoting Sören Brinkmann (2014-05-22 13:32:09) On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21 11

Re: [PATCH RFC v5 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-05-22 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-04-11 05:25:49) +==Assigned clock parents and rates== + +Some platforms require static initial configuration of parts of the clocks +controller. Such a configuration can be specified in a clock consumer node +through clock-parents and clock-rates DT

Re: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-05-22 Thread Mike Turquette
Quoting Sylwester Nawrocki (2014-05-19 10:22:51) diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt index 700e7aa..bee649b 100644 --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt +++

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Mike Turquette
Quoting Uwe Kleine-König (2014-05-21 11:23:08) > Hello Sören, > > On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > > > On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > > > > On Tue, 2014-05-20 at

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Mike Turquette
Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20 at 10:48AM

Re: [PATCH v2 3/4] clk: ti: Driver for DRA7 ATL (Audio Tracking Logic)

2014-05-20 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-05-07 03:20:47) > Audio Tracking Logic is designed to be used by HD Radio applications to > synchronize the audio output clocks to the baseband clock. ATL can be also > used to track errors between two reference clocks (BWS, AWS) and generate a > modulated > clock

Re: [PATCH v2 3/4] clk: ti: Driver for DRA7 ATL (Audio Tracking Logic)

2014-05-20 Thread Mike Turquette
Quoting Peter Ujfalusi (2014-05-07 03:20:47) Audio Tracking Logic is designed to be used by HD Radio applications to synchronize the audio output clocks to the baseband clock. ATL can be also used to track errors between two reference clocks (BWS, AWS) and generate a modulated clock output

[GIT PULL] clk: fixes for 3.15

2014-05-18 Thread Mike Turquette
-mstp: change to using clock-indices Dinh Nguyen (1): clk: socfpga: fix clock driver for 3.15 Maxime COQUELIN (1): clk: divider: Fix best div calculation for power-of-two and table dividers Mike Turquette (1): Merge tag 'socfpga-clk-fix-for-3.15' of git://git.rocketboards.org

[GIT PULL] clk: fixes for 3.15

2014-05-18 Thread Mike Turquette
-mstp: change to using clock-indices Dinh Nguyen (1): clk: socfpga: fix clock driver for 3.15 Maxime COQUELIN (1): clk: divider: Fix best div calculation for power-of-two and table dividers Mike Turquette (1): Merge tag 'socfpga-clk-fix-for-3.15' of git://git.rocketboards.org

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-15 10:32:30) > This patch introduces a driver that handles configuration of CLKOUT pin > of Exynos SoCs that can be used to output certain clocks from inside of > the SoC to a dedicated output pin. > > Signed-off-by: Tomasz Figa Overall implementation looks good to

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-16 Thread Mike Turquette
Quoting Stephen Warren (2014-05-15 13:20:21) > On 05/15/2014 04:52 AM, Peter De Schrijver wrote: > > On Wed, May 14, 2014 at 04:27:40PM +0200, Thierry Reding wrote: > >> * PGP Signed by an unknown key > >> > >> On Tue, May 13, 2014 at 12:09:49PM -0600, Stephen Warren wrote: > >>> On 05/13/2014

Re: [RFC] Linux common clock framework: device with many clocks

2014-05-16 Thread Mike Turquette
separate matter from the management of said > clocks in any given driver. > > If you want a helpful abstraction for combining clocks for management > purposes you'd be better off talking to Mike Turquette (CC'd), as he's > in charge of the common clock framework. Jim emailed me privately.

Re: [RFC] Linux common clock framework: device with many clocks

2014-05-16 Thread Mike Turquette
be better off talking to Mike Turquette (CC'd), as he's in charge of the common clock framework. Jim emailed me privately. Here is my response for posterity: On Wed, May 7, 2014 at 8:59 AM, Jim Quinlan jquin...@broadcom.com wrote: Hi Mike, Hi Jim, snip In most examples of .dtsi files I have

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-16 Thread Mike Turquette
Quoting Stephen Warren (2014-05-15 13:20:21) On 05/15/2014 04:52 AM, Peter De Schrijver wrote: On Wed, May 14, 2014 at 04:27:40PM +0200, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, May 13, 2014 at 12:09:49PM -0600, Stephen Warren wrote: On 05/13/2014 08:06 AM, Peter De

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-15 10:32:30) This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa t.f...@samsung.com Overall implementation

Re: [PATCHv2 3/4] clk: new basic clk type for fractional divider

2014-05-15 Thread Mike Turquette
Quoting Heikki Krogerus (2014-05-15 06:40:25) > Fractional divider clocks are fairly common. This adds basic > type for them. > > Signed-off-by: Heikki Krogerus Taken into clk-next. Just FYI, there was some talk at Embedded Linux Conference on providing a better abstraction layer for some of

Re: [PATCH RESEND] Documentation: clock: fixed-clock: Remove unsupported 'gpios' property

2014-05-15 Thread Mike Turquette
Quoting Fabio Estevam (2014-05-08 20:01:50) > From: Fabio Estevam > > Remove the 'gpios' property from the documentation as this is something that > the > current fixed clock driver does not handle. > > Signed-off-by: Fabio Estevam Good catch. Taken into clk-next. Regards, Mike > --- >

Re: [PATCH] clk/versatile: export symbols for impd1

2014-05-15 Thread Mike Turquette
Quoting Arnd Bergmann (2014-05-08 07:56:16) > The impd1 code on mach-integrator can be a loadable module, > so we have to export icst_clk_register, integrator_impd1_clk_init > and integrator_impd1_clk_exit. > > Signed-off-by: Arnd Bergmann > Cc: Mike Turquette > Cc:

Re: linux-next: manual merge of the clk tree with the renesas tree

2014-05-15 Thread Mike Turquette
Quoting Stephen Rothwell (2014-05-14 23:11:21) > Hi Mike, > > Today's linux-next merge of the clk tree got a conflict in > Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt > between commit b557deadc5cc ("ARM: shmobile: r7s72100: document MSTP > clock support") from the renesas

Re: linux-next: manual merge of the clk tree with the renesas tree

2014-05-15 Thread Mike Turquette
Quoting Stephen Rothwell (2014-05-14 23:11:21) Hi Mike, Today's linux-next merge of the clk tree got a conflict in Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt between commit b557deadc5cc (ARM: shmobile: r7s72100: document MSTP clock support) from the renesas tree and

Re: [PATCH] clk/versatile: export symbols for impd1

2014-05-15 Thread Mike Turquette
Quoting Arnd Bergmann (2014-05-08 07:56:16) The impd1 code on mach-integrator can be a loadable module, so we have to export icst_clk_register, integrator_impd1_clk_init and integrator_impd1_clk_exit. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Mike Turquette mturque...@linaro.org Cc

Re: [PATCH RESEND] Documentation: clock: fixed-clock: Remove unsupported 'gpios' property

2014-05-15 Thread Mike Turquette
Quoting Fabio Estevam (2014-05-08 20:01:50) From: Fabio Estevam fabio.este...@freescale.com Remove the 'gpios' property from the documentation as this is something that the current fixed clock driver does not handle. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Good catch.

Re: [PATCHv2 3/4] clk: new basic clk type for fractional divider

2014-05-15 Thread Mike Turquette
Quoting Heikki Krogerus (2014-05-15 06:40:25) Fractional divider clocks are fairly common. This adds basic type for them. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Taken into clk-next. Just FYI, there was some talk at Embedded Linux Conference on providing a better

Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-14 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-14 00:30:59) > Hello Mike, > > On 14/05/2014 02:51, Mike Turquette wrote: > > Quoting Boris BREZILLON (2014-05-09 04:11:49) > >> +struct clk_ops ar100_ops = { > >> + .recalc_rate = ar100_recalc_rate, > >> +

Re: [PATCH 2/8] clk: berlin: add clock binding docs for Marvell Berlin2 SoCs

2014-05-14 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2014-05-11 13:24:35) > This adds mandatory device tree binding documentation for the clock related > IP found on Marvell Berlin2 (BG2, BG2CD, and BG2Q) SoCs. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Mike Turquette > Cc: Rob Herr

Re: [PATCH v3 2/6] clk: Add clock driver for AXM55xx SoC

2014-05-14 Thread Mike Turquette
Quoting Anders Berg (2014-05-14 11:37:57) > +Example: > + > + clk_ref0: clk_ref0 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <12500>; > + }; Hi Anders, The driver looks good. As for the DT binding, I am

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-14 Thread Mike Turquette
Quoting Thierry Reding (2014-05-14 07:27:40) > On Tue, May 13, 2014 at 12:09:49PM -0600, Stephen Warren wrote: > > On 05/13/2014 08:06 AM, Peter De Schrijver wrote: > > > Add shared and cbus clocks to the Tegra124 clock implementation. > > > > > diff --git

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-14 Thread Mike Turquette
Quoting Thierry Reding (2014-05-14 07:27:40) On Tue, May 13, 2014 at 12:09:49PM -0600, Stephen Warren wrote: On 05/13/2014 08:06 AM, Peter De Schrijver wrote: Add shared and cbus clocks to the Tegra124 clock implementation. diff --git a/include/dt-bindings/clock/tegra124-car.h

Re: [PATCH v3 2/6] clk: Add clock driver for AXM55xx SoC

2014-05-14 Thread Mike Turquette
Quoting Anders Berg (2014-05-14 11:37:57) +Example: + + clk_ref0: clk_ref0 { + compatible = fixed-clock; + #clock-cells = 0; + clock-frequency = 12500; + }; Hi Anders, The driver looks good. As for the DT binding, I am starting to

Re: [PATCH 2/8] clk: berlin: add clock binding docs for Marvell Berlin2 SoCs

2014-05-14 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2014-05-11 13:24:35) This adds mandatory device tree binding documentation for the clock related IP found on Marvell Berlin2 (BG2, BG2CD, and BG2Q) SoCs. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Mike Turquette mturque

Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-14 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-14 00:30:59) Hello Mike, On 14/05/2014 02:51, Mike Turquette wrote: Quoting Boris BREZILLON (2014-05-09 04:11:49) +struct clk_ops ar100_ops = { + .recalc_rate = ar100_recalc_rate, + .determine_rate = ar100_determine_rate

Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-13 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-09 04:11:49) > +struct clk_ops ar100_ops = { > + .recalc_rate = ar100_recalc_rate, > + .determine_rate = ar100_determine_rate, > + .set_parent = ar100_set_parent, > + .get_parent = ar100_get_parent, > + .set_rate = ar100_set_rate, >

Re: [PATCH 1/2] clk: of: helper for determining flags properties

2014-05-13 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2014-05-13 08:11:55) > On 05/13/2014 02:20 PM, Mark Rutland wrote: > > On Tue, May 13, 2014 at 12:57:32PM +0100, Gabriel FERNANDEZ wrote: > >> The patch provides a helper to get flags properties of > >> a clock node. > >> > >> Signed-off-by: Gabriel Fernandez > >>

Re: [PATCH 1/8] clk: add helper for unique DT clock names

2014-05-13 Thread Mike Turquette
reg property or a magic number instead. This is basically the same > we already do for proper devices and may vanish as soon as there is some > (early) device support for clocks available. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Mike Turquette > Cc: Grant Likely &

Re: [PATCH 1/8] clk: add helper for unique DT clock names

2014-05-13 Thread Mike Turquette
or a magic number instead. This is basically the same we already do for proper devices and may vanish as soon as there is some (early) device support for clocks available. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Mike Turquette mturque...@linaro.org Cc: Grant

Re: [PATCH 1/2] clk: of: helper for determining flags properties

2014-05-13 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2014-05-13 08:11:55) On 05/13/2014 02:20 PM, Mark Rutland wrote: On Tue, May 13, 2014 at 12:57:32PM +0100, Gabriel FERNANDEZ wrote: The patch provides a helper to get flags properties of a clock node. Signed-off-by: Gabriel Fernandez

Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-13 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-09 04:11:49) +struct clk_ops ar100_ops = { + .recalc_rate = ar100_recalc_rate, + .determine_rate = ar100_determine_rate, + .set_parent = ar100_set_parent, + .get_parent = ar100_get_parent, + .set_rate = ar100_set_rate, +}; I

Re: [PATCH v3 1/8] clk: sunxi: Implement A31 USB clock

2014-05-12 Thread Mike Turquette
Hans de Goede Acked-by: Mike Turquette > --- > drivers/clk/sunxi/clk-sunxi.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index bd7dc733c1ca..d9bab75f128b 100644 > --- a/drivers/clk/sunxi

Re: [PATCH v6 3/8] ARM: sunxi: Move the clock protection to machine hooks

2014-05-12 Thread Mike Turquette
Quoting Arnd Bergmann (2014-04-23 06:31:06) > On Wednesday 23 April 2014 15:17:20 Maxime Ripard wrote: > > > > +#include > > > > #include > > > > #include > > > > > > > > @@ -19,9 +20,17 @@ > > > > > > > > static void __init sun4i_dt_init(void) > > > > { > > > > + struct clk *clk;

<    1   2   3   4   5   6   7   8   9   10   >