Re: Re: [linux-next PATCH] PM / devfreq: documentation cleanups for devfreq header

2012-10-30 Thread MyungJoo Ham
Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Rafael J. Wysocki r...@sisk.pl Cc: Kevin Hilman khil...@ti.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Nishanth Menon n...@ti.com Acked-by: Randy Dunlap

Re: Re: [for-next PATCH V2] PM / devfreq: Add sysfs node to expose available frequencies

2012-10-30 Thread MyungJoo Ham
On Friday, October 26, 2012 06:16:36 AM MyungJoo Ham wrote: devfreq governors such as ondemand are controlled by a min and max frequency, while governors like userspace governor allow us to set a specific frequency. However, for the same specific device, depending on the SoC

Re: [PATCH v3 1/3] devfreq: Core updates to support devices which can idle

2012-09-27 Thread MyungJoo Ham
@@ -21,14 +21,6 @@ Description: The /sys/class/devfreq/.../cur_freq shows the current frequency of the corresponding devfreq object. -What:/sys/class/devfreq/.../central_polling -Date:September 2011 -Contact: MyungJoo Ham myungjoo

Re: [PATCH v4 0/3] devfreq: Add support for devices which can idle

2012-10-04 Thread MyungJoo Ham
This patchset updates devfreq core to add support for devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume when device is back online. patch 1 introduce core design changes - per device work,

Re: Re: [PATCH v4 0/3] devfreq: Add support for devices which can idle

2012-10-05 Thread MyungJoo Ham
On 4 October 2012 18:06, MyungJoo Ham myungjoo@samsung.com wrote: This patchset updates devfreq core to add support for devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume when device

Re: [PATCH v4 1/3] devfreq: Core updates to support devices which can idle

2012-10-08 Thread MyungJoo Ham
devfreq. This sets ground for adding suspend/resume events. The devfreq apis are not modified and are kept intact. Signed-off-by: Rajagopal Venkat rajagopal.ven...@linaro.org Thank you! Reviewed and Tested (at Exynos4210-Nuri). Acked-by: MyungJoo Ham myungjoo@samsung.com

Re: Re: [PATCH v4 2/3] devfreq: Add suspend and resume apis

2012-10-08 Thread MyungJoo Ham
. Signed-off-by: Rajagopal Venkat rajagopal.ven...@linaro.org Acked-by: MyungJoo Ham myungjoo@samsung.com Well, I wonder if this may be tied in to the runtime PM framework, so that, for example, pm_runtime_suspend() will automatically suspend devfreq on success (and the runtime resume

[PATCH v4] PM / devfreq: add PM-QoS support

2012-10-08 Thread MyungJoo Ham
frequencies and multimedia H/W blocks. (camera, video decoding, and video encoding) Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes from V3 - Corrected and added comments - Code Clean - Merged per-dev qos patch and global qos patch

Re: [PATCH v4] PM / devfreq: add PM-QoS support

2012-10-08 Thread MyungJoo Ham
. Tested on Exynos4412 machines with memory/bus frequencies and multimedia H/W blocks. (camera, video decoding, and video encoding) Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes from V3 - Corrected and added comments

Re: [linux-next PATCH 6/7] PM / devfreq: allow sysfs governor node to switch governor

2012-11-06 Thread MyungJoo Ham
--- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -629,6 +629,44 @@ static ssize_t show_governor(struct device *dev, return sprintf(buf, %s\n, to_devfreq(dev)-governor-name); } +static ssize_t store_governor(struct device *dev, struct device_attribute *attr, +

[GIT PULL] extcon fixes for Linux 3.7

2012-10-21 Thread MyungJoo Ham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Greg, The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next

[GIT PULL v2] extcon fixes for Linux 3.7

2012-10-23 Thread MyungJoo Ham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Greg, Please pull: The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git repository at:

Re: [PATCH] extcon : register for cable interest by cable name

2012-10-10 Thread MyungJoo Ham
There are some scnearios where a driver/framework needs to register interest for a particular cable without specifying the extcon device name. One such scenario is charger notifications. The platform will have charger cabel which will be bound to any extcon device. It's not mandatory for the

Re: RE: [PATCH] extcon : callback function to read cable property

2012-10-25 Thread MyungJoo Ham
Subject: Re: [PATCH] extcon : callback function to read cable property On 10/19/2012 12:13 PM, Tc, Jenny wrote: The rold of extcon inform only attached/detached state of extcon consumer driver from extcon provider driver. After extcon consumer driver detect the state of cable

Re: [for-next PATCH V2] PM / devfreq: Add sysfs node to expose available frequencies

2012-10-26 Thread MyungJoo Ham
as a snapshot over sysfs to allow informed decisions. This was inspired by cpufreq framework's equivalent for similar usage sysfs node: scaling_available_frequencies. Cc: Rajagopal Venkat rajagopal.ven...@linaro.org Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p

Re: [PATCH] devfreq: exynos4_bus.c: Fixed an alignment of the func call args.

2012-10-26 Thread MyungJoo Ham
I fixed the following check item (via checkpatch.pl --strict option): CHECK: Alignment should match open parenthesis Signed-off-by: Sangho Yi antir...@gmail.com Acked-by: MyungJoo Ham myungjoo@samsung.com I'll apply the patch after setting up devfreq for next tree. Thanks. Cheers

Re: [PATCH] extcon : register for cable interest by cable name

2012-10-15 Thread MyungJoo Ham
work on any platform without looking for extcon dev name in the platform data. For example a charger driver can work on any platform without knowing the extcon provider name for The charger cable. -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics

Re: Re: [PATCH v4 2/3] devfreq: Add suspend and resume apis

2012-10-16 Thread MyungJoo Ham
On Monday 08 of October 2012 10:48:24 MyungJoo Ham wrote: On 8 October 2012 03:31, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday 04 of October 2012 14:58:33 Rajagopal Venkat wrote: Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume

Re: [PATCH] PM / devfreq: kernel-doc typo corrections

2012-10-16 Thread MyungJoo Ham
Parameter documentation needs a ':' for scripts/kernel-doc to parse properly. Minor fixes for ones warned by: ./scripts/kernel-doc -text drivers/devfreq/devfreq.c/dev/null Cc: Rafael J. Wysocki r...@sisk.pl Cc: Kevin Hilman khil...@ti.com Cc: MyungJoo Ham myungjoo@samsung.com Cc

Re: [PATCH 1/2] PM / devfreq: fix sscanf handling for writable sysfs entries

2012-10-16 Thread MyungJoo Ham
and polling_interval Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Rafael J. Wysocki r...@sisk.pl Cc: Kevin Hilman khil...@ti.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Nishanth Menon n...@ti.com Acked-by: MyungJoo Ham

Re: RE: [PATCH] extcon : callback function to read cable property

2012-10-17 Thread MyungJoo Ham
Myunjoo/Chanwoo Ping... Could you please review this patch? -jtc Subject: Re: [PATCH] extcon : callback function to read cable property I think the reason why we have extcon is in first place is to only notify the clients of cable connection and disconnection and it

Re: [PATCH] PM / OPP: predictable fail results for opp_find* functions

2012-10-17 Thread MyungJoo Ham
== ERR_PTR(-ERANGE)) opp = opp_find_freq_ceil(dev, freq); Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Rafael J. Wysocki r...@sisk.pl Cc: Kevin Hilman khil...@ti.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed

Re: Re: [GIT PULL] extcon fixes for Linux 3.6

2012-10-18 Thread MyungJoo Ham
Sender : Greg KHgre...@linuxfoundation.org Date : 2012-10-19 02:24 (GMT+09:00) On Thu, Oct 11, 2012 at 10:31:19AM +0900, Chanwoo Choi wrote: Hi Greg, Please pull extcon fixes for Linux 3.6 from: git://git.infradead.org/users/kmpark/linux-samsung extcon-for-next I've been

[RESEND PATCH] [CPUFREQ] EXYNOS: bugfix on retrieving old_index from freqs.old

2012-07-19 Thread MyungJoo Ham
be calculated not based on the current policy. We have been observing such issue when scaling_min/max_freq were updated and sometimes cuased system lockups deu to incorrectly configured voltages. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/cpufreq/exynos-cpufreq.c | 14

Re: [PATCH] PM: devfreq: fix typo CPU_EXYNOS4.12 twice

2013-03-14 Thread MyungJoo Ham
) makes clear that this should have been dependencies on SOC_EXYNOS4212 and SOC_EXYNOS4412. Signed-off-by: Paul Bolle pebo...@tiscali.nl Acked-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v2 1/2] PM / devfreq: Fix compiler warnings

2013-03-28 Thread MyungJoo Ham
On Wed, Mar 27, 2013 at 10:52 PM, Rajagopal Venkat rajagopal.ven...@linaro.org wrote: Fix compiler warnings generated when devfreq is not enabled (CONFIG_PM_DEVFREQ is not set). Signed-off-by: Rajagopal Venkat rajagopal.ven...@linaro.org Thanks! Acked-by: MyungJoo Ham myungjoo

Re: Re: [PATCH v4 4/4] PM: Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

2013-02-04 Thread MyungJoo Ham
Hi, Sorry for being late. One concern is that I cannot apply Patch 1/4 directly as the .dts file isn't available to me. Do you intend to apply that patch to another tree and apply the other three to devfreq tree? I have been merging the devfreq tree into Kgene's tree for my

Re: [PATCH 3/3] PM / devfreq: account suspend/resume for stats

2013-02-04 Thread MyungJoo Ham
On Tue, Jan 15, 2013 at 8:46 PM, Rajagopal Venkat rajagopal.ven...@linaro.org wrote: On 14 January 2013 20:18, MyungJoo Ham myungjoo@samsung.com wrote: On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat rajagopal.ven...@linaro.org wrote: devfreq stats is not taking device suspend and resume

Re: [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-02-04 Thread MyungJoo Ham
On Tue, Jan 15, 2013 at 8:21 PM, Rajagopal Venkat rajagopal.ven...@linaro.org wrote: On 14 January 2013 20:06, MyungJoo Ham myungjoo@samsung.com wrote: On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat rajagopal.ven...@linaro.org wrote: Set devfreq device min and max frequency limits when

[PATCH] PM / devfreq: add comments and Documentation

2013-02-05 Thread MyungJoo Ham
- Added missing ABI documents - Added comments to clarify the objectives of functions Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- Documentation/ABI/testing/sysfs-class-devfreq | 20 drivers/devfreq/devfreq.c | 10 ++ include/linux

Re: [PATCH v5 4/4] PM: Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

2013-02-05 Thread MyungJoo Ham
monitor and PPMU polling function * Moved exynos5 PPMU access functions to the devfreq driver Changes since v4: * Fixed compilation errors due to presence of devinit/devexit * Moved exynos ppmu header to the drivers/devfreq/exynos directory -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC

Re: [PATCH 0/4] OPP usage fixes for RCU locking

2013-01-20 Thread MyungJoo Ham
linux-pm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

2013-02-21 Thread MyungJoo Ham
On 12:33-20130222, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function exynos4_busfreq_pm_notifier_event() in the error handling case. This issue introduced by commit 8fa938 (PM / devfreq: exynos4_bus: honor RCU

Re: Re: [PATCH -next] extcon: extcon-arizona depends on INPUT

2012-09-05 Thread MyungJoo Ham
On Wed, Sep 05, 2012 at 11:28:03AM +0800, Mark Brown wrote: On Tue, Sep 04, 2012 at 04:51:00PM -0700, Randy Dunlap wrote: This build error still happens in linux-next of 20120904. Can we get the patch merged for linux-next? Greg's the one managing extcon in -next. Yeah, can

Re: [PATCH 2/3] devfreq: Add suspend and resume apis

2012-09-10 Thread MyungJoo Ham
Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume of devfreq load monitoring, required for devices which can idle. Signed-off-by: Rajagopal Venkat rajagopal.ven...@linaro.org Rather than letting device driver be responsible to call

Re: [PATCH v2 3/3] devfreq: Add current freq callback in device profile

2012-09-17 Thread MyungJoo Ham
sysfs node to expose governor predicted next target frequency. Signed-off-by: Rajagopal Venkat rajagopal.ven...@linaro.org Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- Documentation/ABI/testing/sysfs-class-devfreq | 11 ++- drivers/devfreq/devfreq.c

Re: Re: [PATCH v3 1/2] PM / devfreq: add global PM QoS support

2012-09-17 Thread MyungJoo Ham
Sender : Rafael J. Wysockir...@sisk.pl Date : 2012-09-09 07:20 (GMT+09:00) Title : Re: [PATCH v3 1/2] PM / devfreq: add global PM QoS support On Thursday, August 30, 2012, MyungJoo Ham wrote: Even if the performance of a device is controlled properly with devfreq, sometimes, we still need

Re: Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-17 Thread MyungJoo Ham
On 10 September 2012 14:43, 함명주 myungjoo@samsung.com wrote: Prepare devfreq core framework to support devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume back when device is online.

Re: Re: Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-17 Thread MyungJoo Ham
Sender : Rajagopal Venkatrajagopal.ven...@linaro.org Date : 2012-09-18 14:20 (GMT+09:00) Title : Re: Re: [PATCH 1/3] devfreq: core updates to support devices which can idle On 17 September 2012 17:46, MyungJoo Ham wrote: On 10 September 2012 14:43, 함명주 wrote: Prepare devfreq core

[PATCH v3 0/2] PM / devfreq: support PM-QoS at devfreq core.

2012-08-30 Thread MyungJoo Ham
The patchset is going to be shown at http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/devfreq-for-next within hours as well. MyungJoo Ham (2): PM / devfreq: add global PM QoS support PM / devfreq: support per-dev PM-QoS in devfreq drivers/devfreq/devfreq.c | 135

[PATCH v3 2/2] PM / devfreq: support per-dev PM-QoS in devfreq

2012-08-30 Thread MyungJoo Ham
Added support of per-dev PM-QoS request handling in devfreq core. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/devfreq.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq

[PATCH v3 1/2] PM / devfreq: add global PM QoS support

2012-08-30 Thread MyungJoo Ham
to be positive, min/max freq is now enforced regardless of governor implementation. Tested on Exynos4412 machines with memory/bus frequencies and multimedia H/W blocks. (camera, video decoding, and video encoding) Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH 1/2] [1/2]extcon: standard cable names definition and declaration changed

2012-08-31 Thread MyungJoo Ham
-by: anish kumar anish198519851...@gmail.com Looks good. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-class.c |4 +--- include/linux/extcon.h|2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-class.c b

Re: [PATCH 2/2] [2/2] extcon: optimising the check_mutually_exclusive function

2012-08-31 Thread MyungJoo Ham
. Singed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-class.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c index e09a6c3..06df95a 100644 --- a/drivers/extcon

Re: [PATCH] extcon: checkpatch warning removal

2012-08-31 Thread MyungJoo Ham
anish198519851...@gmail.com Ah.. yes.. I thought removing it could emit compiler errors. But, we have it declared in the header file. Good. Thanks. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-class.c |1 - 1 files changed, 0 insertions(+), 1 deletions

Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach

2012-09-03 Thread MyungJoo Ham
any comments ? Sorry for replying late. It has been applied to the extcon-for-next tree at http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next , which will appear in hours. On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga develkernel412...@gmail.com

Re: [PATCH] extcon: Remove duplicate inclusion of extcon.h header file

2012-08-07 Thread MyungJoo Ham
extcon.h header file was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Thanks! MyungJoo

[PATCH] Extcon: renamed files to comply with the standard naming.

2012-08-09 Thread MyungJoo Ham
Replaced '_' with '-' in the extcon file names, which has been bogging me since new drivers have been using the standard naming. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/Makefile |4 +- drivers/extcon/extcon-class.c | 832

[PATCH resend] Extcon: renamed files to comply with the standard naming.

2012-08-09 Thread MyungJoo Ham
Replaced '_' with '-' in the extcon file names, which has been bogging since new drivers have been using the standard naming. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/Makefile |4 ++-- drivers/extcon/{extcon_class.c = extcon-class.c

Re: [PATCH] [PATCH V4]Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

2012-08-09 Thread MyungJoo Ham
the cancel_work_sync during removing of driver. Reviewed-by: Lars-Peter Clausen l...@metafoo.de Signed-off-by: anish kumar anish.si...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/Kconfig |5 + drivers/extcon/Makefile|1

Re: [PATCH 1/2] devfreq: Add sysfs node for representing frequency transition information.

2012-08-23 Thread MyungJoo Ham
@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�j:+v돣�쳭喩zZ+€�+zf"톒쉱�~넮녬i鎬z�췿ⅱ�?솳鈺��)刪f뷌^j푹y쬶끷@A첺뛴 0띠h��뭝

Re: [PATCH 1/2] PM: devfreq: add freq table and available_freqs

2012-08-23 Thread MyungJoo Ham
Devfreq framework don't have a frequency table, add it for easy use. Signed-off-by: Xiaoguang Chen che...@marvell.com As we are going to have transition statistics (similar with trans_table and time_in_state of CPUfreq), we are going to have a data structure that your suggested code may use.

Re: [PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

2012-08-23 Thread MyungJoo Ham
This patch initializes freq_table and max_state of devfreq's profile. They will be used for creating transition table. Signed-off-by: Jonghwa Lee jonghwa3@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/exynos4_bus.c | 30

Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

2012-08-05 Thread MyungJoo Ham
others. Signed-off-by: anish kumar anish.si...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/Kconfig |5 + drivers/extcon/Makefile |1 + drivers/extcon/adc_jack.c | 183 +++ include

Re: Re: [PATCH V1]Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

2012-08-06 Thread MyungJoo Ham
-by: MyungJoo Ham myungjoo@samsung.com Hello, One little thing that I've missed before: Could you please rename the file? Though the initial files (class and gpio) didn't do it, like other recent ones, let's use '-' instead of '_'. Besides, could you please use extcon prefix for the filename

Re: [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250.

2012-12-10 Thread MyungJoo Ham
-- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: RE: [PATCH] extcon : callback function to read cable property

2012-11-19 Thread MyungJoo Ham
I think that the role of extcon subsystem notify changed state(attached/detached) of cable to notifiee, but if you want to add property feature of cable, you should solve ambiguous issues. First, This patch only support the properties of charger cable but, never support

Re: Re: [PATCH] extcon : callback function to read cable property

2012-11-20 Thread MyungJoo Ham
Anton Vorontsov wrote: The idea of using union seemed good to me, what happened to it? I mean, MyungJoo Ham wrote: | We may have: |enum extcon_cable_type { |EXTCON_CT_REGULATOR, |EXTCON_CT_PSY, |EXTCON_CT_CHARGER_CB

Re: opp_get_notifier() needs to be under rcu_lock?

2012-11-21 Thread MyungJoo Ham
Hi, It looks like find_device_opp() (called from opp_get_notifier()) needs to be under RCU read lock, but this doesn't seem to be happening in drivers/devfreq/devfreq.c. Doesn't this run the risk of referencing a freed variable? Thanks, -Kees Yes, that's an issue requiring updates.

[PATCH] PM / devfreq: missing rcu_read_lock() added for find_device_opp()

2012-11-21 Thread MyungJoo Ham
opp_get_notifier() uses find_device_opp(), which requires to held rcu_read_lock. In order to keep the notifier-header valid, we have added rcu_read_lock(). Reported-by: Kees Cook keesc...@chromium.org Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/devfreq.c | 26

Re: [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor()

2012-11-21 Thread MyungJoo Ham
Use the value obtained from the function instead of -EINVAL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: MyungJoo Ham myungjoo@samsung.com Both patches applied as they are obvious bugfixes. I'll send pull request with other bugfixes within days. --- drivers/devfreq

[GIT PULL] extcon fixes for Linux 3.7 rc6

2012-11-21 Thread MyungJoo Ham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681: Linux 3.7-rc6 (2012-11-16 17:42:40 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-gregkh Alexey

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread MyungJoo Ham
anyway. Otherwise, you may get unspecified behavior from the BUCK1/2/5, which may incur unstable system. Cheers, MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [GIT PULL] extcon fixes for Linux 3.7 rc6

2012-11-22 Thread MyungJoo Ham
On Wed, Nov 21, 2012 at 11:35 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Nov 21, 2012 at 08:15:25PM +0900, MyungJoo Ham wrote: The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681: Linux 3.7-rc6 (2012-11-16 17:42:40 -0800) are available in the git

[PATCH] PM / devfreq: missing rcu_read_lock() added for find_device_opp()

2012-11-22 Thread MyungJoo Ham
opp_get_notifier() uses find_device_opp(), which requires to held rcu_read_lock. In order to keep the notifier-header valid, we have added rcu_read_lock(). Reported-by: Kees Cook keesc...@chromium.org Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/devfreq.c | 26

[GIT PULL] extcon for Linux 3.8

2012-11-22 Thread MyungJoo Ham
/pub/scm/linux/kernel/git/mzx/extcon.git for-next Alexey Khoroshilov (1): extcon: arizona: unlock mutex on error path in arizona_micdet() Chanwoo Choi (1): extcon: Add missing header file to extcon.h MyungJoo Ham (1): extcon: kernel_doc style fix Sachin Kamat (9): extcon

[PULL REQUEST for Rafael] PM / devfreq: pull request-3 bugfixes

2012-11-25 Thread MyungJoo Ham
00:23:28 +0100) , which is HEAD of Rafael's linux-pm.git linux-next branch on 2012-11-22. are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git tags/pull_req_20121122 MyungJoo Ham (2): PM / devfreq: remove compiler error when a governor

[PULL REQUEST for Rafael] PM / devfreq: rebased on pm-devfreq

2012-11-26 Thread MyungJoo Ham
static (2012-11-15 00:35:06 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git tags/pull_req_20121126 Jonghwa Lee (1): PM / devfreq: Add sysfs node for representing frequency transition information. MyungJoo Ham (2): PM

Re: Re: [PULL REQUEST for Rafael] PM / devfreq: pull request-3 bugfixes

2012-11-26 Thread MyungJoo Ham
On Monday, November 26, 2012 03:41:22 PM MyungJoo Ham wrote: Dear Rafael, sorry for the inconviences; I forgot that I've updated the tag name according to the date modified. Please use pull_req_20121122 tag instead of pull_req_20121121 though I've pushed pull_req_20121121 tag

Re: Re: [GIT PULL] extcon for Linux 3.8

2012-11-26 Thread MyungJoo Ham
On Thu, Nov 22, 2012 at 01:51:10PM +0900, MyungJoo Ham wrote: Please pull extcon patches for Linux 3.8. This is not a signed-tag pull request, which I thought I asked for previously. Please create that, so that I can properly know I am getting the right pull request and patches

Re: Re: Re: [GIT PULL] extcon for Linux 3.8

2012-11-26 Thread MyungJoo Ham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Nov 27, 2012 at 12:54:30AM +, MyungJoo Ham wrote: On Thu, Nov 22, 2012 at 01:51:10PM +0900, MyungJoo Ham wrote: Please pull extcon patches for Linux 3.8. This is not a signed-tag pull request, which I thought I asked

Re: Re: [PATCH v3 1/3] devfreq: Core updates to support devices which can idle

2012-10-01 Thread MyungJoo Ham
On 27 September 2012 13:50, MyungJoo Ham myungjoo@samsung.com wrote: Prepare devfreq core framework to support devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume back when device

Re: [PATCH 1/4] ARM: EXYNOS5: Add PPMU device tree support

2013-01-14 Thread MyungJoo Ham
-by: MyungJoo Ham myungjoo@samsung.com --- .../bindings/arm/exynos/ppmu-exynos5.txt | 28 arch/arm/boot/dts/exynos5250.dtsi |9 ++ 2 files changed, 37 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree

Re: [PATCH 2/4] ARM: EXYNOS5: Support Exynos5-bus devfreq driver

2013-01-14 Thread MyungJoo Ham
On Wed, Jan 9, 2013 at 9:06 PM, Abhilash Kesavan a.kesa...@samsung.com wrote: Setup the INT clock ops to control/vary INT frequency Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com Cc: Jonghwan Choi jhbird.c...@samsung.com Cc: Kukjin Kim kgene@samsung.com Acked-by: MyungJoo Ham

Re: [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-01-14 Thread MyungJoo Ham
); -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-pm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung

Re: [PATCH 2/3] PM / devfreq: fix stats start time stamp

2013-01-14 Thread MyungJoo Ham
at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/3] PM / devfreq: account suspend/resume for stats

2013-01-14 Thread MyungJoo Ham
the line unsubscribe linux-pm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe

Re: [patch] PM / devfreq: create_freezable_workqueue() doesn't return an ERR_PTR

2013-08-18 Thread MyungJoo Ham
On Thu, Aug 15, 2013 at 4:55 PM, Dan Carpenter dan.carpen...@oracle.com wrote: The create_freezable_workqueue() function returns a NULL on error and not an ERR_PTR. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Thanks. I'll apply this. Signed-off-by: MyungJoo Ham myungjoo

Re: [PATCH] extcon: gpio: Request gpio pin before modifying its state

2013-11-24 Thread MyungJoo Ham
-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-gpio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 7e0dff5..4736a9c 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers

[PATCH] extcon: fix switch class porting guide (Documentation)

2013-11-25 Thread MyungJoo Ham
- Unfinished sentence finished. - Incorrect description on the compat-mode condition corrected. Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- Documentation/extcon/porting-android-switch-class |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

Re: [RFC 0/4] Add basic support for ASV

2013-11-12 Thread MyungJoo Ham
-kernel ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- MyungJoo Ham, Ph.D. System S/W Lab, S/W Center, Samsung Electronics -- To unsubscribe from this list: send

Re: [PATCH 3/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
On Tue, Nov 19, 2013 at 10:30 PM, Jonghwan Choi jhbird.c...@gmail.com wrote: Frequency lock should be considered in suspend/hibernation. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Applied in driver-update branch. Do you want

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
On Tue, Nov 19, 2013 at 10:30 PM, Jonghwan Choi jhbird.c...@gmail.com wrote: Frequency lock should be considered in suspend/hibernation. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Cheers, MyungJoo. --- drivers/devfreq

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
. Thanks, Sebastian Capella -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. System S/W Lab, S/W Center, Samsung

Re: [PATCH] PM / devfreq: Rewrite devfreq_update_status() to fix multiple bugs

2014-03-04 Thread MyungJoo Ham
The current devfreq_update_status() has the following bugs: - If previous frequency doesn't have a valid level, it does an out of bounds access into the trans_table and causes memory corruption. - When the new frequency doesn't have a valid level, the time spent in the new frequency is

Re: [PATCH 3/3] regulator: max8998: Remove unnecessary **rdev from struct max8998_data

2014-03-10 Thread MyungJoo Ham
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin axel@ingics.com Acked-by: MyungJoo Ham myungjoo@samsung.com

Re: [PATCH 2/3] regulator: max8997: Remove unnecessary **rdev from struct max8997_data

2014-03-10 Thread MyungJoo Ham
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin axel@ingics.com Acked-by: MyungJoo Ham myungjoo@samsung.com

[PULL REQUEST for Rafael] PM / devfreq: pull request

2014-03-20 Thread MyungJoo Ham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear Rafael, Here goes bugfix devfreq patch. Recent patchset of device-tree support / exynos driver updates is omitted in this pull request as there could be further updates on the patchset. Cheers, MyungJoo The following changes since commit

Re: Re: [RFC v2 0/3][TESTS] LAB: Support for Legacy Application Booster governor - tests results

2013-05-24 Thread MyungJoo Ham
On 24 May 2013 11:26, Lukasz Majewski l.majew...@samsung.com wrote: On 22 May 2013 15:57, Lukasz Majewski l.majew...@samsung.com As you wished, I've provided relevant data for overclocking. Would you be so kind and comment on them? I was about to reply ... was busy with some other

Re: Re: [PATCH v2] PM / devfreq: Use freq_table for available_frequencies

2014-05-08 Thread MyungJoo Ham
On 04/29/2014 01:00 PM, Saravana Kannan wrote: On 04/27/2014 06:41 PM, MyungJoo Ham wrote: You are hereby changing the semmantics of the original available_frequencies node. When a frequency/voltage pair has been disabled (opp_disable), probably by opp_disable(), the frequency

Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV

2014-05-22 Thread MyungJoo Ham
On Thu, May 22, 2014 at 5:37 AM, Paul Bolle pebo...@tiscali.nl wrote: Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig symbol has never been added to the tree. Remove these checks, as they always evaluate to false. Signed-off-by: Paul Bolle pebo...@tiscali.nl Thanks

Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV

2014-05-24 Thread MyungJoo Ham
On Fri, May 23, 2014 at 1:52 PM, MyungJoo Ham myungjoo@samsung.com wrote: On Thu, May 22, 2014 at 5:37 AM, Paul Bolle pebo...@tiscali.nl wrote: Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig symbol has never been added to the tree. Remove these checks

[GIT PULL] devfreq update for Linux 3.16

2014-05-24 Thread MyungJoo Ham
Dear Rafael, Here goes the pull request of devfreq for 3.16 Cheers, MyungJoo -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following changes since commit 4b660a7f5c8099d88d1a43d8ae138965112592c7: Linux 3.15-rc6 (2014-05-22 06:42:02 +0900) are available in the git repository at:

Re: [PATCH v3] extcon: gpio: Add power resume support

2014-01-06 Thread MyungJoo Ham
From: Rongjun Ying rongjun.y...@csr.com When system on the suspend state, Some SoC can't get gpio interrupt. After system resume, need send extcon uevent to userspace. Signed-off-by: Rongjun Ying rongjun.y...@csr.com Reviewed-by: Barry Song baohua.s...@csr.com Acked-by: MyungJoo Ham

Re: [PATCH v2] PM / devfreq: Use freq_table for available_frequencies

2014-04-27 Thread MyungJoo Ham
Some devices use freq_table instead of OPP. For those devices, the available_frequencies file shows up empty. Fix that by using freq_table to generate the available_frequencies data when it's available. OPP find frequency APIs also skips frequencies that have been temporarily disabled (say,

Re: Re: [PATCH] PM / devfreq: Use freq_table for available_frequencies

2014-04-18 Thread MyungJoo Ham
On 04/15/2014 11:41 AM, Saravana Kannan wrote: Ah, I misunderstood your previous email. I thought you Nack-ed my patch and decided to send your own patch to replace mine. Ok, I'll fix up mine and send it out. MyungJoo/Kyungmin, I sent out an updated patch. Can you please take a look?

Re: Re: [PATCH 1/1] extcon: gpio: Add power resume support

2013-12-23 Thread MyungJoo Ham
On 12/23/2013 05:13 PM, Barry Song wrote: 2013/12/23 Chanwoo Choi cw00.c...@samsung.com: On 12/23/2013 04:36 PM, Barry Song wrote: 2013/12/23 Chanwoo Choi cw00.c...@samsung.com: On 12/23/2013 03:10 PM, Barry Song wrote: 2013/12/23 Chanwoo Choi cw00.c...@samsung.com: On 12/20/2013

Re: [PATCH v3] PM / devfreq: Add possible_frequencies device attribute

2014-07-16 Thread MyungJoo Ham
Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- MyungJoo Ham, Ph.D. System S/W Lab

Re: RE: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-07-17 Thread MyungJoo Ham
different charger mangement frameworks in the kernel. I suggest to add features supported by charger-manager to power supply charging driver and convert users of charger-manager to the improved driver. I CC'd MyungJoo Ham, who wrote the charger-manager, so that he can also give

Re: Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C

2014-08-20 Thread MyungJoo Ham
Hi Geert Thanks for your report. I already sent a patch[1] to fix this build break and I'll send pull request to includec this patch in 3.17-rc2. [1] https://lkml.org/lkml/2014/8/13/761 Best Regards, Chanwoo Choi I do not object to this patch or your patch[1]. However, wouldn't it be

  1   2   3   4   5   6   7   >