Re: [PATCH 19/20] perf annotate: Add --percent-type option

On Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa wrote: > Adding --percent-type option to set annotation percent type > from following choices: > global-period, local-period, global-hits, local-hits > > Examples: > $ perf annotate --percent-type period-local --stdio | head -1 >Percent

Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

Hi Jiri, On Sat, Aug 04, 2018 at 03:05:15PM +0200, Jiri Olsa wrote: > Passing struct annotation_options to map_symbol__annotation_dump, > to carry on and pass the percent_type value. > > Link: http://lkml.kernel.org/n/tip-5toohgdkgpk3vn6zebusr...@git.kernel.org > Signed-off-by: Jiri Olsa > ---

Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

Hi Jiri, On Sat, Aug 04, 2018 at 03:05:15PM +0200, Jiri Olsa wrote: > Passing struct annotation_options to map_symbol__annotation_dump, > to carry on and pass the percent_type value. > > Link: http://lkml.kernel.org/n/tip-5toohgdkgpk3vn6zebusr...@git.kernel.org > Signed-off-by: Jiri Olsa > ---

Re: [PATCH 4/4] perf tools: Fix struct comm_str removal crash

rom the kernel, trying to see how this is used with __get() operations > there, if at all. Something like this? static struct comm_str *comm_str__get(struct comm_str *cs) { if (cs && refcount_inc_not_zero(>refcnt)) return cs; return NULL; } Other than that I don't have better idea, so Acked-by: Namhyung Kim Thanks, Namhyung

Re: [PATCH 4/4] perf tools: Fix struct comm_str removal crash

rom the kernel, trying to see how this is used with __get() operations > there, if at all. Something like this? static struct comm_str *comm_str__get(struct comm_str *cs) { if (cs && refcount_inc_not_zero(>refcnt)) return cs; return NULL; } Other than that I don't have better idea, so Acked-by: Namhyung Kim Thanks, Namhyung

Re: [PATCH 1/4] perf tools: Fix struct comm_str removal crash

Hi Jiri, On Mon, Jul 16, 2018 at 12:29:34PM +0200, Jiri Olsa wrote: > On Sun, Jul 15, 2018 at 10:08:27PM +0900, Namhyung Kim wrote: > > SNIP > > > > Because thread 2 first decrements the refcnt and only after then it > > > removes the struct comm_str from t

Re: [PATCH 1/4] perf tools: Fix struct comm_str removal crash

Hi Jiri, On Mon, Jul 16, 2018 at 12:29:34PM +0200, Jiri Olsa wrote: > On Sun, Jul 15, 2018 at 10:08:27PM +0900, Namhyung Kim wrote: > > SNIP > > > > Because thread 2 first decrements the refcnt and only after then it > > > removes the struct comm_str from t

Re: [PATCH 1/4] perf tools: Fix struct comm_str removal crash

Hi Jiri, On Thu, Jul 12, 2018 at 04:20:20PM +0200, Jiri Olsa wrote: > We occasionaly hit following assert failure in perf top, > when processing the /proc info in multiple threads. > > perf: ...include/linux/refcount.h:109: refcount_inc: > Assertion `!(!refcount_inc_not_zero(r))'

Re: [PATCH 1/4] perf tools: Fix struct comm_str removal crash

Hi Jiri, On Thu, Jul 12, 2018 at 04:20:20PM +0200, Jiri Olsa wrote: > We occasionaly hit following assert failure in perf top, > when processing the /proc info in multiple threads. > > perf: ...include/linux/refcount.h:109: refcount_inc: > Assertion `!(!refcount_inc_not_zero(r))'

Re: [PATCH v2] perf script python: Fix dict reference counting

ects. > > Signed-off-by: Janne Huttunen Acked-by: Namhyung Kim Thanks, Namhyung

Re: [PATCH v2] perf script python: Fix dict reference counting

ects. > > Signed-off-by: Janne Huttunen Acked-by: Namhyung Kim Thanks, Namhyung

Re: [PATCH v8 6/8] tracing: Centralize preemptirq tracepoints and unify their usage

LED|FAILED| ok | > [0.00] soft-safe-A + irqs-on/21:FAILED|FAILED| ok | > [0.00] hard-safe-A + unsafe-B #1/123: ok | ok | ok | > [0.00] soft-safe-A + unsafe-B #1/123: ok | ok | ok | > > Signed-off-by: Joel Fernandes (Google) Re

Re: [PATCH v8 6/8] tracing: Centralize preemptirq tracepoints and unify their usage

LED|FAILED| ok | > [0.00] soft-safe-A + irqs-on/21:FAILED|FAILED| ok | > [0.00] hard-safe-A + unsafe-B #1/123: ok | ok | ok | > [0.00] soft-safe-A + unsafe-B #1/123: ok | ok | ok | > > Signed-off-by: Joel Fernandes (Google) Re

Re: [PATCH v7 6/8] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Joel, On Wed, May 23, 2018 at 06:21:55PM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > This patch detaches the preemptirq tracepoints from the tracers and > keeps it separate. > > Advantages: > * Lockdep and irqsoff event can now run in parallel

Re: [PATCH v7 6/8] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Joel, On Wed, May 23, 2018 at 06:21:55PM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > This patch detaches the preemptirq tracepoints from the tracers and > keeps it separate. > > Advantages: > * Lockdep and irqsoff event can now run in parallel since they no longer >

Re: [PATCH v3 00/14] tracing: Add triggers to trace_marker writes

eset_trigger() to handle triggers with filters > tracing/selftest: Add selftests to test trace_marker histogram triggers > tracing/selftest: Add test to test hist trigger between kernel event > and trace_marker > > For the series: Reviewed-by: Namhyung Kim <n

Re: [PATCH v3 00/14] tracing: Add triggers to trace_marker writes

eset_trigger() to handle triggers with filters > tracing/selftest: Add selftests to test trace_marker histogram triggers > tracing/selftest: Add test to test hist trigger between kernel event > and trace_marker > > For the series: Reviewed-by: Namhyung Kim Th

Re: [PATCH v2 14/14] tracing/selftest: Add test to test hist trigger between kernel event and trace_marker

On Mon, May 14, 2018 at 04:58:59PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add a test that tests a trigger that is initiated by a kernel event > (sched_waking) and compared to a write to the trace_marker. > > Signed-off-by: Steven Rostedt (VMware)

Re: [PATCH v2 14/14] tracing/selftest: Add test to test hist trigger between kernel event and trace_marker

On Mon, May 14, 2018 at 04:58:59PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add a test that tests a trigger that is initiated by a kernel event > (sched_waking) and compared to a write to the trace_marker. > > Signed-off-by: Steven Rostedt (VMware) > --- >

Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace internal events

On Mon, May 14, 2018 at 04:58:50PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The filter file in the ftrace internal events, like in > /sys/kernel/tracing/events/ftrace/function/filter is not attached to any > functionality. Do not create them as they

Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace internal events

On Mon, May 14, 2018 at 04:58:50PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The filter file in the ftrace internal events, like in > /sys/kernel/tracing/events/ftrace/function/filter is not attached to any > functionality. Do not create them as they are meaningless. >

Re: [RFC][PATCH 06/10] tracing: Add trigger file for trace_markers tracefs/ftrace/print

Hi Steve, On Mon, May 14, 2018 at 11:04:36AM -0400, Steven Rostedt wrote: > On Mon, 14 May 2018 12:13:22 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > On Fri, May 11, 2018 at 03:49:33PM -0400, Steven Rostedt wrote: > > > From: "Steven Ros

Re: [RFC][PATCH 06/10] tracing: Add trigger file for trace_markers tracefs/ftrace/print

Hi Steve, On Mon, May 14, 2018 at 11:04:36AM -0400, Steven Rostedt wrote: > On Mon, 14 May 2018 12:13:22 +0900 > Namhyung Kim wrote: > > > On Fri, May 11, 2018 at 03:49:33PM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > &g

Re: [RFC][PATCH 06/10] tracing: Add trigger file for trace_markers tracefs/ftrace/print

On Fri, May 11, 2018 at 03:49:33PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow writing to the trace_markers file initiate triggers defined in > tracefs/ftrace/print/trigger file. This will allow of user space to trigger > the same type of

Re: [RFC][PATCH 06/10] tracing: Add trigger file for trace_markers tracefs/ftrace/print

On Fri, May 11, 2018 at 03:49:33PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow writing to the trace_markers file initiate triggers defined in > tracefs/ftrace/print/trigger file. This will allow of user space to trigger > the same type of triggers (including

Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic be full string

Hi, On Sat, May 12, 2018 at 08:32:18PM +0200, Yann Ylavic wrote: > On Fri, May 11, 2018 at 9:49 PM, Steven Rostedt wrote: > [] > > > > static int regex_match_front(char *str, struct regex *r, int len) > > { > > - if (len < r->len) > > + if (len && len < r->len)

Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic be full string

Hi, On Sat, May 12, 2018 at 08:32:18PM +0200, Yann Ylavic wrote: > On Fri, May 11, 2018 at 9:49 PM, Steven Rostedt wrote: > [] > > > > static int regex_match_front(char *str, struct regex *r, int len) > > { > > - if (len < r->len) > > + if (len && len < r->len) > >

[tip:perf/urgent] perf machine: Set main kernel end address properly

Commit-ID: ee05d21791db6db954bbb7b79bb18d88b5f6b7ff Gitweb: https://git.kernel.org/tip/ee05d21791db6db954bbb7b79bb18d88b5f6b7ff Author: Namhyung Kim <namhy...@kernel.org> AuthorDate: Mon, 19 Feb 2018 19:05:45 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/urgent] perf machine: Set main kernel end address properly

Commit-ID: ee05d21791db6db954bbb7b79bb18d88b5f6b7ff Gitweb: https://git.kernel.org/tip/ee05d21791db6db954bbb7b79bb18d88b5f6b7ff Author: Namhyung Kim AuthorDate: Mon, 19 Feb 2018 19:05:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 23 Apr 2018 10:52:55 -0300 perf machine

Re: [PATCH] perf tools: set kernel end address properly

On Thu, Apr 19, 2018 at 06:33:13PM -0500, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:54:24 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > > > diff --git a/tools/perf/arch/arm64/util/sym-handl

Re: [PATCH] perf tools: set kernel end address properly

On Thu, Apr 19, 2018 at 06:33:13PM -0500, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:54:24 +0900 > Namhyung Kim wrote: > > > On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > > > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > > >

Re: [PATCH] perf tools: set kernel end address properly

On Thu, Apr 19, 2018 at 06:20:24PM -0500, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:37:12 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > I think the problem is perf assumes the kernel is the > > first map in the kmaps. When it calls maps_groups__insert() it use

Re: [PATCH] perf tools: set kernel end address properly

On Thu, Apr 19, 2018 at 06:20:24PM -0500, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:37:12 +0900 > Namhyung Kim wrote: > > I think the problem is perf assumes the kernel is the > > first map in the kmaps. When it calls maps_groups__insert() it uses > > start address

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

On Wed, Apr 18, 2018 at 06:02:50PM +0900, Masami Hiramatsu wrote: > On Mon, 16 Apr 2018 21:07:47 -0700 > Joel Fernandes wrote: > > > With TRACE_IRQFLAGS, we call trace_ API too many times. We don't need > > to if local_irq_restore or local_irq_save didn't actually do anything.

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

On Wed, Apr 18, 2018 at 06:02:50PM +0900, Masami Hiramatsu wrote: > On Mon, 16 Apr 2018 21:07:47 -0700 > Joel Fernandes wrote: > > > With TRACE_IRQFLAGS, we call trace_ API too many times. We don't need > > to if local_irq_restore or local_irq_save didn't actually do anything. > > > > This

Re: [PATCH] perf tools: set kernel end address properly

On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > b/tools/perf/arch/arm64/util/sym-handling.c > index 0051b1ee8450..5c4a2e208bbc 100644 > --- a/tools/perf/arch/arm64/util/sym-handling.c > +++

Re: [PATCH] perf tools: set kernel end address properly

On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > b/tools/perf/arch/arm64/util/sym-handling.c > index 0051b1ee8450..5c4a2e208bbc 100644 > --- a/tools/perf/arch/arm64/util/sym-handling.c > +++

Re: [PATCH] perf tools: set kernel end address properly

On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > On Tue, 17 Apr 2018 11:27:26 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > > > > a perf/urgent from last week (co

Re: [PATCH] perf tools: set kernel end address properly

On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > On Tue, 17 Apr 2018 11:27:26 +0900 > Namhyung Kim wrote: > > On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > > > > a perf/urgent from last week (commit 918965d4897) + this patch: > > &

Re: [PATCH 2/6] tracing: Add trace event error log

Hi guys, :) On Wed, Apr 18, 2018 at 09:49:24AM -0400, Steven Rostedt wrote: > On Wed, 18 Apr 2018 18:34:34 +0900 > Masami Hiramatsu wrote: > > > On Fri, 13 Apr 2018 10:44:32 -0400 > > Steven Rostedt wrote: > > > > > On Fri, 13 Apr 2018 09:24:34 -0500

Re: [PATCH 2/6] tracing: Add trace event error log

Hi guys, :) On Wed, Apr 18, 2018 at 09:49:24AM -0400, Steven Rostedt wrote: > On Wed, 18 Apr 2018 18:34:34 +0900 > Masami Hiramatsu wrote: > > > On Fri, 13 Apr 2018 10:44:32 -0400 > > Steven Rostedt wrote: > > > > > On Fri, 13 Apr 2018 09:24:34 -0500 > > > Tom Zanussi wrote: > > > > > > >

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

Hi, On Fri, Apr 13, 2018 at 10:39:40AM -0700, Andi Kleen wrote: > > What do I miss? Or where is it that I'm misinterpreting the calculations > > that objdump did in its output? > > The calculations are right, but these are still two different address modes. > You cannot just turn one silently

Re: [PATCH 17/17] perf annotate: Handle variables in 'sub', 'or' and many other instructions

Hi, On Fri, Apr 13, 2018 at 10:39:40AM -0700, Andi Kleen wrote: > > What do I miss? Or where is it that I'm misinterpreting the calculations > > that objdump did in its output? > > The calculations are right, but these are still two different address modes. > You cannot just turn one silently

Re: [PATCH] perf tools: set kernel end address properly

t; Em Mon, Apr 16, 2018 at 11:07:30AM -0500, Kim Phillips escreveu: > > > > On Mon, 16 Apr 2018 10:51:25 -0300 > > > > Arnaldo Carvalho de Melo <a...@kernel.org> wrote: > > > > > > > > > Em Mon, Apr 16, 2018 at 11:23

Re: [PATCH] perf tools: set kernel end address properly

hillips escreveu: > > > > On Mon, 16 Apr 2018 10:51:25 -0300 > > > > Arnaldo Carvalho de Melo wrote: > > > > > > > > > Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > > > > > > On Mon, Apr 16, 2018 at 01:22:

[PATCH] perf tools: set kernel end address properly

the map_groups__fixup_end(). If there's no module after the kernel map, the end address will be ~0ULL. Reported-by: Kim Phillips <kim.phill...@arm.com> Signed-off-by: Namhyung Kim <namhy...@kernel.org> --- tools/perf/util/machine.c | 20 1 file changed, 8 insertions(+),

[PATCH] perf tools: set kernel end address properly

the map_groups__fixup_end(). If there's no module after the kernel map, the end address will be ~0ULL. Reported-by: Kim Phillips Signed-off-by: Namhyung Kim --- tools/perf/util/machine.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/machine.c

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

On Thu, Apr 12, 2018 at 07:09:54PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 10:57:56 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > > On Thu, 12 Apr 2018 08:31:09 +0900 > >

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

On Thu, Apr 12, 2018 at 07:09:54PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 10:57:56 +0900 > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > > On Thu, 12 Apr 2018 08:31:09 +0900 > > > Namhyung Kim wrote: > &

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 08:31:09 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > Hello, > > Hi, > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > --- > &

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 08:31:09 +0900 > Namhyung Kim wrote: > > > Hello, > > Hi, > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > --- > > > It's not clear to me

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

restore_nameidata > 7.60% true [kernel.kallsyms] [k] perf_iterate_ctx.constprop.38 > 0.69% perf.go [kernel.kallsyms] [k] perf_event_exec > > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Jiri Olsa <jo...@kernel.org>

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

restore_nameidata > 7.60% true [kernel.kallsyms] [k] perf_iterate_ctx.constprop.38 > 0.69% perf.go [kernel.kallsyms] [k] perf_event_exec > > Cc: Arnaldo Carvalho de Melo > Cc: Namhyung Kim > Cc: Jiri Olsa > Cc: Ingo Molnar > Cc: David Ahern > Cc: Alexander Shis

Re: [PATCH v2 1/2] perf sched: move thread::shortname to thread_runtime

Hi, On Tue, Mar 06, 2018 at 11:37:36AM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The thread::shortname only used by sched command, so move it > to sched private structure. > > Signed-off-by: Changbin Du > --- [SNIP] > diff --git

Re: [PATCH v2 1/2] perf sched: move thread::shortname to thread_runtime

Hi, On Tue, Mar 06, 2018 at 11:37:36AM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The thread::shortname only used by sched command, so move it > to sched private structure. > > Signed-off-by: Changbin Du > --- [SNIP] > diff --git a/tools/perf/util/thread.h

Re: [RESEND PATCH] perf sched map: re-annotate shortname if thread comm changed

Hi, On Mon, Mar 05, 2018 at 11:37:54PM +0100, Jiri Olsa wrote: > On Mon, Mar 05, 2018 at 03:11:36PM +0800, Du, Changbin wrote: > > SNIP > > > > > on the other hand it's simple enough and looks > > > > like generic solution would be more tricky > > > > > > What about adding

Re: [RESEND PATCH] perf sched map: re-annotate shortname if thread comm changed

Hi, On Mon, Mar 05, 2018 at 11:37:54PM +0100, Jiri Olsa wrote: > On Mon, Mar 05, 2018 at 03:11:36PM +0800, Du, Changbin wrote: > > SNIP > > > > > on the other hand it's simple enough and looks > > > > like generic solution would be more tricky > > > > > > What about adding

Re: [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Fri, Mar 02, 2018 at 03:32:29PM +0900, Masami Hiramatsu wrote: > On Fri, 2 Mar 2018 13:49:51 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > Hi Masami, > > > > On Wed, Feb 28, 2018 at 12:19:53PM +0900, Masami Hiramatsu wrote: > > &

Re: [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Fri, Mar 02, 2018 at 03:32:29PM +0900, Masami Hiramatsu wrote: > On Fri, 2 Mar 2018 13:49:51 +0900 > Namhyung Kim wrote: > > > Hi Masami, > > > > On Wed, Feb 28, 2018 at 12:19:53PM +0900, Masami Hiramatsu wrote: > > > In Document

Re: [RESEND PATCH] perf sched map: re-annotate shortname if thread comm changed

Hi, On Fri, Mar 02, 2018 at 12:38:45PM +0100, Jiri Olsa wrote: > On Fri, Mar 02, 2018 at 06:52:54PM +0800, Du, Changbin wrote: > > Hello, any comment? > > sry, overlooked this one > > SNIP > > > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > > > index 68b65b1..c660fe6

Re: [RESEND PATCH] perf sched map: re-annotate shortname if thread comm changed

Hi, On Fri, Mar 02, 2018 at 12:38:45PM +0100, Jiri Olsa wrote: > On Fri, Mar 02, 2018 at 06:52:54PM +0800, Du, Changbin wrote: > > Hello, any comment? > > sry, overlooked this one > > SNIP > > > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > > > index 68b65b1..c660fe6

Re: [PATCH v4 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event

On Wed, Feb 28, 2018 at 12:28:11PM +0900, Masami Hiramatsu wrote: > Add a testcase for array type with kprobe event. > This tests whether the traced data is correct or not. > If the kernel doesn't support array type, it skips > the test as UNSUPPORTED. This description is wrong - it's for

Re: [PATCH v4 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event

On Wed, Feb 28, 2018 at 12:28:11PM +0900, Masami Hiramatsu wrote: > Add a testcase for array type with kprobe event. > This tests whether the traced data is correct or not. > If the kernel doesn't support array type, it skips > the test as UNSUPPORTED. This description is wrong - it's for

Re: [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Wed, Feb 28, 2018 at 12:19:53PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

Re: [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Wed, Feb 28, 2018 at 12:19:53PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

Re: [PATCH v3 15/18] tracing: probeevent: Add array type support

On Sat, Feb 24, 2018 at 02:35:40PM +0900, Masami Hiramatsu wrote: > Add array type support for probe events. > This allows user to get arraied types from memory address. > The array type syntax is > > TYPE[N] > > Where TYPE is one of types (u8/16/32/64,s8/16/32/64, > x8/16/32/64, symbol,

Re: [PATCH v3 15/18] tracing: probeevent: Add array type support

On Sat, Feb 24, 2018 at 02:35:40PM +0900, Masami Hiramatsu wrote: > Add array type support for probe events. > This allows user to get arraied types from memory address. > The array type syntax is > > TYPE[N] > > Where TYPE is one of types (u8/16/32/64,s8/16/32/64, > x8/16/32/64, symbol,

Re: [PATCH v3 01/18] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Sat, Feb 24, 2018 at 02:28:52PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

Re: [PATCH v3 01/18] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Sat, Feb 24, 2018 at 02:28:52PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

Re: [PATCH v2 07/17] tracing: probeevent: Introduce new argument fetching code

On Wed, Feb 21, 2018 at 11:57:36PM +0900, Masami Hiramatsu wrote: > Replace {k,u}probe event argument fetching framework > with switch-case based. Currently that is implemented > with structures, macros and chain of function-pointers, > which is more complicated than necessary and may get > a

Re: [PATCH v2 07/17] tracing: probeevent: Introduce new argument fetching code

On Wed, Feb 21, 2018 at 11:57:36PM +0900, Masami Hiramatsu wrote: > Replace {k,u}probe event argument fetching framework > with switch-case based. Currently that is implemented > with structures, macros and chain of function-pointers, > which is more complicated than necessary and may get > a

Re: [BUGFIX PATCH v2.1] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Thu, Feb 22, 2018 at 04:45:01PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

Re: [BUGFIX PATCH v2.1] tracing: probeevent: Fix to support minus offset from symbol

Hi Masami, On Thu, Feb 22, 2018 at 04:45:01PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit

[tip:perf/core] perf machine: Fix paranoid check in machine__set_kernel_mmap()

Commit-ID: 1d12cec6ce99614297e10945d917fd8a62cd2b09 Gitweb: https://git.kernel.org/tip/1d12cec6ce99614297e10945d917fd8a62cd2b09 Author: Namhyung Kim <namhy...@kernel.org> AuthorDate: Mon, 19 Feb 2018 19:00:46 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf machine: Fix paranoid check in machine__set_kernel_mmap()

Commit-ID: 1d12cec6ce99614297e10945d917fd8a62cd2b09 Gitweb: https://git.kernel.org/tip/1d12cec6ce99614297e10945d917fd8a62cd2b09 Author: Namhyung Kim AuthorDate: Mon, 19 Feb 2018 19:00:46 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 19 Feb 2018 09:17:46 -0300 perf machine

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Arnaldo, On Mon, Feb 19, 2018 at 9:21 PM, Arnaldo Carvalho de Melo <a...@kernel.org> wrote: > Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: >> On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: >> > if (!machine__get_runn

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Arnaldo, On Mon, Feb 19, 2018 at 9:21 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim escreveu: >> On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: >> > if (!machine__get_running_kernel_start(machine, , )) { >>

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:01:40AM +0100, Jiri Olsa wrote: > On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: > > SNIP > > > > +static void machine__set_kernel_mmap(struct machine *machine, > > > + u64 start, u

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

On Mon, Feb 19, 2018 at 11:01:40AM +0100, Jiri Olsa wrote: > On Mon, Feb 19, 2018 at 11:20:36AM +0900, Namhyung Kim wrote: > > SNIP > > > > +static void machine__set_kernel_mmap(struct machine *machine, > > > + u64 start, u

Re: [PATCH v4] perf ftrace: Append an EOL when write tracing files

ed error is hidden. > > The original fix is to make the kernel support '\0' as end of string: > https://lkml.org/lkml/2018/1/16/116 > > But above fix cannot be compatible with old kernels. Then Namhyung Kim > suggest adding a space after function name. > > This patch will

Re: [PATCH v4] perf ftrace: Append an EOL when write tracing files

> The original fix is to make the kernel support '\0' as end of string: > https://lkml.org/lkml/2018/1/16/116 > > But above fix cannot be compatible with old kernels. Then Namhyung Kim > suggest adding a space after function name. > > This patch will append an '\n' when write t

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Jiri and Arnaldo, On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > We should not search for kernel start address in > __machine__create_kernel_maps function, because it's being > used in 'report' code path, where we are interested in kernel > MMAP data address instead of in current

Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

Hi Jiri and Arnaldo, On Thu, Feb 15, 2018 at 01:26:32PM +0100, Jiri Olsa wrote: > We should not search for kernel start address in > __machine__create_kernel_maps function, because it's being > used in 'report' code path, where we are interested in kernel > MMAP data address instead of in current

Re: [PATCH v3] perf ftrace: Append an EOL when write tracing files

The expected error is hidden. > > The original fix is to make the kernel support '\0' as end of string: > https://lkml.org/lkml/2018/1/16/116 > > But above fix cannot be compatible with old kernels. Then Namhyung Kim > suggest adding a space after function name. > > This pa

Re: [PATCH v3] perf ftrace: Append an EOL when write tracing files

. > > The original fix is to make the kernel support '\0' as end of string: > https://lkml.org/lkml/2018/1/16/116 > > But above fix cannot be compatible with old kernels. Then Namhyung Kim > suggest adding a space after function name. > > This patch will append an '\n' when wri

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

Hi Steve, On Mon, Feb 12, 2018 at 12:23:54PM -0500, Steven Rostedt wrote: > On Mon, 12 Feb 2018 11:15:34 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > > It should have been: > > > > > > return process_redirects(arg, val, buf); >

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

Hi Steve, On Mon, Feb 12, 2018 at 12:23:54PM -0500, Steven Rostedt wrote: > On Mon, 12 Feb 2018 11:15:34 +0900 > Namhyung Kim wrote: > > > > It should have been: > > > > > > return process_redirects(arg, val, buf); > > > > But I thin

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > Hi, > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > > From

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > Hi, > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > > From: Changbin Du > > &

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

On Fri, Feb 09, 2018 at 10:47:58AM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 14:13:01 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > On Fri, Feb 02, 2018 at 06:05:15PM -0500, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)"

Re: [PATCH 17/18] tracing: Add indirect to indirect access for function based events

On Fri, Feb 09, 2018 at 10:47:58AM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 14:13:01 +0900 > Namhyung Kim wrote: > > > On Fri, Feb 02, 2018 at 06:05:15PM -0500, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > > >

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

Hi Steve, On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 09:34:36 +0900 > Namhyung Kim <namhy...@kernel.org> wrote: > > > Couldn't we use the symbol name directly? Maybe it needs a syntax to > > indicate global variable. L

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

Hi Steve, On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 09:34:36 +0900 > Namhyung Kim wrote: > > > Couldn't we use the symbol name directly? Maybe it needs a syntax to > > indicate global variable. Like this? > > > >

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

Hello, On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The terminal character '\0' should take into account into size of the > string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' > and '--trace-funcs'

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

Hello, On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The terminal character '\0' should take into account into size of the > string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' > and '--trace-funcs' options didn't work as

Re: [PATCH] tracing/fgraph: Missed irq return mark for leaf entry

smp_apic_timer_interrupt(); > 0) <== | > 0) + 36.507 us | } /* __vfs_write */ > 0) 0.049 us| __fsnotify_parent(); > 0) 0.066 us| fsnotify(); > 0) + 50.064 us |} > 0) + 50.952 us | } > > Signed-off-by: Changbin Du <changb

Re: [PATCH] tracing/fgraph: Missed irq return mark for leaf entry

terrupt(); > 0) <== | > 0) + 36.507 us | } /* __vfs_write */ > 0) 0.049 us| __fsnotify_parent(); > 0) 0.066 us| fsnotify(); > 0) + 50.064 us |} > 0) + 50.952 us | } > > Signed-off-by: Changbin Du Acked-by: Namhyung Kim Thanks, Nam

Re: [PATCH 2/2] perf mem: Document a missing option

On Mon, Feb 12, 2018 at 05:38:37AM +0900, Sangwon Hong wrote: > Add the missing --force option on the man page. > > Cc: Jiri Olsa <jo...@kernel.org> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Taeung Song <treeze.tae...@gmail.com> > Signed-off-by: Sa

Re: [PATCH 2/2] perf mem: Document a missing option

On Mon, Feb 12, 2018 at 05:38:37AM +0900, Sangwon Hong wrote: > Add the missing --force option on the man page. > > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Taeung Song > Signed-off-by: Sangwon Hong Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/Docume

Re: [PATCH 1/2] perf kmem: Document a missing option & an argument

tion's argument. > > Cc: Jiri Olsa <jo...@kernel.org> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Taeung Song <treeze.tae...@gmail.com> > Signed-off-by: Sangwon Hong <qpa...@gmail.com> Acked-by: Namhyung Kim <namhy...@kernel.org> A nit below th

<    3   4   5   6   7   8   9   10   11   12   >