[PATCH] ubsan: Implement __ubsan_handle_alignment_assumption

2021-01-12 Thread Nathan Chancellor
org-11.0.1/compiler-rt/lib/ubsan/ubsan_handlers.cpp#L151-L190 Signed-off-by: Nathan Chancellor --- lib/ubsan.c | 28 lib/ubsan.h | 6 ++ 2 files changed, 34 insertions(+) diff --git a/lib/ubsan.c b/lib/ubsan.c index 3e3352f3d0da..a1e6cc999

Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption

2021-01-12 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 01:15:42PM -0800, Nick Desaulniers wrote: > On Tue, Jan 12, 2021 at 12:55 PM Nathan Chancellor > wrote: > > > > When building ARCH=mips 32r2el_defconfig with CONFIG_UBSAN_ALIGNMENT: > > > > ld.lld: error: undefined symbol: __ubs

Re: upstream build error (12)

2021-01-12 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 11:20:27AM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:e609571b Merge tag 'nfs-for-5.11-2' of git://git.linux-nfs.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15965a00d0 >

Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

2021-01-12 Thread Nathan Chancellor
rnd Bergmann I would like to see some movement on getting this fixed in 5.11. As it stands, this is one of three __compiletime_assert references with CONFIG_UBSAN_UNSIGNED_OVERFLOW. If we want to keep the BUILD_BUG() around, I think this is fine. Alternatively, turning it into a runtime check wou

[PATCH] dmaengine: qcom: Always inline gpi_update_reg

2021-01-12 Thread Nathan Chancellor
ime so the check in field_multiplier stays in the final object file, causing the above linkage failure. Always inline gpi_update_reg so that this check can never fail. Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1243 Sign

Re: [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret

2021-01-12 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 06:48:48PM +, Mark Brown wrote: > This is a random warning fix, why would you expect it to be sent as a > bug fix? This is the first indication I've seen that anyone is seeing > it in mainline, in general the people who report and fix warnings are > doing so based on

Re: [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret

2021-01-12 Thread Nathan Chancellor
On Wed, Dec 16, 2020 at 06:44:24PM +0800, Shengjiu Wang wrote: > From: shengjiu wang > > When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) > is true, then goto fail, the uninitialized variable ret will be > returned. > > Signed-off-by: shengjiu wang > Reported-by: kernel test

Re: [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 05:10:04PM +0800, kernel test robot wrote: > Hi Bill, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.11-rc3] > [cannot apply to powerpc/next s390/features tip/x86/core next-20210111] >

Re: [PATCH] ARM: fix link warning with XIP + frame-pointer

2021-01-12 Thread Nathan Chancellor
was already merged for the normal (non-XIP) > linker script, with a longer description. > > Fixes: c39866f268f8 ("arm/build: Always handle .ARM.exidx and .ARM.extab > sections") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > arch

Re: [PATCH] USB: serial: mos7720: improve handling of a kmalloc failure in read_mos_reg()

2021-01-11 Thread Nathan Chancellor
ead_mos_reg() check the return status. > > So move the clearing of data to before the malloc. > > Fixes: 0d130367abf5 ("USB: serial: mos7720: fix control-message error > handling") > Signed-off-by: Tom Rix Reviewed-by: Nathan Chancellor > --- > drivers/usb/ser

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 12:18:21AM -0800, Bill Wendling wrote: > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is collected from

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 04:50:50AM +0900, Masahiro Yamada wrote: > On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor > wrote: > > > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > > >

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > wrote: > > > > After commit da5fb18225b4 ("bpf: Support pre-2.25-binutils objcopy for > > vmlinux BTF"), having CONFIG_DEBUG_INFO_BTF en

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 08:03:29PM +0100, Andrey Konovalov wrote: > On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor > wrote: > > > > > > -config KASAN_STACK_ENABLE > > > > +config KASAN_STACK > > > > bool "Enable stack instrumentati

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Nathan Chancellor
kernel.org/show_bug.cgi?id=210221 > > > > Signed-off-by: Walter Wu > > Suggested-by: Dmitry Vyukov > > Cc: Andrey Ryabinin > > Cc: Dmitry Vyukov > > Cc: Andrey Konovalov > > Cc: Alexander Potapenko > > Cc: Andrew Morton > > Cc: Nathan

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 10:57:35AM +0100, Sedat Dilek wrote: > On Mon, Jan 11, 2021 at 10:17 AM Bill Wendling wrote: > > > > On Mon, Jan 11, 2021 at 12:39 AM Sedat Dilek wrote: > > > > > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > > > wrote: > > > > > > > > From:

[PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Nathan Chancellor
s standard for options that require a specific tools version. Suggested-by: Sedat Dilek Signed-off-by: Nathan Chancellor --- MAINTAINERS | 1 + init/Kconfig | 4 lib/Kconfig.debug | 6 ++ scripts/link-vmlinux.sh | 13 - scripts/pahole-versi

Re: drivers/soc/litex/litex_soc_ctrl.c:143:34: warning: unused variable 'litex_soc_ctrl_of_match'

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 09:30:55PM +0900, Stafford Horne wrote: > On Thu, Jan 07, 2021 at 04:04:47AM +0800, kernel test robot wrote: > > Hi Pawel, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > >

Re: [PATCH mips-fixes] MIPS: relocatable: fix possible boot hangup with KASLR enabled

2021-01-10 Thread Nathan Chancellor
ut I did reproduce the hang that the commit mentions with malta_kvm_guest_defconfig + CONFIG_RELOCATABLE=y + CONFIG_RANDOMIZE_BASE=y and this patch does resolve it so: Tested-by: Nathan Chancellor > --- > arch/mips/kernel/relocate.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > dif

Re: [PATCH] block/rnbd-clt: improve find_or_create_sess() return check

2021-01-10 Thread Nathan Chancellor
initialized but this makes sense to me. I am not sure the commit above find_or_create_sess() is needed but again, personal preference. Reviewed-by: Nathan Chancellor > --- > drivers/block/rnbd/rnbd-clt.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff

Re: [PATCH v5 mips-next 8/9] vmlinux.lds.h: catch UBSAN's "unnamed data" into data

2021-01-10 Thread Nathan Chancellor
d.lld: warning: net/built-in.a(netfilter/utils.o): (.data.$__unnamed_5) > is being placed in '.data.$__unnamed_5' > > [...] > > Also handle this by adding the related sections to generic definitions. > > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chancellor > -

Re: [PATCH v5 mips-next 5/9] MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols

2021-01-10 Thread Nathan Chancellor
and declare it in vmlinux.lds.S closer > to __init_end. > > [0] https://lore.kernel.org/linux-mips/20210109111259.ga4...@alpha.franken.de > > Reported-by: Thomas Bogendoerfer > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chancellor > --- > arch/mips/kernel/vmlin

Re: [PATCH v4 mips-next 7/7] MIPS: select ARCH_WANT_LD_ORPHAN_WARN

2021-01-08 Thread Nathan Chancellor
kin > Reviewed-by: Kees Cook Reviewed-by: Nathan Chancellor > --- > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index d68df1febd25..d3e64cc0932b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mi

Re: [PATCH v4 mips-next 6/7] vmlinux.lds.h: catch compound literals into data and BSS

2021-01-08 Thread Nathan Chancellor
e this by adding the related sections to generic definitions > as suggested by Sami [0]. > > [0] > https://lore.kernel.org/lkml/20201211184633.3213045-3-samitolva...@google.com > > Suggested-by: Kees Cook > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chance

Re: [PATCH v4 mips-next 5/7] MIPS: vmlinux.lds.S: explicitly declare .got table

2021-01-08 Thread Nathan Chancellor
me way as .rel.dyn (like it's done for x86). > Use the ARM/ARM64 path here and place it at the end of .text section. > > Reported-by: Nathan Chancellor > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chancellor > --- > arch/mips/kernel/vmlinux.lds.S | 1 + > 1 file

Re: [PATCH v4 mips-next 4/7] MIPS: vmlinux.lds.S: catch bad .rel.dyn at link time

2021-01-08 Thread Nathan Chancellor
init/main.o' being placed in section `.rel.dyn' > > Adopted from x86/kernel/vmlinux.lds.S. > > Suggested-by: Fangrui Song > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chancellor > --- > arch/mips/kernel/vmlinux.lds.S | 11 +++ > 1 file changed, 11

Re: [PATCH v4 mips-next 3/7] MIPS: properly stop .eh_frame generation

2021-01-08 Thread Nathan Chancellor
("MIPS: Add DWARF unwinding to assembly") > Suggested-by: Kees Cook > Signed-off-by: Alexander Lobakin Reviewed-by: Nathan Chancellor > --- > arch/mips/include/asm/asm.h| 18 ++ > arch/mips/kernel/vmlinux.lds.S | 1 - > 2 files changed, 18 insertions(+)

Re: [PATCH v4 mips-next 2/7] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-08 Thread Nathan Chancellor
orphan section `.gnu.attributes' > from `arch/mips/kernel/head.o' being placed in section > `.gnu.attributes' > mips-alpine-linux-musl-ld: warning: orphan section `.gnu.attributes' > from `init/main.o' being placed in section `.gnu.attributes' > > Signed-off-by: Alexander Lobakin

Re: [PATCH v4 mips-next 1/7] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section

2021-01-08 Thread Nathan Chancellor
5a4000 D __nosave_begin > 805a4000 D __nosave_end > 805a4000 d mips_vdso_data > 805a8000 d vdso_data > 805ac000 D mmlist_lock > 805ac080 D tasklist_lock > > Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") >

Re: [PATCH v3] kasan: remove redundant config option

2021-01-07 Thread Nathan Chancellor
c: Andrey Ryabinin > Cc: Dmitry Vyukov > Cc: Andrey Konovalov > Cc: Alexander Potapenko > Cc: Andrew Morton > Cc: Nathan Chancellor Reviewed-by: Nathan Chancellor > --- > > v2: make commit log to be more readable. > v3: remain CONFIG_KASAN_STACK_ENABLE setting

Re: [PATCH] x86: efi: avoid BUILD_BUG_ON() for non-constant p4d_index

2021-01-07 Thread Nathan Chancellor
tps://github.com/ClangBuiltLinux/linux/issues/256 > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > arch/x86/platform/efi/efi_64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/platform

Re: [PATCH] kasan: remove redundant config option

2021-01-07 Thread Nathan Chancellor
On Thu, Jan 07, 2021 at 02:21:52PM +0800, Walter Wu wrote: > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN > stack instrumentation, but we should only need one config option, > so that we remove CONFIG_KASAN_STACK_ENABLE. see [1]. > > For gcc we could do no prompt and default

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-07 Thread Nathan Chancellor
On Thu, Jan 07, 2021 at 09:22:00AM -0800, Kees Cook wrote: > On Thu, Jan 07, 2021 at 05:09:59PM +0100, Arnd Bergmann wrote: > > On Wed, Jan 6, 2021 at 11:12 PM Arnd Bergmann wrote: > > > > > > On Wed, Jan 6, 2021 at 10:57 PM Kees Cook wrote: > > > > On Wed, Dec 30, 2020 at 04:47:35PM +0100, Arnd

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-06 Thread Nathan Chancellor
On Wed, Jan 06, 2021 at 11:06:39PM +0100, Arnd Bergmann wrote: > On Wed, Jan 6, 2021 at 10:38 PM Nathan Chancellor > wrote: > > On Wed, Jan 06, 2021 at 10:12:51AM +0100, Arnd Bergmann wrote: > > > On Tue, Jan 5, 2021 at 10:25 AM Arnd Bergmann wrote: > > > > >

Re: [PATCH] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-06 Thread Nathan Chancellor
ernal-data to avoid "canonical PLT entry"/copy > relocations https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98112 > > Link: https://github.com/ClangBuiltLinux/linux/issues/1210 > Reported-by: Arnd Bergmann > Signed-off-by: Fangrui Song I agree with Nick's comments about the commi

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-06 Thread Nathan Chancellor
On Wed, Jan 06, 2021 at 10:12:51AM +0100, Arnd Bergmann wrote: > On Tue, Jan 5, 2021 at 10:25 AM Arnd Bergmann wrote: > > > > On Mon, Jan 4, 2021 at 11:33 PM Nathan Chancellor > > wrote: > > > On Wed, Dec 30, 2020 at 05:13:03PM +0100, Marco Elver wrote: > > &g

Re: [PATCH v2 mips-next 3/4] MIPS: vmlinux.lds.S: catch bad .got, .plt and .rel.dyn at link time

2021-01-06 Thread Nathan Chancellor
-alpine-linux-musl-ld: warning: orphan section `.rel.dyn' > from `init/main.o' being placed in section `.rel.dyn' > > ld.lld: warning: :(.got) is being placed in '.got' > > Adopted from x86/kernel/vmlinux.lds.S. > > Reported-by: Nathan Chancellor # .got > Suggested-by: Fangru

Re: [PATCH] cifs: check pointer before freeing

2021-01-05 Thread Nathan Chancellor
to the one done > in dfs_cache_update_vol(). > > Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines") > Signed-off-by: Tom Rix Reviewed-by: Nathan Chancellor > --- > fs/cifs/dfs_cache.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/c

[PATCH] MIPS: c-r4k: Fix section mismatch for loongson2_sc_init

2021-01-05 Thread Nathan Chancellor
: fix Section mismatch in reference") but it was missed. Remove the improper __init annotation like that commit did. Fixes: 078a55fc824c ("MIPS: Delete __cpuinit/__CPUINIT usage from MIPS code") Link: https://github.com/ClangBuiltLinux/linux/issues/787 Signed-off-by: Nathan Chancellor

[PATCH] MIPS: Use address-of operator on section symbols

2021-01-05 Thread Nathan Chancellor
this type of comparison. Link: https://github.com/ClangBuiltLinux/linux/issues/1232 Signed-off-by: Nathan Chancellor --- arch/mips/bmips/setup.c | 2 +- arch/mips/lantiq/prom.c | 2 +- arch/mips/pic32/pic32mzda/init.c | 2 +- arch/mips/ralink/of.c| 2 +- 4 files changed

[PATCH] MIPS: lantiq: Explicitly compare LTQ_EBU_PCC_ISTAT against 0

2021-01-05 Thread Nathan Chancellor
pare the constant LTQ_EBU_PCC_ISTAT against 0 to fix the warning. Additionally, remove the unnecessary parentheses as this is a simple conditional statement and shorthand '== 0' to '!'. Fixes: 3645da0276ae ("OF: MIPS: lantiq: implement irq_domain support") Link: https://github.com/ClangBuil

Re: [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-04 Thread Nathan Chancellor
On Mon, Jan 04, 2021 at 12:18:10PM +, Alexander Lobakin wrote: > This series hunts the problems discovered after manual enabling of > ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() > section affecting VDSO placement (marked for stable). > > Compile and runtime tested on

[PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
ctions like in the main linker script so there is no more build failure. Cc: sta...@vger.kernel.org Fixes: 83a092cf95f2 ("powerpc: Link warning for orphan sections") Link: https://github.com/ClangBuiltLinux/linux/issues/1218 Signed-off-by: Nathan Chancellor --- arch/powerpc/kernel/vmlin

[PATCH v2] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
ctions like in the main linker script so there is no more build failure. [1]: https://reviews.llvm.org/D79600 [2]: https://reviews.llvm.org/D92493 Cc: sta...@vger.kernel.org Fixes: 83a092cf95f2 ("powerpc: Link warning for orphan sections") Link: https://github.com/ClangBuiltLinux/linux/iss

Re: [PATCH] percpu: fix clang modpost warning in pcpu_build_alloc_info()

2021-01-04 Thread Nathan Chancellor
On Thu, Dec 31, 2020 at 09:28:52PM +, Dennis Zhou wrote: > This is an unusual situation so I thought it best to explain it in a > separate patch. > > "percpu: reduce the number of cpu distance comparisons" introduces a > dependency on cpumask helper functions in __init code. This code >

Re: [PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
On Mon, Jan 04, 2021 at 09:55:20PM +0100, Sedat Dilek wrote: > On Mon, Jan 4, 2021 at 9:49 PM Nathan Chancellor > wrote: > > > > Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input > > sections") added ".text.unlikely.*" and ".text.ho

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-04 Thread Nathan Chancellor
t;>> dma/qcom/gpi.o:(gpi_update_reg) in archive >>> drivers/built-in.a >>> referenced by gpi.c >>> dma/qcom/gpi.o:(gpi_update_reg) in archive >>> drivers/built-in.a [1]: https://lore.kernel.org/lkml/202012301

Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

2021-01-04 Thread Nathan Chancellor
On Wed, Dec 30, 2020 at 04:40:40PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang cannt evaluate this function argument at compile time > when the function is not inlined, which leads to a link > time failure: > > ld.lld: error: undefined symbol: __compiletime_assert_414 > >>>

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-04 Thread Nathan Chancellor
On Mon, Jan 04, 2021 at 03:33:33PM -0800, Andrew Morton wrote: > On Mon, 4 Jan 2021 15:33:36 -0700 Nathan Chancellor > wrote: > > > > > +++ b/lib/Kconfig.ubsan > > > > @@ -122,6 +122,8 @@ config UBSAN_SIGNED_OVERFLOW > > > > > > > > con

Re: [PATCH] jffs2: fix use after free in jffs2_sum_write_data()

2021-01-04 Thread Nathan Chancellor
abling summary collection. > > Fixes: 6171586a7ae5 ("[JFFS2] Correct handling of JFFS2_FEATURE_RWCOMPAT_COPY > nodes.") > Signed-off-by: Tom Rix Reviewed-by: Nathan Chancellor > --- > fs/jffs2/summary.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --g

Re: [PATCH v3 2/2] Kbuild: implement support for DWARF v5

2021-01-04 Thread Nathan Chancellor
between GNU readelf and llvm-readelf/llvm-dwarfdump to > validate the DWARF Version in the assembler feature detection script. > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > Suggested-by: Arvind Sankar > Suggested-by: Jakub Jelinek > Suggested-by: Masahiro Yamada >

Re: [PATCH v3 1/2] Kbuild: make DWARF version a choice

2021-01-04 Thread Nathan Chancellor
g configs, and makes adding > future versions more straightforward. > > Suggested-by: Fangrui Song > Suggested-by: Masahiro Yamada > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > Makefile | 14 -- > lib/Kconfig.debug | 21 +++

Re: drivers/net/wireless/intel/iwlwifi/queue/tx.c:310:18: warning: result of comparison of constant 262140 with expression of type 'u16' (aka 'unsigned short') is always false

2021-01-04 Thread Nathan Chancellor
On Sun, Jan 03, 2021 at 09:51:17AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3516bd729358a2a9b090c1905bd2a3fa926e24c6 > commit: 0cd1ad2d7fd41e0de4969fd1dd0aa846c99830d1 iwlwifi: move all > bus-independent TX

Re: [PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning

2020-12-31 Thread Nathan Chancellor
et; > > The driver returns -EINVAL for other broken DT properties, so do > it the same way here. > > Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > sound/soc/fsl/imx-hdmi.

Re: [PATCH] i3c/master/mipi-i3c-hci: re-fix __maybe_unused attribute

2020-12-30 Thread Nathan Chancellor
> Isn't it already upstream? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95393f3e07ab53855b91881692a4a5b52dcdc03c This patch is fixing that one, the attribute was added between the struct type, causing a new warning for clang. I sent a fix for this earlier too, I do not care which one goes in as long as one does so: Reviewed-by: Nathan Chancellor Cheers, Nathan

Re: [PATCH] KVM: arm64: Fix section mismatches around hyp_cpu_pm_{init,exit}

2020-12-29 Thread Nathan Chancellor
On Tue, Dec 29, 2020 at 10:11:07PM +, Marc Zyngier wrote: > On 2020-12-29 21:43, Nathan Chancellor wrote: > > Commit fa8c3d65538a ("KVM: arm64: Keep nVHE EL2 vector installed") > > inadvertently changed clang's inlining decisions around > > hyp_cpu_pm_{init,exit}

[PATCH] KVM: arm64: Fix section mismatches around hyp_cpu_pm_{init,exit}

2020-12-29 Thread Nathan Chancellor
Linux/linux/issues/1230 Signed-off-by: Nathan Chancellor --- arch/arm64/kvm/arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 6e637d2b4cfb..71a49eae9ea0 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -157

[PATCH] mt76: Fix queue ID variable types after mcu queue split

2020-12-29 Thread Nathan Chancellor
the txq variable in mt7915_mcu_send_message to be more neutral like mt7615_mcu_send_message. Fixes: e637763b606b ("mt76: move mcu queues to mt76_dev q_mcu array") Link: https://github.com/ClangBuiltLinux/linux/issues/1229 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/mediatek/m

[PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

2020-12-29 Thread Nathan Chancellor
but only one is used within its scope. Remove the unused one so there is no more warning. Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()") Signed-off-by: Nathan Chancellor --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

Re: [PATCH 5.10 212/717] platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x platform configuration

2020-12-29 Thread Nathan Chancellor
On Mon, Dec 28, 2020 at 01:43:30PM +0100, Greg Kroah-Hartman wrote: > From: Vadim Pasternak > > [ Upstream commit 912b341585e302ee44fc5a2733f7bcf505e2c86f ] > > Remove PSU EEPROM configuration for systems class equipped with > Mellanox chip Spectrum and ATOM CPU - system types MSN274x. Till now

Re: [PATCH v2] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-26 Thread Nathan Chancellor
g to assemble with GNU Assembler >   instead of its built-in LLVM assembler. This flag is set by default >   unless `LLVM_IAS=1' is set, because the LLVM assembler can't yet >   parse certain GNU extensions. > > Signed-off-by: John Millikin Reviewed-by: Nathan Chancellor > ---

Re: [PATCH] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-25 Thread Nathan Chancellor
On Fri, Dec 25, 2020 at 11:35:28PM -0800, h...@zytor.com wrote: > On December 25, 2020 11:29:30 PM PST, John Millikin > wrote: > >When compiling with Clang, the `$(CLANG_FLAGS)' variable contains > >additional flags needed to cross-compile C and Assembly sources: I am not sure how or if others

[PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace

2020-12-25 Thread Nathan Chancellor
: extraneous closing brace ('}') } ^ 3 errors generated. The cleanup in ab8500_interrupts_show left a curly brace around, remove it to fix the error. Fixes: 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc") Signed-off-by: Nathan Chancellor --- drivers/mfd/ab8500-deb

Re: [PATCH 3/3] ibmvfc: use correlation token to tag commands

2020-12-21 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 12:50:31PM -0600, Tyrel Datwyler wrote: > The vfcFrame correlation field is 64bit handle that is intended to trace > I/O operations through both the client stack and VIOS stack when the > underlying physical FC adapter supports tagging. > > Tag vfcFrames with the

[PATCH] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match

2020-12-21 Thread Nathan Chancellor
github.com/ClangBuiltLinux/linux/issues/1221 Signed-off-by: Nathan Chancellor --- drivers/i3c/master/mipi-i3c-hci/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index 500abd27fb22..1b73647cc

Re: [PATCH] cpufreq: intel_pstate: remove obsolete functions

2020-12-21 Thread Nathan Chancellor
unction > 'percent_ext_fp' [-Wunused-function] > static inline int32_t percent_ext_fp(int percent) > ^ > > Remove those obsolete functions. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and ne

Re: [PATCH] MAINTAINERS: Update email address for Sean Christopherson

2020-12-18 Thread Nathan Chancellor
On Thu, Nov 19, 2020 at 10:37:07AM -0800, Sean Christopherson wrote: > From: Sean Christopherson > > Update my email address to one provided by my new benefactor. > > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: Jarkko Sakkinen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Vitaly

[PATCH] KVM: SVM: Add register operand to vmsave call in sev_es_vcpu_load

2020-12-18 Thread Nathan Chancellor
vmenter.S. Fixes: 861377730aa9 ("KVM: SVM: Provide support for SEV-ES vCPU loading") Link: https://reviews.llvm.org/D93524 Link: https://github.com/ClangBuiltLinux/linux/issues/1216 Signed-off-by: Nathan Chancellor --- arch/x86/kvm/svm/sev.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v2] arm64: link with -z norelro for LLD or aarch64-elf

2020-12-17 Thread Nathan Chancellor
Reported-by: kernelci.org bot > Reported-by: Quentin Perret > Acked-by: Ard Biesheuvel > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > Changes V1 -> V2: > * s/relocation types/program headers/ > * s/newer GNU binutils/GNU binutils 2.35+/ >

Re: [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp'

2020-12-11 Thread Nathan Chancellor
On Fri, Dec 11, 2020 at 07:54:07PM +, Maciej W. Rozycki wrote: > On Fri, 11 Dec 2020, Anders Roxell wrote: > > > diff --git a/arch/mips/lib/uncached.c b/arch/mips/lib/uncached.c > > index 09d5deea747f..f80a67c092b6 100644 > > --- a/arch/mips/lib/uncached.c > > +++ b/arch/mips/lib/uncached.c >

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-07 Thread Nathan Chancellor
On Sun, Dec 06, 2020 at 12:09:31PM -0800, Sami Tolvanen wrote: > Sure, looks good to me. However, I think we should also test for > LLVM=1 to avoid possible further issues with mismatched toolchains > instead of only checking for llvm-nm and llvm-ar. It might still be worth testing for $(AR) and

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-05 Thread Nathan Chancellor
On Fri, Dec 04, 2020 at 02:52:41PM -0800, Sami Tolvanen wrote: > On Thu, Dec 3, 2020 at 2:32 PM Nick Desaulniers > wrote: > > > > So I'd recommend to Sami to simply make the Kconfig also depend on > > clang's integrated assembler (not just llvm-nm and llvm-ar). > > Sure, sounds good to me.

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-03 Thread Nathan Chancellor
On Thu, Dec 03, 2020 at 09:07:30AM -0800, Sami Tolvanen wrote: > On Thu, Dec 3, 2020 at 3:26 AM Will Deacon wrote: > > > > Hi Sami, > > > > On Tue, Dec 01, 2020 at 01:36:51PM -0800, Sami Tolvanen wrote: > > > This patch series adds support for building the kernel with Clang's > > > Link Time

Re: [PATCH] x86, build: remove -m16 workaround for unsupported versions of GCC

2020-11-30 Thread Nathan Chancellor
code16gcc.h from a C header to > an assembly header") > > Since commit 0bddd227f3dc ("Documentation: update for gcc 4.9 > requirement") the minimum supported version of GCC is gcc-4.9. It's now > safe to remove this code. > > Signed-off-by: Nick Desaulniers Reviewed-

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-11-29 Thread Nathan Chancellor
a big churn. If arch > maintainers want to clean them up, please go ahead. > > While I was here, I also moved __must_check to compiler_attributes.h > from compiler_types.h > > Signed-off-by: Masahiro Yamada > Acked-by: Jason A. Donenfeld Acked-by: Nathan Chancellor

Re: [stable 4.9] PANIC: double fault, error_code: 0x0 - clang boot failed on x86_64

2020-11-28 Thread Nathan Chancellor
On Thu, Nov 26, 2020 at 07:39:33AM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 26, 2020 at 10:14:43AM +0530, Naresh Kamboju wrote: > > Linaro recently started building and testing with stable branches with > > clang. > > Stable 4.9 branch kernel built with clang 10 boot crashed on x86 and > >

Re: [RESEND,PATCH] ARM: fix __div64_32() error when compiling with clang

2020-11-23 Thread Nathan Chancellor
On Mon, Nov 23, 2020 at 03:36:32PM +0800, Antony Yu wrote: > __do_div64 clobbers the input register r0 in little endian system. > According to the inline assembly document, if an input operand is > modified, it should be tied to a output operand. This patch can > prevent compilers from reusing r0

Re: [PATCH v7 00/17] Add support for Clang LTO

2020-11-20 Thread Nathan Chancellor
_LTO_CLANG=y # CONFIG_HID_WALTOP is not set and I have taken that same kernel and booted it under QEMU with '-enable-kvm' without any visible issues. I have tested four combinations: clang 12 @ f9f0a4046e11c2b4c130640f343e3b2b5db08c1: * CONFIG_THINLTO=y * CONFIG_THINLTO=n clang 11.0.0 * CONFIG_THINLTO=y * CONFIG_THINLTO=n Tested-by: Nathan Chancellor Cheers, Nathan

Re: [PATCH v7 02/17] kbuild: add support for Clang LTO

2020-11-20 Thread Nathan Chancellor
On Fri, Nov 20, 2020 at 11:47:21AM -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 08:23:11AM -0800, Sami Tolvanen wrote: > > Changing the ThinLTO config to a choice and moving it after the main > > LTO config sounds like a good idea to me. I'll see if I can change > > this in v8. Thanks! > >

[PATCH v2 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1

2020-11-19 Thread Nathan Chancellor
/linux/issues/1187 Link: https://github.com/ClangBuiltLinux/linux/issues/1193 Reported-by: Arvind Sankar Reported-by: kernelci.org bot Reported-by: Mark Brown Reviewed-by: Kees Cook Signed-off-by: Nathan Chancellor --- v1 -> v2: * Add condition as a depends on line (Kees Cook) * Capture out

[PATCH v2 1/2] kbuild: Hoist '--orphan-handling' into Kconfig

2020-11-19 Thread Nathan Chancellor
Signed-off-by: Nathan Chancellor --- v1 -> v2: * Change ifeq ($(CONFIG_LD_ORPHAN_WARN),y) to ifdef CONFIG_LD_ORPHAN_WARN to improve readability (Michael Ellerman) * Separate conditions for CONFIG_LD_ORPHAN warn to improve readability (Kees Cook) * Pick up tags from Kees, Mich

[PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in tegra_emc_probe

2020-11-19 Thread Nathan Chancellor
. Fixes: 5e00fd90183a ("memory: tegra30-emc: Continue probing if timings are missing in device-tree") Link: https://github.com/ClangBuiltLinux/linux/issues/1203 Signed-off-by: Nathan Chancellor --- drivers/memory/tegra/tegra30-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH] kbuild: Always link with '-z norelro'

2020-11-19 Thread Nathan Chancellor
On Wed, Nov 18, 2020 at 03:24:04PM -0800, Nick Desaulniers wrote: > On Wed, Nov 18, 2020 at 3:07 PM Ard Biesheuvel wrote: > > > > On Thu, 19 Nov 2020 at 00:05, Nick Desaulniers > > wrote: > > > > > > > > > > > To avoid playing whack-a-mole with different architectures over > > > > > > > >

Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1

2020-11-17 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 01:51:43PM -0800, Kees Cook wrote: > On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > > config LD_ORPHAN_WARN > > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > > + def_bool ARCH_WANT_LD_OR

Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1

2020-11-17 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 11:41:15AM -0800, Nick Desaulniers wrote: > On Fri, Nov 13, 2020 at 11:56 AM Nathan Chancellor > wrote: > > > > ld.lld 10.0.1 spews a bunch of various warnings about .rela sections, > > along with a few others. Newer versions of ld.lld do not

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-17 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 10:46:29AM -0800, Nick Desaulniers wrote: > On Mon, Nov 16, 2020 at 7:04 PM John Hubbard wrote: > > > > Hi, > > > > I just ran into this and it's a real pain to figure out, because even > > with the very latest Fedora 33 on my test machine, which provides clang > > version

Re: [PATCH 1/2] kbuild: Hoist '--orphan-handling' into Kconfig

2020-11-17 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 10:03:29PM +1100, Michael Ellerman wrote: > Nathan Chancellor writes: > > Currently, '--orphan-handling=warn' is spread out across four different > > architectures in their respective Makefiles, which makes it a little > > unruly to deal

Re: [PATCH] ring-buffer: remove obsolete rb_event_is_commit()

2020-11-17 Thread Nathan Chancellor
e then, make CC=clang W=1 warns: > > kernel/trace/ring_buffer.c:2763:1: > warning: unused function 'rb_event_is_commit' [-Wunused-function] > > Remove this obsolete function. > > Signed-off-by: Lukas Bulwahn > --- Reviewed-by: Nathan Chancellor

Re: [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-16 Thread Nathan Chancellor
or lib/. > > Link: https://github.com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > lib/asn1_decoder.c | 4 ++-- > lib/assoc_array.c | 2 +- > lib/bootconfig.c

Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough

2020-11-16 Thread Nathan Chancellor
se cases. > > Link: https://github.com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > arch/powerpc/kernel/prom_init.c | 1 + > arch/powerpc/kernel/uprobes.c | 1 + > arch/powerpc/per

Re: [PATCH 1/3] powerpc: boot: include compiler_attributes.h

2020-11-16 Thread Nathan Chancellor
com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > We could just `#include "include/linux/compiler_types.h"` in the few .c > sources used from lib/ (there are proper header guards in > comp

Re: [PATCH] mm: memcg: remove obsolete memcg_has_children()

2020-11-16 Thread Nathan Chancellor
e then, make CC=clang W=1 warns: > > mm/memcontrol.c:3421:20: > warning: unused function 'memcg_has_children' [-Wunused-function] > > Simply remove this obsolete unused function. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor

Re: [PATCH] scsi: sd: remove obsolete variable in sd_remove()

2020-11-16 Thread Nathan Chancellor
gt; Hence, make W=1 warns: > > drivers/scsi/sd.c:3516:8: > warning: variable 'devt' set but not used [-Wunused-but-set-variable] > > Simply remove this obsolete variable. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor

Re: [PATCH 1/2] kbuild: Hoist '--orphan-handling' into Kconfig

2020-11-16 Thread Nathan Chancellor
On Mon, Nov 16, 2020 at 05:41:58PM -0800, Nick Desaulniers wrote: > On Fri, Nov 13, 2020 at 11:56 AM Nathan Chancellor > wrote: > > > > Currently, '--orphan-handling=warn' is spread out across four different > > architectures in their respective Makefiles, which make

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-15 Thread Nathan Chancellor
On Mon, Nov 16, 2020 at 12:25:13AM +, Al Viro wrote: > On Sun, Nov 15, 2020 at 04:51:49PM -0700, Nathan Chancellor wrote: > > Looks good to me on top of d4d50710a8b46082224376ef119a4dbb75b25c56, > > thanks for quickly looking into this! > > > > Tested-by:

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-15 Thread Nathan Chancellor
On Sun, Nov 15, 2020 at 11:38:14PM +, Al Viro wrote: > On Sun, Nov 15, 2020 at 02:41:25PM -0700, Nathan Chancellor wrote: > > Hi Al, > > > > Apologies for the delay. > > > > On Sun, Nov 15, 2020 at 03:53:55PM +, Al Viro wrote: > > > On Sat, Nov 1

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-13 Thread Nathan Chancellor
On Sat, Nov 14, 2020 at 03:54:53AM +, Al Viro wrote: > On Fri, Nov 13, 2020 at 08:01:24PM -0700, Nathan Chancellor wrote: > > Sure thing, it does trigger. > > > > [0.235058] [ cut here ] > > [0.235062] WARNING: CPU: 15 PI

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-13 Thread Nathan Chancellor
On Sat, Nov 14, 2020 at 01:17:54AM +, Al Viro wrote: > On Fri, Nov 13, 2020 at 04:54:53PM -0700, Nathan Chancellor wrote: > > > This patch in -next (6a9f696d1627bacc91d1cebcfb177f474484e8ba) breaks > > WSL2's interoperability feature, where Windows paths automatically get

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-13 Thread Nathan Chancellor
Hi Al, On Wed, Nov 11, 2020 at 10:21:16PM +, Al Viro wrote: > On Wed, Nov 11, 2020 at 09:52:20PM +, Al Viro wrote: > > > That can be done, but I would rather go with > > n = copy_to_iter(m->buf + m->from, m->count, iter); > > m->count -= n; > > m->from

Re: Error: invalid switch -me200

2020-11-13 Thread Nathan Chancellor
On Fri, Nov 13, 2020 at 11:42:03AM -0800, Nick Desaulniers wrote: > + MPE, PPC > > On Fri, Nov 13, 2020 at 11:08 AM Nathan Chancellor > wrote: > > > > On Fri, Nov 13, 2020 at 09:28:03AM -0800, Fāng-ruì Sòng wrote: > > > On Thu, Nov 12, 2020 at 7:22 PM kernel test

<    1   2   3   4   5   6   7   8   9   10   >