[PATCH 1/2] kbuild: Hoist '--orphan-handling' into Kconfig

2020-11-13 Thread Nathan Chancellor
all of the sections are specified and size asserted. A special thanks to Kees Cook for the help text on this config. Link: https://github.com/ClangBuiltLinux/linux/issues/1187 Signed-off-by: Nathan Chancellor --- Makefile | 6 ++ arch/Kconfig | 9

[PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1

2020-11-13 Thread Nathan Chancellor
-by: kernelci.org bot Reported-by: Mark Brown Link: https://github.com/ClangBuiltLinux/linux/issues/1187 Link: https://github.com/ClangBuiltLinux/linux/issues/1193 Signed-off-by: Nathan Chancellor --- MAINTAINERS| 1 + init/Kconfig | 6 +- scripts/lld-version.sh | 20

Re: Error: invalid switch -me200

2020-11-13 Thread Nathan Chancellor
On Fri, Nov 13, 2020 at 09:28:03AM -0800, Fāng-ruì Sòng wrote: > On Thu, Nov 12, 2020 at 7:22 PM kernel test robot wrote: > > > > Hi Fangrui, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head:

Re: [PATCH] futex: remove unused empty compat_exit_robust_list()

2020-11-13 Thread Nathan Chancellor
; There is no need to declare the unused empty function for !CONFIG_COMPAT. > Simply, remove it to address the -Wunused-function warning. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and next-20201113 > > Thomas, ple

Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()

2020-11-13 Thread Nathan Chancellor
> net/ipv6/exthdrs.c:909:33: > warning: unused function 'ipv6_skb_idev' [-Wunused-function] > > So, remove this unused function and a -Wunused-function warning. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor > --- > Alexey, Hideaki-san, please ack.

Re: [PATCH] dmaengine: ioatdma: remove unused function missed during dma_v2 removal

2020-11-13 Thread Nathan Chancellor
rns: > > drivers/dma/ioat/dca.c:44:19: > warning: unused function 'dca2_tag_map_valid' [-Wunused-function] > > So, remove this unused function and get rid of a -Wused-function warning. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor > --- > appli

[PATCH] spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe

2020-11-13 Thread Nathan Chancellor
ing generated. Restore the assignment so that the error value can be used in the dev_err statement and there is no uninitialized memory being leaked. Fixes: e13ee6cc4781 ("spi: bcm2835aux: Fix use-after-free on unbind") Link: https://github.com/ClangBuiltLinux/linux/issues/1199 Signed-of

Re: [PATCH] kbuild: Always link with '-z norelro'

2020-11-12 Thread Nathan Chancellor
On Thu, Nov 12, 2020 at 04:44:46PM -0800, Nick Desaulniers wrote: > On Thu, Nov 12, 2020 at 10:41 AM Nathan Chancellor > wrote: > > > > Commit 3bbd3db86470 ("arm64: relocatable: fix inconsistencies in linker > > script and options") added '-z n

Re: [PATCH v2 2/2] arm: lib: xor-neon: move pragma options to makefile

2020-11-12 Thread Nathan Chancellor
-by: Ard Biesheuvel > Signed-off-by: Adrian Ratiu Reviewed-by: Nathan Chancellor > --- > arch/arm/lib/Makefile | 2 +- > arch/arm/lib/xor-neon.c | 10 -- > 2 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/arch/arm/lib/Makefile b/arch/arm/

Re: [PATCH] crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd

2020-11-12 Thread Nathan Chancellor
On Thu, Nov 12, 2020 at 10:21:35PM +0100, Christian Lamparter wrote: > Hello, > > On 12/11/2020 21:07, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/crypto/amcc/crypto4xx_core.c:921:60: warning: operator '?:' has > > lower precedence than

Re: [PATCH] USB: storage: avoid use of uninitialized values in error path

2020-11-12 Thread Nathan Chancellor
; to 0 in those paths. That makes clang-analyzer happy. > > Proposal was discussed in this mail thread: > > Link: > https://lore.kernel.org/linux-usb/alpine.DEB.2.21.202146110.13119@felia/ > > Signed-off-by: Lukas Bulwahn Assuming that setting it to zero is okay (soun

[PATCH] crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd

2020-11-12 Thread Nathan Chancellor
erator so that everything works properly. Fixes: 4b5b79998af6 ("crypto: crypto4xx - fix stalls under heavy load") Link: https://github.com/ClangBuiltLinux/linux/issues/1198 Signed-off-by: Nathan Chancellor --- drivers/crypto/amcc/crypto4xx_core.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH] kbuild: Always link with '-z norelro'

2020-11-12 Thread Nathan Chancellor
aulniers Signed-off-by: Nathan Chancellor --- Hi all, This should probably go into Russell's tree with acks from the arm64 and kbuild maintainers. Cheers, Nathan Makefile| 2 ++ arch/arm64/Makefile | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefil

Re: [PATCH] reboot: Fix variable assignments in type_store

2020-11-12 Thread Nathan Chancellor
On Thu, Nov 12, 2020 at 06:59:36PM +0100, Matteo Croce wrote: > On Thu, Nov 12, 2020 at 6:49 PM Nathan Chancellor > wrote: > > > > Hi Matteo, > > > > On Thu, Nov 12, 2020 at 12:26:45PM +0100, Matteo Croce wrote: > > > On Thu, Nov 12, 2020 at

Re: [PATCH] Revert "dm cache: fix arm link errors with inline"

2020-11-12 Thread Nathan Chancellor
GCC is gcc-4.9. It's now safe to remove > this code. > > Link: https://github.com/ClangBuiltLinux/linux/issues/427 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > drivers/md/dm-cache-target.c | 4 > 1 file changed, 4 deletions(-) > > di

Re: [PATCH] ARM: unwind: remove old check for GCC <= 4.2

2020-11-12 Thread Nathan Chancellor
gt; Link: https://github.com/ClangBuiltLinux/linux/issues/427 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > arch/arm/kernel/unwind.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c > index f

Re: [PATCH] usb: fix a few cases of -Wfallthrough

2020-11-12 Thread Nathan Chancellor
aks for those cases. > > Signed-off-by: Nick Desaulniers Aside from a minor nit/question below: Reviewed-by: Nathan Chancellor > --- > drivers/usb/core/config.c| 1 + > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/ohci-hcd.c | 2 +- > drivers/usb/host/ohci-hub.c |

Re: [PATCH] reboot: Fix variable assignments in type_store

2020-11-12 Thread Nathan Chancellor
Hi Matteo, On Thu, Nov 12, 2020 at 12:26:45PM +0100, Matteo Croce wrote: > On Thu, Nov 12, 2020 at 4:50 AM Nathan Chancellor > wrote: > > > > Clang warns: > > > > kernel/reboot.c:707:17: warning: implicit conversion from enumeration > > type 'enum reboot_type'

[PATCH] reboot: Fix variable assignments in type_store

2020-11-11 Thread Nathan Chancellor
should be to reboot_type, not reboot_mode. Fix it so there are no more warnings and the code works properly. Fixes: eab8da48579d ("reboot: allow to specify reboot mode via sysfs") Link: https://github.com/ClangBuiltLinux/linux/issues/1197 Signed-off-by: Nathan Chancellor --- kernel/reb

Re: [PATCH] ARM: Kconfig: CPU_BIG_ENDIAN depends on !LD_IS_LLD

2020-11-09 Thread Nathan Chancellor
Desaulniers I tested allyesconfig, allmodconfig, and about ten to fifteen randconfigs and never saw CONFIG_CPU_BIG_ENDIAN appear. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > arch/arm/mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arc

Re: [PATCH -next v2] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume

2020-11-09 Thread Nathan Chancellor
en Boyd > Cc: linux-...@vger.kernel.org > Cc: Taniya Das > Cc: linux-n...@vger.kernel.org > Cc: Nathan Chancellor > Cc: Andrew Morton Build-tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor > --- > v2: move the function stubs to be inside the #else (for !CONFIG_PM

Re: [PATCH] sysctl: move local variable in proc_do_large_bitmap() to proper scope

2020-11-09 Thread Nathan Chancellor
> > So, simply remove this dead assignment and put the variable in local scope. > > As compilers will detect this unneeded assignment and optimize this anyway, > the resulting object code is identical before and after this change. > > No functional change. No change to obje

[PATCH] ARM: boot: Quote aliased symbol names in string.c

2020-11-08 Thread Nathan Chancellor
d/string.o] Error 1 Quote the names like the treewide patch does so there is no more error. Reported-by: Naresh Kamboju Reported-by: Valdis Klētnieks Signed-off-by: Nathan Chancellor --- Hi Andrew, Stephen said I should send this along to you so that it can be applied as part of the post -next s

Re: next-20201105 - build issue with KASAN on ARM

2020-11-08 Thread Nathan Chancellor
Hi Stephen, On Mon, Nov 09, 2020 at 09:19:19AM +1100, Stephen Rothwell wrote: > Hi Nathan, > > On Sat, 7 Nov 2020 13:04:53 -0700 Nathan Chancellor > wrote: > > > > Because it builds fine if you check out Russell's branch. This build > > error only happens becau

[PATCH] riscv: Explicitly specify the build id style in vDSO Makefile again

2020-11-08 Thread Nathan Chancellor
yle stays consistent across the tree regardless of linker. Fixes: c2c81bb2f691 ("RISC-V: Fix the VDSO symbol generaton for binutils-2.35+") Signed-off-by: Nathan Chancellor --- arch/riscv/kernel/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/ker

[PATCH v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target

2020-11-08 Thread Nathan Chancellor
oards") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Nathan Chancellor --- v1 -> v2: * Simplify commit message and error (Krzysztof). * Pick up Krzysztof's tag. arch/arm64/boot/dts/freescale/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/

Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target

2020-11-08 Thread Nathan Chancellor
Hi Krzysztof, On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote: > On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor > wrote: > > Hi, > > Thanks for the fixes. > > Please mark patches with versions, this should be v2. Otherwise > maintainer might

[PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target

2020-11-07 Thread Nathan Chancellor
68d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Signed-off-by: Nathan Chancellor --- arch/arm64/boot/dts/freescale/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/free

Re: [PATCH] scsi: core: fix -Wformat

2020-11-07 Thread Nathan Chancellor
specifies type 'short' but the argument has type 'int' > [-Wformat] > shost_rd_attr(can_queue, "%hd\n"); > ^ > %d > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Nick D

Re: next-20201105 - build issue with KASAN on ARM

2020-11-07 Thread Nathan Chancellor
Hi Valdis, On Sat, Nov 07, 2020 at 01:33:20PM -0500, Valdis Klētnieks wrote: > commit d6d51a96c7d63b7450860a3037f2d62388286a52 > Author: Linus Walleij > Date: Sun Oct 25 23:52:08 2020 +0100 > > ARM: 9014/2: Replace string mem* functions for KASan > > I'm trying to figure out why this has

Re: [PATCH] hwmon: applesmc: avoid overlong udelay()

2020-11-06 Thread Nathan Chancellor
On Fri, Nov 06, 2020 at 06:17:10PM -0500, Matt Turner wrote: > On my late 2013 Macbook Pro, I have a couple of scripts that set the > fans to auto or full-speed: > > fan-hi: > #!/bin/sh > sudo sh -c 'echo 1 > /sys/devices/platform/applesmc.768/fan1_manual > echo 1 >

Re: [PATCH -next] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume

2020-11-06 Thread Nathan Chancellor
On Fri, Nov 06, 2020 at 11:17:13AM -0700, Nathan Chancellor wrote: > On Fri, Nov 06, 2020 at 10:05:44AM -0800, Randy Dunlap wrote: > > Add stubs for pm_clk_runtime_suspend() and pm_clk_runtime_resume() > > to fix build errors when CONFIG_PM and CONFIG_PM_CLK are not enabled.

Re: [PATCH -next] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume

2020-11-06 Thread Nathan Chancellor
> Cc: linux-...@vger.kernel.org > Cc: Taniya Das > Cc: linux-n...@vger.kernel.org This fixes the same build failure that I saw with s390 all{mod,yes}config. Build-tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor > --- > include/linux/pm_clock.h |9 +

Re: [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning

2020-11-06 Thread Nathan Chancellor
On Fri, Nov 06, 2020 at 03:46:36PM +0100, Arnd Bergmann wrote: > On Fri, Nov 6, 2020 at 6:14 AM Adrian Ratiu > wrote: > > > > From: Nathan Chancellor > > > > Drop warning because kernel now requires GCC >= v4.9 after > > commit 6ec4476ac825

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-06 Thread Nathan Chancellor
Hi Adrian, On Fri, Nov 06, 2020 at 01:50:13PM +0200, Adrian Ratiu wrote: > I tested Arnd's kernel patch from the LLVM bugtracker [1], but with the > Clang v10.0.1 I still get warnings like the following even though the > __restrict workaround seems to affect the generated instructions: > >

Re: [GIT PULL] SPI fixes for v5.10-rc2

2020-11-06 Thread Nathan Chancellor
On Fri, Nov 06, 2020 at 11:00:53AM +, Mark Brown wrote: > On Fri, Nov 06, 2020 at 03:18:15AM -0700, Nathan Chancellor wrote: > > On Thu, Nov 05, 2020 at 04:45:46PM +, Mark Brown wrote: > > > > Martin Hundebøll (1): > > > spi: bcm2835: fix gpio cs

Re: [GIT PULL] SPI fixes for v5.10-rc2

2020-11-06 Thread Nathan Chancellor
On Thu, Nov 05, 2020 at 04:45:46PM +, Mark Brown wrote: > The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: > > Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) > > are available in the Git repository at: > >

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-06 Thread Nathan Chancellor
options come to fruition from further discussions, you can carry my tag forward: Acked-by: Nathan Chancellor Hopefully others can comment soon. > --- > arch/arm/include/asm/xor.h | 3 ++- > arch/arm/lib/Makefile | 3 +++ > arch/arm/lib/xor-neon.c| 4 > 3 files chang

Re: [PATCH] clk: remove unneeded dead-store initialization

2020-11-06 Thread Nathan Chancellor
to object code. > > Signed-off-by: Lukas Bulwahn Indeed, parent is always assigned a new value before that one is read. Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and next-20201106 > > Stephen, Michael, please pick this minor non-urgent clean-u

Re: [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Nathan Chancellor
change to object code. > > Signed-off-by: Lukas Bulwahn Question below. Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and next-20201105 > > Balbir, please pick this minor non-urgent clean-up patch. > > kernel/taskstats.c | 1 - > 1

Re: [PATCH] printk: remove unneeded dead-store assignment

2020-11-05 Thread Nathan Chancellor
nd after this change. > > No functional change. No change to object code. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and next-20201105 > > John, please ack. > Petr, please pick this minor non-urgent clean-up

Re: [PATCH v2 2/4] Kbuild: do not emit debug info for assembly with LLVM_IAS=1

2020-11-04 Thread Nathan Chancellor
ld cleanly with > LLVM=1 LLVM_IAS=1 for x86_64 and arm64. > > Cc: > Link: https://github.com/ClangBuiltLinux/linux/issues/716 > Reported-by: Nathan Chancellor > Suggested-by: Dmitry Golovin If you happen to respin, Dmitry deserves a Reported-by tag too :) > Suggested-by: S

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Nathan Chancellor
r > clang sources. > > Cc: > Fixes: commit 1f7a44f63e6c ("compiler-clang: add build check for clang > 10.0.1") > Reported-by: Chen Yu > Reported-by: Jarkko Sakkinen > Signed-off-by: Nick Desaulniers Acked-by: Nathan Chancellor > --- > include/linux/compil

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-02 Thread Nathan Chancellor
> > We plan to remove workarounds for older versions now, which will break > > in subtle and not so subtle ways. > > > > Suggested-by: Sedat Dilek > > Suggested-by: Nathan Chancellor > > Suggested-by: Kees Cook > > Signed-off-by: Nick Desaulniers > > Tested

Hard lockup on Raspberry Pi 4 after v5.10-rc1

2020-11-01 Thread Nathan Chancellor
Hi everyone, Starting with v5.10-rc1, I appear to be experiencing hard lockups on my Raspberry Pi 4 when compiling LLVM. My standard workflow for testing the Raspberry Pi 4 has been compiling tip of tree LLVM (to catch host AArch64 issues), compiling linux-next ARCH=arm64 defconfig, then booting

Re: [PATCH] treewide: Remove stringification from __alias macro definition

2020-10-30 Thread Nathan Chancellor
ion > itself contains a quote character. So avoid these differences by always > using quotes to define the aliased symbol. > > Remove the stringification and add quotes and when necessary a stringification > when existing uses have a ## concatenation. > > Signed-off-by:

Re: [PATCH] agp: amd64: remove unneeded initialization

2020-10-28 Thread Nathan Chancellor
t; As compilers will detect this unneeded assignment and optimize this anyway, > the resulting binary is identical before and after this change. > > No functional change. No change in binary code. > > Signed-off-by: Lukas Bulwahn Seems obvious :) Reviewed-by: Nathan Chancellor > --- &g

Re: [PATCH] x86/unwind: remove unneeded initialization

2020-10-28 Thread Nathan Chancellor
> > Signed-off-by: Lukas Bulwahn Seems fine to me. Reviewed-by: Nathan Chancellor > --- > applies cleanly on current master and next-20201028 > > Josh, please ack. > Ingo, Borislav, please pick this minor non-urgent clean-up patch. > > arch/x86/kernel/unwind_orc.c |

Re: [PATCH v3] seq_file: fix clang warning for NULL pointer arithmetic

2020-10-28 Thread Nathan Chancellor
behavior while eliminating the warning and making it a little easier to understand. Reviewed-by: Nathan Chancellor > --- > v2: add the named macros after Christoph Hellwig pointed out > that my original logic was too ugly. > Suggestions for better names welcome > > v3: don't overloa

Re: [PATCH 2/2] Makefile.extrawarn: limit -Wnested-externs to clang

2020-10-26 Thread Nathan Chancellor
On Mon, Oct 26, 2020 at 06:48:46PM -0700, Nathan Chancellor wrote: > On Mon, Oct 26, 2020 at 11:03:14PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The -Wnested-externs warning has become useless with gcc, since > > this warns every time that BUILD

Re: [rcu:rcu/test 76/76] drivers/dax/super.c:21:1: error: use of undeclared identifier '___srcu_struct_ptrs'

2020-10-26 Thread Nathan Chancellor
Hi Paul, On Tue, Oct 27, 2020 at 08:50:52AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > rcu/test > head: 784a6343c3660446ae62db13628b20e9f876100f > commit: 784a6343c3660446ae62db13628b20e9f876100f [76/76] Merge commit >

Re: [PATCH net-next 07/11] rtw88: remove extraneous 'const' qualifier

2020-10-26 Thread Nathan Chancellor
ignored-qualifiers] > static const u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev) > > Remove the extra qualifier here. > > Fixes: c97ee3e0bea2 ("rtw88: add power tracking support") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- >

Re: [PATCH] seq_file: fix clang warning for NULL pointer arithmetic

2020-10-26 Thread Nathan Chancellor
e4c3f4 ("Linux-2.6.12-rc2") > Fixes: c2b19daf6760 ("sysfs, kernfs: prepare read path for kernfs") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > fs/kernfs/file.c | 2 +- > fs/seq_file.c| 2 +- > 2 files changed, 2 insertions(+), 2 deleti

Re: [PATCH 2/2] Makefile.extrawarn: limit -Wnested-externs to clang

2020-10-26 Thread Nathan Chancellor
486baae2cf6 ("objtool: Allow nested externs to enable BUILD_BUG()") 6cf4ecf5c51d ("perf build: Allow nested externs to enable BUILD_BUG() usage") Reviewed-by: Nathan Chancellor > --- > scripts/Makefile.extrawarn | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [PATCH 1/2] Makefile.extrawarn: move -Wcast-align to W=3

2020-10-26 Thread Nathan Chancellor
s to a safer method. > > Signed-off-by: Arnd Bergmann Always sad to see a warning move further down the list but noisy headers are rough to deal with. This seems okay. Reviewed-by: Nathan Chancellor > --- > scripts/Makefile.extrawarn | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH\ net] rtw88: fix fw dump support detection

2020-10-26 Thread Nathan Chancellor
return -ENOTSUPP; > } > -- > 2.27.0 > Tom sent an identical patch earlier that it does not look like Kalle has picked up: https://lore.kernel.org/linux-wireless/20201011155438.15892-1-t...@redhat.com/ Not that it particularly matters which one goes in so regardless: Reviewed-by: Nathan Chancellor

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Nathan Chancellor
On Mon, Oct 26, 2020 at 12:36:52PM -0700, Guenter Roeck wrote: > On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > > > Remove the quote operator # from

Re: [PATCH] kbuild: remove unused OBJSIZE

2020-10-23 Thread Nathan Chancellor
commit 2e83e0eb85ca > ("s390: clean .bss before running uncompressed kernel") these restrictions > have been lifted for the decompressor and uncompressed kernel and the > size tool is now unused. > > Signed-off-by: Vasily Gorbik Reviewed-by: Nathan Chancellor Thanks for

[PATCH v2] arm64: vdso32: Allow ld.lld to properly link the VDSO

2020-10-19 Thread Nathan Chancellor
directly. We eliminate -mfloat-abi=soft because it is not handled by the linker. Link: https://github.com/ClangBuiltLinux/linux/issues/1033 Reported-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers Reviewed-by: Vincenzo Frascino Signed-off-by: Nathan Chancellor

Re: [PATCH 1/2] staging: wfx: fix use of uninitialized pointer

2020-10-19 Thread Nathan Chancellor
if (rate->idx >= band->n_bitrates) { > ^~~~ > > Reported-by: kernel test robot > Reported-by: Nathan Chancellor > Fixes: 868fd970e187 ("staging: wfx: improve robustness of wfx_get_hw_rate()") > Signed-off-by: Jérôme Pouiller Reviewed-by: Nath

Re: [PATCH] arm64: vdso32: Allow ld.lld to properly link the VDSO

2020-10-19 Thread Nathan Chancellor
On Mon, Oct 19, 2020 at 10:59:47AM +0100, Vincenzo Frascino wrote: > > Hi Nathan, > > On 10/13/20 4:39 AM, Nathan Chancellor wrote: > > As it stands now, the vdso32 Makefile hardcodes the linker to ld.bfd > > using -fuse-ld=bfd with $(CC). This was taken from t

Re: [PATCH 8/8] staging: wfx: improve robustness of wfx_get_hw_rate()

2020-10-15 Thread Nathan Chancellor
On Fri, Oct 09, 2020 at 07:13:07PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Smatch complains: > > data_tx.c:37 wfx_get_hw_rate() warn: constraint '(struct > ieee80211_supported_band)->bitrates' overflow 'band->bitrates' 0 <= abs_rl > '0-127' user_rl '' required = '(struct

[PATCH] arm64: vdso32: Allow ld.lld to properly link the VDSO

2020-10-12 Thread Nathan Chancellor
directly. We eliminate -mfloat-abi=soft because it is not handled by the linker. Link: https://github.com/ClangBuiltLinux/linux/issues/1033 Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- NOTE: This patch is currently based on the kbuild tree due to the --build-id -> --b

Re: [PATCH] arm/build: Always handle .ARM.exidx and .ARM.extab sections

2020-10-12 Thread Nathan Chancellor
On Mon, Oct 12, 2020 at 02:26:52PM -0700, Kees Cook wrote: > On Mon, Oct 12, 2020 at 02:22:03PM -0700, Fāng-ruì Sòng wrote: > > On Mon, Oct 12, 2020 at 2:11 PM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > On Mon, Sep 28, 2020 at 3:49

Re: [PATCH] rtw88: fix fw_fifo_addr check

2020-10-11 Thread Nathan Chancellor
fw_fifo_addr) { > > fw_fifo_addr is an array in rtw_chip_info so it is always > nonzero. A better check is if the first element of the array is > nonzero. In the cases where fw_fifo_addr is initialized by rtw88b > and rtw88c, the first array element is 0x780. > > S

Re: [PATCH] misc: Kconfig: fix a HISI_HIKEY_USB dependency

2020-10-08 Thread Nathan Chancellor
On Thu, Oct 08, 2020 at 08:24:53AM +0200, Mauro Carvalho Chehab wrote: > The dependency should be just USB_ROLE_SWITCH, instead > of CONFIG_USB_ROLE_SWITCH. > > Fixes: 2827d98bc5d6 ("misc: Kconfig: add a new dependency for HISI_HIKEY_USB") > > Reported-by: Nat

Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB

2020-10-07 Thread Nathan Chancellor
On Wed, Oct 07, 2020 at 07:09:54AM +0200, Mauro Carvalho Chehab wrote: > As warned by Randy: > > on x86_64: > CONFIG_USB_ROLE_SWITCH=m > and HISI_HIKEY_USB=y. > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': >

[PATCH] LSM: Fix type of id parameter in kernel_post_load_data prototype

2020-10-06 Thread Nathan Chancellor
a() hook") Link: https://github.com/ClangBuiltLinux/linux/issues/1172 Signed-off-by: Nathan Chancellor --- include/linux/lsm_hook_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h index d67cb3502310..32a940

[PATCH] crypto: xor - Remove unused variable count in do_xor_speed

2020-10-06 Thread Nathan Chancellor
ink: https://github.com/ClangBuiltLinux/linux/issues/1171 Signed-off-by: Nathan Chancellor --- crypto/xor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/xor.c b/crypto/xor.c index a0badbc03577..eacbf4f93990 100644 --- a/crypto/xor.c +++ b/crypto/xor.c @@ -83,7 +83,7

Re: [PATCH v2] srcu: avoid escaped section names

2020-10-06 Thread Nathan Chancellor
c stable tag as this appears to be the root cause of the issue that Nick reported a few weeks ago: https://lore.kernel.org/rcu/cakwvodm4aqhobdkkt08bjpgb15n58qn79xwxeaqt-p5dk4+...@mail.gmail.com/ https://github.com/ClangBuiltLinux/linux/issues/1081 I can reproduce the issue on next-20201002 on my Raspberry Pi 4 just by booting it up. As soon as I apply this patch, all warnings disappear. I asked the original reporters to test if the patch resolves the issue for them but I figured more visibility on this, the sooner. The commit message might need to be revised if this turns out to be the case to make it more apparent that it has a user visible issue, rather than just a QoL fix. Additionally, it seems like the patch is missing some reviewed by tags from Kees, Sedat, and myself. Feel free to add a Tested-by: Nathan Chancellor as well. Cheers, Nathan

Re: [PATCH RFC 2/2] kbuild: use interpreters to invoke scripts

2020-10-04 Thread Nathan Chancellor
kml/20200830174409.c24c3f67addcce0cea9a9...@linux-foundation.org/ > Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/ > > Suggested-by: Andrew Morton > Suggested-by: Kees Cook > Suggested-by: Lukas Bulwahn > Signed-off-by: Ujjwal Kumar Reviewed-by: N

Re: [PATCH RFC 1/2] kconfig: use interpreters to invoke scripts

2020-10-04 Thread Nathan Chancellor
kml/20200830174409.c24c3f67addcce0cea9a9...@linux-foundation.org/ > Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/ > > Suggested-by: Andrew Morton > Suggested-by: Kees Cook > Suggested-by: Lukas Bulwahn > Signed-off-by: Ujjwal Kumar Reviewed-by: Nathan Cha

Re: [PATCH 4/4] ubsan: Disable UBSAN_TRAP for all*config

2020-10-04 Thread Nathan Chancellor
f-by: Kees Cook Reviewed-by: Nathan Chancellor > --- > lib/Kconfig.ubsan | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan > index 1fc07f936e06..b5b9da0b635a 100644 > --- a/lib/Kconfig.ubsan > +++ b/lib/Kconfig.ubsan > @@ -14,6

Re: [PATCH 3/4] ubsan: Force -Wno-maybe-uninitialized only for GCC

2020-10-04 Thread Nathan Chancellor
On Fri, Oct 02, 2020 at 03:15:26PM -0700, Kees Cook wrote: > Clang handles 'maybe-uninitialized' better in the face of using UBSAN, > so do not make this universally disabled for UBSAN builds. > > Signed-off-by: Kees Cook Well this patch is not strictly necessary because Clang does not support

Re: [PATCH 2/4] ubsan: Disable object-size sanitizer under GCC

2020-10-04 Thread Nathan Chancellor
.kernel.org/lkml/CAHk-=wjPasyJrDuwDnpHJS2TuQfExwe=px-szlen8gfmaqj...@mail.gmail.com/ Reviewed-by: Nathan Chancellor > --- > lib/Kconfig.ubsan | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan > index c0b801871e0b..aeb2cdea0b94 1

Re: [PATCH 1/4] ubsan: Move cc-option tests into Kconfig

2020-10-04 Thread Nathan Chancellor
> Link: > https://lore.kernel.org/lkml/CAHk-=wjPasyJrDuwDnpHJS2TuQfExwe=px-szlen8gfmaqj...@mail.gmail.com/ I tested menuconfig to make sure all the flags when CONFIG_UBSAN_MISC is flipped. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor One comment below. > --- >

[tip: core/static_call] static_call: Fix return type of static_call_init

2020-10-03 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the core/static_call branch of tip: Commit-ID: 69e0ad37c9f32d5aa1beb02aab4ec0cd055be013 Gitweb: https://git.kernel.org/tip/69e0ad37c9f32d5aa1beb02aab4ec0cd055be013 Author:Nathan Chancellor AuthorDate:Mon, 28 Sep 2020 16:09:39 -07

Re: [PATCH V2 1/3] efi: Support for MOK variable config table

2020-10-01 Thread Nathan Chancellor
On Thu, Oct 01, 2020 at 10:57:07PM +0200, Ard Biesheuvel wrote: > On Thu, 1 Oct 2020 at 19:44, Nathan Chancellor > wrote: > > > > On Fri, Sep 04, 2020 at 09:31:05PM -0400, Lenny Szubowicz wrote: > > > Because of system-specific EFI firmware limitations, EFI v

Re: [tip:master] BUILD SUCCESS WITH WARNING 99b8adf3cd30dbcb441cdd7282f0c6f7ef1615f3

2020-10-01 Thread Nathan Chancellor
+ clang-built-linux, full original message here: https://lore.kernel.org/lkml/5f761f6c.3jikdzmqtqd4yt0x%25...@intel.com/ On Fri, Oct 02, 2020 at 02:26:52AM +0800, kernel test robot wrote: > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > master > branch HEAD:

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-01 Thread Nathan Chancellor
On Thu, Oct 01, 2020 at 11:22:03AM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > > Hi Nathan, > > > > > > On Tue, Sep 29, 2020 at 03:15

Re: [PATCH V2 1/3] efi: Support for MOK variable config table

2020-10-01 Thread Nathan Chancellor
On Fri, Sep 04, 2020 at 09:31:05PM -0400, Lenny Szubowicz wrote: > Because of system-specific EFI firmware limitations, EFI volatile > variables may not be capable of holding the required contents of > the Machine Owner Key (MOK) certificate store when the certificate > list grows above some size.

Re: linux-next: manual merge of the akpm-current tree with the pm tree

2020-10-01 Thread Nathan Chancellor
On Thu, Oct 01, 2020 at 07:53:53PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the akpm-current tree got a conflict in: > > include/acpi/acpi_numa.h > > between commit: > > 4849bc777049 ("ACPI / NUMA: Add stub function for pxm_to_node()") > > from the pm tree

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-30 Thread Nathan Chancellor
On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > Hi Nathan, > > On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > > On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > > > Now that all the drivers have been adju

Re: [PATCH v2] srcu: avoid escaped section names

2020-09-30 Thread Nathan Chancellor
; they treat section names that contain \". > > The portable solution is to not use a string literal with the > preprocessor stringification operator. > > Link: https://bugs.llvm.org/show_bug.cgi?id=42950 > Fixes: commit fe15b50cdeee ("srcu: Allocate per-CPU data for DEFINE_SRCU() in

Re: [PATCH] export.h: fix section name for CONFIG_TRIM_UNUSED_KSYMS for Clang

2020-09-30 Thread Nathan Chancellor
https://bugs.llvm.org/show_bug.cgi?id=42950 > Link: https://github.com/ClangBuiltLinux/linux/issues/1166 > Fixes: commit bbda5ec671d3 ("kbuild: simplify dependency generation for > CONFIG_TRIM_UNUSED_KSYMS") > Reported-by: kbuild test robot > Suggested-by: Kees Cook > Sig

Re: [PATCH] docs: programming-languages: refresh blurb on clang support

2020-09-30 Thread Nathan Chancellor
On Tue, Sep 29, 2020 at 02:19:35PM -0700, Nick Desaulniers wrote: > Building the kernel with Clang doesn't rely on third party patches, and > has not for a few years now. > > Signed-off-by: Nick Desaulniers > --- Modulo Randy's nit: Reviewed-by: Nathan Chancellor > Doc

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-29 Thread Nathan Chancellor
On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > Now that all the drivers have been adjusted for it, let's bring in the > necessary device tree changes. > > The VEC and PV3 are left out for now, since it will require a more specific > clock setup. > > Reviewed-by: Dave Stevenson

Re: linux-next: Tree for Sep 29 (drivers/acpi/nfit/core.c)

2020-09-29 Thread Nathan Chancellor
On Tue, Sep 29, 2020 at 12:47:42PM -0700, Randy Dunlap wrote: > On 9/29/20 2:29 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200928: > > > > on x86_64: > when CONFIG_ACPI_NUMA is not set/enabled: > > ../drivers/acpi/nfit/core.c: In function ‘acpi_nfit_register_region’: >

[PATCH] arm/build: Always handle .ARM.exidx and .ARM.extab sections

2020-09-28 Thread Nathan Chancellor
t affected. Fixes: 5a17850e251a ("arm/build: Warn on orphan section placement") Link: https://github.com/ClangBuiltLinux/linux/issues/1152 Reported-by: kernel test robot Signed-off-by: Nathan Chancellor --- arch/arm/kernel/vmlinux.lds.S | 4 1 file changed, 4 insertions(+) diff --g

[PATCH] static_call: Fix return type of static_call_init

2020-09-28 Thread Nathan Chancellor
ink: https://lore.kernel.org/lkml/20200904044559.GA507165@ubuntu-n2-xlarge-x86/ Link: https://lore.kernel.org/lkml/20200903203053.3411268-17-samitolva...@google.com/ Signed-off-by: Nathan Chancellor --- include/linux/static_call.h | 6 +++--- kernel/static_call.c| 5 +++-- 2 files

Re: [PATCH -next for tip:x86/pti] x86/tlb: drop unneeded local vars in enable_l1d_flush_for_task()

2020-09-28 Thread Nathan Chancellor
o, the resulting binary is identical before and > after this change. > > Simplify the code and remove superfluous local variables to make > clang-analyzer happy. > > No functional change. No change in binary with supported compilers. > > Signed-off-by: Lukas Bulwahn > --

[PATCH] ACPI / NUMA: Add stub function for pxm_to_node

2020-09-28 Thread Nathan Chancellor
e(spa->proximity_domain); | ^~~ | xa_to_node cc1: some warnings being treated as errors ... Add a stub function like acpi_map_pxm_to_node had so that the build continues to work. Fixes: 01feba590cd6 ("ACPI: Do not create new NUMA domains from ACPI static tables that are n

Re: [PATCH] Documentation/llvm: Fix clang target examples

2020-09-25 Thread Nathan Chancellor
lang/LLVM") > Signed-off-by: Florian Fainelli Reviewed-by: Nathan Chancellor Thank you for the patch! > --- > Documentation/kbuild/llvm.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/

[PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable

2020-09-22 Thread Nathan Chancellor
the parentheses as it was clearly intended for the ternary condition to be evaluated first. Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail") Link: https://github.com/ClangBuiltLinux/linux/issues/1159 Signed-off-by: Nathan Chancellor ---

[PATCH] drm/amd/display: Simplify condition in try_disable_dsc

2020-09-21 Thread Nathan Chancellor
t the logic and prevents the warning. Fixes: 0749ddeb7d6c ("drm/amd/display: Add DSC force disable to dsc_clock_en debugfs entry") Link: https://github.com/ClangBuiltLinux/linux/issues/1158 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread Nathan Chancellor
fallthrough__) > * goto (plz no) > * (call of function with __attribute__(__noreturn__)) > > Fixes: 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro") > Link: https://bugs.llvm.org/show_bug.cgi?id=47539 > Suggested-by: Joe Perches > Signed-off-b

Re: [PATCH v5] lib/string.c: implement stpcpy

2020-09-14 Thread Nathan Chancellor
e is unsafe, so we should not > encourage its use. As such, I've removed the declaration from any > header, but it still needs to be exported to avoid linkage errors in > modules. > > Reported-by: Sami Tolvanen > Suggested-by: Andy Lavr > Suggested-by: Arvind Sankar > Sug

Re: [PATCH] brcmfmac: initialize variable

2020-09-13 Thread Nathan Chancellor
; brcmf_sdio_dcmd_resp_wait() only sets pending to true. > So pending needs to be initialized to false. > > Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers") > Signed-off-by: Tom Rix Reviewed-by: Nathan Chancellor > --- > drivers/net/wireless/broadco

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Nathan Chancellor
On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > > Ah great, that is indeed cleaner, thank you for letting me kn

Re: [PATCH] tty: serial: qcom_geni_serial: 115.2 is a better console default than 9600

2020-09-11 Thread Nathan Chancellor
nice to fix. > > Let's switch the default to 115200. > > Signed-off-by: Douglas Anderson Reviewed-by: Nathan Chancellor > --- > > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qc

<    1   2   3   4   5   6   7   8   9   10   >