Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread Nathan Chancellor
On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > Clang warns (trimmed for brevity): > > > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > > variable 'lin

[PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread Nathan Chancellor
ot;net: mvpp2: restructure "link status" interrupt handling") Link: https://github.com/ClangBuiltLinux/linux/issues/1151 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH] drm/vc4: Fix bitwise OR versus ternary operator in vc4_plane_mode_set

2020-09-10 Thread Nathan Chancellor
c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5") Link: https://github.com/ClangBuiltLinux/linux/issues/1150 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/vc4/vc4_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_p

[PATCH] drm/vc4: Update type of reg parameter in vc4_hdmi_{read,write}

2020-09-10 Thread Nathan Chancellor
mismatch. Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") Link: https://github.com/ClangBuiltLinux/linux/issues/1149 Signed-off-by: Nathan Chancellor --- Note, the variable names in these functions do not really make much sense after this patch but attempti

Re: [PATCH 4/4] kbuild: remove cc-option test of -Werror=date-time

2020-09-10 Thread Nathan Chancellor
3.5.0, see commit 4f43e554081ecac149fe360bee6eef2ed7dab8ea in LLVM. Reviewed-by: Nathan Chancellor > --- > > Makefile | 2 +- > arch/arm64/kernel/vdso32/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile &g

Re: [PATCH 2/4] kbuild: remove cc-option test of -fno-merge-all-constants

2020-09-10 Thread Nathan Chancellor
roduced this block is going to be reverted: https://lore.kernel.org/mm-commits/20200903201518.jkrrs%25a...@linux-foundation.org/ Regardless, it was introduced in LLVM 2.7.0 in commit f9d41df0930986c52e198292cf875eb5d1761ece. Reviewed-by: Nathan Chancellor > --- > > Makefile | 2 +- > 1 f

Re: [PATCH 3/4] kbuild: remove cc-option test of -fno-stack-check

2020-09-10 Thread Nathan Chancellor
clang (see commit 05b0798916f01690b5903302e51f3136274e291f) but that obviously does not matter for the sake of this. Reviewed-by: Nathan Chancellor > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 1b6abecc5ca

Re: [PATCH 1/4] kbuild: remove cc-option test of -fno-strict-overflow

2020-09-10 Thread Nathan Chancellor
ng 3.0.0 in commit 6e50103acda2b918545f30141edeb991d766f2a4. Reviewed-by: Nathan Chancellor > --- > > Makefile | 2 +- > arch/arm64/kernel/vdso32/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 4b5a305e30d2..05

Re: [PATCH v3 0/7] set clang minimum version to 10.0.1

2020-09-07 Thread Nathan Chancellor
On Mon, Sep 07, 2020 at 12:12:30PM -0400, Arvind Sankar wrote: > On Wed, Sep 02, 2020 at 03:59:04PM -0700, Nick Desaulniers wrote: > > Adds a compile time #error to compiler-clang.h setting the effective > > minimum supported version to clang 10.0.1. A separate patch has already > > been picked up

Re: [PATCH] EDAC: sb_edac: simplify switch statement

2020-09-07 Thread Nathan Chancellor
> This is a false positive. > > However by initializing the type to DEV_UNKNOWN the 3 case can be > removed from the switch, saving a comparison and jump. > > Signed-off-by: Tom Rix Some maintainers have a preference for a default case statement but presumably this case statement has b

Re: [PATCH] ath11k: fix a double free and a memory leak

2020-09-07 Thread Nathan Chancellor
ath11k_mac_setup_channels_rates(), allocates 3 channels. err_free > misses releasing ar->mac.sbands[NL80211_BAND_6GHZ].channels > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Tom Rix Reviewed-by: Nathan Chancellor > --

Re: [PATCH] mwifiex: remove function pointer check

2020-09-07 Thread Nathan Chancellor
because it will always be called at the end of the function even if the first check is skipped. Reviewed-by: Nathan Chancellor > --- > drivers/net/wireless/marvell/mwifiex/init.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/w

Re: [PATCH v2 01/28] x86/boot/compressed: Disable relocation relaxation

2020-09-04 Thread Nathan Chancellor
On Thu, Sep 03, 2020 at 07:42:15PM -0400, Arvind Sankar wrote: > On Thu, Sep 03, 2020 at 02:44:41PM -0700, Kees Cook wrote: > > On Thu, Sep 03, 2020 at 01:30:26PM -0700, Sami Tolvanen wrote: > > > From: Arvind Sankar > > > > > > Patch series [4] is a solution to allow the compressed kernel to be

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-03 Thread Nathan Chancellor
On Thu, Sep 03, 2020 at 04:34:09PM -0700, Kees Cook wrote: > On Thu, Sep 03, 2020 at 01:30:25PM -0700, Sami Tolvanen wrote: > > This patch series adds support for building x86_64 and arm64 kernels > > with Clang's Link Time Optimization (LTO). > > Tested-by: Kees Coo

Re: [PATCH v3 0/7] set clang minimum version to 10.0.1

2020-09-03 Thread Nathan Chancellor
On Thu, Sep 03, 2020 at 04:06:43PM +0200, Sedat Dilek wrote: > On Thu, Sep 3, 2020 at 12:59 AM Nick Desaulniers > wrote: > > > > Adds a compile time #error to compiler-clang.h setting the effective > > minimum supported version to clang 10.0.1. A separate patch has already > > been picked up into

Re: [PATCH] media: em28xx: fix function pointer check

2020-09-03 Thread Nathan Chancellor
e statement. > So fix the check consistent with other similar in > the file. > > Change a similar check in em28xx_resume_extension() > to use consistent logic as its siblings. > > Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner > functionality") > Signe

Re: [PATCH 0/2] link vdso with linker

2020-09-01 Thread Nathan Chancellor
On Tue, Sep 01, 2020 at 03:25:21PM -0700, Nick Desaulniers wrote: > Kees Cook is working on series that adds --orphan-section=warn to arm, > arm64, and x86. I noticed that ppc vdso were still using cc-ldoption > for these which I removed. It seems this results in that flag being > silently

[PATCH] mwifiex: Remove unnecessary braces from HostCmd_SET_SEQ_NO_BSS_INFO

2020-09-01 Thread Nathan Chancellor
;wireless: mwifiex: initial commit for Marvell mwifiex driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1146 Reported-by: Andy Lavr Signed-off-by: Nathan Chancellor --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 4 ++-- drivers/net/wireless/marvell/mwifiex/fw.h | 8 ++

Re: [PATCH v2 7/7] compiler-gcc: improve version error

2020-08-31 Thread Nathan Chancellor
d 4.9 or better. > ("Upgrade to what version?" doesn't need to be dug out of documentation, >headers, etc.) > > Suggested-by: Kees Cook > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor It would be nice if there was some easy way to link the docume

Re: [PATCH v2 6/7] kasan: Remove mentions of unsupported Clang versions

2020-08-31 Thread Nathan Chancellor
o Elver > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > Documentation/dev-tools/kasan.rst | 4 ++-- > lib/Kconfig.kasan | 9 - > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/Documentation/dev-to

Re: [PATCH v2 5/7] Partial revert "ARM: 8905/1: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer"

2020-08-31 Thread Nathan Chancellor
for calling this out. > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > ind

Re: [PATCH v2 4/7] Revert "arm64: vdso: Fix compilation with clang older than 8"

2020-08-31 Thread Nathan Chancellor
On Mon, Aug 31, 2020 at 05:23:23PM -0700, Nick Desaulniers wrote: > This reverts commit 3acf4be235280f14d838581a750532219d67facc. > > The minimum supported version of clang is clang 10.0.1. > > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by:

Re: [PATCH v2 3/7] Revert "arm64: bti: Require clang >= 10.0.1 for in-kernel BTI support"

2020-08-31 Thread Nathan Chancellor
On Mon, Aug 31, 2020 at 05:23:22PM -0700, Nick Desaulniers wrote: > This reverts commit b9249cba25a5dce5de87e5404503a5e11832c2dd. > > The minimum supported version of clang is now 10.0.1. > > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by:

Re: [PATCH v2 2/7] Revert "kbuild: disable clang's default use of -fmerge-all-constants"

2020-08-31 Thread Nathan Chancellor
300. > Link: https://github.com/ClangBuiltLinux/linux/issues/9 > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > Makefile | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/Makefile b/Makefile

Re: [PATCH v2] arm64: use a common .arch preamble for inline assembly

2020-08-27 Thread Nathan Chancellor
i and saw no adverse affects through a compilation workload. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > Changes in v2: > - Switched to a standard preamble for the architecture version. > > --- > arch/arm64/Makefile | 11 --- > arch/ar

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-26 Thread Nathan Chancellor
//github.com/ClangBuiltLinux/linux/issues/941 > Suggested-by: Sedat Dilek > Signed-off-by: Nick Desaulniers Otherwise, I agree with Kees's comments. With them addressed, feel free to add: Acked-by: Nathan Chancellor > --- > include/linux/compiler-clang.h | 8 > 1 file chan

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-26 Thread Nathan Chancellor
On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote: > On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers > wrote: > > > > During Plumbers 2020, we voted to just support the latest release of > > Clang for now. Add a compile time check for this. > > Since this effectively enforces a

[PATCH] Documentation/llvm: Improve formatting of commands, variables, and arguments

2020-08-25 Thread Nathan Chancellor
and single backticks instead of double backticks for inline formatting. Add those so that the document looks nicer in an HTML format, while not ruining the look in plain text. As a result of this, we can remove the escaped backslashes in the last code block and move them to single backslashes. Signed-off-

Re: [PATCH] Documentation: add minimum clang/llvm version

2020-08-25 Thread Nathan Chancellor
t were used to support older versions. Please see > additional > +docs on :ref:`Building Linux with Clang/LLVM `. > + Do we maybe want to add a section for LLVM/clang in the "Getting updated software" section? Maybe just a link to the existing section that we have in kbuild/llvm.rst? > Make > > > -- > 2.28.0.297.g1956fa8f8d-goog > Regardless of the nits above: Reviewed-and-tested-by: Nathan Chancellor

Re: [PATCH v3] lib/string.c: implement stpcpy

2020-08-25 Thread Nathan Chancellor
/bugs.llvm.org/show_bug.cgi?id=47280 > Link: https://github.com/ClangBuiltLinux/linux/issues/1126 > Link: https://man7.org/linux/man-pages/man3/stpcpy.3.html > Link: https://pubs.opengroup.org/onlinepubs/9699919799/functions/stpcpy.html > Link: https://reviews.llvm.org/D85963 > Suggest

Re: [PATCH] MAINTAINERS: add LLVM maintainers

2020-08-25 Thread Nathan Chancellor
t > the keys to the nukes with any one entity. Should Nathan and I find > ourselves at the same employer, I would gladly step down. > > Cc: clang-built-li...@googlegroups.com > Cc: Nathan Chancellor > Signed-off-by: Nick Desaulniers Acked-by: Nathan Chancellor

Re: [PATCH 5.4 000/109] 5.4.61-rc2 review

2020-08-24 Thread Nathan Chancellor
.4.61-rc2.gz > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.4.y > and the diffstat can be found below. > > thanks, > > greg k-h Built several configurations with LLVM 12 and saw no regressions compared to 5.4.60. Tested-by: Nathan Chancellor

Re: [PATCH] lib: Revert use of fallthrough pseudo-keyword in lib/

2020-08-24 Thread Nathan Chancellor
On Mon, Aug 24, 2020 at 03:36:14PM -0500, Gustavo A. R. Silva wrote: > The following build error for powerpc64 was reported by Nathan Chancellor: > > "$ scripts/config --file arch/powerpc/configs/powernv_defconfig -e KERNEL_XZ > > $ make -skj"$(nproc)" ARCH=pow

Re: [GIT PULL] fallthrough pseudo-keyword macro conversions for 5.9-rc3

2020-08-24 Thread Nathan Chancellor
On Sun, Aug 23, 2020 at 10:48:41PM -0500, Gustavo A. R. Silva wrote: > Hi Linus, > > Not sure what the problem was with my pull-request for -rc2. So, I'm giving > this a second try because I think it is worth it. > > I have build-tested this patch on 10 different architectures: x86_64, i386, >

Re: [PATCH] x86/asm: Replace __force_order with memory clobber

2020-08-24 Thread Nathan Chancellor
pplied this patch to v5.9-rc2 and next-20200824 and built several different configurations with clang + GNU as and some with clang + LLVM's integrated assembler and saw no build failures. Tested-by: Nathan Chancellor > --- > arch/x86/boot/compressed/pgtable_64.c | 9 - > arc

Re: [PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-21 Thread Nathan Chancellor
On Fri, Aug 21, 2020 at 04:13:19PM -0700, Randy Dunlap wrote: > On 8/21/20 3:50 PM, Nathan Chancellor wrote: > > Clang warns several times when building for 32-bit ARM along the lines > > of: > > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count &g

[PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-21 Thread Nathan Chancellor
g long. This matches the size of the features field throughout this driver, which is u64 so there should be no functional change. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Link: https://github.com/ClangBuiltLinux/linux/issues/1140 Signed-off-by: N

[PATCH] net: dsa: sja1105: Do not use address of compatible member in sja1105_check_device_id

2020-08-21 Thread Nathan Chancellor
tps://github.com/ClangBuiltLinux/linux/issues/1139 Signed-off-by: Nathan Chancellor --- drivers/net/dsa/sja1105/sja1105_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index c3f6f124e5f0..5a28dfb36ec3 1006

Re: [PATCH] Makefile: add -fuse-ld=lld to KBUILD_HOSTLDFLAGS when LLVM=1

2020-08-20 Thread Nathan Chancellor
mmit a0d1c951ef08 ("kbuild: support LLVM=1 to switch the default > tools to Clang/LLVM") Minor nit, "commit" is unnecessary here and might be flagged by some tag checking scripts. > Reported-by: Matthias Maennich > Signed-off-by: Nick Desaulniers Regardless of the ab

Re: fallthrough pseudo-keyword macro conversions for 5.9-rc2

2020-08-20 Thread Nathan Chancellor
On Thu, Aug 20, 2020 at 03:15:11PM -0700, Nick Desaulniers wrote: > > Hi Gustavo, > Just noticed this on lore. I'm curious if you'd had a chance to test your PR > with e2079e93f562c reverted? > ~Nick There will still probably be a decent amount of noise due to

Re: [PATCH v2 3/5] Revert "lib/string.c: implement a basic bcmp"

2020-08-19 Thread Nathan Chancellor
; explicit callers, so we can now safely remove this interface. > > Suggested-by: Nathan Chancellor > Reviewed-by: Kees Cook > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > include/linux/string.h | 3 --- > lib/string.c | 20 ---

Re: [PATCH v2 1/5] Makefile: add -fno-builtin-stpcpy

2020-08-19 Thread Nathan Chancellor
vm.org/D85963 > Reported-by: Sami Tolvanen > Suggested-by: Dávid Bolvanský > Suggested-by: Kees Cook > Reviewed-by: Kees Cook > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > Makefile | 1 + > 1 file chan

Re: [PATCH v2 2/5] Makefile: add -fno-builtin-bcmp

2020-08-19 Thread Nathan Chancellor
de08), which is also the minimum > supported version of clang for LTO. Use `-fno-builtin-bcmp` instead. > > With this applid, we can cleanly revert > commit 5f074f3e192f ("lib/string.c: implement a basic bcmp") > > Reviewed-by: Kees Cook > Suggested-by: Nathan Ch

[PATCH] block/rnbd: Ensure err is always initialized in process_rdma

2020-08-18 Thread Nathan Chancellor
inux/linux/issues/1134 Reported-by: Brooke Basile Signed-off-by: Nathan Chancellor --- drivers/block/rnbd/rnbd-srv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c index 0fb94843a495..1b71cb2a885d 100644 --- a/dri

Re: [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-17 Thread Nathan Chancellor
On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote: > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > Use `-fno-builtin-bcmp` instead. > > The issue with using `-fno-builtin-*` flags was that they were not > retained during an LTO link with LLVM. This was fixed

Re: [PATCH] block: rnbd: rnbd-srv: silence uninitialized variable warning

2020-08-17 Thread Nathan Chancellor
On Tue, Aug 18, 2020 at 12:03:18AM -0400, Brooke Basile wrote: > Clang warns: > drivers/block/rnbd/rnbd-srv.c:150:6: warning: variable 'err' is used > uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (IS_ERR(bio)) { >

Re: [PATCH 0/3] kbuild: clang-tidy

2020-08-12 Thread Nathan Chancellor
On Wed, Aug 12, 2020 at 03:52:54PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Wed, Aug 12, 2020 at 12:56 PM Nathan Huckleberry wrote: > > > > On Wed, Aug 12, 2020 at 12:40 PM Masahiro Yamada > > wrote: > > > > > > > > > I improved gen_compile_commands.py in the first two

[PATCH] clk: rockchip: Fix initialization of mux_pll_src_4plls_p

2020-08-09 Thread Nathan Chancellor
iable name in rv1108, it seems that this should have been four distinct elements. Fix it up by adding the comma as suggested. Fixes: 307a2e9ac524 ("clk: rockchip: add clock controller for rk3228") Link: https://github.com/ClangBuiltLinux/linux/issues/1123 Signed-off-by: Nathan Chancellor

Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable

2020-07-31 Thread Nathan Chancellor
le 'udc' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Krzysztof Kozlowski Weird, looks like it has been unused since the introduction of the driver. Reviewed-by: Nathan Chancellor > --- > drivers/usb/gadget/udc/s3c2410_udc.c | 3 --- > 1 file changed, 3 deletion

Re: [PATCH v2] clk: bcm2835: Do not use prediv with bcm2711's PLLs

2020-07-30 Thread Nathan Chancellor
ere re-purposed, this > was triggering miscalculations on all clocks hanging from the VPU clock, > notably the aux UART, making its output unintelligible. > > Fixes: 42de9ad400af ("clk: bcm2835: Add BCM2711_CLOCK_EMMC2 support") > Reported-by: Nathan Chancellor > Signed

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-30 Thread Nathan Chancellor
On Tue, Jul 28, 2020 at 12:09:18PM +0200, Christoph Hellwig wrote: > Ok, I found a slight bug that wasn't intended. I wanted to make sure > we can always fall back to a lower pool, but got that wrong. Should be > fixed in the next version. Hi Christoph and Nicolas, Did a version of that series

Re: [PATCH 1/4] arm64: stop using directly

2020-07-30 Thread Nathan Chancellor
On Sun, Jul 26, 2020 at 06:03:58PM +0200, Christoph Hellwig wrote: > Always use so that we can move more declarations to > common code. In two of the three cases the asm include was in addition > to an existing one for anyway. > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH v2] arm64/alternatives: move length validation inside the subsection

2020-07-30 Thread Nathan Chancellor
On Thu, Jul 30, 2020 at 08:37:01AM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement > sequences") breaks LLVM's integrated assembler, because due to its > one-pass design, it cannot compute instruction sequence lengths

Re: mmotm 2020-07-27-18-18 uploaded (mm/page_alloc.c)

2020-07-28 Thread Nathan Chancellor
On Tue, Jul 28, 2020 at 03:39:21PM -0700, Randy Dunlap wrote: > On 7/28/20 2:55 PM, Andrew Morton wrote: > > On Tue, 28 Jul 2020 05:33:58 -0700 Randy Dunlap > > wrote: > > > >> On 7/27/20 6:19 PM, Andrew Morton wrote: > >>> The mm-of-the-moment snapshot 2020-07-27-18-18 has been uploaded to >

Re: [PATCH] usb: dwc2: Fix parameter type in function pointer prototype

2020-07-25 Thread Nathan Chancellor
On Sat, Jul 25, 2020 at 08:19:47AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2020 at 11:03:54PM -0700, Nathan Chancellor wrote: > > When booting up on a Raspberry Pi 4 with Control Flow Integrity checking > > enabled, the following warning/panic happens: > > &

[PATCH] usb: dwc2: Fix parameter type in function pointer prototype

2020-07-25 Thread Nathan Chancellor
pointer prototype. Make the function pointer protoype match the definitions so that there is no more violation. Cc: sta...@vger.kernel.org Fixes: 7de1debcd2de ("usb: dwc2: Remove platform static params") Link: https://github.com/ClangBuiltLinux/linux/issues/1107 Signed-off-by: Nathan

Re: [PATCH] arm64: vdso32: Fix '--prefix=' value for newer versions of clang

2020-07-22 Thread Nathan Chancellor
On Thu, Jul 23, 2020 at 06:45:07AM +0200, Sedat Dilek wrote: > On Thu, Jul 23, 2020 at 6:15 AM Nathan Chancellor > wrote: > > > > Newer versions of clang only look for $(COMPAT_GCC_TOOLCHAIN_DIR)as [1], > > rather than $(COMPAT_GCC_TOOLCHAIN_DIR)$(CROSS_COMPILE_

[PATCH] arm64: vdso32: Fix '--prefix=' value for newer versions of clang

2020-07-22 Thread Nathan Chancellor
ect/commit/3452a0d8c17f7166f479706b293caf6ac76ffd90 [2]: https://lore.kernel.org/lkml/20200721173125.1273884-1-mask...@google.com/ Cc: sta...@vger.kernel.org Link: https://github.com/ClangBuiltLinux/linux/issues/1099 Signed-off-by: Nathan Chancellor --- arch/arm64/kernel/vdso32/Makefile | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-21 Thread Nathan Chancellor
rch64-linux-gnu-as. > > > > > > Set --prefix= to $(GCC_TOOLCHAIN_DIR)$(CROSS_COMPILE) > > > (/usr/bin/aarch64-linux-gnu-) so that newer Clang can find the > > > appropriate cross compiling GNU as (when -no-integrated-as is in > > > effect). > > > > >

Re: [PATCH] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Nathan Chancellor
/bin/aarch64-linux-gnu-) so that newer Clang can find the > appropriate cross compiling GNU as (when -no-integrated-as is in > effect). > > Signed-off-by: Nathan Chancellor > Signed-off-by: Fangrui Song > Link: https://github.com/ClangBuiltLinux/linux/issues/1099 Sorry that I did n

Re: [PATCH v2] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

2020-07-20 Thread Nathan Chancellor
aked+0x34/0x38 > > Signed-off-by: Luca Stefani > Tested-by: freak07 > Acked-by: Anton Altaparmakov Reviewed-by: Nathan Chancellor > --- > fs/ntfs/dir.c | 2 +- > fs/ntfs/inode.c | 27 ++- > fs/ntfs/inode.h | 4 +--- > fs/ntfs/mft.c | 4

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-07-18 Thread Nathan Chancellor
On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > Hi Nathan, > > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor > wrote: > > arch/powerpc/boot/main.c:107:18: warning: array comparison always > > evaluates to a constant [-Wtautological-compare] >

Re: [PATCH] clang: linux/compiler-clang.h: drop duplicated word in a comment

2020-07-17 Thread Nathan Chancellor
On Fri, Jul 17, 2020 at 07:55:02PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Drop the doubled word "the" in a comment. > > Signed-off-by: Randy Dunlap > Cc: clang-built-li...@googlegroups.com Reviewed-by: Nathan Chancellor > --- > include/lin

Re: [PATCH] remoteproc: qcom: pil-info: Fix shift overflow

2020-07-16 Thread Nathan Chancellor
om: Introduce helper to store pil info in > IMEM") > Reported-by: Lee Jones > Reported-by: Nathan Chancellor > Signed-off-by: Bjorn Andersson Tested-by: Nathan Chancellor # build > --- > drivers/remoteproc/qcom_pil_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Intel-wired-lan] [PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

2020-07-16 Thread Nathan Chancellor
On Thu, Jul 16, 2020 at 07:29:03PM +0300, Neftin, Sasha wrote: > On 7/16/2020 07:49, Nathan Chancellor wrote: > > Clang warns: > > > Hello Nathan, > Thanks for tracking our code.Please, look at > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200709

Re: [PATCH v7 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-07-15 Thread Nathan Chancellor
On Mon, Jun 22, 2020 at 12:19:39PM -0700, Bjorn Andersson wrote: > A region in IMEM is used to communicate load addresses of remoteproc to > post mortem debug tools. Implement a helper function that can be used to > store this information in order to enable these tools to process > collected

[PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

2020-07-15 Thread Nathan Chancellor
ot;) Link: https://github.com/ClangBuiltLinux/linux/issues/1095 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/intel/igc/igc_mac.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c in

[PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Nathan Chancellor
f so that the function always does what it should do. Fixes: 239bef676d8e ("drm/i915/display: Implement new combo phy initialization step") Link: https://github.com/ClangBuiltLinux/linux/issues/1094 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/display/intel_combo_phy.c | 4 ++-- 1 f

Re: [PATCH 00/22] add support for Clang LTO

2020-07-12 Thread Nathan Chancellor
On Sun, Jul 12, 2020 at 10:59:17AM +0200, Sedat Dilek wrote: > On Sat, Jul 11, 2020 at 6:32 PM Paul Menzel wrote: > > > > Dear Sami, > > > > > > Am 24.06.20 um 22:31 schrieb Sami Tolvanen: > > > This patch series adds support for building x86_64 and arm64 kernels > > > with Clang's Link Time

Re: sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids'

2020-07-10 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 01:24:59PM +0100, Mark Brown wrote: > On Thu, Jul 09, 2020 at 07:41:00PM -0700, Nathan Chancellor wrote: > > > When CONFIG_SND_SOC_ZL38060 is y, MODULE_DEVICE_TABLE expands to nothing > > so zl38_dt_ids will be unused. This is a pretty common construct

Re: [PATCH] Restore gcc check in mips asm/unroll.h

2020-07-10 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 03:31:00PM -0700, Linus Torvalds wrote: > On Fri, Jul 10, 2020 at 11:43 AM Nick Desaulniers > wrote: > > > > What I'd really like to see as a policy in the kernel going forward in > > that ANY new commit that adds some hack or workaround for a specific > > compiler version

Re: [PATCH] mips: Remove compiler check in unroll macro

2020-07-10 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 03:43:43PM -0700, Linus Torvalds wrote: > On Fri, Jul 10, 2020 at 3:34 PM Nathan Chancellor > wrote: > > > > Clang 8 was chosen as a minimum version for this check because there > > were some improvements around __builtin_constant_p in that relea

[PATCH] mips: Remove compiler check in unroll macro

2020-07-10 Thread Nathan Chancellor
that check was not technically necessary. Just remove all compiler checks and just assume that we have a working compiler. Fixes: d4e60453266b ("Restore gcc check in mips asm/unroll.h") Link: https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/359642821 Signed-off-

Re: sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids'

2020-07-09 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 12:47:31AM +0800, kernel test robot wrote: > Hi Sven, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 0bddd227f3dc55975e2b8dfa7fc6f959b062a2c7 > commit:

Re: [PATCH v4 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-07-07 Thread Nathan Chancellor
Hi Andres, On Tue, Jun 30, 2020 at 08:12:20PM -0400, Andres Beltran wrote: > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in storvsc. In the face of errors or malicious > behavior in Hyper-V, storvsc should not expose or trust the transaction > IDs returned by

Re: [PATCH] kbuild: Allow Clang global merging if !MODULES

2020-07-04 Thread Nathan Chancellor
Hi Danny, On Thu, Jul 02, 2020 at 04:39:29PM -0700, Danny Lin wrote: > The old reasoning for disabling Clang's global merging optimization is > that it breaks modpost by coalescing many symbols into _MergedGlobals. > However, modpost is only used in builds with dynamic modules; > vmlinux.symvers

Re: [PATCH] vmlinux.lds.h: Coalesce transient LLVM dead code elimination sections

2020-07-02 Thread Nathan Chancellor
1170972 KiB > > After:56 sections, 1171169 KiB Am I reading this right that coalescing those sections increases the image size? Kind of interesting. > > [1] > > https://github.com/llvm/llvm-project/commit/9e33c096476ab5e02ab1c8442cc3cb4e32e29f17 > > > > Link: http

[PATCH] clk: mvebu: ARMADA_AP_CPU_CLK needs to select ARMADA_AP_CP_HELPER

2020-07-01 Thread Nathan Chancellor
pu clk") so it was never noticed. Fixes: f756e362d938 ("clk: mvebu: add CPU clock driver for Armada 7K/8K") Signed-off-by: Nathan Chancellor --- I do not know who should actually take this patch since the problematic patch is on Viresh's cpufreq/arm/linux-next but the problem or

Re: [PATCH v2 1/2] kbuild: fix CONFIG_CC_CAN_LINK(_STATIC) for cross-compilation with Clang

2020-06-30 Thread Nathan Chancellor
> > When $(CC) is Clang, it is checked against the host architecture > because --target option is missing. > > Pass $(CLANG_FLAGS) to scripts/cc-can-link.sh to evaluate the link > capability for the target architecture. > > Signed-off-by: Masahiro Yamada Reviewed-by: Natha

Re: [PATCH v2 2/2] kbuild: make Clang build userprogs for target architecture

2020-06-30 Thread Nathan Chancellor
fix. > > Clang builds userspace programs always for the host architecture > because the target triple is currently missing. > > Fix this. > > Fixes: 7f3a59db274c ("kbuild: add infrastructure to build userspace programs") > Signed-off-by: Masahiro Yamada >

[PATCH net-next 1/2] amd8111e: Mark PM functions as __maybe_unused

2020-06-30 Thread Nathan Chancellor
that this is going to happen based on the configuration, which is the standard for these types of functions. Fixes: 2caf751fe080 ("amd8111e: Convert to generic power management") Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/amd/amd8111e.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] mailbox: imx: Mark PM functions as __maybe_unused

2020-06-30 Thread Nathan Chancellor
On Tue, Jun 23, 2020 at 02:14:05AM +, Aisheng Dong wrote: > > From: Nathan Chancellor > > Sent: Tuesday, June 23, 2020 9:04 AM > > > > When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings > > occur: > > > > dri

Re: [PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu'

2020-06-30 Thread Nathan Chancellor
On Wed, Jun 24, 2020 at 02:22:08PM -0400, Dennis Dalessandro wrote: > On 6/22/2020 8:52 PM, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/infiniband/hw/hfi1/qp.c:198:9: warning: implicit conversion from > > enumeration type 'enum opa_mtu' to different enumer

Re: [PATCH] ASoC: Intel: KeemBay: Fix header guard

2020-06-30 Thread Nathan Chancellor
On Tue, Jun 16, 2020 at 06:02:32PM -0700, Nathan Chancellor wrote: > Clang warns: > > In file included from sound/soc/intel/keembay/kmb_platform.c:14: > sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_' > is used as a header guard here, followed by #define

[PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe_unused

2020-06-30 Thread Nathan Chancellor
to the compiler that this is going to happen based on the configuration, which is the standard for these types of functions. Fixes: a86688fbef1b ("pcnet32: Convert to generic power management") Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/amd/pcnet32.c | 4 ++-- 1 file changed, 2 insert

Re: [f2fs-dev] [PATCH v3] f2fs: avoid readahead race condition

2020-06-30 Thread Nathan Chancellor
On Mon, Jun 29, 2020 at 01:27:20PM -0700, Jaegeuk Kim wrote: > If two readahead threads having same offset enter in readpages, every read > IOs are split and issued to the disk which giving lower bandwidth. > > This patch tries to avoid redundant readahead calls. > > Signed-off-by: Jaegeuk Kim

Re: [PATCH] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

2020-06-27 Thread Nathan Chancellor
vi = ilookup5_nowait(sb, mft_no, ntfs_test_inode, ); > } > if (vi) { > ntfs_debug("Base inode 0x%lx is in icache.", mft_no); > @@ -1019,7 +1019,7 @@ bool ntfs_may_write_mft_record(ntfs_volume *vol, const > unsigned long mft_no, > vi = igrab(mft_vi); > BUG_ON(vi != mft_vi); > } else > - vi = ilookup5_nowait(sb, na.mft_no, (test_t)ntfs_test_inode, > + vi = ilookup5_nowait(sb, na.mft_no, ntfs_test_inode, > ); > if (!vi) { > /* > -- > 2.26.2 > Other than those minor nits, Reviewed-by: Nathan Chancellor

Re: drivers/char/hw_random/npcm-rng.c:166:34: warning: unused variable 'rng_dt_id'

2020-06-26 Thread Nathan Chancellor
On Fri, Jun 26, 2020 at 04:42:25PM +1000, Herbert Xu wrote: > On Tue, Jun 23, 2020 at 09:58:39PM +0800, kernel test robot wrote: > > > > >> drivers/char/hw_random/npcm-rng.c:166:34: warning: unused variable > > >> 'rng_dt_id' [-Wunused-const-variable] > >static const struct of_device_id

[PATCH net-next] bonding: Remove extraneous parentheses in bond_setup

2020-06-25 Thread Nathan Chancellor
an assignment within an if statement. Since equality comparisons do not need a second set of parentheses, remove them to fix the warning. Fixes: 18cb261afd7b ("bonding: support hardware encryption offload to slaves") Link: https://github.com/ClangBuiltLinux/linux/issues/1066 Signed-off-

Re: [PATCH 02/22] kbuild: add support for Clang LTO

2020-06-24 Thread Nathan Chancellor
Hi Sami, On Wed, Jun 24, 2020 at 01:31:40PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > This change adds build system support for Clang's Link Time > Optimization (LTO). With -flto, instead of ELF object files, Clang > produces LLVM bitcode, which is compiled into native code at link >

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-24 Thread Nathan Chancellor
Hi Geoff, On Wed, Jun 24, 2020 at 06:18:48PM -0700, Geoff Levand wrote: > Hi Nathan, > > On 6/23/20 8:59 PM, Nathan Chancellor wrote: > > These are not true arrays, they are linker defined symbols, which are > > just addresses. Using the address of operator silences the

Re: [PATCH 5.4 000/314] 5.4.49-rc1 review

2020-06-23 Thread Nathan Chancellor
On Tue, Jun 23, 2020 at 09:53:15PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.49 release. > There are 314 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-23 Thread Nathan Chancellor
sembly with either clang/ld.lld or gcc/ld (tested with diff + objdump -Dr). Link: https://github.com/ClangBuiltLinux/linux/issues/212 Reported-by: Joel Stanley Signed-off-by: Nathan Chancellor --- arch/powerpc/boot/main.c | 4 ++-- arch/powerpc/boot/ps3.c | 2 +- 2 files changed, 3 insertions(+), 3 del

Re: linux-next: build failures after merge of the hid tree

2020-06-23 Thread Nathan Chancellor
Hi Jiri and Cristian, On Wed, Jun 24, 2020 at 12:13:57AM +0200, Jiri Kosina wrote: > On Tue, 23 Jun 2020, Stephen Rothwell wrote: > > > > I don't know what caused it, but commit > > > > > > 470376737e88 ("HID: allow building hid.ko as an external module") > > > > > > did not fix it. BTW, I

Re: [PATCH v8] mm: Proactive compaction

2020-06-22 Thread Nathan Chancellor
On Mon, Jun 22, 2020 at 09:32:12PM -0700, Nitin Gupta wrote: > On 6/22/20 7:26 PM, Nathan Chancellor wrote: > > On Tue, Jun 16, 2020 at 01:45:27PM -0700, Nitin Gupta wrote: > >> For some applications, we need to allocate almost all memory as > >> hugepages. However,

Re: [PATCH v8] mm: Proactive compaction

2020-06-22 Thread Nathan Chancellor
On Tue, Jun 16, 2020 at 01:45:27PM -0700, Nitin Gupta wrote: > For some applications, we need to allocate almost all memory as > hugepages. However, on a running system, higher-order allocations can > fail if the memory is fragmented. Linux kernel currently does on-demand > compaction as we

[PATCH] mm: cma: Return cma->name directly in cma_get_name

2020-06-22 Thread Nathan Chancellor
ix the name of CMA areas"), cma->name will be an array with some value worth printing so we do not need to check for NULL. Link: https://github.com/ClangBuiltLinux/linux/issues/1063 Signed-off-by: Nathan Chancellor --- mm/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH] drm/omap: Remove aggregate initialization of new_mode in omap_connector_mode_valid

2020-06-22 Thread Nathan Chancellor
fled again. Link: https://github.com/ClangBuiltLinux/linux/issues/1059 Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/omapdrm/omap_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drive

[PATCH] mailbox: imx: Mark PM functions as __maybe_unused

2020-06-22 Thread Nathan Chancellor
) |^~~~ Mark these functions as __maybe_unused, which is the standard procedure for PM functions. Fixes: bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU clocks") Signed-off-by: Nathan Chancellor --- drivers/mailbox/imx-mailbox.c | 8 --

[PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu'

2020-06-22 Thread Nathan Chancellor
ipoib Datagram mode MTU's upper limit") Link: https://github.com/ClangBuiltLinux/linux/issues/1062 Link: https://lore.kernel.org/linux-rdma/20200527040350.GA3118979@ubuntu-s3-xlarge-x86/ Signed-off-by: Nathan Chancellor --- drivers/infiniband/hw/hfi1/qp.c | 2 +- 1 file changed, 1 inser

<    1   2   3   4   5   6   7   8   9   10   >