[PATCH 1/2] media: omap3isp: Remove cacheflush.h

2020-06-22 Thread Nathan Chancellor
("asm-generic: don't include in cacheflush.h") Suggested-by: Geert Uytterhoeven Suggested-by: Laurent Pinchart Signed-off-by: Nathan Chancellor --- drivers/media/platform/omap3isp/isp.c | 2 -- drivers/media/platform/omap3isp/ispvideo.c | 1 - 2 files changed, 3 deletions(-)

[PATCH 2/2] asm-generic: Make cacheflush.h self-contained

2020-06-22 Thread Nathan Chancellor
(struct vm_area_struct *vma, ^ ... Add a few forward declarations should that there are no warnings and the ordering of the includes does not matter. Fixes: e0cf615d725c ("asm-generic: don't include in cacheflush.h") Signed-off-by: Nathan

[PATCH 0/2] Small fixes around cacheflush.h

2020-06-22 Thread Nathan Chancellor
Hi all, These two patches are the culmination of the small discussion here: https://lore.kernel.org/lkml/camuhmdvsdutoi5bugf9slqdgadwyl1+qalwskgin1teolgh...@mail.gmail.com/ I have fallen behind on fixing issues so sorry for not sending these sooner and letting these warnings slip into mainline.

Re: [PATCH v2 3/5] mm: memcg/percpu: per-memcg percpu memory statistics

2020-06-21 Thread Nathan Chancellor
On Sun, Jun 21, 2020 at 08:26:35PM -0700, Roman Gushchin wrote: > On Sun, Jun 21, 2020 at 06:48:03PM -0700, Nathan Chancellor wrote: > > On Mon, Jun 08, 2020 at 04:08:17PM -0700, Roman Gushchin wrote: > > > Percpu memory can represent a noticeable chunk of the total > &

Re: [PATCH v2 3/5] mm: memcg/percpu: per-memcg percpu memory statistics

2020-06-21 Thread Nathan Chancellor
On Mon, Jun 08, 2020 at 04:08:17PM -0700, Roman Gushchin wrote: > Percpu memory can represent a noticeable chunk of the total > memory consumption, especially on big machines with many CPUs. > Let's track percpu memory usage for each memcg and display > it in memory.stat. > > A percpu allocation

Re: [PATCH v3] seccomp: Add find_notification helper

2020-06-18 Thread Nathan Chancellor
On Thu, Jun 18, 2020 at 05:44:14AM +, Sargun Dhillon wrote: > On Wed, Jun 17, 2020 at 01:08:44PM -0700, Nathan Chancellor wrote: > > On Mon, Jun 01, 2020 at 04:25:32AM -0700, Sargun Dhillon wrote: > > > This adds a helper which can iterate through a seccomp_filter to > &g

Re: [PATCH v5 01/13] powerpc: Remove Xilinx PPC405/PPC440 support

2020-06-17 Thread Nathan Chancellor
On Thu, Jun 18, 2020 at 10:48:21AM +1000, Michael Ellerman wrote: > Nick Desaulniers writes: > > On Wed, Jun 17, 2020 at 3:20 AM Michael Ellerman > > wrote: > >> Michael Ellerman writes: > >> > Michal Simek writes: > >> > >> > >> >> Or if bamboo requires uImage to be built by default you can

Re: [PATCH v3] seccomp: Add find_notification helper

2020-06-17 Thread Nathan Chancellor
On Mon, Jun 01, 2020 at 04:25:32AM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. > > Signed-off-by: Sargun Dhillon > Acked-by: Christian Brauner > Reviewed-by:

[PATCH] ASoC: Intel: KeemBay: Fix header guard

2020-06-16 Thread Nathan Chancellor
("ASoC: Intel: Add KeemBay platform driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1053 Signed-off-by: Nathan Chancellor --- sound/soc/intel/keembay/kmb_platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/keembay/kmb_platform.h b

Re: [PATCH v5 01/13] powerpc: Remove Xilinx PPC405/PPC440 support

2020-06-16 Thread Nathan Chancellor
Hi Michal, On Tue, Jun 16, 2020 at 04:45:20PM +0200, Michal Simek wrote: > > > On 16. 06. 20 2:27, Nathan Chancellor wrote: > > On Thu, May 21, 2020 at 04:55:52PM +, Christophe Leroy wrote: > >> From: Michal Simek > >> > >> The latest Xilin

Re: [PATCH] phy: intel: Eliminate unnecessary assignment in intel_cbphy_set_mode

2020-06-15 Thread Nathan Chancellor
On Fri, May 22, 2020 at 08:50:43PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/phy/intel/phy-intel-combo.c:202:34: warning: implicit conversion > from enumeration type 'enum intel_phy_mode' to different enumeration > type 'enum intel_combo_mode' [-Wenum-conversion]

Re: [PATCH v5 01/13] powerpc: Remove Xilinx PPC405/PPC440 support

2020-06-15 Thread Nathan Chancellor
On Thu, May 21, 2020 at 04:55:52PM +, Christophe Leroy wrote: > From: Michal Simek > > The latest Xilinx design tools called ISE and EDK has been released in > October 2013. New tool doesn't support any PPC405/PPC440 new designs. > These platforms are no longer supported and tested. > >

Re: [PATCH] ACPI: sysfs: Fix pm_profile_attr type

2020-06-12 Thread Nathan Chancellor
On Thu, Jun 11, 2020 at 11:17:14PM -0700, Kees Cook wrote: > On Thu, Jun 11, 2020 at 09:51:50PM -0700, Nathan Chancellor wrote: > > When running a kernel with Clang's Control Flow Integrity implemented, > > there is a violation that happens when accessing > > /sys/fir

[PATCH] ACPI: sysfs: Fix pm_profile_attr type

2020-06-11 Thread Nathan Chancellor
x/issues/1051 Reported-by: yuu ichii Signed-off-by: Nathan Chancellor --- drivers/acpi/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c index 3a89909b50a6..76c668c05fa0 100644 --- a/drivers/acpi/sysfs.c +++ b/drivers/acpi/sysf

Re: [PATCH] .clang-format: update column limit

2020-06-10 Thread Nathan Chancellor
lar to what checkpatch (cf. [1]) uses now. > > Thanks! Picking this up with a few changes to the commit message. > > Cheers, > Miguel > If it isn't too late: Reviewed-by: Nathan Chancellor

Re: [PATCH] efi/libstub: Fix build error with libstub

2020-06-10 Thread Nathan Chancellor
On Wed, Jun 10, 2020 at 03:14:46PM +0800, Zhenzhong Duan wrote: > Got below error during build: > > In file included from drivers/firmware/efi/libstub/efi-stub-helper.c:16:0: > drivers/firmware/efi/libstub/efi-stub-helper.c: In function > ‘efi_char16_puts’: >

Re: [PATCH] clk: qcom: ipq4019: fix apss cpu overclocking

2020-06-08 Thread Nathan Chancellor
On Mon, Jun 08, 2020 at 10:54:34AM +0200, Robert Marko wrote: > On Thu, Jun 4, 2020 at 10:25 PM kernel test robot wrote: > > > > Hi Robert, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on clk/clk-next] > > [also build test WARNING on v5.7

Re: [rcu:dev.2020.06.02a 67/90] kernel/rcu/rcuperf.c:727:38: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long'

2020-06-07 Thread Nathan Chancellor
On Mon, Jun 08, 2020 at 09:56:16AM +0800, Kefeng Wang wrote: > > On 2020/6/8 3:00, Paul E. McKenney wrote: > > On Fri, Jun 05, 2020 at 05:19:14PM -0700, Paul E. McKenney wrote: > > > On Sat, Jun 06, 2020 at 07:07:10AM +0800, kernel test robot wrote: > > > > tree: > > > >

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Nathan Chancellor
warning pop up (which was about a variable being unused, commented on patch 9 about it). No warnings about uninitialized variables came up; clang's -Wuninitialized was not impacted by 78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized") so it should have caught anything e

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-03 Thread Nathan Chancellor
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize

Re: [git pull] misc uaccess stuff

2020-06-03 Thread Nathan Chancellor
On Wed, Jun 03, 2020 at 08:23:06PM +0100, Al Viro wrote: > uaccess patches that really didn't fit anywhere else. > kvm_hv_set_msr() patch left as-is; __put_user() is by no means > final there, but that'll be dealt with along with other KVM > uaccess stuff next cycle. > > The following

[PATCH v2] s390: vdso: Use $(LD) instead of $(CC) to link vDSO

2020-06-02 Thread Nathan Chancellor
e. Similar changes have been done for ARM, ARM64, and MIPS. Link: https://github.com/ClangBuiltLinux/linux/issues/1041 Signed-off-by: Nathan Chancellor --- v1 -> v2: * Add -fPIC per GCC's documentation, as pointed out by Nick. arch/s390/kernel/vdso64/Makefile | 10 -- 1 file changed,

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-01 Thread Nathan Chancellor
On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > > 'err' is used uninitialized when

[PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-29 Thread Nathan Chancellor
ot;) Link: https://github.com/ClangBuiltLinux/linux/issues/1042 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c in

Re: [PATCH] refperf: work around 64-bit division

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:15:51PM +0200, Arnd Bergmann wrote: > A 64-bit division was introduced in refperf, breaking compilation > on all 32-bit architectures: > > kernel/rcu/refperf.o: in function `main_func': > refperf.c:(.text+0x57c): undefined reference to `__aeabi_uldivmod' > > Work it by

Re: [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency

2020-05-29 Thread Nathan Chancellor
IS_ENABLED for PMIC_OPREGION, like some other drivers do. Regardless of that: Reviewed-by: Nathan Chancellor > --- > drivers/staging/media/atomisp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/atomisp/Kconfig > b/drivers/staging/medi

Re: [PATCH 8/9] staging: media: atomisp: disable all custom formats

2020-05-29 Thread Nathan Chancellor
> Signed-off-by: Arnd Bergmann I have this patch in my local tree and debated sending it myself. I think that this is the right fix for now, as the driver is being cleaned up. Maybe add a FIXME like the rest of this driver? Regardless of that last point: Reviewed-by: Nathan Chancello

Re: [PATCH 7/9] staging: media: atomisp: fix enum type mixups

2020-05-29 Thread Nathan Chancellor
"staging/atomisp: Add support for the Intel IPU v2") > Signed-off-by: Arnd Bergmann Huh weird that I did not see this warning but you do randconfigs so that's expected. Reviewed-by: Nathan Chancellor > --- > .../pci/hive_isp_css_common/host/input_system.c

Re: [PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

2020-05-29 Thread Nathan Chancellor
e > compound-literals with designated initializers") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drivers/staging/media/atomisp/pci/sh_css.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/m

Re: [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it

2020-05-29 Thread Nathan Chancellor
> [-Werror,-Wvisibility] > > Make sure the struct tag is known before declaring a function > that uses it as an argument. > > Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor

Re: [PATCH 3/9] staging: media: atomisp: annotate an unused function

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:25PM +0200, Arnd Bergmann wrote: > atomisp_mrfld_power() has no more callers and produces > a warning: > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused > function 'atomisp_mrfld_power' [-Werror,-Wunused-function] > > Mark the function as

Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:31:44PM +0200, Arnd Bergmann wrote: > On Fri, May 29, 2020 at 10:23 PM Arnd Bergmann wrote: > > > > On Fri, May 29, 2020 at 10:04 PM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > See also Nathan's 7 patch series. > > >

[PATCH] s390: vdso: Use $(LD) instead of $(CC) to link vDSO

2020-05-28 Thread Nathan Chancellor
e. Similar changes have been done for ARM, ARM64, and MIPS. Link: https://github.com/ClangBuiltLinux/linux/issues/1041 Signed-off-by: Nathan Chancellor --- arch/s390/kernel/vdso64/Makefile | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/s390/kernel/vdso64/Makef

Re: [PATCH] x86: crypto: fix building crc32c with clang ias

2020-05-27 Thread Nathan Chancellor
On Wed, May 27, 2020 at 08:24:35PM +0200, Arnd Bergmann wrote: > On Wed, May 27, 2020 at 6:42 PM Nathan Chancellor > wrote: > > > > On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote: > > > The clang integrated assembler complains about movzxw: > > &

Re: [PATCH 0/7] media: atomisp: Address several clang warnings

2020-05-27 Thread Nathan Chancellor
On Wed, May 27, 2020 at 10:45:25AM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 27 May 2020 00:11:43 -0700 > Nathan Chancellor escreveu: > > > Hi all, > > > > This series aims to clean up the code while addressing the majority of > > clang warnings in this d

Re: [PATCH] x86: crypto: fix building crc32c with clang ias

2020-05-27 Thread Nathan Chancellor
he discussion and result in the issue below. https://github.com/ClangBuiltLinux/linux/issues/1010 Reviewed-by: Nathan Chancellor > --- > arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/crypto/crc32c-pcl-i

Re: [PATCH] phy: intel: fix enum type mismatch warning

2020-05-27 Thread Nathan Chancellor
re.kernel.org/lkml/20200523035043.3305846-1-natechancel...@gmail.com/ I left out the default case since clang warns when a switch on an enum does not handle all the values (compile time scream) versus a run time scream like yours. I don't have a preference for either so: Reviewed-by: Nathan Chancellor

Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread Nathan Chancellor
es it by moving the assignment before the > label to which we jump after mapping or allocation errors. > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Reported-by: Nathan Chancellor > Signed-off-by: Bartosz Golaszewski Tested-by: Nathan Chancellor

Re: [PATCH -tip] compiler_types.h: Optimize __unqual_scalar_typeof compilation time

2020-05-27 Thread Nathan Chancellor
type_to_expr_cases(int), \ > + __scalar_type_to_expr_cases(long), \ > + __scalar_type_to_expr_cases(long long), \ > + default: (x))) > +#endif > > /* Is this type a native word size -- useful for atomic operations */ > #define __native_word(t) \ > -- > 2.27.0.rc0.183.gde8f92d652-goog > Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor # build

Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h

2020-05-27 Thread Nathan Chancellor
Hi Geert, On Wed, May 27, 2020 at 09:02:51AM +0200, Geert Uytterhoeven wrote: > Hi Nathan, > > CC Laurent > > On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor > wrote: > > After mm.h was removed from the asm-generic version of cacheflush.h, > > s390 allye

[PATCH net] netfilter: conntrack: Pass value of ctinfo to __nf_conntrack_update

2020-05-27 Thread Nathan Chancellor
to __nf_conntrack_update so that uninitialized memory is not used and everything works properly. Fixes: ee04805ff54a ("netfilter: conntrack: make conntrack userspace helpers work again") Link: https://github.com/ClangBuiltLinux/linux/issues/1039 Signed-off-by: Nathan Chancellor --- net

[PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers

2020-05-27 Thread Nathan Chancellor
); ~~ ^ 1 warning generated. Use the right type for event_type so that clang does not warn. Fixes: 8590ceedb701 ("nexthop: add support for notifiers") Link: https://github.com/ClangBuiltLinux/linux/issues/1038 Signed-off-by: Nathan Chancellor --- net/ipv4/nexthop.c | 2 +- 1 file

[PATCH] net/mlx5e: Don't use err uninitialized in mlx5e_attach_decap

2020-05-27 Thread Nathan Chancellor
Fixes: 14e6b038afa0 ("net/mlx5e: Add support for hw decapsulation of MPLS over UDP") Link: https://github.com/ClangBuiltLinux/linux/issues/1037 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Nathan Chancellor
On Fri, May 22, 2020 at 02:06:55PM +0200, Bartosz Golaszewski wrote: > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > new file mode 100644 > index ..789c77af501f > --- /dev/null > +++

[PATCH 7/7] media: atomisp: Remove binary_supports_input_format

2020-05-27 Thread Nathan Chancellor
nfo is not NULL so this function actually serves no purpose. Remove it. It can be brought back if needed later. Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor --- .../atomisp/pci/runtime/binary/src/binary.c | 21 --- 1 file changed,

[PATCH 3/7] media: atomisp: Add stub for atomisp_mrfld_power

2020-05-27 Thread Nathan Chancellor
the FIXME comment intact, and creating an atomisp_mrfld_power stub function that just returns 0. Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor --- drivers/sta

[PATCH 4/7] media: atomisp: Remove unnecessary NULL checks in ia_css_pipe_load_extension

2020-05-27 Thread Nathan Chancellor
ULL and pipe is already checked for NULL in this function. Simplify this if block. Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor --- drivers/staging/media/atomisp/pci/sh_css.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --g

[PATCH 5/7] media: atomisp: Remove unnecessary NULL check in atomisp_param

2020-05-27 Thread Nathan Chancellor
nsures that the user is not giving us an invalid pointer through copy_from_user. If config is not NULL, info cannot be NULL. Remove this check. Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 5 --

[PATCH 6/7] media: atomisp: Avoid overflow in compute_blending

2020-05-27 Thread Nathan Chancellor
to ever overflow, clang would warn: https://godbolt.org/z/EeSxLG Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor --- .../atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/7] media: atomisp: Address several clang warnings

2020-05-27 Thread Nathan Chancellor
Hi all, This series aims to clean up the code while addressing the majority of clang warnings in this driver, some found by the 0day bot and others found by me. There are several enum conversion warnings that happen, which I do not really know how to solve without understanding how exactly this

[PATCH 1/7] media: atomisp: Clean up if block in sh_css_sp_init_stage

2020-05-27 Thread Nathan Chancellor
verything. Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Reported-by: kbuild test robot Signed-off-by: Nathan Chancellor --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 27 +++ 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/staging/m

[PATCH 2/7] media: atomisp: Remove second increment of count in atomisp_subdev_probe

2020-05-27 Thread Nathan Chancellor
/ClangBuiltLinux/linux/issues/1036 Reported-by: kbuild test robot Signed-off-by: Nathan Chancellor --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci

[PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h

2020-05-26 Thread Nathan Chancellor
in this file and shuffle cacheflush.h below it. Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") Signed-off-by: Nathan Chancellor --- I am aware the fixes tag is kind of irrelevant because that SHA will change in the next linux-next revision and this will probably

Re: inux-next: build failure after merge of the drm-msm tree

2020-05-26 Thread Nathan Chancellor
On Tue, May 26, 2020 at 02:08:41PM +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 19 May 2020 15:09:55 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the drm-msm tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > ERROR: modpost:

Re: [PATCH 1/2] clk: bcm2835: Fix return type of bcm2835_register_gate

2020-05-26 Thread Nathan Chancellor
On Tue, May 26, 2020 at 04:42:04PM -0700, Stephen Boyd wrote: > Quoting Nathan Chancellor (2020-05-16 01:08:06) > > bcm2835_register_gate is used as a callback for the clk_register member > > of bcm2835_clk_desc, which expects a struct clk_hw * return type but > > bcm2835_

[PATCH v2] powerpc/wii: Fix declaration made after definition

2020-05-26 Thread Nathan Chancellor
esaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: * s/is_machine/machine_is/ (Nick) * Add Nick's reviewed-by tag. arch/powerpc/platforms/embedded6xx/wii.c | 25 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/platforms/embedde

Re: [PATCH] phy: intel: Eliminate unnecessary assignment in intel_cbphy_set_mode

2020-05-26 Thread Nathan Chancellor
On Tue, May 26, 2020 at 11:12:58AM -0700, Nick Desaulniers wrote: > On Fri, May 22, 2020 at 8:51 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/phy/intel/phy-intel-combo.c:202:34: warning: implicit conversion > > from enumeration typ

Re: [PATCH] power: reset: vexpress: fix build issue

2020-05-25 Thread Nathan Chancellor
On Mon, May 25, 2020 at 07:37:45PM -0400, Valdis Klētnieks wrote: > On Sun, 24 May 2020 15:20:25 -0700, Nathan Chancellor said: > > > arm-linux-gnueabi-ld: drivers/power/reset/vexpress-poweroff.o: in function > > `vexpress_reset_probe': > > vexpress-poweroff.c:(.text+0x3

Re: [PATCH] power: reset: vexpress: fix build issue

2020-05-24 Thread Nathan Chancellor
On Sat, May 23, 2020 at 12:01:03AM +0200, Anders Roxell wrote: > An allmodconfig kernel makes CONFIG_VEXPRESS_CONFIG a module and > CONFIG_POWER_RESET_VEXPRESS builtin. That makes us see this build > error: > > aarch64-linux-gnu-ld: drivers/power/reset/vexpress-poweroff.o: in function >

[PATCH] mt76: mt7915: Use proper enum type in __mt7915_mcu_msg_send

2020-05-22 Thread Nathan Chancellor
only ones assigned to it and that is the type that mt76_tx_queue_skb_raw expects. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") Link: https://github.com/ClangBuiltLinux/linux/issues/1035 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/mediat

[PATCH] phy: intel: Eliminate unnecessary assignment in intel_cbphy_set_mode

2020-05-22 Thread Nathan Chancellor
river support for ComboPhy") Link: https://github.com/ClangBuiltLinux/linux/issues/1034 Signed-off-by: Nathan Chancellor --- drivers/phy/intel/phy-intel-combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/intel/phy-intel-combo.c b/drivers/phy/intel/phy-int

Re: [tip: locking/kcsan] READ_ONCE: Use data_race() to avoid KCSAN instrumentation

2020-05-20 Thread Nathan Chancellor
On Thu, May 21, 2020 at 12:17:12AM +0200, Borislav Petkov wrote: > Hi, > > On Tue, May 12, 2020 at 02:36:53PM -, tip-bot2 for Will Deacon wrote: > > The following commit has been merged into the locking/kcsan branch of tip: > > > > Commit-ID: cdd28ad2d8110099e43527e96d059c5639809680 > >

Re: [PATCH] READ_ONCE, WRITE_ONCE, kcsan: Perform checks in __*_ONCE variants

2020-05-19 Thread Nathan Chancellor
On Tue, May 19, 2020 at 11:16:24PM -0400, Qian Cai wrote: > On Tue, May 19, 2020 at 10:47 PM Nathan Chancellor > wrote: > > > > On Tue, May 19, 2020 at 10:28:41PM -0400, Qian Cai wrote: > > > > > > > > > > On May 19, 2020, at 6:05 PM, Thomas Gleixn

Re: [PATCH] READ_ONCE, WRITE_ONCE, kcsan: Perform checks in __*_ONCE variants

2020-05-19 Thread Nathan Chancellor
On Tue, May 19, 2020 at 10:28:41PM -0400, Qian Cai wrote: > > > > On May 19, 2020, at 6:05 PM, Thomas Gleixner wrote: > > > > Yes, it's unfortunate, but we have to stop making major concessions just > > because tools are not up to the task. > > > > We've done that way too much in the past and

Re: [tip:x86/mm 1/23] arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp'

2020-05-19 Thread Nathan Chancellor
On Tue, May 19, 2020 at 10:55:05PM +0200, Borislav Petkov wrote: > On Wed, May 20, 2020 at 01:51:25AM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm > > head: bd1de2a7aace4d1d312fb1be264b8fafdb706208 > > commit:

[tip: x86/urgent] x86/mmiotrace: Use cpumask_available() for cpumask_var_t variables

2020-05-19 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: d7110a26e5905ec2fe3fc88bc6a538901accb72b Gitweb: https://git.kernel.org/tip/d7110a26e5905ec2fe3fc88bc6a538901accb72b Author:Nathan Chancellor AuthorDate:Wed, 08 Apr 2020 13:53:23 -07:00

[PATCH] input: i8042: Remove special PowerPC handling

2020-05-18 Thread Nathan Chancellor
ast 12 years, there is not anyone actually trying to use this driver so we can just remove this special walnut code and use the generic header so it builds for all configurations. Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc") Reported-by: kbuild test robot Signe

Re: [PATCH] powerpc/wii: Fix declaration made after definition

2020-05-18 Thread Nathan Chancellor
On Mon, Apr 13, 2020 at 12:06:45PM -0700, Nathan Chancellor wrote: > A 0day randconfig uncovered an error with clang, trimmed for brevity: > > arch/powerpc/platforms/embedded6xx/wii.c:195:7: error: attribute > declaration must precede definition [-Werror,-Wignore

Re: [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-05-18 Thread Nathan Chancellor
On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false

[PATCH 2/2] clk: bcm2835: Remove casting to bcm2835_clk_register

2020-05-16 Thread Nathan Chancellor
clk_register is in struct bcm2835_clk_desc so we can just remove it and use the type directly. Fixes: 56eb3a2ed972 ("clk: bcm2835: remove use of BCM2835_CLOCK_COUNT in driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1028 Signed-off-by: Nathan Chancellor --- drivers/clk/

[PATCH 1/2] clk: bcm2835: Fix return type of bcm2835_register_gate

2020-05-16 Thread Nathan Chancellor
clk_hw_register_gate anyways but this is needed to avoid issues with further changes. Fixes: b19f009d4510 ("clk: bcm2835: Migrate to clk_hw based registration and OF APIs") Link: https://github.com/ClangBuiltLinux/linux/issues/1028 Signed-off-by: Nathan Chancellor --- drivers/clk/bcm/clk-bcm2

[PATCH] drm/i915: Mark check_shadow_context_ppgtt as maybe unused

2020-05-15 Thread Nathan Chancellor
BuiltLinux/linux/issues/1027 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c index f776c92de8d7..0fb1df71c637 100644 --- a/drive

[PATCH] ethernet: ti: am65-cpts: Add missing inline qualifier to stub functions

2020-05-15 Thread Nathan Chancellor
aprio offload") Link: https://github.com/ClangBuiltLinux/linux/issues/1026 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/ti/am65-cpts.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.h b/drivers/net/ethernet/ti/am65-cp

Re: ld.lld: error: undefined symbol: kb_cs

2020-05-13 Thread Nathan Chancellor
On Thu, May 14, 2020 at 08:13:48AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 24085f70a6e1b0cb647ec92623284641d8270637 > commit: 5990cdee689c6885b27c6d969a3d58b09002b0bc lib/mpi: Fix building for > powerpc with

[PATCH] drm/i915: Remove duplicate inline specifier on write_pte

2020-05-13 Thread Nathan Chancellor
15/gt: Force pte cacheline to main memory") Link: https://github.com/ClangBuiltLinux/linux/issues/1024 Reported-by: kbuild test robot Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH] dm zoned: Avoid 64-bit division error in dmz_fixup_devices

2020-05-13 Thread Nathan Chancellor
it should be using DIV_ROUND_UP_SECTOR_T, which handles this automatically. Fixes: 70978208ec91 ("dm zoned: metadata version 2") Signed-off-by: Nathan Chancellor --- drivers/md/dm-zoned-target.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-zo

Re: [PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-05-12 Thread Nathan Chancellor
On Tue, May 12, 2020 at 10:05:09AM +0200, Thomas Bogendoerfer wrote: > On Tue, Apr 28, 2020 at 03:14:14PM -0700, Nathan Chancellor wrote: > > [..] > > Please let me know if there are any issues! > > I found no issues in my tests. Is this the final state ? If yes, I'm > g

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-08 Thread Nathan Chancellor
On Fri, May 08, 2020 at 11:31:07PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 7:12 AM Nathan Chancellor > wrote: > > > - > > > +#ifdef CONFIG_CC_IS_CLANG > > > > Given your comment in the bug: > > > > "The code is written to ass

Re: [PATCH v5] x86: bitops: fix build regression

2020-05-08 Thread Nathan Chancellor
") > Reported-by: Sedat Dilek > Reported-by: kernelci.org bot > Suggested-by: Andy Shevchenko > Suggested-by: Brian Gerst > Suggested-by: H. Peter Anvin > Suggested-by: Ilie Halip > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Nathan Chan

[PATCH net-next] net: ipa: Remove ipa_endpoint_stop{,_rx_dma} again

2020-05-08 Thread Nathan Chancellor
'net-ipa-kill-endpoint-stop-workaround'"). Remove them again so that the build works properly. Fixes: 3793faad7b5b ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") Signed-off-by: Nathan Chancellor --- drivers/net/ipa/ipa_endpoint.c | 61 --

Re: [PATCH] x86: bitops: fix build regression

2020-05-06 Thread Nathan Chancellor
On Tue, May 05, 2020 at 09:30:28PM -0700, Nathan Chancellor wrote: > On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > > From: Sedat Dilek > > > > It turns out that if your config tickles __builtin_constant_p via > > differences in choices to inlin

Re: [PATCH] leds: lm355x: avoid enum conversion warning

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 04:19:45PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 4:44 AM Nathan Chancellor > wrote: > > > > On Tue, May 05, 2020 at 04:19:17PM +0200, Arnd Bergmann wrote: > > > clang points out that doing arithmetic betwe

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 12:22:58PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 5:45 AM Nathan Chancellor > wrote: > > On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > > > On Tue, 5 May 2020 15:25:56 +0100 Mark Rutland > > > wrote: > &g

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 03:53:45PM +0200, Arnd Bergmann wrote: > When building for ARMv7-M, clang-9 or higher tries to unroll some loops, > which ends up confusing the register allocator to the point of generating > rather bad code and using more than the warning limit for stack frames: > >

Re: [PATCH] x86: bitops: fix build regression

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > From: Sedat Dilek > > It turns out that if your config tickles __builtin_constant_p via > differences in choices to inline or not, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { >

Re: [PATCH v2] security: disable FORTIFY_SOURCE on clang

2020-05-05 Thread Nathan Chancellor
urgess > > Cc: Nick Desaulniers > > Link: https://bugs.llvm.org/show_bug.cgi?id=45802 > > Signed-off-by: Jason A. Donenfeld > > Grudgingly, > > Reviewed-by: Kees Cook > > -- > Kees Cook > I feel like you should finish your investigation into how broken this actually is before we give it the hammer like this but if it is going in regardless... Reviewed-by: Nathan Chancellor

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-05 Thread Nathan Chancellor
+ Fangrui, who implemented patchable_function_entry in LLVM/clang On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > Hi Arnd, Mark and others, > > this may not be worth arguing but I'm currently fighting excessive > workarounds in another area and so this triggers me, so I have to

Re: [PATCH] net: bareudp: avoid uninitialized variable warning

2020-05-05 Thread Nathan Chancellor
t;if(IS_ENABLED())" instead of #if IS_ENABLED()". > > Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling > different protocols like MPLS, IP, NSH etc.") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drive

Re: [PATCH] leds: lm355x: avoid enum conversion warning

2020-05-05 Thread Nathan Chancellor
t; - reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode; > + reg_val = (u32)pdata->pin_tx2 | (u32)pdata->ntc_pin | > + (u32)pdata->pass_mode; > ret = regmap_update_bits(chip->regmap, 0x0A, 0xC4, reg_val); > if (ret < 0) > goto out; > -- > 2.26.0 > With those comments addressed, feel free to add: Reviewed-by: Nathan Chancellor

Re: [PATCH] mtd: lpddr: fix excessive stack usage with clang

2020-05-05 Thread Nathan Chancellor
of the structure to assign > most of the members upfront and then only set the few members that > require runtime knowledge at probe time. > > Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan

Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 03:02:16PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Tue, May 5, 2020 at 2:55 PM Jason A. Donenfeld wrote: > > > > clang-10 has a broken optimization stage that doesn't enable the > > compiler to prove at compile time that certain memcpys are within > >

Re: [PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-05-02 Thread Nathan Chancellor
On Sat, May 02, 2020 at 02:50:34PM +0100, Maciej W. Rozycki wrote: > On Tue, 28 Apr 2020, Nathan Chancellor wrote: > > > Before this patch, LD=ld.lld did nothing: > > > > $ llvm-readelf -p.comment arch/mips/vdso/vdso.so.dbg | sed 's/(.*//' > > String dump of s

Re: [PATCH] x86/boot: allow a relocatable kernel to be linked with lld

2020-05-01 Thread Nathan Chancellor
ith both compilers and their respective linkers did not regress. Tested-by: Nathan Chancellor > --- > arch/x86/boot/compressed/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/boot/compressed/Makefile > b/arch/x86/boot/compressed/Makefile > index 5f7c262bcc9

[PATCH] drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_audio

2020-05-01 Thread Nathan Chancellor
: put the audio codec into suspend state before gpu reset V3") Link: https://github.com/ClangBuiltLinux/linux/issues/1017 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load}

2020-05-01 Thread Nathan Chancellor
so the module build breaks. Export them so that they can be used in modules properly. Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs") Signed-off-by: Nathan Chancellor --- drivers/firmware/xilinx/zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-30 Thread Nathan Chancellor
Hi Michael, On Thu, Apr 30, 2020 at 12:06:09AM +, Michael Kelley wrote: > From: Nathan Chancellor Sent: Tuesday, April 28, > 2020 10:55 AM > > > > Do note that netvsc_xmit still returns int because netvsc_xmit has a > > potential return from netvsc_vf_xmi

Re: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 06:46:33PM +0100, Maciej W. Rozycki wrote: > On Mon, 27 Apr 2020, Nathan Chancellor wrote: > > > > Can you actually record in the change description what the difference in > > > the relevant link command is, as shown where `V=1' has bee

Re: [PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:04:42AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > Patch 1 adds ld.lld support to Kconfig so that we can avoid certain > > ld.bfd checks. > > > > Is it possible to introduce and

Re: [PATCH v4 1/5] kbuild: add CONFIG_LD_IS_LLD

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:13:40AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > > From: Sami Tolvanen > > > > Similarly to the CC_IS_CLANG config, add LD_IS_LLD to avoid GNU ld > > specific logic such as

[PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Nathan Chancellor
should have been assigned to rpcurupei. Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies") Link: https://github.com/ClangBuiltLinux/linux/issues/1016 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 2 +- 1 file

<    1   2   3   4   5   6   7   8   9   10   >