Re: linux-next: Tree for Apr 28

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 06:24:21PM -0700, Minchan Kim wrote: > Hello, > > On Tue, Apr 28, 2020 at 12:04:59PM -0700, Nathan Chancellor wrote: > > On Tue, Apr 28, 2020 at 06:10:06PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since

Re: [PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 03:54:01PM -0700, Fangrui Song wrote: > > On 2020-04-28, Nathan Chancellor wrote: > > Currently, the VDSO is being linked through $(CC). This does not match > > how the rest of the kernel links objects, which is through the $(LD) > > variable. >

[PATCH v4 3/5] MIPS: Unconditionally specify '-EB' or '-EL'

2020-04-28 Thread Nathan Chancellor
/mips/vdso/elf.o: endianness incompatible with that of the selected emulation mips64-linux-ld: failed to merge target specific data of file arch/mips/vdso/elf.o ... Remove this legacy hack and just use '-EB' and '-EL' unconditionally. Reported-by: Thomas Bogendoerfer Signed-off-by: Nathan

[PATCH v4 2/5] MIPS: VDSO: Move disabling the VDSO logic to Kconfig

2020-04-28 Thread Nathan Chancellor
MIPS VDSO binutils warning and linking the VDSO when LD is ld.lld. Wrapping the call to ld-ifversion with CONFIG_LD_IS_LLD does not work because the config values are wiped away during 'make clean'. Signed-off-by: Nathan Chancellor --- v3 -> v4: * No changes. v2 -> v3: * Fix CONFIG macro i

[PATCH v4 1/5] kbuild: add CONFIG_LD_IS_LLD

2020-04-28 Thread Nathan Chancellor
-by: Masahiro Yamada [nc: Reword commit message] Signed-off-by: Nathan Chancellor --- v3 -> v4: * No changes. v2 -> v3: * Add Masahiro's ack. v1 -> v2: * No changes. Sami, please scream if you are unhappy with how I worded this commit. init/Kconfig | 3 +++ 1 file changed, 3 insertions(+) d

[PATCH v4 4/5] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-28 Thread Nathan Chancellor
vdso.so.dbg | sed 's/(.*//' String dump of section '.comment': [ 0] Linker: LLD 11.0.0 [62] ClangBuiltLinux clang version 11.0.0 Link: https://github.com/ClangBuiltLinux/linux/issues/785 Signed-off-by: Nathan Chancellor --- v3 -> v4: * Improve commit message to show that ld command is effectivel

[PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-04-28 Thread Nathan Chancellor
Hi all, This series allows ld.lld to properly and completely link the MIPS vDSO. Patch 1 adds ld.lld support to Kconfig so that we can avoid certain ld.bfd checks. Patch 2 moves disabling of the VDSO to Kconfig. This allows us to avoid a warning with LD=ld.lld during the clean phase, when we do

[PATCH v4 5/5] MIPS: VDSO: Allow ld.lld to link the VDSO

2020-04-28 Thread Nathan Chancellor
C32 _start Reported-by: Dmitry Golovin Signed-off-by: Nathan Chancellor Link: https://github.com/ClangBuiltLinux/linux/issues/785 Link: https://github.com/llvm/llvm-project/commit/e364e2e9ce50c12eb2bf093560e1a1a8544d455a --- v3 -> v4: * No changes. v2 -> v3: * No changes. v1 ->

Re: linux-next: Tree for Apr 28

2020-04-28 Thread Nathan Chancellor
On Tue, Apr 28, 2020 at 06:10:06PM +1000, Stephen Rothwell wrote: > Hi all, > > Changes since 20200424: > > The qcom tree still had its build failure for which I reverted a commit. > > The hwmon-staging tree gained a build failure for which I reverted > a commit. > > The mac80211-next tree

[PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-28 Thread Nathan Chancellor
a943d8 ("Staging: hv: add the Hyper-V virtual network driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1009 Signed-off-by: Nathan Chancellor --- v1 -> v2: * Move splat into commit message rather than issue. Comment from previous version: Do note that netvsc_xmit still

[PATCH] dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show

2020-04-28 Thread Nathan Chancellor
dd channel stat to debugfs") Link: https://github.com/ClangBuiltLinux/linux/issues/1012 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dp

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:59:23PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > >

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also have supported s3c6400 as well. > > > Kc

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > > On 22-10-19, 17:09, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-pointer-compare: > > > > > > dri

[PATCH] rtlwifi: Remove unnecessary NULL check in rtl_regd_init

2019-10-22 Thread Nathan Chancellor
s://github.com/ClangBuiltLinux/linux/issues/750 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/realtek/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c b/drivers/net/wireless/realtek/rtlwifi/regd.c ind

[PATCH] usb: gadget: udc: bdc: Remove unnecessary NULL checks in bdc_req_complete

2019-10-22 Thread Nathan Chancellor
gBuiltLinux/linux/issues/749 Signed-off-by: Nathan Chancellor --- Note: I am not sure if these checks were intended to check if the contents of these arrays were NULL or if there should be some other checks in lieu of these; I am not familiar with the USB subsystem to answer this but I w

[PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-22 Thread Nathan Chancellor
ink: https://github.com/ClangBuiltLinux/linux/issues/748 Signed-off-by: Nathan Chancellor --- drivers/cpufreq/s3c64xx-cpufreq.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c index af0c00dabb22..c6bdfc308e99 100644 ---

[PATCH] kernel/profile: Use cpumask_available to check for NULL cpumask

2019-10-22 Thread Nathan Chancellor
2 ("cpumask: Add helper cpumask_available()") to fix warnings like this while keeping the code the same. Link: https://github.com/ClangBuiltLinux/linux/issues/747 Signed-off-by: Nathan Chancellor --- kernel/profile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH -next] dmaengine: fsl-dpaa2-qdma: Remove unnecessary local variables in DPDMAI_CMD_CREATE macro

2019-10-22 Thread Nathan Chancellor
ning. Fixes: f2835adf8afb ("dmaengine: fsl-dpaa2-qdma: Add the DPDMAI(Data Path DMA Interface) support") Link: https://github.com/ClangBuiltLinux/linux/issues/746 Signed-off-by: Nathan Chancellor --- drivers/dma/fsl-dpaa2-qdma/dpdmai.c | 4 +--- 1 file changed, 1 insertion(+), 3 de

[PATCH] clk: sunxi: Fix operator precedence in sunxi_divs_clk_setup

2019-10-22 Thread Nathan Chancellor
n was set; right now, | is being evaluated first. Add parentheses around the ?: block to have it be evaluated first. Fixes: 9919d44ff297 ("clk: sunxi: Use CLK_IS_CRITICAL flag for critical clks") Link: https://github.com/ClangBuiltLinux/linux/issues/745 Signed-off-by: Nathan Chancellor ---

Re: [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-21 Thread Nathan Chancellor
On Fri, Oct 18, 2019 at 03:02:10PM -0500, Segher Boessenkool wrote: > On Fri, Oct 18, 2019 at 12:00:22PM -0700, Nathan Chancellor wrote: > > Just as an FYI, there was some more discussion around the availablity > > and use of bcmp in this LLVM bug which spawned > > comm

[PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to_bootloader

2019-10-18 Thread Nathan Chancellor
Signed-off-by: Nathan Chancellor --- drivers/bluetooth/btintel.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h index d2311156f778..a69ea8a87b9b 100644 --- a/drivers/bluetooth/btintel.h +++ b/drivers/bluetooth/btintel.h @@ -185,6 +185,5 @@ sta

Re: [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-18 Thread Nathan Chancellor
On Mon, Oct 14, 2019 at 02:11:41PM -0500, Segher Boessenkool wrote: > On Mon, Oct 14, 2019 at 08:56:12AM -0700, Nick Desaulniers wrote: > > On Mon, Oct 14, 2019 at 2:35 AM Segher Boessenkool > > wrote: > > > > > > On Sun, Oct 13, 2019 at 07:51:01PM -0700, Nathan

Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-16 Thread Nathan Chancellor
On Wed, Oct 16, 2019 at 05:09:30PM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2019-10-16 at 16:08 +0100, Catalin Marinas wrote: > > On Wed, Oct 16, 2019 at 07:47:14AM -0700, Nathan Chancellor wrote: > > > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32

[PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-16 Thread Nathan Chancellor
generated. Add __maybe_unused to make this clear to the compiler. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix check for CONFIG_ZONE_DMA32 as pointed out by Will. v2 -> v3: * Use __maybe_unused a

[PATCH -next v2] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
generated. Add an ifdef around the variable to fix this. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix check for CONFIG_ZONE_DMA32 as pointed out by Will. arch/arm64/mm/init.c | 2 ++ 1 file changed, 2 insertions(+

Re: [PATCH -next] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
On Wed, Oct 16, 2019 at 04:00:52AM +0100, Will Deacon wrote: > On Tue, Oct 15, 2019 at 03:43:04PM -0700, Nathan Chancellor wrote: > > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32 > > get disabled so there is a warning about max_dma being unused. > >

[PATCH -next] arm64: mm: Fix unused variable warning in zone_sizes_init

2019-10-15 Thread Nathan Chancellor
generated. Add an ifdef around the variable to fix this. Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32") Signed-off-by: Nathan Chancellor --- arch/arm64/mm/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 44

[PATCH v4 1/3] powerpc: Don't add -mabi= flags when building with Clang

2019-10-13 Thread Nathan Chancellor
ed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message v2 -> v3: * Rebase and merge into a single series. v3 -> v4: * Rebase on v5.4-rc3. * Update links to point to llvmorg-9.0.0 instead of llvmorg-9.0.0-rc2. arch/powerpc/Makefile | 4

[PATCH v4 2/3] powerpc: Avoid clang warnings around setjmp and longjmp

2019-10-13 Thread Nathan Chancellor
ect/commit/3be25e79477db2d31ac46493d97eca8c20592b07 Link: https://godbolt.org/z/B2oQnl Suggested-by: Segher Boessenkool Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v3 (I skipped v2 because the first patch in the series already had a v2): * Use -ffreesta

[PATCH v4 0/3] LLVM/Clang fixes for pseries_defconfig

2019-10-13 Thread Nathan Chancellor
Hi all, This series includes a set of fixes for LLVM/Clang when building pseries_defconfig. These have been floating around as standalone patches so I decided to gather them up as a series so it was easier to review/apply them. This has been broken for a bit now, it would be nice to get these

[PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-13 Thread Nathan Chancellor
ee to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/76cdcf25b883751d83402baea6316772aa73865c Reviewed-by: Nick Desaulneris Signed-off-by: Nathan Chancellor --- v1 -> v3: * New patch in the series v3 -> v4:

Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-13 Thread Nathan Chancellor
On Sat, Oct 12, 2019 at 05:59:18PM +0530, Shyam Saini wrote: > This parameters are not changed after early boot. > By making them __ro_after_init will reduce any attack surface in the > kernel. > > Link: https://lwn.net/Articles/676145/ > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin

[PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop_hc

2019-10-11 Thread Nathan Chancellor
_stop_hc()") Signed-off-by: Nathan Chancellor --- drivers/usb/host/ohci-at91.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 513e48397743..b635c6a1b1a9 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at9

[PATCH] mips: Fix unroll macro when building with Clang

2019-10-10 Thread Nathan Chancellor
(although MIPS wasn't buildable until Clang 9); building a kernel with Clang 9.0.0 has no issues after this change. Fixes: 6baaeadae911 ("MIPS: Provide unroll() macro, use it for cache ops") Link: https://github.com/ClangBuiltLinux/linux/issues/736 Signed-off-by: Nathan Chancellor --- arc

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Nathan Chancellor
On Tue, Oct 08, 2019 at 04:59:25PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > On Tue, Oct 8, 2019 at 4:31 PM Andrew Murray wrote: > > This looks good to me. I can build and boot in a model with both Clang > > (9.0.6) and GCC (7.3.1) and boot a guest without anything going bang. > >

Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Nathan Chancellor
On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: > Since we link purgatory.ro with -r aka we enable "incremental linking" > no checks for unresolved symbols is done while linking purgatory.ro. > > Changes to the sha256 code has caused the purgatory in 5.4-rc1 to have > a missing

Re: [PATCH] lib: test_user_copy: style cleanup

2019-10-05 Thread Nathan Chancellor
d-off-by: Aleksa Sarai I assume the comment diff is a line length/alignment thing? The commit message does not mention it. Regardless, thank you for providing the fix that I should have. Reviewed-by: Nathan Chancellor

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Nathan Chancellor
On Fri, Oct 04, 2019 at 10:53:41AM -0700, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > >The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition

[PATCH] usercopy: Add parentheses around assignment in test_copy_struct_from_user

2019-10-03 Thread Nathan Chancellor
hub.com/ClangBuiltLinux/linux/issues/731 Signed-off-by: Nathan Chancellor --- lib/test_user_copy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_user_copy.c b/lib/test_user_copy.c index 950ee88cd6ac..e365ace06538 100644 --- a/lib/test_user_copy.c +++ b/lib/test_us

Re: [PATCH AUTOSEL 4.14 08/23] ARM: 8875/1: Kconfig: default to AEABI w/ Clang

2019-09-29 Thread Nathan Chancellor
On Sun, Sep 29, 2019 at 01:35:18PM -0400, Sasha Levin wrote: > From: Nick Desaulniers > > [ Upstream commit a05b9608456e0d4464c6f7ca8572324ace57a3f4 ] > > Clang produces references to __aeabi_uidivmod and __aeabi_idivmod for > arm-linux-gnueabi and arm-linux-gnueabihf targets incorrectly when

[PATCH] tools/power/cpupower: Fix initializer override in hsw_ext_cstates

2019-09-27 Thread Nathan Chancellor
thub.com/ClangBuiltLinux/linux/issues/718 Signed-off-by: Nathan Chancellor --- tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c b/tools/power/cpupower/utils/idle_monitor/hsw

[PATCH v2] tracing: Fix clang -Wint-in-bool-context warnings in IF_ASSIGN macro

2019-09-26 Thread Nathan Chancellor
ment to fix the warnings and find potential issues in the future. Link: https://github.com/llvm/llvm-project/commit/28b38c277a2941e9e891b2db30652cfd962f070b Link: https://github.com/ClangBuiltLinux/linux/issues/686 Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 ->

[PATCH] tracing: Fix clang -Wint-in-bool-context warnings in IF_ASSIGN macro

2019-09-25 Thread Nathan Chancellor
N statement to fix the warnings. Link: https://github.com/llvm/llvm-project/commit/28b38c277a2941e9e891b2db30652cfd962f070b Link: https://github.com/ClangBuiltLinux/linux/issues/686 Signed-off-by: Nathan Chancellor --- kernel/trace/trace.h | 10 +- 1 file changed, 5 insertions(+), 5 deletio

Request for inclusion of f73b3cc39c84 ("objtool: Clobber user CFLAGS variable") in -stable

2019-09-25 Thread Nathan Chancellor
Hi Greg and Sasha, We received a report of an objtool build failure with clang related to -Wunused-parameter [1], which turned out to be related to the distro's CFLAGS. Josh patched this up in commit f73b3cc39c84 ("objtool: Clobber user CFLAGS variable"), could it be added to -stable whenever

Re: [PATCH] x86, realmode: explicitly set ENTRY in linker script

2019-09-24 Thread Nathan Chancellor
On Mon, Sep 23, 2019 at 03:24:02PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > Linking with ld.lld via $ make LD=ld.lld produces the warning: > ld.lld: warning: cannot find entry symbol _start; defaulting to 0x1000 > > Linking with ld.bfd shows the default entry is 0x1000: > $

Re: [PATCH] powerpc/pmac/smp: avoid unused-variable warnings

2019-09-20 Thread Nathan Chancellor
sed-variable] > > They are only used when CONFIG_PPC64 is not defined. Move > them into a section which does the same macro check. > > Reported-by: Nathan Chancellor > Signed-off-by: Ilie Halip Reviewed-by: Nathan Chancellor

Re: [PATCH] hugetlbfs: hugetlb_fault_mutex_hash cleanup

2019-09-18 Thread Nathan Chancellor
issue, noticed that the 'address' parameter > to hugetlb_fault_mutex_hash is no longer used. So, remove it from the > definition and all callers. > > No functional change. > > Reported-by: Nathan Chancellor > Signed-off-by: Mike Kravetz Thanks for the patch! Reviewed-by: Nathan Chancellor

Re: [PATCH] [v2] arm64: fix unreachable code issue with cmpxchg

2019-09-18 Thread Nathan Chancellor
On Wed, Sep 18, 2019 at 10:02:41AM +0100, Will Deacon wrote: > On Tue, Sep 17, 2019 at 01:34:25PM -0700, Nathan Chancellor wrote: > > On Tue, Sep 10, 2019 at 01:56:22PM +0200, Arnd Bergmann wrote: > > > On arm64 build with clang, sometimes the __cmpxchg_mb is not

[PATCH] libnvdimm/nfit_test: Fix acpi_handle redefinition

2019-09-17 Thread Nathan Chancellor
sues/660 Signed-off-by: Nathan Chancellor --- I know that every maintainer has their own thing with the number of includes in each header file; this issue can be solved in a various number of ways, I went with the smallest diff stat. Please solve it in a different way if you see fit :) tools/testing/nvdi

[PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident

2019-09-17 Thread Nathan Chancellor
ink: https://github.com/ClangBuiltLinux/linux/issues/658 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pens

Re: [PATCH] [v2] arm64: fix unreachable code issue with cmpxchg

2019-09-17 Thread Nathan Chancellor
; Mark all of the cmpxchg() style functions as __always_inline to > ensure that the compiler can see the result. > > Acked-by: Nick Desaulniers > Reported-by: Nathan Chancellor > Link: https://github.com/ClangBuiltLinux/linux/issues/648 > Reviewed-by: Nathan Chancellor > Test

Re: [PATCH v3 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-09-11 Thread Nathan Chancellor
On Wed, Sep 11, 2019 at 02:01:59PM -0700, Nick Desaulniers wrote: > On Wed, Sep 11, 2019 at 11:21 AM Nathan Chancellor > wrote: > > > > r370454 gives LLVM the ability to convert certain loops into a reference > > to bcmp as an optimization; this breaks prom_init_check.sh

[PATCH v3 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-09-11 Thread Nathan Chancellor
ee to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/5c9f3cfec78f9e9ae013de9a0d092a68e3e79e002 Signed-off-by: Nathan Chancellor --- New patch in the series so no previous version. arch/powerpc/kernel/Makefile | 2

[PATCH v3 1/3] powerpc: Don't add -mabi= flags when building with Clang

2019-09-11 Thread Nathan Chancellor
/issues/240 Reviewed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message v2 -> v3: * Rebase and merge into a single series. arch/powerpc/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/Makefile b/arch/powerpc/M

[PATCH v3 2/3] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-11 Thread Nathan Chancellor
ect/commit/3be25e79477db2d31ac46493d97eca8c20592b07 Suggested-by: Segher Boessenkool Signed-off-by: Nathan Chancellor --- v1 -> v3: * Use -ffreestanding instead of outright disabling the warning because it is legitimate. I skipped v2 because the first patch in the series already had a v2.

[PATCH v3 0/3] LLVM/Clang fixes for pseries_defconfig

2019-09-11 Thread Nathan Chancellor
Hi all, This series includes a set of fixes for LLVM/Clang when building pseries_defconfig. These have been floating around as standalone patches so I decided to gather them up as a series so it was easier to review/apply them. The versioning is a bit wonky because of this reason, I have included

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-10 Thread Nathan Chancellor
On Wed, Sep 11, 2019 at 04:30:38AM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > On Wed, Sep 04, 2019 at 08:01:35AM -0500, Segher Boessenkool wrote: > >> On Wed, Sep 04, 2019 at 08:16:45AM +, David Laight wrote: > >> > From: Nathan Chancellor [m

Re: [PATCH] arm64: fix unreachable code issue with cmpxchg

2019-09-09 Thread Nathan Chancellor
; Mark all of the cmpxchg() style functions as __always_inline to > ensure that the compiler can see the result. > > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor

Re: [PATCH net-next 1/2] mlx5: steering: use correct enum type

2019-09-09 Thread Nathan Chancellor
a couple of days ago: https://lore.kernel.org/netdev/20190905014733.17564-1-natechancel...@gmail.com/ I don't care which patch goes in since they are the same thing so: Reviewed-by: Nathan Chancellor

[PATCH] net/mlx5: Fix addr's type in mlx5dr_icm_dm

2019-09-04 Thread Nathan Chancellor
("net/mlx5: DR, ICM pool memory allocator") Link: https://github.com/ClangBuiltLinux/linux/issues/653 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethern

[PATCH] net/mlx5: Fix rt's type in dr_action_create_reformat_action

2019-09-04 Thread Nathan Chancellor
so there are no warnings about mismatched types. Fixes: 9db810ed2d37 ("net/mlx5: DR, Expose steering action functionality") Link: https://github.com/ClangBuiltLinux/linux/issues/652 Signed-off-by: Nathan Chancellor --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c | 2 +- 1 fi

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-04 Thread Nathan Chancellor
On Wed, Sep 04, 2019 at 08:01:35AM -0500, Segher Boessenkool wrote: > On Wed, Sep 04, 2019 at 08:16:45AM +, David Laight wrote: > > From: Nathan Chancellor [mailto:natechancel...@gmail.com] > > > Fair enough so I guess we are back to just outright disabling the > >

Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-04 Thread Nathan Chancellor
On Wed, Sep 04, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > On Sat, Aug 31, 2019 at 6:26 PM Masahiro Yamada > wrote: > > > +# Some diagnostics enabled by default are noisy. > > +# Suppress them by using -Wno... except for W=1. > > + > > ifdef CONFIG_CC_IS_CLANG > > KBUILD_CFLAGS +=

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-03 Thread Nathan Chancellor
On Tue, Sep 03, 2019 at 02:31:28PM -0500, Segher Boessenkool wrote: > On Mon, Sep 02, 2019 at 10:55:53PM -0700, Nathan Chancellor wrote: > > On Thu, Aug 29, 2019 at 09:59:48AM +, David Laight wrote: > > > From: Nathan Chancellor > > > > Sent: 28 August 2019 19:4

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-02 Thread Nathan Chancellor
On Thu, Aug 29, 2019 at 09:59:48AM +, David Laight wrote: > From: Nathan Chancellor > > Sent: 28 August 2019 19:45 > ... > > However, I think that -fno-builtin-* would be appropriate here because > > we are providing our own setjmp implementation, meaning clang should

Re: [PATCH] staging: exfat: fix uninitialized variable ret

2019-09-02 Thread Nathan Chancellor
note: remove the 'if' if its condition is always true if (p_fs->dev_ejected) ^~ drivers/staging/exfat/exfat_super.c:776:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 1 warning generated. Reviewed-by: Nathan Chancellor

[PATCH v2] ARM: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer

2019-08-31 Thread Nathan Chancellor
Reviewed-by: Nick Desaulniers Reviewed-by: Stefan Agner Signed-off-by: Nathan Chancellor --- v1 -> v2: * Add Nick and Stefan's reviewed by tags * Move version check from Makefile to Kconfig. This prevents '-pg` from ever being added if '-meabi gnu' would produce a non-booting ker

Re: [PATCH] ARM: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer

2019-08-30 Thread Nathan Chancellor
On Thu, Aug 29, 2019 at 01:57:35PM -0700, Nick Desaulniers wrote: > On Thu, Aug 29, 2019 at 1:21 PM Stefan Agner wrote: > > > > On 2019-08-29 21:34, Nathan Chancellor wrote: > > > On Thu, Aug 29, 2019 at 10:55:28AM -0700, Nick Desaulniers wrote: > > >> On

Re: [PATCH] ARM: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer

2019-08-29 Thread Nathan Chancellor
On Thu, Aug 29, 2019 at 10:55:28AM -0700, Nick Desaulniers wrote: > On Wed, Aug 28, 2019 at 11:27 PM Nathan Chancellor > wrote: > > > > Currently, multi_v7_defconfig + CONFIG_FUNCTION_TRACER fails to build > > with clang: > > > > arm-linux-gnuea

[PATCH] ARM: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer

2019-08-29 Thread Nathan Chancellor
/issues/35 Link: https://bugs.llvm.org/show_bug.cgi?id=33845 Link: https://github.com/llvm/llvm-project/commit/16fa8b09702378bacfa3d07081afe6b353b99e60 Signed-off-by: Nathan Chancellor --- arch/arm/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/Makefile b/arch/arm/Makefile

Re: [PATCH 2/2] kbuild: allow Clang to find unused static inline functions for W=1 build

2019-08-28 Thread Nathan Chancellor
On Wed, Aug 28, 2019 at 04:28:30PM -0700, Nick Desaulniers wrote: > On Wed, Aug 28, 2019 at 11:20 AM Nathan Chancellor > wrote: > > > > On Wed, Aug 28, 2019 at 02:54:25PM +0900, Masahiro Yamada wrote: > > > GCC and Clang have different policy for -Wunused-function; GCC

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-08-28 Thread Nathan Chancellor
On Wed, Aug 28, 2019 at 11:01:14AM -0700, Nick Desaulniers wrote: > On Wed, Aug 28, 2019 at 10:53 AM Nathan Chancellor > wrote: > > > > On Wed, Aug 28, 2019 at 11:43:53PM +1000, Michael Ellerman wrote: > > > Nathan Chancellor writes: > > > > > > >

Re: [PATCH 2/2] kbuild: allow Clang to find unused static inline functions for W=1 build

2019-08-28 Thread Nathan Chancellor
ce it is not a good idea to sprinkle warnings for the > normal build. > > My initial attempt was to add -Wno-unused-function for no W=1 build > (https://lore.kernel.org/patchwork/patch/1120594/) > > Nathan Chancellor pointed out that would weaken Clang's checks since > we woul

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Nathan Chancellor
t behavior since each warning belongs > to only one warning level. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-08-28 Thread Nathan Chancellor
On Wed, Aug 28, 2019 at 11:43:53PM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > > Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when > > setjmp is used") disabled -Wbuiltin-requires-header because of a warning > > about t

Re: [PATCH v2] kbuild: enable unused-function warnings for W= build with Clang

2019-08-27 Thread Nathan Chancellor
On Tue, Aug 27, 2019 at 01:58:05PM -0700, Nick Desaulniers wrote: > On Tue, Aug 27, 2019 at 12:28 PM Nathan Chancellor > wrote: > > > > On Tue, Aug 27, 2019 at 07:36:21PM +0900, Masahiro Yamada wrote: > > > GCC and Clang have different policy for -Wunused-function; GCC

Re: [PATCH v2] kbuild: enable unused-function warnings for W= build with Clang

2019-08-27 Thread Nathan Chancellor
tform/x86: mlx-platform: Properly use > mlxplat_mlxcpld_msn201x_items"). (pointed out by Nathan Chancellor) > I added -Wunneeded-internal-declaration to address it. > > If you contribute to code clean-up, please run "make CC=clang W=1" > and check -Wunused-functi

[PATCH] kbuild: Do not enable -Wimplicit-fallthrough for clang for now

2019-08-26 Thread Nathan Chancellor
resolved. Suggested-by: Masahiro Yamada Signed-off-by: Nathan Chancellor --- Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index f125625efd60..6007a56bdbee 100644 --- a/Makefile +++ b/Makefile @@ -751,6 +751,11 @@ else # These warnings gene

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-08-26 Thread Nathan Chancellor
On Sun, Aug 11, 2019 at 07:32:15PM -0700, Nathan Chancellor wrote: > Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when > setjmp is used") disabled -Wbuiltin-requires-header because of a warning > about the setjmp and longjmp declarations. > > r3673

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-08-26 Thread Nathan Chancellor
On Mon, Aug 26, 2019 at 12:42:28PM -0300, Jason Gunthorpe wrote: > On Mon, Aug 26, 2019 at 08:38:00AM -0700, Nathan Chancellor wrote: > > On Fri, Aug 23, 2019 at 11:24:27AM -0300, Jason Gunthorpe wrote: > > > The latest clang-9 packages from apt.llvm.org do seem to build the &

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-08-26 Thread Nathan Chancellor
Hi Jason, On Fri, Aug 23, 2019 at 11:24:27AM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 10:30:30AM -0700, Nathan Chancellor wrote: > > On Thu, Jul 11, 2019 at 02:18:08PM -0300, Jason Gunthorpe wrote: > > > On Thu, Jul 11, 2019 at 10:16:44AM -0700, Nick

Re: [PATCH] bus: imx-weim: remove __init from 2 functions

2019-08-26 Thread Nathan Chancellor
seem to be used anywhere else. > > Signed-off-by: Ilie Halip > Reported-by: "kernelci.org bot" > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: clang-built-li...@googlegroups.com > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Nathan Chancellor

Re: [PATCH v3] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-22 Thread Nathan Chancellor
On Thu, Aug 22, 2019 at 01:02:05PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Thu, Aug 22, 2019 at 11:30 AM Nathan Huckleberry wrote: > > > > The stackframe setup when compiled with clang is different. > > Since the stack unwinder expects the gcc stackframe setup it > > fails to

[PATCH v2] powerpc: Don't add -mabi= flags when building with Clang

2019-08-20 Thread Nathan Chancellor
/issues/240 Reviewed-by: Daniel Axtens Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit message wording and explanation. * Add Daniel's reviewed-by. arch/powerpc/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Make

Re: [PATCH] phy-rockchip-inno-hdmi: Fix RK3328_TERM_RESISTOR_CALIB_SPEED_7_0's third value

2019-08-20 Thread Nathan Chancellor
On Wed, Aug 07, 2019 at 12:23:05PM -0700, Nathan Chancellor wrote: > After commit "linux/bits.h: Add compile time sanity check of GENMASK > inputs" [1], arm64 defconfig builds started failing: > > In file included from ../include/linux/bits.h:22, > from

Re: [PATCH] powerpc: Don't add -mabi= flags when building with Clang

2019-08-20 Thread Nathan Chancellor
On Tue, Aug 20, 2019 at 07:40:33AM -0500, Segher Boessenkool wrote: > On Mon, Aug 19, 2019 at 08:15:38PM -0700, Nathan Chancellor wrote: > > On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote: > > > On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor w

Re: Enabling UBSAN breaks KCOV in clang (8.0.*) on arm64

2019-08-20 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 05:59:48PM +0100, Mark Rutland wrote: > Hi, > > I found that when I enable both KCOV and UBSAN on arm64, clang fails to > emit any __sanitizer_cov_trace_*() calls in the resulting binary, > rendering KCOV useless. > > For example, when building v5.3-rc3's

Re: [PATCH] powerpc: Don't add -mabi= flags when building with Clang

2019-08-19 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote: > On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote: > > When building pseries_defconfig, building vdso32 errors out: > > > > error: unknown target ABI 'elfv1' > > > > C

Re: [PATCH] kbuild: enable unused-function warnings for W= build with Clang

2019-08-19 Thread Nathan Chancellor
On Tue, Aug 20, 2019 at 01:58:26AM +0900, Masahiro Yamada wrote: > Hi Nathan, > > On Tue, Aug 20, 2019 at 1:09 AM Nathan Chancellor > wrote: > > > > On Mon, Aug 19, 2019 at 07:51:38PM +0900, Masahiro Yamada wrote: > > > GCC and Clang have different polic

Re: [PATCH] kbuild: enable unused-function warnings for W= build with Clang

2019-08-19 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 07:51:38PM +0900, Masahiro Yamada wrote: > GCC and Clang have different policy for -Wunused-function; GCC does > not report unused-function warnings at all for the functions marked > as 'static inline'. Clang does report unused-function warnings if they > are defined in

[PATCH] test_bpf: Fix a new clang warning about xor-ing two numbers

2019-08-18 Thread Nathan Chancellor
/920890e26812f808a74c60ebc14cc636dac661c1 Signed-off-by: Nathan Chancellor --- I highly doubt that 1e300 was intented but if it was (or something else was), please let me know. Commit history wasn't entirely clear on why this expression was used over just a raw number. lib/test_bpf.c | 2 +- 1

[PATCH] powerpc: Don't add -mabi= flags when building with Clang

2019-08-18 Thread Nathan Chancellor
8abecde8ad ("powerpc: Don't use gcc specific options on clang"). pseries_defconfig successfully builds after this patch and powernv_defconfig and ppc44x_defconfig don't regress. Link: https://github.com/ClangBuiltLinux/linux/issues/240 Signed-off-by: Nathan Chancellor --- arch/powerpc/

Re: [PATCH v2] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-18 Thread Nathan Chancellor
gt; > > > Signed-off-by: Nathan Huckleberry > > Suggested-by: Nathan Chancellor > > Reviewed-by: Nathan Chancellor > > --- > > Changes v1->v2 > > * Move code to preexisting ifdef > > scripts/Makefile.extrawarn | 1 + > > 1 file changed, 1 ins

Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Nathan Chancellor
_CLANG section of scripts/Makefile.extrawarn * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang") for the time being and just rely on adding -Wimplicit-fallthrough to KCFLAGS for testing. Regardless: Reviewed-by: Nathan Chancellor

Re: Explicitly marking initializer overrides (was "Re: [PATCH] arm64/cache: silence -Woverride-init warnings")

2019-08-14 Thread Nathan Chancellor
On Fri, Aug 09, 2019 at 09:32:51AM +0100, Mark Rutland wrote: > On Thu, Aug 08, 2019 at 10:09:16AM -0700, Nathan Chancellor wrote: > > On Thu, Aug 08, 2019 at 11:38:08AM +0100, Mark Rutland wrote: > > > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > > >

[PATCH] netfilter: nft_bitwise: Adjust parentheses to fix memcmp size argument

2019-08-14 Thread Nathan Chancellor
ys be true because sizeof is a non-zero number). Fixes: bd8699e9e292 ("netfilter: nft_bitwise: add offload support") Link: https://github.com/ClangBuiltLinux/linux/issues/638 Reported-by: kbuild test robot Signed-off-by: Nathan Chancellor --- net/netfilter/nft_bitwise.c | 4 ++-- 1 file

Re: [alsa-devel] [PATCH] soundwire: Don't build sound.o without CONFIG_ACPI

2019-08-13 Thread Nathan Chancellor
On Wed, Aug 14, 2019 at 09:29:47AM +0530, Vinod Koul wrote: > On 13-08-19, 09:22, Pierre-Louis Bossart wrote: > > On 8/13/19 1:10 AM, Nathan Chancellor wrote: > > > clang warns when CONFIG_ACPI is unset: > > > > > > ../drivers/soundwire/slave.c:16:12: warning:

[PATCH v2] soundwire: Make slave.o depend on ACPI and rename to acpi_slave.o

2019-08-13 Thread Nathan Chancellor
: https://github.com/ClangBuiltLinux/linux/issues/637 Signed-off-by: Nathan Chancellor --- v1 -> v2: * Rename slave.o to acpi_slave.o * Reword commit message to reflect this drivers/soundwire/Makefile | 6 +- drivers/soundwire/{slave.c => acpi_slave.c} | 3 --- 2 f

Re: [alsa-devel] [PATCH] soundwire: Don't build sound.o without CONFIG_ACPI

2019-08-13 Thread Nathan Chancellor
On Tue, Aug 13, 2019 at 09:22:29AM -0500, Pierre-Louis Bossart wrote: > On 8/13/19 1:10 AM, Nathan Chancellor wrote: > > clang warns when CONFIG_ACPI is unset: > > > > ../drivers/soundwire/slave.c:16:12: warning: unused function > > 'sdw_slave_add' [-Wunused-function] &

<    2   3   4   5   6   7   8   9   10   11   >