-off-by: NeilBrown
---
drivers/staging/lustre/lustre/include/lustre_dlm.h |9 ++-
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 61
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h |4 +
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 11 ++--
drivers
.
- the various functions for allocating an ldlm_interval
and attaching to a lock or detaching from a lock
are also gone.
Signed-off-by: NeilBrown
---
.../staging/lustre/lustre/include/interval_tree.h |4 +
drivers/staging/lustre/lustre/include/lustre_dlm.h | 12 ---
drivers/staging/lustre/lustre
but noticed interval-tree and
decided I should deal with that first. So I added the
interval-tree clean-up. That set is more work to review,
so I put it first.
Comments welcome,
Thanks,
NeilBrown
---
NeilBrown (11):
staging: lustre: simplify use of interval-tree.
staging: lustre
-off-by: NeilBrown
---
drivers/staging/lustre/lustre/include/lustre_dlm.h |9 ++-
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 61
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h |4 +
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 11 ++--
drivers
The name of the function lock_matches() sounds like it
performs a test (it does) and so should return a bool.
Returning a bool gives a slight code simplification (in
search_queue) and more simplification in future patches.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/ldlm
There are no remaining users for this library,
so discard it.
Signed-off-by: NeilBrown
---
.../staging/lustre/lustre/include/interval_tree.h | 119
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 590
drivers/staging/lustre/lustre/ptlrpc/Makefile |1
as we need 64bit endpoints and it only provides "unsigned long".
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/llite/file.c |8 +-
drivers/staging/lustre/lustre/llite/range_lock.c | 94 --
drivers/staging/lustre/lustre/llite/range_lock.h |
Moving this call results in all interval-tree handling code
being in the one file. This will simplify conversion to
use Linux interval trees.
The addition of 'struct cb' is a little ugly, but will be gone
is a subsequent patch.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/ldlm
as we need 64bit endpoints and it only provides "unsigned long".
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/llite/file.c |8 +-
drivers/staging/lustre/lustre/llite/range_lock.c | 94 --
drivers/staging/lustre/lustre/llite/range_lock.h |
Moving this call results in all interval-tree handling code
being in the one file. This will simplify conversion to
use Linux interval trees.
The addition of 'struct cb' is a little ugly, but will be gone
is a subsequent patch.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/ldlm
The name of the function lock_matches() sounds like it
performs a test (it does) and so should return a bool.
Returning a bool gives a slight code simplification (in
search_queue) and more simplification in future patches.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/ldlm
There are no remaining users for this library,
so discard it.
Signed-off-by: NeilBrown
---
.../staging/lustre/lustre/include/interval_tree.h | 119
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 590
drivers/staging/lustre/lustre/ptlrpc/Makefile |1
of spaces.
> staging: mt7621-spi: Add a space before open paranthesis.
> staging: mt7621-spi: Remove unnecessary braces {} from single
> statement if block.
>
Thanks,
All
Reviewed-by: NeilBrown
NeilBrown
signature.asc
Description: PGP signature
of spaces.
> staging: mt7621-spi: Add a space before open paranthesis.
> staging: mt7621-spi: Remove unnecessary braces {} from single
> statement if block.
>
Thanks,
All
Reviewed-by: NeilBrown
NeilBrown
signature.asc
Description: PGP signature
inux-mediatek off the
cc list. They are unlikely to be interested until the driver is ready
to be moved out of drivers/staging.
Thanks,
NeilBrown
>
> Abdun Nihaal (7):
> staging: mt7621-pci: Remove space after open parenthesis
> staging: mt7621-pci: remove trailing whitespace
>
inux-mediatek off the
cc list. They are unlikely to be interested until the driver is ready
to be moved out of drivers/staging.
Thanks,
NeilBrown
>
> Abdun Nihaal (7):
> staging: mt7621-pci: Remove space after open parenthesis
> staging: mt7621-pci: remove trailing whitespace
>
test, you could arrange
that OBD_OSC_VERSION(2, 10, 1, 0) evaluates to 0.
As ocd_version is unsigned, the comparison will always be false, and
the compiler will optimize the code away.
As a general rule, you need a very good reason to have #if or #ifdef in
.c files. They are usually OK in .h files.
Thanks,
NeilBrown
signature.asc
Description: PGP signature
test, you could arrange
that OBD_OSC_VERSION(2, 10, 1, 0) evaluates to 0.
As ocd_version is unsigned, the comparison will always be false, and
the compiler will optimize the code away.
As a general rule, you need a very good reason to have #if or #ifdef in
.c files. They are usually OK in .h files.
Thanks,
NeilBrown
signature.asc
Description: PGP signature
rule:
everything inside brackets must be to the right of the opening bracket
unless that opening bracket is at the end of a line.
Any of these would be acceptable - my personal preference is the second
one.
Thanks,
NeilBrown
> struct mt7621_spi;
>
> @@ -104,7 +105,7 @@ static vo
rule:
everything inside brackets must be to the right of the opening bracket
unless that opening bracket is at the end of a line.
Any of these would be acceptable - my personal preference is the second
one.
Thanks,
NeilBrown
> struct mt7621_spi;
>
> @@ -104,7 +105,7 @@ static vo
On Wed, May 30 2018, Trond Myklebust wrote:
> Hi Stephen,
>
> Thanks for noticing and apologies for missing that. I'll take that
> patch out until Neil can update it.
>
Thanks for noticing that Stephen,
I've sent and updated version.
Thanks,
NeilBrown
> Cheers
> Trond
On Wed, May 30 2018, Trond Myklebust wrote:
> Hi Stephen,
>
> Thanks for noticing and apologies for missing that. I'll take that
> patch out until Neil can update it.
>
Thanks for noticing that Stephen,
I've sent and updated version.
Thanks,
NeilBrown
> Cheers
> Trond
to
continue to look at the other delegation for the server as
we will never be able to get an active reference.
So instead of continuing in the inner loop, break out
and continue in the outer loop.
Signed-off-by: NeilBrown
---
This time with a Signed-off-by - sorry.
I took the opportunity to follow
to
continue to look at the other delegation for the server as
we will never be able to get an active reference.
So instead of continuing in the inner loop, break out
and continue in the outer loop.
Signed-off-by: NeilBrown
---
This time with a Signed-off-by - sorry.
I took the opportunity to follow
y reduce the number
of include files that were automatically included everywhere. Clearly
some config combinations didn't get tested properly.
Reviewed-by: NeilBrown
Thanks,
NeilBrown
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 1 +
> 1 file changed, 1 insertio
y reduce the number
of include files that were automatically included everywhere. Clearly
some config combinations didn't get tested properly.
Reviewed-by: NeilBrown
Thanks,
NeilBrown
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 1 +
> 1 file changed, 1 insertio
On Thu, May 31 2018, Sankalp Negi wrote:
> This patch fixes checkpatch.pl warning and check:
> WARNING: line over 80 characters
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Sankalp Negi
Reviewed-by: NeilBrown
Thanks,
NeilBrown
> ---
> Chan
On Thu, May 31 2018, Sankalp Negi wrote:
> This patch fixes checkpatch.pl warning and check:
> WARNING: line over 80 characters
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Sankalp Negi
Reviewed-by: NeilBrown
Thanks,
NeilBrown
> ---
> Chan
.whamcloud.com/18916
Nor does this review.
Thanks,
NeilBrown
> Reviewed-by: Olaf Weber
> Reviewed-by: Doug Oucharek
> Signed-off-by: James Simmons
> ---
> Changelog:
>
> v1) New patch to handle the disappearence of UMP support
>
> .../lustre/include/linux/libcfs/lib
.whamcloud.com/18916
Nor does this review.
Thanks,
NeilBrown
> Reviewed-by: Olaf Weber
> Reviewed-by: Doug Oucharek
> Signed-off-by: James Simmons
> ---
> Changelog:
>
> v1) New patch to handle the disappearence of UMP support
>
> .../lustre/include/linux/libcfs/lib
someone should probably find out exactly what sort of messages
ADDR2LINE produces, and make sure they are all parsed correctly.
(maybe that someone should be me, but not today).
Thanks,
NeilBrown
>
> Cc: Changbin Du
> Acked-by: Josh Poimboeuf
> Fixes: 6870c0165feaa
someone should probably find out exactly what sort of messages
ADDR2LINE produces, and make sure they are all parsed correctly.
(maybe that someone should be me, but not today).
Thanks,
NeilBrown
>
> Cc: Changbin Du
> Acked-by: Josh Poimboeuf
> Fixes: 6870c0165feaa
r your new version are indented properly.
Try to do more than just remove the warnings - try to make the code
beautiful!
Thanks,
NeilBrown
> {
> int ret;
>
> --
> 2.11.0
signature.asc
Description: PGP signature
r your new version are indented properly.
Try to do more than just remove the warnings - try to make the code
beautiful!
Thanks,
NeilBrown
> {
> int ret;
>
> --
> 2.11.0
signature.asc
Description: PGP signature
On Mon, May 21 2018, Patrick Farrell wrote:
> This, and the rest of the series, look good. Feel free to add a Reviewed-by.
Thanks a lot!
NeilBrown
signature.asc
Description: PGP signature
On Mon, May 21 2018, Patrick Farrell wrote:
> This, and the rest of the series, look good. Feel free to add a Reviewed-by.
Thanks a lot!
NeilBrown
signature.asc
Description: PGP signature
, but gets
the job done.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/curproc.h | 10 --
drivers/staging/lustre/lustre/llite/file.c |8 +++-
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/lust
, but gets
the job done.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/curproc.h | 10 --
drivers/staging/lustre/lustre/llite/file.c |8 +++-
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/cu
Some files didn't need it at all, others just needed
one or two includes.
Signed-off-by: NeilBrown <ne...@suse.com>
---
drivers/staging/lustre/lustre/ptlrpc/errno.c |1 -
drivers/staging/lustre/lustre/ptlrpc/events.c |2 +-
drivers/staging/lustre/lustre/ptlrpc/llog_cl
None of these files seem to nee libcfs_all.h
Signed-off-by: NeilBrown <ne...@suse.com>
---
drivers/staging/lustre/lustre/fid/fid_lib.c|1 -
drivers/staging/lustre/lustre/fid/fid_request.c|1 -
drivers/staging/lustre/lustre/fid/lproc_fid.c |1 -
drivers/staging/
In the remaining files that include libcfs_all.h,
replace it with other include files as necessary,
then remove libcfs_all.h
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_all.h | 88
drivers/staging/lustre/lnet/libcfs/d
Some files didn't need it at all, others just needed
one or two includes.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/ptlrpc/errno.c |1 -
drivers/staging/lustre/lustre/ptlrpc/events.c |2 +-
drivers/staging/lustre/lustre/ptlrpc/llog_client.c |2 --
drivers
None of these files seem to nee libcfs_all.h
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/fid/fid_lib.c|1 -
drivers/staging/lustre/lustre/fid/fid_request.c|1 -
drivers/staging/lustre/lustre/fid/lproc_fid.c |1 -
drivers/staging/lustre/lustre/fld
In the remaining files that include libcfs_all.h,
replace it with other include files as necessary,
then remove libcfs_all.h
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_all.h | 88
drivers/staging/lustre/lnet/libcfs/debug.c |5
Instead of the catch-all libcfs_all.h, just include the
files actually needed in different places.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_crypto.h|3 +++
.../staging/lustre/lustre/include/lprocfs_status.h |2 +-
drivers/staging/
Instead of the catch-all libcfs_all.h, just include the
files actually needed in different places.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_crypto.h|3 +++
.../staging/lustre/lustre/include/lprocfs_status.h |2 +-
drivers/staging/lustre/lustre/include
Most of these aren't needed, a few can be simplified.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/lustre/include/lustre_intent.h |2 ++
drivers/staging/lustre/lustre/ldlm/l_lock.c|1 -
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |1 -
d
Now no *.h files include libcfs_all.h - only *.c files.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_hash.h |3 +++
drivers/staging/lustre/lustre/fid/fid_internal.h |1 -
drivers/staging/lustre/lustre/fld/fld_internal.h |1 -
d
Some of these include files didn't need to
include libcfs_all.h. A couple did so replace with just the
base include files needed.
Signed-off-by: NeilBrown <ne...@suse.com>
---
drivers/staging/lustre/lnet/libcfs/tracefile.h |8 +++-
drivers/staging/lustre/lnet/selftest/conrpc.h
Again, most of these are not needed.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_string.h|2 ++
drivers/staging/lustre/lnet/lnet/lib-socket.c |1 -
drivers/staging/lustre/lnet/lnet/nidstrings.c |5 -
drivers/staging/
Now no *.h files include libcfs_all.h - only *.c files.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_hash.h |3 +++
drivers/staging/lustre/lustre/fid/fid_internal.h |1 -
drivers/staging/lustre/lustre/fld/fld_internal.h |1 -
drivers/staging/lustre
Some of these include files didn't need to
include libcfs_all.h. A couple did so replace with just the
base include files needed.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lnet/libcfs/tracefile.h |8 +++-
drivers/staging/lustre/lnet/selftest/conrpc.h |1 -
drivers
Again, most of these are not needed.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_string.h|2 ++
drivers/staging/lustre/lnet/lnet/lib-socket.c |1 -
drivers/staging/lustre/lnet/lnet/nidstrings.c |5 -
drivers/staging/lustre/lnet/lnet
Most of these aren't needed, a few can be simplified.
Signed-off-by: NeilBrown
---
.../staging/lustre/lustre/include/lustre_intent.h |2 ++
drivers/staging/lustre/lustre/ldlm/l_lock.c|1 -
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |1 -
drivers/staging/lustre
Use memalloc_noreclaim_save() and memalloc_noreclaim_restore(),
and for testing, just directly test the flag in current->flags
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_prim.h | 31
.../staging/lustre/lnet/klnd
We want to be more focused in what is included where.
So we remove libcfs.h from where it isn't needed.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_debug.h |1 +
.../lustre/include/linux/libcfs/libcfs_fail.h |3 +++
.../staging/
This file no longer contains enough content
to justify a separate file. So merge with
libcfs.h.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 12 -
.../lustre/include/linux/libcfs/libcfs_prim.h | 51
2
Use memalloc_noreclaim_save() and memalloc_noreclaim_restore(),
and for testing, just directly test the flag in current->flags
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_prim.h | 31
.../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c |
We want to be more focused in what is included where.
So we remove libcfs.h from where it isn't needed.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_debug.h |1 +
.../lustre/include/linux/libcfs/libcfs_fail.h |3 +++
.../staging/lustre/include/linux/lnet
This file no longer contains enough content
to justify a separate file. So merge with
libcfs.h.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 12 -
.../lustre/include/linux/libcfs/libcfs_prim.h | 51
2 files changed, 11
Both files that use this variable include tracefile.h, and it
seems a more suitable home for the declaration.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |5 -
drivers/staging/lustre/lnet/libcfs/tracefile.h |5 +
2
Other smaller include files are sufficient.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|1 -
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 -
.../lustre/lnet/klnds/socklnd/socklnd_lib.c|1 +
3 files chan
Other smaller include files are sufficient.
Signed-off-by: NeilBrown
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|1 -
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 -
.../lustre/lnet/klnds/socklnd/socklnd_lib.c|1 +
3 files changed, 1 insertion(+), 2
Both files that use this variable include tracefile.h, and it
seems a more suitable home for the declaration.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |5 -
drivers/staging/lustre/lnet/libcfs/tracefile.h |5 +
2 files changed, 5
These are network related on only used in lnet, so move
to lib-lnet.h
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |4
.../staging/lustre/include/linux/lnet/lib-lnet.h |4
2 files changed, 4 insertions(+), 4 del
This type is only used in libcfs/module.c, so make it local to there.
If any other module ever wanted to add its own symlinks,
it would probably be easiest to export lnet_debugfs_root
and just call debugfs_create_symlink as required.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../s
These are network related on only used in lnet, so move
to lib-lnet.h
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |4
.../staging/lustre/include/linux/lnet/lib-lnet.h |4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
This type is only used in libcfs/module.c, so make it local to there.
If any other module ever wanted to add its own symlinks,
it would probably be easiest to export lnet_debugfs_root
and just call debugfs_create_symlink as required.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux
every reference to libcfs.h to instead
include libcfs_all.h
Next several patches will remove that from various files
in small batches
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 48 ---
.../lustre/include/linux/libcfs/libcfs
every reference to libcfs.h to instead
include libcfs_all.h
Next several patches will remove that from various files
in small batches
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 48 ---
.../lustre/include/linux/libcfs/libcfs_all.h | 88
to mean
"continue". This requires a little bit of conversion.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 19 ++
drivers/staging/lustre/lnet/libcfs/module.c| 64
drivers/staging/lustre/ln
There is some confusion with names here - make it all uniform.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcf
There is some confusion with names here - make it all uniform.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
b/drivers/staging/lustre
to mean
"continue". This requires a little bit of conversion.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 19 ++
drivers/staging/lustre/lnet/libcfs/module.c| 64
drivers/staging/lustre/lnet/lnet/module.c
with current->blocked is
exactly what sigprocmask(SIG_BLOCK) does.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 16 ---
drivers/staging/lustre/lustre/include/lustre_lib.h | 21 +++-
drivers/staging/lust
different
purposes and of different durarions.
So discard CFS_TICK and lets each use-site just use whatever number
of jiffies seems appropriate in that case.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |5 -
.../staging/lustre/ln
This macro is only used for debug messages, so use
it to the debug code.
Also improve the documentation slightly.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |7 ---
.../lustre/include/linux/libcfs/libcfs_debug.h |7
with current->blocked is
exactly what sigprocmask(SIG_BLOCK) does.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 16 ---
drivers/staging/lustre/lustre/include/lustre_lib.h | 21 +++-
drivers/staging/lustre/lustre/ll
different
purposes and of different durarions.
So discard CFS_TICK and lets each use-site just use whatever number
of jiffies seems appropriate in that case.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |5 -
.../staging/lustre/lnet/klnds/socklnd/socklnd.h
This macro is only used for debug messages, so use
it to the debug code.
Also improve the documentation slightly.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |7 ---
.../lustre/include/linux/libcfs/libcfs_debug.h |7 +++
2 files changed, 7
replaces cfs_cap_t with kernel_cap_t throughout,
and where a cfs_cap_t was previous stored in a __u32, we now
store cap.cap[0] instead.
With this, we can remove include/linux/libcfs/curproc.h
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/curproc.h
This macro is only used once to test if a value is
a power of two. So use is_power_of_2() instead and
discard the macro.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/libcfs.h |2 --
drivers/staging/lustre/lnet/lnet/lib-eq.c |2
Just use current->pid and current->comm directly, instead
of having wrappers.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../staging/lustre/include/linux/libcfs/curproc.h |4
drivers/staging/lustre/lnet/libcfs/debug.c |2 +-
drivers/staging/lustre/lustre/ldlm
replaces cfs_cap_t with kernel_cap_t throughout,
and where a cfs_cap_t was previous stored in a __u32, we now
store cap.cap[0] instead.
With this, we can remove include/linux/libcfs/curproc.h
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/curproc.h | 69
This macro is only used once to test if a value is
a power of two. So use is_power_of_2() instead and
discard the macro.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |2 --
drivers/staging/lustre/lnet/lnet/lib-eq.c |2 +-
2 files changed, 1
Just use current->pid and current->comm directly, instead
of having wrappers.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/curproc.h |4
drivers/staging/lustre/lnet/libcfs/debug.c |2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
There is no longer any value in having this separate
subdirectory, so promote the files in it.
Also tidy the Makefile a little to use the common "*-obj-y"
macro name. This will allow individual files to be conditionally
compiled.
Signed-off-by: NeilBrown <ne...@suse.com>
---
There is no longer any value in having this separate
subdirectory, so promote the files in it.
Also tidy the Makefile a little to use the common "*-obj-y"
macro name. This will allow individual files to be conditionally
compiled.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/l
that cfs_cpt_tab can sometimes be NULL, so we need to
discard the assertion that it isn't.
Signed-off-by: NeilBrown <ne...@suse.com>
---
.../lustre/include/linux/libcfs/libcfs_cpu.h | 35 ++-
drivers/staging/lustre/lnet/libcfs/Makefile|2 -
drivers/staging/lustr
.
Thanks,
NeilBrown
---
NeilBrown (30):
staging: lustre: osc: tidy up osc_init()
staging: lustre: refactor libcfs initialization.
staging: lustre: move files out of lustre/lnet/libcfs/linux/
staging: lustre: rename cfs_cpt_table to cfs_cpt_tab
staging: lustre: remove
that cfs_cpt_tab can sometimes be NULL, so we need to
discard the assertion that it isn't.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_cpu.h | 35 ++-
drivers/staging/lustre/lnet/libcfs/Makefile|2 -
drivers/staging/lustre/lnet/libcfs/li
.
Thanks,
NeilBrown
---
NeilBrown (30):
staging: lustre: osc: tidy up osc_init()
staging: lustre: refactor libcfs initialization.
staging: lustre: move files out of lustre/lnet/libcfs/linux/
staging: lustre: rename cfs_cpt_table to cfs_cpt_tab
staging: lustre: remove
The variable "cfs_cpt_table" has the same name as
the structure "struct cfs_cpt_table".
This makes it hard to use #define to make one disappear
on a uni-processor build, but keep the other.
So rename the variable to cfs_cpt_tab.
Signed-off-by: NeilBrown <ne...@suse.com&g
dependencies when they are activated rather than when
they are loaded. Achieving that is a much larger job that would
have to progress in stages.
For now, this change ensures that if some initialization in libcfs
fails, other modules will fail-safe.
Signed-off-by: NeilBrown <ne...@suse.
-by: NeilBrown <ne...@suse.com>
---
drivers/staging/lustre/lustre/osc/osc_request.c | 29 +--
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c
b/drivers/staging/lustre/lustre/osc/osc_request.c
index 0038e555e905..0b5245
The variable "cfs_cpt_table" has the same name as
the structure "struct cfs_cpt_table".
This makes it hard to use #define to make one disappear
on a uni-processor build, but keep the other.
So rename the variable to cfs_cpt_tab.
Signed-off-by: NeilBrown
---
.../lustre/
dependencies when they are activated rather than when
they are loaded. Achieving that is a much larger job that would
have to progress in stages.
For now, this change ensures that if some initialization in libcfs
fails, other modules will fail-safe.
Signed-off-by: NeilBrown
---
.../staging
-by: NeilBrown
---
drivers/staging/lustre/lustre/osc/osc_request.c | 29 +--
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c
b/drivers/staging/lustre/lustre/osc/osc_request.c
index 0038e555e905..0b5245741e42 100644
to bioset_init()/mempool_init()
> bcache: convert to bioset_init()/mempool_init()
> md: convert to bioset_init()/mempool_init()
Hi Kent,
this conversion looks really good, thanks for Ccing me on it.
However as Shaohua Li is now the maintainer of md, it probably should
have gone to
to bioset_init()/mempool_init()
> bcache: convert to bioset_init()/mempool_init()
> md: convert to bioset_init()/mempool_init()
Hi Kent,
this conversion looks really good, thanks for Ccing me on it.
However as Shaohua Li is now the maintainer of md, it probably should
have gone to
601 - 700 of 4892 matches
Mail list logo
