Hi Dan, thanks for reviewing.
On Mon, 2019-05-06 at 18:20 +0300, Dan Carpenter wrote:
> On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -1740,7 +1740,8 @@ parse_rx_slots(struct vchiq_state *state)
> > >
.
Fixes: 852b2876a8a8 ("staging: vchiq: rework remove_event handling")
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface
: a772f116702e ("staging: vchiq: switch to wait_for_completion_killable")
Signed-off-by: Nicolas Saenz Julienne
This reverts commit a772f116702e3f0afdd7e6acadc1b8fb3b20b9ff.
---
.../interface/vchiq_arm/vchiq_arm.c | 21 ++-
.../interface/vchiq_arm/vc
("staging: vchiq_2835_arm: quit using custom
down_interruptible()")
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface
s
Nicolas Saenz Julienne (3):
staging: vchiq_2835_arm: revert "quit using custom
down_interruptible()"
staging: vchiq: revert "switch to wait_for_completion_killable"
staging: vchiq: make wait events interruptible
.../interface/vchiq_arm/vchiq_2835_arm.c |
-by: Nicolas Saenz Julienne
---
drivers/input/touchscreen/edt-ft5x06.c | 100 ++---
1 file changed, 72 insertions(+), 28 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c
b/drivers/input/touchscreen/edt-ft5x06.c
index 702bfda7ee77..e58645c72c2f 100644
--- a/drivers
Some devices might not provide an interrupt line for the touchscreen.
In that case the driver defaults to using a polled interface.
Signed-off-by: Nicolas Saenz Julienne
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 8 ++--
1 file changed, 6 insertions(+), 2 deletions
.
>
> Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
> Signed-off-by: Wen Yang
> Cc: Alan Tull
> Cc: Moritz Fischer
> Cc: Nicolas Saenz Julienne
> Cc: linux-f...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/
gt; ./drivers/firmware/stratix10-svc.c:1027:1-7: ERROR: missing of_node_put;
> acquired a node pointer with refcount incremented on line 1014, but without a
> corresponding object release within this function.
>
> Signed-off-by: Wen Yang
> Cc: Greg Kroah-Hartman
> Cc: Alan Tull
On Fri, 2019-04-05 at 15:02 +0300, Dan Carpenter wrote:
> On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote:
> > This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd.
> > ---
>
> Git kind of sets you up for failure with reverts...
>
> Fi
this criteria, as it's mainly used as an
interface to V4L2 and ALSA devices.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface
we follow through. If needed we can always go back to
killable. But at least we'll have a proper understanding on the actual
needs. In the end the driver is in staging, and the potential for errors
small.
Regards,
Nicolas
[1] https://github.com/raspberrypi/linux/issues/2881
---
Nicolas Saenz J
This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd.
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
This reverts commit a772f116702e3f0afdd7e6acadc1b8fb3b20b9ff.
---
.../interface/vchiq_arm/vchiq_arm.c | 21 ++-
.../interface/vchiq_arm/vchiq_core.c | 21 ++-
.../interface/vchiq_arm/vchiq_util.c | 6 +++---
3 files changed, 25
ed to
match Window's implementation, which follows 6.2.2.8.
In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.
Signed-off-by: Nicolas Saenz Julienne
---
v3->v4: - Use u8 instead of __u8
- Remove overly complex
Hi Oliver, thanks for the review!
On Wed, 2019-03-27 at 10:35 +0100, Oliver Neukum wrote:
> On Di, 2019-03-26 at 21:03 +0100, Nicolas Saenz Julienne wrote:
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -218,13 +218,14 @@ static unsigned hid_loo
Hi Terry, thanks for the review!
On Tue, 2019-03-26 at 22:43 +, Junge, Terry wrote:
> Hi Nicolas,
>
> This patch looks good except for one comment/question below.
>
> Thanks,
> Terry
>
> On Tuesday, March 26, 2019 1:04 PM Nicolas Saenz Julienne <
>
ed to
match Window's implementation, which follows 6.2.2.8.
In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.
Signed-off-by: Nicolas Saenz Julienne
---
v2->v3: - Update patch title
v1->v2: - Add usage conc
ed to
match Window's implementation, which follows 6.2.2.8.
In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.
Signed-off-by: Nicolas Saenz Julienne
---
v1->v2: - Add usage concatenation to hid_scan_main()
Hi Benjamin, Thanks for the review!
On Mon, 2019-03-25 at 16:08 +0100, Benjamin Tissoires wrote:
> On Mon, Mar 25, 2019 at 11:39 AM Benjamin Tissoires
> wrote:
> > Hi Nicolas,
> >
> > On Tue, Mar 12, 2019 at 10:37 AM Nicolas Saenz Julienne
> > wrote:
>
Hi Oliver, thanks for the review!
On Tue, 2019-03-19 at 12:01 +0100, Oliver Neukum wrote:
> On Mo, 2019-03-18 at 18:00 +0100, Nicolas Saenz Julienne wrote:
> > This patch clears "port_remote_wakeup" upon detecting a device
> > disconnection. Making sure the above me
ed to
match Window's implementation, which follows 6.2.2.8.
In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.
Signed-off-by: Nicolas Saenz Julienne
---
Note: A PR in hid-tools shoud show up anytime soon
drivers
On Fri, 2019-03-01 at 10:48 +0100, Benjamin Tissoires wrote:
> On Thu, Feb 28, 2019 at 7:01 PM Nicolas Saenz Julienne
> wrote:
> > On Thu, 2019-02-28 at 17:02 +, Junge, Terry wrote:
> > > This could also be a parser error. In the HID specification section
> >
ST)
> + select INPUT_POLLDEV
> help
> Say Y here if you have the official Raspberry Pi 7 inch screen on
> your system.
Thanks!
Looks good to me.
Reviewed-by: Nicolas Saenz Julienne
signature.asc
Description: This is a digitally signed message part
On Thu, 2019-02-28 at 17:02 +, Junge, Terry wrote:
> This could also be a parser error. In the HID specification section 6.2.2.8 it
> states that the last declared Usage Page is applied to Usages when the Main
> item is encountered.
>
> "If the bSize field = 1 or 2 then the Usage is
ting the offending report with a
correct one.
This was made thanks to the user's answers provided here, also full HID
descriptors are available there:
https://unix.stackexchange.com/questions/377830/linux-hid-driver-for-primax-wireless-keyboards/
Signed-off-by: Nicolas Saenz Julienne
---
NOTE: Thi
-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci-ring.c | 12
drivers/usb/host/xhci.c | 16
drivers/usb/host/xhci.h | 17 +
3 files changed, 45 insertions(+)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/x
Hi Felipe, thanks for the review!
On Wed, 2019-02-06 at 08:35 +0200, Felipe Balbi wrote:
> Hi,
>
> Nicolas Saenz Julienne writes:
> > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> > index 40fa25c4d041..a4efbe62a1a3 100644
> > --- a/d
us ones. I
can't seem to find a device that'll perform transfers with such small
packet sizes.
The implementation takes into account that the 8 byte buffers provided
by the URB will never cross a 64KB boundary.
Signed-off-by: Nicolas Saenz Julienne
---
Chages since first RFC:
- Got rid o
Hi Felipe, thanks for the review :)
On Fri, 2019-02-01 at 15:31 +0200, Felipe Balbi wrote:
> Hi,
>
> Nicolas Saenz Julienne writes:
> > Immediate data transfers (IDT) allow the HCD to copy small chunks of
> > data (up to 8bits) directly into its output trans
ontrolling the leds on
an XBOX controller. There where no disruptions on the rest of USB
devices attached on the system.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci-ring.c | 6 ++
drivers/usb/host/xhci.c | 37
drivers/usb/host/xhci.h
already take care of this issue, the
implementation was inspired from usbhid/hid_core.c's.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Oliver Neukum
---
v4:
- Add Oliver's Reviewed-by
- Make timeout calculation simpler
v3: As per Oliver's request:
- Take care of race condition
On Thu, 2018-12-20 at 10:39 -0800, Eric Anholt wrote:
> Nicolas Saenz Julienne writes:
>
> > Add's support to Raspberry Pi's 7" Touch device. Instead of using a
> > conventional bus all information is copied into a memory mapped
> > area by
> > RPi's firmware.
On Thu, 2018-12-20 at 18:36 +, Gordon Hollingworth wrote:
> Assuming this is using the firmware interface then yes it's fine. If
> it is using the i2c directly then it's possible to clash with the GPU
> driving the camera
Well we're already in such a situation without this patch, as the
This patch exposes backlight control into userspace by creating a
backlight device instead of directly accessing the PWM registers.
The backlight driver can't go on a separate file as it shares the I2C
bus & address with the panel.
Signed-off-by: Nicolas Saenz Julienne
---
v1 -> v2:
n AMD SNPS 3.0 xHC")
Reported-by: Oliver Neukum
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index c3515bad5dbb..011dd45f8718 100644
--- a/driver
This patch exposes backlight control into userspace by creating a
backlight device instead of directly accessing the PWM registers.
The backlight driver can't go on a separate file as it shares the I2C
bus & address with the panel.
Signed-off-by: Nicolas Saenz Julienne
---
.../drm/panel/p
There are no users for that header file.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 -
.../interface/vchiq_arm/vchiq_arm.c | 1 -
.../interface/vchiq_arm/vchiq_connected.c | 1 -
.../interface/vchiq_arm/vchiq_core.c | 1
letions instead of semaphores")
Reported-by: Arnd Bergmann
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 21 +--
.../interface/vchiq_arm/vchiq_core.c | 21 +--
.../interface/vchiq_arm/vchiq_util.c
vchi_killable.h overrides down_interruptible() by implementing a
function similar to down_killable(). To make things simpler we turn
calls to down_interruptible() into kernel's implementation of
down_killable().
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface
and gets
rid of vchiq_killable.h. I took into account Arnd's commit to avoid
merge conflicts.
[1] https://www.spinics.net/lists/arm-kernel/msg694422.html
===
Nicolas Saenz Julienne (3):
staging: vchiq: switch to wait_for_completion_killable
staging: vchiq_2835_arm: quit using custom
On Tue, 2018-12-11 at 15:20 +0100, Arnd Bergmann wrote:
> On Tue, Dec 11, 2018 at 1:36 PM Nicolas Saenz Julienne
> wrote:
> > On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote:
> > > @@ -447,26 +444,26 @@ remote_event_wait(VCHIQ_STATE_T *state,
> &
Hi Arnd, thanks for the patch!
On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote:
> I had started the removal of semaphores in this driver without
> knowing
> that Nicolas Saenz Julienne also worked on this. In case of the
> "remote
> event" infrastructure, my solu
On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote:
> On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> > Note that I'm changing it back to 'killable' after the previous
> > patch
> > changed 'killable' to 'interruptible', apparently based on a
> > misunderstanding
> > of the
Adds device tree documentation for Raspberry Pi's official 7"
touchscreen.
This binding is meant to be used as an overlay.
Signed-off-by: Nicolas Saenz Julienne
---
.../touchscreen/raspberrypi,firmware-ts.txt | 26 +++
1 file changed, 26 insertions(+)
create mode 1
g/pipermail/linux-rpi-kernel/2018-December/008444.html
===
Nicolas Saenz Julienne (2):
dt-bindings: input: Add Raspberry Pi Touchscreen
input: add official Raspberry Pi's touchscreen driver
.../touchscreen/raspberrypi,firmware-ts.txt | 26 ++
drivers/input/touchscreen/Kconfig |
Add's support to Raspberry Pi's 7" Touch device. Instead of using a
conventional bus all information is copied into a memory mapped area by
RPi's firmware.
Based on the driver found in RPi's kernel repository.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/input/touchscreen/Kc
Signed-off-by: Nicolas Saenz Julienne
---
drivers/gpio/gpio-raspberrypi-exp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-raspberrypi-exp.c
b/drivers/gpio/gpio-raspberrypi-exp.c
index d6d36d537e37..b77ea16ffa03 100644
--- a/drivers/gpio/gpio-raspberrypi-exp.c
+++ b/drivers
Adds device tree documentation for Raspberry Pi's official 7"
touchscreen.
Signed-off-by: Nicolas Saenz Julienne
---
.../touchscreen/raspberrypi,firmware-ts.txt | 26 +++
1 file changed, 26 insertions(+)
create mode 100644
Documentation/devicetree/bindings/input/touchs
Add's support to Raspberry Pi's 7" Touch device. Instead of using a
conventional bus all information is copied into a memory mapped area by
RPi's firmware.
Based on the driver found in RPi's kernel repository.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/input/touchscreen/Kc
l/linux-rpi-kernel/2018-December/008444.html
===
Nicolas Saenz Julienne (2):
input: add official Raspberry Pi's touchscreen driver
Input: raspberrypi-ts - add devicetree binding documentation
.../touchscreen/raspberrypi,firmware-ts.txt | 26 ++
drivers/input/touchscreen/Kconfig
Adds support to Raspberry Pi's 7" touchscreen device. Instead of using
a conventional bus all information is copied into a memory mapped area
by RPi's VC4 firmware.
Based on the driver found in RPi's downstream kernel repository.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/
Adds device tree documentation for Raspberry Pi's official 7"
touchscreen. The firmware mailbox interface allows the ARM core to
control the device.
Signed-off-by: Nicolas Saenz Julienne
---
.../touchscreen/raspberrypi,firmware-ts.txt | 25 +++
1 file changed, 25 inser
Adds support to Raspberry Pi's 7" touchscreen device. Instead of using
a conventional bus all information is copied into a memory mapped area
by RPi's VC4 firmware.
Based on the driver found in RPi's downstream kernel repository.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/
Adds device tree documentation for Raspberry Pi's official 7"
touchscreen. The firmware mailbox interface allows the ARM core to
control the device.
Signed-off-by: Nicolas Saenz Julienne
---
.../touchscreen/raspberrypi,firmware-ts.txt | 25 +++
1 file changed, 25 inser
a RPi 3 B+.
[1]
https://lists.infradead.org/pipermail/linux-rpi-kernel/2018-December/008444.html
===
Nicolas Saenz Julienne (2):
input: add official Raspberry Pi's 7" touchscreen driver
Input: raspberrypi-ts - add devicetree binding documentation
.../touchscreen/raspberrypi,fir
a RPi 3 B+.
[1]
https://lists.infradead.org/pipermail/linux-rpi-kernel/2018-December/008444.html
===
Nicolas Saenz Julienne (2):
input: add official Raspberry Pi's 7" touchscreen driver
Input: raspberrypi-ts - add devicetree binding documentation
.../touchscreen/raspberrypi,fir
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Nicolas Saenz Julienne
---
v1 -> v2: add actual people to CC & remove unnecessary braces
drivers/firmware/stratix10-svc.c |
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Nicolas Saenz Julienne
---
v1 -> v2: add actual people to CC & remove unnecessary braces
drivers/firmware/stratix10-svc.c |
Hi James, thanks for the review!
On Fri, 2018-11-30 at 18:31 +, James Morse wrote:
> Hi Nicolas,
>
> On 26/11/2018 12:15, Nicolas Saenz Julienne wrote:
> > After finding a "firmware" dt node arm_sdei tries to match it's
> > compatible string
Hi James, thanks for the review!
On Fri, 2018-11-30 at 18:31 +, James Morse wrote:
> Hi Nicolas,
>
> On 26/11/2018 12:15, Nicolas Saenz Julienne wrote:
> > After finding a "firmware" dt node arm_sdei tries to match it's
> > compatible string
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/stratix10-svc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/stra
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/stratix10-svc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/stra
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/fpga/stratix10-soc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/fpga/stratix10-
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/fpga/stratix10-soc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/fpga/stratix10-
y: Nicolas Saenz Julienne
---
drivers/w1/w1.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 890c038c25f8..09514fa6c6b9 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -680,15 +680,17 @@ static int w1_family_notify(unsigned l
y: Nicolas Saenz Julienne
---
drivers/w1/w1.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 890c038c25f8..09514fa6c6b9 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -680,15 +680,17 @@ static int w1_family_notify(unsigned l
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: ad6eb31ef903 ("firmware: arm_sdei: Add driver for Software Delegated
Exceptions")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/arm_sdei.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
e
again.
This patch removes the unwarranted call to of_node_put().
Fixes: ad6eb31ef903 ("firmware: arm_sdei: Add driver for Software Delegated
Exceptions")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/arm_sdei.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
ree semaphore to completion patches (commit 11)
- Update probe/init commit message (commit 14)
- Update TODO commit message and clean up (commit 16)
- Fix spelling on some of the patches
===
Nicolas Saenz Julienne (16):
staging: vchiq_core: rework vchiq_get_config
staging: vchiq_arm: rew
The resulting code is way more readeable and intuitive compared to plain
list_for_each.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 52 ++-
1 file changed, 16 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/vc04_services
ree semaphore to completion patches (commit 11)
- Update probe/init commit message (commit 14)
- Update TODO commit message and clean up (commit 16)
- Fix spelling on some of the patches
===
Nicolas Saenz Julienne (16):
staging: vchiq_core: rework vchiq_get_config
staging: vchiq_arm: rew
The resulting code is way more readeable and intuitive compared to plain
list_for_each.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 52 ++-
1 file changed, 16 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/vc04_services
The function is overly complicated for what it's ultimately achieving.
It's simply filling up a structure.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 12
.../interface/vchiq_arm/vchiq_core.c | 30 +--
.../interface
The function is overly complicated for what it's ultimately achieving.
It's simply filling up a structure.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 12
.../interface/vchiq_arm/vchiq_core.c | 30 +--
.../interface
ll the elements into memory as long as they fit".
The resulting function is shorter and simpler.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 89 +++
1 file changed, 31 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/vc0
ll the elements into memory as long as they fit".
The resulting function is shorter and simpler.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 89 +++
1 file changed, 31 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/vc0
vchiq_init_state() initialises a series of semaphores to then call
remote_event_create() on the same semaphores, which initializes them
again. We get rid of the second initialization.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 11
vchiq_init_state() initialises a series of semaphores to then call
remote_event_create() on the same semaphores, which initializes them
again. We get rid of the second initialization.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 11
".
There seems to be an option to switch roles in vchiq. Which nobody is
using nor is properly implemented. So we get rid of the "is_master == 1"
option, and all the related code.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 12 +-
.../in
".
There seems to be an option to switch roles in vchiq. Which nobody is
using nor is properly implemented. So we get rid of the "is_master == 1"
option, and all the related code.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 12 +-
.../in
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and
was meant to be used with bulk transfers. After a quick look in
vchiq_core.c it is pretty clear that it actually accomplishes nothing
nor alters the bulk transfers in any way.
Signed-off-by: Nicolas Saenz Julienne
It's the first thing remote_event_signal() does.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and
was meant to be used with bulk transfers. After a quick look in
vchiq_core.c it is pretty clear that it actually accomplishes nothing
nor alters the bulk transfers in any way.
Signed-off-by: Nicolas Saenz Julienne
It's the first thing remote_event_signal() does.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging
We update sync to reflect that the firmware version is compatible with
that option. We don't need to check both of them again further down the
code.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +---
1 file changed, 1 insertion
We update sync to reflect that the firmware version is compatible with
that option. We don't need to check both of them again further down the
code.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +---
1 file changed, 1 insertion
changed in between functions, making the checks useless.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging
changed in between functions, making the checks useless.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging
All the memory operations featured in this file modify/access memory
that is only accessed by the CPU. So we can assume that all the memory
barrier handling done by the completion routines is good enough for us.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_util.c
All the memory operations featured in this file modify/access memory
that is only accessed by the CPU. So we can assume that all the memory
barrier handling done by the completion routines is good enough for us.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_util.c
are semantically more explicit in this case.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 60 ++-
.../interface/vchiq_arm/vchiq_core.c | 100 +-
.../interface/vchiq_arm/vchiq_core.h | 26 ++---
.../interface/vchiq_arm
are semantically more explicit in this case.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 60 ++-
.../interface/vchiq_arm/vchiq_core.c | 100 +-
.../interface/vchiq_arm/vchiq_core.h | 26 ++---
.../interface/vchiq_arm
The TODO list was missing some tasks needed before upstreaming the
device.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/TODO | 42 +++
1 file changed, 42 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b
The TODO list was missing some tasks needed before upstreaming the
device.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/TODO | 42 +++
1 file changed, 42 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b
No one is using the API neither in the actual staging tree nor in the
downstream tree (https://github.com/raspberrypi/linux).
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 5 ---
.../interface/vchiq_arm/vchiq_shim.c | 32
Moves the allocation of a chardev region and class creation to the init
function of the driver since those functions are meant to be run on a
per driver basis, as opposed to the code run in the probe function which
is run in a per device basis.
Signed-off-by: Nicolas Saenz Julienne
No one is using the API neither in the actual staging tree nor in the
downstream tree (https://github.com/raspberrypi/linux).
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 5 ---
.../interface/vchiq_arm/vchiq_shim.c | 32
Moves the allocation of a chardev region and class creation to the init
function of the driver since those functions are meant to be run on a
per driver basis, as opposed to the code run in the probe function which
is run in a per device basis.
Signed-off-by: Nicolas Saenz Julienne
The implementation of both IOCTLS was the same except for one function
call. This joins both implementations and updates the code to avoid
unneeded indentations.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_arm.c | 66 +++
1 file changed, 24
901 - 1000 of 1177 matches
Mail list logo