Re: [PATCH v17 09/10] drm/panel: Use of_find_backlight helper

Den 19.01.2018 11.47, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- changes in v17: -remove put_device() to avoid double put

Re: [PATCH v17 09/10] drm/panel: Use of_find_backlight helper

Den 19.01.2018 11.47, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- changes in v17: -remove put_device() to avoid double put as we are using the devm

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Den 19.01.2018 12.05, skrev Daniel Thompson: On Fri, Jan 19, 2018 at 10:42:15AM +, Meghana Madhyastha wrote: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things.

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Den 19.01.2018 12.05, skrev Daniel Thompson: On Fri, Jan 19, 2018 at 10:42:15AM +, Meghana Madhyastha wrote: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things.

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

Den 18.01.2018 13.07, skrev Meghana Madhyastha: On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

Den 18.01.2018 13.07, skrev Meghana Madhyastha: On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

Den 17.01.2018 18.00, skrev Daniel Thompson: On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

Den 17.01.2018 18.00, skrev Daniel Thompson: On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code

Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

Den 16.01.2018 11.35, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha ---

Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

Den 16.01.2018 11.35, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha ---

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10 +++---

Re: [PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

ith that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

urn PTR_ERR(mipi->regulator); - mipi->backlight = of_find_backlight(dev); + mipi->backlight = devm_of_find_backlight(dev); if (IS_ERR(mipi->backlight)) return PTR_ERR(mipi->backlight); You've missed st7735r. With that fixed: Reviewed-by: Noralf Trønnes

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

: -:26: WARNING: Block comments should align the * on each line This one is text so might as well fix it: -:29: WARNING: line over 80 characters With that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/video/backlight/backlight.c | 29 + i

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

should align the * on each line This one is text so might as well fix it: -:29: WARNING: line over 80 characters With that fixed: Reviewed-by: Noralf Trønnes --- drivers/video/backlight/backlight.c | 29 + include/linux/backlight.h | 7 +++ 2 files

Re: [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

r work! With that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 -- drivers/gpu/drm/tinydrm/mi0283qt.c | 3 +- include/drm/tinydrm/tinydrm-helpers.h | 2 -- 3 files changed, 2 inser

Re: [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

rebasing, changes to mi0283qt. You've missed st7735r. I'd appreciate if you could also remove these from tinydrm/Kconfig:     select BACKLIGHT_LCD_SUPPORT     select BACKLIGHT_CLASS_DEVICE It's an ugly hack that we don't need anymore thanks to your work! With that fixed: Reviewed-by: Noralf

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Den 16.01.2018 11.33, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Den 16.01.2018 11.33, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha --- Changes in v16: -Add

Re: [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

o mipi-dbi. Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 55 -- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 +- include/drm/tinydrm/tinydrm-helpers.h | 2 - 3 files changed, 2 inser

Re: [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

Den 16.01.2018 11.32, skrev Meghana Madhyastha: Remove tinydrm_enable/disable_backlight and let the callers call the more generic backlight_enable/disable helpers Signed-off-by: Meghana Madhyastha This patch needs to be rebased on some recent changes to mipi-dbi. Reviewed-by: Noralf

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> checkpatch complains: -:23: WARNING: Block comments should align the * on each line -:45: ERROR: trailing whitespace With that fixed: Reviewed-by: Noralf Trønnes <nor...@tr

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha checkpatch complains: -:23: WARNING: Block comments should align the * on each line -:45: ERROR: trailing whitespace With that fixed: Reviewed-by: Noralf Trønnes --- include/linux/backlight.h | 30

Re: [PATCH v4 3/3] drm/tinydrm: add driver for ST7735R panels

.com> Reviewed-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Linus Walleij <linus.wall...@linaro.org> Thanks, series applied to drm-misc. Noralf.

Re: [PATCH v4 3/3] drm/tinydrm: add driver for ST7735R panels

Den 02.01.2018 10.42, skrev Linus Walleij: On Mon, Jan 1, 2018 at 8:02 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner Reviewed-by: Noralf Trønnes Reviewed-by:

Re: [PATCH 0/3] update compatible string for ILI9225

Den 21.12.2017 19.33, skrev David Lechner: This updates the device tree compatible string for an ILI9225 display. Detailed explanation is in the patches. David Lechner (3): dt-bindings: Add "vot" vendor prefix dt-bindings: update compatible string for ILI9225 drm/tinydrm: Update

Re: [PATCH 0/3] update compatible string for ILI9225

Den 21.12.2017 19.33, skrev David Lechner: This updates the device tree compatible string for an ILI9225 display. Detailed explanation is in the patches. David Lechner (3): dt-bindings: Add "vot" vendor prefix dt-bindings: update compatible string for ILI9225 drm/tinydrm: Update

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

Den 21.12.2017 20.35, skrev David Lechner: On 12/21/2017 01:23 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +    mipi_dbi_command(mipi,

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

Den 21.12.2017 20.35, skrev David Lechner: On 12/21/2017 01:23 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +    mipi_dbi_command(mipi, ST7735R_GAMCTRP1, 0x0f, 0x1a,

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

mple_display_pipe *pipe, + struct drm_crtc_state *crtc_state) This is confusing, you name the mode after the panel, but not the enable function which has an initialization sequence that is also panel specific. With .enable function named after the panel (and *_pipe_funcs): Revi

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

_crtc_state *crtc_state) This is confusing, you name the mode after the panel, but not the enable function which has an initialization sequence that is also panel specific. With .enable function named after the panel (and *_pipe_funcs): Reviewed-by: Noralf Trønnes +{ + struct tinydrm_d

Re: UDL's fbdev doesn't work for user-space apps

Den 04.12.2017 12.32, skrev Alexey Brodkin: Hello, I'm trying to use DisplayLink USB2.0-to-HDMI adapter as the one and only video output and I want to get Xserver working on top of that. I'm not very familiar with all the parts of Linux GPU/video stack (especially its user-space counterpart)

Re: UDL's fbdev doesn't work for user-space apps

Den 04.12.2017 12.32, skrev Alexey Brodkin: Hello, I'm trying to use DisplayLink USB2.0-to-HDMI adapter as the one and only video output and I want to get Xserver working on top of that. I'm not very familiar with all the parts of Linux GPU/video stack (especially its user-space counterpart)

Re: [PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels

Den 10.12.2017 23.10, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +static void st7735r_pipe_enable(struct drm_simple_display_pipe *pipe, +

Re: [PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels

Den 10.12.2017 23.10, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +static void st7735r_pipe_enable(struct drm_simple_display_pipe *pipe, +

Re: [PATCH v2 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

Den 10.12.2017 23.10, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner Acked-by: Rob Herring --- v2: changes: * None, but... I'm wondering about

Re: [PATCH v2 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

Den 10.12.2017 23.10, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner Acked-by: Rob Herring --- v2: changes: * None, but... I'm wondering about my choice of compatible here. I chose

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c +static struct

Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner --- .../bindings/display/sitronix,st7735r.txt | 35 ++ 1 file

Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner --- .../bindings/display/sitronix,st7735r.txt | 35 ++ 1 file changed, 35

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 06.12.2017 19.27, skrev Noralf Trønnes: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- diff --git a/driv

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 06.12.2017 19.27, skrev Noralf Trønnes: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/dr

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

(cc: Thierry) Den 01.12.2017 15.03, skrev Linus Walleij: On Wed, Nov 8, 2017 at 4:52 AM, David Lechner wrote: This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

(cc: Thierry) Den 01.12.2017 15.03, skrev Linus Walleij: On Wed, Nov 8, 2017 at 4:52 AM, David Lechner wrote: This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly marketed for Arduino. See

Re: [PATCH v2 0/4] DRM driver for ILI9225 display panels

Den 19.11.2017 21.12, skrev David Lechner: This is a new driver for ILI9225 based display panels. Thanks, applied to drm-misc. Noralf. v2 changes: * New patch for ilitek vendor prefix. * Use "ilitek" instead of "generic" in dt-bindings * New patch to export 2 mipi_dbi_* functions * Clean

Re: [PATCH v2 0/4] DRM driver for ILI9225 display panels

Den 19.11.2017 21.12, skrev David Lechner: This is a new driver for ILI9225 based display panels. Thanks, applied to drm-misc. Noralf. v2 changes: * New patch for ilitek vendor prefix. * Use "ilitek" instead of "generic" in dt-bindings * New patch to export 2 mipi_dbi_* functions * Clean

Re: [PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

echner <da...@lechnology.com> --- Reviewed-by: Noralf Trønnes <nor...@tronnes.org> v2 changes: * use exported mipi_dbi_* functions from patch 3/4 * new ili9225_command function MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 + drivers/gpu/dr

Re: [PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

echner --- Reviewed-by: Noralf Trønnes v2 changes: * use exported mipi_dbi_* functions from patch 3/4 * new ili9225_command function MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 + drivers/gpu/drm/tinydrm/Makefile | 1 + drivers/gpu/drm/tinydrm/i

Re: [PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

Den 19.11.2017 21.12, skrev David Lechner: This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner <da...@lechnology.com> --- Reviewed-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

Den 19.11.2017 21.12, skrev David Lechner: This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes v2 changes: * new patch in v2 drivers/gpu/drm/tinydrm

Re: [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

Den 15.11.2017 14.04, skrev Liviu Dudau: Hi, On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: Hi Liviu, Thank you for the patch. On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: drm_gem_cma_prime_import_sg_table() will fail if the number of entries in the

Re: [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

Den 15.11.2017 14.04, skrev Liviu Dudau: Hi, On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: Hi Liviu, Thank you for the patch. On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: drm_gem_cma_prime_import_sg_table() will fail if the number of entries in the

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

t; + * + * Lots of code copied from mipi-dbi.c + * Copyright 2016 Noralf Trønnes + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the Lic

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

rm/tinydrm/ili9225.c new file mode 100644 index 000..07e1b8b --- /dev/null +++ b/drivers/gpu/drm/tinydrm/ili9225.c @@ -0,0 +1,547 @@ +/* + * DRM driver for Ilitek ILI9225 panels + * + * Copyright 2017 David Lechner + * + * Lots of code copied from mipi-dbi.c + * Copyright 2016 Noralf Trønnes

Re: [PATCH v1 0/2] DRM driver for ILI9225 display panels

Hi David, nice to see a new driver. Den 08.11.2017 04.52, skrev David Lechner: This is a new driver for ILI9225 based display panels. There are a couple of things that stand out: 1. Despite my best efforts, I could not find a name for this display[1], so I have made up a generic name

Re: [PATCH v1 0/2] DRM driver for ILI9225 display panels

Hi David, nice to see a new driver. Den 08.11.2017 04.52, skrev David Lechner: This is a new driver for ILI9225 based display panels. There are a couple of things that stand out: 1. Despite my best efforts, I could not find a name for this display[1], so I have made up a generic name

Re: [Outreachy kernel] [PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

Den 16.10.2017 21.19, skrev Sean Paul: On Sun, Oct 15, 2017 at 01:58:23AM +0530, Harsha Sharma wrote: Replace use of list_for_each with list_for_each_entry to simplify the code and remove variables that are used only in list_for_each. Done with following coccinelle patch: @r@ identifier

Re: [Outreachy kernel] [PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

Den 16.10.2017 21.19, skrev Sean Paul: On Sun, Oct 15, 2017 at 01:58:23AM +0530, Harsha Sharma wrote: Replace use of list_for_each with list_for_each_entry to simplify the code and remove variables that are used only in list_for_each. Done with following coccinelle patch: @r@ identifier

Re: [PATCH v3] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Den 07.10.2017 00.17, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Thanks, applied to drm-misc. Noralf. Changes in v3: -Solve merge conflicts

Re: [PATCH v3] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Den 07.10.2017 00.17, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Thanks, applied to drm-misc. Noralf. Changes in v3: -Solve merge conflicts Changes in v2: -Fix alignment

Re: [PATCH v2] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Den 29.09.2017 09.48, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v2: -Fix alignment issues This patchfile is corrupt. Looks like you

Re: [PATCH v2] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Den 29.09.2017 09.48, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v2: -Fix alignment issues This patchfile is corrupt. Looks like you have manually edited the file.

Re: [PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

CK: Alignment should match open parenthesis #152: FILE: drivers/gpu/drm/tinydrm/repaper.c:995: +   DRM_DEV_ERROR(dev, "Failed to get thermal zone: %s\n",     thermal_zone); With that changed you can add to your next version: Reviewed-by: Noralf Trønnes

Re: [PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

: drivers/gpu/drm/tinydrm/repaper.c:995: +   DRM_DEV_ERROR(dev, "Failed to get thermal zone: %s\n",     thermal_zone); With that changed you can add to your next version: Reviewed-by: Noralf Trønnes return; } @@ -62

Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static

Den 16.08.2017 17.46, skrev David Lechner: On 08/16/2017 04:23 AM, Colin King wrote: From: Colin Ian King The function st7586_pipe_enable is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol

Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static

Den 16.08.2017 17.46, skrev David Lechner: On 08/16/2017 04:23 AM, Colin King wrote: From: Colin Ian King The function st7586_pipe_enable is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'st7586_pipe_enable' was not

Re: [PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 09.08.2017 19.59, skrev Noralf Trønnes: Den 07.08.2017 19.39, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <

Re: [PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 09.08.2017 19.59, skrev Noralf Trønnes: Den 07.08.2017 19.39, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner

Re: [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently use gem objects for framebuffer planes, the virtual create_handle() is not required. This change adds a struct drm_gem_object *gems[4] field to drm_framebuffer and removes create_handle() function pointer from

Re: [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently use gem objects for framebuffer planes, the virtual create_handle() is not required. This change adds a struct drm_gem_object *gems[4] field to drm_framebuffer and removes create_handle() function pointer from

Re: [PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

even I understand the pixel packing now :-) Now we wait for the DT maintainers to have their say. Reviewed-by: Noralf Trønnes <nor...@tronnes.org> v4 changes: * correct order for MAINTAINERS entry * Drop code not used by LEGO EV3 (regulator, backlight, suspend/resume) * Make gpios required * Use

Re: [PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

now :-) Now we wait for the DT maintainers to have their say. Reviewed-by: Noralf Trønnes v4 changes: * correct order for MAINTAINERS entry * Drop code not used by LEGO EV3 (regulator, backlight, suspend/resume) * Make gpios required * Use lookup table for pixel packing algorithm * Don't modify

Re: [PATCH v4 1/5] drm/tinydrm: Generalize tinydrm_xrgb8888_to_gray8()

Den 07.08.2017 19.39, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Return type is change to void to simplify error handling by callers. Signed-off-by:

Re: [PATCH v4 1/5] drm/tinydrm: Generalize tinydrm_xrgb8888_to_gray8()

Den 07.08.2017 19.39, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Return type is change to void to simplify error handling by callers. Signed-off-by:

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

Den 07.08.2017 12.22, skrev Laurent Pinchart: Hi Daniel, On Monday 07 Aug 2017 11:25:07 Daniel Vetter wrote: On Sat, Aug 05, 2017 at 12:59:07PM +0200, Noralf Trønnes wrote: Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt <e...@anholt.net> wrote: L

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

Den 07.08.2017 12.22, skrev Laurent Pinchart: Hi Daniel, On Monday 07 Aug 2017 11:25:07 Daniel Vetter wrote: On Sat, Aug 05, 2017 at 12:59:07PM +0200, Noralf Trønnes wrote: Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt wrote: Laurent Pinchart writes

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 05.08.2017 20.19, skrev Noralf Trønnes: Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 05.08.2017 20.19, skrev Noralf Trønnes: Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner --- MAINTAINERS

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner --- MAINTAINERS | 6 +

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

Den 05.08.2017 12.59, skrev Noralf Trønnes: (I had to switch to Daniel's Intel address to get this sent) Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt <e...@anholt.net> wrote: Laurent Pinchart <laurent.pinch...@ideasonboard.com> write

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

Den 05.08.2017 12.59, skrev Noralf Trønnes: (I had to switch to Daniel's Intel address to get this sent) Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt wrote: Laurent Pinchart writes: Hi Eric, (CC'ing Daniel) Thank you for the patch. On Tuesday 18

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

(I had to switch to Daniel's Intel address to get this sent) Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt wrote: Laurent Pinchart writes: Hi Eric, (CC'ing Daniel) Thank you for the patch. On

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

(I had to switch to Daniel's Intel address to get this sent) Den 05.08.2017 00.19, skrev Ilia Mirkin: On Fri, Aug 4, 2017 at 4:43 PM, Eric Anholt wrote: Laurent Pinchart writes: Hi Eric, (CC'ing Daniel) Thank you for the patch. On Tuesday 18 Jul 2017 14:05:06 Eric Anholt wrote: This

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Den 04.08.2017 18.51, skrev David Lechner: On 08/04/2017 04:48 AM, Noralf Trønnes wrote: Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Den 04.08.2017 18.51, skrev David Lechner: On 08/04/2017 04:48 AM, Noralf Trønnes wrote: Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Hi Laurent, Den 04.08.2017 16.54, skrev Laurent Pinchart: Hi David, Thank you for the patch. On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Hi Laurent, Den 04.08.2017 16.54, skrev Laurent Pinchart: Hi David, Thank you for the patch. On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel

Re: [PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

Den 04.08.2017 09.27, skrev Noralf Trønnes: Den 04.08.2017 00.33, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner <

Re: [PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

Den 04.08.2017 09.27, skrev Noralf Trønnes: Den 04.08.2017 00.33, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner

Re: [PATCH v3 1/6] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

Den 04.08.2017 00.33, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Suggested-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: David Lechner <da...@lechnology.com&

Re: [PATCH v3 1/6] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

Den 04.08.2017 00.33, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Suggested-by: Noralf Trønnes Signed-off-by: David Lechner Reviewed-by: Noralf Trønnes --- Thanks, applied

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO MINDSTORMS EV3. Is this display available outside of

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO MINDSTORMS EV3. Is this display available outside of

Re: [PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

Den 04.08.2017 00.33, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner ---

Re: [PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

Den 04.08.2017 00.33, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c |

<    1   2   3   4   5   6   7   8   9   >