Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 00.41, skrev David Lechner: On 08/01/2017 03:14 PM, David Lechner wrote: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 00.41, skrev David Lechner: On 08/01/2017 03:14 PM, David Lechner wrote: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 03.08.2017 19.11, skrev Andy Shevchenko: On Thu, Aug 3, 2017 at 8:09 PM, Andy Shevchenko wrote: On Thu, Aug 3, 2017 at 6:18 PM, David Lechner wrote: The particular display I have is this one:

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 03.08.2017 19.11, skrev Andy Shevchenko: On Thu, Aug 3, 2017 at 8:09 PM, Andy Shevchenko wrote: On Thu, Aug 3, 2017 at 6:18 PM, David Lechner wrote: The particular display I have is this one: http://wiki.seeed.cc/Grove-OLED_Display_1.12inch/ It looks like it uses a command/data scheme

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt <e...@anholt.net> ---

Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt --- Acked-by: Nora

Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

2017-08-03 Thread Noralf Trønnes
> --- Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/gpu/drm/vc4/vc4_dsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 13481bb6322f..d1e0dc908048 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers

Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: drm_bridge_remove() is for unregistering a bridge driver, not for detaching a bridge from its consumer. Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.") Signed-off-by: Eric Anholt --- Acked-

Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

2017-08-02 Thread Noralf Trønnes
ev, vc4->hang_state); - - vc4_bo_cache_destroy(dev); } I don't have a display connected, but there's no crashing anymore. Tested-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

2017-08-02 Thread Noralf Trønnes
ache_destroy(dev); } I don't have a display connected, but there's no crashing anymore. Tested-by: Noralf Trønnes Acked-by: Noralf Trønnes

Re: [PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Also fixed order of @dc parameter in the doc comment. Suggested-by: Noralf Trønnes <nor...@tronnes.org> Sign

Re: [PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Also fixed order of @dc parameter in the doc comment. Suggested-by: Noralf Trønnes Signed-off-by: David Lechner

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-02 Thread Noralf Trønnes
Den 01.08.2017 22.14, skrev David Lechner: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner <da...@lechnology.com> --- Reviewed-by:

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-02 Thread Noralf Trønnes
Den 01.08.2017 22.14, skrev David Lechner: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes drivers

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 18.24, skrev David Lechner: On 08/02/2017 08:03 AM, Noralf Trønnes wrote: Please use tinydrm_xrgb_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. Yes, you're right about that. Can you change

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 18.24, skrev David Lechner: On 08/02/2017 08:03 AM, Noralf Trønnes wrote: Please use tinydrm_xrgb_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. Yes, you're right about that. Can you change

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt | 26 + I

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt | 26 +

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-01 Thread Noralf Trønnes
(cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-01 Thread Noralf Trønnes
(cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-07-30 Thread Noralf Trønnes
Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. But, most of the content here is building up the infrastructure to do that. Some general comments/questions: I

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-07-30 Thread Noralf Trønnes
Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. But, most of the content here is building up the infrastructure to do that. Some general comments/questions: I

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-07-30 Thread Noralf Trønnes
Hi David, I'm glad to see a new tinydrm driver! Den 29.07.2017 21.17, skrev David Lechner: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. But, most of the content here is building up the infrastructure to do that. The controller used in the EV3 uses

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-07-30 Thread Noralf Trønnes
Hi David, I'm glad to see a new tinydrm driver! Den 29.07.2017 21.17, skrev David Lechner: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. But, most of the content here is building up the infrastructure to do that. The controller used in the EV3 uses

Re: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency

2017-07-29 Thread Noralf Trønnes
Den 27.07.2017 11.58, skrev Arnd Bergmann: The new RePaper driver uses the thermal subsystem, and fails to link when it is built-in but thermal is a loadable module: drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe': repaper.c:(.text+0x540): undefined reference to

Re: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency

2017-07-29 Thread Noralf Trønnes
Den 27.07.2017 11.58, skrev Arnd Bergmann: The new RePaper driver uses the thermal subsystem, and fails to link when it is built-in but thermal is a loadable module: drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe': repaper.c:(.text+0x540): undefined reference to

Re: [PATCH v2] drm: hdlcd: Update PM code to save/restore console.

2017-06-19 Thread Noralf Trønnes
Den 19.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Changelog: - v2: Use drm_fbdev_cma_set_suspend_unlocked() function for taking the console lock (suggested by Noralf Trønnes <nor...@tronnes.org>) - v1: Initial submission [1] [1]

Re: [PATCH v2] drm: hdlcd: Update PM code to save/restore console.

2017-06-19 Thread Noralf Trønnes
Den 19.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Changelog: - v2: Use drm_fbdev_cma_set_suspend_unlocked() function for taking the console lock (suggested by Noralf Trønnes ) - v1: Initial submission [1] [1] https

Re: [PATCH] drm: hdlcd: Update PM code to save/restore console.

2017-06-19 Thread Noralf Trønnes
Den 19.06.2017 15.17, skrev Liviu Dudau: On Fri, Jun 16, 2017 at 06:58:36PM +0200, Noralf Trønnes wrote: Den 16.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/d

Re: [PATCH] drm: hdlcd: Update PM code to save/restore console.

2017-06-19 Thread Noralf Trønnes
Den 19.06.2017 15.17, skrev Liviu Dudau: On Fri, Jun 16, 2017 at 06:58:36PM +0200, Noralf Trønnes wrote: Den 16.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 11

Re: [PATCH] drm: hdlcd: Update PM code to save/restore console.

2017-06-16 Thread Noralf Trønnes
Den 16.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm: hdlcd: Update PM code to save/restore console.

2017-06-16 Thread Noralf Trønnes
Den 16.06.2017 15.53, skrev Liviu Dudau: Update the PM code to suspend/resume the fbdev_cma console. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c

Re: [PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-12 Thread Noralf Trønnes
Den 12.05.2017 01.56, skrev Eric Anholt: BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel clocks, so to support panels on the Raspberry Pi we need to set a higher pixel clock rate than requested and adjust the mode we program to extend out the HFP so that the refresh rate

Re: [PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-12 Thread Noralf Trønnes
Den 12.05.2017 01.56, skrev Eric Anholt: BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel clocks, so to support panels on the Raspberry Pi we need to set a higher pixel clock rate than requested and adjust the mode we program to extend out the HFP so that the refresh rate

Re: [PATCH] tinydrm: mipi-dbi: Adjust buffer output in mipi_dbi_debugfs_command_show()

2017-05-10 Thread Noralf Trønnes
quot;) Suggested-by: Joe Perches <j...@perches.com> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- Thanks again, Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/gpu/drm/tinydrm/mipi-dbi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

Re: [PATCH] tinydrm: mipi-dbi: Adjust buffer output in mipi_dbi_debugfs_command_show()

2017-05-10 Thread Noralf Trønnes
Signed-off-by: Markus Elfring --- Thanks again, Acked-by: Noralf Trønnes drivers/gpu/drm/tinydrm/mipi-dbi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index f4eb412f3604..2670259d1798 100644

Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()

2017-05-09 Thread Noralf Trønnes
etected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- Thanks, Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/m

Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()

2017-05-09 Thread Noralf Trønnes
Signed-off-by: Markus Elfring --- Thanks, Acked-by: Noralf Trønnes drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index f4eb412f3604..54d66b732d55 100644 --- a/drive

Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-04-12 Thread Noralf Trønnes
Den 11.04.2017 07.29, skrev Laurent Pinchart: Hi Noralf, On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen

Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-04-12 Thread Noralf Trønnes
Den 11.04.2017 07.29, skrev Laurent Pinchart: Hi Noralf, On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-03-08 Thread Noralf Trønnes
Den 07.03.2017 23.21, skrev Daniel Vetter: On Sat, Feb 11, 2017 at 07:48:52PM +0100, Noralf Trønnes wrote: +const struct file_operations tinydrm_fops = { + .owner = THIS_MODULE, + .open = drm_open, + .release= drm_release, + .unlocked_ioctl

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-03-08 Thread Noralf Trønnes
Den 07.03.2017 23.21, skrev Daniel Vetter: On Sat, Feb 11, 2017 at 07:48:52PM +0100, Noralf Trønnes wrote: +const struct file_operations tinydrm_fops = { + .owner = THIS_MODULE, + .open = drm_open, + .release= drm_release, + .unlocked_ioctl

Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

2017-03-02 Thread Noralf Trønnes
Den 02.03.2017 14.04, skrev simran singhal: This patch fixes the following sparse warnings: drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-bus.c:166:36:expected unsigned short [unsigned] [short]

Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

2017-03-02 Thread Noralf Trønnes
Den 02.03.2017 14.04, skrev simran singhal: This patch fixes the following sparse warnings: drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-bus.c:166:36:expected unsigned short [unsigned] [short]

Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-26 Thread Noralf Trønnes
Den 23.02.2017 14.29, skrev Noralf Trønnes: BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---

Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-26 Thread Noralf Trønnes
Den 23.02.2017 14.29, skrev Noralf Trønnes: BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes --- Please apply this, it causes

Re: [PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
I see that I forgot cc'ing Dave Airlie on this, and I just realised that the backlight problem isn't just a warning, but it actually causes a build failure if backlight is built as a module. I missed this in my hurry to get this out the door, sorry. Den 23.02.2017 14.29, skrev Noralf Trønnes

Re: [PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
I see that I forgot cc'ing Dave Airlie on this, and I just realised that the backlight problem isn't just a warning, but it actually causes a build failure if backlight is built as a module. I missed this in my hurry to get this out the door, sorry. Den 23.02.2017 14.29, skrev Noralf Trønnes

[PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-23 Thread Noralf Trønnes
BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- include/drm/tinydrm/tinydrm-helpers.

[PATCH 2/3] drm/tinydrm: mipi-dbi: Fix field width specifier warning

2017-02-23 Thread Noralf Trønnes
OMMAND(). There is no chance of overflow. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index 2caecde..2d2

[PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-23 Thread Noralf Trønnes
BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes --- include/drm/tinydrm/tinydrm-helpers.h | 19 --- 1 file changed

[PATCH 2/3] drm/tinydrm: mipi-dbi: Fix field width specifier warning

2017-02-23 Thread Noralf Trønnes
OMMAND(). There is no chance of overflow. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index 2caecde..2d21b49 100644 --- a/drivers/

[PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
T_DRIVER, fmt, ##__VA_ARGS__) ^~~ >> drivers/gpu/drm/tinydrm/mipi-dbi.c:671:2: note: in expansion of macro >> 'MIPI_DBI_DEBUG_COMMAND' MIPI_DBI_DEBUG_COMMAND(cmd, parameters, num); ^~~~~~ Noralf. Noralf Trønnes (3): drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used un

[PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
T_DRIVER, fmt, ##__VA_ARGS__) ^~~ >> drivers/gpu/drm/tinydrm/mipi-dbi.c:671:2: note: in expansion of macro >> 'MIPI_DBI_DEBUG_COMMAND' MIPI_DBI_DEBUG_COMMAND(cmd, parameters, num); ^~~~~~ Noralf. Noralf Trønnes (3): drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used un

[PATCH 1/3] drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized

2017-02-23 Thread Noralf Trønnes
); ^~ cmd can't be used uninitialized, but to satisfy the compiler, initialize it to zero. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH 1/3] drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized

2017-02-23 Thread Noralf Trønnes
); ^~ cmd can't be used uninitialized, but to satisfy the compiler, initialize it to zero. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c

Re: [PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.50, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes <nor...@tronnes.org> wrote: Add common functionality needed by many tinydrm drivers. +int tinydrm_enable_backlight(struct backlight_device *backlight) +{ + unsigned int old_state; + i

Re: [PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.50, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes wrote: Add common functionality needed by many tinydrm drivers. +int tinydrm_enable_backlight(struct backlight_device *backlight) +{ + unsigned int old_state; + int ret

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.05, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes <nor...@tronnes.org> wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. +/** + * tinydrm_gem_cma_free_object - Free res

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.05, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. +/** + * tinydrm_gem_cma_free_object - Free resources associated with a CMA

[PATCH v4 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-11 Thread Noralf Trønnes
Add support for MIPI DBI compatible controllers. Interface type C option 1 and 3 are supported (SPI). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since version 3: - Use #if IS_ENABLED(CONFIG_SPI) instead of #ifd

[PATCH v4 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-11 Thread Noralf Trønnes
Add support for MIPI DBI compatible controllers. Interface type C option 1 and 3 are supported (SPI). Signed-off-by: Noralf Trønnes Acked-by: Thierry Reding --- Changes since version 3: - Use #if IS_ENABLED(CONFIG_SPI) instead of #ifdef to handle tristate Documentation/gpu/tinydrm.rst

[PATCH v4 4/7] of: Add vendor prefix for Multi-Inno

2017-02-11 Thread Noralf Trønnes
Multi-Inno Technology Co.,Ltd is a Hong Kong based company offering LCD, LCD module products and complete panel solutions. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 fil

[PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Thierry Reding <tred...@nvidia.com> --- Chang

[PATCH v4 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display

2017-02-11 Thread Noralf Trønnes
Add driver to support the Multi-Inno MI0283QT display panel. It has an ILI9341 MIPI DBI compatible display controller. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry Reding <tred...@nvidia.com> --- MAINTAINERS| 6 + drivers/gpu/drm/tin

[PATCH v4 4/7] of: Add vendor prefix for Multi-Inno

2017-02-11 Thread Noralf Trønnes
Multi-Inno Technology Co.,Ltd is a Hong Kong based company offering LCD, LCD module products and complete panel solutions. Signed-off-by: Noralf Trønnes Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Acked-by: Thierry Reding --- Changes since version 3: - Rebase on new drm_fbdev_cma_init_with_funcs() signature

[PATCH v4 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display

2017-02-11 Thread Noralf Trønnes
Add driver to support the Multi-Inno MI0283QT display panel. It has an ILI9341 MIPI DBI compatible display controller. Signed-off-by: Noralf Trønnes Acked-by: Thierry Reding --- MAINTAINERS| 6 + drivers/gpu/drm/tinydrm/Kconfig| 8 ++ drivers/gpu/drm/tinydrm

[PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-02-11 Thread Noralf Trønnes
Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen because that's what fbdev and drm use. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry

[PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-11 Thread Noralf Trønnes
Add common functionality needed by many tinydrm drivers. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since version 3: - Fix backlight dependency by selecting it -

[PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-02-11 Thread Noralf Trønnes
Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen because that's what fbdev and drm use. Signed-off-by: Noralf Trønnes Acked-by: Thierry Reding --- Changes since

[PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-11 Thread Noralf Trønnes
Add common functionality needed by many tinydrm drivers. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Acked-by: Thierry Reding --- Changes since version 3: - Fix backlight dependency by selecting it - Use #if IS_ENABLED(CONFIG_SPI) instead of #ifdef to handle tristate Documentation

[PATCH v4 0/7] drm: Add support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
rm module to the driver using a helper macro: TINYDRM_DRM_DRIVER. - Remove dirtyfb() async code. - Added support for partial display updates. Noralf Trønnes (7): drm: Add DRM support for tiny LCD displays drm/tinydrm: Add helper functions drm/tinydrm: Add MIPI DBI support of: Add vendor prefix for M

[PATCH v4 6/7] dt-bindings: Add Multi-Inno MI0283QT binding

2017-02-11 Thread Noralf Trønnes
Add device-tree binding documentation for the MI0283QT display panel. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/multi-inno,mi0283qt.txt | 27 ++ 1 file changed, 27 insertions(+)

[PATCH v4 6/7] dt-bindings: Add Multi-Inno MI0283QT binding

2017-02-11 Thread Noralf Trønnes
Add device-tree binding documentation for the MI0283QT display panel. Signed-off-by: Noralf Trønnes Acked-by: Rob Herring --- .../bindings/display/multi-inno,mi0283qt.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 0/7] drm: Add support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
rm module to the driver using a helper macro: TINYDRM_DRM_DRIVER. - Remove dirtyfb() async code. - Added support for partial display updates. Noralf Trønnes (7): drm: Add DRM support for tiny LCD displays drm/tinydrm: Add helper functions drm/tinydrm: Add MIPI DBI support of: Add vendor prefix for M

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 16.53, skrev Daniel Vetter: On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding wrote:

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 16.53, skrev Daniel Vetter: On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding wrote: +EXPORT_SYMBOL(tinydrm_disable_backlight); +#endif These look

Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 10.17, skrev Thierry Reding: On Tue, Jan 31, 2017 at 05:03:13PM +0100, Noralf Trønnes wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by:

Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 10.17, skrev Thierry Reding: On Tue, Jan 31, 2017 at 05:03:13PM +0100, Noralf Trønnes wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Changes

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Noralf Trønnes
(Adding Maxime) Den 06.02.2017 13.34, skrev Andrzej Hajda: On 06.02.2017 12:53, Thierry Reding wrote: On Mon, Feb 06, 2017 at 01:30:09PM +0200, Jani Nikula wrote: On Mon, 06 Feb 2017, Thierry Reding <thierry.red...@gmail.com> wrote: On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf T

Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-06 Thread Noralf Trønnes
(Adding Maxime) Den 06.02.2017 13.34, skrev Andrzej Hajda: On 06.02.2017 12:53, Thierry Reding wrote: On Mon, Feb 06, 2017 at 01:30:09PM +0200, Jani Nikula wrote: On Mon, 06 Feb 2017, Thierry Reding wrote: On Tue, Jan 31, 2017 at 05:03:15PM +0100, Noralf Trønnes wrote: Add support for MIPI

Re: [PATCH 2/2] drm/panel: Add driver for sitronix ST7789V panel

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 11.50, skrev Maxime Ripard: Hi Noralf, On Fri, Feb 03, 2017 at 07:53:58PM +0100, Noralf Trønnes wrote: Den 03.02.2017 10.59, skrev Maxime Ripard: Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> --- drivers/gpu/drm/panel/Kconfig

Re: [PATCH 2/2] drm/panel: Add driver for sitronix ST7789V panel

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 11.50, skrev Maxime Ripard: Hi Noralf, On Fri, Feb 03, 2017 at 07:53:58PM +0100, Noralf Trønnes wrote: Den 03.02.2017 10.59, skrev Maxime Ripard: Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig | 4 +- drivers/gpu/drm/panel/Makefile

Re: [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 11.39, skrev Maxime Ripard: Hi Noralf, On Fri, Feb 03, 2017 at 07:48:51PM +0100, Noralf Trønnes wrote: Den 03.02.2017 10.59, skrev Maxime Ripard: Hi, Here is an attempt at supporting the ST7789V LCD controller from Sitronix. What happens if there's another panel driven

Re: [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 11.39, skrev Maxime Ripard: Hi Noralf, On Fri, Feb 03, 2017 at 07:48:51PM +0100, Noralf Trønnes wrote: Den 03.02.2017 10.59, skrev Maxime Ripard: Hi, Here is an attempt at supporting the ST7789V LCD controller from Sitronix. What happens if there's another panel driven

Re: [PATCH 2/2] drm/panel: Add driver for sitronix ST7789V panel

2017-02-03 Thread Noralf Trønnes
Den 03.02.2017 10.59, skrev Maxime Ripard: Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig | 4 +- drivers/gpu/drm/panel/Makefile | 1 +- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 435

Re: [PATCH 2/2] drm/panel: Add driver for sitronix ST7789V panel

2017-02-03 Thread Noralf Trønnes
Den 03.02.2017 10.59, skrev Maxime Ripard: Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig | 4 +- drivers/gpu/drm/panel/Makefile | 1 +- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 435 ++- 3 files changed, 440

Re: [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V

2017-02-03 Thread Noralf Trønnes
Den 03.02.2017 10.59, skrev Maxime Ripard: Hi, Here is an attempt at supporting the ST7789V LCD controller from Sitronix. What happens if there's another panel driven by ST7789V that needs a different controller initialization? Maybe it's better to name it after the panel, not the

Re: [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V

2017-02-03 Thread Noralf Trønnes
Den 03.02.2017 10.59, skrev Maxime Ripard: Hi, Here is an attempt at supporting the ST7789V LCD controller from Sitronix. What happens if there's another panel driven by ST7789V that needs a different controller initialization? Maybe it's better to name it after the panel, not the

Re: [PATCH v3 5/7] dt-bindings: display: Add common rotation property

2017-02-03 Thread Noralf Trønnes
Thierry, please have a look at this. In which direction should we rotate to match how drm rotation works? Den 01.02.2017 18.41, skrev Rob Herring: On Tue, Jan 31, 2017 at 05:03:17PM +0100, Noralf Trønnes wrote: Display panels can be oriented many ways, especially in the embedded world

Re: [PATCH v3 5/7] dt-bindings: display: Add common rotation property

2017-02-03 Thread Noralf Trønnes
Thierry, please have a look at this. In which direction should we rotate to match how drm rotation works? Den 01.02.2017 18.41, skrev Rob Herring: On Tue, Jan 31, 2017 at 05:03:17PM +0100, Noralf Trønnes wrote: Display panels can be oriented many ways, especially in the embedded world

Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

2017-01-31 Thread Noralf Trønnes
Den 31.01.2017 17.23, skrev Daniel Vetter: On Tue, Jan 31, 2017 at 05:03:13PM +0100, Noralf Trønnes wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by:

Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

2017-01-31 Thread Noralf Trønnes
Den 31.01.2017 17.23, skrev Daniel Vetter: On Tue, Jan 31, 2017 at 05:03:13PM +0100, Noralf Trønnes wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter I spotted

<    1   2   3   4   5   6   7   8   9   >